* Re: [PATCH 3/6] sysfs: Implement sysfs tagged directory support.
From: Tejun Heo @ 2010-03-31 6:49 UTC (permalink / raw)
To: Eric W. Biederman
Cc: Greg Kroah-Hartman, Kay Sievers, linux-kernel, Cornelia Huck,
linux-fsdevel, Eric Dumazet, Benjamin LaHaise, Serge Hallyn,
netdev, Benjamin Thery
In-Reply-To: <1269973889-25260-3-git-send-email-ebiederm@xmission.com>
Hello, Eric.
On 03/31/2010 03:31 AM, Eric W. Biederman wrote:
> What this patch does is to add an additional tag field to the
> sysfs dirent structure. For directories that should show different
> contents depending on the context such as /sys/class/net/, and
> /sys/devices/virtual/net/ this tag field is used to specify the
> context in which those directories should be visible. Effectively
> this is the same as creating multiple distinct directories with
> the same name but internally to sysfs the result is nicer.
This has become a long running project. :-)
The way to implement partial visibility seems much cleaner now and I
don't have any objection. Thanks for cleaning up the whole sysfs and
implementing this properly. Unfortunately, I still feel quite
uncomfortable about how the scope of visibility is determined and how
deep knowledge about specific namespace implementation seeps down to
kobject / sysfs layer. It almost looks like a gross layering
violation.
Is it at all possible to implement it in properly layered manner?
ie. sysfs providing mechanisms for selective visibility, driver model
wraps it and exports it and namespace implements namespaces on top of
those mechanisms? I can see that there should be some interaction
between the driver model and namespaces but I can't see why that
information should be visible deep down in kobject and sysfs.
Thanks.
--
tejun
^ permalink raw reply
* Re: [PATCH 2/3] can: add support for Janz VMOD-ICAN3 Intelligent CAN module
From: David Miller @ 2010-03-31 6:46 UTC (permalink / raw)
To: wg; +Cc: iws, linux-kernel, socketcan-core, netdev, sameo
In-Reply-To: <4BB1B2DA.60002@grandegger.com>
From: Wolfgang Grandegger <wg@grandegger.com>
Date: Tue, 30 Mar 2010 10:14:18 +0200
> Ira W. Snyder wrote:
>> The Janz VMOD-ICAN3 is a MODULbus daughterboard which fits onto any
>> MODULbus carrier board. It is an intelligent CAN controller with a
>> microcontroller and associated firmware.
>>
>> Signed-off-by: Ira W. Snyder <iws@ovro.caltech.edu>
>
> Acked-by: Wolfgang Grandegger <wg@grandegger.com>
Since this driver depends upon the MFD stuff and that goes
through other maintainers, just toss this CAN driver in
via whatever tree the MFD thing goes through and add my:
Acked-by: David S. Miller <davem@davemloft.net>
Thanks!
^ permalink raw reply
* Re: [net-next-2.6 PATCH] igb: add per-packet timestamping
From: David Miller @ 2010-03-31 6:42 UTC (permalink / raw)
To: jeffrey.t.kirsher; +Cc: netdev, gospo, nicholasx.d.nunley
In-Reply-To: <20100326213545.19028.21468.stgit@localhost.localdomain>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Fri, 26 Mar 2010 14:36:47 -0700
> From: Nick Nunley <nicholasx.d.nunley@intel.com>
>
> This patch adds support for per-packet timestamping for the
> 82580 adapter. The rx timestamp code is also pulled out of the
> inlined rx hotpath and instead moved to a seperate function.
>
> This version adds a comment explaining the per-packet timestamping
> code added to igb_hwtstamp_ioctl().
>
> Signed-off-by: Nicholas Nunley <nicholasx.d.nunley@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next trivial] MAINTAINERS: ipg: Jesse Huang's email address bounces
From: David Miller @ 2010-03-31 6:42 UTC (permalink / raw)
To: joe; +Cc: romieu, sorbica, netdev, linux-kernel
In-Reply-To: <1269801736.1500.36.camel@Joe-Laptop.home>
From: Joe Perches <joe@perches.com>
Date: Sun, 28 Mar 2010 11:42:16 -0700
> Signed-off-by: Joe Perches <joe@perches.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next trivial] drivers/net/ipg: Remove invalid IPG_DDEBUG_MSG uses, neaten
From: David Miller @ 2010-03-31 6:42 UTC (permalink / raw)
To: joe; +Cc: romieu, sorbica, jesse, netdev, linux-kernel
In-Reply-To: <1269801345.1500.32.camel@Joe-Laptop.home>
From: Joe Perches <joe@perches.com>
Date: Sun, 28 Mar 2010 11:35:45 -0700
> Some no longer valid IPG_DDEBUG_MSG uses are removed
> Validate IPG_DDEBUG_MSG arguments when not #defined
> Neaten #defines
> marco/macro typo correction
>
> Signed-off-by: Joe Perches <joe@perches.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next-2.6 (TAKE 2)] ipv6: Use __fls() instead of fls() in __ipv6_addr_diff().
From: David Miller @ 2010-03-31 6:40 UTC (permalink / raw)
To: yoshfuji; +Cc: netdev
In-Reply-To: <201003291600.o2TG05VI032167@94.43.138.210.xn.2iij.net>
From: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Date: Tue, 30 Mar 2010 01:00:05 +0900
> Because we have ensured that the argument is non-zero,
> it is better to use __fls() and generate better code.
>
> Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Applied.
^ permalink raw reply
* Re: [PATCH net-next-2.6] ipv6 fib: Use "Sweezle" to optimize addr_bit_test().
From: David Miller @ 2010-03-31 6:40 UTC (permalink / raw)
To: yoshfuji; +Cc: netdev
In-Reply-To: <201003271124.o2RBOGjT006944@94.43.138.210.xn.2iij.net>
From: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Date: Sat, 27 Mar 2010 20:24:16 +0900
> Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Applied.
^ permalink raw reply
* Re: [PATCH net-next-2.6] sctp: Use ipv6_addr_diff() in sctp_v6_addr_match_len().
From: David Miller @ 2010-03-31 6:40 UTC (permalink / raw)
To: yoshfuji; +Cc: netdev
In-Reply-To: <201003261834.o2QIYUhQ009920@94.43.138.210.xn.2iij.net>
From: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Date: Sat, 27 Mar 2010 03:34:30 +0900
> Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Applied.
^ permalink raw reply
* Re: [PATCH net-next-2.6 1/3] ipv6 mcast: Introduce include/net/mld.h for MLD definitions.
From: David Miller @ 2010-03-31 6:27 UTC (permalink / raw)
To: yoshfuji; +Cc: netdev
In-Reply-To: <20100330.232344.177012600.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Tue, 30 Mar 2010 23:23:44 -0700 (PDT)
> From: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
> Date: Mon, 29 Mar 2010 20:01:22 +0900
>
>> Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
>
> Applied, thanks.
Nevermind, reverted, breaks the build:
net/ipv6/mcast.c: In function ‘igmp6_event_query’:
net/ipv6/mcast.c:1134: error: implicit declaration of function ‘mld_msg’
net/ipv6/mcast.c:1134: warning: assignment makes pointer from integer without a cast
net/ipv6/mcast.c: In function ‘igmp6_event_report’:
net/ipv6/mcast.c:1254: warning: assignment makes pointer from integer without a cast
make[2]: *** [net/ipv6/mcast.o] Error 1
make[1]: *** [net/ipv6] Error 2
make: *** [net] Error 2
make: *** Waiting for unfinished jobs....
CC [M] drivers/net/e1000e/lib.o
LD [M] drivers/net/e1000e/e1000e.o
^ permalink raw reply
* Re: [PATCH net-next-2.6 2/3] bridge br_multicast: Make functions less ipv4 dependent.
From: David Miller @ 2010-03-31 6:24 UTC (permalink / raw)
To: yoshfuji; +Cc: netdev, shemminger
In-Reply-To: <201003291101.o2TB1R0W006599@94.43.138.210.xn.2iij.net>
From: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Date: Mon, 29 Mar 2010 20:01:27 +0900
> Introduce struct br_ip{} to store ip address and protocol
> and make functions more generic so that we can support
> both IPv4 and IPv6 with less pain.
>
> Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Stephen said he would clean up the macros and he seemed to imply
therefore that he'd resubmit these, so I'll leave patches #2 and #3 to
him.
Thanks!
^ permalink raw reply
* Re: [PATCH net-next-2.6 1/3] ipv6 mcast: Introduce include/net/mld.h for MLD definitions.
From: David Miller @ 2010-03-31 6:23 UTC (permalink / raw)
To: yoshfuji; +Cc: netdev
In-Reply-To: <201003291101.o2TB1MWQ006587@94.43.138.210.xn.2iij.net>
From: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Date: Mon, 29 Mar 2010 20:01:22 +0900
> Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Applied, thanks.
^ permalink raw reply
* [PATCH] rps: keep the old behavior on SMP without rps
From: Changli Gao @ 2010-03-31 6:16 UTC (permalink / raw)
To: David S. Miller; +Cc: netdev, xiaosuo
keep the old behavior on SMP without rps
RPS introduces a lock operation to per cpu variable input_pkt_queue on
SMP whenever rps is enabled or not. On SMP without RPS, this lock isn't
needed at all.
Signed-off-by: Changli Gao <xiaosuo@gmail.com>
----
net/core/dev.c | 42 ++++++++++++++++++++++++++++--------------
1 file changed, 28 insertions(+), 14 deletions(-)
diff --git a/net/core/dev.c b/net/core/dev.c
index 3e7fa16..d154f3b 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -207,6 +207,20 @@ static inline struct hlist_head *dev_index_hash(struct net *net, int ifindex)
return &net->dev_index_head[ifindex & (NETDEV_HASHENTRIES - 1)];
}
+static inline void rps_lock(struct softnet_data *queue)
+{
+#ifdef CONFIG_RPS
+ spin_lock(&queue->input_pkt_queue.lock);
+#endif
+}
+
+static inline void rps_unlock(struct softnet_data *queue)
+{
+#ifdef CONFIG_RPS
+ spin_unlock(&queue->input_pkt_queue.lock);
+#endif
+}
+
/* Device list insertion */
static int list_netdevice(struct net_device *dev)
{
@@ -2314,13 +2328,13 @@ static int enqueue_to_backlog(struct sk_buff *skb, int cpu)
local_irq_save(flags);
__get_cpu_var(netdev_rx_stat).total++;
- spin_lock(&queue->input_pkt_queue.lock);
+ rps_lock(queue);
if (queue->input_pkt_queue.qlen <= netdev_max_backlog) {
if (queue->input_pkt_queue.qlen) {
enqueue:
__skb_queue_tail(&queue->input_pkt_queue, skb);
- spin_unlock_irqrestore(&queue->input_pkt_queue.lock,
- flags);
+ rps_unlock(queue);
+ local_irq_restore(flags);
return NET_RX_SUCCESS;
}
@@ -2342,7 +2356,7 @@ enqueue:
goto enqueue;
}
- spin_unlock(&queue->input_pkt_queue.lock);
+ rps_unlock(queue);
__get_cpu_var(netdev_rx_stat).dropped++;
local_irq_restore(flags);
@@ -2767,19 +2781,19 @@ int netif_receive_skb(struct sk_buff *skb)
EXPORT_SYMBOL(netif_receive_skb);
/* Network device is going away, flush any packets still pending */
-static void flush_backlog(struct net_device *dev, int cpu)
+static void flush_backlog(void *arg)
{
- struct softnet_data *queue = &per_cpu(softnet_data, cpu);
+ struct net_device *dev = arg;
+ struct softnet_data *queue = &__get_cpu_var(softnet_data);
struct sk_buff *skb, *tmp;
- unsigned long flags;
- spin_lock_irqsave(&queue->input_pkt_queue.lock, flags);
+ rps_lock(queue);
skb_queue_walk_safe(&queue->input_pkt_queue, skb, tmp)
if (skb->dev == dev) {
__skb_unlink(skb, &queue->input_pkt_queue);
kfree_skb(skb);
}
- spin_unlock_irqrestore(&queue->input_pkt_queue.lock, flags);
+ rps_unlock(queue);
}
static int napi_gro_complete(struct sk_buff *skb)
@@ -3092,14 +3106,16 @@ static int process_backlog(struct napi_struct *napi, int quota)
do {
struct sk_buff *skb;
- spin_lock_irq(&queue->input_pkt_queue.lock);
+ local_irq_disable();
+ rps_lock(queue);
skb = __skb_dequeue(&queue->input_pkt_queue);
if (!skb) {
__napi_complete(napi);
spin_unlock_irq(&queue->input_pkt_queue.lock);
break;
}
- spin_unlock_irq(&queue->input_pkt_queue.lock);
+ rps_unlock(queue);
+ local_irq_enable();
__netif_receive_skb(skb);
} while (++work < quota && jiffies == start_time);
@@ -5549,7 +5565,6 @@ void netdev_run_todo(void)
while (!list_empty(&list)) {
struct net_device *dev
= list_first_entry(&list, struct net_device, todo_list);
- int i;
list_del(&dev->todo_list);
if (unlikely(dev->reg_state != NETREG_UNREGISTERING)) {
@@ -5561,8 +5576,7 @@ void netdev_run_todo(void)
dev->reg_state = NETREG_UNREGISTERED;
- for_each_online_cpu(i)
- flush_backlog(dev, i);
+ on_each_cpu(flush_backlog, dev, 1);
netdev_wait_allrefs(dev);
^ permalink raw reply related
* Re: [PATCH 0/6] tagged sysfs support
From: Tejun Heo @ 2010-03-31 6:25 UTC (permalink / raw)
To: Kay Sievers
Cc: Eric W. Biederman, Greg Kroah-Hartman, Greg KH, linux-kernel,
Cornelia Huck, linux-fsdevel, Eric Dumazet, Benjamin LaHaise,
Serge Hallyn, netdev
In-Reply-To: <s2hac3eb2511003302251rcbae8767ne21e9daf1546c849@mail.gmail.com>
On 03/31/2010 02:51 PM, Kay Sievers wrote:
> Another problem to solve is that sysfs does not allow us to symlink
> regular files, only directories, so we can currently not create the
> class-wide attributes as symlinks to the proper file in
> /sys/subsystem/.
Making sysfs allow symlinks to attributes shouldn't be too hard if
it's gonna help make things more logical overall.
Thanks.
--
tejun
^ permalink raw reply
* RE: re-submit2 [ANNOUNCEMENT] NET: usb: sierra_net.c driver
From: Rory Filer @ 2010-03-31 6:21 UTC (permalink / raw)
To: David Miller, Elina Pasheva
Cc: dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
In-Reply-To: <20100330.231051.113008279.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
-----Original Message-----
> >
> > Applied, thanks.
>
> Nevermind, reverted, it doesn't even build.
>
> drivers/net/usb/sierra_net.c: In function 'check_ethip_packet':
> drivers/net/usb/sierra_net.c:221:3: error: implicit declaration of
> function 'deverr'
>
> Really, this should never ever happen, and there is simply
> no excuse at all for this.
Well actually there is an excuse, but I'm sure you don't want to
know what it is.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* Re: drivers/net: Add missing unlock
From: David Miller @ 2010-03-31 6:17 UTC (permalink / raw)
To: julia; +Cc: netdev
Applied, thanks.
^ permalink raw reply
* Re: re-submit2 [ANNOUNCEMENT] NET: usb: sierra_net.c driver
From: David Miller @ 2010-03-31 6:10 UTC (permalink / raw)
To: epasheva-ywE8TTl5eJHWpu6QEFMNjNBPR1lH4CV8
Cc: dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f,
rfiler-ywE8TTl5eJHWpu6QEFMNjNBPR1lH4CV8,
linux-usb-u79uwXL29TY76Z2rM5mHXA, netdev-u79uwXL29TY76Z2rM5mHXA
In-Reply-To: <20100330.230932.244208287.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
From: David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
Date: Tue, 30 Mar 2010 23:09:32 -0700 (PDT)
> From: Elina Pasheva <epasheva-ywE8TTl5eJHWpu6QEFMNjNBPR1lH4CV8@public.gmane.org>
> Date: Mon, 29 Mar 2010 13:13:16 -0700
>
>> Subject: re-submit2 [ANNOUNCEMENT] NET: usb: sierra_net.c driver
>> From: Elina Pasheva <epasheva-ywE8TTl5eJHWpu6QEFMNjNBPR1lH4CV8@public.gmane.org>
>
> Applied, thanks.
Nevermind, reverted, it doesn't even build.
drivers/net/usb/sierra_net.c: In function 'check_ethip_packet':
drivers/net/usb/sierra_net.c:221:3: error: implicit declaration of function 'deverr'
Really, this should never ever happen, and there is simply
no excuse at all for this.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* Re: re-submit2 [ANNOUNCEMENT] NET: usb: sierra_net.c driver
From: David Miller @ 2010-03-31 6:09 UTC (permalink / raw)
To: epasheva-ywE8TTl5eJHWpu6QEFMNjNBPR1lH4CV8
Cc: dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f,
rfiler-ywE8TTl5eJHWpu6QEFMNjNBPR1lH4CV8,
linux-usb-u79uwXL29TY76Z2rM5mHXA, netdev-u79uwXL29TY76Z2rM5mHXA
In-Reply-To: <1269893596.9242.7.camel@Linuxdev3>
From: Elina Pasheva <epasheva-ywE8TTl5eJHWpu6QEFMNjNBPR1lH4CV8@public.gmane.org>
Date: Mon, 29 Mar 2010 13:13:16 -0700
> Subject: re-submit2 [ANNOUNCEMENT] NET: usb: sierra_net.c driver
> From: Elina Pasheva <epasheva-ywE8TTl5eJHWpu6QEFMNjNBPR1lH4CV8@public.gmane.org>
Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* Re: [PATCH 2/2] net: gianfar - align BD ring size console messages
From: David Miller @ 2010-03-31 6:09 UTC (permalink / raw)
To: kim.phillips; +Cc: avorontsov, Sandeep.Kumar, galak, afleming, netdev
In-Reply-To: <1269986062-1697-2-git-send-email-kim.phillips@freescale.com>
From: Kim Phillips <kim.phillips@freescale.com>
Date: Tue, 30 Mar 2010 16:54:22 -0500
> fix this:
>
> eth2: :RX BD ring size for Q[0]: 256
> eth2:TX BD ring size for Q[0]: 256
>
> to look like:
>
> eth2: RX BD ring size for Q[0]: 256
> eth2: TX BD ring size for Q[0]: 256
>
> Signed-off-by: Kim Phillips <kim.phillips@freescale.com>
Applied.
^ permalink raw reply
* Re: [PATCH 1/2] net: gianfar - initialize per-queue statistics
From: David Miller @ 2010-03-31 6:09 UTC (permalink / raw)
To: kim.phillips; +Cc: avorontsov, Sandeep.Kumar, galak, afleming, netdev
In-Reply-To: <1269986062-1697-1-git-send-email-kim.phillips@freescale.com>
From: Kim Phillips <kim.phillips@freescale.com>
Date: Tue, 30 Mar 2010 16:54:21 -0500
> Interfaces come up claiming having already received 3.0 GiB.
> Use kzalloc to properly initialize per-queue data.
>
> Signed-off-by: Kim Phillips <kim.phillips@freescale.com>
Applied.
^ permalink raw reply
* Re: [PATCH] gianfar: Fix a memory leak in gianfar close code
From: David Miller @ 2010-03-31 6:09 UTC (permalink / raw)
To: afleming; +Cc: netdev, eric.dumazet, Sandeep.Kumar
In-Reply-To: <1269913343-6566-1-git-send-email-afleming@freescale.com>
From: Andy Fleming <afleming@freescale.com>
Date: Mon, 29 Mar 2010 20:42:23 -0500
> gianfar needed to ensure existence of the *skbuff arrays before
> freeing the skbs in them, rather than ensuring their nonexistence.
>
> Signed-off-by: Andy Fleming <afleming@freescale.com>
Although some refactorings have been suggested, this fixes the bug
straightforwardly and is therefore the most appropriate fix for
net-2.6
Applied, thanks.
^ permalink raw reply
* Re: [PATCH] Allow MACB to connect to a higher addresses PHY.
From: Grant Likely @ 2010-03-31 6:08 UTC (permalink / raw)
To: Anders Darander
Cc: David S. Miller, Ralf Baechle, Maxime Bizon, David Daney,
Sekhar Nori, Anton Vorontsov, Andy Fleming, netdev, linux-kernel
In-Reply-To: <20100331055306.GC4837@datarespons.se>
On Tue, Mar 30, 2010 at 11:53 PM, Anders Darander
<anders.darander@datarespons.se> wrote:
> * Grant Likely <grant.likely@secretlab.ca> [100330 16:42]:
> One question, if I add such an kernel parameter, would it be OK to
> implement something like this in the macb-driver:
>
> if parameter == SOME_DEFAULT
> phydev = phy_find_first(bp->mii_bus);
> else
> phydev = bp->mii_bus->phy_map[parameter];
>
> I.e. if the parameter is set to some default value, the old behaviour is
> retained, otherwise the specified parameter is used for the phy_addr?
Absolutely.
g.
^ permalink raw reply
* Re: [PATCH] Allow MACB to connect to a higher addresses PHY.
From: Anders Darander @ 2010-03-31 5:53 UTC (permalink / raw)
To: Grant Likely
Cc: David S. Miller, Ralf Baechle, Maxime Bizon, David Daney,
Sekhar Nori, Anton Vorontsov, Andy Fleming, netdev, linux-kernel
In-Reply-To: <fa686aa41003300741x5ef9bdbpf56133304fe4d6e6@mail.gmail.com>
Hi Grant,
Thanks for the feedback!
* Grant Likely <grant.likely@secretlab.ca> [100330 16:42]:
> On Tue, Mar 30, 2010 at 3:58 AM, Anders Darander
> <anders.darander@gmail.com> wrote:
> > Using the Atmel MACB together with an integrated switch, can make only port 1
> > work. This is caused by macb_mii_probe trying to attach the MAC to the first
> > PHY, which often is on one of the external ports.
> >
> > E.g. the Micrel KSZ8873 connects to the MAC on port 3, thus phy_addr should be
> > set to 3.
> I understand what you are trying to do, but this is the wrong way to
> go about it. Hard coding it into Kconfig breaks multiplatform
> kernels. Besides, systems may have more than one physical MDIO bus.
> This patch would make CONFIG_SWITCHING_PHY_ADDR the only address
> accessible on all MDIO busses.
True, it would at least make all addresses < CONFIG_SWITCHING_PHY_ADDR
non-accessible.
We developed the patch to solve this problem on a 2.6.29-kernel, in
which the loop in question is directly in the macb_mii_probe() in the
macb.c, thus, the original patch is at least a _little_ bit less ugly...
> Nak.
I fully agree on the nak; I completely forgot that the functions in
phy_devices should be used from more interfaces than only the macb.
> The right thing to do is to add a runtime configuration option (ie.
> kernel parameter or platform data) to the mac driver to specify
> exactly which PHY address it is supposed to use.
I'll see if I can get some time to do such a thing. Unfortunately, it'll
probably have to be dealt with on my sparetime (the customer is quite
unlikely to let me work on that).
One question, if I add such an kernel parameter, would it be OK to
implement something like this in the macb-driver:
if parameter == SOME_DEFAULT
phydev = phy_find_first(bp->mii_bus);
else
phydev = bp->mii_bus->phy_map[parameter];
I.e. if the parameter is set to some default value, the old behaviour is
retained, otherwise the specified parameter is used for the phy_addr?
I'd appreciate your input on such a design.
Best regards,
Anders Darander
^ permalink raw reply
* Re: [PATCH] e1000e: typo corrections
From: David Miller @ 2010-03-31 6:01 UTC (permalink / raw)
To: joe; +Cc: jeffrey.t.kirsher, netdev, gospo, bruce.w.allan
In-Reply-To: <1269670619.1603.9.camel@Joe-Laptop.home>
From: Joe Perches <joe@perches.com>
Date: Fri, 26 Mar 2010 23:16:59 -0700
> Here are the other miscellaneous corrections
> done by an earlier larger suggested patch now
> made unnecessary by a less invasive change.
>
> Correct a few missing newlines from logging
> messages and a typo fix. Fix speed/duplex
> logging message.
>
> Signed-off-by: Joe Perches <joe@perches.com>
I'll apply this to net-next-2.6, thanks.
^ permalink raw reply
* Re: [PATCH] igb: update hw_debug macro to make use of netdev_dbg call
From: David Miller @ 2010-03-31 6:01 UTC (permalink / raw)
To: jeffrey.t.kirsher; +Cc: netdev, gospo, alexander.h.duyck
In-Reply-To: <20100325231007.8991.24570.stgit@localhost.localdomain>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Thu, 25 Mar 2010 16:10:08 -0700
> From: Alexander Duyck <alexander.h.duyck@intel.com>
>
> This change updates the igb driver to make use of the netdev_dbg function
> macros now provided in netdevice.h
>
> This is meant to be provided as an alternative to the patch provided by
> Joe Perches.
>
> It also removes igb_get_time_str since I found that it is unused code that
> is no longer used even in debug.
>
> Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
I'll apply this to net-next-2.6, thanks.
^ permalink raw reply
* Re: [PATCH RFC] virtio_net: use NAPI for xmit (UNTESTED)
From: Shirley Ma @ 2010-03-31 5:58 UTC (permalink / raw)
To: Rusty Russell; +Cc: Michael S. Tsirkin, netdev, Herbert Xu
In-Reply-To: <1270014284.25337.3.camel@localhost.localdomain>
Back ported it and prepared for more tests.
Shirley
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox