* [net-next-2.6 PATCH 2/2] e1000e: Reset 82577/82578 PHY before first PHY register read
From: Jeff Kirsher @ 2010-05-06 8:00 UTC (permalink / raw)
To: davem; +Cc: netdev, gospo, Bruce Allan, Jeff Kirsher
In-Reply-To: <20100506075959.8910.13493.stgit@localhost.localdomain>
From: Bruce Allan <bruce.w.allan@intel.com>
Reset the PHY before first accessing it. Doing so, ensure that the PHY is
in a known good state before we read/write PHY registers. This fixes a
driver probe failure.
Signed-off-by: Bruce Allan <bruce.w.allan@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
drivers/net/e1000e/ich8lan.c | 10 ++++++++++
1 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/drivers/net/e1000e/ich8lan.c b/drivers/net/e1000e/ich8lan.c
index 0bfef8e..b8c4dce 100644
--- a/drivers/net/e1000e/ich8lan.c
+++ b/drivers/net/e1000e/ich8lan.c
@@ -294,6 +294,16 @@ static s32 e1000_init_phy_params_pchlan(struct e1000_hw *hw)
msleep(50);
}
+ /*
+ * Reset the PHY before any acccess to it. Doing so, ensures that
+ * the PHY is in a known good state before we read/write PHY registers.
+ * The generic reset is sufficient here, because we haven't determined
+ * the PHY type yet.
+ */
+ ret_val = e1000e_phy_hw_reset_generic(hw);
+ if (ret_val)
+ goto out;
+
phy->id = e1000_phy_unknown;
ret_val = e1000e_get_phy_id(hw);
if (ret_val)
^ permalink raw reply related
* [net-next-2.6 PATCH 1/2] e1000e: reset MAC-PHY interconnect on 82577/82578 during Sx->S0
From: Jeff Kirsher @ 2010-05-06 8:00 UTC (permalink / raw)
To: davem; +Cc: netdev, gospo, Bruce Allan, Jeff Kirsher
From: Bruce Allan <bruce.w.allan@intel.com>
During Sx->S0 transitions, the interconnect between the MAC and PHY on
82577/82578 can remain in SMBus mode instead of transitioning to the
PCIe-like mode required during normal operation. Toggling the LANPHYPC
Value bit essentially resets the interconnect forcing it to the correct
mode.
Signed-off-by: Bruce Allan <bruce.w.allan@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
drivers/net/e1000e/defines.h | 2 ++
drivers/net/e1000e/ich8lan.c | 20 ++++++++++++++++++++
2 files changed, 22 insertions(+), 0 deletions(-)
diff --git a/drivers/net/e1000e/defines.h b/drivers/net/e1000e/defines.h
index e301e26..7f760aa 100644
--- a/drivers/net/e1000e/defines.h
+++ b/drivers/net/e1000e/defines.h
@@ -214,6 +214,8 @@
#define E1000_CTRL_SPD_1000 0x00000200 /* Force 1Gb */
#define E1000_CTRL_FRCSPD 0x00000800 /* Force Speed */
#define E1000_CTRL_FRCDPX 0x00001000 /* Force Duplex */
+#define E1000_CTRL_LANPHYPC_OVERRIDE 0x00010000 /* SW control of LANPHYPC */
+#define E1000_CTRL_LANPHYPC_VALUE 0x00020000 /* SW value of LANPHYPC */
#define E1000_CTRL_SWDPIN0 0x00040000 /* SWDPIN 0 value */
#define E1000_CTRL_SWDPIN1 0x00080000 /* SWDPIN 1 value */
#define E1000_CTRL_SWDPIO0 0x00400000 /* SWDPIN 0 Input or output */
diff --git a/drivers/net/e1000e/ich8lan.c b/drivers/net/e1000e/ich8lan.c
index 5059c22..0bfef8e 100644
--- a/drivers/net/e1000e/ich8lan.c
+++ b/drivers/net/e1000e/ich8lan.c
@@ -83,6 +83,8 @@
#define E1000_ICH_FWSM_RSPCIPHY 0x00000040 /* Reset PHY on PCI Reset */
+/* FW established a valid mode */
+#define E1000_ICH_FWSM_FW_VALID 0x00008000
#define E1000_ICH_MNG_IAMT_MODE 0x2
@@ -259,6 +261,7 @@ static inline void __ew32flash(struct e1000_hw *hw, unsigned long reg, u32 val)
static s32 e1000_init_phy_params_pchlan(struct e1000_hw *hw)
{
struct e1000_phy_info *phy = &hw->phy;
+ u32 ctrl;
s32 ret_val = 0;
phy->addr = 1;
@@ -274,6 +277,23 @@ static s32 e1000_init_phy_params_pchlan(struct e1000_hw *hw)
phy->ops.power_down = e1000_power_down_phy_copper_ich8lan;
phy->autoneg_mask = AUTONEG_ADVERTISE_SPEED_DEFAULT;
+ if (!(er32(FWSM) & E1000_ICH_FWSM_FW_VALID)) {
+ /*
+ * The MAC-PHY interconnect may still be in SMBus mode
+ * after Sx->S0. Toggle the LANPHYPC Value bit to force
+ * the interconnect to PCIe mode, but only if there is no
+ * firmware present otherwise firmware will have done it.
+ */
+ ctrl = er32(CTRL);
+ ctrl |= E1000_CTRL_LANPHYPC_OVERRIDE;
+ ctrl &= ~E1000_CTRL_LANPHYPC_VALUE;
+ ew32(CTRL, ctrl);
+ udelay(10);
+ ctrl &= ~E1000_CTRL_LANPHYPC_OVERRIDE;
+ ew32(CTRL, ctrl);
+ msleep(50);
+ }
+
phy->id = e1000_phy_unknown;
ret_val = e1000e_get_phy_id(hw);
if (ret_val)
^ permalink raw reply related
* Re: [PATCH v2] sctp: Fix a race between ICMP protocol unreachable and connect()
From: David Miller @ 2010-05-06 7:56 UTC (permalink / raw)
To: vladislav.yasevich; +Cc: netdev, linux-sctp
In-Reply-To: <1273088166-18391-1-git-send-email-vladislav.yasevich@hp.com>
From: Vlad Yasevich <vladislav.yasevich@hp.com>
Date: Wed, 5 May 2010 15:36:06 -0400
> ICMP protocol unreachable handling completely disregarded
> the fact that the user may have locket the socket. It proceeded
> to destroy the association, even though the user may have
> held the lock and had a ref on the association. This resulted
> in the following:
>
> Attempt to release alive inet socket f6afcc00
...
> This was because the sctp_wait_for_connect() would aqcure the socket
> lock and then proceed to release the last reference count on the
> association, thus cause the fully destruction path to finish freeing
> the socket.
>
> The simplest solution is to start a very short timer in case the socket
> is owned by user. When the timer expires, we can do some verification
> and be able to do the release properly.
>
> Signed-off-by: Vlad Yasevich <vladislav.yasevich@hp.com>
Applied and queued up for -stable, thanks Vlad.
^ permalink raw reply
* Re: kernel panic when using netns+bridges+tc(netem)
From: David Miller @ 2010-05-06 7:54 UTC (permalink / raw)
To: eric.dumazet; +Cc: martin.ferrari, arnd, netdev, mathieu.lacage
In-Reply-To: <1273129187.2304.14.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 06 May 2010 08:59:47 +0200
> David, this is a stable candidate, once tested and acked, thanks !
>
> [PATCH] veth: Dont kfree_skb() after dev_forward_skb()
>
> In case of congestion, netif_rx() frees the skb, so we must assume
> dev_forward_skb() also consume skb.
>
> Bug introduced by commit 445409602c092
> (veth: move loopback logic to common location)
>
> We must change dev_forward_skb() to always consume skb, and veth to not
> double free it.
>
> Bug report : http://marc.info/?l=linux-netdev&m=127310770900442&w=3
>
> Reported-by: Martín Ferrari <martin.ferrari@gmail.com>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Ugh, applied and queued up for -stable, thanks Eric!
^ permalink raw reply
* Re: [v5 Patch 1/3] netpoll: add generic support for bridge and bonding devices
From: David Miller @ 2010-05-06 7:44 UTC (permalink / raw)
To: mpm
Cc: amwang, linux-kernel, netdev, bridge, gospo, nhorman, jmoyer,
shemminger, bonding-devel, fubar
In-Reply-To: <1273111530.21962.2753.camel@calx>
From: Matt Mackall <mpm@selenic.com>
Date: Wed, 05 May 2010 21:05:30 -0500
> On Wed, 2010-05-05 at 04:11 -0400, Amerigo Wang wrote:
>> V5:
>> Fix coding style problems pointed by David.
>
> Aside from my concern about the policy of disabling netpoll on
> bridges/bonds with only partial netpoll support, I don't have any
> remaining issues with this. But I'll leave it to other folks to ack the
> underlying driver bits for this series.
Yes the partial support handling is a thorny issue.
But this patch set makes things better than they were before, because
support over such devices didn't work at all previously.
So I'll toss these patches into net-next-2.6, thanks everyone!
^ permalink raw reply
* Re: [net-next-2.6 PATCH] igb: reduce cache misses on tx cleanup
From: David Miller @ 2010-05-06 7:36 UTC (permalink / raw)
To: jeffrey.t.kirsher; +Cc: netdev, gospo, nicholasx.d.nunley
In-Reply-To: <20100505075733.5474.37834.stgit@localhost.localdomain>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Wed, 05 May 2010 00:58:07 -0700
> From: Nick Nunley <nicholasx.d.nunley@intel.com>
>
> This patch reduces the number of skb cache misses in the
> clean_tx_irq path, and results in an overall increase
> in tx packet throughput.
>
> Signed-off-by: Nicholas Nunley <nicholasx.d.nunley@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied.
^ permalink raw reply
* Re: [PATCH] bonding: fix arp_validate on bonds inside a bridge
From: David Miller @ 2010-05-06 7:35 UTC (permalink / raw)
To: jbohac; +Cc: fubar, bonding-devel, netdev
In-Reply-To: <20100505133301.GA18493@midget.suse.cz>
From: Jiri Bohac <jbohac@suse.cz>
Date: Wed, 5 May 2010 15:33:01 +0200
> If either of the ptype_all or ptype_base_predecap[] method is
> preferred, I'll be happy to re-work the patch. I just thought
> performance had bigger priority here.
Well, let's do some thinking.
If there are any ptype_all[] entries at all, processing of every
packet will be expensive.
Also, the ptype_base_predecap[] is unlikely to have any entries
unless bonding is on in this special mode. But if it is, we
can accept a little bit of extra overhead.
So we can address all of this without adding undue overhead for people
not using this stuff, by simply having an atomic counter which shows
how many ptype_all[] or ptype_base_predecap[] entries exist.
And at the top level we test that __read_mostly atomic variable before
traversing the ptype_all[] and ptype_base_predecap[] lists.
That should address all of the issues.
^ permalink raw reply
* Re: [net-next-2.6 PATCH 3/3] ixgbevf: Cache PF ack bit in interrupt
From: David Miller @ 2010-05-06 7:32 UTC (permalink / raw)
To: jeffrey.t.kirsher; +Cc: netdev, gospo, gregory.v.rose
In-Reply-To: <20100506055748.8482.25239.stgit@localhost.localdomain>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Wed, 05 May 2010 22:57:49 -0700
> From: Greg Rose <gregory.v.rose@intel.com>
>
> When the PF acks a message from the VF the VF gets an interrupt. It
> must cache the ack bit so that polling SW will not miss the ack. Also
> avoid reading the message buffer on acks because that also will clear
> the ack bit.
>
> Signed-off-by: Greg Rose <gregory.v.rose@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied.
^ permalink raw reply
* Re: [net-next-2.6 PATCH 2/3] ixgbe: Streamline MC filter setup for VFs
From: David Miller @ 2010-05-06 7:32 UTC (permalink / raw)
To: jeffrey.t.kirsher; +Cc: netdev, gospo, gregory.v.rose
In-Reply-To: <20100506055728.8482.77386.stgit@localhost.localdomain>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Wed, 05 May 2010 22:57:30 -0700
> From: Greg Rose <gregory.v.rose@intel.com>
>
> The driver was calling the set Rx mode function for every multicast
> filter set by the VF. When starting many VMs where each might have
> multiple VLAN interfaces this would result in the function being
> called hundreds or even thousands of times. This is unnecessary
> for the case of the imperfect filters used in the MTA and has been
> streamlined to be more efficient.
>
> Signed-off-by: Greg Rose <gregory.v.rose@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied.
^ permalink raw reply
* Re: [net-next-2.6 PATCH 1/3] ixgbe: Remove unneeded register writes in VF VLAN setup
From: David Miller @ 2010-05-06 7:32 UTC (permalink / raw)
To: jeffrey.t.kirsher; +Cc: netdev, gospo, gregory.v.rose
In-Reply-To: <20100506055703.8482.16515.stgit@localhost.localdomain>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Wed, 05 May 2010 22:57:10 -0700
> From: Greg Rose <gregory.v.rose@intel.com>
>
> The driver is unnecessarily writing values to VLAN control registers.
> These writes already done elsewhere and are superfluous here.
>
> Signed-off-by: Greg Rose <gregory.v.rose@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied.
^ permalink raw reply
* Re: [GIT PULL] amended: first round of vhost-net enhancements for net-next
From: David Miller @ 2010-05-06 7:29 UTC (permalink / raw)
To: mst; +Cc: kvm, virtualization, netdev, linux-kernel
In-Reply-To: <20100504112100.GA22172@redhat.com>
From: "Michael S. Tsirkin" <mst@redhat.com>
Date: Tue, 4 May 2010 14:21:01 +0300
> This is an amended pull request: I have rebased the tree to the
> correct patches. This has been through basic tests and seems
> to work fine here.
>
> The following tree includes a couple of enhancements that help vhost-net.
> Please pull them for net-next. Another set of patches is under
> debugging/testing and I hope to get them ready in time for 2.6.35,
> so there may be another pull request later.
Pulled, thanks Michael.
^ permalink raw reply
* Re: [PATCH v2] net/gianfar: drop recycled skbs on MTU change
From: David Miller @ 2010-05-06 7:26 UTC (permalink / raw)
To: afleming; +Cc: sebastian, afleming, netdev
In-Reply-To: <C4C9C232-1DA6-43BE-A9FF-4A591E3FF672@freescale.com>
From: Andy Fleming <afleming@freescale.com>
Date: Wed, 5 May 2010 10:18:40 -0500
>
> On May 5, 2010, at 3:30 AM, Sebastian Andrzej Siewior wrote:
>
>> From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
>>
>> The size for skbs which is added to the recycled list is using the
>> current descriptor size which is current MTU. gfar_new_skb() is also
>> using this size. So after changing or alteast increasing the MTU all
>> recycled skbs should be dropped.
>>
>> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
...
> Acked-by: Andy Fleming <afleming@freescale.com>
Applied, thanks everyone.
^ permalink raw reply
* Re: [net-next-2.6 PATCH 2/2] e1000/e1000e: implement a simple interrupt moderation
From: David Miller @ 2010-05-06 7:25 UTC (permalink / raw)
To: jeffrey.t.kirsher; +Cc: netdev, gospo, jesse.brandeburg
In-Reply-To: <20100505082601.5956.29024.stgit@localhost.localdomain>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Wed, 05 May 2010 01:26:03 -0700
> From: Jesse Brandeburg <jesse.brandeburg@intel.com>
>
> Back before e1000-7.3.20, the e1000 driver had a simple algorithm that
> managed interrupt moderation. The driver was updated in 7.3.20 to
> have the new "adaptive" interrupt moderation but we have customer
> requests to redeploy the old way as an option. This patch adds the
> old functionality back. The new functionality can be enabled via
> module parameter or at runtime via ethtool.
> Module parameter: (InterruptThrottleRate=4) to use this new
> moderation method.
> Ethtool method: ethtool -C ethX rx-usecs 4
>
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied.
^ permalink raw reply
* Re: [net-next-2.6 PATCH 1/2] e1000e: increase rx fifo size to 36K on 82574 and 82583
From: David Miller @ 2010-05-06 7:25 UTC (permalink / raw)
To: jeffrey.t.kirsher; +Cc: netdev, gospo, alexander.h.duyck
In-Reply-To: <20100505082537.5956.86868.stgit@localhost.localdomain>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Wed, 05 May 2010 01:25:42 -0700
> From: Alexander Duyck <alexander.h.duyck@intel.com>
>
> This change increases the RX fifo size to 36K for standard frames and
> decreases the TX fifo size to 4K. The reason for this change is that on
> slower systems the RX is much more likely to backfill and need space than
> the TX is. As long as the TX fifo is twice the size of the MTU we should
> have more than enough TX fifo.
>
> Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied.
^ permalink raw reply
* Re: [net-next-2.6 PATCH 2/2] ixgbe: Add support for VF MAC and VLAN configuration
From: David Miller @ 2010-05-06 7:25 UTC (permalink / raw)
To: jeffrey.t.kirsher; +Cc: netdev, gospo, gregory.v.rose
In-Reply-To: <20100505081204.5709.63340.stgit@localhost.localdomain>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Wed, 05 May 2010 01:12:06 -0700
> From: Greg Rose <gregory.v.rose@intel.com>
>
> Add support for the "ip link set" and "ip link show" commands that allow
> configuration of the virtual functions' MAC and port VLAN via user space
> command line.
>
> Signed-off-by: Greg Rose <gregory.v.rose@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied.
^ permalink raw reply
* Re: [net-next-2.6 PATCH 1/2] ixgbe: Add boolean parameter to ixgbe_set_vmolr
From: David Miller @ 2010-05-06 7:25 UTC (permalink / raw)
To: jeffrey.t.kirsher; +Cc: netdev, gospo, gregory.v.rose
In-Reply-To: <20100505081129.5709.39430.stgit@localhost.localdomain>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Wed, 05 May 2010 01:11:46 -0700
> From: Greg Rose <gregory.v.rose@intel.com>
>
> Add a boolean parameter to ixgbe-set_vmolr so that the caller can
> specify whether the pool should accept untagged packets. Required
> for a follow on patch to enable administrative configuration of port
> VLAN for virtual functions.
>
> Signed-off-by: Greg Rose <gregory.v.rose@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied.
^ permalink raw reply
* RE: [Pv-drivers] RFC: Network Plugin Architecture (NPA) for vmxnet3
From: Shreyas Bhatewara @ 2010-05-06 7:25 UTC (permalink / raw)
To: Scott Feldman, Arnd Bergmann, Dmitry Torokhov
Cc: Christoph Hellwig, pv-drivers@vmware.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org, Pankaj Thakkar
In-Reply-To: <C807719A.2E910%scofeldm@cisco.com>
> -----Original Message-----
> From: Scott Feldman [mailto:scofeldm@cisco.com]
> Sent: Wednesday, May 05, 2010 7:04 PM
> To: Shreyas Bhatewara; Arnd Bergmann; Dmitry Torokhov
> Cc: Christoph Hellwig; pv-drivers@vmware.com; netdev@vger.kernel.org;
> linux-kernel@vger.kernel.org; virtualization@lists.linux-
> foundation.org; Pankaj Thakkar
> Subject: Re: [Pv-drivers] RFC: Network Plugin Architecture (NPA) for
> vmxnet3
>
> On 5/5/10 10:29 AM, "Dmitry Torokhov" <dtor@vmware.com> wrote:
>
> > It would not be a binary blob but software properly released under
> GPL.
> > The current plan is for the shell to enforce GPL requirement on the
> > plugin code, similar to what module loaded does for regular kernel
> > modules.
>
> On 5/5/10 3:05 PM, "Shreyas Bhatewara" <sbhatewara@vmware.com> wrote:
>
> > The plugin image is not linked against Linux kernel. It is OS
> agnostic infact
> > (Eg. same plugin works for Linux and Windows VMs)
>
> Are there any issues with injecting the GPL-licensed plug-in into the
> Windows vmxnet3 NDIS driver?
>
> -scott
^ permalink raw reply
* RE: [Pv-drivers] RFC: Network Plugin Architecture (NPA) for vmxnet3
From: Shreyas Bhatewara @ 2010-05-06 7:25 UTC (permalink / raw)
To: Scott Feldman, Arnd Bergmann, Dmitry Torokhov
Cc: Christoph Hellwig, pv-drivers@vmware.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org, Pankaj Thakkar
In-Reply-To: <C807719A.2E910%scofeldm@cisco.com>
> -----Original Message-----
> From: Scott Feldman [mailto:scofeldm@cisco.com]
> Sent: Wednesday, May 05, 2010 7:04 PM
> To: Shreyas Bhatewara; Arnd Bergmann; Dmitry Torokhov
> Cc: Christoph Hellwig; pv-drivers@vmware.com; netdev@vger.kernel.org;
> linux-kernel@vger.kernel.org; virtualization@lists.linux-
> foundation.org; Pankaj Thakkar
> Subject: Re: [Pv-drivers] RFC: Network Plugin Architecture (NPA) for
> vmxnet3
>
> On 5/5/10 10:29 AM, "Dmitry Torokhov" <dtor@vmware.com> wrote:
>
> > It would not be a binary blob but software properly released under
> GPL.
> > The current plan is for the shell to enforce GPL requirement on the
> > plugin code, similar to what module loaded does for regular kernel
> > modules.
>
> On 5/5/10 3:05 PM, "Shreyas Bhatewara" <sbhatewara@vmware.com> wrote:
>
> > The plugin image is not linked against Linux kernel. It is OS
> agnostic infact
> > (Eg. same plugin works for Linux and Windows VMs)
>
> Are there any issues with injecting the GPL-licensed plug-in into the
> Windows vmxnet3 NDIS driver?
>
> -scott
Scott,
Thanks for pointing out. This issue can be resolved by adding exception to the plugin license which allows it to link to a non-free program .(http://www.gnu.org/licenses/gpl-faq.html#GPLPluginsInNF)
->Shreyas
^ permalink raw reply
* Re: [PATCH 4/4 v2] ks8851: read/write MAC address on companion eeprom through debugfs
From: David Miller @ 2010-05-06 7:25 UTC (permalink / raw)
To: s-jan; +Cc: netdev, linux-omap, x0066660, ben-linux, Tristram.Ha
In-Reply-To: <1273085155-1260-5-git-send-email-s-jan@ti.com>
From: Sebastien Jan <s-jan@ti.com>
Date: Wed, 5 May 2010 20:45:55 +0200
> A more elegant alternative to ethtool for updating the ks8851
> MAC address stored on its companion eeprom.
> Using this debugfs interface does not require any knowledge on the
> ks8851 companion eeprom organization to update the MAC address.
>
> Example to write 01:23:45:67:89:AB MAC address to the companion
> eeprom (assuming debugfs is mounted in /sys/kernel/debug):
> $ echo "01:23:45:67:89:AB" > /sys/kernel/debug/ks8851/mac_eeprom
>
> Signed-off-by: Sebastien Jan <s-jan@ti.com>
Elegant? This commit message is the biggest lie ever told.
What makes your ethernet driver so god-damn special that it deserves
to have a private, completely unique, and obscure interface for
setting the permanent ethernet address of a network device?
Tell me how damn elegant it is that users have to learn about this
special, unique, and common with no other driver, interface for
performing this task?
Tell me how damn elegant it is when another driver wants to provide
users with a way to do this too, and they (like you) come up with
their own unique and different interface for doing this.
No, this is the most inelegant patch ever conceived because it totally
ignores the way in which we handle issues like this.
There is no way in the world I'm applying this garbage patch, sorry.
We have an ETHTOOL_GPERMADDR, add a new ETHTOOL_SPERMADDR operation
and then any driver (not just your's) can portably provide this
facility and users will have one, and only one, way of performing this
task.
^ permalink raw reply
* Re: [PATCH 3/4 v2] ks8851: companion eeprom access through ethtool
From: David Miller @ 2010-05-06 7:20 UTC (permalink / raw)
To: s-jan; +Cc: netdev, linux-omap, x0066660, ben-linux, Tristram.Ha
In-Reply-To: <1273085155-1260-4-git-send-email-s-jan@ti.com>
From: Sebastien Jan <s-jan@ti.com>
Date: Wed, 5 May 2010 20:45:54 +0200
> Accessing ks8851 companion eeprom permits modifying the ks8851 stored
> MAC address.
>
> Example how to change the MAC address using ethtool, to set the
> 01:23:45:67:89:AB MAC address:
> $ echo "0:AB8976452301" | xxd -r > mac.bin
> $ sudo ethtool -E eth0 magic 0x8870 offset 2 < mac.bin
>
> Signed-off-by: Sebastien Jan <s-jan@ti.com>
Applied.
^ permalink raw reply
* Re: [PATCH 2/4 v2] ks8851: Low level functions for read/write to companion eeprom
From: David Miller @ 2010-05-06 7:20 UTC (permalink / raw)
To: s-jan; +Cc: netdev, linux-omap, x0066660, ben-linux, Tristram.Ha
In-Reply-To: <1273085155-1260-3-git-send-email-s-jan@ti.com>
From: Sebastien Jan <s-jan@ti.com>
Date: Wed, 5 May 2010 20:45:53 +0200
> Low-level functions provide 16bits words read and write capability
> to ks8851 companion eeprom.
>
> Signed-off-by: Sebastien Jan <s-jan@ti.com>
Applied.
^ permalink raw reply
* Re: [PATCH 1/4 v2] ks8851: Add caching of CCR register
From: David Miller @ 2010-05-06 7:20 UTC (permalink / raw)
To: s-jan; +Cc: netdev, linux-omap, x0066660, ben-linux, Tristram.Ha
In-Reply-To: <1273085155-1260-2-git-send-email-s-jan@ti.com>
From: Sebastien Jan <s-jan@ti.com>
Date: Wed, 5 May 2010 20:45:52 +0200
> CCR register contains information on companion eeprom availability.
>
> Signed-off-by: Sebastien Jan <s-jan@ti.com>
APplied.
^ permalink raw reply
* Re: [net-next-2.6 PATCH 4/4] e1000e: Save irq into netdev structure
From: David Miller @ 2010-05-06 7:19 UTC (permalink / raw)
To: jeffrey.t.kirsher; +Cc: netdev, gospo, therbert, bruce.w.allan
In-Reply-To: <20100506000330.8042.91540.stgit@localhost.localdomain>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Wed, 05 May 2010 17:03:32 -0700
> From: Tom Herbert <therbert@google.com>
>
> Set net->devirq to pdev->irq. This should be consistent with other
> drivers.
>
> Signed-off-by: Tom Herbert <therbert@google.com>
> Acked-by: Bruce Allan <bruce.w.allan@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied.
^ permalink raw reply
* Re: [net-next-2.6 PATCH 3/4] e1000e: Remove unnessary log message
From: David Miller @ 2010-05-06 7:19 UTC (permalink / raw)
To: jeffrey.t.kirsher; +Cc: netdev, gospo, therbert, bruce.w.allan
In-Reply-To: <20100506000309.8042.9387.stgit@localhost.localdomain>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Wed, 05 May 2010 17:03:11 -0700
> From: Tom Herbert <therbert@google.com>
>
> Remove e_info message printed whenever TSO is enabled or disabled.
> This is not very useful and just clutters dmesg.
>
> Signed-off-by: Tom Herbert <therbert@google.com>
> Acked-by: Bruce Allan <bruce.w.allan@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied.
^ permalink raw reply
* Re: [net-next-2.6 PATCH 2/4] e1000e: reduce writes of RX producer ptr
From: David Miller @ 2010-05-06 7:19 UTC (permalink / raw)
To: jeffrey.t.kirsher; +Cc: netdev, gospo, therbert, bruce.w.allan
In-Reply-To: <20100506000247.8042.97827.stgit@localhost.localdomain>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Wed, 05 May 2010 17:02:49 -0700
> From: Tom Herbert <therbert@google.com>
>
> Reduce number of writes to RX producer pointer. When alloc'ing RX
> buffers, only write the RX producer pointer once every
> E1000_RX_BUFFER_WRITE (16) buffers created.
>
> Signed-off-by: Tom Herbert <therbert@google.com>
> Acked-by: Bruce Allan <bruce.w.allan@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied.
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox