* Re: [PATCH 0/6] netns support in the kobject layer
From: Greg KH @ 2010-05-17 22:54 UTC (permalink / raw)
To: Eric W. Biederman
Cc: Greg KH, David Miller, kay.sievers, linux-kernel, tj,
cornelia.huck, eric.dumazet, bcrl, serue, netdev
In-Reply-To: <m1hbm6f93x.fsf@fess.ebiederm.org>
On Mon, May 17, 2010 at 03:37:22PM -0700, Eric W. Biederman wrote:
> Greg KH <gregkh@suse.de> writes:
>
> > On Mon, May 17, 2010 at 01:58:44PM -0700, Eric W. Biederman wrote:
> >> Greg KH <greg@kroah.com> writes:
> >>
> >> > On Sat, May 15, 2010 at 11:26:43PM -0700, David Miller wrote:
> >> >> From: Greg KH <greg@kroah.com>
> >> >> Date: Thu, 6 May 2010 13:04:04 -0700
> >> >>
> >> >> > On Tue, May 04, 2010 at 05:35:54PM -0700, Eric W. Biederman wrote:
> >> >> >>
> >> >> >> With the tagged sysfs support finally merged into Greg's tree,
> >> >> >> it is time for the last little bits of work to get the kobject
> >> >> >> layer and network namespaces to play together properly.
> >> >> >>
> >> >> >> These patches are roughly evenly divided between network layer work
> >> >> >> and sysfs layer work. Last time this conundrum came up I believe
> >> >> >> we decided that the easiest way to handle this was for Greg to carry
> >> >> >> all of the patches. David, Greg does that still make sense?
> >> >> >
> >> >> > That's fine, if I get David's ack on these.
> >> >>
> >> >> Looks good to me:
> >> >>
> >> >> Acked-by: David S. Miller <davem@davemloft.net>
> >> >
> >> > Ok. Eric, can you resend these to me when .35-rc1 is out so I can queue
> >> > them up then to get some testing in linux-next so that they can make it
> >> > into .36?
> >>
> >> Grumble. Grumble. Grumble.
> >>
> >> If I must I will resend these, but these patches are already in
> >> production use, and I had them to you weeks before the merge window
> >> closed.
> >
> > Yes, but they were not reviewed by the network maintainer until after
> > the merge window closed.
>
> Strictly speaking the day before but I get your point.
>
> > I already have your sysfs-namespace patches
> > queued up for .35, and that's a big enough change for me to feel
> > comfortable with at the moment.
> >
> >> Is there no way we can get these in for 2.6.35?
> >
> > No, sorry. One thing at a time please.
>
> Sure.
>
> If we are going to push this last bit off until the 2.6.36 time frame
> Dave, Greg mind if I flip around who I send these patches to?
>
> The big dependency is the sysfs-namespace patches which will be in
> 2.6.35, and if the patches get into net-next as well as linux-next
> there will be a larger number of potential testers.
Sure, that's fine with me.
thanks,
greg k-h
^ permalink raw reply
* Re: [PATCH 0/6] netns support in the kobject layer
From: David Miller @ 2010-05-17 23:48 UTC (permalink / raw)
To: gregkh
Cc: ebiederm, greg, kay.sievers, linux-kernel, tj, cornelia.huck,
eric.dumazet, bcrl, serue, netdev
In-Reply-To: <20100517210318.GA6170@suse.de>
From: Greg KH <gregkh@suse.de>
Date: Mon, 17 May 2010 14:03:18 -0700
> On Mon, May 17, 2010 at 01:58:44PM -0700, Eric W. Biederman wrote:
>> Greg KH <greg@kroah.com> writes:
>>
>> If I must I will resend these, but these patches are already in
>> production use, and I had them to you weeks before the merge window
>> closed.
>
> Yes, but they were not reviewed by the network maintainer until after
> the merge window closed. I already have your sysfs-namespace patches
> queued up for .35, and that's a big enough change for me to feel
> comfortable with at the moment.
Greg, this is complete bullshit. I reviewed them last week, they are fine
and have been around forever.
Merge them in now, making them wait until 2.6.36 is completely rediculious.
^ permalink raw reply
* Re: [PATCH 1/1] ipv6 addrlabel: permit deletion of labels assigned to removed dev
From: David Miller @ 2010-05-18 0:08 UTC (permalink / raw)
To: fw; +Cc: netdev
In-Reply-To: <1273267893-22485-1-git-send-email-fw@strlen.de>
From: Florian Westphal <fw@strlen.de>
Date: Fri, 7 May 2010 23:31:33 +0200
> as addrlabels with an interface index are left alone when the
> interface gets removed this results in addrlabels that can no
> longer be removed.
>
> Restrict validation of index to adding new addrlabels.
>
> Signed-off-by: Florian Westphal <fw@strlen.de>
Applied, thanks Florian.
^ permalink raw reply
* Re: [PATCH 1/1] ibmveth: Add suspend/resume support
From: David Miller @ 2010-05-18 0:09 UTC (permalink / raw)
To: brking; +Cc: netdev
In-Reply-To: <201005071156.o47BuCYM007062@d03av03.boulder.ibm.com>
From: Brian King <brking@linux.vnet.ibm.com>
Date: Fri, 07 May 2010 13:56:08 -0500
>
> Adds support for resuming from suspend for IBM virtual ethernet devices.
> We may have lost an interrupt over the suspend, so we just kick the
> interrupt handler to process anything that is outstanding.
>
> Signed-off-by: Brian King <brking@linux.vnet.ibm.com>
Applied, thank you.
^ permalink raw reply
* Re: [PATCH] drivers/net/usb/asix.c Fix unaligned access
From: David Miller @ 2010-05-18 0:18 UTC (permalink / raw)
To: neiljay; +Cc: netdev
In-Reply-To: <AANLkTiliFhlbe7HAOyn9O3935MkmEuRumLKYY7Ew4DXQ@mail.gmail.com>
From: Neil Jones <neiljay@gmail.com>
Date: Mon, 10 May 2010 17:06:01 +0100
> Using this driver can cause unaligned accesses in the IP layer
> This has been fixed by aligning the skb data correctly using the
> spare room left over by the 4 byte header inserted between packets
> by the device.
>
> Signed-off-by: Neil Jones <NeilJay@gmail.com>
Applied, thanks.
^ permalink raw reply
* Re: [PATCH 1/9] netdev: bfin_mac: add support for IEEE 1588 PTP
From: David Miller @ 2010-05-18 0:21 UTC (permalink / raw)
To: vapier; +Cc: netdev, uclinux-dist-devel, barry.song
In-Reply-To: <1273505954-32588-1-git-send-email-vapier@gentoo.org>
From: Mike Frysinger <vapier@gentoo.org>
Date: Mon, 10 May 2010 11:39:06 -0400
> Newer on-chip MAC peripherals support IEEE 1588 PTP in the hardware, so
> extend the driver to support this functionality.
>
> Signed-off-by: Barry Song <barry.song@analog.com>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
Applied.
^ permalink raw reply
* Re: [PATCH 2/9] netdev: bfin_mac: handler RX status errors
From: David Miller @ 2010-05-18 0:21 UTC (permalink / raw)
To: vapier; +Cc: netdev, uclinux-dist-devel, pmeerw, graf.yang
In-Reply-To: <1273505954-32588-2-git-send-email-vapier@gentoo.org>
From: Mike Frysinger <vapier@gentoo.org>
Date: Mon, 10 May 2010 11:39:07 -0400
> From: Peter Meerwald <pmeerw@pmeerw.net>
>
> Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
> Signed-off-by: Graf Yang <graf.yang@analog.com>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
Applied.
^ permalink raw reply
* Re: [PATCH 3/9] netdev: bfin_mac: invalid data cache only once for each new rx skb buffer
From: David Miller @ 2010-05-18 0:21 UTC (permalink / raw)
To: vapier; +Cc: netdev, uclinux-dist-devel, sonic.zhang
In-Reply-To: <1273505954-32588-3-git-send-email-vapier@gentoo.org>
From: Mike Frysinger <vapier@gentoo.org>
Date: Mon, 10 May 2010 11:39:08 -0400
> From: Sonic Zhang <sonic.zhang@analog.com>
>
> The skb buffer isn't actually used until we finish transferring and pass
> it up to higher layers, so only invalidate the range once before we start
> receiving actual data. This also avoids the problem with data invalidating
> on Blackfin systems -- there is no invalidate-only, just invalidate+flush.
> So when running in writeback mode, there is the small (but not uncommon)
> possibility of the flush overwriting valid DMA-ed data from the cache.
>
> Signed-off-by: Sonic Zhang <sonic.zhang@analog.com>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
Applied.
^ permalink raw reply
* Re: [PATCH 5/9] netdev: bfin_mac: clear RXCKS if hardware generated checksum is not enabled
From: David Miller @ 2010-05-18 0:21 UTC (permalink / raw)
To: vapier; +Cc: netdev, uclinux-dist-devel, sonic.zhang
In-Reply-To: <1273505954-32588-5-git-send-email-vapier@gentoo.org>
From: Mike Frysinger <vapier@gentoo.org>
Date: Mon, 10 May 2010 11:39:10 -0400
> From: Sonic Zhang <sonic.zhang@analog.com>
>
> Otherwise we might be get a setting mismatch from a previous module or
> bootloader and what the driver currently expects.
>
> Signed-off-by: Sonic Zhang <sonic.zhang@analog.com>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
Applied.
^ permalink raw reply
* Re: [PATCH 4/9 v2] netdev: bfin_mac: deduce Ethernet FCS from hardware IP payload checksum
From: David Miller @ 2010-05-18 0:21 UTC (permalink / raw)
To: vapier-aBrp7R+bbdUdnm+yROfE0A
Cc: netdev-u79uwXL29TY76Z2rM5mHXA, jon.kowal-obo422lQt0aqq+TXWfNVuQ,
uclinux-dist-devel-ZG0+EudsQA8dtHy/vicBwGD2FQJk+8+b
In-Reply-To: <1273505954-32588-4-git-send-email-vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>
From: Mike Frysinger <vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>
Date: Mon, 10 May 2010 11:39:09 -0400
> From: Sonic Zhang <sonic.zhang-OyLXuOCK7orQT0dZR+AlfA@public.gmane.org>
>
> IP checksum is based on 16-bit one's complement algorithm, so to deduce a
> value from checksum is equal to add its complement.
>
> Unfortunately, the Blackfin on-chip MAC checksum logic only works when the
> IP packet has a header length of 20 bytes. This is true for most IPv4
> packets, but not for IPv6 packets or IPv4 packets which use header options.
> So only use the hardware checksum when appropriate.
>
> Signed-off-by: Sonic Zhang <sonic.zhang-OyLXuOCK7orQT0dZR+AlfA@public.gmane.org>
> Signed-off-by: Jon Kowal <jon.kowal-obo422lQt0aqq+TXWfNVuQ@public.gmane.org>
> Signed-off-by: Mike Frysinger <vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>
Applied.
^ permalink raw reply
* Re: [PATCH 6/9] netdev: bfin_mac: add support for wake-on-lan magic packets
From: David Miller @ 2010-05-18 0:21 UTC (permalink / raw)
To: vapier; +Cc: netdev, uclinux-dist-devel, michael.hennerich
In-Reply-To: <1273505954-32588-6-git-send-email-vapier@gentoo.org>
From: Mike Frysinger <vapier@gentoo.org>
Date: Mon, 10 May 2010 11:39:11 -0400
> From: Michael Hennerich <michael.hennerich@analog.com>
>
> Note that WOL works only in PM Suspend Standby Mode (Sleep Mode).
>
> Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
Applied.
^ permalink raw reply
* Re: [PATCH 7/9] netdev: bfin_mac: use promiscuous flag for promiscuous mode
From: David Miller @ 2010-05-18 0:22 UTC (permalink / raw)
To: vapier; +Cc: netdev, uclinux-dist-devel, sonic.zhang
In-Reply-To: <1273505954-32588-7-git-send-email-vapier@gentoo.org>
From: Mike Frysinger <vapier@gentoo.org>
Date: Mon, 10 May 2010 11:39:12 -0400
> From: Sonic Zhang <sonic.zhang@analog.com>
>
> Rather than using the Receive All Frames (RAF) bit to enable promiscuous
> mode, use the Promiscuous (PR) bit. This lowers overhead at runtime as
> we let the hardware process the packets that should actually be checked.
>
> Signed-off-by: Sonic Zhang <sonic.zhang@analog.com>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
Applied.
^ permalink raw reply
* Re: [PATCH 8/9] netdev: bfin_mac: handle timeouts with the MDIO registers gracefully
From: David Miller @ 2010-05-18 0:22 UTC (permalink / raw)
To: vapier; +Cc: netdev, uclinux-dist-devel
In-Reply-To: <1273505954-32588-8-git-send-email-vapier@gentoo.org>
From: Mike Frysinger <vapier@gentoo.org>
Date: Mon, 10 May 2010 11:39:13 -0400
> Have the low level MDIO functions pass back up timeout information so we
> don't waste time polling them multiple times when there is a problem, and
> so we don't let higher layers think the device is available when it isn't.
>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
Applied.
^ permalink raw reply
* Re: [PATCH 9/9] netdev: bfin_mac: check for mii_bus platform data
From: David Miller @ 2010-05-18 0:22 UTC (permalink / raw)
To: vapier; +Cc: netdev, uclinux-dist-devel, sonic.zhang
In-Reply-To: <1273505954-32588-9-git-send-email-vapier@gentoo.org>
From: Mike Frysinger <vapier@gentoo.org>
Date: Mon, 10 May 2010 11:39:14 -0400
> From: Sonic Zhang <sonic.zhang@analog.com>
>
> If the platform data for the mii_bus is missing, gracefully error out
> rather than deference NULL pointers.
>
> Signed-off-by: Sonic Zhang <sonic.zhang@analog.com>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
Applied.
^ permalink raw reply
* Re: [PATCH V4 0/4] net: relax dst refcnt for net-next-2.6
From: David Miller @ 2010-05-18 0:22 UTC (permalink / raw)
To: eric.dumazet; +Cc: netdev
In-Reply-To: <1273525716.2590.313.camel@edumazet-laptop>
All applied, thanks Eric.
I made sure to use the updated version of patch 1/4
^ permalink raw reply
* Re: [PATCH net-next-2.6] rps: avoid one atomic in enqueue_to_backlog
From: David Miller @ 2010-05-18 0:22 UTC (permalink / raw)
To: eric.dumazet; +Cc: netdev, therbert
In-Reply-To: <1273225881.2261.39.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Fri, 07 May 2010 11:51:21 +0200
> Le vendredi 07 mai 2010 à 07:16 +0200, Eric Dumazet a écrit :
>> Le jeudi 06 mai 2010 à 22:07 -0700, David Miller a écrit :
>>
>> > Looks great, applied, thanks Eric.
>>
>> Thanks, I have a followup to avoid one atomic in enqueue phase too ;)
>>
>
> [PATCH net-next-2.6] rps: avoid one atomic in enqueue_to_backlog
>
> If CONFIG_SMP=y, then we own a queue spinlock, we can avoid the atomic
> test_and_set_bit() from napi_schedule_prep().
>
> We now have same number of atomic ops per netif_rx() calls than with
> pre-RPS kernel.
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Also applied, thanks Eric.
^ permalink raw reply
* Re: [PATCH NEXT 0/7]qlcnic: bug fixes
From: David Miller @ 2010-05-18 0:31 UTC (permalink / raw)
To: amit.salecha; +Cc: netdev, ameen.rahman
In-Reply-To: <1274095334-32362-1-git-send-email-amit.salecha@qlogic.com>
From: Amit Kumar Salecha <amit.salecha@qlogic.com>
Date: Mon, 17 May 2010 04:22:07 -0700
> Series of 7 patches to fix minor bugs. Please apply them on
> net-next.
All applied, thank you.
^ permalink raw reply
* Re: [PATCH -next 1/2] bnx2: Fix register printouts during NETEV_WATCHDOG.
From: David Miller @ 2010-05-18 0:33 UTC (permalink / raw)
To: mchan; +Cc: netdev
In-Reply-To: <1273533539-8646-1-git-send-email-mchan@broadcom.com>
From: "Michael Chan" <mchan@broadcom.com>
Date: Mon, 10 May 2010 16:18:58 -0700
> From: Eddie Wai <waie@broadcom.com>
>
> Dump the correct MCP registers and add EMAC_RX_STATUS register during
> NETDEV_WATCHDOG for debugging.
>
> Signed-off-by: Eddie Wai <waie@broadcom.com>
> Signed-off-by: Benjamin Li <benli@broadcom.com>
> Signed-off-by: Michael Chan <mchan@broadcom.com>
Applied.
^ permalink raw reply
* Re: [PATCH -next 2/2] bnx2: Update 5709 MIPS firmware and version to 2.0.15.
From: David Miller @ 2010-05-18 0:33 UTC (permalink / raw)
To: mchan; +Cc: netdev
In-Reply-To: <1273533539-8646-2-git-send-email-mchan@broadcom.com>
From: "Michael Chan" <mchan@broadcom.com>
Date: Mon, 10 May 2010 16:18:59 -0700
> New firmware fixes a performance regression on small packets.
>
> Signed-off-by: Michael Chan <mchan@broadcom.com>
Also applied, thanks!
^ permalink raw reply
* Re: [PATCH -next] bnx2: Use netif_carrier_off() to prevent timeout.
From: David Miller @ 2010-05-18 0:34 UTC (permalink / raw)
To: mchan; +Cc: sgruszka, netdev
In-Reply-To: <1273762115-13412-1-git-send-email-mchan@broadcom.com>
From: "Michael Chan" <mchan@broadcom.com>
Date: Thu, 13 May 2010 07:48:35 -0700
> Based on original patch from Stanislaw Gruszka <sgruszka@redhat.com>.
>
> Using netif_carrier_off() is better than updating all the ->trans_start
> on all the tx queues.
>
> netif_carrier_off() needs to be called after bnx2_disable_int_sync()
> to guarantee no race conditions with the serdes timers that can
> modify the carrier state.
>
> If the chip or phy is reset, carrier will turn back on when we get the
> link interrupt. If there is no reset, we need to turn carrier back on
> in bnx2_netif_start(). Again, the phy_lock prevents race conditions with
> the serdes timers.
>
> Signed-off-by: Michael Chan <mchan@broadcom.com>
> Signed-off-by: Matt Carlson <mcarlson@broadcom.com>
Applied, thanks.
^ permalink raw reply
* Re: [PATCH resend] bnx2x: avoid TX timeout when stopping device
From: David Miller @ 2010-05-18 0:35 UTC (permalink / raw)
To: sgruszka; +Cc: netdev, eilong, vladz, dmitry
In-Reply-To: <20100517123406.GA2504@dhcp-lab-161.englab.brq.redhat.com>
From: Stanislaw Gruszka <sgruszka@redhat.com>
Date: Mon, 17 May 2010 14:34:06 +0200
> When stop device call netif_carrier_off() just after disabling TX queue to
> avoid possibility of netdev watchdog warning and ->ndo_tx_timeout() invocation.
>
> Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
> Acked-by: Eilon Greenstein <eilong@broadcom.com>
Applied, thank you.
^ permalink raw reply
* Re: [PATCH 1/4] X25: Move qbit flag to bitfield
From: David Miller @ 2010-05-18 0:39 UTC (permalink / raw)
To: andrew.hendry; +Cc: netdev
In-Reply-To: <1274086781.4104.52.camel@ibex>
From: Andrew Hendry <andrew.hendry@gmail.com>
Date: Mon, 17 May 2010 18:59:41 +1000
> Moves the X25 q bit flag from char into a bitfield to allow BKL cleanup.
>
> Signed-off-by: Andrew Hendry <andrew.hendry@gmail.com>
Applied.
^ permalink raw reply
* Re: [PATCH 2/4] X25: Move interrupt flag to bitfield
From: David Miller @ 2010-05-18 0:39 UTC (permalink / raw)
To: andrew.hendry; +Cc: netdev
In-Reply-To: <1274086802.4104.53.camel@ibex>
From: Andrew Hendry <andrew.hendry@gmail.com>
Date: Mon, 17 May 2010 19:00:02 +1000
> Moves the x25 interrupt flag from char into bitfield.
>
> Signed-off-by: Andrew Hendry <andrew.hendry@gmail.com>
Applied.
^ permalink raw reply
* Re: [PATCH 3/4] X25: Move accept approve flag to bitfield
From: David Miller @ 2010-05-18 0:39 UTC (permalink / raw)
To: andrew.hendry; +Cc: netdev
In-Reply-To: <1274086827.4104.54.camel@ibex>
From: Andrew Hendry <andrew.hendry@gmail.com>
Date: Mon, 17 May 2010 19:00:27 +1000
>
> Moves the x25 accept approve flag from char into bitfield.
>
> Signed-off-by: Andrew Hendry <andrew.hendry@gmail.com>
Applied.
^ permalink raw reply
* Re: [PATCH 4/4] X25: Remove bkl in sockopts
From: David Miller @ 2010-05-18 0:39 UTC (permalink / raw)
To: andrew.hendry; +Cc: netdev
In-Reply-To: <1274086835.4104.55.camel@ibex>
From: Andrew Hendry <andrew.hendry@gmail.com>
Date: Mon, 17 May 2010 19:00:35 +1000
>
> Removes the BKL in x25 setsock and getsockopts.
>
> Signed-off-by: Andrew Hendry <andrew.hendry@gmail.com>
Applied.
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox