* Re: [PATCH net-next-2.6 1/2] net: Get rid of rtnl_link_stats64 / net_device_stats union
From: Eric Dumazet @ 2010-07-09 4:25 UTC (permalink / raw)
To: Ben Hutchings; +Cc: David Miller, netdev, linux-net-drivers
In-Reply-To: <1278631762.16013.307.camel@achroite.uk.solarflarecom.com>
Le vendredi 09 juillet 2010 à 00:29 +0100, Ben Hutchings a écrit :
> In commit be1f3c2c027cc5ad735df6a45a542ed1db7ec48b "net: Enable 64-bit
> net device statistics on 32-bit architectures" I redefined struct
> net_device_stats so that it could be used in a union with struct
> rtnl_link_stats64, avoiding the need for explicit copying or
> conversion between the two. However, this is unsafe because there is
> no locking required and no lock consistently held around calls to
> dev_get_stats() and use of the statistics structure it returns.
>
> In commit 28172739f0a276eb8d6ca917b3974c2edb036da3 "net: fix 64 bit
> counters on 32 bit arches" Eric Dumazet dealt with that problem by
> requiring callers of dev_get_stats() to provide storage for the
> result. This means that the net_device::stats64 field and the padding
> in struct net_device_stats are now redundant, so remove them.
>
> Update the comment on net_device_ops::ndo_get_stats64 to reflect its
> new usage.
>
> Change dev_txq_stats_fold() to use struct rtnl_link_stats64, since
> that is what all its callers are really using and it is no longer
> going to be compatible with struct net_device_stats.
>
> Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
> ---
> drivers/net/macvlan.c | 2 +-
> include/linux/netdevice.h | 70 ++++++++++++++++++---------------------------
> net/8021q/vlan_dev.c | 2 +-
> net/core/dev.c | 19 +++++++++---
> 4 files changed, 44 insertions(+), 49 deletions(-)
>
> diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c
> index 6112f14..1b28aae 100644
> --- a/drivers/net/macvlan.c
> +++ b/drivers/net/macvlan.c
> @@ -436,7 +436,7 @@ static struct rtnl_link_stats64 *macvlan_dev_get_stats64(struct net_device *dev,
> {
> struct macvlan_dev *vlan = netdev_priv(dev);
>
> - dev_txq_stats_fold(dev, (struct net_device_stats *)stats);
> + dev_txq_stats_fold(dev, stats);
>
> if (vlan->rx_stats) {
> struct macvlan_rx_stats *p, accum = {0};
> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
> index 8018f6b..17e95e3 100644
> --- a/include/linux/netdevice.h
> +++ b/include/linux/netdevice.h
> @@ -162,42 +162,32 @@ static inline bool dev_xmit_complete(int rc)
> /*
> * Old network device statistics. Fields are native words
> * (unsigned long) so they can be read and written atomically.
> - * Each field is padded to 64 bits for compatibility with
> - * rtnl_link_stats64.
> */
>
> -#if BITS_PER_LONG == 64
> -#define NET_DEVICE_STATS_DEFINE(name) unsigned long name
> -#elif defined(__LITTLE_ENDIAN)
> -#define NET_DEVICE_STATS_DEFINE(name) unsigned long name, pad_ ## name
> -#else
> -#define NET_DEVICE_STATS_DEFINE(name) unsigned long pad_ ## name, name
> -#endif
> -
> struct net_device_stats {
> - NET_DEVICE_STATS_DEFINE(rx_packets);
> - NET_DEVICE_STATS_DEFINE(tx_packets);
> - NET_DEVICE_STATS_DEFINE(rx_bytes);
> - NET_DEVICE_STATS_DEFINE(tx_bytes);
> - NET_DEVICE_STATS_DEFINE(rx_errors);
> - NET_DEVICE_STATS_DEFINE(tx_errors);
> - NET_DEVICE_STATS_DEFINE(rx_dropped);
> - NET_DEVICE_STATS_DEFINE(tx_dropped);
> - NET_DEVICE_STATS_DEFINE(multicast);
> - NET_DEVICE_STATS_DEFINE(collisions);
> - NET_DEVICE_STATS_DEFINE(rx_length_errors);
> - NET_DEVICE_STATS_DEFINE(rx_over_errors);
> - NET_DEVICE_STATS_DEFINE(rx_crc_errors);
> - NET_DEVICE_STATS_DEFINE(rx_frame_errors);
> - NET_DEVICE_STATS_DEFINE(rx_fifo_errors);
> - NET_DEVICE_STATS_DEFINE(rx_missed_errors);
> - NET_DEVICE_STATS_DEFINE(tx_aborted_errors);
> - NET_DEVICE_STATS_DEFINE(tx_carrier_errors);
> - NET_DEVICE_STATS_DEFINE(tx_fifo_errors);
> - NET_DEVICE_STATS_DEFINE(tx_heartbeat_errors);
> - NET_DEVICE_STATS_DEFINE(tx_window_errors);
> - NET_DEVICE_STATS_DEFINE(rx_compressed);
> - NET_DEVICE_STATS_DEFINE(tx_compressed);
> + unsigned long rx_packets;
> + unsigned long tx_packets;
> + unsigned long rx_bytes;
> + unsigned long tx_bytes;
> + unsigned long rx_errors;
> + unsigned long tx_errors;
> + unsigned long rx_dropped;
> + unsigned long tx_dropped;
> + unsigned long multicast;
> + unsigned long collisions;
> + unsigned long rx_length_errors;
> + unsigned long rx_over_errors;
> + unsigned long rx_crc_errors;
> + unsigned long rx_frame_errors;
> + unsigned long rx_fifo_errors;
> + unsigned long rx_missed_errors;
> + unsigned long tx_aborted_errors;
> + unsigned long tx_carrier_errors;
> + unsigned long tx_fifo_errors;
> + unsigned long tx_heartbeat_errors;
> + unsigned long tx_window_errors;
> + unsigned long rx_compressed;
> + unsigned long tx_compressed;
> };
>
> #endif /* __KERNEL__ */
> @@ -666,14 +656,13 @@ struct netdev_rx_queue {
> * Callback uses when the transmitter has not made any progress
> * for dev->watchdog ticks.
> *
> - * struct rtnl_link_stats64* (*ndo_get_stats64)(struct net_device *dev
> + * struct rtnl_link_stats64* (*ndo_get_stats64)(struct net_device *dev,
> * struct rtnl_link_stats64 *storage);
> * struct net_device_stats* (*ndo_get_stats)(struct net_device *dev);
> * Called when a user wants to get the network device usage
> * statistics. Drivers must do one of the following:
> - * 1. Define @ndo_get_stats64 to update a rtnl_link_stats64 structure
> - * (which should normally be dev->stats64) and return a ponter to
> - * it. The structure must not be changed asynchronously.
> + * 1. Define @ndo_get_stats64 to fill in a zero-initialised
> + * rtnl_link_stats64 structure passed by the caller.
> * 2. Define @ndo_get_stats to update a net_device_stats structure
> * (which should normally be dev->stats) and return a pointer to
> * it. The structure may be changed asynchronously only if each
> @@ -888,10 +877,7 @@ struct net_device {
> int ifindex;
> int iflink;
>
> - union {
> - struct rtnl_link_stats64 stats64;
> - struct net_device_stats stats;
> - };
> + struct net_device_stats stats;
>
> #ifdef CONFIG_WIRELESS_EXT
> /* List of functions to handle Wireless Extensions (instead of ioctl).
> @@ -2147,7 +2133,7 @@ extern void dev_mcast_init(void);
> extern const struct rtnl_link_stats64 *dev_get_stats(struct net_device *dev,
> struct rtnl_link_stats64 *storage);
> extern void dev_txq_stats_fold(const struct net_device *dev,
> - struct net_device_stats *stats);
> + struct rtnl_link_stats64 *stats);
>
> extern int netdev_max_backlog;
> extern int netdev_tstamp_prequeue;
> diff --git a/net/8021q/vlan_dev.c b/net/8021q/vlan_dev.c
> index 7865a4c..e66c9bf 100644
> --- a/net/8021q/vlan_dev.c
> +++ b/net/8021q/vlan_dev.c
> @@ -805,7 +805,7 @@ static u32 vlan_ethtool_get_flags(struct net_device *dev)
>
> static struct rtnl_link_stats64 *vlan_dev_get_stats64(struct net_device *dev, struct rtnl_link_stats64 *stats)
> {
> - dev_txq_stats_fold(dev, (struct net_device_stats *)stats);
> + dev_txq_stats_fold(dev, stats);
>
> if (vlan_dev_info(dev)->vlan_rx_stats) {
> struct vlan_rx_stats *p, accum = {0};
> diff --git a/net/core/dev.c b/net/core/dev.c
> index eb4201c..5ec2eec 100644
> --- a/net/core/dev.c
> +++ b/net/core/dev.c
> @@ -5274,10 +5274,10 @@ void netdev_run_todo(void)
> /**
> * dev_txq_stats_fold - fold tx_queues stats
> * @dev: device to get statistics from
> - * @stats: struct net_device_stats to hold results
> + * @stats: struct rtnl_link_stats64 to hold results
> */
> void dev_txq_stats_fold(const struct net_device *dev,
> - struct net_device_stats *stats)
> + struct rtnl_link_stats64 *stats)
> {
> unsigned long tx_bytes = 0, tx_packets = 0, tx_dropped = 0;
> unsigned int i;
> @@ -5311,17 +5311,26 @@ const struct rtnl_link_stats64 *dev_get_stats(struct net_device *dev,
> struct rtnl_link_stats64 *storage)
> {
> const struct net_device_ops *ops = dev->netdev_ops;
> + size_t i, n = sizeof(*storage) / sizeof(u64);
> + u64 *stats64 = (u64 *)storage;
> + const unsigned long *stats;
>
> if (ops->ndo_get_stats64) {
> memset(storage, 0, sizeof(*storage));
> return ops->ndo_get_stats64(dev, storage);
> }
> +
> if (ops->ndo_get_stats) {
> - memcpy(storage, ops->ndo_get_stats(dev), sizeof(*storage));
> + stats = (const unsigned long *)ops->ndo_get_stats(dev);
> + for (i = 0; i < n; i++)
> + stats64[i] = stats[i];
This could be a small helper function, to hide the sizeof(*storage) /
sizeof(u64) magic..
static void stats_to_stats64(struct rtnl_link_stats64 *dst,
const net_device_stats *src)
{
#if BITS_PER_LONG == 64
BUILD_BUG_ON(sizeof(*dst) != sizeof(*src));
memcpy(dst, src, sizeof(*src));
#else
size_t i, n = sizeof(*dst) / sizeof(u64);
u64 *stats64 = (u64 *)dst;
const unsigned long *stats = (const unsigned long *)src;
BUILD_BUG_ON(sizeof(*src) != n * sizeof(unsigned long));
for (i = 0; i < n, i++)
stats64[i] = stats[i];
#endif
}
Thanks !
^ permalink raw reply
* Re: [PATCH 1/1] Bluetooth: hidp: Add support for hidraw HIDIOCGFEATURE and HIDIOCSFEATURE
From: Alan Ott @ 2010-07-09 3:51 UTC (permalink / raw)
To: Marcel Holtmann
Cc: David S Miller, Jiri Kosina, Michael Poole, Bastien Nocera,
Eric Dumazet, linux-bluetooth-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
netdev-u79uwXL29TY76Z2rM5mHXA
In-Reply-To: <1278623485.10421.73.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
On 07/08/2010 05:11 PM, Marcel Holtmann wrote:
> I looked at this and I am bit worried that this should not be done in
> this detail in the HIDP driver. Essentially HIDP is a pure transport
> driver. It should not handle all these details. Can we make this a bit
> easier for the transport drivers to support such features?
>
> Regards
>
> Marcel
>
Hi Marcel,
I put these changes (most notably the addition of hidp_get_raw_report())
in hidp because that's where the parallel function
hidp_output_raw_report() was already located. I figured the input should
go with the output. That said, if there's a better place for both of
them (input and output) to go, let me know where you think it should be,
and I'll get them moved into the proper spot.
I'm not sure what you mean about HIDP being a pure transport driver.
Alan.
^ permalink raw reply
* Re: 2.6.35-rc4-git3: Reported regressions from 2.6.34
From: Shawn Starr @ 2010-07-09 3:36 UTC (permalink / raw)
To: Linus Torvalds
Cc: Rafael J. Wysocki, Linux Kernel Mailing List, Maciej Rutecki,
Andrew Morton, Kernel Testers List, Network Development,
Linux ACPI, Linux PM List, Linux SCSI List, Linux Wireless List,
DRI, Frederic Weisbecker, Al Viro, Jesse Barnes, Dave Airlie,
David S. Miller, Patrick McHardy, Jens Axboe
In-Reply-To: <AANLkTiknnzWyVpqnPCpyiEVHLgkewd0zaGzLInABRe2G@mail.gmail.com>
On Thursday, July 08, 2010 09:34:25 pm Linus Torvalds wrote:
> On Thu, Jul 8, 2010 at 4:33 PM, Rafael J. Wysocki <rjw@sisk.pl> wrote:
> > Unresolved regressions
> > ----------------------
> >
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16353
> > Subject : 2.6.35 regression
> > Submitter : Zeev Tarantov <zeev.tarantov@gmail.com>
> > Date : 2010-07-05 13:04 (4 days old)
> > Message-ID : <loom.20100705T144459-919@post.gmane.org>
> > References : http://marc.info/?l=linux-kernel&m=127836002702522&w=2
>
> This is a gcc-4.5 issue. Whether it's also something that we should
> change in the kernel is unclear, but at least as of now, the rule is
> that you cannot compile the kernel with gcc-4.5. No idea whether the
> compiler is just entirely broken, or whether it's just that it
> triggers something iffy by being overly clever.
>
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16346
> > Subject : 2.6.35-rc3-git8 - include/linux/fdtable.h:88 invoked
> > rcu_dereference_check() without protection! Submitter : Miles Lane
> > <miles.lane@gmail.com>
> > Date : 2010-07-04 22:04 (5 days old)
> > Message-ID :
> > <AANLkTinof0k28rk4rMr66aubxcRL2rFa5ZEArj1lqD3o@mail.gmail.com>
> > References : http://marc.info/?l=linux-kernel&m=127828107815930&w=2
>
> I'm not entirely sure if these RCU proving things should count as
> regressions.
>
> Sure, the option to enable RCU proving is new, but the things it
> reports about generally are not new - and they are usually not even
> bugs in the sense that they necessarily cause any real problems.
>
> That particular one is in the single-thread optimizated case for
> fget_light, ie
>
> if (likely((atomic_read(&files->count) == 1))) {
> file = fcheck_files(files, fd);
>
> where I think it should be entirely safe in all ways without any
> locking. So I think it's a false positive too.
>
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16334
> > Subject : reiserfs locking (v2)
> > Submitter : Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> > Date : 2010-07-02 9:34 (7 days old)
> > Message-ID : <20100702093451.GA3973@swordfish.minsk.epam.com>
> > References : http://marc.info/?l=linux-kernel&m=127806306303590&w=2
>
> Frederic? Al? I assume this is some late fallout from the BKL removal
> ages ago.. It's the old filldir-vs-mmap crud, but normally it should
> be impossible to trigger because the inode for a directory should
> never be mmap'able, so we should never have the same i_mutex lock used
> for both mmap and for filldir protection.
>
> We saw some of that oddity long ago, I wonder if it's lockdep being
> confused about some inodes.
>
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16333
> > Subject : iwl3945: HARDWARE GONE??
> > Submitter : Priit Laes <plaes@plaes.org>
> > Date : 2010-07-02 16:02 (7 days old)
> > Message-ID : <1278086575.2889.8.camel@chi>
> > References : http://marc.info/?l=linux-kernel&m=127808659705983&w=2
>
> This either got fixed, or will be practically impossible to debug. The
> reporter ends up being unable to reproduce the issue.
>
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16332
> > Subject : Kernel crashes in tty code (tty_open)
> > Submitter : werner@guyane.yi.org
> > Date : 2010-07-02 3:34 (7 days old)
> > Message-ID : <1278041650.12788@guyane.yi.org>
> > References : http://marc.info/?l=linux-kernel&m=127804167511930&w=2
>
> This seems to be due to CONFIG_MRST (Moorestown).
>
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16330
> > Subject : Dynamic Debug broken on 2.6.35-rc3?
> > Submitter : Thomas Renninger <trenn@suse.de>
> > Date : 2010-07-01 15:44 (8 days old)
> > Message-ID : <201007011744.19564.trenn@suse.de>
> > References : http://marc.info/?l=linux-kernel&m=127799907218877&w=2
>
> There's a suggested patch in
>
> http://marc.info/?l=linux-kernel&m=127862524404291&w=2
>
> but no reply to it yet.
>
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16329
> > Subject : 2.6.35-rc3: Load average climbing to 3+ with no
> > apparent reason: CPU 98% idle, with hardly no I/O Submitter :
> > Török Edwin <edwintorok@gmail.com>
> > Date : 2010-07-01 7:40 (8 days old)
> > Message-ID : <20100701104022.404410d6@debian>
> > References : http://marc.info/?l=linux-kernel&m=127797005030536&w=2
>
> This seems to be partly a confusion about what "load average" is. It's
> not a CPU load, it's a system load average, and disk-wait processes
> count towards it. He has some problem with his CD-ROM, and it sounds
> like it might be hardware on the verge of going bad.
>
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16324
> > Subject : Oops while running fs_racer test on a POWER6 box
> > against latest git Submitter : divya <dipraksh@linux.vnet.ibm.com>
> > Date : 2010-06-30 11:34 (9 days old)
> > Message-ID : <4C2B28F3.7000006@linux.vnet.ibm.com>
> > References : http://marc.info/?l=linux-kernel&m=127789697303061&w=2
>
> I wonder if this is the writeback problem. That POWER crash dump is
> unreadable, so it's hard to tell, but the load in question makes that
> at least likely.
>
> If so, it should hopefully be fixed in today's git (commit
> 83ba7b071f30f7c01f72518ad72d5cd203c27502 and friends).
>
> > Bug-entry : http://bugzilla.kernel.org/show_bug.cgi?id=16323
> > Subject : 2.6.35-rc3-git4 - kernel/sched.c:616 invoked
> > rcu_dereference_check() without protection! Submitter : Miles Lane
> > <miles.lane@gmail.com>
> > Date : 2010-07-01 12:21 (8 days old)
> > Message-ID :
> > <AANLkTini6hz2LFeZi8CMUmY3xw1MU7NxmyesuxZ4oCdo@mail.gmail.com>
> > References : http://marc.info/?l=linux-kernel&m=127798693125541&w=2
>
> See earlier about these being marked as regressions, but it should be
> fixed by commit dc61b1d6 ("sched: Fix PROVE_RCU vs cpu_cgroup").
>
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16322
> > Subject : WARNING: at /arch/x86/include/asm/processor.h:1005
> > read_measured_perf_ctrs+0x5a/0x70() Submitter : boris64
> > <bugzilla.kernel.org@boris64.net>
> > Date : 2010-07-01 13:54 (8 days old)
> > Handled-By : H. Peter Anvin <hpa@zytor.com>
>
> Magic. Strange and dark magic.
>
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16311
> > Subject : [REGRESSION][SUSPEND] 2.6.35-rcX won't suspend Lenovo
> > W500 laptop Submitter : Shawn Starr <shawn.starr@rogers.com>
> > Date : 2010-06-28 0:45 (11 days old)
> > Message-ID : <201006272045.17004.shawn.starr@rogers.com>
> > References : http://marc.info/?l=linux-kernel&m=127768633705286&w=2
>
> I think this might be usefully bisected. Shawn?
>
I'll have to try bisecting this weekend. It continues in Linux sh0n.net
2.6.35-rc4+ #1 SMP Wed Jul 7 23:58:41 EDT 2010 x86_64 x86_64 x86_64 GNU/Linux
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16309
> > Subject : 2.6.35-rc3 oops trying to suspend.
> > Submitter : Andrew Hendry <andrew.hendry@gmail.com>
> > Date : 2010-06-27 12:40 (12 days old)
> > Message-ID :
> > <AANLkTinUH2p33-AWxOVDrLsNkn9rgEVrlwn5mfK7P8NH@mail.gmail.com>
> > References : http://marc.info/?l=linux-kernel&m=127764249926781&w=2
>
> I'm pretty sure this was fixed by Nick in commit 57439f878afa ("fs:
> fix superblock iteration race").
>
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16307
> > Subject : i915 in kernel 2.6.35-rc3, high number of wakeups
> > Submitter : Enrico Bandiello <enban@postal.uv.es>
> > Date : 2010-06-26 16:57 (13 days old)
> > Message-ID : <4C26317A.5070309@postal.uv.es>
> > References : http://marc.info/?l=linux-kernel&m=127757403404259&w=2
>
> I don't think anybody noticed this one. Jesse?
>
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16304
> > Subject : i915 - high number of wakeups
> > Submitter : Enrico Bandiello <enban@postal.uv.es>
> > Date : 2010-06-27 09:52 (12 days old)
>
> Duplicate of that 16307 one.
>
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16284
> > Subject : Hitting WARN_ON in hw_breakpoint code
> > Submitter : Paul Mackerras <paulus@samba.org>
> > Date : 2010-06-23 12:57 (16 days old)
> > Message-ID : <20100623125740.GA3368@brick.ozlabs.ibm.com>
> > References : http://marc.info/?l=linux-kernel&m=127729789113432&w=2
>
> This has "I have a fix, will post it very soon." in the thread from
> Frederic, but I'm not seeing anything else. Frederic?
>
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16265
> > Subject : Why is kslowd accumulating so much CPU time?
> > Submitter : Theodore Ts'o <tytso@mit.edu>
> > Date : 2010-06-09 18:36 (30 days old)
> > First-Bad-Commit:
> > http://git.kernel.org/linus/fbf81762e385d3d45acad057b654d56972acf58c
> > Message-ID : <E1OMQ88-0002a1-Gb@closure.thunk.org>
> > References : http://marc.info/?l=linux-kernel&m=127610857819033&w=4
>
> Dave, Jesse?
>
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16234
> > Subject : [2.6.35-rc3] reboot mutex 'bug'...
> > Submitter : Daniel J Blueman <daniel.blueman@gmail.com>
> > Date : 2010-06-14 15:16 (25 days old)
> > Message-ID :
> > <AANLkTimDcTnyEPmt2ZcCM1UWtn4AYKotiqyjobJApkO7@mail.gmail.com>
> > References : http://marc.info/?l=linux-kernel&m=127652861118933&w=2
>
> Ok, this is definitely harmless. Whether we should silence the warning
> somehow is a separate question.
>
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16230
> > Subject : inconsistent IN-HARDIRQ-W -> HARDIRQ-ON-W usage:
> > fasync, 2.6.35-rc3 Submitter : Dominik Brodowski
> > <linux@dominikbrodowski.net> Date : 2010-06-13 9:53 (26 days
> > old)
> > Message-ID : <20100613095305.GA13231@comet.dominikbrodowski.net>
> > References : http://marc.info/?l=linux-kernel&m=127642282208277&w=2
>
> Fixed by commit f4985dc714d7.
>
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16228
> > Subject : BUG/boot failure on Dell Precision T3500
> > (pci/ahci_stop_engine) Submitter : Brian Bloniarz
> > <phunge0@hotmail.com>
> > Date : 2010-06-16 17:57 (23 days old)
> > Handled-By : Bjorn Helgaas <bjorn.helgaas@hp.com>
>
> This has a butt-ugly suggested patch that certainly won't be applied.
> I saw the thread, but lost sight of it. Jesse, did that end up with
> some resolution?
>
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16221
> > Subject : 2.6.35-rc2-git5 -- [drm:drm_mode_getfb] *ERROR* invalid
> > framebuffer id Submitter : Miles Lane <miles.lane@gmail.com>
> > Date : 2010-06-11 20:31 (28 days old)
> > Message-ID :
> > <AANLkTim0jVRyqkwlGOcrg_XTvUQwcBYfWJX-aRzkkrLG@mail.gmail.com>
> > References : http://marc.info/?l=linux-kernel&m=127628828119623&w=2
>
> I dunno. Old, and apparently seen by two people. Dave?
>
> Might be helped by bisection.
>
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16205
> > Subject : acpi: freeing invalid memtype bf799000-bf79a000
> > Submitter : Marcin Slusarz <marcin.slusarz@gmail.com>
> > Date : 2010-06-09 20:09 (30 days old)
> > Message-ID : <20100609200910.GA2876@joi.lan>
> > References : http://marc.info/?l=linux-kernel&m=127611427029914&w=2
> > http://marc.info/?l=linux-kernel&m=127688398513862&w=2
>
> This should be fixed by commit b945d6b2554d ("rbtree: Undo augmented
> trees performance damage and regression").
>
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16199
> > Subject : 2.6.35-rc2-git1 - include/linux/cgroup.h:534 invoked
> > rcu_dereference_check() without protection! Submitter : Miles Lane
> > <miles.lane@gmail.com>
> > Date : 2010-06-07 18:14 (32 days old)
> > Message-ID :
> > <AANLkTin2pPqOUx--9fIX3BH3e-cU6oCRufijcx_4ozx5@mail.gmail.com>
> > References : http://marc.info/?l=linux-kernel&m=127593447812015&w=2
>
> Another RCU proving thing. And this one looks the same as the 16323
> one above, and fixed by the same commit as that one.
>
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16197
> > Subject : [BUG on 2.6.35-rc2] sysfs: cannot create duplicate
> > filename '/devices/pci0000:00/0000:00:11.0/0000:02:03.0/slot' Submitter
> > : Ryan Wang <openspace.wang@gmail.com>
> > Date : 2010-06-07 0:23 (32 days old)
> > Message-ID :
> > <AANLkTincwMZPnYW3S4uz4k2GOn52RpgBIBRfzyD010Yo@mail.gmail.com>
> > References : http://marc.info/?l=linux-kernel&m=127587022219378&w=2
>
> These should all be gone. See commit 3be434f0244ee by Jesse ('Revert
> "PCI: create function symlinks in /sys/bus/pci/slots/N/"').
>
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16187
> > Subject : Carrier detection failed in dhcpcd when link is up
> > Submitter : Christian Casteyde <casteyde.christian@free.fr>
> > Date : 2010-06-12 15:15 (27 days old)
> > First-Bad-Commit:
> > http://git.kernel.org/linus/10708f37ae729baba9b67bd134c3720709d4ae62
> > Handled-By : Andrew Morton <akpm@linux-foundation.org>
>
> David? This bisects to a networking commit. Doesn't look sensible, but
> what do I know?
>
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16184
> > Subject : Container, X86-64, i386, iptables rule
> > Submitter : Jean-Marc Pigeon <jmp@safe.ca>
> > Date : 2010-06-12 04:17 (27 days old)
> > Handled-By : Patrick McHardy <kaber@trash.net>
>
> Patrick, Davem? Ping?
>
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16179
> > Subject : 2.6.35-rc2 completely hosed on intel gfx?
> > Submitter : Norbert Preining <preining@logic.at>
> > Date : 2010-06-06 11:55 (33 days old)
> > Message-ID : <20100606115534.GA9399@gamma.logic.tuwien.ac.at>
> > References : http://marc.info/?l=linux-kernel&m=127582534931581&w=2
>
> Hmm. That one is the vt.c bug coupled with another problem, which in
> turn got opened as a separate bugzilla entry:
>
> http://bugzilla.kernel.org/show_bug.cgi?id=16252
>
> which in turn then got closed. I dunno.
>
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16175
> > Subject : 2.6.35-rc1 system oom, many processes killed but memory
> > not free Submitter : andrew hendry <andrew.hendry@gmail.com>
> > Date : 2010-06-05 0:46 (34 days old)
> > Message-ID :
> > <AANLkTim7CiW-yfugZUAHZCqLvXKgt9CwolCvbLGdCLAk@mail.gmail.com>
> > References : http://marc.info/?l=linux-kernel&m=127569877714937&w=2
>
> Not a regression or a kernel bug at all. See the thread. Big ramdisk
> filled up all of memory when it was filled by the builds.
>
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16145
> > Subject : Unable to boot unless "notsc" or "clocksource=hpet", or
> > acpi_pad disabling the TSC Submitter : Tom Gundersen <teg@jklm.no>
> > Date : 2010-06-07 13:11 (32 days old)
> > Handled-By : Venkatesh Pallipadi <venki@google.com>
> > Len Brown <lenb@kernel.org>
>
> This is not a regression. See the full bugzilla details. The same
> problem persists at least back to 2.6.30 with his config. So it's
> somehow specific to his particular config use that requires "notsc" to
> boot.
>
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16122
> > Subject : 2.6.35-rc1: WARNING at fs/fs-writeback.c:1142
> > __mark_inode_dirty+0x103/0x170 Submitter : Larry Finger
> > <Larry.Finger@lwfinger.net>
> > Date : 2010-06-04 13:18 (35 days old)
> > Handled-By : Jens Axboe <axboe@kernel.dk>
>
> This looks like a duplicate of that 16312 bugzilla entry. Jens, has
> this been resolved?
>
> Linus
^ permalink raw reply
* Re: 2.6.35-rc4-git3: Reported regressions from 2.6.34
From: Frederic Weisbecker @ 2010-07-09 2:56 UTC (permalink / raw)
To: Linus Torvalds
Cc: Rafael J. Wysocki, Linux Kernel Mailing List, Maciej Rutecki,
Andrew Morton, Kernel Testers List, Network Development,
Linux ACPI, Linux PM List, Linux SCSI List, Linux Wireless List,
DRI, Al Viro, Shawn Starr, Jesse Barnes, Dave Airlie,
David S. Miller, Patrick McHardy, Jens Axboe
In-Reply-To: <AANLkTiknnzWyVpqnPCpyiEVHLgkewd0zaGzLInABRe2G@mail.gmail.com>
On Thu, Jul 08, 2010 at 06:34:25PM -0700, Linus Torvalds wrote:
> On Thu, Jul 8, 2010 at 4:33 PM, Rafael J. Wysocki <rjw@sisk.pl> wrote:
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16334
> > Subject : reiserfs locking (v2)
> > Submitter : Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> > Date : 2010-07-02 9:34 (7 days old)
> > Message-ID : <20100702093451.GA3973@swordfish.minsk.epam.com>
> > References : http://marc.info/?l=linux-kernel&m=127806306303590&w=2
>
> Frederic? Al? I assume this is some late fallout from the BKL removal
> ages ago.. It's the old filldir-vs-mmap crud, but normally it should
> be impossible to trigger because the inode for a directory should
> never be mmap'able, so we should never have the same i_mutex lock used
> for both mmap and for filldir protection.
>
> We saw some of that oddity long ago, I wonder if it's lockdep being
> confused about some inodes.
I think it has been there from the beginning. At least it was there before
the reiserfs bkl removal in .32.
Indeed the readdir <-> unmap/release inversion problem can not happen.
But Al said that can happen between write and release. (Although I don't see
where write takes the inode mutex).
He also highlighted the fact that reiserfs refcounting based on i_count
was totally broken.
He has a fix the whole in the vfs tree, in the for-next branch on commit
6c2bdaf089a3876226893fab00dd83596c465ad2
"Fix reiserfs_file_release()"
No more uses of the i_mutex on release after that, nor i_count, but a private
openers refcount and a tailpack mutex per reiserfs inode.
^ permalink raw reply
* Re: [PATCH linux-2.6.35-rc3] ks8842 driver
From: Simon Horman @ 2010-07-09 2:40 UTC (permalink / raw)
To: Choi, David; +Cc: netdev, Li, Charles
In-Reply-To: <C43529A246480145B0A6D0234BDB0F0D481D67@MELANITE.micrel.com>
On Thu, Jul 08, 2010 at 12:01:51PM -0700, Choi, David wrote:
> Hi Simon,
>
> Thank you for your comments.
>
> The original ks8842 driver is designed to work on the customized bus
> interface based on an FPGA. This patch is intended to address the more
> commonly used generic bus interface available on the majority of SoC in
> the market.
>
> It is unlikely that for a system to use both FPGA based and generic bus
> interface for ks8842, I am quite certain that those 2 devices are used
> mutual exclusively.
Hi David,
Understood, in that case I think that using #ifdef is reasonable.
Though to my mind it would be nicer to try and abstract it out,
as you have in the first hunk, to something of the form:
foo()
{
A
#ifdef CONFIG_MICREL_KS884X
B
#else
C
#endif
D
}
And then call foo() unconditionally.
I think this is cleaner than, for example ks8842_rx_frame()
where there are several instances of the same #ifdef condition.
>
> Regards,
> David J. Choi
>
>
> -----Original Message-----
> From: Simon Horman [mailto:horms@verge.net.au]
> Sent: Thursday, July 08, 2010 12:53 AM
> To: Choi, David
> Cc: netdev@vger.kernel.org; Li, Charles
> Subject: Re: [PATCH linux-2.6.35-rc3] ks8842 driver
>
> On Wed, Jul 07, 2010 at 08:24:33AM -0700, Choi, David wrote:
> > To whom it may have concerned,
> >
> > It seems that there are differences between Micrel ks8842 device and
> Timberdale FPGA based device with generic bus interface. In order to
> check the differences, I have sent several times but have not received
> any response. This patch is to support ks8841/ks8842 device from Micrel.
>
> Is it desirable that the code can never be compiled to work with both
> devices?
> Is this code likely to be included in a generic/distro kernel?
>
> >
> > From: David J. Choi <david.choi@micrel.com>
> >
> > Body of the explanation:
> > -support 16bit and 32bit bus width.
> > -add device reset for ks8842/8841 Micrel device.
> > -set 100Mbps as a default for Micrel device.
> > -set MAC address in both MAC/Switch layer with different sequence
> for Micrel device,
> > as mentioned in data sheet.
> >
> > Signed-off-by: David J. Choi <david.choi@micrel.com>
> >
> > ---
> > --- linux-2.6.35-rc3/drivers/net/ks8842.c.orig 2010-07-01
> 16:26:50.000000000 -0700
> > +++ linux-2.6.35-rc3/drivers/net/ks8842.c 2010-07-07
> 07:41:03.000000000 -0700
> > @@ -18,6 +18,7 @@
> >
> > /* Supports:
> > * The Micrel KS8842 behind the timberdale FPGA
> > + * The genuine Micrel KS8841/42 device with ISA 16/32bit bus
> interface
> > */
> >
> > #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> > @@ -191,6 +192,12 @@ static inline u32 ks8842_read32(struct k
> >
> > static void ks8842_reset(struct ks8842_adapter *adapter)
> > {
> > +#ifdef CONFIG_MICREL_KS884X
> > + ks8842_write16(adapter, 3, 1, REG_GRR);
> > + msleep(10);
> > + iowrite16(0, adapter->hw_addr + REG_GRR);
> > +
> > +#else
> > /* The KS8842 goes haywire when doing softare reset
> > * a work around in the timberdale IP is implemented to
> > * do a hardware reset instead
> > @@ -201,6 +208,7 @@ static void ks8842_reset(struct ks8842_a
> > iowrite16(32, adapter->hw_addr + REG_SELECT_BANK);
> > iowrite32(0x1, adapter->hw_addr + REG_TIMB_RST);
> > msleep(20);
> > +#endif
> > }
> >
> > static void ks8842_update_link_status(struct net_device *netdev,
> > @@ -269,8 +277,11 @@ static void ks8842_reset_hw(struct ks884
> >
> > /* restart port auto-negotiation */
> > ks8842_enable_bits(adapter, 49, 1 << 13, REG_P1CR4);
> > +
> > +#ifndef CONFIG_MICREL_KS884X
> > /* only advertise 10Mbps */
> > ks8842_clear_bits(adapter, 49, 3 << 2, REG_P1CR4);
> > +#endif
> >
> > /* Enable the transmitter */
> > ks8842_enable_tx(adapter);
> > @@ -296,6 +307,20 @@ static void ks8842_read_mac_addr(struct
> > for (i = 0; i < ETH_ALEN; i++)
> > dest[ETH_ALEN - i - 1] = ks8842_read8(adapter, 2,
> REG_MARL + i);
> >
> > +#ifdef CONFIG_MICREL_KS884X
> > + /*
> > + the sequence of saving mac addr between MAC and Switch
> is
> > + different.
> > + */
> > +
> > + mac = ks8842_read16(adapter, 2, REG_MARL);
> > + ks8842_write16(adapter, 39, mac, REG_MACAR3);
> > + mac = ks8842_read16(adapter, 2, REG_MARM);
> > + ks8842_write16(adapter, 39, mac, REG_MACAR2);
> > + mac = ks8842_read16(adapter, 2, REG_MARH);
> > + ks8842_write16(adapter, 39, mac, REG_MACAR1);
> > +#else
> > +
> > /* make sure the switch port uses the same MAC as the QMU */
> > mac = ks8842_read16(adapter, 2, REG_MARL);
> > ks8842_write16(adapter, 39, mac, REG_MACAR1);
> > @@ -303,6 +328,7 @@ static void ks8842_read_mac_addr(struct
> > ks8842_write16(adapter, 39, mac, REG_MACAR2);
> > mac = ks8842_read16(adapter, 2, REG_MARH);
> > ks8842_write16(adapter, 39, mac, REG_MACAR3);
> > +#endif
> > }
> >
> > static void ks8842_write_mac_addr(struct ks8842_adapter *adapter, u8
> *mac)
> > @@ -313,8 +339,13 @@ static void ks8842_write_mac_addr(struct
> > spin_lock_irqsave(&adapter->lock, flags);
> > for (i = 0; i < ETH_ALEN; i++) {
> > ks8842_write8(adapter, 2, mac[ETH_ALEN - i - 1],
> REG_MARL + i);
> > +#ifdef CONFIG_MICREL_KS884X
> > + ks8842_write8(adapter, 39, mac[ETH_ALEN - i - 1],
> > + REG_MACAR3 + 1 - i);
> > +#else
> > ks8842_write8(adapter, 39, mac[ETH_ALEN - i - 1],
> > REG_MACAR1 + i);
> > +#endif
> > }
> > spin_unlock_irqrestore(&adapter->lock, flags);
> > }
> > @@ -328,8 +359,12 @@ static int ks8842_tx_frame(struct sk_buf
> > {
> > struct ks8842_adapter *adapter = netdev_priv(netdev);
> > int len = skb->len;
> > +#ifdef CONFIG_KS884X_16BIT
> > + u16 *ptr16 = (u16 *)skb->data;
> > +#else
> > u32 *ptr = (u32 *)skb->data;
> > u32 ctrl;
> > +#endif
> >
> > dev_dbg(&adapter->pdev->dev,
> > "%s: len %u head %p data %p tail %p end %p\n",
> > @@ -340,6 +375,18 @@ static int ks8842_tx_frame(struct sk_buf
> > if (ks8842_tx_fifo_space(adapter) < len + 8)
> > return NETDEV_TX_BUSY;
> >
> > +#ifdef CONFIG_KS884X_16BIT
> > + ks8842_write16(adapter, 17, 0x8000 | 0x100, REG_QMU_DATA_LO);
> > + ks8842_write16(adapter, 17, (u16)len, REG_QMU_DATA_HI);
> > + netdev->stats.tx_bytes += len;
> > +
> > + /* copy buffer */
> > + while (len > 0) {
> > + iowrite16(*ptr16++, adapter->hw_addr + REG_QMU_DATA_LO);
> > + iowrite16(*ptr16++, adapter->hw_addr + REG_QMU_DATA_HI);
> > + len -= sizeof(u32);
> > + }
> > +#else
> > /* the control word, enable IRQ, port 1 and the length */
> > ctrl = 0x8000 | 0x100 | (len << 16);
> > ks8842_write32(adapter, 17, ctrl, REG_QMU_DATA_LO);
> > @@ -352,6 +399,7 @@ static int ks8842_tx_frame(struct sk_buf
> > len -= sizeof(u32);
> > ptr++;
> > }
> > +#endif
> >
> > /* enqueue packet */
> > ks8842_write16(adapter, 17, 1, REG_TXQCR);
> > @@ -364,10 +412,15 @@ static int ks8842_tx_frame(struct sk_buf
> > static void ks8842_rx_frame(struct net_device *netdev,
> > struct ks8842_adapter *adapter)
> > {
> > +#ifdef CONFIG_KS884X_16BIT
> > + u16 status = ks8842_read16(adapter, 17, REG_QMU_DATA_LO);
> > + int len = (int)ks8842_read16(adapter, 17, REG_QMU_DATA_HI) &
> 0xffff;
> > +#else
> > u32 status = ks8842_read32(adapter, 17, REG_QMU_DATA_LO);
> > int len = (status >> 16) & 0x7ff;
> >
> > status &= 0xffff;
> > +#endif
> >
> > dev_dbg(&adapter->pdev->dev, "%s - rx_data: status: %x\n",
> > __func__, status);
> > @@ -379,13 +432,28 @@ static void ks8842_rx_frame(struct net_d
> > dev_dbg(&adapter->pdev->dev, "%s, got package, len:
> %d\n",
> > __func__, len);
> > if (skb) {
> > +#ifdef CONFIG_KS884X_16BIT
> > + u16 *data16;
> > +#else
> > u32 *data;
> > +#endif
> >
> > netdev->stats.rx_packets++;
> > netdev->stats.rx_bytes += len;
> > if (status & RXSR_MULTICAST)
> > netdev->stats.multicast++;
> >
> > +#ifdef CONFIG_KS884X_16BIT
> > + data16 = (u16 *)skb_put(skb, len);
> > + ks8842_select_bank(adapter, 17);
> > + while (len > 0) {
> > + *data16++ = ioread16(adapter->hw_addr +
> > + REG_QMU_DATA_LO);
> > + *data16++ = ioread16(adapter->hw_addr +
> > + REG_QMU_DATA_HI);
> > + len -= sizeof(u32);
> > + }
> > +#else
> > data = (u32 *)skb_put(skb, len);
> >
> > ks8842_select_bank(adapter, 17);
> > @@ -397,6 +465,7 @@ static void ks8842_rx_frame(struct net_d
> >
> > skb->protocol = eth_type_trans(skb, netdev);
> > netif_rx(skb);
> > +#endif
> > } else
> > netdev->stats.rx_dropped++;
> > } else {
> > --- linux-2.6.35-rc3/drivers/net/Kconfig.orig 2010-07-02
> 15:52:41.000000000 -0700
> > +++ linux-2.6.35-rc3/drivers/net/Kconfig 2010-07-07
> 07:45:47.000000000 -0700
> > @@ -1748,11 +1748,29 @@ config TLAN
> > Please email feedback to <torben.mathiasen@compaq.com>.
> >
> > config KS8842
> > - tristate "Micrel KSZ8842"
> > + tristate "Micrel KSZ8841/42 with generic bus interface"
> > depends on HAS_IOMEM
> > help
> > - This platform driver is for Micrel KSZ8842 / KS8842
> > - 2-port ethernet switch chip (managed, VLAN, QoS).
> > + This platform driver is for KSZ8841(1-port) / KS8842(2-port)
> > + ethernet switch chip (managed, VLAN, QoS) from Micrel or
> > + Timberdale(FPGA).
> > +
> > +if KS8842
> > +config MICREL_KS884X
> > + boolean "KSZ8841/42 device from Micrel"
> > + default n
> > + help
> > + Say Y to use Micrel device. Otherwise Timberdale(FPGA) device
> is
> > + selected.
> > +
> > +config KS884X_16BIT
> > + boolean "16bit bus width"
> > + default y
> > + help
> > + This option specifies 16bit or 32bit bus interface. Say Y to
> use
> > + 16bit bus. Otherwise 32bit bus is selected.
> > +
> > +endif # KS8842
> >
> > config KS8851
> > tristate "Micrel KS8851 SPI"
> > ---
> > --
> > To unsubscribe from this list: send the line "unsubscribe netdev" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* Re: 2.6.35-rc4-git3: Reported regressions from 2.6.34
From: Frederic Weisbecker @ 2010-07-09 2:04 UTC (permalink / raw)
To: Linus Torvalds
Cc: Rafael J. Wysocki, Linux Kernel Mailing List, Maciej Rutecki,
Andrew Morton, Kernel Testers List, Network Development,
Linux ACPI, Linux PM List, Linux SCSI List, Linux Wireless List,
DRI, Al Viro, Shawn Starr, Jesse Barnes, Dave Airlie,
David S. Miller, Patrick McHardy, Jens Axboe
In-Reply-To: <AANLkTiknnzWyVpqnPCpyiEVHLgkewd0zaGzLInABRe2G-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Thu, Jul 08, 2010 at 06:34:25PM -0700, Linus Torvalds wrote:
> On Thu, Jul 8, 2010 at 4:33 PM, Rafael J. Wysocki <rjw-KKrjLPT3xs0@public.gmane.org> wrote:
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16284
> > Subject : Hitting WARN_ON in hw_breakpoint code
> > Submitter : Paul Mackerras <paulus-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>
> > Date : 2010-06-23 12:57 (16 days old)
> > Message-ID : <20100623125740.GA3368-oklZEfemRj05kJ7NmlRacFaTQe2KTcn/@public.gmane.org>
> > References : http://marc.info/?l=linux-kernel&m=127729789113432&w=2
>
> This has "I have a fix, will post it very soon." in the thread from
> Frederic, but I'm not seeing anything else. Frederic?
Right. In fact it wasn't a regression. The per task breakpoint reservation
design was broken from the beginning and this warning has revealed the
problem. This only touched perf, and it did since perf support breakpoints.
Fortunately ptrace wasn't concerned by this problem, even not by side effects
of this.
The fix is invasive as it's a rewrite of a (little) part of the breakpoint
reservation. And since the symptom is only a warning and also breakpoints
never released from the constraint table (just a counter, no memory leak),
the fix is headed for 2.6.36.
It is ready in tip:/perf/core:
http://git.kernel.org/?p=linux/kernel/git/tip/linux-2.6-tip.git;a=commitdiff;h=45a73372efe4a63f44aa2e1125d4a777c2fdc8d8
I think this ticket can be safely closed.
Thanks.
^ permalink raw reply
* linux-next: manual merge of the wireless tree with the net tree
From: Stephen Rothwell @ 2010-07-09 1:51 UTC (permalink / raw)
To: John W. Linville
Cc: linux-next, linux-kernel, Luciano Coelho, Eric Dumazet,
David Miller, netdev
[-- Attachment #1: Type: text/plain, Size: 622 bytes --]
Hi John,
Today's linux-next merge of the wireless tree got a conflict in
drivers/net/wireless/wl12xx/wl1271_cmd.h between commit
ba2d3587912f82d1ab4367975b1df460db60fb1e ("drivers/net: use __packed
annotation") from the net tree and commit
34dd2aaac4a4b908c093980a9894fd878aeb6deb ("wl1271: moved scan operations
to a separate file") from the wireless tree.
I didn't bother changing __attribute((packed)) to __packed where this
code has been moved to. Maybe someone could write a patch to do that ...
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]
^ permalink raw reply
* Re: 2.6.35-rc4-git3: Reported regressions from 2.6.34
From: Linus Torvalds @ 2010-07-09 1:34 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Jens Axboe, DRI, Linux SCSI List, Patrick McHardy,
Network Development, Linux Wireless List,
Linux Kernel Mailing List, Jesse Barnes, David S. Miller,
Linux ACPI, Al Viro, Frederic Weisbecker, Dave Airlie,
Andrew Morton, Kernel Testers List, Shawn Starr, Linux PM List,
Maciej Rutecki
In-Reply-To: <-IGZ64uxA6G.A.P0H.bLmNMB@chimera>
On Thu, Jul 8, 2010 at 4:33 PM, Rafael J. Wysocki <rjw@sisk.pl> wrote:
>
> Unresolved regressions
> ----------------------
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16353
> Subject : 2.6.35 regression
> Submitter : Zeev Tarantov <zeev.tarantov@gmail.com>
> Date : 2010-07-05 13:04 (4 days old)
> Message-ID : <loom.20100705T144459-919@post.gmane.org>
> References : http://marc.info/?l=linux-kernel&m=127836002702522&w=2
This is a gcc-4.5 issue. Whether it's also something that we should
change in the kernel is unclear, but at least as of now, the rule is
that you cannot compile the kernel with gcc-4.5. No idea whether the
compiler is just entirely broken, or whether it's just that it
triggers something iffy by being overly clever.
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16346
> Subject : 2.6.35-rc3-git8 - include/linux/fdtable.h:88 invoked rcu_dereference_check() without protection!
> Submitter : Miles Lane <miles.lane@gmail.com>
> Date : 2010-07-04 22:04 (5 days old)
> Message-ID : <AANLkTinof0k28rk4rMr66aubxcRL2rFa5ZEArj1lqD3o@mail.gmail.com>
> References : http://marc.info/?l=linux-kernel&m=127828107815930&w=2
I'm not entirely sure if these RCU proving things should count as regressions.
Sure, the option to enable RCU proving is new, but the things it
reports about generally are not new - and they are usually not even
bugs in the sense that they necessarily cause any real problems.
That particular one is in the single-thread optimizated case for fget_light, ie
if (likely((atomic_read(&files->count) == 1))) {
file = fcheck_files(files, fd);
where I think it should be entirely safe in all ways without any
locking. So I think it's a false positive too.
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16334
> Subject : reiserfs locking (v2)
> Submitter : Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> Date : 2010-07-02 9:34 (7 days old)
> Message-ID : <20100702093451.GA3973@swordfish.minsk.epam.com>
> References : http://marc.info/?l=linux-kernel&m=127806306303590&w=2
Frederic? Al? I assume this is some late fallout from the BKL removal
ages ago.. It's the old filldir-vs-mmap crud, but normally it should
be impossible to trigger because the inode for a directory should
never be mmap'able, so we should never have the same i_mutex lock used
for both mmap and for filldir protection.
We saw some of that oddity long ago, I wonder if it's lockdep being
confused about some inodes.
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16333
> Subject : iwl3945: HARDWARE GONE??
> Submitter : Priit Laes <plaes@plaes.org>
> Date : 2010-07-02 16:02 (7 days old)
> Message-ID : <1278086575.2889.8.camel@chi>
> References : http://marc.info/?l=linux-kernel&m=127808659705983&w=2
This either got fixed, or will be practically impossible to debug. The
reporter ends up being unable to reproduce the issue.
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16332
> Subject : Kernel crashes in tty code (tty_open)
> Submitter : werner@guyane.yi.org
> Date : 2010-07-02 3:34 (7 days old)
> Message-ID : <1278041650.12788@guyane.yi.org>
> References : http://marc.info/?l=linux-kernel&m=127804167511930&w=2
This seems to be due to CONFIG_MRST (Moorestown).
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16330
> Subject : Dynamic Debug broken on 2.6.35-rc3?
> Submitter : Thomas Renninger <trenn@suse.de>
> Date : 2010-07-01 15:44 (8 days old)
> Message-ID : <201007011744.19564.trenn@suse.de>
> References : http://marc.info/?l=linux-kernel&m=127799907218877&w=2
There's a suggested patch in
http://marc.info/?l=linux-kernel&m=127862524404291&w=2
but no reply to it yet.
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16329
> Subject : 2.6.35-rc3: Load average climbing to 3+ with no apparent reason: CPU 98% idle, with hardly no I/O
> Submitter : Török Edwin <edwintorok@gmail.com>
> Date : 2010-07-01 7:40 (8 days old)
> Message-ID : <20100701104022.404410d6@debian>
> References : http://marc.info/?l=linux-kernel&m=127797005030536&w=2
This seems to be partly a confusion about what "load average" is. It's
not a CPU load, it's a system load average, and disk-wait processes
count towards it. He has some problem with his CD-ROM, and it sounds
like it might be hardware on the verge of going bad.
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16324
> Subject : Oops while running fs_racer test on a POWER6 box against latest git
> Submitter : divya <dipraksh@linux.vnet.ibm.com>
> Date : 2010-06-30 11:34 (9 days old)
> Message-ID : <4C2B28F3.7000006@linux.vnet.ibm.com>
> References : http://marc.info/?l=linux-kernel&m=127789697303061&w=2
I wonder if this is the writeback problem. That POWER crash dump is
unreadable, so it's hard to tell, but the load in question makes that
at least likely.
If so, it should hopefully be fixed in today's git (commit
83ba7b071f30f7c01f72518ad72d5cd203c27502 and friends).
> Bug-entry : http://bugzilla.kernel.org/show_bug.cgi?id=16323
> Subject : 2.6.35-rc3-git4 - kernel/sched.c:616 invoked rcu_dereference_check() without protection!
> Submitter : Miles Lane <miles.lane@gmail.com>
> Date : 2010-07-01 12:21 (8 days old)
> Message-ID : <AANLkTini6hz2LFeZi8CMUmY3xw1MU7NxmyesuxZ4oCdo@mail.gmail.com>
> References : http://marc.info/?l=linux-kernel&m=127798693125541&w=2
See earlier about these being marked as regressions, but it should be
fixed by commit dc61b1d6 ("sched: Fix PROVE_RCU vs cpu_cgroup").
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16322
> Subject : WARNING: at /arch/x86/include/asm/processor.h:1005 read_measured_perf_ctrs+0x5a/0x70()
> Submitter : boris64 <bugzilla.kernel.org@boris64.net>
> Date : 2010-07-01 13:54 (8 days old)
> Handled-By : H. Peter Anvin <hpa@zytor.com>
Magic. Strange and dark magic.
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16311
> Subject : [REGRESSION][SUSPEND] 2.6.35-rcX won't suspend Lenovo W500 laptop
> Submitter : Shawn Starr <shawn.starr@rogers.com>
> Date : 2010-06-28 0:45 (11 days old)
> Message-ID : <201006272045.17004.shawn.starr@rogers.com>
> References : http://marc.info/?l=linux-kernel&m=127768633705286&w=2
I think this might be usefully bisected. Shawn?
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16309
> Subject : 2.6.35-rc3 oops trying to suspend.
> Submitter : Andrew Hendry <andrew.hendry@gmail.com>
> Date : 2010-06-27 12:40 (12 days old)
> Message-ID : <AANLkTinUH2p33-AWxOVDrLsNkn9rgEVrlwn5mfK7P8NH@mail.gmail.com>
> References : http://marc.info/?l=linux-kernel&m=127764249926781&w=2
I'm pretty sure this was fixed by Nick in commit 57439f878afa ("fs:
fix superblock iteration race").
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16307
> Subject : i915 in kernel 2.6.35-rc3, high number of wakeups
> Submitter : Enrico Bandiello <enban@postal.uv.es>
> Date : 2010-06-26 16:57 (13 days old)
> Message-ID : <4C26317A.5070309@postal.uv.es>
> References : http://marc.info/?l=linux-kernel&m=127757403404259&w=2
I don't think anybody noticed this one. Jesse?
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16304
> Subject : i915 - high number of wakeups
> Submitter : Enrico Bandiello <enban@postal.uv.es>
> Date : 2010-06-27 09:52 (12 days old)
Duplicate of that 16307 one.
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16284
> Subject : Hitting WARN_ON in hw_breakpoint code
> Submitter : Paul Mackerras <paulus@samba.org>
> Date : 2010-06-23 12:57 (16 days old)
> Message-ID : <20100623125740.GA3368@brick.ozlabs.ibm.com>
> References : http://marc.info/?l=linux-kernel&m=127729789113432&w=2
This has "I have a fix, will post it very soon." in the thread from
Frederic, but I'm not seeing anything else. Frederic?
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16265
> Subject : Why is kslowd accumulating so much CPU time?
> Submitter : Theodore Ts'o <tytso@mit.edu>
> Date : 2010-06-09 18:36 (30 days old)
> First-Bad-Commit: http://git.kernel.org/linus/fbf81762e385d3d45acad057b654d56972acf58c
> Message-ID : <E1OMQ88-0002a1-Gb@closure.thunk.org>
> References : http://marc.info/?l=linux-kernel&m=127610857819033&w=4
Dave, Jesse?
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16234
> Subject : [2.6.35-rc3] reboot mutex 'bug'...
> Submitter : Daniel J Blueman <daniel.blueman@gmail.com>
> Date : 2010-06-14 15:16 (25 days old)
> Message-ID : <AANLkTimDcTnyEPmt2ZcCM1UWtn4AYKotiqyjobJApkO7@mail.gmail.com>
> References : http://marc.info/?l=linux-kernel&m=127652861118933&w=2
Ok, this is definitely harmless. Whether we should silence the warning
somehow is a separate question.
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16230
> Subject : inconsistent IN-HARDIRQ-W -> HARDIRQ-ON-W usage: fasync, 2.6.35-rc3
> Submitter : Dominik Brodowski <linux@dominikbrodowski.net>
> Date : 2010-06-13 9:53 (26 days old)
> Message-ID : <20100613095305.GA13231@comet.dominikbrodowski.net>
> References : http://marc.info/?l=linux-kernel&m=127642282208277&w=2
Fixed by commit f4985dc714d7.
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16228
> Subject : BUG/boot failure on Dell Precision T3500 (pci/ahci_stop_engine)
> Submitter : Brian Bloniarz <phunge0@hotmail.com>
> Date : 2010-06-16 17:57 (23 days old)
> Handled-By : Bjorn Helgaas <bjorn.helgaas@hp.com>
This has a butt-ugly suggested patch that certainly won't be applied.
I saw the thread, but lost sight of it. Jesse, did that end up with
some resolution?
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16221
> Subject : 2.6.35-rc2-git5 -- [drm:drm_mode_getfb] *ERROR* invalid framebuffer id
> Submitter : Miles Lane <miles.lane@gmail.com>
> Date : 2010-06-11 20:31 (28 days old)
> Message-ID : <AANLkTim0jVRyqkwlGOcrg_XTvUQwcBYfWJX-aRzkkrLG@mail.gmail.com>
> References : http://marc.info/?l=linux-kernel&m=127628828119623&w=2
I dunno. Old, and apparently seen by two people. Dave?
Might be helped by bisection.
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16205
> Subject : acpi: freeing invalid memtype bf799000-bf79a000
> Submitter : Marcin Slusarz <marcin.slusarz@gmail.com>
> Date : 2010-06-09 20:09 (30 days old)
> Message-ID : <20100609200910.GA2876@joi.lan>
> References : http://marc.info/?l=linux-kernel&m=127611427029914&w=2
> http://marc.info/?l=linux-kernel&m=127688398513862&w=2
This should be fixed by commit b945d6b2554d ("rbtree: Undo augmented
trees performance damage and regression").
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16199
> Subject : 2.6.35-rc2-git1 - include/linux/cgroup.h:534 invoked rcu_dereference_check() without protection!
> Submitter : Miles Lane <miles.lane@gmail.com>
> Date : 2010-06-07 18:14 (32 days old)
> Message-ID : <AANLkTin2pPqOUx--9fIX3BH3e-cU6oCRufijcx_4ozx5@mail.gmail.com>
> References : http://marc.info/?l=linux-kernel&m=127593447812015&w=2
Another RCU proving thing. And this one looks the same as the 16323
one above, and fixed by the same commit as that one.
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16197
> Subject : [BUG on 2.6.35-rc2] sysfs: cannot create duplicate filename '/devices/pci0000:00/0000:00:11.0/0000:02:03.0/slot'
> Submitter : Ryan Wang <openspace.wang@gmail.com>
> Date : 2010-06-07 0:23 (32 days old)
> Message-ID : <AANLkTincwMZPnYW3S4uz4k2GOn52RpgBIBRfzyD010Yo@mail.gmail.com>
> References : http://marc.info/?l=linux-kernel&m=127587022219378&w=2
These should all be gone. See commit 3be434f0244ee by Jesse ('Revert
"PCI: create function symlinks in /sys/bus/pci/slots/N/"').
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16187
> Subject : Carrier detection failed in dhcpcd when link is up
> Submitter : Christian Casteyde <casteyde.christian@free.fr>
> Date : 2010-06-12 15:15 (27 days old)
> First-Bad-Commit: http://git.kernel.org/linus/10708f37ae729baba9b67bd134c3720709d4ae62
> Handled-By : Andrew Morton <akpm@linux-foundation.org>
David? This bisects to a networking commit. Doesn't look sensible, but
what do I know?
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16184
> Subject : Container, X86-64, i386, iptables rule
> Submitter : Jean-Marc Pigeon <jmp@safe.ca>
> Date : 2010-06-12 04:17 (27 days old)
> Handled-By : Patrick McHardy <kaber@trash.net>
Patrick, Davem? Ping?
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16179
> Subject : 2.6.35-rc2 completely hosed on intel gfx?
> Submitter : Norbert Preining <preining@logic.at>
> Date : 2010-06-06 11:55 (33 days old)
> Message-ID : <20100606115534.GA9399@gamma.logic.tuwien.ac.at>
> References : http://marc.info/?l=linux-kernel&m=127582534931581&w=2
Hmm. That one is the vt.c bug coupled with another problem, which in
turn got opened as a separate bugzilla entry:
http://bugzilla.kernel.org/show_bug.cgi?id=16252
which in turn then got closed. I dunno.
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16175
> Subject : 2.6.35-rc1 system oom, many processes killed but memory not free
> Submitter : andrew hendry <andrew.hendry@gmail.com>
> Date : 2010-06-05 0:46 (34 days old)
> Message-ID : <AANLkTim7CiW-yfugZUAHZCqLvXKgt9CwolCvbLGdCLAk@mail.gmail.com>
> References : http://marc.info/?l=linux-kernel&m=127569877714937&w=2
Not a regression or a kernel bug at all. See the thread. Big ramdisk
filled up all of memory when it was filled by the builds.
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16145
> Subject : Unable to boot unless "notsc" or "clocksource=hpet", or acpi_pad disabling the TSC
> Submitter : Tom Gundersen <teg@jklm.no>
> Date : 2010-06-07 13:11 (32 days old)
> Handled-By : Venkatesh Pallipadi <venki@google.com>
> Len Brown <lenb@kernel.org>
This is not a regression. See the full bugzilla details. The same
problem persists at least back to 2.6.30 with his config. So it's
somehow specific to his particular config use that requires "notsc" to
boot.
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16122
> Subject : 2.6.35-rc1: WARNING at fs/fs-writeback.c:1142 __mark_inode_dirty+0x103/0x170
> Submitter : Larry Finger <Larry.Finger@lwfinger.net>
> Date : 2010-06-04 13:18 (35 days old)
> Handled-By : Jens Axboe <axboe@kernel.dk>
This looks like a duplicate of that 16312 bugzilla entry. Jens, has
this been resolved?
Linus
^ permalink raw reply
* Re: 2.6.35-rc4-git3: Reported regressions from 2.6.34
From: Andrew Hendry @ 2010-07-09 0:48 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Linux Kernel Mailing List, Maciej Rutecki, Andrew Morton,
Linus Torvalds, Kernel Testers List, Network Development,
Linux ACPI, Linux PM List, Linux SCSI List, Linux Wireless List,
DRI
In-Reply-To: <-IGZ64uxA6G.A.P0H.bLmNMB@chimera>
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16175
Subject : 2.6.35-rc1 system oom, many processes killed but
memory not free
Submitter : andrew hendry <andrew.hendry@gmail.com>
Date : 2010-06-05 0:46 (34 days old)
Message-ID : <AANLkTim7CiW-yfugZUAHZCqLvXKgt9CwolCvbLGdCLAk@mail.gmail.com>
References : http://marc.info/?l=linux-kernel&m=127569877714937&w=2
Can be put down to bad ramdisk settings > actual memory, its probably
not a regression.
I think it can be closed for now, i'll do some testing and see if
ramdisk should complain before letting such configuration go through.
On Fri, Jul 9, 2010 at 9:33 AM, Rafael J. Wysocki <rjw@sisk.pl> wrote:
> This message contains a list of some regressions from 2.6.34,
> for which there are no fixes in the mainline known to the tracking team.
> If any of them have been fixed already, please let us know.
>
> If you know of any other unresolved regressions from 2.6.34, please let us
> know either and we'll add them to the list. Also, please let us know
> if any of the entries below are invalid.
>
> Each entry from the list will be sent additionally in an automatic reply
> to this message with CCs to the people involved in reporting and handling
> the issue.
>
>
> Listed regressions statistics:
>
> Date Total Pending Unresolved
> ----------------------------------------
> 2010-07-09 79 45 37
> 2010-06-21 46 37 26
> 2010-06-09 15 13 10
>
>
> Unresolved regressions
> ----------------------
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16353
> Subject : 2.6.35 regression
> Submitter : Zeev Tarantov <zeev.tarantov@gmail.com>
> Date : 2010-07-05 13:04 (4 days old)
> Message-ID : <loom.20100705T144459-919@post.gmane.org>
> References : http://marc.info/?l=linux-kernel&m=127836002702522&w=2
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16346
> Subject : 2.6.35-rc3-git8 - include/linux/fdtable.h:88 invoked rcu_dereference_check() without protection!
> Submitter : Miles Lane <miles.lane@gmail.com>
> Date : 2010-07-04 22:04 (5 days old)
> Message-ID : <AANLkTinof0k28rk4rMr66aubxcRL2rFa5ZEArj1lqD3o@mail.gmail.com>
> References : http://marc.info/?l=linux-kernel&m=127828107815930&w=2
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16337
> Subject : general protection fault: 0000 [#1] SMP
> Submitter : Justin P. Mattock <justinmattock@gmail.com>
> Date : 2010-07-03 22:59 (6 days old)
> Message-ID : <4C2FC0E3.6050101@gmail.com>
> References : http://marc.info/?l=linux-kernel&m=127819798215589&w=2
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16334
> Subject : reiserfs locking (v2)
> Submitter : Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> Date : 2010-07-02 9:34 (7 days old)
> Message-ID : <20100702093451.GA3973@swordfish.minsk.epam.com>
> References : http://marc.info/?l=linux-kernel&m=127806306303590&w=2
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16333
> Subject : iwl3945: HARDWARE GONE??
> Submitter : Priit Laes <plaes@plaes.org>
> Date : 2010-07-02 16:02 (7 days old)
> Message-ID : <1278086575.2889.8.camel@chi>
> References : http://marc.info/?l=linux-kernel&m=127808659705983&w=2
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16332
> Subject : Kernel crashes in tty code (tty_open)
> Submitter : werner@guyane.yi.org
> Date : 2010-07-02 3:34 (7 days old)
> Message-ID : <1278041650.12788@guyane.yi.org>
> References : http://marc.info/?l=linux-kernel&m=127804167511930&w=2
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16330
> Subject : Dynamic Debug broken on 2.6.35-rc3?
> Submitter : Thomas Renninger <trenn@suse.de>
> Date : 2010-07-01 15:44 (8 days old)
> Message-ID : <201007011744.19564.trenn@suse.de>
> References : http://marc.info/?l=linux-kernel&m=127799907218877&w=2
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16329
> Subject : 2.6.35-rc3: Load average climbing to 3+ with no apparent reason: CPU 98% idle, with hardly no I/O
> Submitter : Török Edwin <edwintorok@gmail.com>
> Date : 2010-07-01 7:40 (8 days old)
> Message-ID : <20100701104022.404410d6@debian>
> References : http://marc.info/?l=linux-kernel&m=127797005030536&w=2
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16324
> Subject : Oops while running fs_racer test on a POWER6 box against latest git
> Submitter : divya <dipraksh@linux.vnet.ibm.com>
> Date : 2010-06-30 11:34 (9 days old)
> Message-ID : <4C2B28F3.7000006@linux.vnet.ibm.com>
> References : http://marc.info/?l=linux-kernel&m=127789697303061&w=2
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16323
> Subject : 2.6.35-rc3-git4 - kernel/sched.c:616 invoked rcu_dereference_check() without protection!
> Submitter : Miles Lane <miles.lane@gmail.com>
> Date : 2010-07-01 12:21 (8 days old)
> Message-ID : <AANLkTini6hz2LFeZi8CMUmY3xw1MU7NxmyesuxZ4oCdo@mail.gmail.com>
> References : http://marc.info/?l=linux-kernel&m=127798693125541&w=2
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16322
> Subject : WARNING: at /arch/x86/include/asm/processor.h:1005 read_measured_perf_ctrs+0x5a/0x70()
> Submitter : boris64 <bugzilla.kernel.org@boris64.net>
> Date : 2010-07-01 13:54 (8 days old)
> Handled-By : H. Peter Anvin <hpa@zytor.com>
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16312
> Subject : WARNING: at fs/fs-writeback.c:1127 __mark_inode_dirty
> Submitter : Zdenek Kabelac <zdenek.kabelac@gmail.com>
> Date : 2010-06-28 9:40 (11 days old)
> Message-ID : <AANLkTin24fr5O4_q5Xbo9Y_NKkEmtcp6Hgmr9_4qXaFz@mail.gmail.com>
> References : http://marc.info/?l=linux-kernel&m=127771804806465&w=2
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16311
> Subject : [REGRESSION][SUSPEND] 2.6.35-rcX won't suspend Lenovo W500 laptop
> Submitter : Shawn Starr <shawn.starr@rogers.com>
> Date : 2010-06-28 0:45 (11 days old)
> Message-ID : <201006272045.17004.shawn.starr@rogers.com>
> References : http://marc.info/?l=linux-kernel&m=127768633705286&w=2
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16309
> Subject : 2.6.35-rc3 oops trying to suspend.
> Submitter : Andrew Hendry <andrew.hendry@gmail.com>
> Date : 2010-06-27 12:40 (12 days old)
> Message-ID : <AANLkTinUH2p33-AWxOVDrLsNkn9rgEVrlwn5mfK7P8NH@mail.gmail.com>
> References : http://marc.info/?l=linux-kernel&m=127764249926781&w=2
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16307
> Subject : i915 in kernel 2.6.35-rc3, high number of wakeups
> Submitter : Enrico Bandiello <enban@postal.uv.es>
> Date : 2010-06-26 16:57 (13 days old)
> Message-ID : <4C26317A.5070309@postal.uv.es>
> References : http://marc.info/?l=linux-kernel&m=127757403404259&w=2
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16306
> Subject : 2.6.35-rc3 BUG: unable to handle kernel NULL pointer dereference at 0000000000000048 cifs_show_options
> Submitter : Andrew Hendry <andrew.hendry@gmail.com>
> Date : 2010-06-26 10:46 (13 days old)
> Message-ID : <AANLkTilhTrEBYZd4HxeXQk8B6-yV8rCJ2C0jXsEREgIR@mail.gmail.com>
> References : http://marc.info/?l=linux-kernel&m=127754922110501&w=2
> Handled-By : Jeff Layton <jlayton@redhat.com>
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16304
> Subject : i915 - high number of wakeups
> Submitter : Enrico Bandiello <enban@postal.uv.es>
> Date : 2010-06-27 09:52 (12 days old)
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16294
> Subject : [Q35 bisected] hang at init of i915 driver
> Submitter : Kees Cook <kees@outflux.net>
> Date : 2010-06-25 18:20 (14 days old)
> First-Bad-Commit: http://git.kernel.org/linus/f1befe71fa7a79ab733011b045639d8d809924ad
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16288
> Subject : kernel panic with iwlagn for Intel Wifi Link 5100
> Submitter : <yanshuang.zheng@intel.com>
> Date : 2010-06-25 08:14 (14 days old)
> Handled-By : Reinette Chatre <reinette.chatre@intel.com>
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16284
> Subject : Hitting WARN_ON in hw_breakpoint code
> Submitter : Paul Mackerras <paulus@samba.org>
> Date : 2010-06-23 12:57 (16 days old)
> Message-ID : <20100623125740.GA3368@brick.ozlabs.ibm.com>
> References : http://marc.info/?l=linux-kernel&m=127729789113432&w=2
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16265
> Subject : Why is kslowd accumulating so much CPU time?
> Submitter : Theodore Ts'o <tytso@mit.edu>
> Date : 2010-06-09 18:36 (30 days old)
> First-Bad-Commit: http://git.kernel.org/linus/fbf81762e385d3d45acad057b654d56972acf58c
> Message-ID : <E1OMQ88-0002a1-Gb@closure.thunk.org>
> References : http://marc.info/?l=linux-kernel&m=127610857819033&w=4
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16257
> Subject : sysfs changes break hwsim and bnep drivers
> Submitter : Johannes Berg <johannes@sipsolutions.net>
> Date : 2010-06-20 11:23 (19 days old)
> References : http://thread.gmane.org/gmane.linux.network/162754
> Handled-By : Eric W. Biederman <ebiederm@xmission.com>
> Kay Sievers <kay.sievers@vrfy.org>
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16234
> Subject : [2.6.35-rc3] reboot mutex 'bug'...
> Submitter : Daniel J Blueman <daniel.blueman@gmail.com>
> Date : 2010-06-14 15:16 (25 days old)
> Message-ID : <AANLkTimDcTnyEPmt2ZcCM1UWtn4AYKotiqyjobJApkO7@mail.gmail.com>
> References : http://marc.info/?l=linux-kernel&m=127652861118933&w=2
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16230
> Subject : inconsistent IN-HARDIRQ-W -> HARDIRQ-ON-W usage: fasync, 2.6.35-rc3
> Submitter : Dominik Brodowski <linux@dominikbrodowski.net>
> Date : 2010-06-13 9:53 (26 days old)
> Message-ID : <20100613095305.GA13231@comet.dominikbrodowski.net>
> References : http://marc.info/?l=linux-kernel&m=127642282208277&w=2
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16228
> Subject : BUG/boot failure on Dell Precision T3500 (pci/ahci_stop_engine)
> Submitter : Brian Bloniarz <phunge0@hotmail.com>
> Date : 2010-06-16 17:57 (23 days old)
> Handled-By : Bjorn Helgaas <bjorn.helgaas@hp.com>
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16221
> Subject : 2.6.35-rc2-git5 -- [drm:drm_mode_getfb] *ERROR* invalid framebuffer id
> Submitter : Miles Lane <miles.lane@gmail.com>
> Date : 2010-06-11 20:31 (28 days old)
> Message-ID : <AANLkTim0jVRyqkwlGOcrg_XTvUQwcBYfWJX-aRzkkrLG@mail.gmail.com>
> References : http://marc.info/?l=linux-kernel&m=127628828119623&w=2
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16205
> Subject : acpi: freeing invalid memtype bf799000-bf79a000
> Submitter : Marcin Slusarz <marcin.slusarz@gmail.com>
> Date : 2010-06-09 20:09 (30 days old)
> Message-ID : <20100609200910.GA2876@joi.lan>
> References : http://marc.info/?l=linux-kernel&m=127611427029914&w=2
> http://marc.info/?l=linux-kernel&m=127688398513862&w=2
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16201
> Subject : SIOCGIWFREQ ioctl fails to get frequency info
> Submitter : nuh <nuh@mailinator.net>
> Date : 2010-06-14 10:45 (25 days old)
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16199
> Subject : 2.6.35-rc2-git1 - include/linux/cgroup.h:534 invoked rcu_dereference_check() without protection!
> Submitter : Miles Lane <miles.lane@gmail.com>
> Date : 2010-06-07 18:14 (32 days old)
> Message-ID : <AANLkTin2pPqOUx--9fIX3BH3e-cU6oCRufijcx_4ozx5@mail.gmail.com>
> References : http://marc.info/?l=linux-kernel&m=127593447812015&w=2
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16197
> Subject : [BUG on 2.6.35-rc2] sysfs: cannot create duplicate filename '/devices/pci0000:00/0000:00:11.0/0000:02:03.0/slot'
> Submitter : Ryan Wang <openspace.wang@gmail.com>
> Date : 2010-06-07 0:23 (32 days old)
> Message-ID : <AANLkTincwMZPnYW3S4uz4k2GOn52RpgBIBRfzyD010Yo@mail.gmail.com>
> References : http://marc.info/?l=linux-kernel&m=127587022219378&w=2
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16187
> Subject : Carrier detection failed in dhcpcd when link is up
> Submitter : Christian Casteyde <casteyde.christian@free.fr>
> Date : 2010-06-12 15:15 (27 days old)
> First-Bad-Commit: http://git.kernel.org/linus/10708f37ae729baba9b67bd134c3720709d4ae62
> Handled-By : Andrew Morton <akpm@linux-foundation.org>
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16184
> Subject : Container, X86-64, i386, iptables rule
> Submitter : Jean-Marc Pigeon <jmp@safe.ca>
> Date : 2010-06-12 04:17 (27 days old)
> Handled-By : Patrick McHardy <kaber@trash.net>
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16179
> Subject : 2.6.35-rc2 completely hosed on intel gfx?
> Submitter : Norbert Preining <preining@logic.at>
> Date : 2010-06-06 11:55 (33 days old)
> Message-ID : <20100606115534.GA9399@gamma.logic.tuwien.ac.at>
> References : http://marc.info/?l=linux-kernel&m=127582534931581&w=2
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16175
> Subject : 2.6.35-rc1 system oom, many processes killed but memory not free
> Submitter : andrew hendry <andrew.hendry@gmail.com>
> Date : 2010-06-05 0:46 (34 days old)
> Message-ID : <AANLkTim7CiW-yfugZUAHZCqLvXKgt9CwolCvbLGdCLAk@mail.gmail.com>
> References : http://marc.info/?l=linux-kernel&m=127569877714937&w=2
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16173
> Subject : After uncompressing the kernel, at boot time, the server hangs.
> Submitter : David Hill <hilld@binarystorm.net>
> Date : 2010-06-09 23:25 (30 days old)
> First-Bad-Commit: http://git.kernel.org/linus/cf7500c0ea133d66f8449d86392d83f840102632
> Handled-By : Eric W. Biederman <ebiederm@xmission.com>
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16145
> Subject : Unable to boot unless "notsc" or "clocksource=hpet", or acpi_pad disabling the TSC
> Submitter : Tom Gundersen <teg@jklm.no>
> Date : 2010-06-07 13:11 (32 days old)
> Handled-By : Venkatesh Pallipadi <venki@google.com>
> Len Brown <lenb@kernel.org>
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16122
> Subject : 2.6.35-rc1: WARNING at fs/fs-writeback.c:1142 __mark_inode_dirty+0x103/0x170
> Submitter : Larry Finger <Larry.Finger@lwfinger.net>
> Date : 2010-06-04 13:18 (35 days old)
> Handled-By : Jens Axboe <axboe@kernel.dk>
>
>
> Regressions with patches
> ------------------------
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16310
> Subject : arm omap invalid module format
> Submitter : Robert Nelson <robertcnelson@gmail.com>
> Date : 2010-06-28 17:30 (11 days old)
> First-Bad-Commit: http://git.kernel.org/linus/d0679c730395d0bde9a46939e7ba255b4ba7dd7c
> Handled-By : Michal Marek <mmarek@suse.cz>
> Patch : https://bugzilla.kernel.org/attachment.cgi?id=26999
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16278
> Subject : lvm snapshot causes deadlock in 2.6.35
> Submitter : Phillip Susi <psusi@cfl.rr.com>
> Date : 2010-06-23 16:55 (16 days old)
> Handled-By : Eric Sandeen <sandeen@redhat.com>
> Patch : https://bugzilla.kernel.org/attachment.cgi?id=26933
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16271
> Subject : 2.6.35-rc3 regression: IBM Maia system is unbootable [ACPI related?]
> Submitter : James Bottomley <James.Bottomley@hansenpartnership.com>
> Date : 2010-06-21 16:03 (18 days old)
> Message-ID : <1277136189.10998.63.camel@mulgrave.site>
> References : http://marc.info/?l=linux-kernel&m=127713622821166&w=2
> Handled-By : Len Brown <len.brown@intel.com>
> Patch : https://patchwork.kernel.org/patch/108497/
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16256
> Subject : tpm_tis breaks suspend/hibernate on kernels > 2.6.34
> Submitter : Helmut Schaa <helmut.schaa@googlemail.com>
> Date : 2010-06-20 11:15 (19 days old)
> First-Bad-Commit: http://git.kernel.org/linus/225a9be24d799aa16d543c31fb09f0c9ed1d9caa
> Handled-By : Helmut Schaa <helmut.schaa@googlemail.com>
> Patch : http://marc.info/?l=tpmdd-devel&m=127609160616162&w=2
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16255
> Subject : 2.6.35-rc3 deadlocks on semaphore operations
> Submitter : Christoph Lameter <cl@linux-foundation.org>
> Date : 2010-06-18 14:49 (21 days old)
> Message-ID : <alpine.DEB.2.00.1006180940140.11575@router.home>
> References : http://marc.info/?l=linux-kernel&m=127687262727707&w=2
> Handled-By : Manfred Spraul <manfred@colorfullife.com>
> Patch : http://marc.info/?l=linux-kernel&m=127731055203402&w=2
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16232
> Subject : 2.6.35-rc3 - WARNING:iwl_set_dynamic_key
> Submitter : Mario Guenterberg <mario.guenterberg@googlemail.com>
> Date : 2010-06-14 11:55 (25 days old)
> Message-ID : <20100614115510.GA7904@guenti-laptop>
> References : http://marc.info/?l=linux-kernel&m=127651695627147&w=2
> Handled-By : Reinette Chatre <reinette.chatre@intel.com>
> Patch : http://article.gmane.org/gmane.linux.kernel.wireless.general/52893
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16215
> Subject : sysfs: cannot create duplicate filename '/class/net/bnep0'
> Submitter : Janusz Krzysztofik <jkrzyszt@tis.icnet.pl>
> Date : 2010-06-15 14:55 (24 days old)
> Handled-By : Eric W. Biederman <ebiederm@xmission.com>
> Patch : https://bugzilla.kernel.org/show_bug.cgi?id=16215#c10
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16169
> Subject : Complain from preemptive debug
> Submitter : Sedat Dilek <sedat.dilek@googlemail.com>
> Date : 2010-05-31 10:10 (39 days old)
> Message-ID : <AANLkTilTnAAZIizKinYsxFkNTkrmPqk6XJJuUjjhJ7EP@mail.gmail.com>
> References : http://lkml.org/lkml/2010/5/31/77
> Handled-By : Dmitry Monakhov <dmonakhov@openvz.org>
> Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> Patch : http://www.spinics.net/lists/cpufreq/msg01631.html
> https://patchwork.kernel.org/patch/106555/
>
>
> For details, please visit the bug entries and follow the links given in
> references.
>
> As you can see, there is a Bugzilla entry for each of the listed regressions.
> There also is a Bugzilla entry used for tracking the regressions from 2.6.34,
> unresolved as well as resolved, at:
>
> http://bugzilla.kernel.org/show_bug.cgi?id=16055
>
> Please let the tracking team know if there are any Bugzilla entries that
> should be added to the list in there.
>
> Thanks!
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
^ permalink raw reply
* Re: Pull request: bluetooth-2.6 2010-07-08
From: David Miller @ 2010-07-09 0:28 UTC (permalink / raw)
To: marcel; +Cc: netdev
In-Reply-To: <cover.1278632276.git.marcel@holtmann.org>
From: Marcel Holtmann <marcel@holtmann.org>
Date: Thu, 8 Jul 2010 20:40:50 -0300
> Hi Dave,
>
> so I took the two security fixes and the interoperability fix for basic
> mode L2CAP connections and combined them here.
>
> All the other patches where bug fixes with L2CAP ERTM support and I will
> send them separately.
...
> Please pull from
>
> git://git.kernel.org/pub/scm/linux/kernel/git/holtmann/bluetooth-2.6.git master
Pulled, thanks.
^ permalink raw reply
* Re: [PATCH 1/6 net-next-2.6] vxge: Remove queue_state references
From: David Miller @ 2010-07-09 0:27 UTC (permalink / raw)
To: jon.mason; +Cc: netdev, Sreenivasa.Honnur, ramkrishna.vepa
In-Reply-To: <20100708231936.GA19237@exar.com>
From: Jon Mason <jon.mason@exar.com>
Date: Thu, 8 Jul 2010 18:19:37 -0500
> On Thu, Jul 08, 2010 at 12:19:57PM -0700, Jon Mason wrote:
>> Remove queue_state references, as they are no longer necessary.
>>
>> Also, The driver needs to start/stop the queue regardless of which type
>> of steering is enabled. Remove checks for TX_MULTIQ_STEERING only and
>> start/stop for all steering types.
>>
>> Signed-off-by: Jon Mason <jon.mason@exar.com>
>> Signed-off-by: Sreenivasa Honnur <sreenivasa.honnur@exar.com>
>> Signed-off-by: Ramkrishna Vepa <ram.vepa@exar.com>
>
> Ram's e-mail address is incorrect in this series. Would you like me
> to resubmit with it corrected?
I can fix it up.
^ permalink raw reply
* Re: 2.6.35-rc4-git3: Reported regressions from 2.6.34
From: Sedat Dilek @ 2010-07-09 0:16 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Linux Kernel Mailing List, Maciej Rutecki, Andrew Morton,
Linus Torvalds, Kernel Testers List, Network Development,
Linux ACPI, Linux PM List, Linux SCSI List, Linux Wireless List,
DRI
In-Reply-To: <-IGZ64uxA6G.A.P0H.bLmNMB@chimera>
Hi Rafael,
On Fri, Jul 9, 2010 at 1:33 AM, Rafael J. Wysocki <rjw@sisk.pl> wrote:
[...]
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16169
Subject : Complain from preemptive debug
Submitter : Sedat Dilek <sedat.dilek@googlemail.com>
Date : 2010-05-31 10:10 (39 days old)
Message-ID : <AANLkTilTnAAZIizKinYsxFkNTkrmPqk6XJJuUjjhJ7EP@mail.gmail.com>
References : http://lkml.org/lkml/2010/5/31/77
Handled-By : Dmitry Monakhov <dmonakhov@openvz.org>
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Patch : http://www.spinics.net/lists/cpufreq/msg01631.html
https://patchwork.kernel.org/patch/106555/
This bug is fixed Upstream [1]:
commit 8c215bd3890c347dfb6a2db4779755f8b9c298a9
"sched: Cure nr_iowait_cpu() users"
- Sedat -
[1] http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=8c215bd3890c347dfb6a2db4779755f8b9c298a9
^ permalink raw reply
* [PATCH 3/3] Bluetooth: Update sec_level/auth_type for already existing connections
From: Marcel Holtmann @ 2010-07-08 23:40 UTC (permalink / raw)
To: David Miller; +Cc: netdev
In-Reply-To: <cover.1278632276.git.marcel@holtmann.org>
From: Ville Tervo <ville.tervo@nokia.com>
Update auth level for already existing connections if it is lower
than required by new connection.
Signed-off-by: Ville Tervo <ville.tervo@nokia.com>
Reviewed-by: Emeltchenko Andrei <andrei.emeltchenko@nokia.com>
Signed-off-by: Luciano Coelho <luciano.coelho@nokia.com>
Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@nokia.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
---
net/bluetooth/hci_conn.c | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/net/bluetooth/hci_conn.c b/net/bluetooth/hci_conn.c
index b10e3cd..800b6b9 100644
--- a/net/bluetooth/hci_conn.c
+++ b/net/bluetooth/hci_conn.c
@@ -358,6 +358,11 @@ struct hci_conn *hci_connect(struct hci_dev *hdev, int type, bdaddr_t *dst, __u8
acl->sec_level = sec_level;
acl->auth_type = auth_type;
hci_acl_connect(acl);
+ } else {
+ if (acl->sec_level < sec_level)
+ acl->sec_level = sec_level;
+ if (acl->auth_type < auth_type)
+ acl->auth_type = auth_type;
}
if (type == ACL_LINK)
--
1.7.1.1
^ permalink raw reply related
* [PATCH 2/3] Bluetooth: Reset the security level after an authentication failure
From: Marcel Holtmann @ 2010-07-08 23:40 UTC (permalink / raw)
To: David Miller; +Cc: netdev
In-Reply-To: <cover.1278632276.git.marcel@holtmann.org>
From: Johan Hedberg <johan.hedberg@nokia.com>
When authentication fails for a connection the assumed security level
should be set back to BT_SECURITY_LOW so that subsequent connect
attempts over the same link don't falsely assume that security is
adequate enough.
Signed-off-by: Johan Hedberg <johan.hedberg@nokia.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
---
net/bluetooth/hci_event.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c
index 6c57fc7..786b5de 100644
--- a/net/bluetooth/hci_event.c
+++ b/net/bluetooth/hci_event.c
@@ -1049,6 +1049,8 @@ static inline void hci_auth_complete_evt(struct hci_dev *hdev, struct sk_buff *s
if (conn) {
if (!ev->status)
conn->link_mode |= HCI_LM_AUTH;
+ else
+ conn->sec_level = BT_SECURITY_LOW;
clear_bit(HCI_CONN_AUTH_PEND, &conn->pend);
--
1.7.1.1
^ permalink raw reply related
* [PATCH 1/3] Bluetooth: Check L2CAP pending status before sending connect request
From: Marcel Holtmann @ 2010-07-08 23:40 UTC (permalink / raw)
To: David Miller; +Cc: netdev
In-Reply-To: <cover.1278632276.git.marcel@holtmann.org>
From: Andrei Emeltchenko <andrei.emeltchenko@nokia.com>
Due to race condition in L2CAP state machine L2CAP Connection Request
may be sent twice for SDP with the same source channel id. Problems
reported connecting to Apple products, some carkit, Blackberry phones.
...
2010-06-07 21:18:03.651031 < ACL data: handle 1 flags 0x02 dlen 12
L2CAP(s): Connect req: psm 1 scid 0x0040
2010-06-07 21:18:03.653473 > HCI Event: Number of Completed Packets (0x13) plen 5
handle 1 packets 1
2010-06-07 21:18:03.653808 > HCI Event: Auth Complete (0x06) plen 3
status 0x00 handle 1
2010-06-07 21:18:03.653869 < ACL data: handle 1 flags 0x02 dlen 12
L2CAP(s): Connect req: psm 1 scid 0x0040
...
Patch uses L2CAP_CONF_CONNECT_PEND flag to mark that L2CAP Connection
Request has been sent already.
Modified version of patch from Ville Tervo.
Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@nokia.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
---
net/bluetooth/l2cap.c | 14 +++++++++++---
1 files changed, 11 insertions(+), 3 deletions(-)
diff --git a/net/bluetooth/l2cap.c b/net/bluetooth/l2cap.c
index 1b682a5..cf3c407 100644
--- a/net/bluetooth/l2cap.c
+++ b/net/bluetooth/l2cap.c
@@ -401,6 +401,11 @@ static inline void l2cap_send_rr_or_rnr(struct l2cap_pinfo *pi, u16 control)
l2cap_send_sframe(pi, control);
}
+static inline int __l2cap_no_conn_pending(struct sock *sk)
+{
+ return !(l2cap_pi(sk)->conf_state & L2CAP_CONF_CONNECT_PEND);
+}
+
static void l2cap_do_start(struct sock *sk)
{
struct l2cap_conn *conn = l2cap_pi(sk)->conn;
@@ -409,12 +414,13 @@ static void l2cap_do_start(struct sock *sk)
if (!(conn->info_state & L2CAP_INFO_FEAT_MASK_REQ_DONE))
return;
- if (l2cap_check_security(sk)) {
+ if (l2cap_check_security(sk) && __l2cap_no_conn_pending(sk)) {
struct l2cap_conn_req req;
req.scid = cpu_to_le16(l2cap_pi(sk)->scid);
req.psm = l2cap_pi(sk)->psm;
l2cap_pi(sk)->ident = l2cap_get_ident(conn);
+ l2cap_pi(sk)->conf_state |= L2CAP_CONF_CONNECT_PEND;
l2cap_send_cmd(conn, l2cap_pi(sk)->ident,
L2CAP_CONN_REQ, sizeof(req), &req);
@@ -464,12 +470,14 @@ static void l2cap_conn_start(struct l2cap_conn *conn)
}
if (sk->sk_state == BT_CONNECT) {
- if (l2cap_check_security(sk)) {
+ if (l2cap_check_security(sk) &&
+ __l2cap_no_conn_pending(sk)) {
struct l2cap_conn_req req;
req.scid = cpu_to_le16(l2cap_pi(sk)->scid);
req.psm = l2cap_pi(sk)->psm;
l2cap_pi(sk)->ident = l2cap_get_ident(conn);
+ l2cap_pi(sk)->conf_state |= L2CAP_CONF_CONNECT_PEND;
l2cap_send_cmd(conn, l2cap_pi(sk)->ident,
L2CAP_CONN_REQ, sizeof(req), &req);
@@ -2912,7 +2920,6 @@ static inline int l2cap_connect_rsp(struct l2cap_conn *conn, struct l2cap_cmd_hd
l2cap_pi(sk)->ident = 0;
l2cap_pi(sk)->dcid = dcid;
l2cap_pi(sk)->conf_state |= L2CAP_CONF_REQ_SENT;
-
l2cap_pi(sk)->conf_state &= ~L2CAP_CONF_CONNECT_PEND;
l2cap_send_cmd(conn, l2cap_get_ident(conn), L2CAP_CONF_REQ,
@@ -4404,6 +4411,7 @@ static int l2cap_security_cfm(struct hci_conn *hcon, u8 status, u8 encrypt)
req.psm = l2cap_pi(sk)->psm;
l2cap_pi(sk)->ident = l2cap_get_ident(conn);
+ l2cap_pi(sk)->conf_state |= L2CAP_CONF_CONNECT_PEND;
l2cap_send_cmd(conn, l2cap_pi(sk)->ident,
L2CAP_CONN_REQ, sizeof(req), &req);
--
1.7.1.1
^ permalink raw reply related
* Pull request: bluetooth-2.6 2010-07-08
From: Marcel Holtmann @ 2010-07-08 23:40 UTC (permalink / raw)
To: David Miller; +Cc: netdev
Hi Dave,
so I took the two security fixes and the interoperability fix for basic
mode L2CAP connections and combined them here.
All the other patches where bug fixes with L2CAP ERTM support and I will
send them separately.
Regards
Marcel
Please pull from
git://git.kernel.org/pub/scm/linux/kernel/git/holtmann/bluetooth-2.6.git master
This will update the following files:
net/bluetooth/hci_conn.c | 5 +++++
net/bluetooth/hci_event.c | 2 ++
net/bluetooth/l2cap.c | 14 +++++++++++---
3 files changed, 18 insertions(+), 3 deletions(-)
through these ChangeSets:
Andrei Emeltchenko (1):
Bluetooth: Check L2CAP pending status before sending connect request
Johan Hedberg (1):
Bluetooth: Reset the security level after an authentication failure
Ville Tervo (1):
Bluetooth: Update sec_level/auth_type for already existing connections
^ permalink raw reply
* [PATCH net-next-2.6] sfc: Remove unused field left from mis-merge
From: Ben Hutchings @ 2010-07-08 23:36 UTC (permalink / raw)
To: David Miller; +Cc: netdev, linux-net-drivers
Commit eedc765ca4b19a41cf0b921a492ac08d640060d1 merged changes from
net-2.6 that added and then removed efx_nic::port_num, which was also
added in net-next-2.6. The end result should be that it is removed,
since it is now unused.
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
---
drivers/net/sfc/net_driver.h | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/net/sfc/net_driver.h b/drivers/net/sfc/net_driver.h
index bab836c..64e7caa 100644
--- a/drivers/net/sfc/net_driver.h
+++ b/drivers/net/sfc/net_driver.h
@@ -622,7 +622,6 @@ union efx_multicast_hash {
* struct efx_nic - an Efx NIC
* @name: Device name (net device name or bus id before net device registered)
* @pci_dev: The PCI device
- * @port_num: Index of this host port within the controller
* @type: Controller type attributes
* @legacy_irq: IRQ number
* @workqueue: Workqueue for port reconfigures and the HW monitor.
@@ -708,7 +707,6 @@ union efx_multicast_hash {
struct efx_nic {
char name[IFNAMSIZ];
struct pci_dev *pci_dev;
- unsigned port_num;
const struct efx_nic_type *type;
int legacy_irq;
struct workqueue_struct *workqueue;
--
1.6.2.5
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
^ permalink raw reply related
* 2.6.35-rc4-git3: Reported regressions from 2.6.34
From: Rafael J. Wysocki @ 2010-07-08 23:33 UTC (permalink / raw)
To: Linux Kernel Mailing List
Cc: Maciej Rutecki, Andrew Morton, Linus Torvalds,
Kernel Testers List, Network Development, Linux ACPI,
Linux PM List, Linux SCSI List, Linux Wireless List, DRI
This message contains a list of some regressions from 2.6.34,
for which there are no fixes in the mainline known to the tracking team.
If any of them have been fixed already, please let us know.
If you know of any other unresolved regressions from 2.6.34, please let us
know either and we'll add them to the list. Also, please let us know
if any of the entries below are invalid.
Each entry from the list will be sent additionally in an automatic reply
to this message with CCs to the people involved in reporting and handling
the issue.
Listed regressions statistics:
Date Total Pending Unresolved
----------------------------------------
2010-07-09 79 45 37
2010-06-21 46 37 26
2010-06-09 15 13 10
Unresolved regressions
----------------------
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16353
Subject : 2.6.35 regression
Submitter : Zeev Tarantov <zeev.tarantov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date : 2010-07-05 13:04 (4 days old)
Message-ID : <loom.20100705T144459-919-eS7Uydv5nfjZ+VzJOa5vwg@public.gmane.org>
References : http://marc.info/?l=linux-kernel&m=127836002702522&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16346
Subject : 2.6.35-rc3-git8 - include/linux/fdtable.h:88 invoked rcu_dereference_check() without protection!
Submitter : Miles Lane <miles.lane-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date : 2010-07-04 22:04 (5 days old)
Message-ID : <AANLkTinof0k28rk4rMr66aubxcRL2rFa5ZEArj1lqD3o-JsoAwUIsXotQFR93xxRIaA@public.gmane.orgcom>
References : http://marc.info/?l=linux-kernel&m=127828107815930&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16337
Subject : general protection fault: 0000 [#1] SMP
Submitter : Justin P. Mattock <justinmattock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date : 2010-07-03 22:59 (6 days old)
Message-ID : <4C2FC0E3.6050101-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
References : http://marc.info/?l=linux-kernel&m=127819798215589&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16334
Subject : reiserfs locking (v2)
Submitter : Sergey Senozhatsky <sergey.senozhatsky-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date : 2010-07-02 9:34 (7 days old)
Message-ID : <20100702093451.GA3973-dY8u8AhHFaWtd10JCjopabkcH5ONE+aC@public.gmane.org>
References : http://marc.info/?l=linux-kernel&m=127806306303590&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16333
Subject : iwl3945: HARDWARE GONE??
Submitter : Priit Laes <plaes-q/aMd4JkU83YtjvyW6yDsg@public.gmane.org>
Date : 2010-07-02 16:02 (7 days old)
Message-ID : <1278086575.2889.8.camel@chi>
References : http://marc.info/?l=linux-kernel&m=127808659705983&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16332
Subject : Kernel crashes in tty code (tty_open)
Submitter : werner-K1X7VnsBORrsrOwW+9ziJQ@public.gmane.org
Date : 2010-07-02 3:34 (7 days old)
Message-ID : <1278041650.12788-K1X7VnsBORrsrOwW+9ziJQ@public.gmane.org>
References : http://marc.info/?l=linux-kernel&m=127804167511930&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16330
Subject : Dynamic Debug broken on 2.6.35-rc3?
Submitter : Thomas Renninger <trenn-l3A5Bk7waGM@public.gmane.org>
Date : 2010-07-01 15:44 (8 days old)
Message-ID : <201007011744.19564.trenn-l3A5Bk7waGM@public.gmane.org>
References : http://marc.info/?l=linux-kernel&m=127799907218877&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16329
Subject : 2.6.35-rc3: Load average climbing to 3+ with no apparent reason: CPU 98% idle, with hardly no I/O
Submitter : Török Edwin <edwintorok-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date : 2010-07-01 7:40 (8 days old)
Message-ID : <20100701104022.404410d6@debian>
References : http://marc.info/?l=linux-kernel&m=127797005030536&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16324
Subject : Oops while running fs_racer test on a POWER6 box against latest git
Submitter : divya <dipraksh-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
Date : 2010-06-30 11:34 (9 days old)
Message-ID : <4C2B28F3.7000006-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
References : http://marc.info/?l=linux-kernel&m=127789697303061&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16323
Subject : 2.6.35-rc3-git4 - kernel/sched.c:616 invoked rcu_dereference_check() without protection!
Submitter : Miles Lane <miles.lane-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date : 2010-07-01 12:21 (8 days old)
Message-ID : <AANLkTini6hz2LFeZi8CMUmY3xw1MU7NxmyesuxZ4oCdo-JsoAwUIsXotQFR93xxRIaA@public.gmane.orgcom>
References : http://marc.info/?l=linux-kernel&m=127798693125541&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16322
Subject : WARNING: at /arch/x86/include/asm/processor.h:1005 read_measured_perf_ctrs+0x5a/0x70()
Submitter : boris64 <bugzilla.kernel.org-ro/BP3KN3ujR7s880joybQ@public.gmane.org>
Date : 2010-07-01 13:54 (8 days old)
Handled-By : H. Peter Anvin <hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16312
Subject : WARNING: at fs/fs-writeback.c:1127 __mark_inode_dirty
Submitter : Zdenek Kabelac <zdenek.kabelac-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date : 2010-06-28 9:40 (11 days old)
Message-ID : <AANLkTin24fr5O4_q5Xbo9Y_NKkEmtcp6Hgmr9_4qXaFz-JsoAwUIsXotQFR93xxRIaA@public.gmane.orgcom>
References : http://marc.info/?l=linux-kernel&m=127771804806465&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16311
Subject : [REGRESSION][SUSPEND] 2.6.35-rcX won't suspend Lenovo W500 laptop
Submitter : Shawn Starr <shawn.starr-bJEeYj9oJeDQT0dZR+AlfA@public.gmane.org>
Date : 2010-06-28 0:45 (11 days old)
Message-ID : <201006272045.17004.shawn.starr-bJEeYj9oJeDQT0dZR+AlfA@public.gmane.org>
References : http://marc.info/?l=linux-kernel&m=127768633705286&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16309
Subject : 2.6.35-rc3 oops trying to suspend.
Submitter : Andrew Hendry <andrew.hendry-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date : 2010-06-27 12:40 (12 days old)
Message-ID : <AANLkTinUH2p33-AWxOVDrLsNkn9rgEVrlwn5mfK7P8NH-JsoAwUIsXotQFR93xxRIaA@public.gmane.orgcom>
References : http://marc.info/?l=linux-kernel&m=127764249926781&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16307
Subject : i915 in kernel 2.6.35-rc3, high number of wakeups
Submitter : Enrico Bandiello <enban-c0jvKHQHzSzx4jp4WZvp5g@public.gmane.org>
Date : 2010-06-26 16:57 (13 days old)
Message-ID : <4C26317A.5070309-c0jvKHQHzSzx4jp4WZvp5g@public.gmane.org>
References : http://marc.info/?l=linux-kernel&m=127757403404259&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16306
Subject : 2.6.35-rc3 BUG: unable to handle kernel NULL pointer dereference at 0000000000000048 cifs_show_options
Submitter : Andrew Hendry <andrew.hendry-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date : 2010-06-26 10:46 (13 days old)
Message-ID : <AANLkTilhTrEBYZd4HxeXQk8B6-yV8rCJ2C0jXsEREgIR-JsoAwUIsXotQFR93xxRIaA@public.gmane.orgcom>
References : http://marc.info/?l=linux-kernel&m=127754922110501&w=2
Handled-By : Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16304
Subject : i915 - high number of wakeups
Submitter : Enrico Bandiello <enban-c0jvKHQHzSzx4jp4WZvp5g@public.gmane.org>
Date : 2010-06-27 09:52 (12 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16294
Subject : [Q35 bisected] hang at init of i915 driver
Submitter : Kees Cook <kees-oSa+0FWJbaXR7s880joybQ@public.gmane.org>
Date : 2010-06-25 18:20 (14 days old)
First-Bad-Commit: http://git.kernel.org/linus/f1befe71fa7a79ab733011b045639d8d809924ad
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16288
Subject : kernel panic with iwlagn for Intel Wifi Link 5100
Submitter : <yanshuang.zheng-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Date : 2010-06-25 08:14 (14 days old)
Handled-By : Reinette Chatre <reinette.chatre-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16284
Subject : Hitting WARN_ON in hw_breakpoint code
Submitter : Paul Mackerras <paulus-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>
Date : 2010-06-23 12:57 (16 days old)
Message-ID : <20100623125740.GA3368-oklZEfemRj05kJ7NmlRacFaTQe2KTcn/@public.gmane.org>
References : http://marc.info/?l=linux-kernel&m=127729789113432&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16265
Subject : Why is kslowd accumulating so much CPU time?
Submitter : Theodore Ts'o <tytso-3s7WtUTddSA@public.gmane.org>
Date : 2010-06-09 18:36 (30 days old)
First-Bad-Commit: http://git.kernel.org/linus/fbf81762e385d3d45acad057b654d56972acf58c
Message-ID : <E1OMQ88-0002a1-Gb-UK71uKi2zisAobODsErMgNi2O/JbrIOy@public.gmane.org>
References : http://marc.info/?l=linux-kernel&m=127610857819033&w=4
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16257
Subject : sysfs changes break hwsim and bnep drivers
Submitter : Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
Date : 2010-06-20 11:23 (19 days old)
References : http://thread.gmane.org/gmane.linux.network/162754
Handled-By : Eric W. Biederman <ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
Kay Sievers <kay.sievers-tD+1rO4QERM@public.gmane.org>
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16234
Subject : [2.6.35-rc3] reboot mutex 'bug'...
Submitter : Daniel J Blueman <daniel.blueman-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date : 2010-06-14 15:16 (25 days old)
Message-ID : <AANLkTimDcTnyEPmt2ZcCM1UWtn4AYKotiqyjobJApkO7-JsoAwUIsXotQFR93xxRIaA@public.gmane.orgcom>
References : http://marc.info/?l=linux-kernel&m=127652861118933&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16230
Subject : inconsistent IN-HARDIRQ-W -> HARDIRQ-ON-W usage: fasync, 2.6.35-rc3
Submitter : Dominik Brodowski <linux-X3ehHDuj6sIIGcDfoQAp7OTW4wlIGRCZ@public.gmane.org>
Date : 2010-06-13 9:53 (26 days old)
Message-ID : <20100613095305.GA13231-S7uyTPAaJ/sb6pqDj42GsMgv3T4z79SOrE5yTffgRl4@public.gmane.org>
References : http://marc.info/?l=linux-kernel&m=127642282208277&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16228
Subject : BUG/boot failure on Dell Precision T3500 (pci/ahci_stop_engine)
Submitter : Brian Bloniarz <phunge0-PkbjNfxxIARBDgjK7y7TUQ@public.gmane.org>
Date : 2010-06-16 17:57 (23 days old)
Handled-By : Bjorn Helgaas <bjorn.helgaas-VXdhtT5mjnY@public.gmane.org>
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16221
Subject : 2.6.35-rc2-git5 -- [drm:drm_mode_getfb] *ERROR* invalid framebuffer id
Submitter : Miles Lane <miles.lane-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date : 2010-06-11 20:31 (28 days old)
Message-ID : <AANLkTim0jVRyqkwlGOcrg_XTvUQwcBYfWJX-aRzkkrLG-JsoAwUIsXotQFR93xxRIaA@public.gmane.orgcom>
References : http://marc.info/?l=linux-kernel&m=127628828119623&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16205
Subject : acpi: freeing invalid memtype bf799000-bf79a000
Submitter : Marcin Slusarz <marcin.slusarz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date : 2010-06-09 20:09 (30 days old)
Message-ID : <20100609200910.GA2876-OI9uyE9O0yo@public.gmane.org>
References : http://marc.info/?l=linux-kernel&m=127611427029914&w=2
http://marc.info/?l=linux-kernel&m=127688398513862&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16201
Subject : SIOCGIWFREQ ioctl fails to get frequency info
Submitter : nuh <nuh-hRtevi7K+EWJQ7yn63+t2w@public.gmane.org>
Date : 2010-06-14 10:45 (25 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16199
Subject : 2.6.35-rc2-git1 - include/linux/cgroup.h:534 invoked rcu_dereference_check() without protection!
Submitter : Miles Lane <miles.lane-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date : 2010-06-07 18:14 (32 days old)
Message-ID : <AANLkTin2pPqOUx--9fIX3BH3e-cU6oCRufijcx_4ozx5-JsoAwUIsXotQFR93xxRIaA@public.gmane.orgcom>
References : http://marc.info/?l=linux-kernel&m=127593447812015&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16197
Subject : [BUG on 2.6.35-rc2] sysfs: cannot create duplicate filename '/devices/pci0000:00/0000:00:11.0/0000:02:03.0/slot'
Submitter : Ryan Wang <openspace.wang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date : 2010-06-07 0:23 (32 days old)
Message-ID : <AANLkTincwMZPnYW3S4uz4k2GOn52RpgBIBRfzyD010Yo-JsoAwUIsXotQFR93xxRIaA@public.gmane.orgcom>
References : http://marc.info/?l=linux-kernel&m=127587022219378&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16187
Subject : Carrier detection failed in dhcpcd when link is up
Submitter : Christian Casteyde <casteyde.christian-GANU6spQydw@public.gmane.org>
Date : 2010-06-12 15:15 (27 days old)
First-Bad-Commit: http://git.kernel.org/linus/10708f37ae729baba9b67bd134c3720709d4ae62
Handled-By : Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16184
Subject : Container, X86-64, i386, iptables rule
Submitter : Jean-Marc Pigeon <jmp-4qkeo2rQ0gg@public.gmane.org>
Date : 2010-06-12 04:17 (27 days old)
Handled-By : Patrick McHardy <kaber-dcUjhNyLwpNeoWH0uzbU5w@public.gmane.org>
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16179
Subject : 2.6.35-rc2 completely hosed on intel gfx?
Submitter : Norbert Preining <preining-DX+603jRYB8@public.gmane.org>
Date : 2010-06-06 11:55 (33 days old)
Message-ID : <20100606115534.GA9399-DqSSrKF0TaySnEC3TeqHn5dqbFPxfnh/@public.gmane.org>
References : http://marc.info/?l=linux-kernel&m=127582534931581&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16175
Subject : 2.6.35-rc1 system oom, many processes killed but memory not free
Submitter : andrew hendry <andrew.hendry-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date : 2010-06-05 0:46 (34 days old)
Message-ID : <AANLkTim7CiW-yfugZUAHZCqLvXKgt9CwolCvbLGdCLAk-JsoAwUIsXotQFR93xxRIaA@public.gmane.orgcom>
References : http://marc.info/?l=linux-kernel&m=127569877714937&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16173
Subject : After uncompressing the kernel, at boot time, the server hangs.
Submitter : David Hill <hilld-HTiBYHdybX7UkGsOFmftXw@public.gmane.org>
Date : 2010-06-09 23:25 (30 days old)
First-Bad-Commit: http://git.kernel.org/linus/cf7500c0ea133d66f8449d86392d83f840102632
Handled-By : Eric W. Biederman <ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16145
Subject : Unable to boot unless "notsc" or "clocksource=hpet", or acpi_pad disabling the TSC
Submitter : Tom Gundersen <teg-B22kvLQNl6c@public.gmane.org>
Date : 2010-06-07 13:11 (32 days old)
Handled-By : Venkatesh Pallipadi <venki-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
Len Brown <lenb-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16122
Subject : 2.6.35-rc1: WARNING at fs/fs-writeback.c:1142 __mark_inode_dirty+0x103/0x170
Submitter : Larry Finger <Larry.Finger-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
Date : 2010-06-04 13:18 (35 days old)
Handled-By : Jens Axboe <axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>
Regressions with patches
------------------------
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16310
Subject : arm omap invalid module format
Submitter : Robert Nelson <robertcnelson-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date : 2010-06-28 17:30 (11 days old)
First-Bad-Commit: http://git.kernel.org/linus/d0679c730395d0bde9a46939e7ba255b4ba7dd7c
Handled-By : Michal Marek <mmarek-AlSwsSmVLrQ@public.gmane.org>
Patch : https://bugzilla.kernel.org/attachment.cgi?id=26999
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16278
Subject : lvm snapshot causes deadlock in 2.6.35
Submitter : Phillip Susi <psusi-3tLf1voIkJTQT0dZR+AlfA@public.gmane.org>
Date : 2010-06-23 16:55 (16 days old)
Handled-By : Eric Sandeen <sandeen-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Patch : https://bugzilla.kernel.org/attachment.cgi?id=26933
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16271
Subject : 2.6.35-rc3 regression: IBM Maia system is unbootable [ACPI related?]
Submitter : James Bottomley <James.Bottomley-JuX6DAaQMKPCXq6kfMZ53/egYHeGw8Jk@public.gmane.org>
Date : 2010-06-21 16:03 (18 days old)
Message-ID : <1277136189.10998.63.camel-0iu6Cu4xQGLYCGPCin2YbQ@public.gmane.org>
References : http://marc.info/?l=linux-kernel&m=127713622821166&w=2
Handled-By : Len Brown <len.brown-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Patch : https://patchwork.kernel.org/patch/108497/
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16256
Subject : tpm_tis breaks suspend/hibernate on kernels > 2.6.34
Submitter : Helmut Schaa <helmut.schaa-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>
Date : 2010-06-20 11:15 (19 days old)
First-Bad-Commit: http://git.kernel.org/linus/225a9be24d799aa16d543c31fb09f0c9ed1d9caa
Handled-By : Helmut Schaa <helmut.schaa-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>
Patch : http://marc.info/?l=tpmdd-devel&m=127609160616162&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16255
Subject : 2.6.35-rc3 deadlocks on semaphore operations
Submitter : Christoph Lameter <cl-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
Date : 2010-06-18 14:49 (21 days old)
Message-ID : <alpine.DEB.2.00.1006180940140.11575-sBS69tsa9Uj/9pzu0YdTqQ@public.gmane.org>
References : http://marc.info/?l=linux-kernel&m=127687262727707&w=2
Handled-By : Manfred Spraul <manfred-nhLOkwUX5cPe2c5cEj3t2g@public.gmane.org>
Patch : http://marc.info/?l=linux-kernel&m=127731055203402&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16232
Subject : 2.6.35-rc3 - WARNING:iwl_set_dynamic_key
Submitter : Mario Guenterberg <mario.guenterberg-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>
Date : 2010-06-14 11:55 (25 days old)
Message-ID : <20100614115510.GA7904@guenti-laptop>
References : http://marc.info/?l=linux-kernel&m=127651695627147&w=2
Handled-By : Reinette Chatre <reinette.chatre-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Patch : http://article.gmane.org/gmane.linux.kernel.wireless.general/52893
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16215
Subject : sysfs: cannot create duplicate filename '/class/net/bnep0'
Submitter : Janusz Krzysztofik <jkrzyszt-NCk8gXQAEuFz6jiHbVrK7g@public.gmane.org>
Date : 2010-06-15 14:55 (24 days old)
Handled-By : Eric W. Biederman <ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
Patch : https://bugzilla.kernel.org/show_bug.cgi?id=16215#c10
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=16169
Subject : Complain from preemptive debug
Submitter : Sedat Dilek <sedat.dilek-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>
Date : 2010-05-31 10:10 (39 days old)
Message-ID : <AANLkTilTnAAZIizKinYsxFkNTkrmPqk6XJJuUjjhJ7EP-JsoAwUIsXotQFR93xxRIaA@public.gmane.orgcom>
References : http://lkml.org/lkml/2010/5/31/77
Handled-By : Dmitry Monakhov <dmonakhov-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org>
Sergey Senozhatsky <sergey.senozhatsky-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Patch : http://www.spinics.net/lists/cpufreq/msg01631.html
https://patchwork.kernel.org/patch/106555/
For details, please visit the bug entries and follow the links given in
references.
As you can see, there is a Bugzilla entry for each of the listed regressions.
There also is a Bugzilla entry used for tracking the regressions from 2.6.34,
unresolved as well as resolved, at:
http://bugzilla.kernel.org/show_bug.cgi?id=16055
Please let the tracking team know if there are any Bugzilla entries that
should be added to the list in there.
Thanks!
^ permalink raw reply
* [PATCH net-next-2.6 2/2] net: Document that dev_get_stats() returns the given pointer
From: Ben Hutchings @ 2010-07-08 23:30 UTC (permalink / raw)
To: David Miller; +Cc: netdev, linux-net-drivers, Eric Dumazet
In-Reply-To: <1278631762.16013.307.camel@achroite.uk.solarflarecom.com>
Document that dev_get_stats() returns the same stats pointer it was
given. Remove const qualification from the returned pointer since the
caller may do what it likes with that structure.
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
---
include/linux/netdevice.h | 4 ++--
net/core/dev.c | 12 ++++++------
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index 17e95e3..c4fedf0 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -2130,8 +2130,8 @@ extern void netdev_features_change(struct net_device *dev);
/* Load a device via the kmod */
extern void dev_load(struct net *net, const char *name);
extern void dev_mcast_init(void);
-extern const struct rtnl_link_stats64 *dev_get_stats(struct net_device *dev,
- struct rtnl_link_stats64 *storage);
+extern struct rtnl_link_stats64 *dev_get_stats(struct net_device *dev,
+ struct rtnl_link_stats64 *storage);
extern void dev_txq_stats_fold(const struct net_device *dev,
struct rtnl_link_stats64 *stats);
diff --git a/net/core/dev.c b/net/core/dev.c
index 5ec2eec..2605a68 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -5302,13 +5302,13 @@ EXPORT_SYMBOL(dev_txq_stats_fold);
* @dev: device to get statistics from
* @storage: place to store stats
*
- * Get network statistics from device. The device driver may provide
- * its own method by setting dev->netdev_ops->get_stats64 or
- * dev->netdev_ops->get_stats; otherwise the internal statistics
- * structure is used.
+ * Get network statistics from device. Return @storage.
+ * The device driver may provide its own method by setting
+ * dev->netdev_ops->get_stats64 or dev->netdev_ops->get_stats;
+ * otherwise the internal statistics structure is used.
*/
-const struct rtnl_link_stats64 *dev_get_stats(struct net_device *dev,
- struct rtnl_link_stats64 *storage)
+struct rtnl_link_stats64 *dev_get_stats(struct net_device *dev,
+ struct rtnl_link_stats64 *storage)
{
const struct net_device_ops *ops = dev->netdev_ops;
size_t i, n = sizeof(*storage) / sizeof(u64);
--
1.6.2.5
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
^ permalink raw reply related
* [PATCH net-next-2.6 1/2] net: Get rid of rtnl_link_stats64 / net_device_stats union
From: Ben Hutchings @ 2010-07-08 23:29 UTC (permalink / raw)
To: David Miller; +Cc: netdev, linux-net-drivers, Eric Dumazet
In commit be1f3c2c027cc5ad735df6a45a542ed1db7ec48b "net: Enable 64-bit
net device statistics on 32-bit architectures" I redefined struct
net_device_stats so that it could be used in a union with struct
rtnl_link_stats64, avoiding the need for explicit copying or
conversion between the two. However, this is unsafe because there is
no locking required and no lock consistently held around calls to
dev_get_stats() and use of the statistics structure it returns.
In commit 28172739f0a276eb8d6ca917b3974c2edb036da3 "net: fix 64 bit
counters on 32 bit arches" Eric Dumazet dealt with that problem by
requiring callers of dev_get_stats() to provide storage for the
result. This means that the net_device::stats64 field and the padding
in struct net_device_stats are now redundant, so remove them.
Update the comment on net_device_ops::ndo_get_stats64 to reflect its
new usage.
Change dev_txq_stats_fold() to use struct rtnl_link_stats64, since
that is what all its callers are really using and it is no longer
going to be compatible with struct net_device_stats.
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
---
drivers/net/macvlan.c | 2 +-
include/linux/netdevice.h | 70 ++++++++++++++++++---------------------------
net/8021q/vlan_dev.c | 2 +-
net/core/dev.c | 19 +++++++++---
4 files changed, 44 insertions(+), 49 deletions(-)
diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c
index 6112f14..1b28aae 100644
--- a/drivers/net/macvlan.c
+++ b/drivers/net/macvlan.c
@@ -436,7 +436,7 @@ static struct rtnl_link_stats64 *macvlan_dev_get_stats64(struct net_device *dev,
{
struct macvlan_dev *vlan = netdev_priv(dev);
- dev_txq_stats_fold(dev, (struct net_device_stats *)stats);
+ dev_txq_stats_fold(dev, stats);
if (vlan->rx_stats) {
struct macvlan_rx_stats *p, accum = {0};
diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index 8018f6b..17e95e3 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -162,42 +162,32 @@ static inline bool dev_xmit_complete(int rc)
/*
* Old network device statistics. Fields are native words
* (unsigned long) so they can be read and written atomically.
- * Each field is padded to 64 bits for compatibility with
- * rtnl_link_stats64.
*/
-#if BITS_PER_LONG == 64
-#define NET_DEVICE_STATS_DEFINE(name) unsigned long name
-#elif defined(__LITTLE_ENDIAN)
-#define NET_DEVICE_STATS_DEFINE(name) unsigned long name, pad_ ## name
-#else
-#define NET_DEVICE_STATS_DEFINE(name) unsigned long pad_ ## name, name
-#endif
-
struct net_device_stats {
- NET_DEVICE_STATS_DEFINE(rx_packets);
- NET_DEVICE_STATS_DEFINE(tx_packets);
- NET_DEVICE_STATS_DEFINE(rx_bytes);
- NET_DEVICE_STATS_DEFINE(tx_bytes);
- NET_DEVICE_STATS_DEFINE(rx_errors);
- NET_DEVICE_STATS_DEFINE(tx_errors);
- NET_DEVICE_STATS_DEFINE(rx_dropped);
- NET_DEVICE_STATS_DEFINE(tx_dropped);
- NET_DEVICE_STATS_DEFINE(multicast);
- NET_DEVICE_STATS_DEFINE(collisions);
- NET_DEVICE_STATS_DEFINE(rx_length_errors);
- NET_DEVICE_STATS_DEFINE(rx_over_errors);
- NET_DEVICE_STATS_DEFINE(rx_crc_errors);
- NET_DEVICE_STATS_DEFINE(rx_frame_errors);
- NET_DEVICE_STATS_DEFINE(rx_fifo_errors);
- NET_DEVICE_STATS_DEFINE(rx_missed_errors);
- NET_DEVICE_STATS_DEFINE(tx_aborted_errors);
- NET_DEVICE_STATS_DEFINE(tx_carrier_errors);
- NET_DEVICE_STATS_DEFINE(tx_fifo_errors);
- NET_DEVICE_STATS_DEFINE(tx_heartbeat_errors);
- NET_DEVICE_STATS_DEFINE(tx_window_errors);
- NET_DEVICE_STATS_DEFINE(rx_compressed);
- NET_DEVICE_STATS_DEFINE(tx_compressed);
+ unsigned long rx_packets;
+ unsigned long tx_packets;
+ unsigned long rx_bytes;
+ unsigned long tx_bytes;
+ unsigned long rx_errors;
+ unsigned long tx_errors;
+ unsigned long rx_dropped;
+ unsigned long tx_dropped;
+ unsigned long multicast;
+ unsigned long collisions;
+ unsigned long rx_length_errors;
+ unsigned long rx_over_errors;
+ unsigned long rx_crc_errors;
+ unsigned long rx_frame_errors;
+ unsigned long rx_fifo_errors;
+ unsigned long rx_missed_errors;
+ unsigned long tx_aborted_errors;
+ unsigned long tx_carrier_errors;
+ unsigned long tx_fifo_errors;
+ unsigned long tx_heartbeat_errors;
+ unsigned long tx_window_errors;
+ unsigned long rx_compressed;
+ unsigned long tx_compressed;
};
#endif /* __KERNEL__ */
@@ -666,14 +656,13 @@ struct netdev_rx_queue {
* Callback uses when the transmitter has not made any progress
* for dev->watchdog ticks.
*
- * struct rtnl_link_stats64* (*ndo_get_stats64)(struct net_device *dev
+ * struct rtnl_link_stats64* (*ndo_get_stats64)(struct net_device *dev,
* struct rtnl_link_stats64 *storage);
* struct net_device_stats* (*ndo_get_stats)(struct net_device *dev);
* Called when a user wants to get the network device usage
* statistics. Drivers must do one of the following:
- * 1. Define @ndo_get_stats64 to update a rtnl_link_stats64 structure
- * (which should normally be dev->stats64) and return a ponter to
- * it. The structure must not be changed asynchronously.
+ * 1. Define @ndo_get_stats64 to fill in a zero-initialised
+ * rtnl_link_stats64 structure passed by the caller.
* 2. Define @ndo_get_stats to update a net_device_stats structure
* (which should normally be dev->stats) and return a pointer to
* it. The structure may be changed asynchronously only if each
@@ -888,10 +877,7 @@ struct net_device {
int ifindex;
int iflink;
- union {
- struct rtnl_link_stats64 stats64;
- struct net_device_stats stats;
- };
+ struct net_device_stats stats;
#ifdef CONFIG_WIRELESS_EXT
/* List of functions to handle Wireless Extensions (instead of ioctl).
@@ -2147,7 +2133,7 @@ extern void dev_mcast_init(void);
extern const struct rtnl_link_stats64 *dev_get_stats(struct net_device *dev,
struct rtnl_link_stats64 *storage);
extern void dev_txq_stats_fold(const struct net_device *dev,
- struct net_device_stats *stats);
+ struct rtnl_link_stats64 *stats);
extern int netdev_max_backlog;
extern int netdev_tstamp_prequeue;
diff --git a/net/8021q/vlan_dev.c b/net/8021q/vlan_dev.c
index 7865a4c..e66c9bf 100644
--- a/net/8021q/vlan_dev.c
+++ b/net/8021q/vlan_dev.c
@@ -805,7 +805,7 @@ static u32 vlan_ethtool_get_flags(struct net_device *dev)
static struct rtnl_link_stats64 *vlan_dev_get_stats64(struct net_device *dev, struct rtnl_link_stats64 *stats)
{
- dev_txq_stats_fold(dev, (struct net_device_stats *)stats);
+ dev_txq_stats_fold(dev, stats);
if (vlan_dev_info(dev)->vlan_rx_stats) {
struct vlan_rx_stats *p, accum = {0};
diff --git a/net/core/dev.c b/net/core/dev.c
index eb4201c..5ec2eec 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -5274,10 +5274,10 @@ void netdev_run_todo(void)
/**
* dev_txq_stats_fold - fold tx_queues stats
* @dev: device to get statistics from
- * @stats: struct net_device_stats to hold results
+ * @stats: struct rtnl_link_stats64 to hold results
*/
void dev_txq_stats_fold(const struct net_device *dev,
- struct net_device_stats *stats)
+ struct rtnl_link_stats64 *stats)
{
unsigned long tx_bytes = 0, tx_packets = 0, tx_dropped = 0;
unsigned int i;
@@ -5311,17 +5311,26 @@ const struct rtnl_link_stats64 *dev_get_stats(struct net_device *dev,
struct rtnl_link_stats64 *storage)
{
const struct net_device_ops *ops = dev->netdev_ops;
+ size_t i, n = sizeof(*storage) / sizeof(u64);
+ u64 *stats64 = (u64 *)storage;
+ const unsigned long *stats;
if (ops->ndo_get_stats64) {
memset(storage, 0, sizeof(*storage));
return ops->ndo_get_stats64(dev, storage);
}
+
if (ops->ndo_get_stats) {
- memcpy(storage, ops->ndo_get_stats(dev), sizeof(*storage));
+ stats = (const unsigned long *)ops->ndo_get_stats(dev);
+ for (i = 0; i < n; i++)
+ stats64[i] = stats[i];
return storage;
}
- memcpy(storage, &dev->stats, sizeof(*storage));
- dev_txq_stats_fold(dev, (struct net_device_stats *)storage);
+
+ stats = (const unsigned long *)&dev->stats;
+ for (i = 0; i < n; i++)
+ stats64[i] = stats[i];
+ dev_txq_stats_fold(dev, storage);
return storage;
}
EXPORT_SYMBOL(dev_get_stats);
--
1.6.2.5
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
^ permalink raw reply related
* Re: Pull request: bluetooth-2.6 2010-07-08
From: Marcel Holtmann @ 2010-07-08 23:28 UTC (permalink / raw)
To: David Miller; +Cc: netdev
In-Reply-To: <20100708.154637.71104736.davem@davemloft.net>
Hi Dave,
> > these patches fix a few bugs and crashes and also two security related
> > issues with the authentication procedure.
>
> 13 changes is too much this late in the -RC series. Fixes need to
> trickle in, in small quantities, and therefore it's critical that
> maintainers submit fixes often and as soon as they are ready.
>
> Please pick a small number of the most critical fixes, say 3 or 4. An
> easy way to roughly quantify which ones shoule be included is:
>
> 1) Is there an OOPS or crash regression reported by real users and
> listed in the official lkml regression list which is caused by this
> problem?
>
> 2) Is there an exploitable security concern fixed by this change?
>
> Else, it's only net-next-2.6 material.
>
> For example:
>
> Bluetooth: Remove max_tx and tx_window module paramenters from L2CAP
>
> Things like that change are absolutely not appropriate at this
> stage in the post merge-window development environment.
I can take these out and leave them for -next. That is fine with me, but
you asked Gustavo to remove these. And so I left them in.
Regards
Marcel
^ permalink raw reply
* Re: [PATCH 1/6 net-next-2.6] vxge: Remove queue_state references
From: Jon Mason @ 2010-07-08 23:19 UTC (permalink / raw)
To: David Miller; +Cc: netdev@vger.kernel.org, Sreenivasa Honnur, ramkrishna.vepa
In-Reply-To: <20100708191957.GA15167@exar.com>
On Thu, Jul 08, 2010 at 12:19:57PM -0700, Jon Mason wrote:
> Remove queue_state references, as they are no longer necessary.
>
> Also, The driver needs to start/stop the queue regardless of which type
> of steering is enabled. Remove checks for TX_MULTIQ_STEERING only and
> start/stop for all steering types.
>
> Signed-off-by: Jon Mason <jon.mason@exar.com>
> Signed-off-by: Sreenivasa Honnur <sreenivasa.honnur@exar.com>
> Signed-off-by: Ramkrishna Vepa <ram.vepa@exar.com>
Ram's e-mail address is incorrect in this series. Would you like me
to resubmit with it corrected?
Thanks,
Jon
> ---
> drivers/net/vxge/vxge-main.c | 118 +++++++++++++++---------------------------
> drivers/net/vxge/vxge-main.h | 10 +---
> 2 files changed, 42 insertions(+), 86 deletions(-)
>
> diff --git a/drivers/net/vxge/vxge-main.c b/drivers/net/vxge/vxge-main.c
> index ed17865..e78703d 100644
> --- a/drivers/net/vxge/vxge-main.c
> +++ b/drivers/net/vxge/vxge-main.c
> @@ -133,75 +133,48 @@ static inline void VXGE_COMPLETE_ALL_RX(struct vxgedev *vdev)
> /*
> * MultiQ manipulation helper functions
> */
> -void vxge_stop_all_tx_queue(struct vxgedev *vdev)
> +static inline int vxge_netif_queue_stopped(struct vxge_fifo *fifo)
> {
> - int i;
> - struct net_device *dev = vdev->ndev;
> + struct net_device *dev = fifo->ndev;
> + struct netdev_queue *txq = NULL;
> + int vpath_no = fifo->driver_id;
> + int ret = 0;
>
> - if (vdev->config.tx_steering_type != TX_MULTIQ_STEERING) {
> - for (i = 0; i < vdev->no_of_vpath; i++)
> - vdev->vpaths[i].fifo.queue_state = VPATH_QUEUE_STOP;
> - }
> - netif_tx_stop_all_queues(dev);
> + if (fifo->tx_steering_type)
> + txq = netdev_get_tx_queue(dev, vpath_no);
> + else
> + txq = netdev_get_tx_queue(dev, 0);
> +
> + ret = netif_tx_queue_stopped(txq);
> + return ret;
> }
>
> void vxge_stop_tx_queue(struct vxge_fifo *fifo)
> {
> struct net_device *dev = fifo->ndev;
> -
> struct netdev_queue *txq = NULL;
> - if (fifo->tx_steering_type == TX_MULTIQ_STEERING)
> +
> + if (fifo->tx_steering_type)
> txq = netdev_get_tx_queue(dev, fifo->driver_id);
> - else {
> + else
> txq = netdev_get_tx_queue(dev, 0);
> - fifo->queue_state = VPATH_QUEUE_STOP;
> - }
>
> netif_tx_stop_queue(txq);
> }
>
> -void vxge_start_all_tx_queue(struct vxgedev *vdev)
> -{
> - int i;
> - struct net_device *dev = vdev->ndev;
> -
> - if (vdev->config.tx_steering_type != TX_MULTIQ_STEERING) {
> - for (i = 0; i < vdev->no_of_vpath; i++)
> - vdev->vpaths[i].fifo.queue_state = VPATH_QUEUE_START;
> - }
> - netif_tx_start_all_queues(dev);
> -}
> -
> -static void vxge_wake_all_tx_queue(struct vxgedev *vdev)
> -{
> - int i;
> - struct net_device *dev = vdev->ndev;
> -
> - if (vdev->config.tx_steering_type != TX_MULTIQ_STEERING) {
> - for (i = 0; i < vdev->no_of_vpath; i++)
> - vdev->vpaths[i].fifo.queue_state = VPATH_QUEUE_START;
> - }
> - netif_tx_wake_all_queues(dev);
> -}
> -
> -void vxge_wake_tx_queue(struct vxge_fifo *fifo, struct sk_buff *skb)
> +void vxge_wake_tx_queue(struct vxge_fifo *fifo)
> {
> struct net_device *dev = fifo->ndev;
> -
> - int vpath_no = fifo->driver_id;
> struct netdev_queue *txq = NULL;
> - if (fifo->tx_steering_type == TX_MULTIQ_STEERING) {
> + int vpath_no = fifo->driver_id;
> +
> + if (fifo->tx_steering_type)
> txq = netdev_get_tx_queue(dev, vpath_no);
> - if (netif_tx_queue_stopped(txq))
> - netif_tx_wake_queue(txq);
> - } else {
> + else
> txq = netdev_get_tx_queue(dev, 0);
> - if (fifo->queue_state == VPATH_QUEUE_STOP)
> - if (netif_tx_queue_stopped(txq)) {
> - fifo->queue_state = VPATH_QUEUE_START;
> - netif_tx_wake_queue(txq);
> - }
> - }
> +
> + if (netif_tx_queue_stopped(txq))
> + netif_tx_wake_queue(txq);
> }
>
> /*
> @@ -222,7 +195,7 @@ vxge_callback_link_up(struct __vxge_hw_device *hldev)
> vdev->stats.link_up++;
>
> netif_carrier_on(vdev->ndev);
> - vxge_wake_all_tx_queue(vdev);
> + netif_tx_wake_all_queues(vdev->ndev);
>
> vxge_debug_entryexit(VXGE_TRACE,
> "%s: %s:%d Exiting...", vdev->ndev->name, __func__, __LINE__);
> @@ -246,7 +219,7 @@ vxge_callback_link_down(struct __vxge_hw_device *hldev)
>
> vdev->stats.link_down++;
> netif_carrier_off(vdev->ndev);
> - vxge_stop_all_tx_queue(vdev);
> + netif_tx_stop_all_queues(vdev->ndev);
>
> vxge_debug_entryexit(VXGE_TRACE,
> "%s: %s:%d Exiting...", vdev->ndev->name, __func__, __LINE__);
> @@ -677,7 +650,7 @@ vxge_xmit_compl(struct __vxge_hw_fifo *fifo_hw, void *dtr,
> &dtr, &t_code) == VXGE_HW_OK);
>
> *skb_ptr = done_skb;
> - vxge_wake_tx_queue(fifo, skb);
> + vxge_wake_tx_queue(fifo);
>
> vxge_debug_entryexit(VXGE_TRACE,
> "%s: %s:%d Exiting...",
> @@ -881,17 +854,11 @@ vxge_xmit(struct sk_buff *skb, struct net_device *dev)
> return NETDEV_TX_LOCKED;
> }
>
> - if (vdev->config.tx_steering_type == TX_MULTIQ_STEERING) {
> - if (netif_subqueue_stopped(dev, skb)) {
> - spin_unlock_irqrestore(&fifo->tx_lock, flags);
> - return NETDEV_TX_BUSY;
> - }
> - } else if (unlikely(fifo->queue_state == VPATH_QUEUE_STOP)) {
> - if (netif_queue_stopped(dev)) {
> - spin_unlock_irqrestore(&fifo->tx_lock, flags);
> - return NETDEV_TX_BUSY;
> - }
> + if (vxge_netif_queue_stopped(fifo)) {
> + spin_unlock_irqrestore(&fifo->tx_lock, flags);
> + return NETDEV_TX_BUSY;
> }
> +
> avail = vxge_hw_fifo_free_txdl_count_get(fifo_hw);
> if (avail == 0) {
> vxge_debug_tx(VXGE_ERR,
> @@ -1478,7 +1445,7 @@ static int vxge_reset_vpath(struct vxgedev *vdev, int vp_id)
> clear_bit(vp_id, &vdev->vp_reset);
>
> /* Start the vpath queue */
> - vxge_wake_tx_queue(&vdev->vpaths[vp_id].fifo, NULL);
> + vxge_wake_tx_queue(&vdev->vpaths[vp_id].fifo);
>
> return ret;
> }
> @@ -1513,7 +1480,7 @@ static int do_vxge_reset(struct vxgedev *vdev, int event)
> "%s: execution mode is debug, returning..",
> vdev->ndev->name);
> clear_bit(__VXGE_STATE_CARD_UP, &vdev->state);
> - vxge_stop_all_tx_queue(vdev);
> + netif_tx_stop_all_queues(vdev->ndev);
> return 0;
> }
> }
> @@ -1523,7 +1490,7 @@ static int do_vxge_reset(struct vxgedev *vdev, int event)
>
> switch (vdev->cric_err_event) {
> case VXGE_HW_EVENT_UNKNOWN:
> - vxge_stop_all_tx_queue(vdev);
> + netif_tx_stop_all_queues(vdev->ndev);
> vxge_debug_init(VXGE_ERR,
> "fatal: %s: Disabling device due to"
> "unknown error",
> @@ -1544,7 +1511,7 @@ static int do_vxge_reset(struct vxgedev *vdev, int event)
> case VXGE_HW_EVENT_VPATH_ERR:
> break;
> case VXGE_HW_EVENT_CRITICAL_ERR:
> - vxge_stop_all_tx_queue(vdev);
> + netif_tx_stop_all_queues(vdev->ndev);
> vxge_debug_init(VXGE_ERR,
> "fatal: %s: Disabling device due to"
> "serious error",
> @@ -1554,7 +1521,7 @@ static int do_vxge_reset(struct vxgedev *vdev, int event)
> ret = -EPERM;
> goto out;
> case VXGE_HW_EVENT_SERR:
> - vxge_stop_all_tx_queue(vdev);
> + netif_tx_stop_all_queues(vdev->ndev);
> vxge_debug_init(VXGE_ERR,
> "fatal: %s: Disabling device due to"
> "serious error",
> @@ -1566,7 +1533,7 @@ static int do_vxge_reset(struct vxgedev *vdev, int event)
> ret = -EPERM;
> goto out;
> case VXGE_HW_EVENT_SLOT_FREEZE:
> - vxge_stop_all_tx_queue(vdev);
> + netif_tx_stop_all_queues(vdev->ndev);
> vxge_debug_init(VXGE_ERR,
> "fatal: %s: Disabling device due to"
> "slot freeze",
> @@ -1580,7 +1547,7 @@ static int do_vxge_reset(struct vxgedev *vdev, int event)
> }
>
> if ((event == VXGE_LL_FULL_RESET) || (event == VXGE_LL_START_RESET))
> - vxge_stop_all_tx_queue(vdev);
> + netif_tx_stop_all_queues(vdev->ndev);
>
> if (event == VXGE_LL_FULL_RESET) {
> status = vxge_reset_all_vpaths(vdev);
> @@ -1640,7 +1607,7 @@ static int do_vxge_reset(struct vxgedev *vdev, int event)
> vxge_hw_vpath_rx_doorbell_init(vdev->vpaths[i].handle);
> }
>
> - vxge_wake_all_tx_queue(vdev);
> + netif_tx_wake_all_queues(vdev->ndev);
> }
>
> out:
> @@ -2779,7 +2746,7 @@ vxge_open(struct net_device *dev)
> vxge_hw_vpath_rx_doorbell_init(vdev->vpaths[i].handle);
> }
>
> - vxge_start_all_tx_queue(vdev);
> + netif_tx_start_all_queues(vdev->ndev);
> goto out0;
>
> out2:
> @@ -2902,7 +2869,7 @@ int do_vxge_close(struct net_device *dev, int do_io)
>
> netif_carrier_off(vdev->ndev);
> printk(KERN_NOTICE "%s: Link Down\n", vdev->ndev->name);
> - vxge_stop_all_tx_queue(vdev);
> + netif_tx_stop_all_queues(vdev->ndev);
>
> /* Note that at this point xmit() is stopped by upper layer */
> if (do_io)
> @@ -3215,7 +3182,7 @@ int __devinit vxge_device_register(struct __vxge_hw_device *hldev,
> u64 stat;
>
> *vdev_out = NULL;
> - if (config->tx_steering_type == TX_MULTIQ_STEERING)
> + if (config->tx_steering_type)
> no_of_queue = no_of_vpath;
>
> ndev = alloc_etherdev_mq(sizeof(struct vxgedev),
> @@ -3284,9 +3251,6 @@ int __devinit vxge_device_register(struct __vxge_hw_device *hldev,
> if (vdev->config.gro_enable)
> ndev->features |= NETIF_F_GRO;
>
> - if (vdev->config.tx_steering_type == TX_MULTIQ_STEERING)
> - ndev->real_num_tx_queues = no_of_vpath;
> -
> #ifdef NETIF_F_LLTX
> ndev->features |= NETIF_F_LLTX;
> #endif
> diff --git a/drivers/net/vxge/vxge-main.h b/drivers/net/vxge/vxge-main.h
> index 60276b2..a384582 100644
> --- a/drivers/net/vxge/vxge-main.h
> +++ b/drivers/net/vxge/vxge-main.h
> @@ -228,10 +228,6 @@ struct vxge_fifo {
> int tx_steering_type;
> int indicate_max_pkts;
> spinlock_t tx_lock;
> - /* flag used to maintain queue state when MULTIQ is not enabled */
> -#define VPATH_QUEUE_START 0
> -#define VPATH_QUEUE_STOP 1
> - int queue_state;
>
> /* Tx stats */
> struct vxge_fifo_stats stats;
> @@ -447,13 +443,9 @@ int vxge_open_vpaths(struct vxgedev *vdev);
>
> enum vxge_hw_status vxge_reset_all_vpaths(struct vxgedev *vdev);
>
> -void vxge_stop_all_tx_queue(struct vxgedev *vdev);
> -
> void vxge_stop_tx_queue(struct vxge_fifo *fifo);
>
> -void vxge_start_all_tx_queue(struct vxgedev *vdev);
> -
> -void vxge_wake_tx_queue(struct vxge_fifo *fifo, struct sk_buff *skb);
> +void vxge_wake_tx_queue(struct vxge_fifo *fifo);
>
> enum vxge_hw_status vxge_add_mac_addr(struct vxgedev *vdev,
> struct macInfo *mac);
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* Re: [PATCH] sysfs: Don't allow the creation of symlinks we can't remove
From: Greg KH @ 2010-07-08 23:06 UTC (permalink / raw)
To: Eric W. Biederman
Cc: Greg KH, Andrew Morton, Rafael J. Wysocki, Maciej W. Rozycki,
Kay Sievers, Johannes Berg, netdev
In-Reply-To: <m1r5jdbobe.fsf@fess.ebiederm.org>
On Thu, Jul 08, 2010 at 03:28:53PM -0700, Eric W. Biederman wrote:
> Greg KH <greg@kroah.com> writes:
>
> > With this patch, how does the existing code fail as the drivers aren't
> > fixed up?
> >
> > I like this change, just worried it will cause problems if it gets into
> > .35, without your RFC patch. Will it?
>
> It don't expect this patch to be worse than where we are current at.
> Network devices are renamed, and come and go enough that both the
> mac80211_hwsim and the bnep driver are currently unusable with a
> failure only the rename and remove.
>
> This patch simply moves the failure into creation where we are a little more
> prepared to deal with problems, and this patch is limited to mac80211_hwsim,
> bnep, and any hypothetically undiscovered other network devices that
> have the same problem.
>
> mac80211_hwsim with just this patch becomes somewhat usable as it's primary
> network device gets registered and the module can be loaded and unloaded. It
> just doesn't create the wlan0 and wlan1 interfaces for the wifi interfaces.
Fair enough, I've commited it now, let's see what happens :)
> On a slightly unrelated note, what got us on trying to convert
> mac80211_hwsim was that everything happens in a single module which
> makes avoiding cleanup races hard. I am hoping bnep is structured
> enough differently so we can convert it to a bus device using the
> existing infrastructure. I haven't figured out bnep yet though ;(
Yeah, good luck with that...
greg k-h
^ permalink raw reply
* Re: Pull request: bluetooth-2.6 2010-07-08
From: David Miller @ 2010-07-08 22:46 UTC (permalink / raw)
To: marcel; +Cc: netdev
In-Reply-To: <cover.1278619047.git.marcel@holtmann.org>
From: Marcel Holtmann <marcel@holtmann.org>
Date: Thu, 8 Jul 2010 16:59:49 -0300
> these patches fix a few bugs and crashes and also two security related
> issues with the authentication procedure.
13 changes is too much this late in the -RC series. Fixes need to
trickle in, in small quantities, and therefore it's critical that
maintainers submit fixes often and as soon as they are ready.
Please pick a small number of the most critical fixes, say 3 or 4. An
easy way to roughly quantify which ones shoule be included is:
1) Is there an OOPS or crash regression reported by real users and
listed in the official lkml regression list which is caused by this
problem?
2) Is there an exploitable security concern fixed by this change?
Else, it's only net-next-2.6 material.
For example:
Bluetooth: Remove max_tx and tx_window module paramenters from L2CAP
Things like that change are absolutely not appropriate at this
stage in the post merge-window development environment.
Thanks.
^ permalink raw reply
* [PATCH] extensions: libipt_CHECKSUM extension
From: Michael S. Tsirkin @ 2010-07-08 22:35 UTC (permalink / raw)
To: Patrick McHardy, David S. Miller, Alexey Kuznetsov,
Pekka Savola (ipv6), James Morris <jmorris@
In-Reply-To: <20100708222913.GA4475@redhat.com>
This adds a `CHECKSUM' target, which can be used in the iptables mangle
table.
You can use this target to compute and fill in the checksum in
an IP packet that lacks a checksum. This is particularly useful,
if you need to work around old applications such as dhcp clients,
that do not work well with checksum offloads, but don't want to disable
checksum offload in your device.
The problem happens in the field with virtualized applications.
For reference, see Red Hat bz 605555, as well as
http://www.spinics.net/lists/kvm/msg37660.html
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
This patch adds userspace support for the CHECKSUM kernel module I sent previously.
extensions/libipt_CHECKSUM.c | 100 ++++++++++++++++++++++++++++++++++++++++
extensions/libipt_CHECKSUM.man | 8 +++
2 files changed, 108 insertions(+), 0 deletions(-)
create mode 100644 extensions/libipt_CHECKSUM.c
create mode 100644 extensions/libipt_CHECKSUM.man
diff --git a/extensions/libipt_CHECKSUM.c b/extensions/libipt_CHECKSUM.c
new file mode 100644
index 0000000..93d3e3f
--- /dev/null
+++ b/extensions/libipt_CHECKSUM.c
@@ -0,0 +1,100 @@
+/* Shared library add-on to iptables for CHECKSUM
+ *
+ * (C) 2002 by Harald Welte <laforge@gnumonks.org>
+ * (C) 2010 by Red Hat, Inc
+ * Author: Michael S. Tsirkin <mst@redhat.com>
+ *
+ * This program is distributed under the terms of GNU GPL v2, 1991
+ *
+ * libipt_CHECKSUM.c borrowed heavily from libipt_ECN.c
+ *
+ * $Id$
+ */
+#include <stdio.h>
+#include <string.h>
+#include <stdlib.h>
+#include <getopt.h>
+
+#include <xtables.h>
+#include <linux/netfilter_ipv4/ipt_CHECKSUM.h>
+
+static void CHECKSUM_help(void)
+{
+ printf(
+"CHECKSUM target options\n"
+" --checksum-fill Fill in packet checksum.\n");
+}
+
+static const struct option CHECKSUM_opts[] = {
+ { "checksum-fill", 0, NULL, 'F' },
+ { .name = NULL }
+};
+
+static int CHECKSUM_parse(int c, char **argv, int invert, unsigned int *flags,
+ const void *entry, struct xt_entry_target **target)
+{
+ unsigned int result;
+ struct ipt_CHECKSUM_info *einfo
+ = (struct ipt_CHECKSUM_info *)(*target)->data;
+
+ switch (c) {
+ case 'F':
+ if (*flags)
+ xtables_error(PARAMETER_PROBLEM,
+ "CHECKSUM target: Only use --checksum-fill ONCE!");
+ einfo->operation = IPT_CHECKSUM_OP_FILL;
+ *flags |= IPT_CHECKSUM_OP_FILL;
+ break;
+ default:
+ return 0;
+ }
+
+ return 1;
+}
+
+static void CHECKSUM_check(unsigned int flags)
+{
+ if (!flags)
+ xtables_error(PARAMETER_PROBLEM,
+ "CHECKSUM target: Parameter --checksum-fill is required");
+}
+
+static void CHECKSUM_print(const void *ip, const struct xt_entry_target *target,
+ int numeric)
+{
+ const struct ipt_CHECKSUM_info *einfo =
+ (const struct ipt_CHECKSUM_info *)target->data;
+
+ printf("CHECKSUM ");
+
+ if (einfo->operation & IPT_CHECKSUM_OP_FILL)
+ printf("fill ");
+}
+
+static void CHECKSUM_save(const void *ip, const struct xt_entry_target *target)
+{
+ const struct ipt_CHECKSUM_info *einfo =
+ (const struct ipt_CHECKSUM_info *)target->data;
+
+ if (einfo->operation & IPT_CHECKSUM_OP_FILL)
+ printf("--checksum-fill ");
+}
+
+static struct xtables_target checksum_tg_reg = {
+ .name = "CHECKSUM",
+ .version = XTABLES_VERSION,
+ .family = NFPROTO_IPV4,
+ .size = XT_ALIGN(sizeof(struct ipt_CHECKSUM_info)),
+ .userspacesize = XT_ALIGN(sizeof(struct ipt_CHECKSUM_info)),
+ .help = CHECKSUM_help,
+ .parse = CHECKSUM_parse,
+ .final_check = CHECKSUM_check,
+ .print = CHECKSUM_print,
+ .save = CHECKSUM_save,
+ .extra_opts = CHECKSUM_opts,
+};
+
+void _init(void)
+{
+ xtables_register_target(&checksum_tg_reg);
+}
diff --git a/extensions/libipt_CHECKSUM.man b/extensions/libipt_CHECKSUM.man
new file mode 100644
index 0000000..4f83335
--- /dev/null
+++ b/extensions/libipt_CHECKSUM.man
@@ -0,0 +1,8 @@
+This target allows to selectively work around broken/old applications.
+It can only be used in the mangle table.
+.TP
+\fB\-\-checksum\-fill\fP
+Compute and fill in the checksum in an IP packet that lacks a checksum.
+This is particularly useful, if you need to work around old applications
+such as dhcp clients, that do not work well with checksum offloads,
+but don't want to disable checksum offload in your device.
--
1.7.2.rc0.14.g41c1c
^ permalink raw reply related
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox