* Re: [PATCH 4/4] zd1211rw: remove unnecessary [kv][mcz]alloc casts
From: Johannes Berg @ 2010-11-28 9:30 UTC (permalink / raw)
To: Joe Perches
Cc: Daniel Drake, Ulrich Kunitz, linux-wireless, John W. Linville,
linux-kernel, netdev
In-Reply-To: <1290936047.16349.13.camel@Joe-Laptop>
On Sun, 2010-11-28 at 01:20 -0800, Joe Perches wrote:
> On Sun, 2010-11-28 at 10:12 +0100, Johannes Berg wrote:
> > On Sun, 2010-11-28 at 01:05 -0800, Joe Perches wrote:
> > > diff --git a/drivers/net/wireless/zd1211rw/zd_chip.c b/drivers/net/wireless/zd1211rw/zd_chip.c
> > > @@ -117,8 +117,7 @@ int zd_ioread32v_locked(struct zd_chip *chip, u32 *values, const zd_addr_t *addr
> > >
> > > /* Allocate a single memory block for values and addresses. */
> > > count16 = 2*count;
> > > - a16 = (zd_addr_t *) kmalloc(count16 * (sizeof(zd_addr_t) + sizeof(u16)),
> > > - GFP_KERNEL);
> > > + a16 = kmalloc(count16 * (sizeof(zd_addr_t) + sizeof(u16)), GFP_KERNEL);
> > I believe this is on purpose for sparse.
>
> Perhaps in a previous version, but not now.
>
> $ make C=1 drivers/net/wireless/zd1211rw/zd_chip.o
> CHK include/linux/version.h
> CHK include/generated/utsrelease.h
> CALL scripts/checksyscalls.sh
> CHECK drivers/net/wireless/zd1211rw/zd_chip.c
> include/trace/events/kmem.h:45:1: error: Expected ( after asm
> include/trace/events/kmem.h:45:1: error: got goto
How do you know? I thought sparse was pretty much not reliable after the
first error it prints.
johannes
^ permalink raw reply
* Re: [PATCH 4/4] zd1211rw: remove unnecessary [kv][mcz]alloc casts
From: Joe Perches @ 2010-11-28 9:50 UTC (permalink / raw)
To: Johannes Berg
Cc: Daniel Drake, Ulrich Kunitz,
linux-wireless-u79uwXL29TY76Z2rM5mHXA, John W. Linville,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, netdev
In-Reply-To: <1290936606.3467.2.camel-8upI4CBIZJIJvtFkdXX2HixXY32XiHfO@public.gmane.org>
On Sun, 2010-11-28 at 10:30 +0100, Johannes Berg wrote:
> On Sun, 2010-11-28 at 01:20 -0800, Joe Perches wrote:
> > On Sun, 2010-11-28 at 10:12 +0100, Johannes Berg wrote:
> > > On Sun, 2010-11-28 at 01:05 -0800, Joe Perches wrote:
> > > > diff --git a/drivers/net/wireless/zd1211rw/zd_chip.c b/drivers/net/wireless/zd1211rw/zd_chip.c
> > > > @@ -117,8 +117,7 @@ int zd_ioread32v_locked(struct zd_chip *chip, u32 *values, const zd_addr_t *addr
> > > > /* Allocate a single memory block for values and addresses. */
> > > > count16 = 2*count;
> > > > - a16 = (zd_addr_t *) kmalloc(count16 * (sizeof(zd_addr_t) + sizeof(u16)),
> > > > - GFP_KERNEL);
> > > > + a16 = kmalloc(count16 * (sizeof(zd_addr_t) + sizeof(u16)), GFP_KERNEL);
> > > I believe this is on purpose for sparse.
> > Perhaps in a previous version, but not now.
> How do you know? I thought sparse was pretty much not reliable after the
> first error it prints.
Good memory you have Johannes...
http://marc.info/?l=linux-netdev&m=117113743902549&w=3
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* Re: [PATCH 4/4] zd1211rw: remove unnecessary [kv][mcz]alloc casts
From: Johannes Berg @ 2010-11-28 10:02 UTC (permalink / raw)
To: Joe Perches
Cc: Daniel Drake, Ulrich Kunitz, linux-wireless, John W. Linville,
linux-kernel, netdev
In-Reply-To: <1290937845.16349.16.camel@Joe-Laptop>
On Sun, 2010-11-28 at 01:50 -0800, Joe Perches wrote:
> On Sun, 2010-11-28 at 10:30 +0100, Johannes Berg wrote:
> > On Sun, 2010-11-28 at 01:20 -0800, Joe Perches wrote:
> > > On Sun, 2010-11-28 at 10:12 +0100, Johannes Berg wrote:
> > > > On Sun, 2010-11-28 at 01:05 -0800, Joe Perches wrote:
> > > > > diff --git a/drivers/net/wireless/zd1211rw/zd_chip.c b/drivers/net/wireless/zd1211rw/zd_chip.c
> > > > > @@ -117,8 +117,7 @@ int zd_ioread32v_locked(struct zd_chip *chip, u32 *values, const zd_addr_t *addr
> > > > > /* Allocate a single memory block for values and addresses. */
> > > > > count16 = 2*count;
> > > > > - a16 = (zd_addr_t *) kmalloc(count16 * (sizeof(zd_addr_t) + sizeof(u16)),
> > > > > - GFP_KERNEL);
> > > > > + a16 = kmalloc(count16 * (sizeof(zd_addr_t) + sizeof(u16)), GFP_KERNEL);
> > > > I believe this is on purpose for sparse.
> > > Perhaps in a previous version, but not now.
> > How do you know? I thought sparse was pretty much not reliable after the
> > first error it prints.
>
> Good memory you have Johannes...
>
> http://marc.info/?l=linux-netdev&m=117113743902549&w=3
I, err, not really, all this isn't making a whole lot of sense to me
right now :-)
The only thing I remembered was that there was something weird with
zd_addr_t ...
Did sparse become more reliable in face of errors?
johannes
^ permalink raw reply
* [PATCH V2 4/4] zd1211rw: document need for kmalloc cast
From: Joe Perches @ 2010-11-28 10:02 UTC (permalink / raw)
To: Johannes Berg
Cc: Daniel Drake, Ulrich Kunitz, linux-wireless, John W. Linville,
linux-kernel, netdev
In-Reply-To: <1290936606.3467.2.camel@jlt3.sipsolutions.net>
Signed-off-by: Joe Perches <joe@perches.com>
---
V2: Just document the need for the cast
diff --git a/drivers/net/wireless/zd1211rw/zd_chip.c b/drivers/net/wireless/zd1211rw/zd_chip.c
index 87a95bc..dd0bb0c 100644
--- a/drivers/net/wireless/zd1211rw/zd_chip.c
+++ b/drivers/net/wireless/zd1211rw/zd_chip.c
@@ -117,6 +117,7 @@ int zd_ioread32v_locked(struct zd_chip *chip, u32 *values, const zd_addr_t *addr
/* Allocate a single memory block for values and addresses. */
count16 = 2*count;
+ /* zd_addr_t is __nocast, so the kmalloc needs an explicit cast */
a16 = (zd_addr_t *) kmalloc(count16 * (sizeof(zd_addr_t) + sizeof(u16)),
GFP_KERNEL);
if (!a16) {
^ permalink raw reply related
* Re: [PATCH 4/4] zd1211rw: remove unnecessary [kv][mcz]alloc casts
From: Joe Perches @ 2010-11-28 10:13 UTC (permalink / raw)
To: Johannes Berg
Cc: Daniel Drake, Ulrich Kunitz, John W. Linville,
linux-wireless-u79uwXL29TY76Z2rM5mHXA, netdev, LKML
In-Reply-To: <1290938527.3467.5.camel-8upI4CBIZJIJvtFkdXX2HixXY32XiHfO@public.gmane.org>
On Sun, 2010-11-28 at 11:02 +0100, Johannes Berg wrote:
> On Sun, 2010-11-28 at 01:50 -0800, Joe Perches wrote:
> > Good memory you have Johannes...
> > http://marc.info/?l=linux-netdev&m=117113743902549&w=3
> I, err, not really, all this isn't making a whole lot of sense to me
> right now :-)
> The only thing I remembered was that there was something weird with
> zd_addr_t ...
Yes. It's marked __nocast.
> Did sparse become more reliable in face of errors?
Apparently not.
If the kmalloc cast in zd_chip is removed:
$ make C=1 drivers/net/wireless/zd1211rw/zd_chip.o
CHK include/linux/version.h
CHK include/generated/utsrelease.h
CALL scripts/checksyscalls.sh
CHECK drivers/net/wireless/zd1211rw/zd_chip.c
arch/x86/include/asm/uaccess_32.h:197:9: error: attribute 'error': unknown attribute
CC drivers/net/wireless/zd1211rw/zd_chip.o
$
If the __compiletime_<foo> uses in uaccess_32.h are removed,
and the kmalloc cast in zd_chip is also removed:
$ make C=1 drivers/net/wireless/zd1211rw/zd_chip.o
CHK include/linux/version.h
CHK include/generated/utsrelease.h
CC arch/x86/kernel/asm-offsets.s
GEN include/generated/asm-offsets.h
CALL scripts/checksyscalls.sh
CHECK drivers/net/wireless/zd1211rw/zd_chip.c
drivers/net/wireless/zd1211rw/zd_chip.c:121:22: warning: implicit cast to nocast type
CC drivers/net/wireless/zd1211rw/zd_chip.o
$
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* Re: [PATCH net-next] bnx2x: Use skb_is_gso_v6(skb) instead of accessing the skb_shinfo(skb) directly
From: Vladislav Zolotarov @ 2010-11-28 10:22 UTC (permalink / raw)
To: Eric Dumazet; +Cc: Dave Miller, Eilon Greenstein, netdev list
In-Reply-To: <1290851625.2794.17.camel@edumazet-laptop>
>
> May I ask why ?
>
> This seems not consistent with the previous block.
>
> Either you also add a skb_is_gso_v4(skb) helper, or let the code as is,
> maybe reordering the flags ?
>
U r right. I'm respinning a patch taking your remarks and a "brackets"
patch into an account.
thanks, Eric.
^ permalink raw reply
* [PATCH net-next] bnx2x: Use helpers instead of direct access to the shinfo(skb) fields
From: Vladislav Zolotarov @ 2010-11-28 10:23 UTC (permalink / raw)
To: Dave Miller; +Cc: Eilon Greenstein, netdev list
In-Reply-To: <1290851625.2794.17.camel@edumazet-laptop>
Signed-off-by: Vladislav Zolotarov <vladz@broadcom.com>
Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
---
drivers/net/bnx2x/bnx2x_cmn.c | 9 ++++-----
1 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/net/bnx2x/bnx2x_cmn.c b/drivers/net/bnx2x/bnx2x_cmn.c
index 94d5f59..e20b2d3 100644
--- a/drivers/net/bnx2x/bnx2x_cmn.c
+++ b/drivers/net/bnx2x/bnx2x_cmn.c
@@ -1692,11 +1692,10 @@ static inline u32 bnx2x_xmit_type(struct bnx2x *bp, struct sk_buff *skb)
}
}
- if (skb_shinfo(skb)->gso_type & SKB_GSO_TCPV4)
- rc |= (XMIT_GSO_V4 | XMIT_CSUM_V4 | XMIT_CSUM_TCP);
-
- else if (skb_shinfo(skb)->gso_type & SKB_GSO_TCPV6)
- rc |= (XMIT_GSO_V6 | XMIT_CSUM_TCP | XMIT_CSUM_V6);
+ if (skb_is_gso_v6(skb))
+ rc |= XMIT_GSO_V6 | XMIT_CSUM_TCP | XMIT_CSUM_V6;
+ else if (skb_is_gso(skb))
+ rc |= XMIT_GSO_V4 | XMIT_CSUM_V4 | XMIT_CSUM_TCP;
return rc;
}
--
1.7.0.4
^ permalink raw reply related
* [PATCH] ssb: Add sysfs attributes to ssb devices
From: Hauke Mehrtens @ 2010-11-28 11:22 UTC (permalink / raw)
To: davem; +Cc: mb, netdev, Hauke Mehrtens, Bernhard Loos
Make it possible to read out the attributes, till now only show on
dmesg, through sysfs.
This patch was some time in OpenWrt.
Signed-off-by: Bernhard Loos <bernhardloos@googlemail.com>
Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
---
drivers/ssb/main.c | 30 ++++++++++++++++++++++++++++++
1 files changed, 30 insertions(+), 0 deletions(-)
diff --git a/drivers/ssb/main.c b/drivers/ssb/main.c
index c68b3dc..3918d2c 100644
--- a/drivers/ssb/main.c
+++ b/drivers/ssb/main.c
@@ -383,6 +383,35 @@ static int ssb_device_uevent(struct device *dev, struct kobj_uevent_env *env)
ssb_dev->id.revision);
}
+#define ssb_config_attr(attrib, field, format_string) \
+static ssize_t \
+attrib##_show(struct device *dev, struct device_attribute *attr, char *buf) \
+{ \
+ return sprintf(buf, format_string, dev_to_ssb_dev(dev)->field); \
+}
+
+ssb_config_attr(core_num, core_index, "%u\n")
+ssb_config_attr(coreid, id.coreid, "0x%04x\n")
+ssb_config_attr(vendor, id.vendor, "0x%04x\n")
+ssb_config_attr(revision, id.revision, "%u\n")
+ssb_config_attr(irq, irq, "%u\n")
+static ssize_t
+name_show(struct device *dev, struct device_attribute *attr, char *buf)
+{
+ return sprintf(buf, "%s\n",
+ ssb_core_name(dev_to_ssb_dev(dev)->id.coreid));
+}
+
+static struct device_attribute ssb_device_attrs[] = {
+ __ATTR_RO(name),
+ __ATTR_RO(core_num),
+ __ATTR_RO(coreid),
+ __ATTR_RO(vendor),
+ __ATTR_RO(revision),
+ __ATTR_RO(irq),
+ __ATTR_NULL,
+};
+
static struct bus_type ssb_bustype = {
.name = "ssb",
.match = ssb_bus_match,
@@ -392,6 +421,7 @@ static struct bus_type ssb_bustype = {
.suspend = ssb_device_suspend,
.resume = ssb_device_resume,
.uevent = ssb_device_uevent,
+ .dev_attrs = ssb_device_attrs,
};
static void ssb_buses_lock(void)
--
1.7.1
^ permalink raw reply related
* Re: [PATCH] econet: Move to staging; remove from defconfig
From: Ben Hutchings @ 2010-11-28 15:11 UTC (permalink / raw)
To: David Miller; +Cc: gregkh, netdev, devel, linux-arm-kernel, debian-kernel
In-Reply-To: <20101127.223845.189711153.davem@davemloft.net>
[-- Attachment #1: Type: text/plain, Size: 1962 bytes --]
On Sat, 2010-11-27 at 22:38 -0800, David Miller wrote:
> From: Ben Hutchings <ben@decadent.org.uk>
> Date: Sun, 28 Nov 2010 01:53:35 +0000
>
> > On Sat, 2010-11-27 at 17:26 -0800, David Miller wrote:
> >> From: Greg KH <gregkh@suse.de>
> >> Date: Sat, 27 Nov 2010 16:21:35 -0800
> >>
> >> > And I need an ack from the networking maintainer to be able to accept
> >> > this also.
> >>
> >> I'm not applying this, nor do I want anyone else to.
> >>
> >> If people think this protocol is not maintained adequately
> >> right now, wait until you push it into staging.
> >>
> >> Furthermore, once Phil Blundell was made aware of security
> >> holes in econet he fixed them within a few days. Which is
> >> much better than I can say for some of the other protocols
> >> and filesystems in the tree.
> >
> > Those bugs were present for years and would have been obvious to anyone
> > who cared to read the code. While I very much appreciate Phil's quick
> > response, I don't think this reactive maintenance is enough.
>
> These same arguments could for be made for RDS. Look at all the
> hellacious awful obvious crap we've discovered in that code recently.
> A simple read would have caught those too, and I don't see it's
> maintainer doing such things.
Indeed, hence the change I made for the upcoming Debian release was:
* af_802154,decnet,econet,rds,x25: Disable auto-loading as mitigation
against local exploits. These protocol modules are not widely used
and can be explicitly loaded or aliased on systems where they are
wanted.
(While decnet may be in better shape than the others, auto-loading is
unnecessary for us as the userland support package explicitly loads
it..)
> So, you're very much still not convincing Ben, but feel free to keep
> trying.
I'm not going to try any more.
Ben.
--
Ben Hutchings
Once a job is fouled up, anything done to improve it makes it worse.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
^ permalink raw reply
* [PATCH net-next-2.6] xps: NUMA allocations for per cpu data
From: Eric Dumazet @ 2010-11-28 15:43 UTC (permalink / raw)
To: David Miller; +Cc: netdev, Tom Herbert
In-Reply-To: <1290791866.2855.263.camel@edumazet-laptop>
store_xps_map() allocates maps that are used by single cpu, it makes
sense to use NUMA allocations.
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Tom Herbert <therbert@google.com>
---
net/core/net-sysfs.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c
index 68dbbfd..35f28b1 100644
--- a/net/core/net-sysfs.c
+++ b/net/core/net-sysfs.c
@@ -950,8 +950,9 @@ static ssize_t store_xps_map(struct netdev_queue *queue,
if (map_len >= alloc_len) {
alloc_len = alloc_len ?
2 * alloc_len : XPS_MIN_MAP_ALLOC;
- new_map = kzalloc(XPS_MAP_SIZE(alloc_len),
- GFP_KERNEL);
+ new_map = kzalloc_node(XPS_MAP_SIZE(alloc_len),
+ GFP_KERNEL,
+ cpu_to_node(cpu));
if (!new_map)
goto error;
new_map->alloc_len = alloc_len;
^ permalink raw reply related
* Re: [PATCH] ks8842: Fix TX cache flush issue
From: David Miller @ 2010-11-28 18:38 UTC (permalink / raw)
To: richard.rojfors; +Cc: netdev, ferringb
In-Reply-To: <1290430257.13971.7.camel@debian>
From: Richard Röjfors <richard.rojfors@pelagicore.com>
Date: Mon, 22 Nov 2010 13:50:57 +0100
> This patch fixes a cache sync issue found in MeeGo 1.1.
>
> It was found that bytes after the first 64 of the TX buffer was not
> flushed from the cache correctly.
>
> The patch switches out kmalloc/dma_map_single/dma_sync_single_for_device
> to dma_alloc_coherent.
>
> Signed-off-by: Richard Röjfors <richard.rojfors@pelagicore.com>
Why is dma_sync_single_*() not working properly?
Maybe the length arguments are not correct? Maybe the cache flush
implementation accidently misses the last cache line when the buffer
length ends in the middle of a cache line.
Did you even check to see what the actual cause of the problem is?
I'm not applying this patch, not enough justification or explanation
in the commit message exists yet. For all we know there could be
a bug elsewhere, and that would effect other drivers too not just
ks8842.
^ permalink raw reply
* Re: [PATCH v2] tcp: restrict net.ipv4.tcp_adv_win_scale (#20312)
From: David Miller @ 2010-11-28 18:39 UTC (permalink / raw)
To: adobriyan; +Cc: eric.dumazet, shemminger, netdev, bhutchings
In-Reply-To: <20101122225421.GA7372@core2.telecom.by>
From: Alexey Dobriyan <adobriyan@gmail.com>
Date: Tue, 23 Nov 2010 00:54:21 +0200
> tcp_win_from_space() does the following:
>
> if (sysctl_tcp_adv_win_scale <= 0)
> return space >> (-sysctl_tcp_adv_win_scale);
> else
> return space - (space >> sysctl_tcp_adv_win_scale);
>
> "space" is int.
>
> As per C99 6.5.7 (3) shifting int for 32 or more bits is
> undefined behaviour.
>
> Indeed, if sysctl_tcp_adv_win_scale is exactly 32,
> space >> 32 equals space and function returns 0.
>
> Which means we busyloop in tcp_fixup_rcvbuf().
>
> Restrict net.ipv4.tcp_adv_win_scale to [-31, 31].
>
> Fix https://bugzilla.kernel.org/show_bug.cgi?id=20312
>
> Steps to reproduce:
>
> echo 32 >/proc/sys/net/ipv4/tcp_adv_win_scale
> wget www.kernel.org
> [softlockup]
>
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
I'll aply this, thanks Alexey.
^ permalink raw reply
* Re: [PATCH net-next] sctp: kill unused macro definition
From: David Miller @ 2010-11-28 18:47 UTC (permalink / raw)
To: shanwei; +Cc: vladislav.yasevich, linux-sctp, netdev
In-Reply-To: <4CEB82BA.6030406@cn.fujitsu.com>
From: Shan Wei <shanwei@cn.fujitsu.com>
Date: Tue, 23 Nov 2010 17:00:42 +0800
>
> These macros have been existed for several years since v2.6.12-rc2.
> But they never be used. So remove them now.
>
> Signed-off-by: Shan Wei <shanwei@cn.fujitsu.com>
Applied.
^ permalink raw reply
* Re: [PATCH NEXT] qlcnic: avoid using reset_devices as it may become obsolete.
From: David Miller @ 2010-11-28 18:48 UTC (permalink / raw)
To: amit.salecha; +Cc: netdev, ameen.rahman, anirban.chakraborty, rajesh.borundia
In-Reply-To: <1290511521-5773-1-git-send-email-amit.salecha@qlogic.com>
From: Amit Kumar Salecha <amit.salecha@qlogic.com>
Date: Tue, 23 Nov 2010 03:25:21 -0800
> From: Rajesh Borundia <rajesh.borundia@qlogic.com>
>
> In kdump environment do not depend upon reset_devices parameter
> to reset the pci function as this parameter may become obsolete.
> Instead use an adapter specific mechanism to determine if the pci
> function needs to be reset.
>
> Per function refcount is maintained in driver, which is set in probe
> and reset in remove handler of adapter. If the probe detects the count
> as non zero then reset the function.
>
> Signed-off-by: Rajesh Borundia <rajesh.borundia@qlogic.com>
> Signed-off-by: Amit Kumar Salecha <amit.salecha@qlogic.com>
Applied.
^ permalink raw reply
* Re: [PATCH] netxen: avoid using reset_devices as it may become obsolete
From: David Miller @ 2010-11-28 18:48 UTC (permalink / raw)
To: amit.salecha; +Cc: netdev, ameen.rahman, anirban.chakraborty, rajesh.borundia
In-Reply-To: <1290517707-8554-1-git-send-email-amit.salecha@qlogic.com>
From: Amit Kumar Salecha <amit.salecha@qlogic.com>
Date: Tue, 23 Nov 2010 05:08:27 -0800
> From: Rajesh Borundia <rajesh.borundia@qlogic.com>
>
> In kdump environment do not depend on reset_devices
> parameter to reset the device as the parameter may become obsolete.
> Instead use an adapter specific mechanism to determine if the device
> needs a reset.
>
> Driver maintains a count of number of pci functions probed
> and decrements the count when remove handler of that pci function
> is called. If the first probe, probe of function 0,
> detects the count as non zero then reset the device.
>
> Signed-off-by: Rajesh Borundia <rajesh.borundia@qlogic.com>
> Signed-off-by: Amit Kumar Salecha <amit.salecha@qlogic.com>
Applied.
^ permalink raw reply
* Re: [net-next-2.6 PATCH] 8021q: vlan device is lockless do not transfer real_num_{tx|rx}_queues
From: David Miller @ 2010-11-28 18:48 UTC (permalink / raw)
To: john.r.fastabend; +Cc: netdev, eric.dumazet
In-Reply-To: <20101124231450.3158.67194.stgit@jf-dev1-dcblab>
From: John Fastabend <john.r.fastabend@intel.com>
Date: Wed, 24 Nov 2010 15:14:50 -0800
> Now that the vlan device is lockless and single queue do not
> transfer the real num queues. This is causing a BUG_ON to occur.
>
> kernel BUG at net/8021q/vlan.c:345!
> Call Trace:
> [<ffffffff813fd6e8>] ? fib_rules_event+0x28/0x1b0
> [<ffffffff814ad2b5>] notifier_call_chain+0x55/0x80
> [<ffffffff81089156>] raw_notifier_call_chain+0x16/0x20
> [<ffffffff813e5af7>] call_netdevice_notifiers+0x37/0x70
> [<ffffffff813e6756>] netdev_features_change+0x16/0x20
> [<ffffffffa02995be>] ixgbe_fcoe_enable+0xae/0x100 [ixgbe]
> [<ffffffffa01da06a>] vlan_dev_fcoe_enable+0x2a/0x30 [8021q]
> [<ffffffffa02d08c3>] fcoe_create+0x163/0x630 [fcoe]
> [<ffffffff811244d5>] ? mmap_region+0x255/0x5a0
> [<ffffffff81080ef0>] param_attr_store+0x50/0x80
> [<ffffffff810809b6>] module_attr_store+0x26/0x30
> [<ffffffff811b9db2>] sysfs_write_file+0xf2/0x180
> [<ffffffff8114fc88>] vfs_write+0xc8/0x190
> [<ffffffff81150621>] sys_write+0x51/0x90
> [<ffffffff8100c0b2>] system_call_fastpath+0x16/0x1b
>
> Signed-off-by: John Fastabend <john.r.fastabend@intel.com>
Applied.
^ permalink raw reply
* Re: [PATCH 3/6] net: add some KERN_CONT markers to continuation lines
From: David Miller @ 2010-11-28 18:48 UTC (permalink / raw)
To: u.kleine-koenig; +Cc: linux-kernel, linux, kernel, arjan, torvalds, netdev
In-Reply-To: <1290589070-854-3-git-send-email-u.kleine-koenig@pengutronix.de>
From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Date: Wed, 24 Nov 2010 09:57:47 +0100
> Cc: netdev@vger.kernel.org
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Applied.
^ permalink raw reply
* Re: [PATCH]ipv6: kill two unused macro definition
From: David Miller @ 2010-11-28 18:49 UTC (permalink / raw)
To: shanwei; +Cc: netdev, adobriyan
In-Reply-To: <4CEE14AC.7090008@cn.fujitsu.com>
From: Shan Wei <shanwei@cn.fujitsu.com>
Date: Thu, 25 Nov 2010 15:47:56 +0800
> 1. IPV6_TLV_TEL_DST_SIZE
> This has not been using for several years since created.
>
> 2. RT6_INFO_LEN
> commit 33120b30 kill all RT6_INFO_LEN's references, but only this definition remained.
>
> commit 33120b30cc3b8665204d4fcde7288638b0dd04d5
> Author: Alexey Dobriyan <adobriyan@sw.ru>
> Date: Tue Nov 6 05:27:11 2007 -0800
>
> [IPV6]: Convert /proc/net/ipv6_route to seq_file interface
>
>
> Signed-off-by: Shan Wei <shanwei@cn.fujitsu.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next-2.6] net: add netif_tx_queue_frozen_or_stopped
From: David Miller @ 2010-11-28 18:49 UTC (permalink / raw)
To: eric.dumazet; +Cc: netdev
In-Reply-To: <1290544922.2866.11.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 23 Nov 2010 21:42:02 +0100
> When testing struct netdev_queue state against FROZEN bit, we also test
> XOFF bit. We can test both bits at once and save some cycles.
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next 1/2] bnx2: Fix reset bug on 5709
From: David Miller @ 2010-11-28 18:49 UTC (permalink / raw)
To: mchan; +Cc: netdev
In-Reply-To: <1290642535-20293-1-git-send-email-mchan@broadcom.com>
From: "Michael Chan" <mchan@broadcom.com>
Date: Wed, 24 Nov 2010 15:48:54 -0800
> From: Eddie Wai <waie@broadcom.com>
>
> The 5709 chip requires the BNX2_MISC_NEW_CORE_CTL_DMA_ENABLE bit to be
> cleared and polling for pending DMAs to complete before chip reset.
> Without this step, we've seen NMIs during repeated resets of the chip.
>
> Signed-off-by: Eddie Wai <waie@broadcom.com>
> Signed-off-by: Michael Chan <mchan@broadcom.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next 2/2] bnx2: Remove config access to non-standard registers
From: David Miller @ 2010-11-28 18:49 UTC (permalink / raw)
To: mchan; +Cc: netdev
In-Reply-To: <1290642535-20293-2-git-send-email-mchan@broadcom.com>
From: "Michael Chan" <mchan@broadcom.com>
Date: Wed, 24 Nov 2010 15:48:55 -0800
> In KVM passthrough mode, the driver may not have config access to
> non-standard registers. The BNX2_PCICFG_MISC_CONFIG config register
> access to setup mailbox swapping can be done using MMIO.
>
> Update version to 2.0.20.
>
> Signed-off-by: Michael Chan <mchan@broadcom.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next] bnx2x: Use helpers instead of direct access to the shinfo(skb) fields
From: David Miller @ 2010-11-28 19:08 UTC (permalink / raw)
To: vladz; +Cc: eilong, netdev
In-Reply-To: <1290939815.21703.81.camel@lb-tlvb-vladz>
From: "Vladislav Zolotarov" <vladz@broadcom.com>
Date: Sun, 28 Nov 2010 12:23:35 +0200
> Signed-off-by: Vladislav Zolotarov <vladz@broadcom.com>
> Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
Applied, thanks.
^ permalink raw reply
* Re: [Pv-drivers] [PATCH] vmxnet3: fix compilation when RSS is disabled
From: Bhavesh Davda @ 2010-11-28 19:09 UTC (permalink / raw)
To: Scott Goldman
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-next@vger.kernel.org, pv-drivers@vmware.com,
randy.dunlap@oracle.com
In-Reply-To: <1290890035-32285-2-git-send-email-scottjg@vmware.com>
Straightforward enough. Thanks for fixing this Scott!
On Nov 27, 2010, at 12:35 PM, "Scott J. Goldman" <scottjg@vmware.com> wrote:
> If RSS is disabled, we can ifdef out some RSS specific code. This fixes
> the compile error found by Randy Dunlap.
>
> Signed-off-by: Scott J. Goldman <scottjg@vmware.com>
Reviewed-by: Bhavesh Davda <bhavesh@vmware.com>
> ---
> drivers/net/vmxnet3/vmxnet3_ethtool.c | 5 ++++-
> 1 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/vmxnet3/vmxnet3_ethtool.c b/drivers/net/vmxnet3/vmxnet3_ethtool.c
> index 9ddaea6..8e17fc8 100644
> --- a/drivers/net/vmxnet3/vmxnet3_ethtool.c
> +++ b/drivers/net/vmxnet3/vmxnet3_ethtool.c
> @@ -553,7 +553,7 @@ vmxnet3_get_rxnfc(struct net_device *netdev, struct ethtool_rxnfc *info,
> return -EOPNOTSUPP;
> }
>
> -
> +#ifdef VMXNET3_RSS
> static int
> vmxnet3_get_rss_indir(struct net_device *netdev,
> struct ethtool_rxfh_indir *p)
> @@ -598,6 +598,7 @@ vmxnet3_set_rss_indir(struct net_device *netdev,
> return 0;
>
> }
> +#endif
>
> static struct ethtool_ops vmxnet3_ethtool_ops = {
> .get_settings = vmxnet3_get_settings,
> @@ -623,8 +624,10 @@ static struct ethtool_ops vmxnet3_ethtool_ops = {
> .get_ringparam = vmxnet3_get_ringparam,
> .set_ringparam = vmxnet3_set_ringparam,
> .get_rxnfc = vmxnet3_get_rxnfc,
> +#ifdef VMXNET3_RSS
> .get_rxfh_indir = vmxnet3_get_rss_indir,
> .set_rxfh_indir = vmxnet3_set_rss_indir,
> +#endif
> };
>
> void vmxnet3_set_ethtool_ops(struct net_device *netdev)
> --
> 1.7.0.4
>
> _______________________________________________
> Pv-drivers mailing list
> Pv-drivers@vmware.com
> http://mailman2.vmware.com/mailman/listinfo/pv-drivers
^ permalink raw reply
* Re: [PATCH net-next 1/5] X25 remove bkl in subscription ioctls
From: David Miller @ 2010-11-28 19:12 UTC (permalink / raw)
To: andrew.hendry; +Cc: netdev
In-Reply-To: <1290687495.5053.35.camel@jaunty>
From: Andrew Hendry <andrew.hendry@gmail.com>
Date: Thu, 25 Nov 2010 23:18:15 +1100
>
> Signed-off-by: Andrew Hendry <andrew.hendry@gmail.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next 2/5] X25 remove bkl in facility ioctls
From: David Miller @ 2010-11-28 19:13 UTC (permalink / raw)
To: andrew.hendry; +Cc: netdev
In-Reply-To: <1290687515.5053.40.camel@jaunty>
From: Andrew Hendry <andrew.hendry@gmail.com>
Date: Thu, 25 Nov 2010 23:18:35 +1100
>
> Signed-off-by: Andrew Hendry <andrew.hendry@gmail.com>
Applied.
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox