* Re: [net-next 2/8] bnx2x: add select queue callback
From: David Miller @ 2010-12-10 22:11 UTC (permalink / raw)
To: dmitry; +Cc: netdev, eilong
In-Reply-To: <1291896556.8745.7.camel@lb-tlvb-dmitry>
From: "Dmitry Kravkov" <dmitry@broadcom.com>
Date: Thu, 9 Dec 2010 14:09:16 +0200
> +#endif
> + /* Select queue (if defined) adjust for fcoe */
> + fp_index = skb_tx_hash(dev, skb) - FCOE_CONTEXT_USE;
> +
> + return (fp_index >= 0 ? fp_index : 0);
This doesn't make any sense, and it's one of the reasons I really
hate the fact that drivers sometimes need to override the
select_queue method.
Because 9 times out of 10 they get it wrong.
You're mapping queues 0 --> FCOE_CONTEXT_USE to zero.
But that's not what you actually want.
You're actually trying to make non-FCOE traffic hash only amongst the
non-FCOE queues.
So make your code actually do that instead of screwing up the
distribution of the hash result.
^ permalink raw reply
* Re: [patch 0/4] s390: qeth patches for net-next
From: David Miller @ 2010-12-10 22:29 UTC (permalink / raw)
To: frank.blaschka; +Cc: netdev, linux-s390
In-Reply-To: <20101208125757.726629855@de.ibm.com>
From: frank.blaschka@de.ibm.com
Date: Wed, 08 Dec 2010 13:57:57 +0100
> here is another patch set for net-next.
All applied, thank you.
^ permalink raw reply
* Re: [PATCH 3/3 v2] ifb: use the lockless variants of skb_queue
From: David Miller @ 2010-12-10 22:35 UTC (permalink / raw)
To: hadi; +Cc: xiaosuo, netdev, jarkao2
In-Reply-To: <1291559180.2159.683.camel@mojatatu>
From: jamal <hadi@cyberus.ca>
Date: Sun, 05 Dec 2010 09:26:20 -0500
> On Sun, 2010-12-05 at 09:01 +0800, Changli Gao wrote:
>> rq and tq are both protected by tx queue lock, so we can simply use
>> the lockless variants of skb_queue.
>>
>> skb_queue_splice_tail_init() is used instead of the open coded and slow
>> one.
>>
>> Signed-off-by: Changli Gao <xiaosuo@gmail.com>
>
> Signed-off-by: Jamal Hadi Salim <hadi@cyberus.ca>
I've applied the most up to date versions of all 3 of
Changli's IFB patches, thanks!
^ permalink raw reply
* Re: [PATCH 0/3] xfrm: ESP Traffic Flow Confidentiality padding (v3)
From: David Miller @ 2010-12-10 22:44 UTC (permalink / raw)
To: herbert; +Cc: martin, linux-crypto, netdev
In-Reply-To: <20101209124732.GA28931@gondor.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Thu, 9 Dec 2010 20:47:32 +0800
> On Wed, Dec 08, 2010 at 03:37:48PM +0100, Martin Willi wrote:
>> The following patchset adds Traffic Flow Confidentiality padding. The
>> first patch introduces a new Netlink XFRM attribute to configure TFC via
>> userspace. Patch two and three implement the padding logic in IPv4 and
>> IPv6 ESP. Padding is always done using the RFC4303 format an is clamped
>> to the PMTU.
>>
>> Changes from v2:
>> - Remove unused flag field in attribute, use a plain u32 as attribute payload
>> - Reject installation of TFC padding on non-tunnel SAs
>
> Looks good to me. Thanks for the hard work Martin!
>
> Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
All applied, thanks everyone!
^ permalink raw reply
* Re: [PATCH v2] bridge: Fix return values of br_multicast_add_group/br_multicast_new_group
From: Tobias Klauser @ 2010-12-10 22:52 UTC (permalink / raw)
To: David Miller; +Cc: shemminger, bridge, netdev
In-Reply-To: <20101210.130125.233714141.davem@davemloft.net>
On 2010-12-10 at 22:01:25 +0100, David Miller <davem@davemloft.net> wrote:
> From: Tobias Klauser <tklauser@distanz.ch>
> Date: Fri, 10 Dec 2010 14:18:04 +0100
>
> > If br_multicast_new_group returns NULL, we would return 0 (no error) to
> > the caller of br_multicast_add_group, which is not what we want. Instead
> > br_multicast_new_group should return ERR_PTR(-ENOMEM) in this case.
> > Also propagate the error number returned by br_mdb_rehash properly.
> >
> > Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
>
> Looks good, applied to net-next-2.6
>
> Please in the future make is clear, in your subject line, which
> tree this patch is meant for.
>
> I had to figure it out by trial and error, because this patch
> does not apply properly to net-2.6
Sorry about that. I'll do so in the future.
Thanks
^ permalink raw reply
* Re: [PATCH] inet6: Remove redundant unlikely()
From: David Miller @ 2010-12-10 22:57 UTC (permalink / raw)
To: tklauser
Cc: kuznet, pekkas, jmorris, yoshfuji, kaber, netdev, kernel-janitors
In-Reply-To: <1291905468-32174-1-git-send-email-tklauser@distanz.ch>
From: Tobias Klauser <tklauser@distanz.ch>
Date: Thu, 9 Dec 2010 15:37:48 +0100
> IS_ERR() already implies unlikely(), so it can be omitted here.
>
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Applied.
^ permalink raw reply
* Re: [PATCH] stmmac: Remove redundant unlikely()
From: David Miller @ 2010-12-10 22:57 UTC (permalink / raw)
To: tklauser; +Cc: peppe.cavallaro, netdev, kernel-janitors
In-Reply-To: <1291906222-575-1-git-send-email-tklauser@distanz.ch>
From: Tobias Klauser <tklauser@distanz.ch>
Date: Thu, 9 Dec 2010 15:50:22 +0100
> IS_ERR() already implies unlikely(), so it can be omitted here.
>
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Applied.
^ permalink raw reply
* Re: [PATCH] ipv6: slightly simplify keeping IPv6 addresses on link down
From: Lorenzo Colitti @ 2010-12-10 23:00 UTC (permalink / raw)
To: David Miller; +Cc: shemminger, netdev
In-Reply-To: <20101210.124339.242120993.davem@davemloft.net>
On Fri, Dec 10, 2010 at 12:43 PM, David Miller <davem@davemloft.net> wrote:
> Lorenzo you've already added serious bugs to this code with your
> previous address handling changes (which had reference counting bugs),
> so I'm going to heavily scrutinize any "cleanup" or other kind of
> change you try to make here.
By all means. Apologies for introducing the bug. Needless to say, I'll
let this one lie.
> In fact I really wish you would just leave this code as-is instead
> of trying to make such pointless tweaks to it.
My intention was to make the code a little more readable, and I did
test this by running it, but yes, a bug is a bug. As you can probably
tell, my expertise is in networking, not in writing kernel code. But I
do think that this code does the wrong thing in some areas, so I
wanted to try to fix it. In particular, keeping invalid autoconfig
addresses and routes configured on interfaces is guaranteed to break
connectivity.
I have two other patches that I think will improve the behaviour of
the stack from a networking perspective. One of them makes the kernel
properly update the lifetime of temporary addresses (this changed
between RFC 3041 and RFC 4941). The other deprecates addresses when
link goes down, which will do pretty much the same as my original
patch to delete the addresses, but will not cause the loss of any
privacy addresses configured.
My plan was to let these soak on my laptop (which I have been doing
for a few weeks), show them to colleagues who write kernel code (which
I have done), and submit them to this list. Is there anything else I
should be doing?
Thanks,
Lorenzo
^ permalink raw reply
* Re: [net-2.6 PATCH] enic: Bug Fix: Pass napi reference to the isr that services receive queue
From: David Miller @ 2010-12-10 23:01 UTC (permalink / raw)
To: vkolluri; +Cc: netdev, roprabhu, dwang2
In-Reply-To: <20101208230545.24082.48614.stgit@savbu-pc100.cisco.com>
From: Vasanthy Kolluri <vkolluri@cisco.com>
Date: Wed, 08 Dec 2010 15:05:45 -0800
> From: Vasanthy Kolluri <vkolluri@cisco.com>
>
> Pass reference to napi instead of enic device to the isr that services receive queue.
>
> Signed-off-by: Vasanthy Kolluri <vkolluri@cisco.com>
> Signed-off-by: Roopa Prabhu <roprabhu@cisco.com>
> Signed-off-by: David Wang <dwang2@cisco.com>
Applied, thank you.
^ permalink raw reply
* Re: [PATCH] SCTP: Fix SCTP_SET_PEER_PRIMARY_ADDR to accpet v4mapped address
From: David Miller @ 2010-12-10 23:01 UTC (permalink / raw)
To: yjwei; +Cc: vladislav.yasevich, linux-sctp, netdev
In-Reply-To: <4CFEF74D.7020704@cn.fujitsu.com>
From: Wei Yongjun <yjwei@cn.fujitsu.com>
Date: Wed, 08 Dec 2010 11:11:09 +0800
> SCTP_SET_PEER_PRIMARY_ADDR does not accpet v4mapped address, using
> v4mapped address in SCTP_SET_PEER_PRIMARY_ADDR socket option will
> get -EADDRNOTAVAIL error if v4map is enabled. This patch try to
> fix it by mapping v4mapped address to v4 address if allowed.
>
> Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
Vlad and other SCTP folks, please review this patch.
^ permalink raw reply
* Re: Misuse of LRO, how widespread
From: David Miller @ 2010-12-10 23:03 UTC (permalink / raw)
To: bhutchings; +Cc: shemminger, olof, divy, netdev
In-Reply-To: <1291674912.5405.24.camel@bwh-desktop>
From: Ben Hutchings <bhutchings@solarflare.com>
Date: Mon, 06 Dec 2010 22:35:12 +0000
> On Mon, 2010-12-06 at 14:33 -0800, Stephen Hemminger wrote:
>> How about this?
>>
>> Subject: sfc: convert references to LRO to GRO
>>
>> This driver now uses Generic Receive Offload, not the older LRO.
>> Change references to LRO in names and comments.
>>
>> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
> Acked-by: Ben Hutchings <bhutchings@solarflare.com>
Applied to net-next-2.6, thanks!
^ permalink raw reply
* Re: [PATCH] SCTP: Fix SCTP_SET_PEER_PRIMARY_ADDR to accpet v4mapped address
From: Vladislav Yasevich @ 2010-12-10 23:13 UTC (permalink / raw)
To: Wei Yongjun; +Cc: David Miller, linux-sctp, netdev@vger.kernel.org
In-Reply-To: <4CFEF74D.7020704@cn.fujitsu.com>
On 12/07/2010 10:11 PM, Wei Yongjun wrote:
> SCTP_SET_PEER_PRIMARY_ADDR does not accpet v4mapped address, using
> v4mapped address in SCTP_SET_PEER_PRIMARY_ADDR socket option will
> get -EADDRNOTAVAIL error if v4map is enabled. This patch try to
> fix it by mapping v4mapped address to v4 address if allowed.
>
> Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
Looks good.
Acked-by: Vlad Yasevich <vladislav.yasevich@hp.com>
-vlad
> ---
> net/sctp/socket.c | 8 ++++++++
> 1 files changed, 8 insertions(+), 0 deletions(-)
>
> diff --git a/net/sctp/socket.c b/net/sctp/socket.c
> index 6bd5543..0b9ee34 100644
> --- a/net/sctp/socket.c
> +++ b/net/sctp/socket.c
> @@ -2932,6 +2932,7 @@ static int sctp_setsockopt_peer_primary_addr(struct sock *sk, char __user *optva
> struct sctp_association *asoc = NULL;
> struct sctp_setpeerprim prim;
> struct sctp_chunk *chunk;
> + struct sctp_af *af;
> int err;
>
> sp = sctp_sk(sk);
> @@ -2959,6 +2960,13 @@ static int sctp_setsockopt_peer_primary_addr(struct sock *sk, char __user *optva
> if (!sctp_state(asoc, ESTABLISHED))
> return -ENOTCONN;
>
> + af = sctp_get_af_specific(prim.sspp_addr.ss_family);
> + if (!af)
> + return -EINVAL;
> +
> + if (!af->addr_valid((union sctp_addr *)&prim.sspp_addr, sp, NULL))
> + return -EADDRNOTAVAIL;
> +
> if (!sctp_assoc_lookup_laddr(asoc, (union sctp_addr *)&prim.sspp_addr))
> return -EADDRNOTAVAIL;
>
>
>
^ permalink raw reply
* Re: [PATCH] SCTP: Fix SCTP_SET_PEER_PRIMARY_ADDR to accpet v4mapped address
From: David Miller @ 2010-12-10 23:29 UTC (permalink / raw)
To: vladislav.yasevich; +Cc: yjwei, linux-sctp, netdev
In-Reply-To: <4D02B436.5000605@hp.com>
From: Vladislav Yasevich <vladislav.yasevich@hp.com>
Date: Fri, 10 Dec 2010 18:13:58 -0500
> On 12/07/2010 10:11 PM, Wei Yongjun wrote:
>> SCTP_SET_PEER_PRIMARY_ADDR does not accpet v4mapped address, using
>> v4mapped address in SCTP_SET_PEER_PRIMARY_ADDR socket option will
>> get -EADDRNOTAVAIL error if v4map is enabled. This patch try to
>> fix it by mapping v4mapped address to v4 address if allowed.
>>
>> Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
>
> Looks good.
>
> Acked-by: Vlad Yasevich <vladislav.yasevich@hp.com>
Applied, thanks everyone.
^ permalink raw reply
* Re: [PATCH net-next-2.6] pktgen: adding prefetchw() call
From: David Miller @ 2010-12-10 23:37 UTC (permalink / raw)
To: junchangwang
Cc: eric.dumazet, robert.olsson, john.r.fastabend, andy.shevchenko,
netdev, wangjc
In-Reply-To: <20101209025511.GC5379@Desktop-Junchang>
From: Junchang Wang <junchangwang@gmail.com>
Date: Thu, 9 Dec 2010 10:55:16 +0800
> We know for sure pktgen is going to write skb->data right after
> *_alloc_skb, causing unnecessary cache misses.
>
> Idea is to add a prefetchw() call to prefetch the first cache line
> indicated by skb->data. On systems with Adjacent Cache Line Prefetch,
> it's probably two cache lines are prefetched.
>
> With this patch, pktgen on Intel SR1625 server with two E5530
> quad-core processors and a single ixgbe-based NIC went from 8.63Mpps
> to 9.03Mpps, with 4.6% improvement.
>
> Signed-off-by: Junchang Wang <junchangwang@gmail.com>
> Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied, thanks.
^ permalink raw reply
* Re: [net-next-2.6 PATCH] enic: Add ndo_set_rx_mode support for enic vnics
From: David Miller @ 2010-12-10 23:39 UTC (permalink / raw)
To: roprabhu; +Cc: netdev
In-Reply-To: <20101208231958.24293.72420.stgit@savbu-pc100.cisco.com>
From: Roopa Prabhu <roprabhu@cisco.com>
Date: Wed, 08 Dec 2010 15:19:58 -0800
> From: Roopa Prabhu <roprabhu@cisco.com>
>
> Add ndo_set_rx_mode support to register unicast and multicast
> address filters for enic devices
>
> Signed-off-by: Roopa Prabhu <roprabhu@cisco.com>
> Signed-off-by: Vasanthy Kolluri <vkolluri@cisco.com>
> Signed-off-by: David Wang <dwang2@cisco.com>
> Signed-off-by: Christian Benvenuti <benve@cisco.com>
Applied.
^ permalink raw reply
* Re: [net-next-2.6 PATCH 0/2] enic: updates to version 1.4.1.9
From: David Miller @ 2010-12-10 23:42 UTC (permalink / raw)
To: roprabhu; +Cc: netdev
In-Reply-To: <20101208235340.24874.50597.stgit@savbu-pc100.cisco.com>
From: Roopa Prabhu <roprabhu@cisco.com>
Date: Wed, 08 Dec 2010 15:53:52 -0800
> This patch series implements the following enic driver updates:
>
> 01/2 - Add ndo_set_vf_mac support for enic dynamic devices
> 02/2 - Use VF mac set by IFLA_VF_MAC in port profile provisioning data
Both applied, thanks.
^ permalink raw reply
* Re: [PATCH] MAINTAINERS: remove me from tulip
From: David Miller @ 2010-12-10 23:43 UTC (permalink / raw)
To: grundler; +Cc: kyle, netdev
In-Reply-To: <20101209213340.GB26182@lackof.org>
From: Grant Grundler <grundler@parisc-linux.org>
Date: Thu, 9 Dec 2010 14:33:40 -0700
> On Thu, Dec 09, 2010 at 02:50:08PM -0500, Kyle McMartin wrote:
>> It was a nice idea, but -ENOTIME and -ENOHW. I never got around to doing
>> a lot of the clean up that I intended to.
>>
>> Signed-off-by: Kyle McMartin <kyle@mcmartin.ca>
>
> Yeah, I can understand. I basically just review incoming patches and
> haven't done any work on the outstanding bugs over the past year or so.
>
> Acked-by: Grant Grundler <grundler@parisc-linux.org>
>
> Dave, please apply.
Applied, thanks.
^ permalink raw reply
* Re: [PATCH v2] atm: correct sysfs 'device' link creation and parent relationships
From: David Miller @ 2010-12-10 23:45 UTC (permalink / raw)
To: dcbw; +Cc: kay.sievers, netdev, duncan.sands, linux-usb, chas
In-Reply-To: <1291873251.24551.4.camel@dcbw.foobar.com>
From: Dan Williams <dcbw@redhat.com>
Date: Wed, 08 Dec 2010 23:40:47 -0600
> The ATM subsystem was incorrectly creating the 'device' link for ATM
> nodes in sysfs. This led to incorrect device/parent relationships
> exposed by sysfs and udev. Instead of rolling the 'device' link by hand
> in the generic ATM code, pass each ATM driver's bus device down to the
> sysfs code and let sysfs do this stuff correctly.
>
> Signed-off-by: Dan Williams <dcbw@redhat.com>
Applied and being compile tested :-)
Thanks!
^ permalink raw reply
* Re: [PATCH] phy: add the IC+ IP1001 driver
From: David Miller @ 2010-12-10 23:47 UTC (permalink / raw)
To: peppe.cavallaro; +Cc: netdev
In-Reply-To: <1291885513-32766-1-git-send-email-peppe.cavallaro@st.com>
From: Peppe CAVALLARO <peppe.cavallaro@st.com>
Date: Thu, 9 Dec 2010 10:05:13 +0100
> This patch adds the IC+ IP1001 (Gigabit Ethernet Transceiver) driver.
> I've had to add an additional delay (2ns) to adjust RX clock phase at
> GMII/ RGMII interface (according to the PHY data-sheet). This helps to
> have the RGMII working on some ST platforms.
>
> Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@st.com>
You forgot to update the icplus_tbl module device table with a
new 0x02430d90 entry.
Please fix this and resubmit.
^ permalink raw reply
* Re: [PATCH] phy: add the IC+ IP1001 driver
From: David Miller @ 2010-12-10 23:48 UTC (permalink / raw)
To: peppe.cavallaro; +Cc: netdev
In-Reply-To: <20101210.154741.173841125.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Fri, 10 Dec 2010 15:47:41 -0800 (PST)
> From: Peppe CAVALLARO <peppe.cavallaro@st.com>
> Date: Thu, 9 Dec 2010 10:05:13 +0100
>
>> This patch adds the IC+ IP1001 (Gigabit Ethernet Transceiver) driver.
>> I've had to add an additional delay (2ns) to adjust RX clock phase at
>> GMII/ RGMII interface (according to the PHY data-sheet). This helps to
>> have the RGMII working on some ST platforms.
>>
>> Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@st.com>
>
> You forgot to update the icplus_tbl module device table with a
> new 0x02430d90 entry.
Ignore this, I can't read! :-)
I'll apply this, thanks a lot.
^ permalink raw reply
* Re: [PATCH] phy: add the IC+ IP1001 driver
From: Andy Fleming @ 2010-12-10 23:48 UTC (permalink / raw)
To: Peppe CAVALLARO; +Cc: netdev@vger.kernel.org
In-Reply-To: <1291885513-32766-1-git-send-email-peppe.cavallaro@st.com>
On Thu, Dec 9, 2010 at 3:05 AM, Peppe CAVALLARO <peppe.cavallaro@st.com> wrote:
> This patch adds the IC+ IP1001 (Gigabit Ethernet Transceiver) driver.
> I've had to add an additional delay (2ns) to adjust RX clock phase at
> GMII/ RGMII interface (according to the PHY data-sheet). This helps to
> have the RGMII working on some ST platforms.
>
> Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@st.com>
> ---
> drivers/net/phy/Kconfig | 2 +-
> drivers/net/phy/icplus.c | 59 ++++++++++++++++++++++++++++++++++++++++++----
> 2 files changed, 55 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig
> index cb3d13e..35fda5a 100644
> --- a/drivers/net/phy/Kconfig
> +++ b/drivers/net/phy/Kconfig
> @@ -64,7 +64,7 @@ config BCM63XX_PHY
> config ICPLUS_PHY
> tristate "Drivers for ICPlus PHYs"
> ---help---
> - Currently supports the IP175C PHY.
> + Currently supports the IP175C and IP1001 PHYs.
>
> config REALTEK_PHY
> tristate "Drivers for Realtek PHYs"
> diff --git a/drivers/net/phy/icplus.c b/drivers/net/phy/icplus.c
> index c1d2d25..9a09e24 100644
> --- a/drivers/net/phy/icplus.c
> +++ b/drivers/net/phy/icplus.c
> @@ -30,7 +30,7 @@
> #include <asm/irq.h>
> #include <asm/uaccess.h>
>
> -MODULE_DESCRIPTION("ICPlus IP175C PHY driver");
> +MODULE_DESCRIPTION("ICPlus IP175C/IC1001 PHY drivers");
> MODULE_AUTHOR("Michael Barkowski");
> MODULE_LICENSE("GPL");
>
> @@ -89,6 +89,33 @@ static int ip175c_config_init(struct phy_device *phydev)
> return 0;
> }
>
> +static int ip1001_config_init(struct phy_device *phydev)
> +{
> + int err, value;
> +
> + /* Software Reset PHY */
> + value = phy_read(phydev, MII_BMCR);
> + value |= BMCR_RESET;
> + err = phy_write(phydev, MII_BMCR, value);
> + if (err < 0)
> + return err;
> +
> + do {
> + value = phy_read(phydev, MII_BMCR);
> + } while (value & BMCR_RESET);
> +
> + /* Additional delay (2ns) used to adjust RX clock phase
> + * at GMII/ RGMII interface */
> + value = phy_read(phydev, 16);
> + value |= 0x3;
Two things:
1) Is this generic for all instances of this PHY, or only for the
particular board you're using? Frequently these sorts of clock
adjustments are done to deal with skew on the lines between the PHY
and the NIC. If this is a board-specific change, consider using a
board fixup or passing a flag from the NIC.
2) Can we have names for register 16 and value 0x3?
Andy
^ permalink raw reply
* Re: [PATCH net-next-26] cxgb4vf: Ingress Queue Entry Size needs to be 64 bytes
From: David Miller @ 2010-12-10 23:49 UTC (permalink / raw)
To: leedom; +Cc: netdev
In-Reply-To: <201012091352.40821.leedom@chelsio.com>
From: Casey Leedom <leedom@chelsio.com>
Date: Thu, 9 Dec 2010 13:52:40 -0800
> Urk. Sorry about that: the subject prefix should have read "net-26" since
> this is a fairly critical bug fix. Let me know if you'd like me to resubmit the
> patch.
No need to resubmit, applied, thanks.
^ permalink raw reply
* Re: [PATCH net-next-2.6 1/2] ethtool: Report link-down while interface is down
From: David Miller @ 2010-12-10 23:55 UTC (permalink / raw)
To: bhutchings; +Cc: netdev, linux-net-drivers
In-Reply-To: <1291932515.2647.32.camel@bwh-desktop>
From: Ben Hutchings <bhutchings@solarflare.com>
Date: Thu, 09 Dec 2010 22:08:35 +0000
> While an interface is down, many implementations of
> ethtool_ops::get_link, including the default, ethtool_op_get_link(),
> will report the last link state seen while the interface was up. In
> general the current physical link state is not available if the
> interface is down.
>
> Define ETHTOOL_GLINK to reflect whether the interface *and* any
> physical port have a working link, and consistently return 0 when the
> interface is down.
>
> Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
> ---
> David,
>
> I know you weren't keen on this, but if you don't accept it then please
> say what you think the proper semantics are.
No, I'm actually fine with this.
Applied, thanks Ben!
^ permalink raw reply
* Re: [PATCH net-next-2.6 2/2] netdev: Use default implementation of ethtool_ops::get_link where possible
From: David Miller @ 2010-12-10 23:56 UTC (permalink / raw)
To: bhutchings; +Cc: netdev, linux-net-drivers
In-Reply-To: <1291932625.2647.34.camel@bwh-desktop>
From: Ben Hutchings <bhutchings@solarflare.com>
Date: Thu, 09 Dec 2010 22:10:25 +0000
> Various drivers are using implementations of ethtool_ops::get_link
> that are equivalent to the default ethtool_op_get_link(). Change
> them to use that instead.
>
> Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Applied.
^ permalink raw reply
* Re: [PATCH] af_packet: use swap() instead of the open coded macro XC()
From: David Miller @ 2010-12-11 0:02 UTC (permalink / raw)
To: xiaosuo; +Cc: jpirko, nhorman, netdev
In-Reply-To: <1291735125-20067-1-git-send-email-xiaosuo@gmail.com>
From: Changli Gao <xiaosuo@gmail.com>
Date: Tue, 7 Dec 2010 23:18:45 +0800
> Signed-off-by: Changli Gao <xiaosuo@gmail.com>
Applied, thanks.
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox