Netdev List
 help / color / mirror / Atom feed
* inbound connection problems when "netlink: test for all flags of the NLM_F_DUMP composite" commit applied
From: Arthur Marsh @ 2011-01-16  8:54 UTC (permalink / raw)
  To: netdev

 
 
 
 This bug was originally posted at https://bugzilla.kernel.org/show_bug.cgi?id=26632 
 
With kernels up to and including 2.6.37-git7, inbound telnetd-ssl connections worked fine. 
With kernel 2.6.37-git9 and later inbound telnetd-ssl connections failed, and on machine shut-down, there were warning messages about daemons not return status. 
 
A git bisect on Linus' kernel tree revealed: 
 
0ab03c2b1478f2438d2c80204f7fef65b1bca9cf is the first bad commit 
commit 0ab03c2b1478f2438d2c80204f7fef65b1bca9cf 
Author: Jan Engelhardt <jengelh@medozas.de> 
Date:   Fri Jan 7 03:15:05 2011 +0000 
 
    netlink: test for all flags of the NLM_F_DUMP composite 
 
    Due to NLM_F_DUMP is composed of two bits, NLM_F_ROOT | NLM_F_MATCH, 
    when doing "if (x & NLM_F_DUMP)", it tests for _either_ of the bits 
    being set. Because NLM_F_MATCH's value overlaps with NLM_F_EXCL, 
    non-dump requests with NLM_F_EXCL set are mistaken as dump requests. 
 
    Substitute the condition to test for _all_ bits being set. 
 
    Signed-off-by: Jan Engelhardt <jengelh@medozas.de> 
    Acked-by: Pablo Neira Ayuso <pablo@netfilter.org> 
    Signed-off-by: David S. Miller <davem@davemloft.net> 
 
:040000 040000 1a0717ab0c87787309c3c3af88d666b44f327f64 
cba6279de85b7ebeaf21f19f1d93b59468fdd01d M      net 
 
I tried git cherry-pick 0ab03c2b1478f2438d2c80204f7fef65b1bca9cf and verified 
that the resulting kernel had these problems, then git revert 
0ab03c2b1478f2438d2c80204f7fef65b1bca9cf and verified that the resulting kernel 
did *not* have problems. 
 
Arthur. 

^ permalink raw reply

* Re: Linux IPv6 router table size.
From: Eric Dumazet @ 2011-01-16  8:44 UTC (permalink / raw)
  To: Jan Hugo Prins; +Cc: netdev
In-Reply-To: <4D320D90.3090005@jhprins.org>

Le samedi 15 janvier 2011 à 22:11 +0100, Jan Hugo Prins a écrit :
> Hi netdev kernel developers,
> 
> In the beginning of December the number of IPv6 routes in the BPG router
> tables got somewhere close to 4096 and this number is somewhat magical
> in Linux. Why is it magical? Well, the default setting for
> net.ipv6.route.max_size is hardcoded in the linux kernel to be exactly
> this number, this in contradiction with the IPv4 net.ipv4.route.max_size
> which is set based upon the size of your memory. Actually, in the IPv4
> part of the kernel sources their is a route.c with a nice formula
> telling the kernel how big this number should be. For IPv6 their is also
> a route.c with some nice formula in it, the formula says exactly the
> following:
> net->ipv6.sysctl.ip6_rt_max_size = 4096;
> 
> The result of all this magic was that when the BGP RIB in my quagga
> routers went over the 4096 routes, quagga started complaining that it
> couldn't put the routes in the kernel FIB anymore and this went all into
> syslog.
> 
> It took some digging to find the reason for these error messages, but
> after changing this sysctl to something more useful, everything was fine
> again.
> 
> Maybe it is a good idea to change this in the IPv6 tree to something
> more useful in the same direction of the solution that is in the IPv4 tree.
> 

Hi

IPv4 does an auto memsize tuning because it uses a hash table, and this
table cant be resized after boot.

IPv6 is different, and you can change 
/proc/sys/net/ipv6/route/gc_thresh & /proc/sys/net/ipv6/route/max_size
whithout downsides.

echo 32768 >/proc/sys/net/ipv6/route/max_size
echo 8192 >/proc/sys/net/ipv6/route/gc_thresh

(or equivalent lines in /etc/sysctl.conf)

We probably could change default values, but they are "not hardcoded" ;)




^ permalink raw reply

* Re: [PATCH net-next 0/8] vmxnet3 fixes and enhancements
From: David Miller @ 2011-01-16  5:21 UTC (permalink / raw)
  To: sbhatewara; +Cc: netdev, linux-kernel, pv-drivers
In-Reply-To: <20110115005701.1064.67435.stgit@sbhatewara-dev1.eng.vmware.com>

From: Shreyas N Bhatewara <sbhatewara@vmware.com>
Date: Fri, 14 Jan 2011 16:59:20 -0800

> The following series fixes bugs and enhances functionality in the
> vmxnet3 driver.
> 
> ---
> 
> Shreyas N Bhatewara (8):
>       vmxnet3: fix ring size update
>       vmxnet3: Preserve the MAC address configured by ifconfig
>       vmxnet3: Enable HW Rx VLAN stripping by default
>       vmxnet3: Provide required number of bytes in first SG buffer
>       vmxnet3: Make ethtool handlers multiqueue aware
>       vmxnet3: Disable napi in suspend, reenable in resume.
>       vmxnet3: Add locking for access to command register
>       vmxnet3: Dont allocate extra MSI-x vectors

All applied, thanks.

^ permalink raw reply

* Re: [patch] caif: checking the wrong variable
From: David Miller @ 2011-01-16  5:05 UTC (permalink / raw)
  To: sjurbren; +Cc: error27, netdev, kernel-janitors
In-Reply-To: <AANLkTimyZQ1BEJ=tPK4LrYWhQaGd+xhYUsVEENibEVoU@mail.gmail.com>

From: Sjur Brændeland <sjurbren@gmail.com>
Date: Sat, 15 Jan 2011 15:03:31 +0100

>> In the original code we check if (servl == NULL) twice.  The first time
>> should print the message that cfmuxl_remove_uplayer() failed and set
>> "ret" correctly, but instead it just returns success.  The second check
>> should be checking the value of "ret" instead of "servl".
>>
>> Signed-off-by: Dan Carpenter <error27@gmail.com>
> 
> Thank you for spotting and correcting this.
> Looks good to me (reviewed only)
> 
> Acked-by: Sjur Braendeland <sjur.brandeland@stericsson.com>

Applied, thanks.

^ permalink raw reply

* Re: [PATCH v2] can: test size of struct sockaddr in sendmsg
From: David Miller @ 2011-01-16  4:56 UTC (permalink / raw)
  To: kurt.van.dijck; +Cc: netdev, socketcan-core, socketcan
In-Reply-To: <20110115193916.GC463@e-circ.dyndns.org>

From: Kurt Van Dijck <kurt.van.dijck@eia.be>
Date: Sat, 15 Jan 2011 20:39:16 +0100

> This patch makes the CAN socket code conform to the manpage of sendmsg.
> 
> Signed-off-by: Kurt Van Dijck <kurt.van.dijck@eia.be>
> Acked-by: Oliver Hartkopp <socketcan@hartkopp.net>

Applied, thanks.

^ permalink raw reply

* Re: [patch] 9p: fix min_t() casting
From: David Miller @ 2011-01-16  4:52 UTC (permalink / raw)
  To: error27; +Cc: ericvh, sripathik, jvrao, aneesh.kumar, netdev, kernel-janitors
In-Reply-To: <20110115203539.GF2721@bicker>

From: Dan Carpenter <error27@gmail.com>
Date: Sat, 15 Jan 2011 23:35:39 +0300

> The intent here was to cap the length to USHRT_MAX, but what the
> code actually does is it just casts the return from strlen() to
> unsigned short and truncates the significant bits away.
> 
> Signed-off-by: Dan Carpenter <error27@gmail.com>

If you want me to apply this, it doesn't apply cleanly to net-2.6
at all.

^ permalink raw reply

* Re: pull request: batman-adv 2011-01-16
From: David Miller @ 2011-01-16  4:48 UTC (permalink / raw)
  To: sven-KaDOiPu9UxWEi8DpZVb4nw
  Cc: netdev-u79uwXL29TY76Z2rM5mHXA,
	b.a.t.m.a.n-ZwoEplunGu2X36UT3dwllkB+6BGkLq7r
In-Reply-To: <1295145527-17537-1-git-send-email-sven-KaDOiPu9UxWEi8DpZVb4nw@public.gmane.org>

From: Sven Eckelmann <sven-KaDOiPu9UxWEi8DpZVb4nw@public.gmane.org>
Date: Sun, 16 Jan 2011 03:38:45 +0100

> The following changes since commit 53320fe3bb1b1eef1aaff8dd47aae530ebeeb1e5:
> 
>   batman-adv: Return hna count on local buffer fill (2010-12-20 10:32:03 -0800)
> 
> are available in the git repository at:
>   git://git.open-mesh.org/ecsv/linux-merge.git for-david

Pulled, thanks Sven.

^ permalink raw reply

* Re: [patch 2/2] [PATCH] qeth: l3 hw tx csum circumvent hw bug
From: David Miller @ 2011-01-16  4:46 UTC (permalink / raw)
  To: frank.blaschka; +Cc: netdev, linux-s390
In-Reply-To: <20110113082359.GA11455@tuxmaker.boeblingen.de.ibm.com>

From: Frank Blaschka <frank.blaschka@de.ibm.com>
Date: Thu, 13 Jan 2011 09:23:59 +0100

> On Wed, Jan 12, 2011 at 11:47:35PM -0800, David Miller wrote:
>> From: frank.blaschka@de.ibm.com
>> Date: Thu, 13 Jan 2011 07:42:25 +0100
>> 
>> > --- a/drivers/s390/net/qeth_l3_main.c
>> > +++ b/drivers/s390/net/qeth_l3_main.c
>> > @@ -2998,7 +2998,9 @@ static inline void qeth_l3_hdr_csum(stru
>> >  	 */
>> >  	if (iph->protocol == IPPROTO_UDP)
>> >  		hdr->hdr.l3.ext_flags |= QETH_HDR_EXT_UDP;
>> > -	hdr->hdr.l3.ext_flags |= QETH_HDR_EXT_CSUM_TRANSP_REQ;
>> > +	hdr->hdr.l3.ext_flags |= QETH_HDR_EXT_CSUM_TRANSP_REQ |
>> > +		QETH_HDR_EXT_CSUM_HDR_REQ;
>> > +	iph->check = 0;
>> >  	if (card->options.performance_stats)
>> >  		card->perf_stats.tx_csum++;
>> >  }
>> 
>> You may not change the packet header contents blindly like this.
>> Otherwise unpredictable contents will be seen by tcpdump and any
>> other code path which has a clone of this packet.
>> 
>> Thus, you'll need to guard this change with something like:
>> 
>> 		if (skb_header_cloned(skb) &&
>> 		    pskb_expand_head(skb, 0, 0, GFP_ATOMIC)) {
>> 			dev_kfree_skb(skb);
>> 			goto tx_fail;
>> 		}
> Yes I know. Because of the suboptimal l3 driver design :-) we already have
> a private copy of the skb at this place. Thx!

I see, thanks for explaining.

Both patches applied, thanks.

^ permalink raw reply

* [PATCH 2/2] batman-adv: Use "__attribute__" shortcut macros
From: Sven Eckelmann @ 2011-01-16  2:38 UTC (permalink / raw)
  To: davem-fT/PcQaiUtIeIZ0/mPfg9Q
  Cc: netdev-u79uwXL29TY76Z2rM5mHXA,
	b.a.t.m.a.n-ZwoEplunGu2X36UT3dwllkB+6BGkLq7r
In-Reply-To: <1295145527-17537-1-git-send-email-sven-KaDOiPu9UxWEi8DpZVb4nw@public.gmane.org>

Linux 2.6.21 defines different macros for __attribute__ which are also
used inside batman-adv. The next version of checkpatch.pl warns about
the usage of __attribute__((packed))).

Linux 2.6.33 defines an extra macro __always_unused which is used to
assist source code analyzers and can be used to removed the last
existing __attribute__ inside the source code.

Signed-off-by: Sven Eckelmann <sven-KaDOiPu9UxWEi8DpZVb4nw@public.gmane.org>
---
 net/batman-adv/main.h   |    6 +++---
 net/batman-adv/packet.h |   14 +++++++-------
 net/batman-adv/types.h  |    4 ++--
 3 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/net/batman-adv/main.h b/net/batman-adv/main.h
index d4d9926..65106fb 100644
--- a/net/batman-adv/main.h
+++ b/net/batman-adv/main.h
@@ -151,9 +151,9 @@ int debug_log(struct bat_priv *bat_priv, char *fmt, ...);
 	}							\
 	while (0)
 #else /* !CONFIG_BATMAN_ADV_DEBUG */
-static inline void bat_dbg(char type __attribute__((unused)),
-			   struct bat_priv *bat_priv __attribute__((unused)),
-			   char *fmt __attribute__((unused)), ...)
+static inline void bat_dbg(char type __always_unused,
+			   struct bat_priv *bat_priv __always_unused,
+			   char *fmt __always_unused, ...)
 {
 }
 #endif
diff --git a/net/batman-adv/packet.h b/net/batman-adv/packet.h
index b49fdf7..2284e81 100644
--- a/net/batman-adv/packet.h
+++ b/net/batman-adv/packet.h
@@ -63,7 +63,7 @@ struct batman_packet {
 	uint8_t  num_hna;
 	uint8_t  gw_flags;  /* flags related to gateway class */
 	uint8_t  align;
-} __attribute__((packed));
+} __packed;
 
 #define BAT_PACKET_LEN sizeof(struct batman_packet)
 
@@ -76,7 +76,7 @@ struct icmp_packet {
 	uint8_t  orig[6];
 	uint16_t seqno;
 	uint8_t  uid;
-} __attribute__((packed));
+} __packed;
 
 #define BAT_RR_LEN 16
 
@@ -93,14 +93,14 @@ struct icmp_packet_rr {
 	uint8_t  uid;
 	uint8_t  rr_cur;
 	uint8_t  rr[BAT_RR_LEN][ETH_ALEN];
-} __attribute__((packed));
+} __packed;
 
 struct unicast_packet {
 	uint8_t  packet_type;
 	uint8_t  version;  /* batman version field */
 	uint8_t  dest[6];
 	uint8_t  ttl;
-} __attribute__((packed));
+} __packed;
 
 struct unicast_frag_packet {
 	uint8_t  packet_type;
@@ -110,7 +110,7 @@ struct unicast_frag_packet {
 	uint8_t  flags;
 	uint8_t  orig[6];
 	uint16_t seqno;
-} __attribute__((packed));
+} __packed;
 
 struct bcast_packet {
 	uint8_t  packet_type;
@@ -118,7 +118,7 @@ struct bcast_packet {
 	uint8_t  orig[6];
 	uint8_t  ttl;
 	uint32_t seqno;
-} __attribute__((packed));
+} __packed;
 
 struct vis_packet {
 	uint8_t  packet_type;
@@ -131,6 +131,6 @@ struct vis_packet {
 				  * neighbors */
 	uint8_t  target_orig[6]; /* who should receive this packet */
 	uint8_t  sender_orig[6]; /* who sent or rebroadcasted this packet */
-} __attribute__((packed));
+} __packed;
 
 #endif /* _NET_BATMAN_ADV_PACKET_H_ */
diff --git a/net/batman-adv/types.h b/net/batman-adv/types.h
index 97cb23d..bf3f6f5 100644
--- a/net/batman-adv/types.h
+++ b/net/batman-adv/types.h
@@ -246,13 +246,13 @@ struct vis_info {
 	/* this packet might be part of the vis send queue. */
 	struct sk_buff *skb_packet;
 	/* vis_info may follow here*/
-} __attribute__((packed));
+} __packed;
 
 struct vis_info_entry {
 	uint8_t  src[ETH_ALEN];
 	uint8_t  dest[ETH_ALEN];
 	uint8_t  quality;	/* quality = 0 means HNA */
-} __attribute__((packed));
+} __packed;
 
 struct recvlist_node {
 	struct list_head list;
-- 
1.7.2.3

^ permalink raw reply related

* [PATCH 1/2] batman-adv: Even Batman should not dereference NULL pointers
From: Sven Eckelmann @ 2011-01-16  2:38 UTC (permalink / raw)
  To: davem-fT/PcQaiUtIeIZ0/mPfg9Q
  Cc: netdev-u79uwXL29TY76Z2rM5mHXA,
	b.a.t.m.a.n-ZwoEplunGu2X36UT3dwllkB+6BGkLq7r, Jesper Juhl
In-Reply-To: <1295145527-17537-1-git-send-email-sven-KaDOiPu9UxWEi8DpZVb4nw@public.gmane.org>

From: Jesper Juhl <jj-IYz4IdjRLj0sV2N9l4h3zg@public.gmane.org>

There's a problem in net/batman-adv/unicast.c::frag_send_skb().
dev_alloc_skb() allocates memory and may fail, thus returning NULL. If
this happens we'll pass a NULL pointer on to skb_split() which in turn
hands it to skb_split_inside_header() from where it gets passed to
skb_put() that lets skb_tail_pointer() play with it and that function
dereferences it. And thus the bat dies.

While I was at it I also moved the call to dev_alloc_skb() above the
assignment to 'unicast_packet' since there's no reason to do that
assignment if the memory allocation fails.

Signed-off-by: Jesper Juhl <jj-IYz4IdjRLj0sV2N9l4h3zg@public.gmane.org>
Signed-off-by: Sven Eckelmann <sven-KaDOiPu9UxWEi8DpZVb4nw@public.gmane.org>
---
 net/batman-adv/unicast.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/net/batman-adv/unicast.c b/net/batman-adv/unicast.c
index dc2e28b..ee41fef 100644
--- a/net/batman-adv/unicast.c
+++ b/net/batman-adv/unicast.c
@@ -229,10 +229,12 @@ int frag_send_skb(struct sk_buff *skb, struct bat_priv *bat_priv,
 	if (!bat_priv->primary_if)
 		goto dropped;
 
-	unicast_packet = (struct unicast_packet *) skb->data;
+	frag_skb = dev_alloc_skb(data_len - (data_len / 2) + ucf_hdr_len);
+	if (!frag_skb)
+		goto dropped;
 
+	unicast_packet = (struct unicast_packet *) skb->data;
 	memcpy(&tmp_uc, unicast_packet, uc_hdr_len);
-	frag_skb = dev_alloc_skb(data_len - (data_len / 2) + ucf_hdr_len);
 	skb_split(skb, frag_skb, data_len / 2);
 
 	if (my_skb_head_push(skb, ucf_hdr_len - uc_hdr_len) < 0 ||
-- 
1.7.2.3

^ permalink raw reply related

* pull request: batman-adv 2011-01-16
From: Sven Eckelmann @ 2011-01-16  2:38 UTC (permalink / raw)
  To: davem-fT/PcQaiUtIeIZ0/mPfg9Q
  Cc: netdev-u79uwXL29TY76Z2rM5mHXA,
	b.a.t.m.a.n-ZwoEplunGu2X36UT3dwllkB+6BGkLq7r

Hi,

i would propose some smaller corrections.

The following changes since commit 53320fe3bb1b1eef1aaff8dd47aae530ebeeb1e5:

  batman-adv: Return hna count on local buffer fill (2010-12-20 10:32:03 -0800)

are available in the git repository at:
  git://git.open-mesh.org/ecsv/linux-merge.git for-david

Jesper Juhl (1):
      batman-adv: Even Batman should not dereference NULL pointers

Sven Eckelmann (1):
      batman-adv: Use "__attribute__" shortcut macros

 net/batman-adv/main.h    |    6 +++---
 net/batman-adv/packet.h  |   14 +++++++-------
 net/batman-adv/types.h   |    4 ++--
 net/batman-adv/unicast.c |    6 ++++--
 4 files changed, 16 insertions(+), 14 deletions(-)

^ permalink raw reply

* Re: [PATCH] tlan: Use pr_fmt, pr_<level> and netdev_<level>, remove changelog
From: Sakari Ailus @ 2011-01-13  6:19 UTC (permalink / raw)
  To: David Miller; +Cc: joe, netdev, chessman, bhutchings
In-Reply-To: <20110109.233950.71582613.davem@davemloft.net>

Hi David,

On Sun, Jan 09, 2011 at 11:39:50PM -0800, David Miller wrote:
> From: Joe Perches <joe@perches.com>
> Date: Thu, 06 Jan 2011 14:48:08 -0800
> 
> > Neatening and standardization to the standard logging mechanisms.
> > The changelog isn't useful anymore.
> > Miscellaneous speen/speed typo correction.
> > 
> > Signed-off-by: Joe Perches <joe@perches.com>
> 
> This patch didn't apply cleanly to the current sources.
> 
> And anyways, please resubmit this once 2.6.38-rc1 is out and I
> start taking net-next-2.6 patches again.

Joe's patch applies on top of my patchset "tlan improvements" which contains
a largish code cleanup for the tlan driver. I got comments on that from Ben
Hutchings and haven't sent a new patchset yet.

Instead of fixing partner capability printout I'm removing it since the same
information is available under the mii-tool interface. Ben notified, quite
rightly, that the tlan should be using ethtool interface. That looks like a
topic for another patchset, though.

Regards,

-- 
Sakari Ailus
sakari dot ailus at iki dot fi

^ permalink raw reply

* Linux IPv6 router table size.
From: Jan Hugo Prins @ 2011-01-15 21:11 UTC (permalink / raw)
  To: netdev

Hi netdev kernel developers,

In the beginning of December the number of IPv6 routes in the BPG router
tables got somewhere close to 4096 and this number is somewhat magical
in Linux. Why is it magical? Well, the default setting for
net.ipv6.route.max_size is hardcoded in the linux kernel to be exactly
this number, this in contradiction with the IPv4 net.ipv4.route.max_size
which is set based upon the size of your memory. Actually, in the IPv4
part of the kernel sources their is a route.c with a nice formula
telling the kernel how big this number should be. For IPv6 their is also
a route.c with some nice formula in it, the formula says exactly the
following:
net->ipv6.sysctl.ip6_rt_max_size = 4096;

The result of all this magic was that when the BGP RIB in my quagga
routers went over the 4096 routes, quagga started complaining that it
couldn't put the routes in the kernel FIB anymore and this went all into
syslog.

It took some digging to find the reason for these error messages, but
after changing this sysctl to something more useful, everything was fine
again.

Maybe it is a good idea to change this in the IPv6 tree to something
more useful in the same direction of the solution that is in the IPv4 tree.

Greetings,
Jan Hugo Prins


^ permalink raw reply

* [patch] 9p: fix min_t() casting
From: Dan Carpenter @ 2011-01-15 20:35 UTC (permalink / raw)
  To: Eric Van Hensbergen
  Cc: David S. Miller, Sripathi Kodi, Venkateswararao Jujjuri,
	Aneesh Kumar K.V, netdev, kernel-janitors

The intent here was to cap the length to USHRT_MAX, but what the
code actually does is it just casts the return from strlen() to
unsigned short and truncates the significant bits away.

Signed-off-by: Dan Carpenter <error27@gmail.com>

diff --git a/net/9p/protocol.c b/net/9p/protocol.c
index 1e308f2..0422581 100644
--- a/net/9p/protocol.c
+++ b/net/9p/protocol.c
@@ -403,7 +403,7 @@ p9pdu_vwritef(struct p9_fcall *pdu, int proto_version, const char *fmt,
 				const char *sptr = va_arg(ap, const char *);
 				uint16_t len = 0;
 				if (sptr)
-					len = min_t(uint16_t, strlen(sptr),
+					len = min_t(size_t, strlen(sptr),
 								USHRT_MAX);
 
 				errcode = p9pdu_writef(pdu, proto_version,

^ permalink raw reply related

* [PATCH v2] can: test size of struct sockaddr in sendmsg
From: Kurt Van Dijck @ 2011-01-15 19:39 UTC (permalink / raw)
  To: netdev-u79uwXL29TY76Z2rM5mHXA,
	socketcan-core-0fE9KPoRgkgATYTw5x5z8w, Oliver Hartkopp

This patch makes the CAN socket code conform to the manpage of sendmsg.

Signed-off-by: Kurt Van Dijck <kurt.van.dijck-/BeEPy95v10@public.gmane.org>
Acked-by: Oliver Hartkopp <socketcan-fJ+pQTUTwRTk1uMJSBkQmQ@public.gmane.org>
---
 net/can/bcm.c |    3 +++
 net/can/raw.c |    3 +++
 2 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/net/can/bcm.c b/net/can/bcm.c
index 6faa825..2f804e4 100644
--- a/net/can/bcm.c
+++ b/net/can/bcm.c
@@ -1256,6 +1256,9 @@ static int bcm_sendmsg(struct kiocb *iocb, struct socket *sock,
 		struct sockaddr_can *addr =
 			(struct sockaddr_can *)msg->msg_name;
 
+		if (msg->msg_namelen < sizeof(*addr))
+			return -EINVAL;
+
 		if (addr->can_family != AF_CAN)
 			return -EINVAL;
 
diff --git a/net/can/raw.c b/net/can/raw.c
index e88f610..883e9d7 100644
--- a/net/can/raw.c
+++ b/net/can/raw.c
@@ -649,6 +649,9 @@ static int raw_sendmsg(struct kiocb *iocb, struct socket *sock,
 		struct sockaddr_can *addr =
 			(struct sockaddr_can *)msg->msg_name;
 
+		if (msg->msg_namelen < sizeof(*addr))
+			return -EINVAL;
+
 		if (addr->can_family != AF_CAN)
 			return -EINVAL;

^ permalink raw reply related

* Re: [PATCH] can: test size of struct sockaddr
From: Kurt Van Dijck @ 2011-01-15 19:35 UTC (permalink / raw)
  To: Oliver Hartkopp
  Cc: socketcan-core-0fE9KPoRgkgATYTw5x5z8w,
	netdev-u79uwXL29TY76Z2rM5mHXA
In-Reply-To: <4D31D4A6.4040701-fJ+pQTUTwRTk1uMJSBkQmQ@public.gmane.org>

On Sat, Jan 15, 2011 at 06:08:54PM +0100, Oliver Hartkopp wrote:
> On 14.01.2011 18:23, Kurt Van Dijck wrote:
> > I think this patch makes the CAN socket code comform to the
> > manpages of sendmsg & recvmsg.
> 
> Hello Kurt,
> 
> if you check similar code sniplets in the kernel you would see, that in
> recvmsg()-cases the given namelen is not used from userspace.
I went into udp code, but my mind got troubled there.
> 
> If msg->msg_name is not NULL the msg_namelen is just set by the kernel. E.g.
> see af_packet.c, af_econet.c, etc.
I should have looked further ...
Given this, I went up to net/socket.c:__sys_recvmsg.
Within kernel space, a struct sockaddr_storage is used in fact ....
This solves indeed the problem I was trying to address.
> 
> So the code in candump.c setting the msg_namelen before recvmsg() is obviously
> obsolete ...
I think no, since after the socket's recvmsg() has been called, 
since move_addr_to_user() will do checks similar as I tried to reimplement.
> 
> Btw. your two patches below for bcm_sendmsg() and raw_sendmesg() look good.
> 
> If you would like to resubmit these two patches, you may add my Acked-by
Thanks, I will do so.

Kurt

^ permalink raw reply

* NETLINK: Failed to browse: Invalid argument from avahi-daemon in F14 since 2.6.37-git8
From: Alessandro Suardi @ 2011-01-15 18:34 UTC (permalink / raw)
  To: linux-kernel, netdev

/var/log/messages says:

Jan 13 12:42:02 duff avahi-daemon[2771]: Found user 'avahi' (UID 70)
and group 'avahi' (GID 70).
Jan 13 12:42:02 duff avahi-daemon[2771]: Successfully dropped root privileges.
Jan 13 12:42:02 duff avahi-daemon[2771]: avahi-daemon 0.6.27 starting up.
Jan 13 12:42:02 duff avahi-daemon[2771]: Successfully called chroot().
Jan 13 12:42:02 duff avahi-daemon[2771]: Successfully dropped
remaining capabilities.
Jan 13 12:42:02 duff avahi-daemon[2771]: Loading service file
/services/ssh.service.
Jan 13 12:42:02 duff avahi-daemon[2771]: Loading service file
/services/udisks.service.
Jan 13 12:42:02 duff avahi-daemon[2771]: NETLINK: Failed to browse:
Invalid argument
Jan 13 12:42:23 duff acpid: starting up with netlink and the input layer


Happens both at boot and after boot if restarting avahi-daemon service,
 and there is a 10-15" wait before the service start script prints a [FAILED]
 red tag; avahi-daemon process does start up anyways.

-git7 is the latest "good" kernel
-git8, -git9, -git11, -git13 have been reproducing the issue


thanks, ciao,

--alessandro

 "There's always a siren singing you to shipwreck"

   (Radiohead, "There There")

^ permalink raw reply

* Re: [2.6.37 vanilla] PC freezing, call stack pointing at net/sched/sch_generic.c
From: Joe Perches @ 2011-01-15 17:38 UTC (permalink / raw)
  To: David Robin; +Cc: netdev, LKML
In-Reply-To: <AANLkTimrP5Mqg340SwHrvdn=4KkvRchOjoy3-_f-9UJg@mail.gmail.com>

On Sat, 2011-01-15 at 14:49 +0100, David Robin wrote:
> Hello,
> 
> As I noticed you are one of the latest forcedeth contributers, I take
> the opportunity to report you this series of errors in forcedeth
> driver, which caused my desktop PC to freeze, in a reproducable way.
> 
> I am running Debian testing on a nForce4-based motheboard, and an AMD
> Athlon X2 Dual Core Processor 4200+.
> The stock 2.6.32-5 kernel package is running perfectly fine, whereas
> 2.6.37 kernel image I compiled is freezing after 1 or 2 days of
> uptime.
> 
> Unfortunately, I have tried to compile intermediate versions of Linux
> kernel to try and identify the period when the issue was introduced.

Try git-bisect.
http://www.reactivated.net/weblog/archives/2006/01/using-git-bisect-to-find-buggy-kernel-patches/

Here's a list of the changelog since 2.6.32
------------------

$ git shortlog v2.6.32..v2.6.37 -- drivers/net/forcedeth.c
Alexey Dobriyan (1):
      drivers/net/: use DEFINE_PCI_DEVICE_TABLE()

Ayaz Abdulla (1):
      forcedeth: fix tx limit2 flag check

David S. Miller (3):
      Merge branch 'master' of master.kernel.org:/.../davem/net-2.6
      Merge branch 'master' of master.kernel.org:/.../davem/net-2.6
      forcedeth: Kill NAPI config options.

Eric Dumazet (3):
      drivers: net: use skb_headlen()
      net: trans_start cleanups
      drivers/net: return operator cleanup

Jesse Gross (1):
      vlan: Don't check for vlan group before vlan_tx_tag_present.

Jiri Pirko (2):
      net: convert multiple drivers to use netdev_for_each_mc_addr, part4
      net: convert multicast list to list_head

Joe Perches (2):
      drivers/net: request_irq - Remove unnecessary leading & from second arg
      drivers/net: Remove address use from assignments of function pointers

Julia Lawall (1):
      forcedeth: correct valid flag

Mike Ditto (1):
      forcedeth: Fix different hardware statistics versions.

Tejun Heo (1):
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit s

Tom Herbert (2):
      forcedeth: GRO support
      forcedeth: Account for consumed budget in napi poll

stephen hemminger (1):
      forcedeth: Stay in NAPI as long as there's work

------------------

Based only on the changelog, I'd guess it might be the NAPI change
and some hardware issue, but who really knows.

git bisect should help figure that out.

> Are you the right person I should report this error too,

No.

You should report this to linux-kernel@vger.kernel.org
and to netdev@vger.kernel.org

I added them to the cc's on this reply.

>  and is there more debug information I could provide ?

Not really, other than it'd really help if you could
run the git bisect.

David Robin's original attachment:
----------------------
Jan 14 01:50:02 gizeh kernel: [13653.828013] ------------[ cut here ]------------
Jan 14 01:50:02 gizeh kernel: [13653.828023] WARNING: at net/sched/sch_generic.c:258 dev_watchdog+0xfc/0x1a2()
Jan 14 01:50:02 gizeh kernel: [13653.828026] Hardware name: MS-7125
Jan 14 01:50:02 gizeh kernel: [13653.828029] NETDEV WATCHDOG: eth1 (forcedeth): transmit queue 0 timed out
Jan 14 01:50:02 gizeh kernel: [13653.828031] Modules linked in: radeon ttm drm_kms_helper drm i2c_algo_bit fuse loop firewire_sbp2 usbhid hid arc4 ecb option usb_wwan usbserial ath5k ath snd_hda_codec_hdmi sg snd_hda_intel ohci_hcd sr_mod cdrom mac80211 firewire_ohci ehci_hcd i2c_nforce2 usbcore snd_hda_codec cfg80211 snd_intel8x0 firewire_core k8temp parport_pc sata_sil pata_amd sky2 rfkill snd_hwdep i2c_core parport snd_ac97_codec pcspkr shpchp evdev forcedeth ac97_bus nls_base snd_pcm snd_timer snd tpm_tis tpm tpm_bios soundcore processor button edac_core pci_hotplug crc_itu_t snd_page_alloc edac_mce_amd ext3 jbd mbcache sd_mod crc_t10dif sata_nv ata_generic libata scsi_mod thermal fan thermal_sys
Jan 14 01:50:02 gizeh kernel: [13653.828085] Pid: 2096, comm: Xorg Not tainted 2.6.37 #1
Jan 14 01:50:02 gizeh kernel: [13653.828087] Call Trace:
Jan 14 01:50:02 gizeh kernel: [13653.828090]  <IRQ>  [<ffffffff8103bc50>] ? warn_slowpath_common+0x78/0x8c
Jan 14 01:50:02 gizeh kernel: [13653.828099]  [<ffffffff8103bd03>] ? warn_slowpath_fmt+0x45/0x4a
Jan 14 01:50:02 gizeh kernel: [13653.828103]  [<ffffffff8125ce41>] ? netif_tx_lock+0x3d/0x65
Jan 14 01:50:02 gizeh kernel: [13653.828106]  [<ffffffff8125cf65>] ? dev_watchdog+0xfc/0x1a2
Jan 14 01:50:02 gizeh kernel: [13653.828111]  [<ffffffff8104fa7c>] ? __queue_work+0x22d/0x251
Jan 14 01:50:02 gizeh kernel: [13653.828116]  [<ffffffff81047c33>] ? run_timer_softirq+0x1c2/0x285
Jan 14 01:50:02 gizeh kernel: [13653.828119]  [<ffffffff8125ce69>] ? dev_watchdog+0x0/0x1a2
Jan 14 01:50:02 gizeh kernel: [13653.828124]  [<ffffffff8105c45e>] ? ktime_get+0x5f/0xb8
Jan 14 01:50:02 gizeh kernel: [13653.828127]  [<ffffffff81041552>] ? __do_softirq+0xc9/0x1ab
Jan 14 01:50:02 gizeh kernel: [13653.828131]  [<ffffffff8100388c>] ? call_softirq+0x1c/0x28
Jan 14 01:50:02 gizeh kernel: [13653.828134]  [<ffffffff81004ca5>] ? do_softirq+0x31/0x63
Jan 14 01:50:02 gizeh kernel: [13653.828137]  [<ffffffff810413f0>] ? irq_exit+0x36/0x79
Jan 14 01:50:02 gizeh kernel: [13653.828142]  [<ffffffff81018d72>] ? smp_apic_timer_interrupt+0x87/0x94
Jan 14 01:50:02 gizeh kernel: [13653.828146]  [<ffffffff81003353>] ? apic_timer_interrupt+0x13/0x20
Jan 14 01:50:02 gizeh kernel: [13653.828148]  <EOI>  [<ffffffff8118b12c>] ? delay_tsc+0x1a/0x4e
Jan 14 01:50:02 gizeh kernel: [13653.828171]  [<ffffffffa0336acc>] ? radeon_freelist_get+0xd5/0xf6 [radeon]
Jan 14 01:50:02 gizeh kernel: [13653.828181]  [<ffffffffa033a495>] ? radeon_cp_buffers+0xe5/0x169 [radeon]
Jan 14 01:50:02 gizeh kernel: [13653.828191]  [<ffffffffa02f1e06>] ? drm_ioctl+0x26c/0x322 [drm]
Jan 14 01:50:02 gizeh kernel: [13653.828201]  [<ffffffffa033a3b0>] ? radeon_cp_buffers+0x0/0x169 [radeon]
Jan 14 01:50:02 gizeh kernel: [13653.828205]  [<ffffffff81002497>] ? do_signal+0x584/0x68a
Jan 14 01:50:02 gizeh kernel: [13653.828209]  [<ffffffff810f0ea4>] ? do_vfs_ioctl+0x4a2/0x4ef
Jan 14 01:50:02 gizeh kernel: [13653.828213]  [<ffffffff8100a7a8>] ? restore_i387_xstate+0x61/0x139
Jan 14 01:50:02 gizeh kernel: [13653.828216]  [<ffffffff8100334e>] ? apic_timer_interrupt+0xe/0x20
Jan 14 01:50:02 gizeh kernel: [13653.828220]  [<ffffffff810f0f3c>] ? sys_ioctl+0x4b/0x6f
Jan 14 01:50:02 gizeh kernel: [13653.828223]  [<ffffffff810029bb>] ? system_call_fastpath+0x16/0x1b
Jan 14 01:50:02 gizeh kernel: [13653.828226] ---[ end trace 119f4557b810af02 ]---
Jan 14 01:50:02 gizeh kernel: [13653.828229] eth1: Got tx_timeout. irq: 00000036
Jan 14 01:50:02 gizeh kernel: [13653.828231] eth1: Ring at 12a73c000
Jan 14 01:50:02 gizeh kernel: [13653.828233] eth1: Dumping tx registers
Jan 14 01:50:02 gizeh kernel: [13653.828238]   0: 00000036 00000000 00000003 0000000d 00000000 00000000 00000000 00000000
Jan 14 01:50:02 gizeh kernel: [13653.828243]  20: 06255300 ff701365 00000000 00000000 00000000 00000000 00000000 00000000
Jan 14 01:50:02 gizeh kernel: [13653.828249]  40: 0420e20e 0000a855 00002e20 00000000 00000000 00000000 00000000 00000000
Jan 14 01:50:02 gizeh kernel: [13653.828254]  60: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
Jan 14 01:50:02 gizeh kernel: [13653.828260]  80: 003b0f3c 00000001 00040000 007f0020 0000061c 00000001 00200000 80007fae
Jan 14 01:50:02 gizeh kernel: [13653.828265]  a0: 0016070f 00000016 d2091100 0000b21b 00000001 00000000 2d00cccd 00004ce4
Jan 14 01:50:02 gizeh kernel: [13653.828271]  c0: 10000001 00000001 00000001 00000001 00000001 00000001 00000001 00000001
Jan 14 01:50:02 gizeh kernel: [13653.828276]  e0: 00000001 00000001 00000001 00000001 00000001 00000001 00000001 00000001
Jan 14 01:50:02 gizeh kernel: [13653.828282] 100: 2a73e000 2a73c000 01ff00ff 00008000 00010064 00000000 00000024 2a73e500
Jan 14 01:50:02 gizeh kernel: [13653.828287] 120: 2a73d4c0 bf435380 a000ffde 117bf040 8000061c 2a73e50c 2a73d374 01e08000
Jan 14 01:50:02 gizeh kernel: [13653.828293] 140: 00304120 80002600 00000001 00000001 00000000 00000000 00000000 00000000
Jan 14 01:50:02 gizeh kernel: [13653.828298] 160: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
Jan 14 01:50:02 gizeh kernel: [13653.828304] 180: 00000016 00000008 0194796d 00008103 0000002a 00004000 0194000f 00000003
Jan 14 01:50:02 gizeh kernel: [13653.828309] 1a0: 00000016 00000008 0194796d 00008103 0000002a 00004000 0194000f 00000003
Jan 14 01:50:02 gizeh kernel: [13653.828315] 1c0: 00000016 00000008 0194796d 00008103 0000002a 00004000 0194000f 00000003
Jan 14 01:50:02 gizeh kernel: [13653.828320] 1e0: 00000016 00000008 0194796d 00008103 0000002a 00004000 0194000f 00000003
Jan 14 01:50:02 gizeh kernel: [13653.828326] 200: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
Jan 14 01:50:02 gizeh kernel: [13653.828331] 220: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
Jan 14 01:50:02 gizeh kernel: [13653.828336] 240: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
Jan 14 01:50:02 gizeh kernel: [13653.828342] 260: 00000000 00000000 fe020001 00000100 00000000 00000000 7e020001 00000100
Jan 14 01:50:02 gizeh kernel: [13653.828347] 280: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
Jan 14 01:50:02 gizeh kernel: [13653.828352] 2a0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
Jan 14 01:50:02 gizeh kernel: [13653.828358] 2c0: 00000000 00000000 00000000 00000000 00000000 00000001 00000001 00000001
Jan 14 01:50:02 gizeh kernel: [13653.828360] eth1: Dumping tx ring
Jan 14 01:50:02 gizeh kernel: [13653.828364] 000: 00000000 b7267402 20000029 // 00000000 b7267602 20000029 // 00000000 b7267802 20000029 // 00000000 b7267a02 20000029
Jan 14 01:50:02 gizeh kernel: [13653.828370] 004: 00000000 b7267c02 20000029 // 00000000 b7267e02 20000029 // 00000001 2498b202 20000029 // 00000001 2498aa02 20000029
Jan 14 01:50:02 gizeh kernel: [13653.828375] 008: 00000000 b736c002 20000029 // 00000000 b736c202 20000029 // 00000000 b736c402 20000029 // 00000000 b736c602 20000029
Jan 14 01:50:02 gizeh kernel: [13653.828380] 00c: 00000000 b736c802 20000029 // 00000000 b736ca02 20000029 // 00000000 b736cc02 20000029 // 00000000 b736ce02 20000029
Jan 14 01:50:02 gizeh kernel: [13653.828385] 010: 00000000 b736d002 20000029 // 00000000 b736d202 20000029 // 00000000 b736d402 20000029 // 00000000 b736d602 20000029
Jan 14 01:50:02 gizeh kernel: [13653.828390] 014: 00000000 b736d802 20000029 // 00000000 b736da02 20000029 // 00000000 b736dc02 20000029 // 00000000 b736de02 20000029
Jan 14 01:50:02 gizeh kernel: [13653.828395] 018: 00000000 b72a2002 20000029 // 00000000 b72a2202 20000029 // 00000000 b72a2402 20000029 // 00000000 b72a2602 20000029
Jan 14 01:50:02 gizeh kernel: [13653.828400] 01c: 00000000 b72a2802 20000029 // 00000000 b72a2a02 20000029 // 00000000 b72a2c02 20000029 // 00000000 b72a2e02 20000029
Jan 14 01:50:02 gizeh kernel: [13653.828405] 020: 00000000 b72a3002 20000029 // 00000000 b72a3202 20000029 // 00000000 b72a3402 20000029 // 00000000 b72a3602 20000029
Jan 14 01:50:02 gizeh kernel: [13653.828410] 024: 00000000 b72a3802 20000029 // 00000000 b72a3a02 20000029 // 00000000 b72a3c02 20000029 // 00000000 b72a3e02 20000029
Jan 14 01:50:02 gizeh kernel: [13653.828415] 028: 00000000 b72a4002 20000029 // 00000000 b72a4202 20000029 // 00000000 b72a4402 20000029 // 00000000 b72a4602 20000029
Jan 14 01:50:02 gizeh kernel: [13653.828420] 02c: 00000000 b72a4802 20000029 // 00000000 b72a4a02 20000029 // 00000000 b72a4c02 20000029 // 00000000 b72a4e02 20000029
Jan 14 01:50:02 gizeh kernel: [13653.828425] 030: 00000000 bf4150fa 20000040 // 00000000 bf4150ee 22000046 // 00000000 a465c8ee 22000046 // 00000001 26b710fe 00000000
Jan 14 01:50:02 gizeh kernel: [13653.828430] 034: 00000000 b6d01374 220005ee // 00000000 a465ed0a 00000000 // 00000000 cda7562e 220005ee // 00000001 26b73d0a 00000000
Jan 14 01:50:02 gizeh kernel: [13653.828435] 038: 00000000 bf6dfd77 00000000 // 00000000 cdac7000 220005b4 // 00000000 bf414cee 22000046 // 00000000 bf4148ee 22000046
Jan 14 01:50:02 gizeh kernel: [13653.828440] 03c: 00000000 bf415cfe 00000000 // 00000000 b6d0191c 200005ee // 00000000 bf41750a 00000000 // 00000000 cda75be2 00000000
Jan 14 01:50:02 gizeh kernel: [13653.828445] 040: 00000000 04d69000 200005ee // 00000000 bf41650a 00000000 // 00000000 cdac72f1 220005b4 // 00000000 cd9b30fe 00000000
Jan 14 01:50:02 gizeh kernel: [13653.828450] 044: 00000000 b6cefd94 00000000 // 00000000 b6d01000 200005ee // 00000000 b72d78ee 20000046 // 00000001 26b7150a 00000000
Jan 14 01:50:02 gizeh kernel: [13653.828455] 048: 00000000 cda7500b 200005ee // 00000000 b72d4d0a 00000000 // 00000000 cdac786b 200005b4 // 00000000 b72d5d0a 00000000
Jan 14 01:50:02 gizeh kernel: [13653.828460] 04c: 00000000 04cd5951 20000040 // 00000000 b72d710a 00000000 // 00000000 cdac7de5 00000000 // 00000000 bf435000 220005b4
Jan 14 01:50:02 gizeh kernel: [13653.828465] 050: 00000001 2a69e8ee 2c000041 // 00000000 a465cd0a 0c000035 // 00000000 bf6df2b8 a0000579 // 00000001 2a55050a 0c000035
Jan 14 01:50:02 gizeh kernel: [13653.828470] 054: 00000000 04cd5951 a0000004 // 00000000 a465dcfe 0c000041 // 00000000 b6cefd94 8000026b // 00000000 b6d01000 a000033b
Jan 14 01:50:02 gizeh kernel: [13653.828476] 058: 00000001 26b6d8ee 2c000041 // 00000001 2613290a 0c000035 // 00000000 cda7500b a00005b3 // 00000001 2a1f150a 0c000035
Jan 14 01:50:02 gizeh kernel: [13653.828481] 05c: 00000000 04cd5951 a0000004 // 00000000 b6dfb10a 0c000035 // 00000000 bf6df2b8 a0000579 // 00000000 b6dfa4ee 2c000041
Jan 14 01:50:02 gizeh kernel: [13653.828486] 060: 00000000 a465e8fe 0c000041 // 00000000 b6cefd94 8000026b // 00000000 b6d01000 a000033b // 00000000 b6df990a 0c000035
Jan 14 01:50:02 gizeh kernel: [13653.828491] 064: 00000000 04cd5951 a0000004 // 00000000 b728710a 0c000035 // 00000000 cda7500b a00005b3 // 00000000 b728410a 0c000035
Jan 14 01:50:02 gizeh kernel: [13653.828496] 068: 00000000 bf6df2b8 a0000579 // 00000000 b728590a 0c000035 // 00000000 04cd5951 a0000004 // 00000000 a465d4fe 0c000041
Jan 14 01:50:02 gizeh kernel: [13653.828501] 06c: 00000000 b6cefd94 8000026b // 00000000 b6d01000 a000033b // 00000000 b7287d0a 0c000035 // 00000000 cda7500b a00005b3
Jan 14 01:50:02 gizeh kernel: [13653.828506] 070: 00000000 b728450a 0c000035 // 00000000 bf6df2b8 a0000579 // 00000000 b728510a 0c000035 // 00000000 04cd5951 a0000004
Jan 14 01:50:02 gizeh kernel: [13653.828512] 074: 00000000 a465e4fe 0c000041 // 00000000 b6cefd94 8000026b // 00000000 b6d01000 a000033b // 00000000 b7284d0a 0c000035
Jan 14 01:50:02 gizeh kernel: [13653.828517] 078: 00000000 cda7500b a00005b3 // 00000001 26b7310a 0c000035 // 00000000 04cd5951 a0000004 // 00000001 26b7290a 0c000035
Jan 14 01:50:02 gizeh kernel: [13653.828522] 07c: 00000000 bf6df2b8 a0000579 // 00000000 a465d0fe 0c000041 // 00000000 b6cefd94 8000026b // 00000000 b6d01000 a000033b
Jan 14 01:50:02 gizeh kernel: [13653.828527] 080: 00000001 2f80e50a 0c000035 // 00000000 cda7500b a00005b3 // 00000001 2f80e10a 0c000035 // 00000000 04cd5951 a0000004
Jan 14 01:50:02 gizeh kernel: [13653.828532] 084: 00000001 2a48610a 0c000035 // 00000000 bf6df2b8 a0000579 // 00000000 b72fb002 20000029 // 00000000 b72fb202 20000029
Jan 14 01:50:02 gizeh kernel: [13653.828537] 088: 00000000 b72fb602 20000029 // 00000000 b72fba02 20000029 // 00000000 b72faa02 20000029 // 00000000 b72fa402 20000029
Jan 14 01:50:02 gizeh kernel: [13653.828542] 08c: 00000000 b72fbc02 20000029 // 00000000 b72fa002 20000029 // 00000000 b72fbe02 20000029 // 00000000 b72fae02 20000029
Jan 14 01:50:02 gizeh kernel: [13653.828547] 090: 00000000 b72fa802 20000029 // 00000000 b72fa602 20000029 // 00000001 29f47202 20000029 // 00000001 29f46402 20000029
Jan 14 01:50:02 gizeh kernel: [13653.828552] 094: 00000001 29f47602 20000029 // 00000001 29f46002 20000029 // 00000001 29f46202 20000029 // 00000001 26a2f402 20000029
Jan 14 01:50:02 gizeh kernel: [13653.828557] 098: 00000001 26a2e602 20000029 // 00000001 26a2e202 20000029 // 00000001 26a2e002 20000029 // 00000001 26a2ea02 20000029
Jan 14 01:50:02 gizeh kernel: [13653.828562] 09c: 00000001 26a2ec02 20000029 // 00000001 26a2fe02 20000029 // 00000001 26afe202 20000029 // 00000001 26afea02 20000029
Jan 14 01:50:02 gizeh kernel: [13653.828567] 0a0: 00000001 26afe402 20000029 // 00000001 26afec02 20000029 // 00000001 26affe02 20000029 // 00000001 29826402 20000029
Jan 14 01:50:02 gizeh kernel: [13653.828572] 0a4: 00000001 29826802 20000029 // 00000001 29bcbe02 20000029 // 00000001 29bca802 20000029 // 00000001 269b9c02 20000029
Jan 14 01:50:02 gizeh kernel: [13653.828578] 0a8: 00000001 269b8802 20000029 // 00000001 269b9e02 20000029 // 00000001 26859e02 20000029 // 00000001 26858802 20000029
Jan 14 01:50:02 gizeh kernel: [13653.828583] 0ac: 00000001 26859602 20000029 // 00000001 26858402 20000029 // 00000001 26859002 20000029 // 00000001 26859c02 20000029
Jan 14 01:50:02 gizeh kernel: [13653.828588] 0b0: 00000001 26859202 20000029 // 00000001 26858202 20000029 // 00000001 26859402 20000029 // 00000001 26859802 20000029
Jan 14 01:50:02 gizeh kernel: [13653.828593] 0b4: 00000001 26858c02 20000029 // 00000001 2907f402 20000029 // 00000001 24932202 20000029 // 00000001 24933e02 20000029
Jan 14 01:50:02 gizeh kernel: [13653.828598] 0b8: 00000001 2a2b2202 20000029 // 00000001 2a0c1c02 20000029 // 00000001 26aff402 20000029 // 00000001 26affa02 20000029
Jan 14 01:50:02 gizeh kernel: [13653.828603] 0bc: 00000000 b7210002 20000029 // 00000000 b7210202 20000029 // 00000000 b7210402 20000029 // 00000000 b7210602 20000029
Jan 14 01:50:02 gizeh kernel: [13653.828608] 0c0: 00000000 b7210802 20000029 // 00000000 b7210a02 20000029 // 00000000 b7210c02 20000029 // 00000000 b7210e02 20000029
Jan 14 01:50:02 gizeh kernel: [13653.828613] 0c4: 00000000 b7211002 20000029 // 00000000 b7211202 20000029 // 00000000 b7211402 20000029 // 00000000 b7211602 20000029
Jan 14 01:50:02 gizeh kernel: [13653.828618] 0c8: 00000000 b7211802 20000029 // 00000000 b7211a02 20000029 // 00000000 b7211c02 20000029 // 00000000 b7211e02 20000029
Jan 14 01:50:02 gizeh kernel: [13653.828623] 0cc: 00000001 2a6c4a02 20000029 // 00000000 b6c26002 20000029 // 00000000 b6c26202 20000029 // 00000000 b6c26402 20000029
Jan 14 01:50:02 gizeh kernel: [13653.828628] 0d0: 00000000 b6c26602 20000029 // 00000000 b6c26802 20000029 // 00000000 b6c26a02 20000029 // 00000000 b6c26c02 20000029
Jan 14 01:50:02 gizeh kernel: [13653.828633] 0d4: 00000000 b6c26e02 20000029 // 00000000 b6c27002 20000029 // 00000000 b6c27202 20000029 // 00000000 b6c27402 20000029
Jan 14 01:50:02 gizeh kernel: [13653.828638] 0d8: 00000000 b6c27602 20000029 // 00000000 b6c27802 20000029 // 00000000 b6c27a02 20000029 // 00000000 b6c27c02 20000029
Jan 14 01:50:02 gizeh kernel: [13653.828643] 0dc: 00000000 b6c27e02 20000029 // 00000000 b70c0002 20000029 // 00000000 b70c0202 20000029 // 00000000 b70c0402 20000029
Jan 14 01:50:02 gizeh kernel: [13653.828648] 0e0: 00000000 b70c0602 20000029 // 00000000 b70c0802 20000029 // 00000000 b70c0a02 20000029 // 00000000 b70c0c02 20000029
Jan 14 01:50:02 gizeh kernel: [13653.828653] 0e4: 00000000 b70c0e02 20000029 // 00000000 b70c1002 20000029 // 00000000 b70c1202 20000029 // 00000000 b70c1402 20000029
Jan 14 01:50:02 gizeh kernel: [13653.828659] 0e8: 00000000 b70c1602 20000029 // 00000001 2498a202 20000029 // 00000001 2498a402 20000029 // 00000001 2498ba02 20000029
Jan 14 01:50:02 gizeh kernel: [13653.828664] 0ec: 00000000 b70c1802 20000029 // 00000000 b70c1a02 20000029 // 00000000 b70c1c02 20000029 // 00000000 b70c1e02 20000029
Jan 14 01:50:02 gizeh kernel: [13653.828669] 0f0: 00000000 b7266002 20000029 // 00000000 b7266202 20000029 // 00000000 37aae002 20000029 // 00000000 37aae402 20000029
Jan 14 01:50:02 gizeh kernel: [13653.828673] 0f4: 00000000 37aae602 20000029 // 00000000 37aaea02 20000029 // 00000000 37aaec02 20000029 // 00000000 37aaee02 20000029
Jan 14 01:50:02 gizeh kernel: [13653.828678] 0f8: 00000000 b7266402 20000029 // 00000000 b7266602 20000029 // 00000000 b7266802 20000029 // 00000000 b7266a02 20000029
Jan 14 01:50:02 gizeh kernel: [13653.828683] 0fc: 00000000 b7266c02 20000029 // 00000000 b7266e02 20000029 // 00000000 b7267002 20000029 // 00000000 b7267202 20000029
Jan 14 03:10:22 gizeh kernel: [18473.828017] eth1: Got tx_timeout. irq: 00000036
Jan 14 03:10:22 gizeh kernel: [18473.828021] eth1: Ring at 12a73c000
Jan 14 03:10:22 gizeh kernel: [18473.828023] eth1: Dumping tx registers
Jan 14 03:10:22 gizeh kernel: [18473.828028]   0: 00000036 00000000 00000003 000a000d 00000000 00000000 00000000 00000000
Jan 14 03:10:22 gizeh kernel: [18473.828034]  20: 06255300 ff701365 00000000 00000000 00000000 00000000 00000000 00000000
Jan 14 03:10:22 gizeh kernel: [18473.828039]  40: 0420e20e 0000a855 00002e20 00000000 00000000 00000000 00000000 00000000
Jan 14 03:10:22 gizeh kernel: [18473.828045]  60: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
Jan 14 03:10:22 gizeh kernel: [18473.828050]  80: 003b0f3c 00c02601 00040000 007f0020 0000061c 00000001 00200000 80007fae
Jan 14 03:10:22 gizeh kernel: [18473.828056]  a0: 0016070f 00000016 d2091100 0000b21b 00000001 00000000 2d00cccd 00004ce4
Jan 14 03:10:22 gizeh kernel: [18473.828061]  c0: 10000001 00000001 00000001 00000001 00000001 00000001 00000001 00000001
Jan 14 03:10:22 gizeh kernel: [18473.828067]  e0: 00000001 00000001 00000001 00000001 00000001 00000001 00000001 00000001
Jan 14 03:10:22 gizeh kernel: [18473.828072] 100: 2a73e000 2a73c000 01ff00ff 00002601 00010064 00000000 0000002a 2a73e600
Jan 14 03:10:22 gizeh kernel: [18473.828078] 120: 2a73d4c0 b72a5e40 a000ffeb 117bf040 8000061c 2a73e604 2a73d374 01e08000
Jan 14 03:10:22 gizeh kernel: [18473.828083] 140: 00304120 80002600 00000001 00000001 00000000 00000000 00000000 00000000
Jan 14 03:10:22 gizeh kernel: [18473.828089] 160: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
Jan 14 03:10:22 gizeh kernel: [18473.828095] 180: 00000016 00000008 0194796d 00008103 0000002a 00004000 0194000f 00000003
Jan 14 03:10:22 gizeh kernel: [18473.828100] 1a0: 00000016 00000008 0194796d 00008103 0000002a 00004000 0194000f 00000003
Jan 14 03:10:22 gizeh kernel: [18473.828106] 1c0: 00000016 00000008 0194796d 00008103 0000002a 00004000 0194000f 00000003
Jan 14 03:10:22 gizeh kernel: [18473.828111] 1e0: 00000016 00000008 0194796d 00008103 0000002a 00004000 0194000f 00000003
Jan 14 03:10:22 gizeh kernel: [18473.828117] 200: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
Jan 14 03:10:22 gizeh kernel: [18473.828122] 220: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
Jan 14 03:10:22 gizeh kernel: [18473.828127] 240: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
Jan 14 03:10:22 gizeh kernel: [18473.828133] 260: 00000000 00000000 fe020001 00000100 00000000 00000000 7e020001 00000100
Jan 14 03:10:22 gizeh kernel: [18473.828138] 280: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
Jan 14 03:10:22 gizeh kernel: [18473.828143] 2a0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
Jan 14 03:10:22 gizeh kernel: [18473.828149] 2c0: 00000000 00000000 00000000 00000000 00000000 00000001 00000001 00000001
Jan 14 03:10:22 gizeh kernel: [18473.828151] eth1: Dumping tx ring
Jan 14 03:10:22 gizeh kernel: [18473.828155] 000: 00000000 b736d402 20000029 // 00000000 b736d602 20000029 // 00000000 b736d802 20000029 // 00000000 b736da02 20000029
Jan 14 03:10:22 gizeh kernel: [18473.828161] 004: 00000000 b736de02 20000029 // 00000000 b736dc02 20000029 // 00000000 b734a202 20000029 // 00000000 b736c202 20000029
Jan 14 03:10:22 gizeh kernel: [18473.828166] 008: 00000000 b7210002 20000029 // 00000000 b7210402 20000029 // 00000000 b7210602 20000029 // 00000000 b7210a02 20000029
Jan 14 03:10:22 gizeh kernel: [18473.828171] 00c: 00000000 b7210c02 20000029 // 00000000 b7211002 20000029 // 00000000 b7210e02 20000029 // 00000000 b7211202 20000029
Jan 14 03:10:22 gizeh kernel: [18473.828176] 010: 00000000 b7211402 20000029 // 00000000 b7211602 20000029 // 00000000 b7211802 20000029 // 00000000 b7211a02 20000029
Jan 14 03:10:22 gizeh kernel: [18473.828181] 014: 00000000 b7211c02 20000029 // 00000000 b7211e02 20000029 // 00000000 b72a2202 20000029 // 00000000 b7210202 20000029
Jan 14 03:10:22 gizeh kernel: [18473.828186] 018: 00000000 b6c26002 20000029 // 00000000 b6c26402 20000029 // 00000000 b6c26802 20000029 // 00000000 b6c26a02 20000029
Jan 14 03:10:22 gizeh kernel: [18473.828191] 01c: 00000000 b6c26c02 20000029 // 00000000 b6c26e02 20000029 // 00000000 b6c27002 20000029 // 00000000 b6c27202 20000029
Jan 14 03:10:22 gizeh kernel: [18473.828196] 020: 00000000 b6c27402 20000029 // 00000000 b6c27602 20000029 // 00000000 b6c27802 20000029 // 00000000 b6c27a02 20000029
Jan 14 03:10:22 gizeh kernel: [18473.828201] 024: 00000000 b6c27c02 20000029 // 00000000 b6c27e02 20000029 // 00000000 b7210802 20000029 // 00000000 b6c26602 20000029
Jan 14 03:10:22 gizeh kernel: [18473.828206] 028: 00000000 b70c0002 20000029 // 00000000 b70c0602 20000029 // 00000000 b70c0802 20000029 // 00000000 b70c0a02 20000029
Jan 14 03:10:22 gizeh kernel: [18473.828211] 02c: 00000000 b70c0c02 20000029 // 00000000 b70c0e02 20000029 // 00000000 b70c1002 20000029 // 00000000 b70c1202 20000029
Jan 14 03:10:22 gizeh kernel: [18473.828216] 030: 00000000 b70c1402 20000029 // 00000000 b70c1602 20000029 // 00000000 b70c1a02 20000029 // 00000000 b70c1c02 20000029
Jan 14 03:10:22 gizeh kernel: [18473.828221] 034: 00000000 b70c1e02 20000029 // 00000000 b736c402 20000029 // 00000000 b70c0402 20000029 // 00000000 cdb26002 20000029
Jan 14 03:10:22 gizeh kernel: [18473.828226] 038: 00000000 cdb26602 20000029 // 00000000 cdb26802 20000029 // 00000000 cdb26a02 20000029 // 00000000 cdb26c02 20000029
Jan 14 03:10:22 gizeh kernel: [18473.828231] 03c: 00000000 cdb26e02 20000029 // 00000000 cdb27002 20000029 // 00000000 cdb27202 20000029 // 00000000 cdb27402 20000029
Jan 14 03:10:22 gizeh kernel: [18473.828236] 040: 00000000 cdb27602 20000029 // 00000000 cdb27802 20000029 // 00000000 cdb27a02 20000029 // 00000000 cdb27c02 20000029
Jan 14 03:10:22 gizeh kernel: [18473.828240] 044: 00000000 cdb27e02 20000029 // 00000000 b6c26202 20000029 // 00000000 b70c1802 20000029 // 00000000 cdb26402 20000029
Jan 14 03:10:22 gizeh kernel: [18473.828246] 048: 00000000 b7304002 20000029 // 00000000 b7304402 20000029 // 00000000 b7304802 20000029 // 00000000 b7304a02 20000029
Jan 14 03:10:22 gizeh kernel: [18473.828250] 04c: 00000000 b7304c02 20000029 // 00000000 b7304e02 20000029 // 00000000 b7305002 20000029 // 00000000 00000000 00000000
Jan 14 03:10:22 gizeh kernel: [18473.828256] 050: 00000000 b72a5002 00000000 // 00000000 20000040 a0000029 // 00000000 22000040 a0000029 // 00000000 22000040 a0000029
Jan 14 03:10:22 gizeh kernel: [18473.828261] 054: 00000000 22000040 a0000029 // 00000000 22000040 a0000029 // 00000000 22000040 a0000029 // 00000000 22000040 a0000029
Jan 14 03:10:22 gizeh kernel: [18473.828266] 058: 00000000 22000040 a0000029 // 00000000 22000040 a0000029 // 00000000 22000040 a0000029 // 00000000 22000040 a0000029
Jan 14 03:10:22 gizeh kernel: [18473.828271] 05c: 00000000 22000040 a0000029 // 00000000 22000040 a0000029 // 00000000 22000040 a0000029 // 00000000 22000040 a0000029
Jan 14 03:10:22 gizeh kernel: [18473.828276] 060: 00000001 2498b202 20000029 // 00000001 2498aa02 20000029 // 00000001 2498a202 20000029 // 00000001 2498a402 20000029
Jan 14 03:10:22 gizeh kernel: [18473.828281] 064: 00000001 2498ba02 20000029 // 00000001 2a6c4a02 20000029 // 00000001 26afe202 20000029 // 00000001 26afea02 20000029
Jan 14 03:10:22 gizeh kernel: [18473.828286] 068: 00000001 26afe402 20000029 // 00000001 26afec02 20000029 // 00000001 26affe02 20000029 // 00000001 26aff402 20000029
Jan 14 03:10:22 gizeh kernel: [18473.828291] 06c: 00000001 26affa02 20000029 // 00000001 2a0c1c02 20000029 // 00000001 2a2b2202 20000029 // 00000001 24932202 20000029
Jan 14 03:10:22 gizeh kernel: [18473.828296] 070: 00000001 24933e02 20000029 // 00000001 2907f402 20000029 // 00000001 26859e02 20000029 // 00000001 26858802 20000029
Jan 14 03:10:22 gizeh kernel: [18473.828301] 074: 00000001 26859602 20000029 // 00000001 26858402 20000029 // 00000001 26859002 20000029 // 00000001 26859c02 20000029
Jan 14 03:10:22 gizeh kernel: [18473.828306] 078: 00000001 26859202 20000029 // 00000001 26858202 20000029 // 00000001 26859402 20000029 // 00000001 26859802 20000029
Jan 14 03:10:22 gizeh kernel: [18473.828311] 07c: 00000001 26858c02 20000029 // 00000001 269b9c02 20000029 // 00000001 269b8802 20000029 // 00000001 269b9e02 20000029
Jan 14 03:10:22 gizeh kernel: [18473.828316] 080: 00000001 29bcbe02 20000029 // 00000001 29bca802 20000029 // 00000001 29826402 20000029 // 00000001 29826802 20000029
Jan 14 03:10:22 gizeh kernel: [18473.828321] 084: 00000001 26a2f402 20000029 // 00000001 26a2e602 20000029 // 00000001 26a2e202 20000029 // 00000001 26a2e002 20000029
Jan 14 03:10:22 gizeh kernel: [18473.828326] 088: 00000001 26a2ea02 20000029 // 00000001 26a2ec02 20000029 // 00000001 29f47202 20000029 // 00000001 29f46402 20000029
Jan 14 03:10:22 gizeh kernel: [18473.828331] 08c: 00000001 29f47602 20000029 // 00000001 29f46002 20000029 // 00000001 29f46202 20000029 // 00000000 b72fb002 20000029
Jan 14 03:10:22 gizeh kernel: [18473.828336] 090: 00000000 b72fb202 20000029 // 00000000 b72fb602 20000029 // 00000000 b72fba02 20000029 // 00000000 b72faa02 20000029
Jan 14 03:10:22 gizeh kernel: [18473.828341] 094: 00000000 b72fa402 20000029 // 00000000 b72fbc02 20000029 // 00000000 b72fa002 20000029 // 00000000 b72fbe02 20000029
Jan 14 03:10:22 gizeh kernel: [18473.828346] 098: 00000000 b72fae02 20000029 // 00000000 37aaf202 20000029 // 00000000 37aaf402 20000029 // 00000000 37aaf602 20000029
Jan 14 03:10:22 gizeh kernel: [18473.828351] 09c: 00000000 37aaf802 20000029 // 00000000 37aafa02 20000029 // 00000000 37aafc02 20000029 // 00000000 37aafe02 20000029
Jan 14 03:10:22 gizeh kernel: [18473.828356] 0a0: 00000000 37aaf002 20000029 // 00000000 37aae002 20000029 // 00000000 37aae402 20000029 // 00000000 37aae602 20000029
Jan 14 03:10:22 gizeh kernel: [18473.828361] 0a4: 00000000 37aaea02 20000029 // 00000000 37aaec02 20000029 // 00000000 37aaee02 20000029 // 00000001 26a2fe02 20000029
Jan 14 03:10:22 gizeh kernel: [18473.828366] 0a8: 00000001 24932a02 20000029 // 00000001 24933602 20000029 // 00000001 24933202 20000029 // 00000001 24933802 20000029
Jan 14 03:10:22 gizeh kernel: [18473.828371] 0ac: 00000001 269b9802 20000029 // 00000001 269b8e02 20000029 // 00000001 269b9a02 20000029 // 00000001 2498a002 20000029
Jan 14 03:10:22 gizeh kernel: [18473.828376] 0b0: 00000001 29bcb402 20000029 // 00000001 24932602 20000029 // 00000001 24932402 20000029 // 00000001 269b8402 20000029
Jan 14 03:10:22 gizeh kernel: [18473.828381] 0b4: 00000000 37aae802 20000029 // 00000001 24933c02 20000029 // 00000001 269b9002 20000029 // 00000001 26afe002 20000029
Jan 14 03:10:22 gizeh kernel: [18473.828386] 0b8: 00000000 b7256002 20000029 // 00000000 b7256402 20000029 // 00000000 b7256802 20000029 // 00000000 b7256a02 20000029
Jan 14 03:10:22 gizeh kernel: [18473.828391] 0bc: 00000000 b7256c02 20000029 // 00000000 b7256e02 20000029 // 00000000 b7257002 20000029 // 00000000 b7257202 20000029
Jan 14 03:10:22 gizeh kernel: [18473.828396] 0c0: 00000000 b7257402 20000029 // 00000000 b7257602 20000029 // 00000000 b7257802 20000029 // 00000000 b7257a02 20000029
Jan 14 03:10:22 gizeh kernel: [18473.828401] 0c4: 00000000 b7257c02 20000029 // 00000000 b7257e02 20000029 // 00000001 24932c02 20000029 // 00000000 b7256602 20000029
Jan 14 03:10:22 gizeh kernel: [18473.828406] 0c8: 00000000 b734a002 20000029 // 00000000 b734a602 20000029 // 00000000 b734a802 20000029 // 00000000 b734aa02 20000029
Jan 14 03:10:22 gizeh kernel: [18473.828411] 0cc: 00000000 b734ac02 20000029 // 00000000 b734ae02 20000029 // 00000000 b734b002 20000029 // 00000000 b734b202 20000029
Jan 14 03:10:22 gizeh kernel: [18473.828416] 0d0: 00000000 b734b402 20000029 // 00000000 b734b602 20000029 // 00000000 b734b802 20000029 // 00000000 b734ba02 20000029
Jan 14 03:10:22 gizeh kernel: [18473.828421] 0d4: 00000000 b734bc02 20000029 // 00000000 b734be02 20000029 // 00000000 37aae202 20000029 // 00000000 b734a402 20000029
Jan 14 03:10:22 gizeh kernel: [18473.828426] 0d8: 00000000 b7266602 20000029 // 00000000 b7266802 20000029 // 00000000 b7266a02 20000029 // 00000000 b7266c02 20000029
Jan 14 03:10:22 gizeh kernel: [18473.828431] 0dc: 00000000 b7266e02 20000029 // 00000000 b7267002 20000029 // 00000000 b7267202 20000029 // 00000000 b7267402 20000029
Jan 14 03:10:22 gizeh kernel: [18473.828436] 0e0: 00000000 b7267602 20000029 // 00000000 b7267802 20000029 // 00000000 b7267a02 20000029 // 00000000 b7267c02 20000029
Jan 14 03:10:22 gizeh kernel: [18473.828441] 0e4: 00000000 b7266402 20000029 // 00000000 b7267e02 20000029 // 00000000 b7256202 20000029 // 00000000 b7266202 20000029
Jan 14 03:10:22 gizeh kernel: [18473.828446] 0e8: 00000000 b72a2002 20000029 // 00000000 b72a2402 20000029 // 00000000 b72a2802 20000029 // 00000000 b72a2a02 20000029
Jan 14 03:10:22 gizeh kernel: [18473.828451] 0ec: 00000000 b72a2c02 20000029 // 00000000 b72a2e02 20000029 // 00000000 b72a3002 20000029 // 00000000 b72a3202 20000029
Jan 14 03:10:22 gizeh kernel: [18473.828456] 0f0: 00000000 b72a3402 20000029 // 00000000 b72a3602 20000029 // 00000000 b72a3802 20000029 // 00000000 b72a3a02 20000029
Jan 14 03:10:22 gizeh kernel: [18473.828461] 0f4: 00000000 b72a3c02 20000029 // 00000000 b72a3e02 20000029 // 00000000 b7266002 20000029 // 00000000 b72a2602 20000029
Jan 14 03:10:22 gizeh kernel: [18473.828466] 0f8: 00000000 b736c002 20000029 // 00000000 b736c602 20000029 // 00000000 b736c802 20000029 // 00000000 b736ca02 20000029
Jan 14 03:10:22 gizeh kernel: [18473.828470] 0fc: 00000000 b736cc02 20000029 // 00000000 b736ce02 20000029 // 00000000 b736d002 20000029 // 00000000 b736d202 20000029
Jan 14 05:03:47 gizeh kernel: [25278.836016] eth1: Got tx_timeout. irq: 00000036
Jan 14 05:03:47 gizeh kernel: [25278.836019] eth1: Ring at 12a73c000
Jan 14 05:03:47 gizeh kernel: [25278.836021] eth1: Dumping tx registers
Jan 14 05:03:47 gizeh kernel: [25278.836026]   0: 00000036 00000000 00000003 0002000d 00000000 00000000 00000000 00000000
Jan 14 05:03:47 gizeh kernel: [25278.836032]  20: 06255300 ff701365 00000000 00000000 00000000 00000000 00000000 00000000
Jan 14 05:03:47 gizeh kernel: [25278.836038]  40: 0420e20e 0000a855 00002e20 00000000 00000000 00000000 00000000 00000000
Jan 14 05:03:47 gizeh kernel: [25278.836043]  60: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
Jan 14 05:03:47 gizeh kernel: [25278.836049]  80: 003b0f3c 00000000 00040000 007f0020 0000061c 00000001 00200000 80007fae
Jan 14 05:03:47 gizeh kernel: [25278.836054]  a0: 0016070f 00000016 d2091100 0000b21b 00000001 00000000 2d00cccd 00004ce4
Jan 14 05:03:47 gizeh kernel: [25278.836059]  c0: 10000001 00000001 00000001 00000001 00000001 00000001 00000001 00000001
Jan 14 05:03:47 gizeh kernel: [25278.836065]  e0: 00000001 00000001 00000001 00000001 00000001 00000001 00000001 00000001
Jan 14 05:03:47 gizeh kernel: [25278.836070] 100: 2a73e000 2a73c000 01ff00ff 00000000 00010064 00000000 00000026 2a73e700
Jan 14 05:03:47 gizeh kernel: [25278.836076] 120: 2a73d4c0 00002c00 b7302a02 117bf040 8000061c 2a73e614 2a73d374 01e08000
Jan 14 05:03:47 gizeh kernel: [25278.836081] 140: 00304120 00002600 00000001 00000001 00000000 00000000 00000000 00000000
Jan 14 05:03:47 gizeh kernel: [25278.836087] 160: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
Jan 14 05:03:47 gizeh kernel: [25278.836092] 180: 00000016 00000008 0194796d 00008103 0000002a 00004000 0194000f 00000003
Jan 14 05:03:47 gizeh kernel: [25278.836098] 1a0: 00000016 00000008 0194796d 00008103 0000002a 00004000 0194000f 00000003
Jan 14 05:03:47 gizeh kernel: [25278.836103] 1c0: 00000016 00000008 0194796d 00008103 0000002a 00004000 0194000f 00000003
Jan 14 05:03:47 gizeh kernel: [25278.836109] 1e0: 00000016 00000008 0194796d 00008103 0000002a 00004000 0194000f 00000003
Jan 14 05:03:47 gizeh kernel: [25278.836114] 200: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
Jan 14 05:03:47 gizeh kernel: [25278.836119] 220: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
Jan 14 05:03:47 gizeh kernel: [25278.836125] 240: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
Jan 14 05:03:47 gizeh kernel: [25278.836130] 260: 00000000 00000000 fe020001 00000100 00000000 00000000 7e020001 00000100
Jan 14 05:03:47 gizeh kernel: [25278.836136] 280: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
Jan 14 05:03:47 gizeh kernel: [25278.836141] 2a0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
Jan 14 05:03:47 gizeh kernel: [25278.836147] 2c0: 00000000 00000000 00000000 00000000 00000000 00000001 00000001 00000001
Jan 14 05:03:47 gizeh kernel: [25278.836149] eth1: Dumping tx ring
Jan 14 05:03:47 gizeh kernel: [25278.836153] 000: 00000000 b72a2802 20000029 // 00000000 b72a2a02 20000029 // 00000000 b72a2c02 20000029 // 00000000 b72a2e02 20000029
Jan 14 05:03:47 gizeh kernel: [25278.836158] 004: 00000000 b72a3002 20000029 // 00000000 b72a3202 20000029 // 00000000 b72a3402 20000029 // 00000000 b72a3602 20000029
Jan 14 05:03:47 gizeh kernel: [25278.836163] 008: 00000000 b72a3802 20000029 // 00000000 b72a3a02 20000029 // 00000000 b72a3c02 20000029 // 00000000 b72a3e02 20000029
Jan 14 05:03:47 gizeh kernel: [25278.836168] 00c: 00000000 b72a2602 20000029 // 00000000 b736c002 20000029 // 00000000 b736c402 20000029 // 00000000 b736c802 20000029
Jan 14 05:03:47 gizeh kernel: [25278.836173] 010: 00000000 b736ca02 20000029 // 00000000 b736cc02 20000029 // 00000000 b736ce02 20000029 // 00000000 b736d002 20000029
Jan 14 05:03:47 gizeh kernel: [25278.836178] 014: 00000000 b736d202 20000029 // 00000000 b736d402 20000029 // 00000000 b736d602 20000029 // 00000000 b736d802 20000029
Jan 14 05:03:47 gizeh kernel: [25278.836183] 018: 00000000 b736da02 20000029 // 00000000 b736dc02 20000029 // 00000000 b736de02 20000029 // 00000000 b72a2202 20000029
Jan 14 05:03:47 gizeh kernel: [25278.836188] 01c: 00000000 b7256002 20000029 // 00000000 b7266202 20000029 // 00000000 b7210002 20000029 // 00000000 b7210402 20000029
Jan 14 05:03:47 gizeh kernel: [25278.836193] 020: 00000000 b7210602 20000029 // 00000000 b7210a02 20000029 // 00000000 b7210c02 20000029 // 00000000 b7210e02 20000029
Jan 14 05:03:47 gizeh kernel: [25278.836198] 024: 00000000 b7211002 20000029 // 00000000 b7211202 20000029 // 00000000 b7211402 20000029 // 00000000 b7211602 20000029
Jan 14 05:03:47 gizeh kernel: [25278.836203] 028: 00000000 b7211802 20000029 // 00000000 b7211a02 20000029 // 00000000 b7211c02 20000029 // 00000000 b7211e02 20000029
Jan 14 05:03:47 gizeh kernel: [25278.836208] 02c: 00000000 b736c602 20000029 // 00000000 b7210802 20000029 // 00000000 b6c26002 20000029 // 00000000 b6c26402 20000029
Jan 14 05:03:47 gizeh kernel: [25278.836213] 030: 00000000 b6c26802 20000029 // 00000000 b6c26a02 20000029 // 00000000 b6c26c02 20000029 // 00000000 b6c26e02 20000029
Jan 14 05:03:47 gizeh kernel: [25278.836218] 034: 00000000 b6c27002 20000029 // 00000000 b6c27202 20000029 // 00000000 b6c27402 20000029 // 00000000 b6c27602 20000029
Jan 14 05:03:47 gizeh kernel: [25278.836223] 038: 00000000 b6c27802 20000029 // 00000000 b6c27a02 20000029 // 00000000 b6c27c02 20000029 // 00000000 b6c27e02 20000029
Jan 14 05:03:47 gizeh kernel: [25278.836228] 03c: 00000000 b7210202 20000029 // 00000000 b6c26602 20000029 // 00000000 b734a002 20000029 // 00000000 b734a802 20000029
Jan 14 05:03:47 gizeh kernel: [25278.836233] 040: 00000000 b734aa02 20000029 // 00000000 b734ac02 20000029 // 00000000 b734a602 20000029 // 00000000 b734ae02 20000029
Jan 14 05:03:47 gizeh kernel: [25278.836238] 044: 00000000 b734b002 20000029 // 00000000 b734b202 20000029 // 00000000 b734b402 20000029 // 00000000 b734b602 20000029
Jan 14 05:03:47 gizeh kernel: [25278.836243] 048: 00000000 b734b802 20000029 // 00000000 b734ba02 20000029 // 00000000 b734bc02 20000029 // 00000000 b734be02 20000029
Jan 14 05:03:47 gizeh kernel: [25278.836248] 04c: 00000000 b736c202 20000029 // 00000000 b734a402 20000029 // 00000000 b70c0002 20000029 // 00000000 b70c0402 20000029
Jan 14 05:03:47 gizeh kernel: [25278.836253] 050: 00000000 b70c0602 20000029 // 00000000 b70c0a02 20000029 // 00000000 b70c0c02 20000029 // 00000000 b70c0e02 20000029
Jan 14 05:03:47 gizeh kernel: [25278.836258] 054: 00000000 b70c1002 20000029 // 00000000 b70c1202 20000029 // 00000000 b70c1402 20000029 // 00000000 b70c1802 20000029
Jan 14 05:03:47 gizeh kernel: [25278.836263] 058: 00000000 b70c1a02 20000029 // 00000000 b70c1c02 20000029 // 00000000 b70c1e02 20000029 // 00000000 b6c26202 20000029
Jan 14 05:03:47 gizeh kernel: [25278.836268] 05c: 00000000 b70c0802 20000029 // 00000000 b6c7e002 20000029 // 00000000 b6c7e402 20000029 // 00000000 00000000 00000000
Jan 14 05:03:47 gizeh kernel: [25278.836273] 060: 00000000 22000040 a0000029 // 00000000 b7305602 a0000029 // 00000000 b7305802 a0000029 // 00000000 b7305a02 a0000029
Jan 14 05:03:47 gizeh kernel: [25278.836278] 064: 00000000 b7305c02 a0000029 // 00000000 b7305e02 a0000029 // 00000000 b7304002 a0000029 // 00000000 b7304402 a0000029
Jan 14 05:03:47 gizeh kernel: [25278.836283] 068: 00000000 b7304802 a0000029 // 00000000 b7304a02 a0000029 // 00000000 b7304c02 a0000029 // 00000000 b7304e02 a0000029
Jan 14 05:03:47 gizeh kernel: [25278.836288] 06c: 00000000 b7305002 a0000029 // 00000000 b7305402 a0000029 // 00000001 24932202 a0000029 // 00000001 24932a02 a0000029
Jan 14 05:03:47 gizeh kernel: [25278.836293] 070: 00000001 24933202 20000029 // 00000001 24933802 20000029 // 00000001 24932602 20000029 // 00000001 26afe402 20000029
Jan 14 05:03:47 gizeh kernel: [25278.836298] 074: 00000001 26afec02 20000029 // 00000001 26affe02 20000029 // 00000001 26aff402 20000029 // 00000001 26affa02 20000029
Jan 14 05:03:47 gizeh kernel: [25278.836303] 078: 00000001 26afe002 20000029 // 00000001 269b9c02 20000029 // 00000001 269b9e02 20000029 // 00000001 269b9802 20000029
Jan 14 05:03:47 gizeh kernel: [25278.836308] 07c: 00000001 269b9a02 20000029 // 00000001 269b8402 20000029 // 00000001 269b9002 20000029 // 00000001 29bcbe02 20000029
Jan 14 05:03:47 gizeh kernel: [25278.836313] 080: 00000001 29bcb402 20000029 // 00000001 2498b202 20000029 // 00000001 2498a402 20000029 // 00000001 2498ba02 20000029
Jan 14 05:03:47 gizeh kernel: [25278.836318] 084: 00000001 2498a002 20000029 // 00000001 26a2f402 20000029 // 00000001 26a2e202 20000029 // 00000001 26a2e002 20000029
Jan 14 05:03:47 gizeh kernel: [25278.836323] 088: 00000001 26a2ec02 20000029 // 00000001 26a2fe02 20000029 // 00000001 29f47202 20000029 // 00000001 29f46002 20000029
Jan 14 05:03:47 gizeh kernel: [25278.836329] 08c: 00000001 29f46202 20000029 // 00000001 29826402 20000029 // 00000001 26858802 20000029 // 00000001 26859602 20000029
Jan 14 05:03:47 gizeh kernel: [25278.836334] 090: 00000001 26858402 20000029 // 00000001 26859c02 20000029 // 00000001 26859202 20000029 // 00000001 26858202 20000029
Jan 14 05:03:47 gizeh kernel: [25278.836339] 094: 00000001 26859402 20000029 // 00000001 26859802 20000029 // 00000001 26858c02 20000029 // 00000001 2a6c4a02 20000029
Jan 14 05:03:47 gizeh kernel: [25278.836344] 098: 00000000 b7304602 20000029 // 00000001 24933602 20000029 // 00000001 24933c02 20000029 // 00000001 24932c02 20000029
Jan 14 05:03:47 gizeh kernel: [25278.836349] 09c: 00000001 26afe202 20000029 // 00000001 29bca802 20000029 // 00000001 2498a202 20000029 // 00000001 26a2e602 20000029
Jan 14 05:03:47 gizeh kernel: [25278.836354] 0a0: 00000001 29826802 20000029 // 00000001 26859002 20000029 // 00000001 2a0c1c02 20000029 // 00000001 24932402 20000029
Jan 14 05:03:47 gizeh kernel: [25278.836359] 0a4: 00000001 26afea02 20000029 // 00000001 269b8e02 20000029 // 00000001 26a2ea02 20000029 // 00000001 29f47602 20000029
Jan 14 05:03:47 gizeh kernel: [25278.836364] 0a8: 00000001 26859e02 20000029 // 00000001 24933e02 20000029 // 00000001 2498aa02 20000029 // 00000001 269b8802 20000029
Jan 14 05:03:47 gizeh kernel: [25278.836369] 0ac: 00000001 29f46402 20000029 // 00000001 2a2b2202 20000029 // 00000000 37aae002 20000029 // 00000000 37aae602 20000029
Jan 14 05:03:47 gizeh kernel: [25278.836374] 0b0: 00000000 37aae802 20000029 // 00000000 37aaea02 20000029 // 00000000 37aaec02 20000029 // 00000000 37aaee02 20000029
Jan 14 05:03:47 gizeh kernel: [25278.836379] 0b4: 00000000 37aaf002 20000029 // 00000000 37aaf202 20000029 // 00000000 37aaf402 20000029 // 00000000 37aaf602 20000029
Jan 14 05:03:47 gizeh kernel: [25278.836384] 0b8: 00000000 37aaf802 20000029 // 00000000 37aafa02 20000029 // 00000000 37aafc02 20000029 // 00000000 37aafe02 20000029
Jan 14 05:03:47 gizeh kernel: [25278.836388] 0bc: 00000000 b7304202 20000029 // 00000000 37aae402 20000029 // 00000000 b72a4002 20000029 // 00000000 b72a4402 20000029
Jan 14 05:03:47 gizeh kernel: [25278.836393] 0c0: 00000000 b72a4602 20000029 // 00000000 b72a4a02 20000029 // 00000000 b72a4c02 20000029 // 00000000 b72a4e02 20000029
Jan 14 05:03:47 gizeh kernel: [25278.836398] 0c4: 00000000 b72a5002 20000029 // 00000000 b72a5202 20000029 // 00000000 b72a5402 20000029 // 00000000 b72a5602 20000029
Jan 14 05:03:47 gizeh kernel: [25278.836403] 0c8: 00000000 b72a5802 20000029 // 00000000 b72a5a02 20000029 // 00000000 b72a5c02 20000029 // 00000000 b72a5e02 20000029
Jan 14 05:03:47 gizeh kernel: [25278.836409] 0cc: 00000001 2907f402 20000029 // 00000000 b72a4802 20000029 // 00000000 b732c202 20000029 // 00000000 b732c402 20000029
Jan 14 05:03:47 gizeh kernel: [25278.836414] 0d0: 00000000 b732c802 20000029 // 00000000 b732ca02 20000029 // 00000000 b732cc02 20000029 // 00000000 b732ce02 20000029
Jan 14 05:03:47 gizeh kernel: [25278.836419] 0d4: 00000000 b732d202 20000029 // 00000000 b732d402 20000029 // 00000000 b732d002 20000029 // 00000000 b732d602 20000029
Jan 14 05:03:47 gizeh kernel: [25278.836423] 0d8: 00000000 b732d802 20000029 // 00000000 b732da02 20000029 // 00000000 b732dc02 20000029 // 00000000 b732de02 20000029
Jan 14 05:03:47 gizeh kernel: [25278.836428] 0dc: 00000000 37aae202 20000029 // 00000000 b732c002 20000029 // 00000000 b7256202 20000029 // 00000000 b7256602 20000029
Jan 14 05:03:47 gizeh kernel: [25278.836434] 0e0: 00000000 b7256802 20000029 // 00000000 b7256a02 20000029 // 00000000 b7256e02 20000029 // 00000000 b7257002 20000029
Jan 14 05:03:47 gizeh kernel: [25278.836439] 0e4: 00000000 b7257202 20000029 // 00000000 b7257402 20000029 // 00000000 b7257602 20000029 // 00000000 b7257802 20000029
Jan 14 05:03:47 gizeh kernel: [25278.836444] 0e8: 00000000 b7257a02 20000029 // 00000000 b7257c02 20000029 // 00000000 b7257e02 20000029 // 00000000 b732c602 20000029
Jan 14 05:03:47 gizeh kernel: [25278.836449] 0ec: 00000000 b7256402 20000029 // 00000000 b7266002 20000029 // 00000000 b7266602 20000029 // 00000000 b7266802 20000029
Jan 14 05:03:47 gizeh kernel: [25278.836454] 0f0: 00000000 b7266a02 20000029 // 00000000 b7266c02 20000029 // 00000000 b7266e02 20000029 // 00000000 b7267002 20000029
Jan 14 05:03:47 gizeh kernel: [25278.836459] 0f4: 00000000 b7267202 20000029 // 00000000 b7267402 20000029 // 00000000 b7267802 20000029 // 00000000 b7267602 20000029
Jan 14 05:03:47 gizeh kernel: [25278.836464] 0f8: 00000000 b7267a02 20000029 // 00000000 b7267c02 20000029 // 00000000 b7267e02 20000029 // 00000000 b72a4202 20000029
Jan 14 05:03:47 gizeh kernel: [25278.836469] 0fc: 00000000 b7266402 20000029 // 00000000 b7256c02 20000029 // 00000000 b72a2002 20000029 // 00000000 b72a2402 20000029
Jan 14 06:25:34 gizeh rsyslogd: [origin software="rsyslogd" swVersion="4.6.4" x-pid="1750" x-info="http://www.rsyslog.com"] rsyslogd was HUPed, type 'lightweight'.
Jan 14 07:15:47 gizeh kernel: [33198.836015] eth1: Got tx_timeout. irq: 00000036
Jan 14 07:15:47 gizeh kernel: [33198.836019] eth1: Ring at 12a73c000
Jan 14 07:15:47 gizeh kernel: [33198.836021] eth1: Dumping tx registers
Jan 14 07:15:47 gizeh kernel: [33198.836026]   0: 00000036 00000000 00000003 000d000d 00000000 00000000 00000000 00000000
Jan 14 07:15:47 gizeh kernel: [33198.836032]  20: 06255300 ff701365 00000000 00000000 00000000 00000000 00000000 00000000
Jan 14 07:15:47 gizeh kernel: [33198.836037]  40: 0420e20e 0000a855 00002e20 00000000 00000000 00000000 00000000 00000000
Jan 14 07:15:47 gizeh kernel: [33198.836042]  60: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
Jan 14 07:15:47 gizeh kernel: [33198.836048]  80: 003b0f3c 00c02601 00040000 007f0020 0000061c 00000001 00200000 80007fae
Jan 14 07:15:47 gizeh kernel: [33198.836054]  a0: 0016070f 00000016 d2091100 0000b21b 00000001 00000000 2d00cccd 00004ce4
Jan 14 07:15:47 gizeh kernel: [33198.836059]  c0: 10000001 00000001 00000001 00000001 00000001 00000001 00000001 00000001
Jan 14 07:15:47 gizeh kernel: [33198.836064]  e0: 00000001 00000001 00000001 00000001 00000001 00000001 00000001 00000001
Jan 14 07:15:47 gizeh kernel: [33198.836070] 100: 2a73e000 2a73c000 01ff00ff 00002601 00010064 00000000 00000039 2a73e800
Jan 14 07:15:47 gizeh kernel: [33198.836076] 120: 2a73d4c0 00002c40 b73029c2 117bf040 8000061c 2a73e614 2a73d374 01e08000
Jan 14 07:15:47 gizeh kernel: [33198.836081] 140: 00304120 00002600 00000001 00000001 00000000 00000000 00000000 00000000
Jan 14 07:15:47 gizeh kernel: [33198.836086] 160: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
Jan 14 07:15:47 gizeh kernel: [33198.836092] 180: 00000016 00000008 0194796d 00008103 0000002a 00004000 0194000f 00000003
Jan 14 07:15:47 gizeh kernel: [33198.836097] 1a0: 00000016 00000008 0194796d 00008103 0000002a 00004000 0194000f 00000003
Jan 14 07:15:47 gizeh kernel: [33198.836103] 1c0: 00000016 00000008 0194796d 00008103 0000002a 00004000 0194000f 00000003
Jan 14 07:15:47 gizeh kernel: [33198.836108] 1e0: 00000016 00000008 0194796d 00008103 0000002a 00004000 0194000f 00000003
Jan 14 07:15:47 gizeh kernel: [33198.836114] 200: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
Jan 14 07:15:47 gizeh kernel: [33198.836119] 220: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
Jan 14 07:15:47 gizeh kernel: [33198.836124] 240: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
Jan 14 07:15:47 gizeh kernel: [33198.836130] 260: 00000000 00000000 fe020001 00000100 00000000 00000000 7e020001 00000100
Jan 14 07:15:47 gizeh kernel: [33198.836135] 280: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
Jan 14 07:15:47 gizeh kernel: [33198.836141] 2a0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
Jan 14 07:15:47 gizeh kernel: [33198.836146] 2c0: 00000000 00000000 00000000 00000000 00000000 00000001 00000001 00000001
Jan 14 07:15:47 gizeh kernel: [33198.836148] eth1: Dumping tx ring
Jan 14 07:15:47 gizeh kernel: [33198.836152] 000: 00000000 b732c602 20000029 // 00000000 b732ca02 20000029 // 00000000 b732cc02 20000029 // 00000000 b732ce02 20000029
Jan 14 07:15:47 gizeh kernel: [33198.836158] 004: 00000000 b732d002 20000029 // 00000000 b732d202 20000029 // 00000000 b732d602 20000029 // 00000000 b732d402 20000029
Jan 14 07:15:47 gizeh kernel: [33198.836163] 008: 00000000 b732d802 20000029 // 00000000 b732da02 20000029 // 00000000 b732dc02 20000029 // 00000000 b732de02 20000029
Jan 14 07:15:47 gizeh kernel: [33198.836168] 00c: 00000000 b72a4202 20000029 // 00000000 b732c202 20000029 // 00000000 b7256002 20000029 // 00000000 b7256402 20000029
Jan 14 07:15:47 gizeh kernel: [33198.836173] 010: 00000000 99e2b802 20000029 // 00000000 99e2b202 20000029 // 00000000 99e2ae02 20000029 // 00000000 99e2a202 20000029
Jan 14 07:15:47 gizeh kernel: [33198.836178] 014: 00000000 99e2b402 20000029 // 00000000 99e2aa02 20000029 // 00000000 99e2bc02 20000029 // 00000000 99e2ba02 20000029
Jan 14 07:15:47 gizeh kernel: [33198.836183] 018: 00000000 99e2a802 20000029 // 00000000 99e2a602 20000029 // 00000000 b70c0602 20000029 // 00000000 b7256e02 20000029
Jan 14 07:15:47 gizeh kernel: [33198.836188] 01c: 00000000 55a2e402 20000029 // 00000000 55a2f602 20000029 // 00000000 55a2f202 20000029 // 00000000 55a2f802 20000029
Jan 14 07:15:47 gizeh kernel: [33198.836193] 020: 00000000 55a2ec02 20000029 // 00000000 55a2e202 20000029 // 00000000 55a2ea02 20000029 // 00000000 55a2fe02 20000029
Jan 14 07:15:47 gizeh kernel: [33198.836198] 024: 00000000 55a2fc02 20000029 // 00000000 55a2fa02 20000029 // 00000000 55a2ee02 20000029 // 00000000 55a2e802 20000029
Jan 14 07:15:47 gizeh kernel: [33198.836203] 028: 00000000 55a2e002 20000029 // 00000000 55a2e602 20000029 // 00000000 99e2be02 20000029 // 00000000 99e2a002 20000029
Jan 14 07:15:47 gizeh kernel: [33198.836208] 02c: 00000000 99e2b002 20000029 // 00000000 b7256602 20000029 // 00000000 b7256a02 20000029 // 00000000 b7257e02 20000029
Jan 14 07:15:47 gizeh kernel: [33198.836213] 030: 00000000 b7256c02 20000029 // 00000000 b7257202 20000029 // 00000000 b7257602 20000029 // 00000000 b7257002 20000029
Jan 14 07:15:47 gizeh kernel: [33198.836218] 034: 00000000 b7257402 20000029 // 00000000 b7257a02 20000029 // 00000000 b7257c02 20000029 // 00000000 b7257802 20000029
Jan 14 07:15:47 gizeh kernel: [33198.836223] 038: 00000000 b732c802 20000029 // 00000000 55a2f002 20000029 // 00000000 99e2a402 20000029 // 00000000 99e2b602 20000029
Jan 14 07:15:47 gizeh kernel: [33198.836228] 03c: 00000000 b7256802 20000029 // 00000000 55a2f402 20000029 // 00000001 1e7c4002 20000029 // 00000001 1e7c4402 20000029
Jan 14 07:15:47 gizeh kernel: [33198.836233] 040: 00000001 1e7c4802 20000029 // 00000001 1e7c4a02 20000029 // 00000001 1e7c4c02 20000029 // 00000001 1e7c4e02 20000029
Jan 14 07:15:47 gizeh kernel: [33198.836238] 044: 00000001 1e7c5002 20000029 // 00000001 1e7c5202 20000029 // 00000001 1e7c5402 20000029 // 00000001 1e7c5602 20000029
Jan 14 07:15:47 gizeh kernel: [33198.836243] 048: 00000001 1e7c5802 20000029 // 00000001 1e7c5a02 20000029 // 00000001 1e7c5e02 20000029 // 00000000 99e2ac02 20000029
Jan 14 07:15:47 gizeh kernel: [33198.836248] 04c: 00000001 1e7c4202 20000029 // 00000001 1e7c5c02 20000029 // 00000001 1faac002 20000029 // 00000001 1faac802 20000029
Jan 14 07:15:47 gizeh kernel: [33198.836253] 050: 00000001 1faaca02 20000029 // 00000001 1faacc02 20000029 // 00000001 1faac602 20000029 // 00000001 1faace02 20000029
Jan 14 07:15:47 gizeh kernel: [33198.836258] 054: 00000001 1faad002 20000029 // 00000001 1faad202 20000029 // 00000001 1faad402 20000029 // 00000001 1faad602 20000029
Jan 14 07:15:47 gizeh kernel: [33198.836263] 058: 00000001 1faad802 20000029 // 00000001 1faada02 20000029 // 00000001 1faadc02 20000029 // 00000001 1faade02 20000029
Jan 14 07:15:47 gizeh kernel: [33198.836268] 05c: 00000001 1e7c4602 20000029 // 00000001 1faac202 20000029 // 00000001 13708002 20000029 // 00000001 13708402 20000029
Jan 14 07:15:47 gizeh kernel: [33198.836273] 060: 00000001 13708602 20000029 // 00000001 13708c02 20000029 // 00000001 13708e02 20000029 // 00000001 13709002 20000029
Jan 14 07:15:47 gizeh kernel: [33198.836278] 064: 00000001 13709202 20000029 // 00000001 13709402 20000029 // 00000001 13709602 20000029 // 00000001 13709802 20000029
Jan 14 07:15:47 gizeh kernel: [33198.836283] 068: 00000001 13709a02 20000029 // 00000001 13709c02 20000029 // 00000001 13709e02 20000029 // 00000000 b7256202 20000029
Jan 14 07:15:47 gizeh kernel: [33198.836288] 06c: 00000001 13708802 20000029 // 00000001 1faac402 20000029 // 00000001 0d884002 20000029 // 00000000 00000000 00000000
Jan 14 07:15:47 gizeh kernel: [33198.836293] 070: 00000000 b6c7e602 a0000029 // 00000000 b6c7ea02 a0000029 // 00000000 b6c7ec02 a0000029 // 00000000 b6c7ee02 a0000029
Jan 14 07:15:47 gizeh kernel: [33198.836298] 074: 00000000 b6c7f202 a0000029 // 00000000 b6c7f402 a0000029 // 00000000 b6c7f602 a0000029 // 00000000 b6c7e202 a0000029
Jan 14 07:15:47 gizeh kernel: [33198.836303] 078: 00000000 b6c7f802 a0000029 // 00000000 b6c7fa02 a0000029 // 00000000 b6c7fc02 a0000029 // 00000000 b6c7fe02 a0000029
Jan 14 07:15:47 gizeh kernel: [33198.836308] 07c: 00000000 b6c7e402 a0000029 // 00000000 b6c7e002 a0000029 // 00000001 2907f402 a0000029 // 00000001 29f47202 a0000029
Jan 14 07:15:47 gizeh kernel: [33198.836313] 080: 00000001 29f47602 20000029 // 00000001 29f46402 20000029 // 00000001 269b9c02 20000029 // 00000001 269b9a02 20000029
Jan 14 07:15:47 gizeh kernel: [33198.836318] 084: 00000001 269b8402 20000029 // 00000001 269b9002 20000029 // 00000001 269b8e02 20000029 // 00000001 269b8802 20000029
Jan 14 07:15:47 gizeh kernel: [33198.836323] 088: 00000001 2498b202 20000029 // 00000001 2498a002 20000029 // 00000001 2498a202 20000029 // 00000001 2498aa02 20000029
Jan 14 07:15:47 gizeh kernel: [33198.836329] 08c: 00000001 24932202 20000029 // 00000001 24933202 20000029 // 00000001 24933802 20000029 // 00000001 24933602 20000029
Jan 14 07:15:47 gizeh kernel: [33198.836334] 090: 00000001 24933c02 20000029 // 00000001 24932c02 20000029 // 00000001 24932402 20000029 // 00000001 24933e02 20000029
Jan 14 07:15:47 gizeh kernel: [33198.836339] 094: 00000001 26858802 20000029 // 00000001 26859202 20000029 // 00000001 26858202 20000029 // 00000001 26859402 20000029
Jan 14 07:15:47 gizeh kernel: [33198.836344] 098: 00000001 26859802 20000029 // 00000001 26858c02 20000029 // 00000001 26859002 20000029 // 00000001 26859e02 20000029
Jan 14 07:15:47 gizeh kernel: [33198.836349] 09c: 00000001 26a2f402 20000029 // 00000001 26a2e002 20000029 // 00000001 26a2fe02 20000029 // 00000001 26a2e602 20000029
Jan 14 07:15:47 gizeh kernel: [33198.836354] 0a0: 00000001 26a2ea02 20000029 // 00000001 26afe402 20000029 // 00000001 26affe02 20000029 // 00000001 26aff402 20000029
Jan 14 07:15:47 gizeh kernel: [33198.836359] 0a4: 00000001 26afe002 20000029 // 00000001 26afe202 20000029 // 00000001 26afea02 20000029 // 00000001 2a0c1c02 20000029
Jan 14 07:15:47 gizeh kernel: [33198.836364] 0a8: 00000001 29826802 20000029 // 00000001 29bcbe02 20000029 // 00000001 2a6c4a02 20000029 // 00000000 b6c7f002 20000029
Jan 14 07:15:47 gizeh kernel: [33198.836369] 0ac: 00000001 2a2b2202 20000029 // 00000001 269b9e02 20000029 // 00000001 2498a402 20000029 // 00000001 24932a02 20000029
Jan 14 07:15:47 gizeh kernel: [33198.836374] 0b0: 00000001 26858402 20000029 // 00000001 26859c02 20000029 // 00000001 26a2ec02 20000029 // 00000001 26affa02 20000029
Jan 14 07:15:47 gizeh kernel: [33198.836379] 0b4: 00000001 29826402 20000029 // 00000001 29bca802 20000029 // 00000001 29f46002 20000029 // 00000001 269b9802 20000029
Jan 14 07:15:47 gizeh kernel: [33198.836384] 0b8: 00000001 26859602 20000029 // 00000001 26a2e202 20000029 // 00000001 29f46202 20000029 // 00000001 29bcb402 20000029
Jan 14 07:15:47 gizeh kernel: [33198.836389] 0bc: 00000001 2498ba02 20000029 // 00000000 b6c7e802 20000029 // 00000000 b7304002 20000029 // 00000000 b7304602 20000029
Jan 14 07:15:47 gizeh kernel: [33198.836394] 0c0: 00000000 b7304802 20000029 // 00000000 b7304a02 20000029 // 00000000 b7304c02 20000029 // 00000000 b7304e02 20000029
Jan 14 07:15:47 gizeh kernel: [33198.836398] 0c4: 00000000 b7305002 20000029 // 00000000 b7305202 20000029 // 00000000 b7305402 20000029 // 00000000 b7305602 20000029
Jan 14 07:15:47 gizeh kernel: [33198.836403] 0c8: 00000000 b7305802 20000029 // 00000000 b7305a02 20000029 // 00000000 b7305c02 20000029 // 00000000 b7305e02 20000029
Jan 14 07:15:47 gizeh kernel: [33198.836408] 0cc: 00000001 24932602 20000029 // 00000000 b7304402 20000029 // 00000000 cdb26002 20000029 // 00000000 cdb26402 20000029
Jan 14 07:15:47 gizeh kernel: [33198.836413] 0d0: 00000000 cdb26602 20000029 // 00000000 cdb26a02 20000029 // 00000000 cdb26c02 20000029 // 00000000 cdb26e02 20000029
Jan 14 07:15:47 gizeh kernel: [33198.836418] 0d4: 00000000 cdb27002 20000029 // 00000000 cdb27202 20000029 // 00000000 cdb27402 20000029 // 00000000 cdb27602 20000029
Jan 14 07:15:47 gizeh kernel: [33198.836423] 0d8: 00000000 cdb27802 20000029 // 00000000 cdb27a02 20000029 // 00000000 cdb27c02 20000029 // 00000000 cdb27e02 20000029
Jan 14 07:15:47 gizeh kernel: [33198.836428] 0dc: 00000001 26afec02 20000029 // 00000000 cdb26802 20000029 // 00000000 b70c0002 20000029 // 00000000 b70c0402 20000029
Jan 14 07:15:47 gizeh kernel: [33198.836433] 0e0: 00000000 b70c0802 20000029 // 00000000 b70c0a02 20000029 // 00000000 b70c0c02 20000029 // 00000000 b70c0e02 20000029
Jan 14 07:15:47 gizeh kernel: [33198.836438] 0e4: 00000000 b70c1002 20000029 // 00000000 b70c1202 20000029 // 00000000 b70c1402 20000029 // 00000000 b70c1602 20000029
Jan 14 07:15:47 gizeh kernel: [33198.836443] 0e8: 00000000 b70c1802 20000029 // 00000000 b70c1c02 20000029 // 00000000 b70c1e02 20000029 // 00000000 cdb26202 20000029
Jan 14 07:15:47 gizeh kernel: [33198.836448] 0ec: 00000000 b7304202 20000029 // 00000000 b72a4002 20000029 // 00000000 b72a4402 20000029 // 00000000 b72a4802 20000029
Jan 14 07:15:47 gizeh kernel: [33198.836453] 0f0: 00000000 b72a4a02 20000029 // 00000000 b72a4c02 20000029 // 00000000 b72a4e02 20000029 // 00000000 b72a5002 20000029
Jan 14 07:15:47 gizeh kernel: [33198.836458] 0f4: 00000000 b72a5202 20000029 // 00000000 b72a5402 20000029 // 00000000 b72a5802 20000029 // 00000000 b72a5a02 20000029
Jan 14 07:15:47 gizeh kernel: [33198.836463] 0f8: 00000000 b72a5c02 20000029 // 00000000 b72a5e02 20000029 // 00000000 b70c0202 20000029 // 00000000 b72a5602 20000029
Jan 14 07:15:47 gizeh kernel: [33198.836468] 0fc: 00000000 b72a4602 20000029 // 00000000 b70c1a02 20000029 // 00000000 b732c002 20000029 // 00000000 b732c402 20000029

^ permalink raw reply

* Re: [PATCH] can: test size of struct sockaddr
From: Oliver Hartkopp @ 2011-01-15 17:08 UTC (permalink / raw)
  To: Kurt Van Dijck
  Cc: socketcan-core-0fE9KPoRgkgATYTw5x5z8w,
	netdev-u79uwXL29TY76Z2rM5mHXA
In-Reply-To: <20110114172321.GB331-MxZ6Iy/zr/UdbCeoMzGj59i2O/JbrIOy@public.gmane.org>

On 14.01.2011 18:23, Kurt Van Dijck wrote:
> I think this patch makes the CAN socket code comform to the
> manpages of sendmsg & recvmsg.

Hello Kurt,

if you check similar code sniplets in the kernel you would see, that in
recvmsg()-cases the given namelen is not used from userspace.

If msg->msg_name is not NULL the msg_namelen is just set by the kernel. E.g.
see af_packet.c, af_econet.c, etc.

So the code in candump.c setting the msg_namelen before recvmsg() is obviously
obsolete ...

Btw. your two patches below for bcm_sendmsg() and raw_sendmesg() look good.

If you would like to resubmit these two patches, you may add my Acked-by

Thanks,
Oliver



> diff --git a/net/can/bcm.c b/net/can/bcm.c
> index 6faa825..dc0d5d6 100644
> --- a/net/can/bcm.c
> +++ b/net/can/bcm.c
> @@ -1256,6 +1256,9 @@ static int bcm_sendmsg(struct kiocb *iocb, struct socket *sock,
>  		struct sockaddr_can *addr =
>  			(struct sockaddr_can *)msg->msg_name;
>  
> +		if (msg->msg_namelen < sizeof(*addr))
> +			return -EINVAL;
> +
>  		if (addr->can_family != AF_CAN)
>  			return -EINVAL;
>  


> diff --git a/net/can/raw.c b/net/can/raw.c
> index e88f610..e68a6d3 100644
> --- a/net/can/raw.c
> +++ b/net/can/raw.c
> @@ -649,6 +649,9 @@ static int raw_sendmsg(struct kiocb *iocb, struct socket *sock,
>  		struct sockaddr_can *addr =
>  			(struct sockaddr_can *)msg->msg_name;
>  
> +		if (msg->msg_namelen < sizeof(*addr))
> +			return -EINVAL;
> +
>  		if (addr->can_family != AF_CAN)
>  			return -EINVAL;
>  

^ permalink raw reply

* Re: [PATCH v3 0/2] net: add device groups
From: Vlad Dogaru @ 2011-01-15 16:45 UTC (permalink / raw)
  To: Stephen Hemminger; +Cc: netdev, jamal, Octavian Purdila
In-Reply-To: <20110114080810.2f128064@nehalam>

On Fri, Jan 14, 2011 at 08:08:10AM -0800, Stephen Hemminger wrote:
> On Fri, 14 Jan 2011 11:38:29 +0200
> Vlad Dogaru <ddvlad@rosedu.org> wrote:
> 
> > This patchset implements network device grouping and simple manipulation
> > of groups. Netlink has been updated to provide group information and
> > means of applying changes to members of a specific group via a single
> > message.
> > 
> > The patchset has a corresponding one for iproute2, which implements the
> > new functionality in userspace.
> 
> What about a read/write sysfs interface as well?
>   /sys/class/net/eth0/devgroup

Oops, I overlooked that, probably because I've been testing in a virtual
machine where the kernel has sysfs turned off -- less waiting for simple
tests.

> Not sure if numeric devgroup is best choice. Since this is more of
> a human interface parameter maybe it should be a string? Or have
> a translation in the utilities /etc/iproute2/devgroup?

I didn't know about /etc/iproute2. I could add the devgroup file as you
mention, seems like a good choice for userspace.

I'll update the patches with these, but it will probably take a few days,
I have a few exams next week :)

Thanks for the suggestions,
Vlad

^ permalink raw reply

* Re: [patch] caif: checking the wrong variable
From: Sjur Brændeland @ 2011-01-15 14:03 UTC (permalink / raw)
  To: Dan Carpenter; +Cc: David S. Miller, netdev, kernel-janitors
In-Reply-To: <20110115130639.GA2721@bicker>

> In the original code we check if (servl == NULL) twice.  The first time
> should print the message that cfmuxl_remove_uplayer() failed and set
> "ret" correctly, but instead it just returns success.  The second check
> should be checking the value of "ret" instead of "servl".
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>

Thank you for spotting and correcting this.
Looks good to me (reviewed only)

Acked-by: Sjur Braendeland <sjur.brandeland@stericsson.com>

^ permalink raw reply

* Re: [PATCH net-next] net: cleanup unused macros in net directory
From: Sjur Brændeland @ 2011-01-15 13:59 UTC (permalink / raw)
  To: Shan Wei
  Cc: David Miller, andy.grover, ericvh, jvrao, aneesh.kumar, joe,
	Changli Gao, Eric Dumazet, jpirko, nhorman, pebolle, jkosina,
	arnd, Network-Maillist, linux-decnet-user, rds-devel
In-Reply-To: <4D300728.8030402@cn.fujitsu.com>

> Clean up some unused macros in net/*.
> 1. be left for code change. e.g. PGV_FROM_VMALLOC, PGV_FROM_VMALLOC, KMEM_SAFETYZONE.
> 2. never be used since introduced to kernel.
>   e.g. P9_RDMA_MAX_SGE, UTIL_CTRL_PKT_SIZE.
>
>
> Signed-off-by: Shan Wei <shanwei@cn.fujitsu.com>

CAIF parts looks ok to me (reviewed only).

Acked-by: Sjur Braendeland <sjur.brandeland@stericsson.com>

^ permalink raw reply

* [patch] caif: checking the wrong variable
From: Dan Carpenter @ 2011-01-15 13:06 UTC (permalink / raw)
  To: Sjur Braendeland; +Cc: David S. Miller, netdev, kernel-janitors

In the original code we check if (servl == NULL) twice.  The first time
should print the message that cfmuxl_remove_uplayer() failed and set
"ret" correctly, but instead it just returns success.  The second check
should be checking the value of "ret" instead of "servl".

Signed-off-by: Dan Carpenter <error27@gmail.com>

diff --git a/net/caif/cfcnfg.c b/net/caif/cfcnfg.c
index 21ede14..c665de7 100644
--- a/net/caif/cfcnfg.c
+++ b/net/caif/cfcnfg.c
@@ -191,6 +191,7 @@ int cfcnfg_disconn_adapt_layer(struct cfcnfg *cnfg, struct cflayer *adap_layer)
 	struct cflayer *servl = NULL;
 	struct cfcnfg_phyinfo *phyinfo = NULL;
 	u8 phyid = 0;
+
 	caif_assert(adap_layer != NULL);
 	channel_id = adap_layer->id;
 	if (adap_layer->dn == NULL || channel_id == 0) {
@@ -199,16 +200,16 @@ int cfcnfg_disconn_adapt_layer(struct cfcnfg *cnfg, struct cflayer *adap_layer)
 		goto end;
 	}
 	servl = cfmuxl_remove_uplayer(cnfg->mux, channel_id);
-	if (servl == NULL)
-		goto end;
-	layer_set_up(servl, NULL);
-	ret = cfctrl_linkdown_req(cnfg->ctrl, channel_id, adap_layer);
 	if (servl == NULL) {
 		pr_err("PROTOCOL ERROR - Error removing service_layer Channel_Id(%d)",
 		       channel_id);
 		ret = -EINVAL;
 		goto end;
 	}
+	layer_set_up(servl, NULL);
+	ret = cfctrl_linkdown_req(cnfg->ctrl, channel_id, adap_layer);
+	if (ret)
+		goto end;
 	caif_assert(channel_id == servl->id);
 	if (adap_layer->dn != NULL) {
 		phyid = cfsrvl_getphyid(adap_layer->dn);

^ permalink raw reply related

* Re: [PATCH] bonding: added 802.3ad round-robin hashing policy for single TCP session balancing
From: Oleg V. Ukhno @ 2011-01-15 12:11 UTC (permalink / raw)
  To: Jay Vosburgh; +Cc: netdev, David S. Miller, John Fastabend
In-Reply-To: <26330.1295049912@death>



Jay Vosburgh wrote:
> Oleg V. Ukhno <olegu@yandex-team.ru> wrote:
>> Jay Vosburgh wrote:
>>
>>> 	Also, what does a round robin in 802.3ad provide that the
>>> existing round robin does not?  My presumption is that you're looking to
>>> get the aggregator autoconfiguration that 802.3ad provides, but you
>>> don't say.
> 
> 	I'm still curious about this question.  Given the rather
> intricate setup of your particular network (described below), I'm not
> sure why 802.3ad is of benefit over traditional etherchannel
> (balance-rr / balance-xor).
Yes, I wanted 802.3ad autoconfiguration. Besides, all switches I use 
support LACP so I've chosen 802.3ad link aggregation.
Of course, it would be cool it both 802.3ad and balance-rr modes 
supported such load striping feature.

> 
>> Yes, I am resetting MAC addresses when transmitting packets to have switch
>> to put packets into different ports of the receiving etherchannel.
> 
> 	By "etherchannel" do you really mean "Cisco switch with a
> port-channel group using LACP"?
Yes, exactly
> 
>> I am using this patch to provide full-mesh ISCSI connectivity between at
>> least 4 hosts (all hosts of course are in same ethernet segment) and every
>> host is connected with aggregate link with 4 slaves(usually).
>> Using round-robin I provide near-equal load striping when transmitting,
>> using MAC address magic I force switch to stripe packets over all slave
>> links in destination port-channel(when number of rx-ing slaves is equal to
>> number ot tx-ing slaves and is even).
> 
> 	By "MAC address magic" do you mean that you're assigning
> specifically chosen MAC addresses to the slaves so that the switch's
> hash is essentially "assigning" the bonding slaves to particular ports
> on the outgoing port-channel group?

Yes, so I am able to make equal load striping even for single TCP 
session between just two hosts not only for transmiting host, but also 
for receiving host(iperf, when doing TCP test, is able to utilize all 
available bandwith in given etherchannel).

> 
> 	Assuming that this is the case, it's an interesting idea, but
> I'm unconvinced that it's better on 802.3ad vs. balance-rr.  Unless I'm
> missing something, you can get everything you need from an option to
> have balance-rr / balance-xor utilize the slave's permanent address as
> the source address for outgoing traffic.

Yes, balance-rr would satisfy my requrements if patched for doing "MAC 
address magic"(replacing MAC address of packets being transmitted by 
slave's permanent address), except for 802.3ad link autoconfiguration.
"Pure" balance-rr won't allow to utilize whole etherchannel bandwidth 
when transmitting data just between 2 hosts( for example, when I have 
one iSCSI initiator and one iSCSI target). balance-xor is not what I 
wanted because data transmitted on source host will stick to any, but 
single slave.


> 
> 
>>> 	This is the code that resets the MAC header as described above.
>>> It doesn't quite match the documentation, since it only resets the MAC
>>> for ETH_P_IP packets.
>> Yes, I really meant that my patch applies to ETH_P_IP packets and I've
>> missed that from documentation I wrote.
> 
> 	Is limiting this to just ETH_P_IP really a means to exclude ARP,
> or is there some advantage to (effectively) only balancing IP traffic,
> and leaving other traffic (IPv6, for one) essentially unbalanced (when
> exiting the switch through the destination port-channel group, which
> you've set to use a src-mac hash)?
> 
Well, when making initial version of this patch(it was for 2.6.18 
kernel), I meant just excluding ARP .

> 	-J
> 
> ---
> 	-Jay Vosburgh, IBM Linux Technology Center, fubar@us.ibm.com
> 

-- 
Best regards,

Oleg Ukhno

^ permalink raw reply

* [PATCH resend] netfilter: make rcu read section smaller
From: Changli Gao @ 2011-01-15 11:28 UTC (permalink / raw)
  To: Patrick McHardy; +Cc: David S. Miller, netfilter-devel, netdev, Changli Gao
In-Reply-To: <1295090930-16671-1-git-send-email-xiaosuo@gmail.com>

Signed-off-by: Changli Gao <xiaosuo@gmail.com>
---
 net/ipv4/netfilter/nf_nat_core.c |   38 +++++++++++++++++++-------------------
 1 file changed, 19 insertions(+), 19 deletions(-)
diff --git a/net/ipv4/netfilter/nf_nat_core.c b/net/ipv4/netfilter/nf_nat_core.c
index c04787c..7300611 100644
--- a/net/ipv4/netfilter/nf_nat_core.c
+++ b/net/ipv4/netfilter/nf_nat_core.c
@@ -85,7 +85,7 @@ in_range(const struct nf_conntrack_tuple *tuple,
 	 const struct nf_nat_range *range)
 {
 	const struct nf_nat_protocol *proto;
-	int ret = 0;
+	int ret = 1;
 
 	/* If we are supposed to map IPs, then we must be in the
 	   range specified, otherwise let this drag us onto a new src IP. */
@@ -95,13 +95,14 @@ in_range(const struct nf_conntrack_tuple *tuple,
 			return 0;
 	}
 
-	rcu_read_lock();
-	proto = __nf_nat_proto_find(tuple->dst.protonum);
-	if (!(range->flags & IP_NAT_RANGE_PROTO_SPECIFIED) ||
-	    proto->in_range(tuple, IP_NAT_MANIP_SRC,
-			    &range->min, &range->max))
-		ret = 1;
-	rcu_read_unlock();
+	if (range->flags & IP_NAT_RANGE_PROTO_SPECIFIED) {
+		rcu_read_lock();
+		proto = __nf_nat_proto_find(tuple->dst.protonum);
+		if (!proto->in_range(tuple, IP_NAT_MANIP_SRC, &range->min,
+				     &range->max))
+			ret = 0;
+		rcu_read_unlock();
+	}
 
 	return ret;
 }
@@ -235,22 +236,21 @@ get_unique_tuple(struct nf_conntrack_tuple *tuple,
 
 	/* 3) The per-protocol part of the manip is made to map into
 	   the range to make a unique tuple. */
+	if (!(range->flags & (IP_NAT_RANGE_PROTO_RANDOM |
+			      IP_NAT_RANGE_PROTO_SPECIFIED)) &&
+	    !nf_nat_used_tuple(tuple, ct))
+		return;
 
 	rcu_read_lock();
 	proto = __nf_nat_proto_find(orig_tuple->dst.protonum);
 
 	/* Only bother mapping if it's not already in range and unique */
-	if (!(range->flags & IP_NAT_RANGE_PROTO_RANDOM)) {
-		if (range->flags & IP_NAT_RANGE_PROTO_SPECIFIED) {
-			if (proto->in_range(tuple, maniptype, &range->min,
-					    &range->max) &&
-			    (range->min.all == range->max.all ||
-			     !nf_nat_used_tuple(tuple, ct)))
-				goto out;
-		} else if (!nf_nat_used_tuple(tuple, ct)) {
-			goto out;
-		}
-	}
+	if ((range->flags & (IP_NAT_RANGE_PROTO_RANDOM |
+			     IP_NAT_RANGE_PROTO_SPECIFIED)) ==
+	    IP_NAT_RANGE_PROTO_SPECIFIED &&
+	    proto->in_range(tuple, maniptype, &range->min, &range->max) &&
+	    (range->min.all == range->max.all || !nf_nat_used_tuple(tuple, ct)))
+		goto out;
 
 	/* Last change: get protocol to try to obtain unique tuple. */
 	proto->unique_tuple(tuple, range, maniptype, ct);

^ permalink raw reply related


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox