* Kernel wiki for Linux networking
From: Luis R. Rodriguez @ 2011-01-31 23:29 UTC (permalink / raw)
To: netdev, Stephen Hemminger, David Miller
Cc: linux-kernel, Etan.Cohen, Hai.Shalom, zhen.xie
https://wiki.kernel.org/
We lack a general networking wiki. Can we get a subdomain to start
one? The Documentation/ directory serves its purpose but wikis can
allow for easier updates and allow for more content to be added and
categorized. We have some pages with some content already like:
http://www.linuxfoundation.org/collaborate/workgroups/networking/
http://www.linuxfoundation.org/collaborate/workgroups/networking/bridge
This is obviously outdated:
http://www.linuxfoundation.org/collaborate/workgroups/networking/802.11
And should just point to wireless.kernel.org, but I don't get the
sense that the LF networking site is a home body for any doc updates.
I have found the 802.11 wiki to write proposals [1], summarize
standards [2], and even provide a home body for userspace [3]. I think
something like this can benefit networking in general. Thoughts?
[1] http://wireless.kernel.org/en/developers/DFS
[2] http://wireless.kernel.org/en/developers/Documentation/ieee80211/802.11n
[3] http://wireless.kernel.org/en/users/Documentation
Luis
^ permalink raw reply
* Re: IAMT broken by commit 82776a4bcd7aa5fbcd2e6339b3ce88b727dd40ab
From: Jeff Kirsher @ 2011-01-31 23:24 UTC (permalink / raw)
To: David Miller; +Cc: aurelien@aurel32.net, Allan, Bruce W, netdev@vger.kernel.org
In-Reply-To: <20110131.123605.226778418.davem@davemloft.net>
[-- Attachment #1: Type: text/plain, Size: 1912 bytes --]
On Mon, 2011-01-31 at 12:36 -0800, David Miller wrote:
> From: Aurelien Jarno <aurelien@aurel32.net>
> Date: Mon, 31 Jan 2011 12:45:58 +0100
>
> >> On recent kernels, IAMT support does not work after the machine has
> >> been powered-off. Even worse, it also goes into this state when I try
> >> to reboot it.
> >>
> >> I have done a bisect and got this commit:
> >>
> >> | commit 82776a4bcd7aa5fbcd2e6339b3ce88b727dd40ab
> >> | Author: Bruce Allan <bruce.w.allan@intel.com>
> >> | Date: Fri Aug 14 14:35:33 2009 +0000
> >> |
> >> | e1000e: WoL does not work on 82577/82578 with manageability enabled
> >> |
> >> | With manageability (Intel AMT) enabled via BIOS, PHY wakeup does not get
> >> | configured on newer parts which use PHY wakeup vs. MAC wakeup which causes
> >> | WoL to not work. The driver should configure PHY wakeup whether or not
> >> | manageability is enabled.
> >> |
> >> | Signed-off-by: Bruce Allan <bruce.w.allan@intel.com>
> >> | Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> >> | Signed-off-by: David S. Miller <davem@davemloft.net>
> >>
> >> I have tried to revert it on recent kernels (2.6.34), and IAMT is then
> >> working as expected. My machine is using a Gigabyte EQ45M-S2 motherboard
> >> with an 82567LM-3 ethernet chip (8086:10de), that is a different model
> >> than the one of the original problem.
> >>
> >> I do wonder if the changes in the patch should not only be done on some
> >> chip models, and I will appreciate any help in fixing this issue.
> >>
> >
> > Just a short mail to say this problem is still present in 2.6.38-rc2.
> > The same solution still applies, that is reverting the above commit.
> > Note that reverting the first hunk only is enough to get it working
> > again.
>
> Intel folks please look into this.
We at looking into it, thanks.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
^ permalink raw reply
* Re: [PATCH v2 16/16] skge: convert to hw_features
From: Michał Mirosław @ 2011-01-31 23:08 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: netdev, Ben Hutchings
In-Reply-To: <20110131215343.GA19379@rere.qmqm.pl>
On Mon, Jan 31, 2011 at 10:53:43PM +0100, Michał Mirosław wrote:
> On Mon, Jan 31, 2011 at 08:45:02AM -0800, Stephen Hemminger wrote:
> > On Sat, 22 Jan 2011 23:14:14 +0100 (CET)
> > Michał Mirosław <mirq-linux@rere.qmqm.pl> wrote:
> > > The hardware might do full HW_CSUM, not just IP_CSUM, but it's not tested
> > > and so not changed here.
> > > Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
> > The skge hardware does not do full HW_CSUM. It looks at the IP header.
> Driver code suggests otherwise. Please look at skge_xmit_frame() and TX
> descriptor format.
Ah, I just noticed you wrote most of the code. :-)
Anyway, I still think you're wrong on this. I'll get back to it if I find
the time to create a proper test for other people with similar hardware.
This might be an academic dispute unless we can get at the docs.
Best Regards,
Michał Mirosław
^ permalink raw reply
* Re: linux-next: Tree for January 31 (ip_vs)
From: David Miller @ 2011-01-31 23:00 UTC (permalink / raw)
To: horms; +Cc: randy.dunlap, sfr, netdev, linux-next, linux-kernel
In-Reply-To: <20110131225727.GA23992@verge.net.au>
From: Simon Horman <horms@verge.net.au>
Date: Tue, 1 Feb 2011 09:57:28 +1100
> On Tue, Feb 01, 2011 at 08:18:47AM +1100, Simon Horman wrote:
>> On Mon, Jan 31, 2011 at 10:18:29AM -0800, Randy Dunlap wrote:
>> > On Mon, 31 Jan 2011 17:41:13 +1100 Stephen Rothwell wrote:
>> >
>> > > Hi all,
>> > >
>> > > Changes since 20110121:
>> > >
>> > > The net tree lost its build failure.
>> >
>> >
>> > When CONFIG_SYSCTL is not enabled:
>> >
>> > net/netfilter/ipvs/ip_vs_core.c:1891: warning: format '%lu' expects type 'long unsigned int', but argument 2 has type 'unsigned int'
>> > ERROR: "unregister_net_sysctl_table" [net/netfilter/ipvs/ip_vs.ko] undefined!
>> > ERROR: "register_net_sysctl_table" [net/netfilter/ipvs/ip_vs.ko] undefined!
>>
>> Thanks, I'm looking into it.
>
> On a related note, does IPVS need to handle the case
> where CONFIG_PROC_FS is not enabled?
Yes.
^ permalink raw reply
* Re: linux-next: Tree for January 31 (ip_vs)
From: Simon Horman @ 2011-01-31 22:57 UTC (permalink / raw)
To: Randy Dunlap; +Cc: Stephen Rothwell, netdev, linux-next, LKML
In-Reply-To: <20110131211846.GH2389@verge.net.au>
On Tue, Feb 01, 2011 at 08:18:47AM +1100, Simon Horman wrote:
> On Mon, Jan 31, 2011 at 10:18:29AM -0800, Randy Dunlap wrote:
> > On Mon, 31 Jan 2011 17:41:13 +1100 Stephen Rothwell wrote:
> >
> > > Hi all,
> > >
> > > Changes since 20110121:
> > >
> > > The net tree lost its build failure.
> >
> >
> > When CONFIG_SYSCTL is not enabled:
> >
> > net/netfilter/ipvs/ip_vs_core.c:1891: warning: format '%lu' expects type 'long unsigned int', but argument 2 has type 'unsigned int'
> > ERROR: "unregister_net_sysctl_table" [net/netfilter/ipvs/ip_vs.ko] undefined!
> > ERROR: "register_net_sysctl_table" [net/netfilter/ipvs/ip_vs.ko] undefined!
>
> Thanks, I'm looking into it.
On a related note, does IPVS need to handle the case
where CONFIG_PROC_FS is not enabled?
^ permalink raw reply
* Re: Problems with /proc/net/tcp6 - possible bug - ipv6
From: PK @ 2011-01-31 22:51 UTC (permalink / raw)
To: David Miller; +Cc: eric.dumazet, linux-kernel, netdev
David Miller wrote
>
> Please give this patch a try:
>
> --------------------
> From d80bc0fd262ef840ed4e82593ad6416fa1ba3fc4 Mon Sep 17 00:00:00 2001
> From: David S. Miller <davem@davemloft.net>
> Date: Mon, 24 Jan 2011 16:01:58 -0800
> Subject: [PATCH] ipv6: Always clone offlink routes.
That patch and all the others seem to be in the official tree, so I pulled
earlier
today to test against.
I no longer see kernel warnings or any problems with /proc/net/tcp6, but the
tcp6
layer still has issues with tcp_tw_recycle and a listening socket + looped
connect/disconnects.
First there are intermittent net unreachable connection failures when trying to
connect
to a local closed tcp6 port, and eventually connection attempts start failing
with
timeouts. At that point the tcp6 layer seems quite hosed. It usually gets
to that point within a few minutes of starting the loop. Stopping the script
after that
point seems to have no positive effect.
https://github.com/runningdogx/net6-bug
Using that script, I get something like the following output, although sometimes
it
takes a few more minutes before the timeouts begin. Using 127.0.0.1 to test
against tcp4 shows no net unreachables and no timeouts. All the errors
displayed
once the timestamped loops start are from attempts to connect to a port that's
supposed to be closed.
Kernel log is empty since boot.
All this still in a standard ubuntu 10.10 amd64 smp vm.
----output----
# ruby net6-bug/tcp6br.rb ::1 3333
If you're not root, you'll need to enable tcp_tw_recycle yourself
Server listening on ::1:3333
Chose port 55555 (should be closed) to test if stack is functioning
14:28:06 SYN_S:1 SYN_R:0 TWAIT:7 FW1:0 FW2:0 CLOSING:0 LACK:0
14:28:11 SYN_S:1 SYN_R:0 TWAIT:8 FW1:0 FW2:0 CLOSING:0 LACK:0
14:28:16 SYN_S:1 SYN_R:0 TWAIT:12 FW1:0 FW2:0 CLOSING:0 LACK:0
14:28:21 SYN_S:1 SYN_R:0 TWAIT:12 FW1:0 FW2:0 CLOSING:0 LACK:0
14:28:26 SYN_S:1 SYN_R:0 TWAIT:12 FW1:0 FW2:0 CLOSING:0 LACK:0
14:28:31 SYN_S:1 SYN_R:0 TWAIT:17 FW1:0 FW2:0 CLOSING:0 LACK:0
14:28:36 SYN_S:0 SYN_R:0 TWAIT:15 FW1:1 FW2:0 CLOSING:0 LACK:0
tcp socket error: Net Unreachable
14:28:41 SYN_S:1 SYN_R:0 TWAIT:17 FW1:0 FW2:0 CLOSING:0 LACK:0
14:28:46 SYN_S:1 SYN_R:0 TWAIT:16 FW1:0 FW2:0 CLOSING:0 LACK:0
14:28:51 SYN_S:1 SYN_R:0 TWAIT:19 FW1:0 FW2:0 CLOSING:0 LACK:1
14:28:56 SYN_S:1 SYN_R:0 TWAIT:18 FW1:0 FW2:0 CLOSING:0 LACK:0
14:29:01 SYN_S:1 SYN_R:0 TWAIT:19 FW1:0 FW2:0 CLOSING:0 LACK:0
14:29:06 SYN_S:1 SYN_R:0 TWAIT:10 FW1:0 FW2:0 CLOSING:0 LACK:0
14:29:11 SYN_S:1 SYN_R:0 TWAIT:8 FW1:0 FW2:0 CLOSING:0 LACK:0
14:29:16 SYN_S:1 SYN_R:0 TWAIT:8 FW1:0 FW2:0 CLOSING:0 LACK:0
14:29:21 SYN_S:1 SYN_R:0 TWAIT:7 FW1:0 FW2:0 CLOSING:0 LACK:0
14:29:26 SYN_S:1 SYN_R:0 TWAIT:4 FW1:0 FW2:0 CLOSING:0 LACK:0
14:29:31 SYN_S:1 SYN_R:0 TWAIT:5 FW1:0 FW2:0 CLOSING:0 LACK:0
14:29:36 SYN_S:1 SYN_R:0 TWAIT:5 FW1:0 FW2:0 CLOSING:0 LACK:0
14:29:41 SYN_S:1 SYN_R:0 TWAIT:4 FW1:0 FW2:0 CLOSING:0 LACK:0
14:29:46 SYN_S:1 SYN_R:0 TWAIT:5 FW1:0 FW2:0 CLOSING:0 LACK:0
14:29:51 SYN_S:1 SYN_R:0 TWAIT:3 FW1:0 FW2:0 CLOSING:0 LACK:0
14:29:56 SYN_S:1 SYN_R:0 TWAIT:4 FW1:0 FW2:0 CLOSING:0 LACK:0
14:30:01 SYN_S:1 SYN_R:0 TWAIT:5 FW1:4 FW2:0 CLOSING:0 LACK:1
tcp socket error: Net Unreachable
14:30:06 SYN_S:1 SYN_R:0 TWAIT:6 FW1:2 FW2:0 CLOSING:0 LACK:1
14:30:32 SYN_S:1 SYN_R:0 TWAIT:5 FW1:0 FW2:0 CLOSING:0 LACK:0
14:30:37 SYN_S:1 SYN_R:0 TWAIT:5 FW1:0 FW2:0 CLOSING:0 LACK:0
14:30:42 SYN_S:1 SYN_R:0 TWAIT:3 FW1:0 FW2:0 CLOSING:0 LACK:0
14:30:47 SYN_S:1 SYN_R:0 TWAIT:3 FW1:0 FW2:0 CLOSING:0 LACK:0
!! TCP SOCKET TIMED OUT CONNECTING TO A LOCAL CLOSED PORT
14:34:02 SYN_S:1 SYN_R:0 TWAIT:0 FW1:0 FW2:0 CLOSING:0 LACK:0
!! TCP SOCKET TIMED OUT CONNECTING TO A LOCAL CLOSED PORT
14:37:16 SYN_S:1 SYN_R:0 TWAIT:0 FW1:0 FW2:0 CLOSING:0 LACK:0
!! TCP SOCKET TIMED OUT CONNECTING TO A LOCAL CLOSED PORT
14:40:30 SYN_S:1 SYN_R:0 TWAIT:0 FW1:0 FW2:0 CLOSING:0 LACK:0
^C
^ permalink raw reply
* Re: [PATCH v2 16/16] skge: convert to hw_features
From: Michał Mirosław @ 2011-01-31 22:40 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: netdev, Ben Hutchings
In-Reply-To: <20110131215343.GA19379@rere.qmqm.pl>
On Mon, Jan 31, 2011 at 10:53:43PM +0100, Michał Mirosław wrote:
> On Mon, Jan 31, 2011 at 08:45:02AM -0800, Stephen Hemminger wrote:
> > On Sat, 22 Jan 2011 23:14:14 +0100 (CET)
> > Michał Mirosław <mirq-linux@rere.qmqm.pl> wrote:
> > > The hardware might do full HW_CSUM, not just IP_CSUM, but it's not tested
> > > and so not changed here.
> > > Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
> > The skge hardware does not do full HW_CSUM. It looks at the IP header.
> Driver code suggests otherwise. Please look at skge_xmit_frame() and TX
> descriptor format.
>
> Besides, I'm locally using a patch that makes skge advertise HW_CSUM - TCP
> over IPv6 is correctly checksummed in hardware (haven't tried VLANs yet).
IPv4 UDP inside VLAN-tagged packet is also checksummed properly by hardware.
I don't have time now to make a proper HW_CSUM test (with arbitrary header
prepended). If someone has one (or patches?), I'd be glad to use it, though.
Best Regards,
Michał Mirosław
^ permalink raw reply
* [net-2.6 PATCH 3/3] net: dcb: application priority is per net_device
From: John Fastabend @ 2011-01-31 22:00 UTC (permalink / raw)
To: davem; +Cc: john.r.fastabend, netdev
In-Reply-To: <20110131220048.29758.22379.stgit@jf-dev1-dcblab>
The app_data priority may not be the same for all net devices.
In order for stacks with application notifiers to identify the
specific net device dcb_app_type should be passed in the ptr.
This allows handlers to use dev_get_by_name() to pin priority
to net devices.
Signed-off-by: John Fastabend <john.r.fastabend@intel.com>
---
net/dcb/dcbnl.c | 6 +++++-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/net/dcb/dcbnl.c b/net/dcb/dcbnl.c
index e3399d6..249bcec 100644
--- a/net/dcb/dcbnl.c
+++ b/net/dcb/dcbnl.c
@@ -1613,6 +1613,10 @@ EXPORT_SYMBOL(dcb_getapp);
u8 dcb_setapp(struct net_device *dev, struct dcb_app *new)
{
struct dcb_app_type *itr, *tmp;
+ struct dcb_app_type event;
+
+ memcpy(&event.name, dev->name, sizeof(event.name));
+ memcpy(&event.app, new, sizeof(event.app));
spin_lock(&dcb_lock);
/* Search for existing match and replace */
@@ -1644,7 +1648,7 @@ u8 dcb_setapp(struct net_device *dev, struct dcb_app *new)
}
out:
spin_unlock(&dcb_lock);
- call_dcbevent_notifiers(DCB_APP_EVENT, new);
+ call_dcbevent_notifiers(DCB_APP_EVENT, &event);
return 0;
}
EXPORT_SYMBOL(dcb_setapp);
^ permalink raw reply related
* [net-2.6 PATCH 2/3] net: dcb: use _safe() version of list iterators
From: John Fastabend @ 2011-01-31 22:00 UTC (permalink / raw)
To: davem; +Cc: john.r.fastabend, netdev
In-Reply-To: <20110131220048.29758.22379.stgit@jf-dev1-dcblab>
Use _safe() version of list iterator macros in dcb_setapp().
Signed-off-by: John Fastabend <john.r.fastabend@intel.com>
---
net/dcb/dcbnl.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/net/dcb/dcbnl.c b/net/dcb/dcbnl.c
index 6b03f56..e3399d6 100644
--- a/net/dcb/dcbnl.c
+++ b/net/dcb/dcbnl.c
@@ -1605,18 +1605,18 @@ u8 dcb_getapp(struct net_device *dev, struct dcb_app *app)
EXPORT_SYMBOL(dcb_getapp);
/**
- * ixgbe_dcbnl_setapp - add dcb application data to app list
+ * dcbnl_setapp - add dcb application data to app list
*
* Priority 0 is the default priority this removes applications
* from the app list if the priority is set to zero.
*/
u8 dcb_setapp(struct net_device *dev, struct dcb_app *new)
{
- struct dcb_app_type *itr;
+ struct dcb_app_type *itr, *tmp;
spin_lock(&dcb_lock);
/* Search for existing match and replace */
- list_for_each_entry(itr, &dcb_app_list, list) {
+ list_for_each_entry_safe(itr, tmp, &dcb_app_list, list) {
if (itr->app.selector == new->selector &&
itr->app.protocol == new->protocol &&
(strncmp(itr->name, dev->name, IFNAMSIZ) == 0)) {
^ permalink raw reply related
* [net-2.6 PATCH 1/3] net: dcb: match dcb_app protocol field with 802.1Qaz spec
From: John Fastabend @ 2011-01-31 22:00 UTC (permalink / raw)
To: davem; +Cc: john.r.fastabend, netdev
The dcb_app protocol field is a __u32 however the 802.1Qaz
specification defines it as a 16 bit field. This patch brings
the structure inline with the spec making it a __u16.
Signed-off-by: John Fastabend <john.r.fastabend@intel.com>
---
include/linux/dcbnl.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/linux/dcbnl.h b/include/linux/dcbnl.h
index 68cd248..bdc7ef4 100644
--- a/include/linux/dcbnl.h
+++ b/include/linux/dcbnl.h
@@ -101,7 +101,7 @@ struct ieee_pfc {
*/
struct dcb_app {
__u8 selector;
- __u32 protocol;
+ __u16 protocol;
__u8 priority;
};
^ permalink raw reply related
* Re: patch "appletalk: move to staging" added to staging tree
From: David Miller @ 2011-01-31 22:05 UTC (permalink / raw)
To: arnd; +Cc: gregkh, acme, netdev
In-Reply-To: <201101312255.39981.arnd@arndb.de>
From: Arnd Bergmann <arnd@arndb.de>
Date: Mon, 31 Jan 2011 22:55:39 +0100
> On Monday 31 January 2011, gregkh@suse.de wrote:
>>
>> This is a note to let you know that I've just added the patch titled
>>
>> appletalk: move to staging
>>
>> to my staging git tree which can be found at
>> git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging-2.6.git
>> in the staging-next branch.
>
> Actually, David Miller objected to this patch for good reasons, please
> revert it. One of the other patches removes the BKL in appletalk, so
> we should find a way to keep it.
Right.
^ permalink raw reply
* Re: [PATCH] Make INET_LHTABLE_SIZE a compile-time tunable
From: David Miller @ 2011-01-31 22:05 UTC (permalink / raw)
To: wsommerfeld; +Cc: netdev, therbert
In-Reply-To: <AANLkTi=5ncH6aRY5ifA0TONB7L5RDdHkriMY1p=aDxs6@mail.gmail.com>
From: Bill Sommerfeld <wsommerfeld@google.com>
Date: Mon, 31 Jan 2011 13:52:03 -0800
> On Fri, Jan 14, 2011 at 13:48, I wrote:
>> INET_LHTABLE_SIZE has been fixed at 32 for a long time. It should be
>> tunable as larger systems may be running many more than 32 listeners.
>
> I haven't seen any responses to this patch submission. Can someone
> take a look? Thanks.
It should be dynamically sized. Compile time configuration knobs
generally stick.
^ permalink raw reply
* Re: patch "appletalk: move to staging" added to staging tree
From: Greg KH @ 2011-01-31 22:02 UTC (permalink / raw)
To: Arnd Bergmann; +Cc: acme, netdev, David Miller
In-Reply-To: <201101312255.39981.arnd@arndb.de>
On Mon, Jan 31, 2011 at 10:55:39PM +0100, Arnd Bergmann wrote:
> On Monday 31 January 2011, gregkh@suse.de wrote:
> >
> > This is a note to let you know that I've just added the patch titled
> >
> > appletalk: move to staging
> >
> > to my staging git tree which can be found at
> > git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging-2.6.git
> > in the staging-next branch.
>
> Actually, David Miller objected to this patch for good reasons, please
> revert it. One of the other patches removes the BKL in appletalk, so
> we should find a way to keep it.
Oops, sorry about that, I'll go revert it.
greg k-h
^ permalink raw reply
* Re: patch "appletalk: move to staging" added to staging tree
From: Arnd Bergmann @ 2011-01-31 21:55 UTC (permalink / raw)
To: gregkh; +Cc: acme, netdev, David Miller
In-Reply-To: <12965099622238@site>
On Monday 31 January 2011, gregkh@suse.de wrote:
>
> This is a note to let you know that I've just added the patch titled
>
> appletalk: move to staging
>
> to my staging git tree which can be found at
> git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging-2.6.git
> in the staging-next branch.
Actually, David Miller objected to this patch for good reasons, please
revert it. One of the other patches removes the BKL in appletalk, so
we should find a way to keep it.
Arnd
^ permalink raw reply
* Re: [PATCH v2 16/16] skge: convert to hw_features
From: Michał Mirosław @ 2011-01-31 21:53 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: netdev, Ben Hutchings
In-Reply-To: <20110131084502.7be146e7@nehalam>
On Mon, Jan 31, 2011 at 08:45:02AM -0800, Stephen Hemminger wrote:
> On Sat, 22 Jan 2011 23:14:14 +0100 (CET)
> Michał Mirosław <mirq-linux@rere.qmqm.pl> wrote:
> > The hardware might do full HW_CSUM, not just IP_CSUM, but it's not tested
> > and so not changed here.
> > Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
> The skge hardware does not do full HW_CSUM. It looks at the IP header.
Driver code suggests otherwise. Please look at skge_xmit_frame() and TX
descriptor format.
Besides, I'm locally using a patch that makes skge advertise HW_CSUM - TCP
over IPv6 is correctly checksummed in hardware (haven't tried VLANs yet).
Best Regards,
Michał Mirosław
^ permalink raw reply
* Re: [PATCH] Make INET_LHTABLE_SIZE a compile-time tunable
From: Bill Sommerfeld @ 2011-01-31 21:52 UTC (permalink / raw)
To: netdev; +Cc: David S. Miller, Tom Herbert, Bill Sommerfeld
In-Reply-To: <1295041688-16550-1-git-send-email-wsommerfeld@google.com>
On Fri, Jan 14, 2011 at 13:48, I wrote:
> INET_LHTABLE_SIZE has been fixed at 32 for a long time. It should be
> tunable as larger systems may be running many more than 32 listeners.
I haven't seen any responses to this patch submission. Can someone
take a look? Thanks.
- Bill
^ permalink raw reply
* Re: pull request: batman-adv 2011-01-31
From: David Miller @ 2011-01-31 21:26 UTC (permalink / raw)
To: sven; +Cc: netdev
In-Reply-To: <1296487251-12552-1-git-send-email-sven@narfation.org>
From: Sven Eckelmann <sven@narfation.org>
Date: Mon, 31 Jan 2011 16:20:42 +0100
> Hi,
>
> I would like to propose some changes for net-next-2.6.git. These include two
> bugfixes for the fragmentation handling which were not accepted in net-2.6. The
> last seven changes are only cleanups and non-functionality changes.
>
> No included change has any hard dependencies to the oops fixes which were
> pulled by you into net-2.6 yesterday.
>
> thanks,
> Sven
>
> The following changes since commit 1bae4ce27c9c90344f23c65ea6966c50ffeae2f5:
>
> Linux 2.6.38-rc2 (2011-01-21 19:01:34 -0800)
>
> are available in the git repository at:
> git://git.open-mesh.org/ecsv/linux-merge.git batman-adv/next
Pulled, thanks Sven.
^ permalink raw reply
* Re: [PATCH net-next 0/10] bnx2x: Few enhancements and styling fixes
From: David Miller @ 2011-01-31 21:24 UTC (permalink / raw)
To: yanivr; +Cc: netdev, eilong
In-Reply-To: <1296483683.17181.110.camel@lb-tlvb-dmitry>
From: "Yaniv Rosner" <yanivr@broadcom.com>
Date: Mon, 31 Jan 2011 16:21:23 +0200
> The following patch series describe some link enhancements and styling fixes in bnx2x driver.
> It should not cause conflicts when integrating the net-2.6.
How can it not cause conflicts, when there is a driver version update
in yesterday's net-2.6 patch set as well as this one.
> Please consider applying it to net-next.
I've applied this series to net-next-2.6, resolving the version conflict by
hand.
^ permalink raw reply
* Re: [PATCH] CAN: softing driver depends on IOMEM
From: David Miller @ 2011-01-31 21:20 UTC (permalink / raw)
To: kurt.van.dijck; +Cc: cebbert, netdev
In-Reply-To: <20110131160334.GC334@e-circ.dyndns.org>
From: Kurt Van Dijck <kurt.van.dijck@eia.be>
Date: Mon, 31 Jan 2011 17:03:34 +0100
> On Mon, Jan 31, 2011 at 10:44:07AM -0500, Chuck Ebbert wrote:
>> CAN: softing driver depends on IOMEM
> Acked-by: Kurt Van Dijck <kurt.van.dijck@eia.be>
Applied, thanks.
^ permalink raw reply
* Re: linux-next: Tree for January 31 (ip_vs)
From: Simon Horman @ 2011-01-31 21:18 UTC (permalink / raw)
To: Randy Dunlap; +Cc: Stephen Rothwell, netdev, linux-next, LKML
In-Reply-To: <20110131101829.b842da44.randy.dunlap@oracle.com>
On Mon, Jan 31, 2011 at 10:18:29AM -0800, Randy Dunlap wrote:
> On Mon, 31 Jan 2011 17:41:13 +1100 Stephen Rothwell wrote:
>
> > Hi all,
> >
> > Changes since 20110121:
> >
> > The net tree lost its build failure.
>
>
> When CONFIG_SYSCTL is not enabled:
>
> net/netfilter/ipvs/ip_vs_core.c:1891: warning: format '%lu' expects type 'long unsigned int', but argument 2 has type 'unsigned int'
> ERROR: "unregister_net_sysctl_table" [net/netfilter/ipvs/ip_vs.ko] undefined!
> ERROR: "register_net_sysctl_table" [net/netfilter/ipvs/ip_vs.ko] undefined!
Thanks, I'm looking into it.
^ permalink raw reply
* Re: [PATCH] Add default_mtu() methods to blackhole dst_ops
From: David Miller @ 2011-01-31 21:15 UTC (permalink / raw)
To: roland; +Cc: netdev
In-Reply-To: <87fws8zsit.fsf@shaolin.home.digitalvampire.org>
From: Roland Dreier <roland@digitalvampire.org>
Date: Mon, 31 Jan 2011 13:12:58 -0800
> From: Roland Dreier <roland@purestorage.com>
>
> When an IPSEC SA is still being set up, __xfrm_lookup() will return
> -EREMOTE and so ip_route_output_flow() will return a blackhole route.
> This can happen in a sndmsg call, and after d33e455337ea ("net: Abstract
> default MTU metric calculation behind an accessor.") this leads to a
> crash in ip_append_data() because the blackhole dst_ops have no
> default_mtu() method and so dst_mtu() calls a NULL pointer.
>
> Fix this by adding default_mtu() methods (that simply return 0, matching
> the old behavior) to the blackhole dst_ops.
>
> The IPv4 part of this patch fixes a crash that I saw when using an IPSEC
> VPN; the IPv6 part is untested because I don't have an IPv6 VPN, but it
> looks to be needed as well.
>
> Signed-off-by: Roland Dreier <roland@purestorage.com>
Thanks so much for tracking this down and fixing it. I was going to look
at your traces and report later today.
I'll apply this, thanks again Roland.
^ permalink raw reply
* Re: IAMT broken by commit 82776a4bcd7aa5fbcd2e6339b3ce88b727dd40ab
From: David Miller @ 2011-01-31 20:36 UTC (permalink / raw)
To: aurelien; +Cc: bruce.w.allan, jeffrey.t.kirsher, netdev
In-Reply-To: <20110131114558.GA28303@volta.aurel32.net>
From: Aurelien Jarno <aurelien@aurel32.net>
Date: Mon, 31 Jan 2011 12:45:58 +0100
>> On recent kernels, IAMT support does not work after the machine has
>> been powered-off. Even worse, it also goes into this state when I try
>> to reboot it.
>>
>> I have done a bisect and got this commit:
>>
>> | commit 82776a4bcd7aa5fbcd2e6339b3ce88b727dd40ab
>> | Author: Bruce Allan <bruce.w.allan@intel.com>
>> | Date: Fri Aug 14 14:35:33 2009 +0000
>> |
>> | e1000e: WoL does not work on 82577/82578 with manageability enabled
>> |
>> | With manageability (Intel AMT) enabled via BIOS, PHY wakeup does not get
>> | configured on newer parts which use PHY wakeup vs. MAC wakeup which causes
>> | WoL to not work. The driver should configure PHY wakeup whether or not
>> | manageability is enabled.
>> |
>> | Signed-off-by: Bruce Allan <bruce.w.allan@intel.com>
>> | Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
>> | Signed-off-by: David S. Miller <davem@davemloft.net>
>>
>> I have tried to revert it on recent kernels (2.6.34), and IAMT is then
>> working as expected. My machine is using a Gigabyte EQ45M-S2 motherboard
>> with an 82567LM-3 ethernet chip (8086:10de), that is a different model
>> than the one of the original problem.
>>
>> I do wonder if the changes in the patch should not only be done on some
>> chip models, and I will appreciate any help in fixing this issue.
>>
>
> Just a short mail to say this problem is still present in 2.6.38-rc2.
> The same solution still applies, that is reverting the above commit.
> Note that reverting the first hunk only is enough to get it working
> again.
Intel folks please look into this.
^ permalink raw reply
* Re: [PATCH 0/7] netfilter: netfilter update for -next
From: David Miller @ 2011-01-31 20:32 UTC (permalink / raw)
To: kaber; +Cc: netfilter-devel, netdev
In-Reply-To: <1296504620-820-1-git-send-email-kaber@trash.net>
From: kaber@trash.net
Date: Mon, 31 Jan 2011 21:10:13 +0100
> following is a small netfilter update for net-next, containing:
>
> - compiler warning fixes for IPVS from Changli
>
> - IPVS netns fixes from Simon and Hans Schillstrom
>
> - a fix for connlimit destination address selection in NAT scenarios,
> from Jan
>
> - minor iprange bugfixes and debugging improvements from Thomas Jacob
>
> Please pull from:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/kaber/nf-next-2.6.git master
Pulled, thanks Patrick.
^ permalink raw reply
* [PATCH 6/7] netfilter: xt_iprange: typo in IPv4 match debug print code
From: kaber @ 2011-01-31 20:10 UTC (permalink / raw)
To: davem; +Cc: netfilter-devel, netdev
In-Reply-To: <1296504620-820-1-git-send-email-kaber@trash.net>
From: Thomas Jacob <jacob@internet24.de>
Signed-off-by: Thomas Jacob <jacob@internet24.de>
Signed-off-by: Patrick McHardy <kaber@trash.net>
---
net/netfilter/xt_iprange.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/netfilter/xt_iprange.c b/net/netfilter/xt_iprange.c
index 88f7c35..77b9ebc 100644
--- a/net/netfilter/xt_iprange.c
+++ b/net/netfilter/xt_iprange.c
@@ -31,7 +31,7 @@ iprange_mt4(const struct sk_buff *skb, struct xt_action_param *par)
pr_debug("src IP %pI4 NOT in range %s%pI4-%pI4\n",
&iph->saddr,
(info->flags & IPRANGE_SRC_INV) ? "(INV) " : "",
- &info->src_max.ip,
+ &info->src_min.ip,
&info->src_max.ip);
return false;
}
--
1.7.2.3
^ permalink raw reply related
* [PATCH 5/7] netfilter: xt_connlimit: pick right dstaddr in NAT scenario
From: kaber @ 2011-01-31 20:10 UTC (permalink / raw)
To: davem; +Cc: netfilter-devel, netdev
In-Reply-To: <1296504620-820-1-git-send-email-kaber@trash.net>
From: Jan Engelhardt <jengelh@medozas.de>
xt_connlimit normally records the "original" tuples in a hashlist
(such as "1.2.3.4 -> 5.6.7.8"), and looks in this list for iph->daddr
when counting.
When the user however uses DNAT in PREROUTING, looking for
iph->daddr -- which is now 192.168.9.10 -- will not match. Thus in
daddr mode, we need to record the reverse direction tuple
("192.168.9.10 -> 1.2.3.4") instead. In the reverse tuple, the dst
addr is on the src side, which is convenient, as count_them still uses
&conn->tuple.src.u3.
Signed-off-by: Jan Engelhardt <jengelh@medozas.de>
---
net/netfilter/xt_connlimit.c | 12 ++++++++----
1 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/net/netfilter/xt_connlimit.c b/net/netfilter/xt_connlimit.c
index 7fd3fd5..e029c48 100644
--- a/net/netfilter/xt_connlimit.c
+++ b/net/netfilter/xt_connlimit.c
@@ -185,11 +185,15 @@ connlimit_mt(const struct sk_buff *skb, struct xt_action_param *par)
int connections;
ct = nf_ct_get(skb, &ctinfo);
- if (ct != NULL)
- tuple_ptr = &ct->tuplehash[0].tuple;
- else if (!nf_ct_get_tuplepr(skb, skb_network_offset(skb),
- par->family, &tuple))
+ if (ct != NULL) {
+ if (info->flags & XT_CONNLIMIT_DADDR)
+ tuple_ptr = &ct->tuplehash[IP_CT_DIR_REPLY].tuple;
+ else
+ tuple_ptr = &ct->tuplehash[IP_CT_DIR_ORIGINAL].tuple;
+ } else if (!nf_ct_get_tuplepr(skb, skb_network_offset(skb),
+ par->family, &tuple)) {
goto hotdrop;
+ }
if (par->family == NFPROTO_IPV6) {
const struct ipv6hdr *iph = ipv6_hdr(skb);
--
1.7.2.3
^ permalink raw reply related
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox