* OT: Re: [PATCH] CAN: add controller hardware name for Softing cards
From: Oliver Hartkopp @ 2011-02-21 17:26 UTC (permalink / raw)
To: Marc Kleine-Budde, Wolfgang Grandegger; +Cc: Kurt Van Dijck, netdev
In-Reply-To: <4D622CC1.5050402@pengutronix.de>
On 21.02.2011 10:13, Marc Kleine-Budde wrote:
> On 02/21/2011 10:04 AM, Kurt Van Dijck wrote:
>> I just found that the controller hardware name is not set for the Softing
>> driver. After this patch, "$ ip -d link show" looks nicer.
>>
>> Signed-off-by: Kurt Van Dijck <kurt.van.dijck@eia.be>
> Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>
>
Hello Marc,
i really appreciate your work regarding the CAN driver maintenance together
with Wolfgang!
Would it probably make sense to add your name to the drivers/net/can section
in the MAINTAINERS file so that Dave and the other listeners on netdev-ML can
appraise your Acked-by more easily?
Regards,
Oliver
^ permalink raw reply
* Re: Huge ammount of invalid checksum packets on macvlan
From: Andrian Nord @ 2011-02-21 17:39 UTC (permalink / raw)
To: Daniel Lezcano
Cc: Linux Netdev List, lxc-users-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f,
Patrick McHardy
In-Reply-To: <4D628DC3.9000400-GANU6spQydw@public.gmane.org>
[-- Attachment #1.1: Type: text/plain, Size: 2419 bytes --]
On Mon, Feb 21, 2011 at 05:07:31PM +0100, Daniel Lezcano wrote:
> IMO, the checksum is not needed for the virtual macvlan devices, hence
Well, maybe then I've made a horrible mistake of asking the wrong
question. It's not a bad checksums that are wondering me, but very poor
network traffic performance: I'm getting about ~25kbps of
/dev/zero-to-/dev/null copy via netcat between hosts and mysql queries
from container other than mysql's are horribly laggy.
Strangely enough - while there is such bug on both systems, they are
behaving differently.
First system (router):
eth1 eth0 dummy0
|----|------------|-----------|-----| macvlans |------------|
| macvlan "lan" | |-------------------------| containers |
| / \ | | | | -----------|
|--|---|----------|-----------|-----|
| | | | macvlan
| | |----------------|------|
--- | | eth0 eth1 eth2 | Router-container
LAN | | | |
--- \---------------/ |
|-----------------------|
And bug appears much less when copying from container to container, or
from container to HN (but still noticeable, especially in mysql queries),
but it's seen very well when copying from LAN to container. netcat copy
transfer rate shows enormous ~300 Mbps.
/proc/net/dev show many transfer errors but 0 receive errors.
Second system (server):
eth0 eth1 dummy0
|----------------------------|---------------|
| no carrier |-macvlan "lxc" |
|----------------------------|---------------|
|
|---------------------------|
| containers |
|---------------------------|
We can't link macvlans on eth1, as it has no carrier and macvlans are
not working in this case. Here bug is seen very well, even in
transferring packets from container to container (netcat copy transfer
rate is ~40kbps on this system).
/proc/net/dev show may errors in both directions.
First system is slightly more powerful, but difference in
between-container performance is just too big. Also, tcpdump on both
system reports kernel-dropped packets in great amount.
P.S. netcat copy is:
lxc1) nc6 -l -p 12345 > /dev/null
lxc2) dd if=/dev/zero | nc6 lxc1 12345
[-- Attachment #1.2: Type: application/pgp-signature, Size: 198 bytes --]
[-- Attachment #2: Type: text/plain, Size: 387 bytes --]
------------------------------------------------------------------------------
The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE:
Pinpoint memory and threading errors before they happen.
Find and fix more than 250 security defects in the development cycle.
Locate bottlenecks in serial and parallel code that limit performance.
http://p.sf.net/sfu/intel-dev2devfeb
[-- Attachment #3: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply
* Re: [PATCH] bonding: bond_select_queue off by one
From: Andy Gospodarek @ 2011-02-21 18:06 UTC (permalink / raw)
To: Ben Hutchings; +Cc: Andy Gospodarek, Jay Vosburgh, Phil Oester, netdev
In-Reply-To: <1298070372.2211.59.camel@localhost>
On Fri, Feb 18, 2011 at 11:06:12PM +0000, Ben Hutchings wrote:
> On Fri, 2011-02-18 at 17:49 -0500, Andy Gospodarek wrote:
> > --- a/include/linux/skbuff.h
> > +++ b/include/linux/skbuff.h
> > @@ -2194,6 +2194,21 @@ static inline bool skb_rx_queue_recorded(const struct sk_buff *skb)
> > return skb->queue_mapping != 0;
> > }
> >
> > +static inline void skb_record_tx_queue(struct sk_buff *skb, u16 tx_queue)
> > +{
> > + skb->queue_mapping = tx_queue + 1;
> > +}
> > +
> > +static inline u16 skb_get_tx_queue(const struct sk_buff *skb)
> > +{
> > + return skb->queue_mapping - 1;
> > +}
> > +
> > +static inline bool skb_tx_queue_recorded(const struct sk_buff *skb)
> > +{
> > + return skb->queue_mapping != 0;
> > +}
> > +
> [...]
>
> This is nonsense. After the TX queue has been selected, it's recorded
> in queue_mapping *without* the offset (skb_set_queue_mapping()).
>
I see that now. Yay for symmetry! :)
I'm actually looking over this now and will post a tested patch to
address the original reporter's problem.
^ permalink raw reply
* Re: [PATCH] xps-mq: Transmit Packet Steering for multiqueue
From: Ben Hutchings @ 2011-02-21 18:19 UTC (permalink / raw)
To: David Miller; +Cc: therbert, eric.dumazet, shemminger, netdev
In-Reply-To: <20100901.183251.106803238.davem@davemloft.net>
On Wed, 2010-09-01 at 18:32 -0700, David Miller wrote:
> From: Tom Herbert <therbert@google.com>
> Date: Wed, 1 Sep 2010 09:24:18 -0700
>
> > On Wed, Sep 1, 2010 at 8:54 AM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
> >> 3) Eventually have a user selectable selection (socket option, or system
> >> wide, but one sysctl, not many bitmasks ;) ).
> >>
> > Right, but it would also be nice if a single sysctl could optimally
> > set up multiqueue, RSS, RPS, and all my interrupt affinities for me
> > ;-)
>
> It's becomming increasingly obvious to me that we need (somewhere,
> not necessarily the kernel) a complete datastructure representing
> the NUMA, cache, cpu, device hierarchy.
>
> And that can be used to tweak all of this stuff.
>
> The policy should probably be in userspace, we just need to provide
> the knobs in the kernel to tweak it however userspace wants.
>
> Userspace should be able to, for example, move a TX queue into a
> NUMA domain and have this invoke several side effects:
I think most of the pieces are now ready:
> 1) IRQs for that TX queue get rerouted to a cpu in the NUMA
> domain.
There is a longstanding procfs interface for IRQ affinity, and userland
infrastructure built on it. Adding a new interface would be contentious
and I have tried to build on it instead.
> 2) TX queue datastructures in the driver get reallocated using
> memory in that NUMA domain.
I've previously sent patches to add an ethtool API for NUMA control,
which include the option to allocate on the same node where IRQs are
handled. However, there is currently no function to allocate
DMA-coherent memory on a specified NUMA node (rather than the device's
node). This is likely to be beneficial for event rings and might be
good for descriptor rings for some devices. (The implementation I sent
for sfc mistakenly switched it to allocating non-coherent memory, for
which it *is* possible to specify the node.)
> 3) TX hashing is configured to use the set of cpus in the NUMA
> domain.
I posted patches for automatic XPS configuration at the end of last
week. And RFS acceleration covers the other direction.
Ben.
> It's alot of tedious work and involves some delicate tasks figuring
> out where each of these things go, but really then we'd solve all
> of this crap one and for all.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
^ permalink raw reply
* [PATCH ethtool 0/5] Add --version option and fix some bugs in show_usage()
From: Ben Hutchings @ 2011-02-21 19:16 UTC (permalink / raw)
To: netdev
Every command-line tool needs a --version option, right? And while
looking at the existing option parsing and usage messages I found and
fixed some bugs.
Ben.
Ben Hutchings (5):
ethtool: Split show_usage() into two functions
ethtool: Report an error if given an unrecognised option
ethtool: Allow for long options with no short option and without a
device name
ethtool: Indent the no-options usage line consistently with the
others
ethtool: Add --version option
ethtool.8.in | 5 ++
ethtool.c | 165 +++++++++++++++++++++++++++++++--------------------------
2 files changed, 95 insertions(+), 75 deletions(-)
--
1.7.3.4
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
^ permalink raw reply
* [PATCH ethtool 1/5] ethtool: Split show_usage() into two functions
From: Ben Hutchings @ 2011-02-21 19:17 UTC (permalink / raw)
To: netdev
In-Reply-To: <1298315809.2608.68.camel@bwh-desktop>
show_usage(0) and show_usage(1) now do unrelated things; split it
into show_usage() and exit_bad_args().
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
---
ethtool.c | 144 +++++++++++++++++++++++++++++++------------------------------
1 files changed, 73 insertions(+), 71 deletions(-)
diff --git a/ethtool.c b/ethtool.c
index f680b6d..b9422d3 100644
--- a/ethtool.c
+++ b/ethtool.c
@@ -268,32 +268,32 @@ static struct option {
};
-static void show_usage(int badarg) __attribute__((noreturn));
+static void exit_bad_args(void) __attribute__((noreturn));
-static void show_usage(int badarg)
+static void exit_bad_args(void)
+{
+ fprintf(stderr,
+ "ethtool: bad command line argument(s)\n"
+ "For more information run ethtool -h\n");
+ exit(1);
+}
+
+static void show_usage(void)
{
int i;
- if (badarg != 0) {
- fprintf(stderr,
- "ethtool: bad command line argument(s)\n"
- "For more information run ethtool -h\n"
- );
- }
- else {
- /* ethtool -h */
- fprintf(stdout, PACKAGE " version " VERSION "\n");
- fprintf(stdout,
+
+ /* ethtool -h */
+ fprintf(stdout, PACKAGE " version " VERSION "\n");
+ fprintf(stdout,
"Usage:\n"
"ethtool DEVNAME\tDisplay standard information about device\n");
- for (i = 0; args[i].srt; i++) {
- fprintf(stdout, " ethtool %s|%s %s\t%s\n%s",
- args[i].srt, args[i].lng,
- strstr(args[i].srt, "-h") ? "\t" : "DEVNAME",
- args[i].help,
- args[i].opthelp ? args[i].opthelp : "");
- }
+ for (i = 0; args[i].srt; i++) {
+ fprintf(stdout, " ethtool %s|%s %s\t%s\n%s",
+ args[i].srt, args[i].lng,
+ strstr(args[i].srt, "-h") ? "\t" : "DEVNAME",
+ args[i].help,
+ args[i].opthelp ? args[i].opthelp : "");
}
- exit(badarg);
}
static char *devname = NULL;
@@ -612,11 +612,11 @@ get_int_range(char *str, int base, long long min, long long max)
char *endp;
if (!str)
- show_usage(1);
+ exit_bad_args();
errno = 0;
v = strtoll(str, &endp, base);
if (errno || *endp || v < min || v > max)
- show_usage(1);
+ exit_bad_args();
return v;
}
@@ -627,11 +627,11 @@ get_uint_range(char *str, int base, unsigned long long max)
char *endp;
if (!str)
- show_usage(1);
+ exit_bad_args();
errno = 0;
v = strtoull(str, &endp, base);
if ( errno || *endp || v > max)
- show_usage(1);
+ exit_bad_args();
return v;
}
@@ -664,7 +664,7 @@ static void parse_generic_cmdline(int argc, char **argp,
*(int *)info[idx].seen_val = 1;
i += 1;
if (i >= argc)
- show_usage(1);
+ exit_bad_args();
switch (info[idx].type) {
case CMDL_BOOL: {
int *p = info[idx].wanted_val;
@@ -673,7 +673,7 @@ static void parse_generic_cmdline(int argc, char **argp,
else if (!strcmp(argp[i], "off"))
*p = 0;
else
- show_usage(1);
+ exit_bad_args();
break;
}
case CMDL_S32: {
@@ -712,7 +712,7 @@ static void parse_generic_cmdline(int argc, char **argp,
u32 *p = info[idx].wanted_val;
struct in_addr in;
if (!inet_aton(argp[i], &in))
- show_usage(1);
+ exit_bad_args();
*p = in.s_addr;
break;
}
@@ -728,7 +728,7 @@ static void parse_generic_cmdline(int argc, char **argp,
p = info[idx].wanted_val;
*p |= info[idx].flag_val;
} else if (strcmp(argp[i], "off")) {
- show_usage(1);
+ exit_bad_args();
}
break;
}
@@ -738,13 +738,13 @@ static void parse_generic_cmdline(int argc, char **argp,
break;
}
default:
- show_usage(1);
+ exit_bad_args();
}
break;
}
}
if( !found)
- show_usage(1);
+ exit_bad_args();
}
}
@@ -808,10 +808,12 @@ static void parse_cmdline(int argc, char **argp)
break;
}
if (mode == MODE_HELP ||
- (!args[k].srt && argp[i][0] == '-'))
- show_usage(0);
- else
+ (!args[k].srt && argp[i][0] == '-')) {
+ show_usage();
+ exit(0);
+ } else {
devname = argp[i];
+ }
break;
case 2:
if ((mode == MODE_SSET) ||
@@ -850,7 +852,7 @@ static void parse_cmdline(int argc, char **argp)
} else if (!strcmp(argp[i], "offline")) {
test_type = OFFLINE;
} else {
- show_usage(1);
+ exit_bad_args();
}
break;
} else if (mode == MODE_PHYS_ID) {
@@ -923,14 +925,14 @@ static void parse_cmdline(int argc, char **argp)
if (!strcmp(argp[i], "flow-type")) {
i += 1;
if (i >= argc) {
- show_usage(1);
+ exit_bad_args();
break;
}
parse_rxntupleopts(argc, argp, i);
i = argc;
break;
} else {
- show_usage(1);
+ exit_bad_args();
}
break;
}
@@ -938,54 +940,54 @@ static void parse_cmdline(int argc, char **argp)
if (!strcmp(argp[i], "rx-flow-hash")) {
i += 1;
if (i >= argc) {
- show_usage(1);
+ exit_bad_args();
break;
}
rx_fhash_get =
rxflow_str_to_type(argp[i]);
if (!rx_fhash_get)
- show_usage(1);
+ exit_bad_args();
} else
- show_usage(1);
+ exit_bad_args();
break;
}
if (mode == MODE_FLASHDEV) {
flash_region = strtol(argp[i], NULL, 0);
if ((flash_region < 0))
- show_usage(1);
+ exit_bad_args();
break;
}
if (mode == MODE_SNFC) {
if (!strcmp(argp[i], "rx-flow-hash")) {
i += 1;
if (i >= argc) {
- show_usage(1);
+ exit_bad_args();
break;
}
rx_fhash_set =
rxflow_str_to_type(argp[i]);
if (!rx_fhash_set) {
- show_usage(1);
+ exit_bad_args();
break;
}
i += 1;
if (i >= argc) {
- show_usage(1);
+ exit_bad_args();
break;
}
if (parse_rxfhashopts(argp[i],
&rx_fhash_val) < 0)
- show_usage(1);
+ exit_bad_args();
else
rx_fhash_changed = 1;
} else
- show_usage(1);
+ exit_bad_args();
break;
}
if (mode == MODE_SRXFHINDIR) {
if (!strcmp(argp[i], "equal")) {
if (argc != i + 2) {
- show_usage(1);
+ exit_bad_args();
break;
}
i += 1;
@@ -996,42 +998,42 @@ static void parse_cmdline(int argc, char **argp)
} else if (!strcmp(argp[i], "weight")) {
i += 1;
if (i >= argc) {
- show_usage(1);
+ exit_bad_args();
break;
}
rxfhindir_weight = argp + i;
i = argc;
} else {
- show_usage(1);
+ exit_bad_args();
}
break;
}
if (mode != MODE_SSET)
- show_usage(1);
+ exit_bad_args();
if (!strcmp(argp[i], "speed")) {
gset_changed = 1;
i += 1;
if (i >= argc)
- show_usage(1);
+ exit_bad_args();
speed_wanted = get_int(argp[i],10);
break;
} else if (!strcmp(argp[i], "duplex")) {
gset_changed = 1;
i += 1;
if (i >= argc)
- show_usage(1);
+ exit_bad_args();
if (!strcmp(argp[i], "half"))
duplex_wanted = DUPLEX_HALF;
else if (!strcmp(argp[i], "full"))
duplex_wanted = DUPLEX_FULL;
else
- show_usage(1);
+ exit_bad_args();
break;
} else if (!strcmp(argp[i], "port")) {
gset_changed = 1;
i += 1;
if (i >= argc)
- show_usage(1);
+ exit_bad_args();
if (!strcmp(argp[i], "tp"))
port_wanted = PORT_TP;
else if (!strcmp(argp[i], "aui"))
@@ -1043,12 +1045,12 @@ static void parse_cmdline(int argc, char **argp)
else if (!strcmp(argp[i], "fibre"))
port_wanted = PORT_FIBRE;
else
- show_usage(1);
+ exit_bad_args();
break;
} else if (!strcmp(argp[i], "autoneg")) {
i += 1;
if (i >= argc)
- show_usage(1);
+ exit_bad_args();
if (!strcmp(argp[i], "on")) {
gset_changed = 1;
autoneg_wanted = AUTONEG_ENABLE;
@@ -1056,56 +1058,56 @@ static void parse_cmdline(int argc, char **argp)
gset_changed = 1;
autoneg_wanted = AUTONEG_DISABLE;
} else {
- show_usage(1);
+ exit_bad_args();
}
break;
} else if (!strcmp(argp[i], "advertise")) {
gset_changed = 1;
i += 1;
if (i >= argc)
- show_usage(1);
+ exit_bad_args();
advertising_wanted = get_int(argp[i], 16);
break;
} else if (!strcmp(argp[i], "phyad")) {
gset_changed = 1;
i += 1;
if (i >= argc)
- show_usage(1);
+ exit_bad_args();
phyad_wanted = get_int(argp[i], 0);
break;
} else if (!strcmp(argp[i], "xcvr")) {
gset_changed = 1;
i += 1;
if (i >= argc)
- show_usage(1);
+ exit_bad_args();
if (!strcmp(argp[i], "internal"))
xcvr_wanted = XCVR_INTERNAL;
else if (!strcmp(argp[i], "external"))
xcvr_wanted = XCVR_EXTERNAL;
else
- show_usage(1);
+ exit_bad_args();
break;
} else if (!strcmp(argp[i], "wol")) {
gwol_changed = 1;
i++;
if (i >= argc)
- show_usage(1);
+ exit_bad_args();
if (parse_wolopts(argp[i], &wol_wanted) < 0)
- show_usage(1);
+ exit_bad_args();
wol_change = 1;
break;
} else if (!strcmp(argp[i], "sopass")) {
gwol_changed = 1;
i++;
if (i >= argc)
- show_usage(1);
+ exit_bad_args();
get_mac_addr(argp[i], sopass_wanted);
sopass_change = 1;
break;
} else if (!strcmp(argp[i], "msglvl")) {
i++;
if (i >= argc)
- show_usage(1);
+ exit_bad_args();
if (isdigit((unsigned char)argp[i][0])) {
msglvl_changed = 1;
msglvl_mask = ~0;
@@ -1122,7 +1124,7 @@ static void parse_cmdline(int argc, char **argp)
}
break;
}
- show_usage(1);
+ exit_bad_args();
}
}
@@ -1159,9 +1161,9 @@ static void parse_cmdline(int argc, char **argp)
}
if (devname == NULL)
- show_usage(1);
+ exit_bad_args();
if (strlen(devname) >= IFNAMSIZ)
- show_usage(1);
+ exit_bad_args();
}
static void dump_supported(struct ethtool_cmd *ep)
@@ -1512,7 +1514,7 @@ static void get_mac_addr(char *src, unsigned char *dest)
count = sscanf(src, "%2x:%2x:%2x:%2x:%2x:%2x",
&buf[0], &buf[1], &buf[2], &buf[3], &buf[4], &buf[5]);
if (count != ETH_ALEN)
- show_usage(1);
+ exit_bad_args();
for (i = 0; i < count; i++) {
dest[i] = buf[i];
@@ -3026,7 +3028,7 @@ static int do_srxfhindir(int fd, struct ifreq *ifr)
int err;
if (!rxfhindir_equal && !rxfhindir_weight)
- show_usage(1);
+ exit_bad_args();
indir_head.cmd = ETHTOOL_GRXFHINDIR;
indir_head.size = 0;
@@ -3094,7 +3096,7 @@ static int do_flash(int fd, struct ifreq *ifr)
if (flash < 0) {
fprintf(stdout, "Missing filename argument\n");
- show_usage(1);
+ exit_bad_args();
return 98;
}
@@ -3160,7 +3162,7 @@ static int do_srxntuple(int fd, struct ifreq *ifr)
if (err < 0)
perror("Cannot add new RX n-tuple filter");
} else {
- show_usage(1);
+ exit_bad_args();
}
return 0;
--
1.7.3.4
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
^ permalink raw reply related
* [PATCH ethtool 2/5] ethtool: Report an error if given an unrecognised option
From: Ben Hutchings @ 2011-02-21 19:18 UTC (permalink / raw)
To: netdev
In-Reply-To: <1298315809.2608.68.camel@bwh-desktop>
Previously we would print full usage information and return 0.
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
---
ethtool.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/ethtool.c b/ethtool.c
index b9422d3..d28f1b2 100644
--- a/ethtool.c
+++ b/ethtool.c
@@ -807,10 +807,11 @@ static void parse_cmdline(int argc, char **argp)
mode = args[k].Mode;
break;
}
- if (mode == MODE_HELP ||
- (!args[k].srt && argp[i][0] == '-')) {
+ if (mode == MODE_HELP) {
show_usage();
exit(0);
+ } else if (!args[k].srt && argp[i][0] == '-') {
+ exit_bad_args();
} else {
devname = argp[i];
}
--
1.7.3.4
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
^ permalink raw reply related
* [PATCH ethtool 3/5] ethtool: Allow for long options with no short option and without a device name
From: Ben Hutchings @ 2011-02-21 19:18 UTC (permalink / raw)
To: netdev
In-Reply-To: <1298315809.2608.68.camel@bwh-desktop>
Change loop conditions to check for a long option string.
Generalise check for whether option requires a device name.
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
---
ethtool.c | 23 ++++++++++++++---------
1 files changed, 14 insertions(+), 9 deletions(-)
diff --git a/ethtool.c b/ethtool.c
index d28f1b2..8246bda 100644
--- a/ethtool.c
+++ b/ethtool.c
@@ -287,12 +287,16 @@ static void show_usage(void)
fprintf(stdout,
"Usage:\n"
"ethtool DEVNAME\tDisplay standard information about device\n");
- for (i = 0; args[i].srt; i++) {
- fprintf(stdout, " ethtool %s|%s %s\t%s\n%s",
- args[i].srt, args[i].lng,
- strstr(args[i].srt, "-h") ? "\t" : "DEVNAME",
- args[i].help,
- args[i].opthelp ? args[i].opthelp : "");
+ for (i = 0; args[i].lng; i++) {
+ fputs(" ethtool ", stdout);
+ if (args[i].srt)
+ fprintf(stdout, "%s|", args[i].srt);
+ fprintf(stdout, "%s %s\t%s\n",
+ args[i].lng,
+ args[i].Mode < 0 ? "\t" : "DEVNAME",
+ args[i].help);
+ if (args[i].opthelp)
+ fputs(args[i].opthelp, stdout);
}
}
@@ -801,8 +805,9 @@ static void parse_cmdline(int argc, char **argp)
for (i = 1; i < argc; i++) {
switch (i) {
case 1:
- for (k = 0; args[k].srt; k++)
- if (!strcmp(argp[i], args[k].srt) ||
+ for (k = 0; args[k].lng; k++)
+ if ((args[k].srt &&
+ !strcmp(argp[i], args[k].srt)) ||
!strcmp(argp[i], args[k].lng)) {
mode = args[k].Mode;
break;
@@ -810,7 +815,7 @@ static void parse_cmdline(int argc, char **argp)
if (mode == MODE_HELP) {
show_usage();
exit(0);
- } else if (!args[k].srt && argp[i][0] == '-') {
+ } else if (!args[k].lng && argp[i][0] == '-') {
exit_bad_args();
} else {
devname = argp[i];
--
1.7.3.4
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
^ permalink raw reply related
* [PATCH ethtool 4/5] ethtool: Indent the no-options usage line consistently with the others
From: Ben Hutchings @ 2011-02-21 19:18 UTC (permalink / raw)
To: netdev
In-Reply-To: <1298315809.2608.68.camel@bwh-desktop>
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
---
ethtool.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/ethtool.c b/ethtool.c
index 8246bda..32a97f6 100644
--- a/ethtool.c
+++ b/ethtool.c
@@ -286,7 +286,8 @@ static void show_usage(void)
fprintf(stdout, PACKAGE " version " VERSION "\n");
fprintf(stdout,
"Usage:\n"
- "ethtool DEVNAME\tDisplay standard information about device\n");
+ " ethtool DEVNAME\t"
+ "Display standard information about device\n");
for (i = 0; args[i].lng; i++) {
fputs(" ethtool ", stdout);
if (args[i].srt)
--
1.7.3.4
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
^ permalink raw reply related
* [PATCH ethtool 5/5] ethtool: Add --version option
From: Ben Hutchings @ 2011-02-21 19:19 UTC (permalink / raw)
To: netdev
In-Reply-To: <1298315809.2608.68.camel@bwh-desktop>
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
---
ethtool.8.in | 5 +++++
ethtool.c | 6 ++++++
2 files changed, 11 insertions(+), 0 deletions(-)
diff --git a/ethtool.8.in b/ethtool.8.in
index 133825b..8b04335 100644
--- a/ethtool.8.in
+++ b/ethtool.8.in
@@ -100,6 +100,8 @@ ethtool \- query or control network driver and hardware settings
.B ethtool \-h|\-\-help
+.B ethtool \-\-version
+
.B ethtool \-a|\-\-show\-pause
.I ethX
@@ -310,6 +312,9 @@ settings of the specified device.
.B \-h \-\-help
Shows a short help message.
.TP
+.B \-\-version
+Shows the ethtool version number.
+.TP
.B \-a \-\-show\-pause
Queries the specified Ethernet device for pause parameter information.
.TP
diff --git a/ethtool.c b/ethtool.c
index 32a97f6..e9cb2c9 100644
--- a/ethtool.c
+++ b/ethtool.c
@@ -115,6 +115,7 @@ static int do_permaddr(int fd, struct ifreq *ifr);
static int send_ioctl(int fd, struct ifreq *ifr);
static enum {
+ MODE_VERSION = -2,
MODE_HELP = -1,
MODE_GSET=0,
MODE_SSET,
@@ -264,6 +265,7 @@ static struct option {
{ "-P", "--show-permaddr", MODE_PERMADDR,
"Show permanent hardware address" },
{ "-h", "--help", MODE_HELP, "Show this help" },
+ { NULL, "--version", MODE_VERSION, "Show version number" },
{}
};
@@ -816,6 +818,10 @@ static void parse_cmdline(int argc, char **argp)
if (mode == MODE_HELP) {
show_usage();
exit(0);
+ } else if (mode == MODE_VERSION) {
+ fprintf(stdout,
+ PACKAGE " version " VERSION "\n");
+ exit(0);
} else if (!args[k].lng && argp[i][0] == '-') {
exit_bad_args();
} else {
--
1.7.3.4
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
^ permalink raw reply related
* [PATCH v2 4/4] m68k/atari: ARAnyM - Add support for network access
From: Geert Uytterhoeven @ 2011-02-21 19:30 UTC (permalink / raw)
To: linux-m68k
Cc: linux-kernel, aranym, Milan Jurik, Petr Stehlik, Michael Schmitz,
Geert Uytterhoeven, netdev
In-Reply-To: <1298316600-23094-1-git-send-email-geert@linux-m68k.org>
From: Milan Jurik <milan.jurik@xylab.cz>
[petr: Second author]
[michael, geert: Cleanups and updates]
Signed-off-by: Milan Jurik <milan.jurik@xylab.cz>
Signed-off-by: Petr Stehlik <pstehlik@sophics.cz>
Signed-off-by: Michael Schmitz <schmitz@debian.org>
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: netdev@vger.kernel.org
---
v2:
- Review comments from David Miller:
- Remove "dev->trans_start = jiffies;",
- Set pr_fmt(),
- Use netdev_*() for logging.
- Review comments from Petr Stehlik:
- Update ARAnyM URL.
v1:
- Convert to net_device_ops,
- nfeth doesn't need obsolete <net/ieee80211.h>,
- Convert print_mac to %pM,
- Break too long lines,
- Make needlessly global functions static,
- Make version[] const,
- Use pr_*(),
- Use net_device_stats from struct net_device instead of our own,
- Propagate error code from request_irq(),
- Remove unused variable "handled".
arch/m68k/Kconfig | 8 ++
arch/m68k/emu/Makefile | 1 +
arch/m68k/emu/nfeth.c | 270 ++++++++++++++++++++++++++++++++++++++++++++++++
3 files changed, 279 insertions(+), 0 deletions(-)
create mode 100644 arch/m68k/emu/nfeth.c
diff --git a/arch/m68k/Kconfig b/arch/m68k/Kconfig
index 6719c56..80df6ee 100644
--- a/arch/m68k/Kconfig
+++ b/arch/m68k/Kconfig
@@ -263,6 +263,14 @@ config NFCON
which allows the console output to be redirected to the stderr
output of ARAnyM.
+config NFETH
+ tristate "NatFeat Ethernet support"
+ depends on NET_ETHERNET && NATFEAT
+ help
+ Say Y to include support for the ARAnyM NatFeat network device
+ which will emulate a regular ethernet device while presenting an
+ ethertap device to the host system.
+
comment "Processor type"
config M68020
diff --git a/arch/m68k/emu/Makefile b/arch/m68k/emu/Makefile
index a83ef1e..7dc2010 100644
--- a/arch/m68k/emu/Makefile
+++ b/arch/m68k/emu/Makefile
@@ -6,3 +6,4 @@ obj-y += natfeat.o
obj-$(CONFIG_NFBLOCK) += nfblock.o
obj-$(CONFIG_NFCON) += nfcon.o
+obj-$(CONFIG_NFETH) += nfeth.o
diff --git a/arch/m68k/emu/nfeth.c b/arch/m68k/emu/nfeth.c
new file mode 100644
index 0000000..8b6e201
--- /dev/null
+++ b/arch/m68k/emu/nfeth.c
@@ -0,0 +1,270 @@
+/*
+ * atari_nfeth.c - ARAnyM ethernet card driver for GNU/Linux
+ *
+ * Copyright (c) 2005 Milan Jurik, Petr Stehlik of ARAnyM dev team
+ *
+ * Based on ARAnyM driver for FreeMiNT written by Standa Opichal
+ *
+ * This software may be used and distributed according to the terms of
+ * the GNU General Public License (GPL), incorporated herein by reference.
+ */
+
+#define DRV_VERSION "0.3"
+#define DRV_RELDATE "10/12/2005"
+
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
+
+#include <linux/netdevice.h>
+#include <linux/etherdevice.h>
+#include <linux/module.h>
+#include <asm/natfeat.h>
+#include <asm/virtconvert.h>
+
+enum {
+ GET_VERSION = 0,/* no parameters, return NFAPI_VERSION in d0 */
+ XIF_INTLEVEL, /* no parameters, return Interrupt Level in d0 */
+ XIF_IRQ, /* acknowledge interrupt from host */
+ XIF_START, /* (ethX), called on 'ifup', start receiver thread */
+ XIF_STOP, /* (ethX), called on 'ifdown', stop the thread */
+ XIF_READLENGTH, /* (ethX), return size of network data block to read */
+ XIF_READBLOCK, /* (ethX, buffer, size), read block of network data */
+ XIF_WRITEBLOCK, /* (ethX, buffer, size), write block of network data */
+ XIF_GET_MAC, /* (ethX, buffer, size), return MAC HW addr in buffer */
+ XIF_GET_IPHOST, /* (ethX, buffer, size), return IP address of host */
+ XIF_GET_IPATARI,/* (ethX, buffer, size), return IP address of atari */
+ XIF_GET_NETMASK /* (ethX, buffer, size), return IP netmask */
+};
+
+#define MAX_UNIT 8
+
+/* These identify the driver base version and may not be removed. */
+static const char version[] __devinitdata =
+ KERN_INFO KBUILD_MODNAME ".c:v" DRV_VERSION " " DRV_RELDATE
+ " S.Opichal, M.Jurik, P.Stehlik\n"
+ KERN_INFO " http://aranym.org/\n";
+
+MODULE_AUTHOR("Milan Jurik");
+MODULE_DESCRIPTION("Atari NFeth driver");
+MODULE_LICENSE("GPL");
+/*
+MODULE_PARM(nfeth_debug, "i");
+MODULE_PARM_DESC(nfeth_debug, "nfeth_debug level (1-2)");
+*/
+
+
+static long nfEtherID;
+static int nfEtherIRQ;
+
+struct nfeth_private {
+ int ethX;
+};
+
+static struct net_device *nfeth_dev[MAX_UNIT];
+
+static int nfeth_open(struct net_device *dev)
+{
+ struct nfeth_private *priv = netdev_priv(dev);
+ int res;
+
+ res = nf_call(nfEtherID + XIF_START, priv->ethX);
+ netdev_dbg(dev, "%s: %d\n", __func__, res);
+
+ /* Ready for data */
+ netif_start_queue(dev);
+
+ return 0;
+}
+
+static int nfeth_stop(struct net_device *dev)
+{
+ struct nfeth_private *priv = netdev_priv(dev);
+
+ /* No more data */
+ netif_stop_queue(dev);
+
+ nf_call(nfEtherID + XIF_STOP, priv->ethX);
+
+ return 0;
+}
+
+/*
+ * Read a packet out of the adapter and pass it to the upper layers
+ */
+static inline void recv_packet(struct net_device *dev)
+{
+ struct nfeth_private *priv = netdev_priv(dev);
+ unsigned short pktlen;
+ struct sk_buff *skb;
+
+ /* read packet length (excluding 32 bit crc) */
+ pktlen = nf_call(nfEtherID + XIF_READLENGTH, priv->ethX);
+
+ netdev_dbg(dev, "%s: %u\n", __func__, pktlen);
+
+ if (!pktlen) {
+ netdev_dbg(dev, "%s: pktlen == 0\n", __func__);
+ dev->stats.rx_errors++;
+ return;
+ }
+
+ skb = dev_alloc_skb(pktlen + 2);
+ if (!skb) {
+ netdev_dbg(dev, "%s: out of mem (buf_alloc failed)\n",
+ __func__);
+ dev->stats.rx_dropped++;
+ return;
+ }
+
+ skb->dev = dev;
+ skb_reserve(skb, 2); /* 16 Byte align */
+ skb_put(skb, pktlen); /* make room */
+ nf_call(nfEtherID + XIF_READBLOCK, priv->ethX, virt_to_phys(skb->data),
+ pktlen);
+
+ skb->protocol = eth_type_trans(skb, dev);
+ netif_rx(skb);
+ dev->last_rx = jiffies;
+ dev->stats.rx_packets++;
+ dev->stats.rx_bytes += pktlen;
+
+ /* and enqueue packet */
+ return;
+}
+
+static irqreturn_t nfeth_interrupt(int irq, void *dev_id)
+{
+ int i, m, mask;
+
+ mask = nf_call(nfEtherID + XIF_IRQ, 0);
+ for (i = 0, m = 1; i < MAX_UNIT; m <<= 1, i++) {
+ if (mask & m && nfeth_dev[i]) {
+ recv_packet(nfeth_dev[i]);
+ nf_call(nfEtherID + XIF_IRQ, m);
+ }
+ }
+ return IRQ_HANDLED;
+}
+
+static int nfeth_xmit(struct sk_buff *skb, struct net_device *dev)
+{
+ unsigned int len;
+ char *data, shortpkt[ETH_ZLEN];
+ struct nfeth_private *priv = netdev_priv(dev);
+
+ data = skb->data;
+ len = skb->len;
+ if (len < ETH_ZLEN) {
+ memset(shortpkt, 0, ETH_ZLEN);
+ memcpy(shortpkt, data, len);
+ data = shortpkt;
+ len = ETH_ZLEN;
+ }
+
+ netdev_dbg(dev, "%s: send %u bytes\n", __func__, len);
+ nf_call(nfEtherID + XIF_WRITEBLOCK, priv->ethX, virt_to_phys(data),
+ len);
+
+ dev->stats.tx_packets++;
+ dev->stats.tx_bytes += len;
+
+ dev_kfree_skb(skb);
+ return 0;
+}
+
+static void nfeth_tx_timeout(struct net_device *dev)
+{
+ dev->stats.tx_errors++;
+ netif_wake_queue(dev);
+}
+
+static const struct net_device_ops nfeth_netdev_ops = {
+ .ndo_open = nfeth_open,
+ .ndo_stop = nfeth_stop,
+ .ndo_start_xmit = nfeth_xmit,
+ .ndo_tx_timeout = nfeth_tx_timeout,
+ .ndo_validate_addr = eth_validate_addr,
+ .ndo_change_mtu = eth_change_mtu,
+ .ndo_set_mac_address = eth_mac_addr,
+};
+
+static struct net_device * __init nfeth_probe(int unit)
+{
+ struct net_device *dev;
+ struct nfeth_private *priv;
+ char mac[ETH_ALEN], host_ip[32], local_ip[32];
+ int err;
+
+ if (!nf_call(nfEtherID + XIF_GET_MAC, unit, mac, ETH_ALEN))
+ return NULL;
+
+ dev = alloc_etherdev(sizeof(struct nfeth_private));
+ if (!dev)
+ return NULL;
+
+ dev->irq = nfEtherIRQ;
+ dev->netdev_ops = &nfeth_netdev_ops;
+
+ dev->flags |= NETIF_F_NO_CSUM;
+ memcpy(dev->dev_addr, mac, ETH_ALEN);
+
+ priv = netdev_priv(dev);
+ priv->ethX = unit;
+
+ err = register_netdev(dev);
+ if (err) {
+ free_netdev(dev);
+ return NULL;
+ }
+
+ nf_call(nfEtherID + XIF_GET_IPHOST, unit,
+ host_ip, sizeof(host_ip));
+ nf_call(nfEtherID + XIF_GET_IPATARI, unit,
+ local_ip, sizeof(local_ip));
+
+ netdev_info(dev, KBUILD_MODNAME " addr:%s (%s) HWaddr:%pM\n", host_ip,
+ local_ip, mac);
+
+ return dev;
+}
+
+static int __init nfeth_init(void)
+{
+ long ver;
+ int error, i;
+
+ nfEtherID = nf_get_id("ETHERNET");
+ if (!nfEtherID)
+ return -ENODEV;
+
+ ver = nf_call(nfEtherID + GET_VERSION);
+ pr_info("API %lu\n", ver);
+
+ nfEtherIRQ = nf_call(nfEtherID + XIF_INTLEVEL);
+ error = request_irq(nfEtherIRQ, nfeth_interrupt, IRQF_SHARED,
+ "eth emu", nfeth_interrupt);
+ if (error) {
+ pr_err("request for irq %d failed %d", nfEtherIRQ, error);
+ return error;
+ }
+
+ for (i = 0; i < MAX_UNIT; i++)
+ nfeth_dev[i] = nfeth_probe(i);
+
+ return 0;
+}
+
+static void __exit nfeth_cleanup(void)
+{
+ int i;
+
+ for (i = 0; i < MAX_UNIT; i++) {
+ if (nfeth_dev[i]) {
+ unregister_netdev(nfeth_dev[0]);
+ free_netdev(nfeth_dev[0]);
+ }
+ }
+ free_irq(nfEtherIRQ, nfeth_interrupt);
+}
+
+module_init(nfeth_init);
+module_exit(nfeth_cleanup);
--
1.7.0.4
^ permalink raw reply related
* Re: [PATCH] tcp: undo_retrans counter fixes
From: David Miller @ 2011-02-21 19:31 UTC (permalink / raw)
To: ycheng; +Cc: netdev, ilpo.jarvinen
In-Reply-To: <1297119424-19956-1-git-send-email-ycheng@google.com>
From: Yuchung Cheng <ycheng@google.com>
Date: Mon, 7 Feb 2011 14:57:04 -0800
> Fix a bug that undo_retrans is incorrectly decremented when undo_marker is
> not set or undo_retrans is already 0. This happens when sender receives
> more DSACK ACKs than packets retransmitted during the current
> undo phase. This may also happen when sender receives DSACK after
> the undo operation is completed or cancelled.
>
> Fix another bug that undo_retrans is incorrectly incremented when
> sender retransmits an skb and tcp_skb_pcount(skb) > 1 (TSO). This case
> is rare but not impossible.
>
> Signed-off-by: Yuchung Cheng <ycheng@google.com>
Applied and queued up for -stable, thanks.
^ permalink raw reply
* Re: Off-by-one error in net/8021q/vlan.c
From: Brent Cook @ 2011-02-21 19:26 UTC (permalink / raw)
To: Michał Mirosław
Cc: Eric Dumazet, Phil Karn, richard -rw- weinberger, kaber, netdev
In-Reply-To: <AANLkTimrQy6gU8d86m2jM4arMS0rOvEQmn2m-KTE4sx9@mail.gmail.com>
On Wednesday 16 February 2011 12:41:34 Michał Mirosław wrote:
> 2011/2/16 Eric Dumazet <eric.dumazet@gmail.com>:
> > Le mercredi 16 février 2011 à 08:28 -0800, Phil Karn a écrit :
> >> On 2/16/11 8:10 AM, richard -rw- weinberger wrote:
> >> > On Wed, Feb 16, 2011 at 4:58 PM, Phil Karn <karn@ka9q.net> wrote:
> >> >> On 2/16/11 4:51 AM, richard -rw- weinberger wrote:
> >> >>> On Wed, Feb 16, 2011 at 11:58 AM, Phil Karn <karn@ka9q.net> wrote:
> >> >>>> The range check on vlan_id in register_vlan_device is off by one, and it
> >> >>>> prevents the creation of a vlan interface for vlan ID 4095. (OSX allows
> >> >>>> this, I checked.)
> >> >>>
> >> >>> Then OSX should fix their code. 4095 is reserved.
> >> >> If it's reserved, then it's up to the user to reserve it.
> >> > No.
> >> > See:
> >> > http://standards.ieee.org/getieee802/download/802.1Q-2005.pdf
> >> Well, then I guess we all know better than the user. That's the Windows
> >> Way...no, wait, I thought this is Linux.
> >>
> >> The fact is that I did encounter a misconfigured switch using vlan 4095,
> >> and because of this off-by-one error I was unable to talk to it and fix it.
> >>
> >> I was hoping I wouldn't have to patch every new kernel I install.
> > You can use an OSX gateway ;)
> >
> > If we allow ID 4095, then some users will complain we violate rules.
> >
> > Really you cannot push this patch in official kernel only to ease your
> > life ;)
>
> The idea is that you don't have to use ID 4095 and if you don't -
> nothing's broken by just allowing it. The same goes with ID 0 - it's
> defined to be 802.1p packet, but people do use it as normal VLAN
> (especially with hardware that can cope with only small number of
> VLANs at once).
>
> Allowing it but with a big fat warning in logs is even better: "You
> want your network broken? Sure, can do, but you have been warned."
>
On the other end of the spectrum, vconfig warns for vlan 1:
bcook@bcook-box:~$ sudo vconfig add eth0 1
Added VLAN with VID == 1 to IF -:eth0:-
WARNING: VLAN 1 does not work with many switches,
consider another number if you have problems.
bcook@bcook-box:~$ sudo vconfig add eth0 4095
ERROR: trying to add VLAN #4095 to IF -:eth0:- error: Numerical result out of range
^ permalink raw reply
* Re: [PATCH] xps-mq: Transmit Packet Steering for multiqueue
From: Jeremy Eder @ 2011-02-21 19:31 UTC (permalink / raw)
To: netdev
In-Reply-To: <1298312395.2608.65.camel@bwh-desktop>
[-- Attachment #1: Type: text/plain, Size: 1035 bytes --]
On Mon, 2011-02-21 at 18:19 +0000, Ben Hutchings wrote:
> On Wed, 2010-09-01 at 18:32 -0700, David Miller wrote:
> > From: Tom Herbert <therbert@google.com>
> > Date: Wed, 1 Sep 2010 09:24:18 -0700
> >
> > > On Wed, Sep 1, 2010 at 8:54 AM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
> > >> 3) Eventually have a user selectable selection (socket option, or system
> > >> wide, but one sysctl, not many bitmasks ;) ).
> > >>
> > > Right, but it would also be nice if a single sysctl could optimally
> > > set up multiqueue, RSS, RPS, and all my interrupt affinities for me
> > > ;-)
Are cgroups the right place to have the network stack pull "guidance"
from ?
If an app is bound to a socket/core/NUMA node; then the network stack
could inherit the cgroup's tuning and adjust kernel knobs accordingly.
This would not replace procfs tuning, but it seems like a natural
extension of how cgroups and RPS/RFS/XPS could be integrated to ease the
management burden that these new technologies might impose.
--jer
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply
* Re: linux-next: build warning after merge of the driver-core tree
From: Ilya Yanok @ 2011-02-21 20:18 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Greg KH, linux-next, linux-kernel, Marc Kleine-Budde,
David Miller, netdev
In-Reply-To: <20110221170226.c43175f7.sfr@canb.auug.org.au>
Hi Stephen, Greg,
On 21.02.2011 09:02, Stephen Rothwell wrote:
> After merging the driver-core tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> drivers/net/dnet.c: In function 'dnet_mii_init':
> drivers/net/dnet.c:340: warning: passing argument 1 of 'platform_set_drvdata' from incompatible pointer type
> include/linux/platform_device.h:138: note: expected 'struct platform_device *' but argument is of type 'struct net_device *'
It's actually a bug in the driver. Thanks for reporting. I'll send the
patch as a follow up.
Regards, Ilya.
^ permalink raw reply
* [PATCH] dnet: fix wrong use of platform_set_drvdata()
From: Ilya Yanok @ 2011-02-21 20:20 UTC (permalink / raw)
To: sfr, greg, linux-next, linux-kernel, mkl, davem, netdev; +Cc: Ilya Yanok
In-Reply-To: <4D62C897.5020707@emcraft.com>
platform_set_drvdata() was used with argument of incorrect type and
could cause memory corruption. Moreover, because of not setting drvdata
in the correct place not all resources were freed upon module unload.
Signed-off-by: Ilya Yanok <yanok@emcraft.com>
---
drivers/net/dnet.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/net/dnet.c b/drivers/net/dnet.c
index 9d8a20b..8318ea0 100644
--- a/drivers/net/dnet.c
+++ b/drivers/net/dnet.c
@@ -337,8 +337,6 @@ static int dnet_mii_init(struct dnet *bp)
for (i = 0; i < PHY_MAX_ADDR; i++)
bp->mii_bus->irq[i] = PHY_POLL;
- platform_set_drvdata(bp->dev, bp->mii_bus);
-
if (mdiobus_register(bp->mii_bus)) {
err = -ENXIO;
goto err_out_free_mdio_irq;
@@ -863,6 +861,7 @@ static int __devinit dnet_probe(struct platform_device *pdev)
bp = netdev_priv(dev);
bp->dev = dev;
+ platform_set_drvdata(pdev, dev);
SET_NETDEV_DEV(dev, &pdev->dev);
spin_lock_init(&bp->lock);
--
1.7.4
^ permalink raw reply related
* 2.6.38-rc5: nfsd: page allocation failure. spinlock trylock failure on UP
From: Alexander Beregalov @ 2011-02-21 20:33 UTC (permalink / raw)
To: netdev, Linux Kernel Mailing List
Hi
Let me know if I can provide more info
nfsd: page allocation failure. order:5, mode:0x4020
BUG: spinlock trylock failure on UP on CPU#0, nfsd/1574
lock: f6771be0, .magic: dead4ead, .owner: nfsd/1574, .owner_cpu: 0
Pid: 1574, comm: nfsd Not tainted 2.6.38-rc5-00100-g0cc9d52 #1
Call Trace:
[<c11ec94d>] ? spin_bug+0x9d/0xe0
[<c11ecb9a>] ? do_raw_spin_trylock+0x3a/0x40
[<c1365dae>] ? _raw_spin_trylock+0xe/0x50
[<c109b08a>] ? __kmalloc_track_caller+0x9a/0x170
[<c12fc1e9>] ? netpoll_send_skb_on_dev+0x109/0x220
[<c12e2e74>] ? __alloc_skb+0x54/0x100
[<c12fc4ee>] ? netpoll_send_udp+0x1ee/0x220
[<c129ba8c>] ? write_msg+0x9c/0xd0
[<c129b9f0>] ? write_msg+0x0/0xd0
[<c102b2c3>] ? __call_console_drivers+0x43/0x60
[<c102b32f>] ? _call_console_drivers+0x4f/0x80
[<c102b651>] ? console_unlock+0xf1/0x200
[<c102ba79>] ? vprintk+0x209/0x3b0
[<c100205d>] ? do_signal+0x3bd/0x870
[<c11d93c5>] ? ___ratelimit+0x85/0x100
[<c136365e>] ? printk+0x18/0x1a
[<c1078055>] ? __alloc_pages_nodemask+0x405/0x620
[<c107828b>] ? __get_free_pages+0x1b/0x30
[<c109a3e2>] ? __kmalloc+0x152/0x170
[<c12e2507>] ? pskb_expand_head+0x147/0x2e0
[<c12e29ff>] ? __pskb_pull_tail+0x23f/0x340
[<c1050f8b>] ? trace_hardirqs_off+0xb/0x10
[<c12ec592>] ? dev_hard_start_xmit+0x2a2/0x570
[<c1365f1c>] ? _raw_spin_lock+0x5c/0x70
[<c12fd590>] ? sch_direct_xmit+0x90/0x200
[<c1365f1c>] ? _raw_spin_lock+0x5c/0x70
[<c12ec9e8>] ? dev_queue_xmit+0x188/0x600
[<c12ec860>] ? dev_queue_xmit+0x0/0x600
[<c130b173>] ? ip_finish_output+0x133/0x400
[<c130bdf7>] ? ip_output+0x67/0xc0
[<c130b5d0>] ? ip_local_out+0x20/0x70
[<c130b789>] ? ip_queue_xmit+0x169/0x420
[<c130b620>] ? ip_queue_xmit+0x0/0x420
[<c1047a42>] ? sched_clock_local.clone.1+0x42/0x1a0
[<c131f6ec>] ? tcp_transmit_skb+0x35c/0x810
[<c1320218>] ? tcp_write_xmit+0xf8/0x950
[<c12e2188>] ? __kfree_skb+0x38/0x90
[<c1320ad7>] ? __tcp_push_pending_frames+0x27/0xb0
[<c131efe6>] ? tcp_current_mss+0x76/0xa0
[<c131da56>] ? tcp_rcv_established+0x416/0x610
[<c1324020>] ? tcp_v4_do_rcv+0x90/0x1e0
[<c12dd4fc>] ? release_sock+0x5c/0x170
[<c12dd53d>] ? release_sock+0x9d/0x170
[<c131419c>] ? tcp_sendpage+0x9c/0x5c0
[<c1314100>] ? tcp_sendpage+0x0/0x5c0
[<c13327af>] ? inet_sendpage+0x3f/0xa0
[<c1332770>] ? inet_sendpage+0x0/0xa0
[<c12da158>] ? kernel_sendpage+0x28/0x50
[<c134ff42>] ? svc_send_common+0xd2/0x120
[<c134fff9>] ? svc_sendto+0x69/0x1a0
[<c1047c5d>] ? sched_clock_cpu+0x7d/0xf0
[<c1050f8b>] ? trace_hardirqs_off+0xb/0x10
[<c1047d16>] ? local_clock+0x46/0x60
[<c10537d6>] ? mark_held_locks+0x56/0x80
[<c1364cc9>] ? mutex_lock_nested+0x1d9/0x2a0
[<c1364cd3>] ? mutex_lock_nested+0x1e3/0x2a0
[<c13501b3>] ? svc_tcp_sendto+0x33/0xa0
[<c1359d7b>] ? svc_send+0x8b/0xe0
[<c113f870>] ? nfs3svc_release_fhandle+0x0/0x20
[<c134cbda>] ? svc_process+0x22a/0x750
[<c11313e0>] ? nfsd+0xa0/0x130
[<c1020cc8>] ? complete+0x48/0x60
[<c1131340>] ? nfsd+0x0/0x130
[<c1041fb4>] ? kthread+0x74/0x80
[<c1041f40>] ? kthread+0x0/0x80
[<c100307a>] ? kernel_thread_helper+0x6/0x1c
Pid: 1574, comm: nfsd Not tainted 2.6.38-rc5-00100-g0cc9d52 #1
Call Trace:
[<c107805a>] ? __alloc_pages_nodemask+0x40a/0x620
[<c107828b>] ? __get_free_pages+0x1b/0x30
[<c109a3e2>] ? __kmalloc+0x152/0x170
[<c12e2507>] ? pskb_expand_head+0x147/0x2e0
[<c12e29ff>] ? __pskb_pull_tail+0x23f/0x340
[<c1050f8b>] ? trace_hardirqs_off+0xb/0x10
[<c12ec592>] ? dev_hard_start_xmit+0x2a2/0x570
[<c1365f1c>] ? _raw_spin_lock+0x5c/0x70
[<c12fd590>] ? sch_direct_xmit+0x90/0x200
[<c1365f1c>] ? _raw_spin_lock+0x5c/0x70
[<c12ec9e8>] ? dev_queue_xmit+0x188/0x600
[<c12ec860>] ? dev_queue_xmit+0x0/0x600
[<c130b173>] ? ip_finish_output+0x133/0x400
[<c130bdf7>] ? ip_output+0x67/0xc0
[<c130b5d0>] ? ip_local_out+0x20/0x70
[<c130b789>] ? ip_queue_xmit+0x169/0x420
[<c130b620>] ? ip_queue_xmit+0x0/0x420
[<c1047a42>] ? sched_clock_local.clone.1+0x42/0x1a0
[<c131f6ec>] ? tcp_transmit_skb+0x35c/0x810
[<c1320218>] ? tcp_write_xmit+0xf8/0x950
[<c12e2188>] ? __kfree_skb+0x38/0x90
[<c1320ad7>] ? __tcp_push_pending_frames+0x27/0xb0
[<c131efe6>] ? tcp_current_mss+0x76/0xa0
[<c131da56>] ? tcp_rcv_established+0x416/0x610
[<c1324020>] ? tcp_v4_do_rcv+0x90/0x1e0
[<c12dd4fc>] ? release_sock+0x5c/0x170
[<c12dd53d>] ? release_sock+0x9d/0x170
[<c131419c>] ? tcp_sendpage+0x9c/0x5c0
[<c1314100>] ? tcp_sendpage+0x0/0x5c0
[<c13327af>] ? inet_sendpage+0x3f/0xa0
[<c1332770>] ? inet_sendpage+0x0/0xa0
[<c12da158>] ? kernel_sendpage+0x28/0x50
[<c134ff42>] ? svc_send_common+0xd2/0x120
[<c134fff9>] ? svc_sendto+0x69/0x1a0
[<c1047c5d>] ? sched_clock_cpu+0x7d/0xf0
[<c1050f8b>] ? trace_hardirqs_off+0xb/0x10
[<c1047d16>] ? local_clock+0x46/0x60
[<c10537d6>] ? mark_held_locks+0x56/0x80
[<c1364cc9>] ? mutex_lock_nested+0x1d9/0x2a0
[<c1364cd3>] ? mutex_lock_nested+0x1e3/0x2a0
[<c13501b3>] ? svc_tcp_sendto+0x33/0xa0
[<c1359d7b>] ? svc_send+0x8b/0xe0
[<c113f870>] ? nfs3svc_release_fhandle+0x0/0x20
[<c134cbda>] ? svc_process+0x22a/0x750
[<c11313e0>] ? nfsd+0xa0/0x130
[<c1020cc8>] ? complete+0x48/0x60
[<c1131340>] ? nfsd+0x0/0x130
[<c1041fb4>] ? kthread+0x74/0x80
[<c1041f40>] ? kthread+0x0/0x80
[<c100307a>] ? kernel_thread_helper+0x6/0x1c
^ permalink raw reply
* Re: [PATCH 2/2] DM9000B: Fix PHY power for network down/up
From: Henry Nestler @ 2011-02-21 21:03 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: netdev, tori, akpm, linux-arm-kernel
In-Reply-To: <4D62491F.4050602@ru.mvista.com>
On 21.02.2011 12:14, Sergei Shtylyov wrote:
> On 21-02-2011 0:45, Henry Nestler wrote:
>
>> DM9000 revision B needs 1 ms delay after PHY power on (see spec), and PHY
>> power must on in register
>
> Couldn't parse that.
This can read in manual DM900B-12-DS-F02 from September 2 2010, Page 14:
"If this Register 1FH bit 0 is updated from '1' to '0', the all
Registers can not be accessed within 1ms."
The example driver code waits 2 ms.
>> diff --git a/drivers/net/dm9000.c b/drivers/net/dm9000.c
>> index 2d4c4fc..5925569 100644
>> --- a/drivers/net/dm9000.c
>> +++ b/drivers/net/dm9000.c
> [...]
>> @@ -1194,6 +1191,10 @@ dm9000_open(struct net_device *dev)
>> if (request_irq(dev->irq, dm9000_interrupt, irqflags, dev->name, dev))
>> return -EAGAIN;
>>
>> + /* GPIO0 on pre-activate PHY, Reg 1F is not set by reset */
>> + iow(db, DM9000_GPR, 0); /* REG_1F bit0 activate phyxcer */
>> + udelay(1000); /* delay needs by DM9000B */
>
> Why not mdelay(1)?
Because udelay is the base of mdelay.
See include/linux/delay.h:31
#define mdelay(n) ... udelay((n)*1000)
--
Henry N.
^ permalink raw reply
* Re: Off-by-one error in net/8021q/vlan.c
From: Phil Karn @ 2011-02-21 21:47 UTC (permalink / raw)
To: Brent Cook
Cc: Michał Mirosław, Eric Dumazet, richard -rw- weinberger,
kaber, netdev
In-Reply-To: <201102211326.00255.bcook@breakingpoint.com>
On 2/21/11 11:26 AM, Brent Cook wrote:
>> Allowing it but with a big fat warning in logs is even better: "You
>> want your network broken? Sure, can do, but you have been warned."
*By all means* have vconfig issue a warning for 4095 just as it already
does for vlan 1.
As I explained the only reason I wanted to do this was to talk to a
piece of equipment that had been misconfigured to use vlan 4095 so I
could fix it. At the time I was using a newly built Linux system running
off a live CD, and only it had a physical network connection to the
device I was trying to fix.
I'm reminded of the classic example of an airliner that is so "smart"
and "idiot proof" that it always disallows a throttle setting that might
shorten the life of the engines.
The designers hadn't considered the possibility that such a setting
might be necessary to avoid a crash that, too, shortens engine life.
The obvious answer is to allow it but make sure he knows what he's
doing. So it takes noticeably more force to push the handles past the
safe limits, but it can be done if you really want to.
So if an airliner allows a command that might cause costly engine
damage, I think Linux can allow a command that violates a usage
convention written in a spec. With a warning, of course.
^ permalink raw reply
* 2.6.38-rc5-git6: Reported regressions from 2.6.37
From: Rafael J. Wysocki @ 2011-02-21 21:52 UTC (permalink / raw)
To: Linux Kernel Mailing List
Cc: Maciej Rutecki, Florian Mickler, Andrew Morton, Linus Torvalds,
Kernel Testers List, Network Development, Linux ACPI,
Linux PM List, Linux SCSI List, Linux Wireless List, DRI
This message contains a list of some regressions from 2.6.37,
for which there are no fixes in the mainline known to the tracking team.
If any of them have been fixed already, please let us know.
If you know of any other unresolved regressions from 2.6.37, please let us
know either and we'll add them to the list. Also, please let us know
if any of the entries below are invalid.
Each entry from the list will be sent additionally in an automatic reply
to this message with CCs to the people involved in reporting and handling
the issue.
Listed regressions statistics:
Date Total Pending Unresolved
----------------------------------------
2011-02-21 51 18 17
2011-02-12 39 20 18
2011-02-03 19 11 7
Unresolved regressions
----------------------
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=29402
Subject : kernel panics while running ffsb scalability workloads on 2.6.38-rc1 through -rc5
Submitter : Eric Whitney <eric.whitney@hp.com>
Date : 2011-02-18 21:47 (4 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=29322
Subject : System lockup with 2.6.38-rc4+
Submitter : Chris Clayton <chris2553@googlemail.com>
Date : 2011-02-14 17:31 (8 days old)
Message-ID : <201102141731.29331.chris2553@googlemail.com>
References : http://marc.info/?l=linux-kernel&m=129770471724602&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=29252
Subject : IPv6 doesn't work in a kvm guest.
Submitter : Kusanagi Kouichi <slash@ac.auone-net.jp>
Date : 2011-02-16 13:03 (6 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=29232
Subject : [VT-d] VT-d device passthrough fail to guest
Submitter : xudong <xudong.hao@intel.com>
Date : 2011-02-16 08:56 (6 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=29202
Subject : 2.6.38-rc: fuse BUG, maybe related to detaching external usb drive without umounting
Submitter : Florian Mickler <florian@mickler.org>
Date : 2011-02-15 22:05 (7 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=29022
Subject : [REGRESSION? 2.6.38-rc4] nouveau NV50 screen freeze
Submitter : Marc <marc@osknowledge.org>
Date : 2011-02-13 12:29 (9 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=28882
Subject : Screen corruption and GPU hangs
Submitter : Ko Mi <chaostya.test@hotmail.com>
Date : 2011-02-11 18:17 (11 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=28842
Subject : 2.6.38-rc3 regression ipv6 TFTP download with curl failing in getpeername?
Submitter : Eric W. Biederman <ebiederm@xmission.com>
Date : 2011-02-08 9:41 (14 days old)
Message-ID : <m1ei7iamnn.fsf@fess.ebiederm.org>
References : http://marc.info/?l=linux-kernel&m=129715811421534&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=28642
Subject : ACPI broken on DELL Latitude E6410 in 2.6.38-rc3
Submitter : Adam Kovari <kovariadam@gmail.com>
Date : 2011-02-08 22:22 (14 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=28562
Subject : [BUG] usb problems in .38-rc3+
Submitter : Ed Tomlinson <edt@aei.ca>
Date : 2011-02-05 19:17 (17 days old)
Message-ID : <201102051417.58953.edt@aei.ca>
References : http://marc.info/?l=linux-kernel&m=129693391417607&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=28522
Subject : Unable to mount FAT-formatted floppy on /dev/fd0, plus WARN_ON when using /dev/fd0u1440
Submitter : Alex Villacis Lasso <avillaci@ceibo.fiec.espol.edu.ec>
Date : 2011-02-07 17:21 (15 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=28452
Subject : 2.6.38-rc3 regression on parisc: segfaults
Submitter : Meelis Roos <mroos@linux.ee>
Date : 2011-02-01 22:00 (21 days old)
Message-ID : <alpine.SOC.1.00.1102012342200.25944@math.ut.ee>
References : http://marc.info/?l=linux-kernel&m=129659763426600&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=28432
Subject : khugepaged: gets stuck when writing to USB flash, 2.6.38-rc2
Submitter : Jindřich Makovička <makovick@gmail.com>
Date : 2011-01-31 19:28 (22 days old)
Message-ID : <AANLkTi=uOpN0PwWdGh6iri-vJwuMS+WMPxmaZjv0-TrV@mail.gmail.com>
References : http://marc.info/?l=linux-kernel&m=129650210516627&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=28422
Subject : kref and apparmor panic in 2.6.38-rc2.
Submitter : Tao Ma <tm@tao.ma>
Date : 2011-01-31 10:06 (22 days old)
Message-ID : <4D46899B.80302@tao.ma>
References : http://marc.info/?l=linux-kernel&m=129646840303149&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=28262
Subject : Slow resume from suspend/hibernate on Dell Inspiron M301Z
Submitter : Luca Ferretti <lferrett@gnome.org>
Date : 2011-02-05 12:37 (17 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=28102
Subject : New display errors in 2.6.38-rc2-00175-g6fb1b30
Submitter : Nico Schottelius <nico-kernel-20110117@schottelius.org>
Date : 2011-01-28 20:29 (25 days old)
Message-ID : <20110128202905.GB3395@schottelius.org>
References : http://marc.info/?l=linux-kernel&m=129624657425949&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=27022
Subject : [REPORT] BUG: spinlock recursion on CPU#0, init/1
Submitter : Santosh Shilimkar <santosh.shilimkar@ti.com>
Date : 2011-01-10 15:33 (43 days old)
Message-ID : <a7a9bdaa5936630925fb7ffd1a1795b1@mail.gmail.com>
References : http://marc.info/?l=linux-kernel&m=129467294808655&w=2
Regressions with patches
------------------------
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=27382
Subject : ath5k phy0: gain calibration timeout
Submitter : Nicolas Stransky <Nico@stransky.cx>
Date : 2011-01-23 00:18 (30 days old)
Handled-By : Nick Kossifidis <mickflemm@gmail.com>
Patch : https://patchwork.kernel.org/patch/530811/
For details, please visit the bug entries and follow the links given in
references.
As you can see, there is a Bugzilla entry for each of the listed regressions.
There also is a Bugzilla entry used for tracking the regressions from 2.6.37,
unresolved as well as resolved, at:
http://bugzilla.kernel.org/show_bug.cgi?id=27352
Please let the tracking team know if there are any Bugzilla entries that
should be added to the list in there.
Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* 2.6.38-rc5-git6: Reported regressions 2.6.36 -> 2.6.37
From: Rafael J. Wysocki @ 2011-02-21 22:29 UTC (permalink / raw)
To: Linux Kernel Mailing List
Cc: Maciej Rutecki, Florian Mickler, Andrew Morton, Linus Torvalds,
Kernel Testers List, Network Development, Linux ACPI,
Linux PM List, Linux SCSI List, Linux Wireless List, DRI
[NOTE: Can maintainers _please_ merge patches listed below, especially those that
have been known for weeks?]
This message contains a list of some post-2.6.36 regressions introduced before
2.6.37, for which there are no fixes in the mainline known to the tracking team.
If any of them have been fixed already, please let us know.
If you know of any other unresolved post-2.6.36 regressions, please let us know
either and we'll add them to the list. Also, please let us know if any
of the entries below are invalid.
Each entry from the list will be sent additionally in an automatic reply to
this message with CCs to the people involved in reporting and handling the
issue.
Listed regressions statistics:
Date Total Pending Unresolved
----------------------------------------
2011-02-21 128 35 26
2011-02-13 126 36 30
2011-02-03 118 36 31
2010-12-30 85 32 26
2010-12-19 73 28 24
2010-12-03 55 25 19
2010-11-19 39 29 25
Unresolved regressions
----------------------
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=29172
Subject : releasing loop on top of other loop leads to deadlock
Submitter : Petr Uzel <petr.uzel@centrum.cz>
Date : 2011-02-15 10:00 (7 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=28812
Subject : DVI attached monitor is turned off while booting linux 2.6.37 and higher
Submitter : Markus Heinz <markus.heinz@uni-dortmund.de>
Date : 2011-02-10 19:33 (12 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=28772
Subject : oops in nfs_revalidate_mapping
Submitter : Daniel Poelzleithner <bugzilla.kernel.org@poelzi.org>
Date : 2011-02-10 13:59 (12 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=28662
Subject : i915 in kernel 2.6.38-rc4, high number of wakeups
Submitter : Kan-Ru Chen <kanru@kanru.info>
Date : 2011-02-09 07:06 (13 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=28622
Subject : radeon video lockup
Submitter : Daniel Poelzleithner <bugzilla.kernel.org@poelzi.org>
Date : 2011-02-08 17:48 (14 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=28612
Subject : regular soft lockup
Submitter : Alexandre Demers <alexandre.f.demers@gmail.com>
Date : 2011-02-08 16:39 (14 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=28582
Subject : whole system hang when start X
Submitter : Gu Rui <chaos.proton@gmail.com>
Date : 2011-02-08 08:33 (14 days old)
First-Bad-Commit: http://git.kernel.org/linus/d5bb081b027b520f9e59b4fb8faea83a136ec15e
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=28332
Subject : [RV620] Can not re-enable LVDS after using HDMI only
Submitter : Rafał Miłecki <zajec5@gmail.com>
Date : 2011-02-05 22:42 (17 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=27892
Subject : SNB: GPU hang with Slip xscreensaver
Submitter : Takashi Iwai <tiwai@suse.de>
Date : 2011-01-31 12:06 (22 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=27842
Subject : [regression?] hang with 2.6.37 on a BTRFS test machine
Submitter : Martin Steigerwald <Martin@lichtvoll.de>
Date : 2011-01-23 12:06 (30 days old)
Message-ID : <<201101231306.23069.Martin@lichtvoll.de>>
References : http://marc.info/?l=linux-kernel&m=129578445613283&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=27642
Subject : 2.6.37 says WARNING: at arch/x86/kernel/apic/apic.c:1287 setup_local_APIC+0x18f/0x263()
Submitter : Rob Landley <rlandley@parallels.com>
Date : 2011-01-18 13:11 (35 days old)
Message-ID : <4D359188.3040408@parallels.com>
References : http://marc.info/?l=linux-kernel&m=129535632319892&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=27402
Subject : Atheros adapter no longer loads firmware
Submitter : Michal Vaner <vorner@ucw.cz>
Date : 2011-01-23 15:29 (30 days old)
First-Bad-Commit: http://git.kernel.org/linus/be93112accb42c5586a459683d71975cc70673ca
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=27152
Subject : VGA output broken at cold boot
Submitter : Takashi Iwai <tiwai@suse.de>
Date : 2011-01-20 13:26 (33 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=27132
Subject : flush-btrfs gets into an infinite loop
Submitter : Artem Anisimov <aanisimov@inbox.ru>
Date : 2011-01-20 11:51 (33 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=26802
Subject : b43: Suspend failed
Submitter : Patrick Matthäi <patrick@linux-dev.org>
Date : 2011-01-15 18:56 (38 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=26612
Subject : BUG in fs/inode.c:429
Submitter : Florian Kriener <florian@kriener.org>
Date : 2011-01-06 16:35 (47 days old)
Message-ID : <201101061735.40060.florian@kriener.org>
References : http://marc.info/?l=linux-kernel&m=129433235223735&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=26582
Subject : NULL pointer dereference on pipe creation
Submitter : Ferenc Wágner <wferi@niif.hu>
Date : 2011-01-12 13:30 (41 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=26112
Subject : [LogFS] [2.6.37-rc8+] Kernel BUG at logfs/readwrite.c:297!
Submitter : Prasad Joshi <prasadjoshi124@gmail.com>
Date : 2011-01-02 21:22 (51 days old)
Message-ID : <AANLkTinpoM8FuG8UkF88xs_V37dz_wgE8t-s0JPzaS-w@mail.gmail.com>
References : http://marc.info/?l=linux-kernel&m=129400335910652&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=26102
Subject : [2.6.37-rc8] BUG kmalloc-256: Poison overwritten.
Submitter : Pawel Sikora <pluto@agmk.net>
Date : 2010-12-30 15:08 (54 days old)
Message-ID : <201012301608.40859.pluto@agmk.net>
References : http://marc.info/?l=linux-kernel&m=129372388925679&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=25832
Subject : kernel crashes upon resume if usb devices are removed when suspended
Submitter : rocko <rockorequin@hotmail.com>
Date : 2010-12-29 11:47 (55 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=25732
Subject : i915 turns picture green when display switched off-on
Submitter : Tõnu Raitviir <jussuf@linux.ee>
Date : 2010-12-27 22:14 (57 days old)
First-Bad-Commit: http://git.kernel.org/linus/3c17fe4b8f40a112a85758a9ab2aebf772bdd647
Handled-By : Chris Wilson <chris@chris-wilson.co.uk>
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=24882
Subject : PM/Hibernate: Memory corruption patch introduces regression (2.6.36.2)
Submitter : <akwatts@ymail.com>
Date : 2010-12-14 04:00 (70 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=24822
Subject : Embedded DisplayPort is detected wrongly on HP ProBook 5320m
Submitter : Takashi Iwai <tiwai@suse.de>
Date : 2010-12-13 11:09 (71 days old)
Handled-By : Chris Wilson <chris@chris-wilson.co.uk>
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=22942
Subject : [2.6.37-rc1, OOM] virtblk: OOM in do_virtblk_request()
Submitter : Dave Chinner <david@fromorbit.com>
Date : 2010-11-05 1:30 (109 days old)
Message-ID : <20101105013003.GE13830@dastard>
References : http://marc.info/?l=linux-kernel&m=128892062917641&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=22642
Subject : 2.6.37-rc1: Disk takes 10 seconds to resume - MacBook2,1
Submitter : Tobias <devnull@plzk.org>
Date : 2010-11-10 19:33 (104 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=22542
Subject : [2.6.37-rc1] drm:i195 errors
Submitter : Paul Rolland <rol@witbe.net>
Date : 2010-11-02 14:58 (112 days old)
Message-ID : <20101102155813.09cb2c6e@tux.DEF.witbe.net>
References : http://marc.info/?l=linux-kernel&m=128870991628970&w=2
Regressions with patches
------------------------
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=27532
Subject : ath9k prevents CPU from entering lower C-states
Submitter : Thomas Bächler <thomas@archlinux.org>
Date : 2011-01-24 22:43 (29 days old)
Handled-By : Mohammed Shafi Shajakhan <mshajakhan@atheros.com>
Patch : https://bugzilla.kernel.org/attachment.cgi?id=47952
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=27202
Subject : Remote control of saa7134-based tv card "ASUSTeK P7131 Hybrid" stopped working in 2.6.37
Submitter : <acaizzo@gmail.com>
Date : 2011-01-20 17:23 (33 days old)
First-Bad-Commit: http://git.kernel.org/linus/4651918a4afdd49bdea21d2f919b189ef17a6399
Handled-By : Mauro Carvalho Chehab <mchehab@redhat.com>
Patch : https://bugzilla.kernel.org/attachment.cgi?id=44532
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=25922
Subject : IdeaPad Y530 brightness keys not functioning
Submitter : Tomasz <tm.temp@gmx.com>
Date : 2010-12-30 12:48 (54 days old)
Patch : https://bugzilla.kernel.org/attachment.cgi?id=48542
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=25822
Subject : [BUG] kernel BUG at mm/truncate.c:479! on 2.6.37-rc8
Submitter : Gurudas Pai <gurudas.pai@oracle.com>
Date : 2010-12-29 6:58 (55 days old)
Message-ID : <4D1AD935.1020504@oracle.com>
References : http://marc.info/?l=linux-kernel&m=129360511222037&w=2
Handled-By : Miklos Szeredi <mszeredi@suse.cz>
Patch : https://lkml.org/lkml/2010/12/29/131
https://lkml.org/lkml/2011/1/20/163
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=25402
Subject : kernel (2.6.37-8-generic_amd64) panic on boot (with message "map_single: bounce buffer is not DMA'ble) - possible regression !!!
Submitter : carlos <carlos.palma@ono.com>
Date : 2010-12-21 19:58 (63 days old)
Handled-By : FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Patch : https://patchwork.kernel.org/patch/522971/
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=24982
Subject : Inconsistent DPMS handling with 2.6.37 DRM
Submitter : Takashi Iwai <tiwai@suse.de>
Date : 2010-12-16 16:32 (68 days old)
Handled-By : Takashi Iwai <tiwai@suse.de>
Keith Packard <keithp@keithp.com>
Patch : https://bugzilla.kernel.org/attachment.cgi?id=40392
https://patchwork.kernel.org/patch/530921/
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=24582
Subject : Kernel Oops at tty_buffer_request_room when using pppd program (2.6.37-rc4)
Submitter : baoyb <baoyb@avit.org.cn>
Date : 2010-12-08 13:55 (76 days old)
Message-ID : <EF6DDE218DB34702B1FA84D6CD7EA771@baoyb>
References : http://marc.info/?l=linux-kernel&m=129181763525738&w=2
Handled-By : Jiri Slaby <jslaby@suse.cz>
Patch : https://bugzilla.kernel.org/attachment.cgi?id=47872
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=23472
Subject : 2.6.37-rc2 vs. 2.6.36 laptop backlight changes?
Submitter : Patrick Schaaf <netdev@bof.de>
Date : 2010-11-17 13:41 (97 days old)
Message-ID : <1290001262.5727.2.camel@lat1>
References : http://marc.info/?l=linux-kernel&m=129000127920912&w=2
Handled-By : Indan Zupancic <indan@nul.nu>
Patch : https://bugzilla.kernel.org/attachment.cgi?id=47302
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=22882
Subject : (2.6.37-rc1) amd64-agp module crashed on second load
Submitter : Randy Dunlap <randy.dunlap@oracle.com>
Date : 2010-11-05 0:13 (109 days old)
Message-ID : <20101104171333.fea1f498.randy.dunlap@oracle.com>
References : http://marc.info/?l=linux-kernel&m=128891605213447&w=2
Handled-By : Florian Mickler <florian@mickler.org>
Patch : https://bugzilla.kernel.org/attachment.cgi?id=46682
For details, please visit the bug entries and follow the links given in
references.
As you can see, there is a Bugzilla entry for each of the listed regressions.
There also is a Bugzilla entry used for tracking the regressions introduced
between 2.6.36 and 2.6.37, unresolved as well as resolved, at:
http://bugzilla.kernel.org/show_bug.cgi?id=21782
Please let the tracking team know if there are any Bugzilla entries that
should be added to the list in there.
Thanks!
^ permalink raw reply
* [PATCH net-next-2.6] bonding: fix user-controlled queuing issues
From: Andy Gospodarek @ 2011-02-21 22:53 UTC (permalink / raw)
To: netdev, Ben Hutchings, Jay Vosburgh, Phil Oester
Users noticed the following messages were filling their logs when using
queue 16 for user-mode bonding:
kernel: bond0 selects TX queue 16, but real number of TX queues is 16
These messages were showing up since the code for setting queues
presumed that queues 1-16 were usable and queue 0 was reserved, but
parts of the code didn't account for this correctly. This update now
allows 16 queues (numbered 0-15) to be used (in the nominal case) and
queue awareness can be completely and clearly disabled rather than by
simply setting the queue for a device to 0.
Configuration syntax has changed a little, but is similar to the
existing method. To associate a queue with an output device, you can do
this:
# echo "+eth1:2" > /sys/class/net/bond0/bonding/queue_id
and to clear it this:
# echo "-eth1:2" > /sys/class/net/bond0/bonding/queue_id
The orginal report that prompted this patch changed bond_select_queue to
return a value different than sinply skb->queue_mapping. This should
now be a proper return value since the interal queues were remapped
internally and queues 0-15 are the usable queues.
Signed-off-by: Andy Gospodarek <andy@greyhouse.net>
Reported-by: Phil Oester <kernel@linuxace.com>
---
My tests all seem to work well, but more testing/feedback is obviously
appreciated.
---
Documentation/networking/bonding.txt | 20 ++++++----
drivers/net/bonding/bond_main.c | 16 ++++---
drivers/net/bonding/bond_sysfs.c | 71 +++++++++++++++++++++------------
drivers/net/bonding/bonding.h | 20 +++++++++
4 files changed, 86 insertions(+), 41 deletions(-)
diff --git a/Documentation/networking/bonding.txt b/Documentation/networking/bonding.txt
index 25d2f41..8a27f0f 100644
--- a/Documentation/networking/bonding.txt
+++ b/Documentation/networking/bonding.txt
@@ -1404,10 +1404,11 @@ By default the bonding driver is multiqueue aware and 16 queues are created
when the driver initializes (see Documentation/networking/multiqueue.txt
for details). If more or less queues are desired the module parameter
tx_queues can be used to change this value. There is no sysfs parameter
-available as the allocation is done at module init time.
+available as the allocation is done at module init time. Currently only one
+queue per device can be set.
The output of the file /proc/net/bonding/bondX has changed so the output Queue
-ID is now printed for each slave:
+ID is now printed for each slave that has a queue configured:
Bonding Mode: fault-tolerance (active-backup)
Primary Slave: None
@@ -1421,7 +1422,6 @@ Slave Interface: eth0
MII Status: up
Link Failure Count: 0
Permanent HW addr: 00:1a:a0:12:8f:cb
-Slave queue ID: 0
Slave Interface: eth1
MII Status: up
@@ -1431,12 +1431,16 @@ Slave queue ID: 2
The queue_id for a slave can be set using the command:
-# echo "eth1:2" > /sys/class/net/bond0/bonding/queue_id
+# echo "+eth1:2" > /sys/class/net/bond0/bonding/queue_id
-Any interface that needs a queue_id set should set it with multiple calls
-like the one above until proper priorities are set for all interfaces. On
-distributions that allow configuration via initscripts, multiple 'queue_id'
-arguments can be added to BONDING_OPTS to set all needed slave queues.
+and removed using the command:
+
+# echo "-eth1:2" > /sys/class/net/bond0/bonding/queue_id
+
+Any interface that needs a queue_id set should set it with multiple calls until
+proper priorities are set or cleared for all interfaces. On distributions that
+allow configuration via initscripts, multiple 'queue_id' arguments can be added
+to BONDING_OPTS to set all needed slave queues.
These queue id's can be used in conjunction with the tc utility to configure
a multiqueue qdisc and filters to bias certain traffic to transmit on certain
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index 77e3c6a..c9723d6 100644
--- a/drivers/net/bonding/bond_main.c
+++ b/drivers/net/bonding/bond_main.c
@@ -1560,8 +1560,8 @@ int bond_enslave(struct net_device *bond_dev, struct net_device *slave_dev)
}
/*
- * Set the new_slave's queue_id to be zero. Queue ID mapping
- * is set via sysfs or module option if desired.
+ * Set the new_slave's queue_id to be zero to disable. Queue ID
+ * mapping is set via sysfs.
*/
new_slave->queue_id = 0;
@@ -3355,7 +3355,8 @@ static void bond_info_show_slave(struct seq_file *seq,
else
seq_puts(seq, "Aggregator ID: N/A\n");
}
- seq_printf(seq, "Slave queue ID: %d\n", slave->queue_id);
+ if (slave_tx_queue_recorded(slave))
+ seq_printf(seq, "Slave queue ID: %d\n", slave_get_tx_queue(slave));
}
static int bond_info_seq_show(struct seq_file *seq, void *v)
@@ -4516,15 +4517,16 @@ static inline int bond_slave_override(struct bonding *bond,
/* Find out if any slaves have the same mapping as this skb. */
bond_for_each_slave(bond, check_slave, i) {
- if (check_slave->queue_id == skb->queue_mapping) {
+ if (slave_tx_queue_recorded(check_slave) &&
+ slave_get_tx_queue(check_slave) == skb->queue_mapping) {
slave = check_slave;
break;
}
}
/* If the slave isn't UP, use default transmit policy. */
- if (slave && slave->queue_id && IS_UP(slave->dev) &&
- (slave->link == BOND_LINK_UP)) {
+ if (slave && slave_tx_queue_recorded(slave) &&
+ IS_UP(slave->dev) && (slave->link == BOND_LINK_UP)) {
res = bond_dev_queue_xmit(bond, skb, slave->dev);
}
@@ -4537,7 +4539,7 @@ static u16 bond_select_queue(struct net_device *dev, struct sk_buff *skb)
{
/*
* This helper function exists to help dev_pick_tx get the correct
- * destination queue. Using a helper function skips the a call to
+ * destination queue. Using a helper function skips the call to
* skb_tx_hash and will put the skbs in the queue we expect on their
* way down to the bonding driver.
*/
diff --git a/drivers/net/bonding/bond_sysfs.c b/drivers/net/bonding/bond_sysfs.c
index 72bb0f6..d09701f 100644
--- a/drivers/net/bonding/bond_sysfs.c
+++ b/drivers/net/bonding/bond_sysfs.c
@@ -1448,15 +1448,18 @@ static ssize_t bonding_show_queue_id(struct device *d,
read_lock(&bond->lock);
bond_for_each_slave(bond, slave, i) {
- if (res > (PAGE_SIZE - IFNAMSIZ - 6)) {
- /* not enough space for another interface_name:queue_id pair */
- if ((PAGE_SIZE - res) > 10)
- res = PAGE_SIZE - 10;
- res += sprintf(buf + res, "++more++ ");
- break;
+ if (slave_tx_queue_recorded(slave)) {
+ if (res > (PAGE_SIZE - IFNAMSIZ - 6)) {
+ /* Not enough space for another
+ * interface_name:queue_id pair. */
+ if ((PAGE_SIZE - res) > 10)
+ res = PAGE_SIZE - 10;
+ res += sprintf(buf + res, "++more++ ");
+ break;
+ }
+ res += sprintf(buf + res, "%s:%d ", slave->dev->name,
+ slave_get_tx_queue(slave));
}
- res += sprintf(buf + res, "%s:%d ",
- slave->dev->name, slave->queue_id);
}
read_unlock(&bond->lock);
if (res)
@@ -1479,55 +1482,71 @@ static ssize_t bonding_store_queue_id(struct device *d,
int i, ret = count;
char *delim;
struct net_device *sdev = NULL;
+ char command[IFNAMSIZ + 7] = {0, };
+ char *ifname;
if (!rtnl_trylock())
return restart_syscall();
+ sscanf(buffer, "%22s", command); /* IFNAMSIZ*/
+
/* delim will point to queue id if successful */
- delim = strchr(buffer, ':');
+ delim = strchr(command + 1, ':');
if (!delim)
goto err_no_cmd;
-
/*
* Terminate string that points to device name and bump it
* up one, so we can read the queue id there.
*/
*delim = '\0';
- if (sscanf(++delim, "%hd\n", &qid) != 1)
+ if (sscanf(++delim, "%hd\n", &qid) != 1) {
goto err_no_cmd;
+ }
- /* Check buffer length, valid ifname and queue id */
- if (strlen(buffer) > IFNAMSIZ ||
- !dev_valid_name(buffer) ||
- qid > bond->params.tx_queues)
+ /* ifname will now be command + 1 */
+ ifname = command + 1;
+ if ((strlen(command) <= 1) ||
+ !dev_valid_name(ifname) ||
+ qid >= bond->params.tx_queues)
goto err_no_cmd;
/* Get the pointer to that interface if it exists */
- sdev = __dev_get_by_name(dev_net(bond->dev), buffer);
+ sdev = __dev_get_by_name(dev_net(bond->dev), ifname);
if (!sdev)
goto err_no_cmd;
read_lock(&bond->lock);
- /* Search for thes slave and check for duplicate qids */
+ /* Search for the slave needing the change */
update_slave = NULL;
bond_for_each_slave(bond, slave, i) {
if (sdev == slave->dev)
- /*
- * We don't need to check the matching
- * slave for dups, since we're overwriting it
- */
update_slave = slave;
- else if (qid && qid == slave->queue_id) {
+ else if (slave_tx_queue_recorded(slave) &&
+ qid == slave_get_tx_queue(slave)) {
goto err_no_cmd_unlock;
}
}
-
if (!update_slave)
goto err_no_cmd_unlock;
- /* Actually set the qids for the slave */
- update_slave->queue_id = qid;
+ /* at this point we have a valid slave */
+ switch (command[0]) {
+ case '+':
+ if (slave_tx_queue_recorded(update_slave))
+ goto err_no_cmd_unlock;
+ slave_record_tx_queue(update_slave, qid);
+ break;
+ case '-':
+ if (!slave_tx_queue_recorded(update_slave) ||
+ slave_get_tx_queue(update_slave) != qid)
+ goto err_no_cmd_unlock;
+ slave_clear_tx_queue(update_slave);
+ break;
+
+ default:
+ goto err_no_cmd;
+ }
read_unlock(&bond->lock);
out:
@@ -1537,7 +1556,7 @@ out:
err_no_cmd_unlock:
read_unlock(&bond->lock);
err_no_cmd:
- pr_info("invalid input for queue_id set for %s.\n",
+ pr_info("cannot modify queue_id for %s.\n",
bond->dev->name);
ret = -EPERM;
goto out;
diff --git a/drivers/net/bonding/bonding.h b/drivers/net/bonding/bonding.h
index 31fe980..c9059f4 100644
--- a/drivers/net/bonding/bonding.h
+++ b/drivers/net/bonding/bonding.h
@@ -422,4 +422,24 @@ static inline void bond_unregister_ipv6_notifier(void)
}
#endif
+static inline void slave_record_tx_queue(struct slave *slave, u16 tx_queue)
+{
+ slave->queue_id = tx_queue + 1;
+}
+
+static inline u16 slave_get_tx_queue(const struct slave *slave)
+{
+ return slave->queue_id - 1;
+}
+
+static inline bool slave_tx_queue_recorded(const struct slave *slave)
+{
+ return slave->queue_id != 0;
+}
+
+static inline void slave_clear_tx_queue(struct slave *slave)
+{
+ slave->queue_id = 0;
+}
+
#endif /* _LINUX_BONDING_H */
^ permalink raw reply related
* Re: [patch net-next-2.6 V3] net: convert bonding to use rx_handler
From: Nicolas de Pesloüan @ 2011-02-21 23:20 UTC (permalink / raw)
To: Jiri Pirko
Cc: Jay Vosburgh, David Miller, kaber, eric.dumazet, netdev,
shemminger, andy, Fischer, Anna
In-Reply-To: <20110220150710.GB2750@psychotron.redhat.com>
Le 20/02/2011 16:07, Jiri Pirko a écrit :
> Sun, Feb 20, 2011 at 01:12:01PM CET, nicolas.2p.debian@gmail.com wrote:
[snip]
>> And thinking about all this, I wonder what the protocol handlers expect as the orig_dev value ?
>>
>> Lets imagine the following configuration: eth0 -> bond0 -> br0.
>>
>> What does a protocol handler listening on br0 expect for orig_dev ?
>> bond0 or eth0 ? Current implementation give eth0, but I think bond0
>> should be the right value, for proper nesting.
>
> I agree with you.
[snip}
>>> This hook is something I do not like at all :/ But anyway if should be in vlan
>>> part I think.
>>
>> Yes, and in order for the future rx_handler for vlan to properly
>> handle it, it needs to know the device just below it, not the pure
>> original device. Hence, my question about the exact meaning of
>> orig_dev...
After checking every protocol handlers installed by dev_add_pack(), it appears that only 4 of them
really use the orig_dev parameter given by __netif_receive_skb():
- bond_3ad_lacpdu_recv() @ drivers/net/bonding/bond_3ad.c
- bond_arp_recv() @ drivers/net/bonding/bond_main.c
- packet_rcv() @ net/packet/af_packet.c
- tpacket_rcv() @ net/packet/af_packet.c
From the bonding point of view, the meaning of orig_dev is obviously "the device one layer below
the bonding device, through which the packet reached the bonding device". It is used by
bond_3ad_lacpdu_recv() and bond_arp_recv(), to find the underlying slave device through which the
LACPDU or ARP was received. (The protocol handler is registered at the bonding device level).
From the af_packet point of view, the meaning is documented (in commit "[AF_PACKET]: Add option to
return orig_dev to userspace") as the "physical device [that] actually received the traffic, instead
of having the encapsulating device hide that information."
When the bonding device is just one level above the physical device, the two meanings happen to
match the same device, by chance.
So, currently, a bonding device cannot stack properly on top of anything but physical devices. It
might not be a problem today, but may change in the future...
Nicolas.
^ permalink raw reply
* TX VLAN acceleration on bridges broken in 2.6.37?
From: Jan Niehusmann @ 2011-02-21 23:29 UTC (permalink / raw)
To: linux-kernel; +Cc: netdev
With the following configuration, sending vlan tagged traffic from a
bridged interface doesn't work in 2.6.37.
The same configuration does work with 2.6.36:
- bridge br0 with physical interface eth0
- eth0 being an e1000e device (don't know if that's important)
- vlan interface br0.10
- (on 2.6.37) tx vlan acceleration active on br0 (default)
Networking on br0.10 doesn't work, and tcpdump on eth0 shows packets
sent on br0.10 as untagged, instead of vlan 10 tagged.
After turning vlan tx offloading off with 'ethtool -K br0 txvlan off',
everything works as expected, again.
The workaround is made permanent by reverting "bridge: Add support for
TX vlan offload.", 361ff8a6cf90d62c0071b7e532e37369bfd3ae77, turning
of the feature on bridges completely.
Jan
^ permalink raw reply
* RPS runs with multiqueue NIC
From: Jon Zhou @ 2011-02-22 3:07 UTC (permalink / raw)
To: netdev@vger.kernel.org
Hi
What will happen if RPS runs on kernel 2.6.36.4 machine where a multiqueue NIC intel x520 installed
Will it decrease or improve performance?
rui
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox