* Re: [PATCH 00/21] clean up rx_copybreak handling [split version]
From: Michał Mirosław @ 2011-07-10 11:28 UTC (permalink / raw)
To: Joe Perches
Cc: netdev, Steffen Klassert, Santiago Leon, Tim Hockin, Don Fry,
Francois Romieu, Ion Badulescu, Matt Carlson, Michael Chan,
Grant Grundler, David Dillow, Roger Luethi, David S. Miller
In-Reply-To: <1310235632.3848.13.camel@Joe-Laptop>
On Sat, Jul 09, 2011 at 11:20:32AM -0700, Joe Perches wrote:
> On Sat, 2011-07-09 at 19:17 +0200, Michał Mirosław wrote:
> > Split version of rx_copybreak cleanup patch.
>
> Hello Michał.
>
> Looks good, thanks for doing this work.
>
> One style quibble.
>
> You use this style:
>
> + skb = dev_skb_finish_rx_dma(&np->rx_skbuff[entry],
> + pkt_len, rx_copybreak,
> + &np->pci_dev->dev,
> + le32_to_cpu(desc->frag[0].addr),
> + np->rx_buf_sz);
>
> where almost all other uses throughout drivers/net
> align arguments to open parenthesis instead.
>
> + skb = dev_skb_finish_rx_dma(&np->rx_skbuff[entry],
> + pkt_len, rx_copybreak,
> + &np->pci_dev->dev,
> + le32_to_cpu(desc->frag[0].addr),
> + np->rx_buf_sz);
I'll fix that in v2 where the style differs.
Best Regards,
Michał Mirosław
^ permalink raw reply
* Re: 3.0-rc6-git6: Reported regressions from 2.6.39
From: Rafael J. Wysocki @ 2011-07-10 11:12 UTC (permalink / raw)
To: Johannes Berg
Cc: Linux Kernel Mailing List, Maciej Rutecki, Florian Mickler,
Andrew Morton, Linus Torvalds, Kernel Testers List,
Network Development, Linux ACPI, Linux PM List, Linux SCSI List,
Linux Wireless List, DRI
In-Reply-To: <1310295277.3942.1.camel@jlt3.sipsolutions.net>
On Sunday, July 10, 2011, Johannes Berg wrote:
> On Sun, 2011-07-10 at 12:19 +0200, Rafael J. Wysocki wrote:
>
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=38702
> > Subject : 3.0.0-rc4-git6 - INFO: possible circular locking dependency detected - (&rdev->mtx){+.+.+.}, at: [<ffffffffa00e27e0>] cfg80211_netdev_notifier_call+0x275/0x4ff [cfg80211]
> > Submitter : Miles Lane <miles.lane@gmail.com>
> > Date : 2011-06-26 21:54 (15 days old)
> > Message-ID : <BANLkTikztsFnPkJZ7VxRC-zsitwCCvVmeg@mail.gmail.com>
> > References : http://marc.info/?l=linux-kernel&m=130912559804336&w=2
>
> Should be fixed by c10841ca722a0bc960dc541c51582773f9a24f98 which was
> part of John's latest pull request and is in net-2.6 now on its way up.
Thanks, closing.
Rafael
^ permalink raw reply
* 3.0-rc6-git6: Reported regressions 2.6.38 -> 2.6.39
From: Rafael J. Wysocki @ 2011-07-10 10:54 UTC (permalink / raw)
To: Linux Kernel Mailing List
Cc: Maciej Rutecki, Florian Mickler, Andrew Morton, Linus Torvalds,
Kernel Testers List, Network Development, Linux ACPI,
Linux PM List, Linux SCSI List, Linux Wireless List, DRI
This message contains a list of some post-2.6.38 regressions introduced before
2.6.39, for which there are no fixes in the mainline known to the tracking team.
If any of them have been fixed already, please let us know.
If you know of any other unresolved post-2.6.38 regressions, please let us know
either and we'll add them to the list. Also, please let us know if any
of the entries below are invalid.
Each entry from the list will be sent additionally in an automatic reply to
this message with CCs to the people involved in reporting and handling the
issue.
Listed regressions statistics:
Date Total Pending Unresolved
----------------------------------------
2011-07-10 99 26 24
2011-06-27 94 25 23
2011-06-12 81 21 18
2011-05-15 50 12 11
2011-04-30 38 17 16
2011-04-17 17 11 10
Unresolved regressions
----------------------
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=38842
Subject : panic in elv_completed_request on safe remove usb hard drive
Submitter : leniviy <basinilya-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date : 2011-07-06 09:20 (5 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=38742
Subject : After hard power-off, btrfs cannot be recovered except booting 2.6.38 or below kernel
Submitter : Ryan Underwood <nemesis-RBwgCYbvQ+vk1uMJSBkQmQ@public.gmane.org>
Date : 2011-07-03 18:57 (8 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=38572
Subject : New NFS: directory XXX contains a readdir loop seems to be triggered by well-behaving server
Submitter : Petr Vandrovec <petr-vPk2MGR0e28uaRcfnNAh7A@public.gmane.org>
Date : 2011-06-30 19:38 (11 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=38132
Subject : [Warning] 2.6.39.x latencytop
Submitter : Andrew Watts <akwatts-DaQTI0RpDDMAvxtiuMwx3w@public.gmane.org>
Date : 2011-06-14 17:07 (27 days old)
Message-ID : <80098.5633.qm-tGSp4LqzbTn6X00i2u5GFvu2YVrzzGjVVpNB7YpNyf8@public.gmane.org>
References : http://marc.info/?l=linux-kernel&m=130807128506490&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=38102
Subject : BUG kmalloc-2048: Poison overwritten
Submitter : Alexey Zaytsev <alexey.zaytsev-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date : 2011-06-23 17:33 (18 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=37772
Subject : Sometimes, sound disappears and doesn't want to idle.
Submitter : <merkil-kt3qwsSULN8dnm+yROfE0A@public.gmane.org>
Date : 2011-06-17 22:06 (24 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=37752
Subject : Kernel Panic in drm_vblank_put+0x13/0x50 on P4 HT machine with 82915G/GV/910GL Integrated Graphics Controller
Submitter : Martin Rogge <marogge-53koH/AXb86i2/dY4+mD5w@public.gmane.org>
Date : 2011-06-17 13:02 (24 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=37712
Subject : reboot / "shutdown -r now" hangs ; works fine on 2.6.38.7-1
Submitter : Dave Hooper <dave-kId6I2PxnVtBDgjK7y7TUQ@public.gmane.org>
Date : 2011-06-16 20:50 (25 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=37692
Subject : Linux 2.6.39.x fails to boot - unable to mount root fs
Submitter : Dan Dart <dandart-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>
Date : 2011-06-16 18:55 (25 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=37622
Subject : Poor wireless performance with Intel 4965AGN with iwl-legacy/iwl4965
Submitter : <MDstr_1-PkbjNfxxIARBDgjK7y7TUQ@public.gmane.org>
Date : 2011-06-16 11:22 (25 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=37472
Subject : Lenovo U160 (i915 black screen)
Submitter : Robse <rob-se-Dz115AEZgoU@public.gmane.org>
Date : 2011-06-14 15:17 (27 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=37322
Subject : high load, unresponsive system spinning in rcu_kthread
Submitter : Ferenc Wágner <wferi-eEbw3PyuezQ@public.gmane.org>
Date : 2011-06-12 14:53 (29 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=37312
Subject : Intel 5100 wifi stopped working with 2.6.39.1
Submitter : Thibault Dory <dory.thibault-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date : 2011-06-12 12:43 (29 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=37292
Subject : kernel BUG at fs/ecryptfs/read_write.c:47!
Submitter : <rems14-fqJXh2VwIQ9ByuSxxbvQtw@public.gmane.org>
Date : 2011-06-12 10:25 (29 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=37042
Subject : linux 3.0.0-rc2 libata-eh.c:4018 ata_scsi_port_error_handler+0x80/0x53d on s2disk
Submitter : Alex Zhavnerchik <alex.vizor-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date : 2011-06-09 08:22 (32 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=36952
Subject : [2.6.39] CIFS write failures where 2.6.38 works
Submitter : Helge Hafting <helge.hafting-CND4fxrytsY@public.gmane.org>
Date : 2011-06-01 10:11 (40 days old)
Message-ID : <4DE6103E.6010100-CND4fxrytsY@public.gmane.org>
References : http://marc.info/?l=linux-kernel&m=130692387613423&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=36392
Subject : 2.6.39, 3.0-rc2 Intel DRI Regression: Black Screen after trying to play video
Submitter : Dennis Jansen <dennis.jansen-S0/GAf8tV78@public.gmane.org>
Date : 2011-06-01 04:41 (40 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=36332
Subject : Intel gpu turns external monitor off when X starts
Submitter : rocko <rockorequin-PkbjNfxxIARBDgjK7y7TUQ@public.gmane.org>
Date : 2011-05-31 02:53 (41 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=36182
Subject : Erroneous package power limit notification since kernel 2.6.39
Submitter : Olaf Freyer <aaron667-hi6Y0CQ0nG0@public.gmane.org>
Date : 2011-05-22 13:01 (50 days old)
Message-ID : <4DD9092A.4080507-hi6Y0CQ0nG0@public.gmane.org>
References : http://marc.info/?l=linux-kernel&m=130606930631131&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=35922
Subject : SND_USB_AUDIO recording device not initializing correctly
Submitter : <bjoern.online-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date : 2011-05-26 10:30 (46 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=35662
Subject : softlockup with kernel 2.6.39
Submitter : Hussam Al-Tayeb <ht990332-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date : 2011-05-23 08:13 (49 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=35242
Subject : NULL pointer dereference in intel_sdvo_write_cmd (was Black screen after boot)
Submitter : Ko Mi <chaostya.test-PkbjNfxxIARBDgjK7y7TUQ@public.gmane.org>
Date : 2011-05-17 10:27 (55 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=35142
Subject : 2.6.39-rc7-git1 boot error message (no crash)
Submitter : werner <w.landgraf-ow1r9FSYgO0@public.gmane.org>
Date : 2011-05-11 4:58 (61 days old)
Message-ID : <web-520830057-zcyLqNHFQq3Ee+7He9zlJw@public.gmane.org>
References : http://marc.info/?l=linux-kernel&m=130512952706444&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=34942
Subject : [Bug] Kdump does not work when panic triggered due to MCE
Submitter : K.Prasad <prasad-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
Date : 2011-05-06 16:54 (66 days old)
Message-ID : <20110506165412.GB2719-xthvdsQ13ZrQT0dZR+AlfA@public.gmane.org>
References : http://marc.info/?l=linux-kernel&m=130470087226270&w=2
Regressions with patches
------------------------
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=35642
Subject : On resume, I sometimes get a kernel oops with led_trigger_unregister_simple
Submitter : Sven-Hendrik Haase <sh-5wni8d9J0yJl57MIdRCFDg@public.gmane.org>
Date : 2011-05-23 00:15 (49 days old)
Patch : https://patchwork.kernel.org/patch/927582/
https://patchwork.kernel.org/patch/927612/
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=33242
Subject : Lockdep splat in autofs with 2.6.39-rc2
Submitter : Nick Bowler <nbowler-7BP4RkwGw0uXmMXjJBpWqg@public.gmane.org>
Date : 2011-04-07 19:44 (95 days old)
Message-ID : <20110407194403.GA29404-7BP4RkwGw0uXmMXjJBpWqg@public.gmane.org>
References : http://marc.info/?l=linux-kernel&m=130220545614682&w=2
Patch : http://marc.info/?l=linux-kernel&m=130342115008659&w=2
For details, please visit the bug entries and follow the links given in
references.
As you can see, there is a Bugzilla entry for each of the listed regressions.
There also is a Bugzilla entry used for tracking the regressions introduced
between 2.6.38 and 2.6.39, unresolved as well as resolved, at:
http://bugzilla.kernel.org/show_bug.cgi?id=32012
Please let the tracking team know if there are any Bugzilla entries that
should be added to the list in there.
Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* Re: 3.0-rc6-git6: Reported regressions from 2.6.39
From: Johannes Berg @ 2011-07-10 10:54 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Linux Kernel Mailing List, Maciej Rutecki, Florian Mickler,
Andrew Morton, Linus Torvalds, Kernel Testers List,
Network Development, Linux ACPI, Linux PM List, Linux SCSI List,
Linux Wireless List, DRI
In-Reply-To: <Y7LyOsOBwFM.A.kJG.kBYGOB@chimera>
On Sun, 2011-07-10 at 12:19 +0200, Rafael J. Wysocki wrote:
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=38702
> Subject : 3.0.0-rc4-git6 - INFO: possible circular locking dependency detected - (&rdev->mtx){+.+.+.}, at: [<ffffffffa00e27e0>] cfg80211_netdev_notifier_call+0x275/0x4ff [cfg80211]
> Submitter : Miles Lane <miles.lane-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Date : 2011-06-26 21:54 (15 days old)
> Message-ID : <BANLkTikztsFnPkJZ7VxRC-zsitwCCvVmeg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
> References : http://marc.info/?l=linux-kernel&m=130912559804336&w=2
Should be fixed by c10841ca722a0bc960dc541c51582773f9a24f98 which was
part of John's latest pull request and is in net-2.6 now on its way up.
johannes
^ permalink raw reply
* 3.0-rc6-git6: Reported regressions from 2.6.39
From: Rafael J. Wysocki @ 2011-07-10 10:19 UTC (permalink / raw)
To: Linux Kernel Mailing List
Cc: Maciej Rutecki, Florian Mickler, Andrew Morton, Linus Torvalds,
Kernel Testers List, Network Development, Linux ACPI,
Linux PM List, Linux SCSI List, Linux Wireless List, DRI
This message contains a list of some regressions from 2.6.39,
for which there are no fixes in the mainline known to the tracking team.
If any of them have been fixed already, please let us know.
If you know of any other unresolved regressions from 2.6.39, please let us
know either and we'll add them to the list. Also, please let us know
if any of the entries below are invalid.
Each entry from the list will be sent additionally in an automatic reply
to this message with CCs to the people involved in reporting and handling
the issue.
Listed regressions statistics:
Date Total Pending Unresolved
----------------------------------------
2011-07-10 38 16 13
2011-06-26 22 14 12
2011-06-12 8 7 7
Unresolved regressions
----------------------
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=39052
Subject : .tmp_depmod owned by root after modules_install
Submitter : Christian Kujau <lists-AanptEQQ3TL9uQeqpI+JUg@public.gmane.org>
Date : 2011-07-04 9:49 (7 days old)
Message-ID : <alpine.DEB.2.01.1107040242180.9183-yMVncJ7Z0T9hhup4ARC/jw@public.gmane.org>
References : http://marc.info/?l=linux-kernel&m=130977296812731&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=38802
Subject : Not work hotkey of Microsoft Comfort Curve Keyboard 2000
Submitter : Cristian Aravena Romero <caravena-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date : 2011-07-05 20:43 (6 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=38732
Subject : Linux 3.0-rc5 doesnt boot and hangs at rcu_sched_state ()
Submitter : RKK <kulkarni.ravi4-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date : 2011-06-29 13:38 (12 days old)
Message-ID : <BANLkTikW6Xk8UMsOHLCnLn7STRzy8RaiJA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
References : http://marc.info/?l=linux-kernel&m=130935402722869&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=38702
Subject : 3.0.0-rc4-git6 - INFO: possible circular locking dependency detected - (&rdev->mtx){+.+.+.}, at: [<ffffffffa00e27e0>] cfg80211_netdev_notifier_call+0x275/0x4ff [cfg80211]
Submitter : Miles Lane <miles.lane-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date : 2011-06-26 21:54 (15 days old)
Message-ID : <BANLkTikztsFnPkJZ7VxRC-zsitwCCvVmeg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
References : http://marc.info/?l=linux-kernel&m=130912559804336&w=2
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=38672
Subject : KVM guest boot crashed
Submitter : Steve <stefan.bosak-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date : 2011-07-02 06:56 (9 days old)
First-Bad-Commit: http://git.kernel.org/linus/6506e4f995967b1a48cc34418c77b318df92ce35
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=38622
Subject : [radeon cayman regresion] artefacts on screen
Submitter : Marek Hobler, 'neutrinus' <kernellist-X/h6sc6Dz0uakBO8gow8eQ@public.gmane.org>
Date : 2011-07-01 09:35 (10 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=38612
Subject : Boot time warnings in APIC
Submitter : Bill Huey <bill.huey-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date : 2011-07-01 06:44 (10 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=38582
Subject : T510 43495KG won't resume with 32bit installation
Submitter : Marc Koschewski <marc-e1Wt+8K1Ta8ZEwqihLH0+Q@public.gmane.org>
Date : 2011-06-30 22:39 (11 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=38522
Subject : address space collision error message on boot
Submitter : Jools Wills <jools-ApNQbik20ZdhgJEaYHuxyvXRex20P6io@public.gmane.org>
Date : 2011-06-29 02:28 (12 days old)
First-Bad-Commit: http://git.kernel.org/linus/5d94e81f69d4b1d1102d3ab557ce0a817c11fbbb
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=38332
Subject : System hang when enable rc6
Submitter : Gu Rui <chaos.proton-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date : 2011-06-27 08:16 (14 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=37872
Subject : CPU lockup during boot
Submitter : Bruno Wolff III <bruno-bdMChIhFSYk@public.gmane.org>
Date : 2011-06-19 15:00 (22 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=37482
Subject : Driver: i915 - Starting with kernel 3.0.0-rc3, dual monitor freezes a Dell Latitude E6410 when a second monitor is connected at boot time
Submitter : David Hill <hilld-HTiBYHdybX7UkGsOFmftXw@public.gmane.org>
Date : 2011-06-14 18:42 (27 days old)
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=37432
Subject : sdhci-pci fails on 3.0.0-rc1 on Dell E6510
Submitter : Oliver Hartkopp <socketcan-fJ+pQTUTwRTk1uMJSBkQmQ@public.gmane.org>
Date : 2011-06-07 20:06 (34 days old)
First-Bad-Commit: http://git.kernel.org/linus/da7822e5ad71ec9b745b412639f1e5e0ba795a20
References : http://article.gmane.org/gmane.linux.kernel.mmc/8442
https://lkml.org/lkml/2011/6/23/660
Regressions with patches
------------------------
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=38972
Subject : Kernel panic when syncing while cifs is mounted
Submitter : <farbing-S0/GAf8tV78@public.gmane.org>
Date : 2011-07-08 15:39 (3 days old)
First-Bad-Commit: http://git.kernel.org/linus/dd8544661947ad6d8d87b3c9d4333bfa1583d1bc
Handled-By : Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Patch : https://bugzilla.kernel.org/attachment.cgi?id=65082
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=38302
Subject : NFS crash in un-modified 3.0.0-rc3+, list corruption.
Submitter : Ben Greear <greearb-my8/4N5VtI7c+919tysfdA@public.gmane.org>
Date : 2011-06-20 22:42 (21 days old)
Message-ID : <4DFFCCDC.2070106-my8/4N5VtI7c+919tysfdA@public.gmane.org>
References : http://marc.info/?l=linux-kernel&m=130860979610651&w=2
Patch : https://bugzilla.kernel.org/attachment.cgi?id=63902
Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=38152
Subject : acpi_power_off lockdep splat
Submitter : Borislav Petkov <bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org>
Date : 2011-06-19 13:30 (22 days old)
Message-ID : <20110619133049.GA18168-f9CnO7I+Q6zU6FkGJEIX5A@public.gmane.org>
References : http://marc.info/?l=linux-kernel&m=130849028317365&w=2
Handled-By : Rafael J. Wysocki <rjw-KKrjLPT3xs0@public.gmane.org>
Patch : https://patchwork.kernel.org/patch/950852/
For details, please visit the bug entries and follow the links given in
references.
As you can see, there is a Bugzilla entry for each of the listed regressions.
There also is a Bugzilla entry used for tracking the regressions from 2.6.39,
unresolved as well as resolved, at:
http://bugzilla.kernel.org/show_bug.cgi?id=36912
Please let the tracking team know if there are any Bugzilla entries that
should be added to the list in there.
Thanks!
^ permalink raw reply
* [PATCH 3/5] ath5k: Add missing breaks in switch/case
From: Joe Perches @ 2011-07-10 9:28 UTC (permalink / raw)
To: Jiri Slaby, Nick Kossifidis, Luis R. Rodriguez, Bob Copeland
Cc: John W. Linville, linux-wireless, ath5k-devel, netdev,
linux-kernel
In-Reply-To: <cover.1310289795.git.joe@perches.com>
Signed-off-by: Joe Perches <joe@perches.com>
---
drivers/net/wireless/ath/ath5k/desc.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/net/wireless/ath/ath5k/desc.c b/drivers/net/wireless/ath/ath5k/desc.c
index 62172d5..f82383b 100644
--- a/drivers/net/wireless/ath/ath5k/desc.c
+++ b/drivers/net/wireless/ath/ath5k/desc.c
@@ -107,10 +107,13 @@ ath5k_hw_setup_2word_tx_desc(struct ath5k_hw *ah, struct ath5k_desc *desc,
case AR5K_PKT_TYPE_BEACON:
case AR5K_PKT_TYPE_PROBE_RESP:
frame_type = AR5K_AR5210_TX_DESC_FRAME_TYPE_NO_DELAY;
+ break;
case AR5K_PKT_TYPE_PIFS:
frame_type = AR5K_AR5210_TX_DESC_FRAME_TYPE_PIFS;
+ break;
default:
frame_type = type;
+ break;
}
tx_ctl->tx_control_0 |=
--
1.7.6.131.g99019
^ permalink raw reply related
* [PATCH 0/5] treewide: Add missing breaks in switch/case
From: Joe Perches @ 2011-07-10 9:28 UTC (permalink / raw)
To: linux-wireless, ath5k-devel, linux-usb; +Cc: linux-kernel, netdev, alsa-devel
Found by grep. Uncompiled/untested.
Joe Perches (5):
gpio-tps65910.c: Add missing breaks in switch/case
tps65910-irq: Add missing breaks in switch/case
ath5k: Add missing breaks in switch/case
fusb300_udc: Add missing breaks in switch/case
dbri: Add missing breaks in switch/case
drivers/gpio/gpio-tps65910.c | 2 ++
drivers/mfd/tps65910-irq.c | 2 ++
drivers/net/wireless/ath/ath5k/desc.c | 3 +++
drivers/usb/gadget/fusb300_udc.c | 3 +++
sound/sparc/dbri.c | 5 +++++
5 files changed, 15 insertions(+), 0 deletions(-)
--
1.7.6.131.g99019
^ permalink raw reply
* Re: [PATCH] natsemi: silence dma-debug warnings
From: Michał Mirosław @ 2011-07-10 8:58 UTC (permalink / raw)
To: Jim Cromie; +Cc: David Miller, fujita.tomonori, thockin, netdev
In-Reply-To: <CAJfuBxxKYNvaw5t4jWMP4+hYcw42SkwLiiahVdeezpfh6AsLBA@mail.gmail.com>
2011/7/9 Jim Cromie <jim.cromie@gmail.com>:
> On Sun, Jul 3, 2011 at 11:34 PM, David Miller <davem@davemloft.net> wrote:
>> From: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
>> Date: Mon, 4 Jul 2011 14:30:19 +0900
>>
>>> This silences dma-debug warnings:
>>>
>>> https://lkml.org/lkml/2011/6/30/341
>> ...
>>> Reported-by: Jim Cromie <jim.cromie@gmail.com>
>>> Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
>>> Tested-by: Jim Cromie <jim.cromie@gmail.com>
>>
>> Applied, thanks!
>>
>
> I have since seen a similar warning on shutdown,
> heres a patch for it.
>
> theres one other callsite, but I havent seen the warning from it,
> will try to tickle it at some point.
[about attached patch]
Why not increase buflen, like in refill_rx()?
Best Regards,
Michał Mirosław
^ permalink raw reply
* Re: [PATCH 02/21] net: 3c59x: use common rx_copybreak handling
From: Francois Romieu @ 2011-07-10 7:24 UTC (permalink / raw)
To: Michał Mirosław; +Cc: netdev, Steffen Klassert
In-Reply-To: <20110709232339.GA15588@rere.qmqm.pl>
Michał Mirosław <mirq-linux@rere.qmqm.pl> :
[...]
> For this driver and via-velocity - you're right (fixed). For others no -
> they always refill the rx ring, possibly discarding the packet.
Ok, I completely missed the "_refill" part.
--
Ueimor
^ permalink raw reply
* Re: [PATCH] natsemi: silence dma-debug warnings
From: FUJITA Tomonori @ 2011-07-10 2:18 UTC (permalink / raw)
To: jim.cromie; +Cc: davem, thockin, netdev
In-Reply-To: <CAJfuBxwhxhMpxBS6L7FANcqeyipjCR1cjhPraYVpOv55_weC6g@mail.gmail.com>
On Sat, 9 Jul 2011 20:10:17 -0600
Jim Cromie <jim.cromie@gmail.com> wrote:
>>>> Which pci_unmap_single are you talking about?
>>>>
>>>
>>>
>>> 2131 static void netdev_tx_done(struct net_device *dev)
>>> 2132 {
>>> ...
>>> 2160 pci_unmap_single(np->pci_dev,np->tx_dma[entry],
>>> 2161 np->tx_skbuff[entry]->len,
>>> 2162 PCI_DMA_TODEVICE);
>>
>> It's pci_unmap_single call for tx_dma buffers. We fixed
>> pci_unmap_single calls for rx_dma buffers.
>>
>> Looks like the driver correctlly uses pci_map_single and
>> pci_unmap_single for tx_dma buffers.
>>
>
> thanks for checking.
>
> and oops, the one I was referring to was this one,
> patched locally.
>
>
> possible dma-debug error, unseen
>
> diff --git a/drivers/net/natsemi.c b/drivers/net/natsemi.c
> index e4bd202..0df7a47 100644
> --- a/drivers/net/natsemi.c
> +++ b/drivers/net/natsemi.c
> @@ -2007,8 +2007,8 @@ static void drain_tx(struct net_device *dev)
>
> for (i = 0; i < TX_RING_SIZE; i++) {
> if (np->tx_skbuff[i]) {
> - pci_unmap_single(np->pci_dev,
> - np->tx_dma[i], np->tx_skbuff[i]->len,
> + pci_unmap_single(np->pci_dev, np->tx_dma[i],
> + np->tx_skbuff[i]->len + NATSEMI_PADDING,
> PCI_DMA_TODEVICE);
> dev_kfree_skb(np->tx_skbuff[i]);
> dev->stats.tx_dropped++;
>
> again, I havent seen a warning here,
> either with or without this patch.
>
> Given the wording of the warning (mismatch, ie > or <, not ==)
> I presume I should get a warning if the PADDING is wrong here,
> and I actually run this codepath ?
I don't think you run this code path. And as I wrote, the current code
looks correct.
^ permalink raw reply
* Re: [PATCH] natsemi: silence dma-debug warnings
From: Jim Cromie @ 2011-07-10 2:10 UTC (permalink / raw)
To: FUJITA Tomonori; +Cc: davem, thockin, netdev
In-Reply-To: <20110710.105730.1305564732068163754.fujita.tomonori@lab.ntt.co.jp>
>>> Which pci_unmap_single are you talking about?
>>>
>>
>>
>> 2131 static void netdev_tx_done(struct net_device *dev)
>> 2132 {
>> ...
>> 2160 pci_unmap_single(np->pci_dev,np->tx_dma[entry],
>> 2161 np->tx_skbuff[entry]->len,
>> 2162 PCI_DMA_TODEVICE);
>
> It's pci_unmap_single call for tx_dma buffers. We fixed
> pci_unmap_single calls for rx_dma buffers.
>
> Looks like the driver correctlly uses pci_map_single and
> pci_unmap_single for tx_dma buffers.
>
thanks for checking.
and oops, the one I was referring to was this one,
patched locally.
possible dma-debug error, unseen
diff --git a/drivers/net/natsemi.c b/drivers/net/natsemi.c
index e4bd202..0df7a47 100644
--- a/drivers/net/natsemi.c
+++ b/drivers/net/natsemi.c
@@ -2007,8 +2007,8 @@ static void drain_tx(struct net_device *dev)
for (i = 0; i < TX_RING_SIZE; i++) {
if (np->tx_skbuff[i]) {
- pci_unmap_single(np->pci_dev,
- np->tx_dma[i], np->tx_skbuff[i]->len,
+ pci_unmap_single(np->pci_dev, np->tx_dma[i],
+ np->tx_skbuff[i]->len + NATSEMI_PADDING,
PCI_DMA_TODEVICE);
dev_kfree_skb(np->tx_skbuff[i]);
dev->stats.tx_dropped++;
again, I havent seen a warning here,
either with or without this patch.
Given the wording of the warning (mismatch, ie > or <, not ==)
I presume I should get a warning if the PADDING is wrong here,
and I actually run this codepath ?
^ permalink raw reply related
* Re: [PATCH] natsemi: silence dma-debug warnings
From: FUJITA Tomonori @ 2011-07-10 1:20 UTC (permalink / raw)
To: jim.cromie; +Cc: davem, thockin, netdev
In-Reply-To: <CAJfuBxxKYNvaw5t4jWMP4+hYcw42SkwLiiahVdeezpfh6AsLBA@mail.gmail.com>
On Sat, 9 Jul 2011 14:11:25 -0600
Jim Cromie <jim.cromie@gmail.com> wrote:
> On Sun, Jul 3, 2011 at 11:34 PM, David Miller <davem@davemloft.net> wrote:
>> From: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
>> Date: Mon, 4 Jul 2011 14:30:19 +0900
>>
>>> This silences dma-debug warnings:
>>>
>>> https://lkml.org/lkml/2011/6/30/341
>> ...
>>> Reported-by: Jim Cromie <jim.cromie@gmail.com>
>>> Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
>>> Tested-by: Jim Cromie <jim.cromie@gmail.com>
>>
>> Applied, thanks!
>>
>
> I have since seen a similar warning on shutdown,
> heres a patch for it.
Oops, I noticed this too but I forgot to send a patch.
The patch looks good to me.
> theres one other callsite, but I havent seen the warning from it,
> will try to tickle it at some point.
Which pci_unmap_single are you talking about?
^ permalink raw reply
* Re: [PATCH] natsemi: silence dma-debug warnings
From: FUJITA Tomonori @ 2011-07-10 1:57 UTC (permalink / raw)
To: jim.cromie; +Cc: davem, thockin, netdev
In-Reply-To: <CAJfuBxxs=CEBV+v+8GkYyabVobhwiXKYc5qHhZE-ZKFxywkQaQ@mail.gmail.com>
On Sat, 9 Jul 2011 19:45:22 -0600
Jim Cromie <jim.cromie@gmail.com> wrote:
> On Sat, Jul 9, 2011 at 7:20 PM, FUJITA Tomonori
> <fujita.tomonori@lab.ntt.co.jp> wrote:
>> On Sat, 9 Jul 2011 14:11:25 -0600
>> Jim Cromie <jim.cromie@gmail.com> wrote:
>>
>>> On Sun, Jul 3, 2011 at 11:34 PM, David Miller <davem@davemloft.net> wrote:
>>>> From: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
>>>> Date: Mon, 4 Jul 2011 14:30:19 +0900
>>>>
>>>>> This silences dma-debug warnings:
>>>>>
>>>>> https://lkml.org/lkml/2011/6/30/341
>>>> ...
>>>>> Reported-by: Jim Cromie <jim.cromie@gmail.com>
>>>>> Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
>>>>> Tested-by: Jim Cromie <jim.cromie@gmail.com>
>>>>
>>>> Applied, thanks!
>>>>
>>>
>>> I have since seen a similar warning on shutdown,
>>> heres a patch for it.
>>
>> Oops, I noticed this too but I forgot to send a patch.
>>
>> The patch looks good to me.
>>
>>
>>> theres one other callsite, but I havent seen the warning from it,
>>> will try to tickle it at some point.
>>
>> Which pci_unmap_single are you talking about?
>>
>
>
> 2131 static void netdev_tx_done(struct net_device *dev)
> 2132 {
> ...
> 2160 pci_unmap_single(np->pci_dev,np->tx_dma[entry],
> 2161 np->tx_skbuff[entry]->len,
> 2162 PCI_DMA_TODEVICE);
It's pci_unmap_single call for tx_dma buffers. We fixed
pci_unmap_single calls for rx_dma buffers.
Looks like the driver correctlly uses pci_map_single and
pci_unmap_single for tx_dma buffers.
^ permalink raw reply
* Re: [PATCH] natsemi: silence dma-debug warnings
From: Jim Cromie @ 2011-07-10 1:45 UTC (permalink / raw)
To: FUJITA Tomonori; +Cc: davem, thockin, netdev
In-Reply-To: <20110710.102039.1305564732068163396.fujita.tomonori@lab.ntt.co.jp>
On Sat, Jul 9, 2011 at 7:20 PM, FUJITA Tomonori
<fujita.tomonori@lab.ntt.co.jp> wrote:
> On Sat, 9 Jul 2011 14:11:25 -0600
> Jim Cromie <jim.cromie@gmail.com> wrote:
>
>> On Sun, Jul 3, 2011 at 11:34 PM, David Miller <davem@davemloft.net> wrote:
>>> From: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
>>> Date: Mon, 4 Jul 2011 14:30:19 +0900
>>>
>>>> This silences dma-debug warnings:
>>>>
>>>> https://lkml.org/lkml/2011/6/30/341
>>> ...
>>>> Reported-by: Jim Cromie <jim.cromie@gmail.com>
>>>> Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
>>>> Tested-by: Jim Cromie <jim.cromie@gmail.com>
>>>
>>> Applied, thanks!
>>>
>>
>> I have since seen a similar warning on shutdown,
>> heres a patch for it.
>
> Oops, I noticed this too but I forgot to send a patch.
>
> The patch looks good to me.
>
>
>> theres one other callsite, but I havent seen the warning from it,
>> will try to tickle it at some point.
>
> Which pci_unmap_single are you talking about?
>
2131 static void netdev_tx_done(struct net_device *dev)
2132 {
...
2160 pci_unmap_single(np->pci_dev,np->tx_dma[entry],
2161 np->tx_skbuff[entry]->len,
2162 PCI_DMA_TODEVICE);
^ permalink raw reply
* Re: [PATCH 02/21] net: 3c59x: use common rx_copybreak handling
From: Michał Mirosław @ 2011-07-09 23:23 UTC (permalink / raw)
To: Francois Romieu; +Cc: netdev, Steffen Klassert
In-Reply-To: <20110709222258.GA5642@electric-eye.fr.zoreil.com>
On Sun, Jul 10, 2011 at 12:22:58AM +0200, Francois Romieu wrote:
> Michał Mirosław <mirq-linux@rere.qmqm.pl> :
> [...]
> > diff --git a/drivers/net/3c59x.c b/drivers/net/3c59x.c
> > index 8cc2256..456726c 100644
> > --- a/drivers/net/3c59x.c
> > +++ b/drivers/net/3c59x.c
> [...]
> > + skb = dev_skb_finish_rx_dma(&vp->rx_skbuff[entry],
> > + pkt_len, rx_copybreak,
> > + &VORTEX_PCI(vp)->dev, dma, PKT_BUF_SZ);
> > + if (skb)
> s/if (skb)/if (vp->rx_skbuff[entry])/ probably
For this driver and via-velocity - you're right (fixed). For others no -
they always refill the rx ring, possibly discarding the packet.
Best Regards,
Michał Mirosław
^ permalink raw reply
* Re: [PATCH 15/21] net: tulip/de2104x: use common rx_copybreak handling [strict refill!]
From: Francois Romieu @ 2011-07-09 22:31 UTC (permalink / raw)
To: Michał Mirosław; +Cc: netdev, Grant Grundler
In-Reply-To: <29374e542d6211f31b9ed0571a60b795f4aed1bb.1310229312.git.mirq-linux@rere.qmqm.pl>
Michał Mirosław <mirq-linux@rere.qmqm.pl> :
[...]
> diff --git a/drivers/net/tulip/de2104x.c b/drivers/net/tulip/de2104x.c
> index ce90efc..80a34b6 100644
> --- a/drivers/net/tulip/de2104x.c
> +++ b/drivers/net/tulip/de2104x.c
> @@ -432,42 +431,22 @@ static void de_rx (struct de_private *de)
> goto rx_next;
> }
>
> - copying_skb = (len <= rx_copybreak);
> -
> netif_dbg(de, rx_status, de->dev,
> "rx slot %d status 0x%x len %d copying? %d\n",
> - rx_tail, status, len, copying_skb);
> + rx_tail, status, len, len <= rx_copybreak);
>
> - buflen = copying_skb ? (len + RX_OFFSET) : de->rx_buf_sz;
> - copy_skb = dev_alloc_skb (buflen);
> - if (unlikely(!copy_skb)) {
> + skb = dev_skb_finish_rx_dma_refill(&de->rx_skb[rx_tail].skb,
> + len, rx_copybreak, 0, RX_OFFSET,
> + &de->pdev->dev, &mapping, de->rx_buf_sz);
> + de->rx_skb[rx_tail].mapping = mapping;
> +
> + if (unlikely(!skb)) {
s/skb/de->rx_skb[rx_tail].skb/
--
Ueimor
^ permalink raw reply
* Re: [PATCH 09/21] net: pcnet32: use common rx_copybreak handling [strict refill!]
From: Francois Romieu @ 2011-07-09 22:28 UTC (permalink / raw)
To: Michał Mirosław; +Cc: netdev, Don Fry
In-Reply-To: <0f270b4469acf1db6e18025c7097f6e4e338ad5d.1310229312.git.mirq-linux@rere.qmqm.pl>
Michał Mirosław <mirq-linux@rere.qmqm.pl> :
[...]
> diff --git a/drivers/net/pcnet32.c b/drivers/net/pcnet32.c
> index 8b3090d..baae404 100644
> --- a/drivers/net/pcnet32.c
> +++ b/drivers/net/pcnet32.c
> @@ -1147,51 +1146,18 @@ static void pcnet32_rx_entry(struct net_device *dev,
> return;
> }
>
> - if (pkt_len > rx_copybreak) {
> - struct sk_buff *newskb;
> -
> - newskb = dev_alloc_skb(PKT_BUF_SKB);
> - if (newskb) {
> - skb_reserve(newskb, NET_IP_ALIGN);
> - skb = lp->rx_skbuff[entry];
> - pci_unmap_single(lp->pci_dev,
> - lp->rx_dma_addr[entry],
> - PKT_BUF_SIZE,
> - PCI_DMA_FROMDEVICE);
> - skb_put(skb, pkt_len);
> - lp->rx_skbuff[entry] = newskb;
> - lp->rx_dma_addr[entry] =
> - pci_map_single(lp->pci_dev,
> - newskb->data,
> - PKT_BUF_SIZE,
> - PCI_DMA_FROMDEVICE);
> - rxp->base = cpu_to_le32(lp->rx_dma_addr[entry]);
> - rx_in_place = 1;
> - } else
> - skb = NULL;
> - } else
> - skb = dev_alloc_skb(pkt_len + NET_IP_ALIGN);
> + skb = dev_skb_finish_rx_dma_refill(&lp->rx_skbuff[entry],
> + pkt_len, rx_copybreak, NET_IP_ALIGN, 0,
> + &lp->pci_dev->dev, &lp->rx_dma_addr[entry],
> + PKT_BUF_SIZE);
> + rxp->base = cpu_to_le32(lp->rx_dma_addr[entry]);
>
> if (skb == NULL) {
s/skb/lp->rx_skbuff[entry]/
--
Ueimor
^ permalink raw reply
* Re: [PATCH 07/21] net: lib82596: use common rx_copybreak handling [strict refill!]
From: Francois Romieu @ 2011-07-09 22:25 UTC (permalink / raw)
To: Michał Mirosław; +Cc: netdev
In-Reply-To: <041aed2721ea22ee6e7d122c3c21a59b4042f431.1310229312.git.mirq-linux@rere.qmqm.pl>
Michał Mirosław <mirq-linux@rere.qmqm.pl> :
[...]
> diff --git a/drivers/net/lib82596.c b/drivers/net/lib82596.c
> index 9e04289..d19e05b 100644
> --- a/drivers/net/lib82596.c
> +++ b/drivers/net/lib82596.c
> @@ -679,67 +679,29 @@ static inline int i596_rx(struct net_device *dev)
> if (rbd != NULL && (rfd->stat & SWAP16(STAT_OK))) {
> /* a good frame */
> int pkt_len = SWAP16(rbd->count) & 0x3fff;
> - struct sk_buff *skb = rbd->skb;
> - int rx_in_place = 0;
> + struct sk_buff *skb;
> + dma_addr_t dma_addr;
>
> DEB(DEB_RXADDR, print_eth(rbd->v_data, "received"));
> frames++;
>
> - /* Check if the packet is long enough to just accept
> - * without copying to a properly sized skbuff.
> - */
> + dma_addr = SWAP32(rbd->b_data);
> + skb = dev_skb_finish_rx_dma_refill(&rbd->skb,
> + pkt_len, rx_copybreak, NET_IP_ALIGN, 0,
> + dev->dev.parent, &dma_addr, PKT_BUF_SZ);
[...]
> + if (likely(skb)) {
s/skb/rbd->skb/
--
Ueimor
^ permalink raw reply
* Re: [PATCH 02/21] net: 3c59x: use common rx_copybreak handling
From: Francois Romieu @ 2011-07-09 22:22 UTC (permalink / raw)
To: Michał Mirosław; +Cc: netdev, Steffen Klassert
In-Reply-To: <5a242c5dbd6222d87b77a22b9c6fe6cdfa0351f3.1310229312.git.mirq-linux@rere.qmqm.pl>
Michał Mirosław <mirq-linux@rere.qmqm.pl> :
[...]
> diff --git a/drivers/net/3c59x.c b/drivers/net/3c59x.c
> index 8cc2256..456726c 100644
> --- a/drivers/net/3c59x.c
> +++ b/drivers/net/3c59x.c
[...]
> + skb = dev_skb_finish_rx_dma(&vp->rx_skbuff[entry],
> + pkt_len, rx_copybreak,
> + &VORTEX_PCI(vp)->dev, dma, PKT_BUF_SZ);
> + if (skb)
s/if (skb)/if (vp->rx_skbuff[entry])/ probably
--
Ueimor
^ permalink raw reply
* Re: [PATCH 20/21] net: via-velocity: use common rx_copybreak handling
From: Francois Romieu @ 2011-07-09 22:19 UTC (permalink / raw)
To: Michał Mirosław; +Cc: netdev
In-Reply-To: <fde4e58b4575124aaa9878ea2329dcb3445c50f0.1310229312.git.mirq-linux@rere.qmqm.pl>
Michał Mirosław <mirq-linux@rere.qmqm.pl> :
[...]
> diff --git a/drivers/net/via-velocity.c b/drivers/net/via-velocity.c
> index f929242..cdc51de 100644
> --- a/drivers/net/via-velocity.c
> +++ b/drivers/net/via-velocity.c
[...]
> @@ -2027,10 +1996,10 @@ static int velocity_rx_copy(struct sk_buff **rx_skb, int pkt_size,
> * configured by the user.
> */
> static inline void velocity_iph_realign(struct velocity_info *vptr,
> - struct sk_buff *skb, int pkt_size)
> + struct sk_buff *skb)
> {
> if (vptr->flags & VELOCITY_FLAGS_IP_ALIGN) {
> - memmove(skb->data + 2, skb->data, pkt_size);
> + memmove(skb->data + 2, skb->data, skb->len);
> skb_reserve(skb, 2);
> }
> }
[...]
> @@ -2078,30 +2044,25 @@ static int velocity_receive_frame(struct velocity_info *vptr, int idx)
> }
> }
>
> - pci_action = pci_dma_sync_single_for_device;
> + skb = dev_skb_finish_rx_dma(&rd_info->skb,
> + pkt_len - ETH_FCS_LEN, rx_copybreak,
> + &vptr->pdev->dev, rd_info->skb_dma, vptr->rx.buf_sz);
> + if (!skb)
> + /* not copied */
> + velocity_iph_realign(vptr, skb);
s/if (!skb)/if (!rd_info->skb)/ ?
--
Ueimor
^ permalink raw reply
* [PATCH 7/7] drivers/net: static should be at beginning of declaration
From: Jesper Juhl @ 2011-07-09 21:24 UTC (permalink / raw)
To: linux-kernel
Cc: trivial, Greg Kroah-Hartman, linux-usb, netdev, David S. Miller,
Marius Bjoernstad Kotsbak
In-Reply-To: <alpine.LNX.2.00.1107092304160.25516@swampdragon.chaosbits.net>
[-- Attachment #1: Type: TEXT/PLAIN, Size: 1973 bytes --]
Make sure that the 'static' keywork is at the beginning of declaration
for drivers/net/usb/kalmia.c
This gets rid of warnings like
warning: ‘static’ is not at beginning of declaration
when building with -Wold-style-declaration (and/or -Wextra which also
enables it).
Signed-off-by: Jesper Juhl <jj@chaosbits.net>
---
drivers/net/usb/kalmia.c | 12 ++++++------
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/net/usb/kalmia.c b/drivers/net/usb/kalmia.c
index a9b6c63..5a6d0f8 100644
--- a/drivers/net/usb/kalmia.c
+++ b/drivers/net/usb/kalmia.c
@@ -100,13 +100,13 @@ kalmia_send_init_packet(struct usbnet *dev, u8 *init_msg, u8 init_msg_len,
static int
kalmia_init_and_get_ethernet_addr(struct usbnet *dev, u8 *ethernet_addr)
{
- const static char init_msg_1[] =
+ static const char init_msg_1[] =
{ 0x57, 0x50, 0x04, 0x00, 0x00, 0x00, 0x00, 0x20, 0x00, 0x00,
0x00, 0x00 };
- const static char init_msg_2[] =
+ static const char init_msg_2[] =
{ 0x57, 0x50, 0x04, 0x00, 0x00, 0x00, 0x00, 0x02, 0x00, 0xf4,
0x00, 0x00 };
- const static int buflen = 28;
+ static const int buflen = 28;
char *usb_buf;
int status;
@@ -239,11 +239,11 @@ kalmia_rx_fixup(struct usbnet *dev, struct sk_buff *skb)
* Our task here is to strip off framing, leaving skb with one
* data frame for the usbnet framework code to process.
*/
- const static u8 HEADER_END_OF_USB_PACKET[] =
+ static const u8 HEADER_END_OF_USB_PACKET[] =
{ 0x57, 0x5a, 0x00, 0x00, 0x08, 0x00 };
- const static u8 EXPECTED_UNKNOWN_HEADER_1[] =
+ static const u8 EXPECTED_UNKNOWN_HEADER_1[] =
{ 0x57, 0x43, 0x1e, 0x00, 0x15, 0x02 };
- const static u8 EXPECTED_UNKNOWN_HEADER_2[] =
+ static const u8 EXPECTED_UNKNOWN_HEADER_2[] =
{ 0x57, 0x50, 0x0e, 0x00, 0x00, 0x00 };
int i = 0;
--
1.7.6
--
Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.
^ permalink raw reply related
* Re: [PATCH] natsemi: silence dma-debug warnings
From: Jim Cromie @ 2011-07-09 20:11 UTC (permalink / raw)
To: David Miller; +Cc: fujita.tomonori, thockin, netdev
In-Reply-To: <20110703.223448.458910310802724750.davem@davemloft.net>
[-- Attachment #1: Type: text/plain, Size: 641 bytes --]
On Sun, Jul 3, 2011 at 11:34 PM, David Miller <davem@davemloft.net> wrote:
> From: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
> Date: Mon, 4 Jul 2011 14:30:19 +0900
>
>> This silences dma-debug warnings:
>>
>> https://lkml.org/lkml/2011/6/30/341
> ...
>> Reported-by: Jim Cromie <jim.cromie@gmail.com>
>> Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
>> Tested-by: Jim Cromie <jim.cromie@gmail.com>
>
> Applied, thanks!
>
I have since seen a similar warning on shutdown,
heres a patch for it.
theres one other callsite, but I havent seen the warning from it,
will try to tickle it at some point.
[-- Attachment #2: 0001-natsemi-fix-another-dma-debug-report.patch --]
[-- Type: text/x-patch, Size: 3026 bytes --]
From 2d81b28645b22100271bdbe2d6859cb49a49166d Mon Sep 17 00:00:00 2001
From: Jim Cromie <jim.cromie@gmail.com>
Date: Sat, 9 Jul 2011 11:44:38 -0600
Subject: [PATCH 1/3] natsemi: fix another dma-debug report
commit 2fb83cd618be34546fb526a9051eceaa95517026
Author: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Date: Sun Jul 3 22:34:29 2011 -0700
Above commit fixed previously reported warning, but I later
noticed another one at shutdown. This commit fixes it.
Theres one other callsite to pci_unmap_single, but I havent seen
it report a problem, so havent included it here.
------------[ cut here ]------------
WARNING: at /home/jimc/projects/lx/linux-2.6/lib/dma-debug.c:820 check_unmap+0x1fe/0x56c()
natsemi 0000:00:06.0: DMA-API: device driver frees DMA memory with different size [device address=0x0000000007356840] [map size=1538 bytes] [unmap size=1522 bytes]
Modules linked in: bridge stp llc x_tables ipv6 pc87360 hwmon_vid scx200_hrt pc8736x_gpio scx200_gpio nsc_gpio scx200_acb i2c_core arc4 rtl8180 mac80211 eeprom_93cx6 cfg80211 pcspkr scx200 rfkill ide_gd_mod ide_pci_generic ohci_hcd usbcore sc1200 ide_core [last unloaded: ebtables]
Pid: 3996, comm: ifconfig Not tainted 3.0.0-rc6-skc-dyndbg+ #104
Call Trace:
[<c011ca97>] warn_slowpath_common+0x4a/0x5f
[<c0261ca5>] ? check_unmap+0x1fe/0x56c
[<c011cb10>] warn_slowpath_fmt+0x26/0x2a
[<c0261ca5>] check_unmap+0x1fe/0x56c
[<c0116505>] ? check_preempt_curr+0x5a/0x6a
[<c0262186>] debug_dma_unmap_page+0x53/0x5b
[<c02aaaf9>] pci_unmap_single+0x4d/0x57
[<c02aab51>] drain_rx+0x4e/0x74
[<c02acc6e>] netdev_close+0x103/0x1b8
[<c02f097e>] ? spin_unlock_bh.clone.30+0x12/0x14
[<c02f10aa>] ? dev_deactivate_many+0xc1/0xef
[<c02e05e9>] __dev_close_many+0x69/0x86
[<c02e0625>] __dev_close+0x1f/0x2c
[<c02e3200>] __dev_change_flags+0x92/0x107
[<c02e32db>] dev_change_flags+0x13/0x3f
[<c031e7ea>] devinet_ioctl+0x248/0x4b3
[<c02e3a9e>] ? dev_ioctl+0x50a/0x54c
[<c031f509>] inet_ioctl+0x8e/0xa7
[<c02d506f>] sock_ioctl+0x1b6/0x1da
[<c02d4eb9>] ? sock_fasync+0x61/0x61
[<c0183db4>] do_vfs_ioctl+0x44d/0x47f
[<c0113cdb>] ? do_page_fault+0x268/0x299
[<c01339d0>] ? __put_cred+0x34/0x36
[<c0177d83>] ? sys_faccessat+0x13e/0x14b
[<c0183e14>] sys_ioctl+0x2e/0x4a
[<c035bc95>] syscall_call+0x7/0xb
---[ end trace 7013a1bdac403e56 ]---
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
---
drivers/net/natsemi.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/natsemi.c b/drivers/net/natsemi.c
index 8f8b65a..e4bd202 100644
--- a/drivers/net/natsemi.c
+++ b/drivers/net/natsemi.c
@@ -2028,8 +2028,8 @@ static void drain_rx(struct net_device *dev)
np->rx_ring[i].cmd_status = 0;
np->rx_ring[i].addr = cpu_to_le32(0xBADF00D0); /* An invalid address. */
if (np->rx_skbuff[i]) {
- pci_unmap_single(np->pci_dev,
- np->rx_dma[i], buflen,
+ pci_unmap_single(np->pci_dev, np->rx_dma[i],
+ buflen + NATSEMI_PADDING,
PCI_DMA_FROMDEVICE);
dev_kfree_skb(np->rx_skbuff[i]);
}
--
1.7.4.1
^ permalink raw reply related
* Re: [PATCH 00/21] clean up rx_copybreak handling [split version]
From: Joe Perches @ 2011-07-09 18:20 UTC (permalink / raw)
To: Michał Mirosław
Cc: netdev, Steffen Klassert, Santiago Leon, Tim Hockin, Don Fry,
Francois Romieu, Ion Badulescu, Matt Carlson, Michael Chan,
Grant Grundler, David Dillow, Roger Luethi, David S. Miller
In-Reply-To: <cover.1310229312.git.mirq-linux@rere.qmqm.pl>
On Sat, 2011-07-09 at 19:17 +0200, Michał Mirosław wrote:
> Split version of rx_copybreak cleanup patch.
Hello Michał.
Looks good, thanks for doing this work.
One style quibble.
You use this style:
+ skb = dev_skb_finish_rx_dma(&np->rx_skbuff[entry],
+ pkt_len, rx_copybreak,
+ &np->pci_dev->dev,
+ le32_to_cpu(desc->frag[0].addr),
+ np->rx_buf_sz);
where almost all other uses throughout drivers/net
align arguments to open parenthesis instead.
+ skb = dev_skb_finish_rx_dma(&np->rx_skbuff[entry],
+ pkt_len, rx_copybreak,
+ &np->pci_dev->dev,
+ le32_to_cpu(desc->frag[0].addr),
+ np->rx_buf_sz);
^ permalink raw reply
* Re: [PATCH 18/21] net: typhoon: use common rx_copybreak handling
From: David Dillow @ 2011-07-09 17:46 UTC (permalink / raw)
To: Michał Mirosław; +Cc: netdev
In-Reply-To: <86c335595654802d096c5c6c79f5d3fb71d4bd22.1310229312.git.mirq-linux@rere.qmqm.pl>
On Sat, 2011-07-09 at 19:17 +0200, Michał Mirosław wrote:
> v2: fix inverted test on skb refill/reuse
>
> Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
> ---
> drivers/net/typhoon.c | 26 +++++++-------------------
Looks good,
Acked-by: David Dillow <dave@thedillows.org>
^ permalink raw reply
* [PATCH 21/21] net: yellowfin: use common rx_copybreak handling
From: Michał Mirosław @ 2011-07-09 17:17 UTC (permalink / raw)
To: netdev
In-Reply-To: <cover.1310229312.git.mirq-linux@rere.qmqm.pl>
Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
---
drivers/net/yellowfin.c | 27 ++++++---------------------
1 files changed, 6 insertions(+), 21 deletions(-)
diff --git a/drivers/net/yellowfin.c b/drivers/net/yellowfin.c
index 3e5ac60..e1aa4a6 100644
--- a/drivers/net/yellowfin.c
+++ b/drivers/net/yellowfin.c
@@ -1124,27 +1124,12 @@ static int yellowfin_rx(struct net_device *dev)
printk(KERN_DEBUG " %s() normal Rx pkt length %d of %d, bogus_cnt %d\n",
__func__, pkt_len, data_size, boguscnt);
#endif
- /* Check if the packet is long enough to just pass up the skbuff
- without copying to a properly sized skbuff. */
- if (pkt_len > rx_copybreak) {
- skb_put(skb = rx_skb, pkt_len);
- pci_unmap_single(yp->pci_dev,
- le32_to_cpu(yp->rx_ring[entry].addr),
- yp->rx_buf_sz,
- PCI_DMA_FROMDEVICE);
- yp->rx_skbuff[entry] = NULL;
- } else {
- skb = dev_alloc_skb(pkt_len + 2);
- if (skb == NULL)
- break;
- skb_reserve(skb, 2); /* 16 byte align the IP header */
- skb_copy_to_linear_data(skb, rx_skb->data, pkt_len);
- skb_put(skb, pkt_len);
- pci_dma_sync_single_for_device(yp->pci_dev,
- le32_to_cpu(desc->addr),
- yp->rx_buf_sz,
- PCI_DMA_FROMDEVICE);
- }
+ skb = dev_skb_finish_rx_dma(&yp->rx_skbuff[entry],
+ pkt_len, rx_copybreak,
+ &yp->pci_dev->dev,
+ le32_to_cpu(desc->addr),
+ yp->rx_buf_sz);
+
skb->protocol = eth_type_trans(skb, dev);
netif_rx(skb);
dev->stats.rx_packets++;
--
1.7.5.4
^ permalink raw reply related
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox