* Re: [PATCH] net: check the length of the data before dereferencing it
From: David Miller @ 2012-04-02 3:55 UTC (permalink / raw)
To: eric.dumazet; +Cc: xiaosuo, kaber, pablo, netfilter-devel, netdev
In-Reply-To: <1333338345.2325.6591.camel@edumazet-glaptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Mon, 02 Apr 2012 05:45:45 +0200
> Usually not a problem since we have many bytes after our head.
We always have bytes after the head, it's guarenteed, and whether it's
garbage bytes or skb_shared_info() it simply doesn't matter.
^ permalink raw reply
* Re: [PATCH] net: check the length of the data before dereferencing it
From: Eric Dumazet @ 2012-04-02 3:53 UTC (permalink / raw)
To: Changli Gao; +Cc: David Miller, kaber, pablo, netfilter-devel, netdev
In-Reply-To: <CABa6K_HfWckb=sv7oQatv2ZJm3EKJE0mutQQ-OiddXiR6E7eHg@mail.gmail.com>
On Mon, 2012-04-02 at 11:45 +0800, Changli Gao wrote:
> Thinking about a malformed tcp segment, which has no data but silly
> options, and whose last byte is neither TCPOPT_EOL or TCPOPT_NOP, we
> will try to dereference one byte over the boundary when parsing the
> options. I know we have skb_shared_info at the end and it won't cause
> any crash, but should we rely on this fact?
>
No we cant rely on this, kmemcheck might barf on us.
Your patch (and the netfilter one) is fine.
^ permalink raw reply
* Re: [PATCH] net: check the length of the data before dereferencing it
From: Eric Dumazet @ 2012-04-02 3:45 UTC (permalink / raw)
To: David Miller; +Cc: xiaosuo, kaber, pablo, netfilter-devel, netdev
In-Reply-To: <20120401.232942.1829187970291547571.davem@davemloft.net>
On Sun, 2012-04-01 at 23:29 -0400, David Miller wrote:
> From: Eric Dumazet <eric.dumazet@gmail.com>
> Date: Mon, 02 Apr 2012 05:19:33 +0200
>
> >> @@ -3845,6 +3845,8 @@ void tcp_parse_options(const struct sk_buff *skb, struct tcp_options_received *o
> >> length--;
> >> continue;
> >> default:
> >> + if (length < 2)
> >> + return;
> >> opsize = *ptr++;
> >> if (opsize < 2) /* "silly options" */
> >> return;
> >
> > Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
>
> Tag Eric, you're it.
>
> You ACK'd this patch, so you get to show how this is actually able
> to cause some kind of problem.
>
> I assert that this is adding a useless test, that doesn't fix any kind
> of possible crash or misbehavior. If length == 1 at the default:, the
> code will absolutely do the right thing.
>
> Prove me wrong.
No problem.
You can have NOP,NOP,NOP,EVIL-OPTION
initial length=4 (multiple of 4)
We can read 5 bytes, and access 'out of bound' memory.
Usually not a problem since we have many bytes after our head.
^ permalink raw reply
* Re: [PATCH] net: check the length of the data before dereferencing it
From: Changli Gao @ 2012-04-02 3:45 UTC (permalink / raw)
To: David Miller; +Cc: eric.dumazet, kaber, pablo, netfilter-devel, netdev
In-Reply-To: <20120401.232942.1829187970291547571.davem@davemloft.net>
On Mon, Apr 2, 2012 at 11:29 AM, David Miller <davem@davemloft.net> wrote:
>
> Tag Eric, you're it.
>
> You ACK'd this patch, so you get to show how this is actually able
> to cause some kind of problem.
>
> I assert that this is adding a useless test, that doesn't fix any kind
> of possible crash or misbehavior. If length == 1 at the default:, the
> code will absolutely do the right thing.
>
> Prove me wrong.
Thinking about a malformed tcp segment, which has no data but silly
options, and whose last byte is neither TCPOPT_EOL or TCPOPT_NOP, we
will try to dereference one byte over the boundary when parsing the
options. I know we have skb_shared_info at the end and it won't cause
any crash, but should we rely on this fact?
--
Regards,
Changli Gao(xiaosuo@gmail.com)
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* Re: [BUGFIX][PATCH 3/3] memcg/tcp: ignore tcp usage before accounting started
From: David Miller @ 2012-04-02 3:41 UTC (permalink / raw)
To: glommer; +Cc: kamezawa.hiroyu, netdev, akpm
In-Reply-To: <4F742983.1080402@parallels.com>
From: Glauber Costa <glommer@parallels.com>
Date: Thu, 29 Mar 2012 11:21:07 +0200
> On 03/29/2012 09:10 AM, KAMEZAWA Hiroyuki wrote:
>> tcp memcontrol starts accouting after res->limit is set. So, if a sockets
>> starts before setting res->limit, there are already used resource.
>> After setting res->limit, the resource (already used) will be uncharged and
>> make res_counter below 0 because they are not charged. This causes warning.
>>
>> This patch fixes that by adding res_counter_uncharge_nowarn().
>> (*) We cannot avoid this while we have 'account start' switch.
>>
>> Signed-off-by: KAMEZAWA Hiroyuki<kamezawa.hiroyu@jp.fujitsu.com>
>
> Fine by me.
>
> Acked-by: Glauber Costa <glommer@parallels.com>
I'm not applying patches that simply ignore accounting counter
underflows.
You must either:
1) Integrate the socket's existing usage when the limit is set.
2) Avoid accounting completely for a socket that started before
the limit was set.
No half-way solutions, please. Otherwise it is impossible to design
validations of the resource usage for a particular socket or group of
sockets, because they can always be potentially "wrong" and over the
limit. That's a design for a buggy system.
^ permalink raw reply
* Re: [PATCH] net: Report dev->promiscuity in netlink reports.
From: David Miller @ 2012-04-02 3:35 UTC (permalink / raw)
To: greearb; +Cc: netdev
In-Reply-To: <1333061490-4484-1-git-send-email-greearb@candelatech.com>
From: greearb@candelatech.com
Date: Thu, 29 Mar 2012 15:51:30 -0700
> From: Ben Greear <greearb@candelatech.com>
>
> The standard ways of probing a device's promiscuity
> (ifi_flags, for instance) does not report the actual
> state of the device. This patch adds dev->promiscuity
> to the netlink netdevice report so that users can know
> for certain if the device is acting PROMISC or not.
>
> Signed-off-by: Ben Greear <greearb@candelatech.com>
Ok, applied to net-next, thanks.
^ permalink raw reply
* Re: [PATCH] net: usb: cdc_eem: fix mtu
From: David Miller @ 2012-04-02 3:33 UTC (permalink / raw)
To: rabin; +Cc: oliver, linux-usb, netdev
In-Reply-To: <1333041315-4303-1-git-send-email-rabin@rab.in>
From: Rabin Vincent <rabin@rab.in>
Date: Thu, 29 Mar 2012 22:45:15 +0530
> Make CDC EEM recalculate the hard_mtu after adjusting the
> hard_header_len.
>
> Without this, usbnet adjusts the MTU down to 1494 bytes, and the host is
> unable to receive standard 1500-byte frames from the device.
>
> Tested with the Linux USB Ethernet gadget.
>
> Cc: Oliver Neukum <oliver@neukum.name>
> Signed-off-by: Rabin Vincent <rabin@rab.in>
Applied and queued up for -stable, thanks.
^ permalink raw reply
* Re: [PATCH net-next-2.6] net: remove unused icmp_ioctl() definition.
From: David Miller @ 2012-04-02 3:31 UTC (permalink / raw)
To: ramirose; +Cc: netdev
In-Reply-To: <CAHLOa7RZFQHLtsYE2VeS7Fmhcr+O9guEFYYVoGTPJQos48Eo1w@mail.gmail.com>
From: Rami Rosen <ramirose@gmail.com>
Date: Thu, 29 Mar 2012 20:49:01 +0200
> The patch removes unused icmp_ioctl() method definition in
> include/net/icmp.h.
>
> Signed-off-by: Rami Rosen <ramirose@gmail.com>
Applied.
^ permalink raw reply
* Re: [PATCH] net: check the length of the data before dereferencing it
From: David Miller @ 2012-04-02 3:29 UTC (permalink / raw)
To: eric.dumazet; +Cc: xiaosuo, kaber, pablo, netfilter-devel, netdev
In-Reply-To: <1333336773.2325.6531.camel@edumazet-glaptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Mon, 02 Apr 2012 05:19:33 +0200
>> @@ -3845,6 +3845,8 @@ void tcp_parse_options(const struct sk_buff *skb, struct tcp_options_received *o
>> length--;
>> continue;
>> default:
>> + if (length < 2)
>> + return;
>> opsize = *ptr++;
>> if (opsize < 2) /* "silly options" */
>> return;
>
> Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
Tag Eric, you're it.
You ACK'd this patch, so you get to show how this is actually able
to cause some kind of problem.
I assert that this is adding a useless test, that doesn't fix any kind
of possible crash or misbehavior. If length == 1 at the default:, the
code will absolutely do the right thing.
Prove me wrong.
^ permalink raw reply
* [PATCH] netfilter: don't scale the size of the window up twice
From: Changli Gao @ 2012-04-02 3:25 UTC (permalink / raw)
To: Pablo Neira Ayuso
Cc: Patrick McHardy, David S. Miller, netfilter-devel, netdev,
Changli Gao
For a picked up connection, the window win is scaled twice: one is by the
initialization code, and the other is by the sender updating code.
I use the temporary variable swin instead of modifying the variable win.
Signed-off-by: Changli Gao <xiaosuo@gmail.com>
---
net/netfilter/nf_conntrack_proto_tcp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/netfilter/nf_conntrack_proto_tcp.c b/net/netfilter/nf_conntrack_proto_tcp.c
index 361eade..0d07a1d 100644
--- a/net/netfilter/nf_conntrack_proto_tcp.c
+++ b/net/netfilter/nf_conntrack_proto_tcp.c
@@ -584,8 +584,8 @@ static bool tcp_in_window(const struct nf_conn *ct,
* Let's try to use the data from the packet.
*/
sender->td_end = end;
- win <<= sender->td_scale;
- sender->td_maxwin = (win == 0 ? 1 : win);
+ swin = win << sender->td_scale;
+ sender->td_maxwin = (swin == 0 ? 1 : swin);
sender->td_maxend = end + sender->td_maxwin;
/*
* We haven't seen traffic in the other direction yet
^ permalink raw reply related
* Re: [PATCH] net: sh_eth: fix endian check for architecture independent
From: David Miller @ 2012-04-02 3:22 UTC (permalink / raw)
To: yoshihiro.shimoda.uh; +Cc: netdev, linux-sh
In-Reply-To: <4F754558.1070001@renesas.com>
From: "Shimoda, Yoshihiro" <yoshihiro.shimoda.uh@renesas.com>
Date: Fri, 30 Mar 2012 14:32:08 +0900
> SuperH has the "CONFIG_CPU_LITTLE_ENDIAN" and the "__LITTLE_ENDIAN__".
> But, other architecture doesn't have them. So, this patch fixes it.
>
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Applied.
^ permalink raw reply
* Re: [PATCH] usb/rtl8150 : Remove duplicated definitions
From: David Miller @ 2012-04-02 3:20 UTC (permalink / raw)
To: huajun.li.lee; +Cc: petkan, netdev
In-Reply-To: <CA+v9cxYHCNTmPagMBMM6quco2EexCobZrF-bpvhKVP40OWjNhA@mail.gmail.com>
From: Huajun Li <huajun.li.lee@gmail.com>
Date: Fri, 30 Mar 2012 18:11:05 +0800
> There exist duplicated macro definitions in rtl8150.c, remove them.
>
> Signed-off-by: Huajun Li <huajun.li.lee@gmail.com>
Applied, thanks.
^ permalink raw reply
* Re: [PATCH] net: check the length of the data before dereferencing it
From: David Miller @ 2012-04-02 3:19 UTC (permalink / raw)
To: xiaosuo; +Cc: kaber, pablo, eric.dumazet, netfilter-devel, netdev
In-Reply-To: <1333336250-4110-1-git-send-email-xiaosuo@gmail.com>
From: Changli Gao <xiaosuo@gmail.com>
Date: Mon, 2 Apr 2012 11:10:50 +0800
> We should check the length of the data before dereferencing it when parsing
> the TCP options.
>
> Signed-off-by: Changli Gao <xiaosuo@gmail.com>
Proper Subject prefix here would be "tcp: ", not "net: "
and maybe adjust the subject line to also mention the
specific function being fixed, which in this case would
be tcp_parse_options(). So:
tcp: Validate length of data before dereference in tcp_parse_options().
and then you can make the commit message just be your signoff.
^ permalink raw reply
* Re: [PATCH] net: check the length of the data before dereferencing it
From: Eric Dumazet @ 2012-04-02 3:19 UTC (permalink / raw)
To: Changli Gao
Cc: David S. Miller, Patrick McHardy, Pablo Neira Ayuso,
netfilter-devel, netdev
In-Reply-To: <1333336250-4110-1-git-send-email-xiaosuo@gmail.com>
On Mon, 2012-04-02 at 11:10 +0800, Changli Gao wrote:
> We should check the length of the data before dereferencing it when parsing
> the TCP options.
>
> Signed-off-by: Changli Gao <xiaosuo@gmail.com>
> ---
> net/ipv4/tcp_input.c | 2 ++
> 1 file changed, 2 insertions(+)
> diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c
> index e886e2f..5099f08 100644
> --- a/net/ipv4/tcp_input.c
> +++ b/net/ipv4/tcp_input.c
> @@ -3845,6 +3845,8 @@ void tcp_parse_options(const struct sk_buff *skb, struct tcp_options_received *o
> length--;
> continue;
> default:
> + if (length < 2)
> + return;
> opsize = *ptr++;
> if (opsize < 2) /* "silly options" */
> return;
Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
^ permalink raw reply
* Re: [PATCH] rionet: fix page allocation order of rionet_active
From: David Miller @ 2012-04-02 3:17 UTC (permalink / raw)
To: akinobu.mita; +Cc: netdev, mporter, alexandre.bounine
In-Reply-To: <1333105306-2601-1-git-send-email-akinobu.mita@gmail.com>
From: Akinobu Mita <akinobu.mita@gmail.com>
Date: Fri, 30 Mar 2012 20:01:46 +0900
> rionet_active is allocated from the page allocator and the allocation
> order is calculated on the assumption that the page size is 4KB, so it
> wastes memory on more than 4K page systems.
>
> Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Applied, thanks.
^ permalink raw reply
* [PATCH] net: check the length of the data before dereferencing it
From: Changli Gao @ 2012-04-02 3:10 UTC (permalink / raw)
To: David S. Miller
Cc: Patrick McHardy, Pablo Neira Ayuso, Eric Dumazet, netfilter-devel,
netdev, Changli Gao
We should check the length of the data before dereferencing it when parsing
the TCP options.
Signed-off-by: Changli Gao <xiaosuo@gmail.com>
---
net/ipv4/tcp_input.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c
index e886e2f..5099f08 100644
--- a/net/ipv4/tcp_input.c
+++ b/net/ipv4/tcp_input.c
@@ -3845,6 +3845,8 @@ void tcp_parse_options(const struct sk_buff *skb, struct tcp_options_received *o
length--;
continue;
default:
+ if (length < 2)
+ return;
opsize = *ptr++;
if (opsize < 2) /* "silly options" */
return;
^ permalink raw reply related
* Re: [PATCH] via-rhine: fix wait-bit inversion.
From: David Miller @ 2012-04-02 3:10 UTC (permalink / raw)
To: romieu; +Cc: netdev, andi, DavidLv
In-Reply-To: <20120401223500.GA28138@electric-eye.fr.zoreil.com>
From: Francois Romieu <romieu@fr.zoreil.com>
Date: Mon, 2 Apr 2012 00:35:00 +0200
> From: Andreas Mohr <andi@lisas.de>
>
> Bug appeared in a384a33bb1c9ec2d99db2046b41f57023fa7d77b
> ("via-rhine: RHINE_WAIT_FOR macro removal). It can be noticed
> during suspend/resume.
>
> Signed-off-by: Andreas Mohr <andi@lisas.de>
> Acked-by: Francois Romieu <romieu@fr.zoreil.com>
> Cc: David Lv <DavidLv@viatech.com.cn>
Applied and queued up for -stable, thanks.
^ permalink raw reply
* Re: [PATCH 8/8] net/ipv6/addrconf.c: Checkpatch cleanups
From: David Miller @ 2012-04-02 3:07 UTC (permalink / raw)
To: eldad; +Cc: kuznet, jmorris, yoshfuji, kaber, netdev, linux-kernel
In-Reply-To: <1333302548-9187-8-git-send-email-eldad@fogrefinery.com>
From: Eldad Zack <eldad@fogrefinery.com>
Date: Sun, 1 Apr 2012 19:49:08 +0200
> net/ipv6/addrconf.c:340: WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
> net/ipv6/addrconf.c:342: ERROR: "foo * bar" should be "foo *bar"
> net/ipv6/addrconf.c:444: ERROR: "foo * bar" should be "foo *bar"
> net/ipv6/addrconf.c:1337: WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
> net/ipv6/addrconf.c:1526: ERROR: "(foo*)" should be "(foo *)"
> net/ipv6/addrconf.c:1671: ERROR: open brace '{' following function declarations go on the next line
> net/ipv6/addrconf.c:1914: ERROR: "foo * bar" should be "foo *bar"
> net/ipv6/addrconf.c:2368: ERROR: "foo * bar" should be "foo *bar"
> net/ipv6/addrconf.c:2370: ERROR: "foo * bar" should be "foo *bar"
> net/ipv6/addrconf.c:2416: ERROR: "foo * bar" should be "foo *bar"
> net/ipv6/addrconf.c:2437: ERROR: "foo * bar" should be "foo *bar"
> net/ipv6/addrconf.c:2573: ERROR: "foo * bar" should be "foo *bar"
> net/ipv6/addrconf.c:3797: ERROR: "foo* bar" should be "foo *bar"
>
> Signed-off-by: Eldad Zack <eldad@fogrefinery.com>
Applied.
^ permalink raw reply
* Re: [PATCH 7/8] net/ipv6/icmp.c: Checkpatch cleanups
From: David Miller @ 2012-04-02 3:07 UTC (permalink / raw)
To: eldad; +Cc: kuznet, jmorris, yoshfuji, kaber, netdev, linux-kernel
In-Reply-To: <1333302548-9187-7-git-send-email-eldad@fogrefinery.com>
From: Eldad Zack <eldad@fogrefinery.com>
Date: Sun, 1 Apr 2012 19:49:07 +0200
> icmp.c:501: ERROR: "(foo*)" should be "(foo *)"
> icmp.c:582: ERROR: "(foo*)" should be "(foo *)"
> icmp.c:954: WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
>
> Signed-off-by: Eldad Zack <eldad@fogrefinery.com>
Applied.
^ permalink raw reply
* Re: [PATCH 6/8] net/ipv6/fib6_rules.c: Checkpatch cleanup
From: David Miller @ 2012-04-02 3:07 UTC (permalink / raw)
To: eldad; +Cc: kuznet, jmorris, yoshfuji, kaber, netdev, linux-kernel
In-Reply-To: <1333302548-9187-6-git-send-email-eldad@fogrefinery.com>
From: Eldad Zack <eldad@fogrefinery.com>
Date: Sun, 1 Apr 2012 19:49:06 +0200
> fib6_rules.c:26: ERROR: open brace '{' following struct go on the same line
>
> Signed-off-by: Eldad Zack <eldad@fogrefinery.com>
Applied.
^ permalink raw reply
* Re: [PATCH 5/8] net/ipv6/exthdrs_core.c: Checkpatch cleanups
From: David Miller @ 2012-04-02 3:07 UTC (permalink / raw)
To: eldad; +Cc: kuznet, jmorris, yoshfuji, kaber, netdev, linux-kernel
In-Reply-To: <1333302548-9187-5-git-send-email-eldad@fogrefinery.com>
From: Eldad Zack <eldad@fogrefinery.com>
Date: Sun, 1 Apr 2012 19:49:05 +0200
> exthdrs_core.c:113: WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
> exthdrs_core.c:114: WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
>
> Signed-off-by: Eldad Zack <eldad@fogrefinery.com>
Applied.
^ permalink raw reply
* Re: [PATCH 4/8] net/ipv6/exthdrs.c: Checkpatch cleanups
From: David Miller @ 2012-04-02 3:07 UTC (permalink / raw)
To: eldad; +Cc: kuznet, jmorris, yoshfuji, kaber, netdev, linux-kernel
In-Reply-To: <1333302548-9187-4-git-send-email-eldad@fogrefinery.com>
From: Eldad Zack <eldad@fogrefinery.com>
Date: Sun, 1 Apr 2012 19:49:04 +0200
> exthdrs.c:726: WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
> exthdrs.c:741: ERROR: "(foo*)" should be "(foo *)"
> exthdrs.c:741: ERROR: "(foo*)" should be "(foo *)"
> exthdrs.c:744: ERROR: "(foo**)" should be "(foo **)"
> exthdrs.c:746: ERROR: "(foo**)" should be "(foo **)"
> exthdrs.c:748: ERROR: "(foo**)" should be "(foo **)"
> exthdrs.c:750: ERROR: "(foo**)" should be "(foo **)"
> exthdrs.c:755: WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
> exthdrs.c:896: WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
>
> Signed-off-by: Eldad Zack <eldad@fogrefinery.com>
Applied.
^ permalink raw reply
* Re: [PATCH 3/8] net/ipv6/datagram.c: Checkpatch cleanups
From: David Miller @ 2012-04-02 3:07 UTC (permalink / raw)
To: eldad; +Cc: kuznet, jmorris, yoshfuji, kaber, netdev, linux-kernel
In-Reply-To: <1333302548-9187-3-git-send-email-eldad@fogrefinery.com>
From: Eldad Zack <eldad@fogrefinery.com>
Date: Sun, 1 Apr 2012 19:49:03 +0200
> datagram.c:101: ERROR: "(foo*)" should be "(foo *)"
> datagram.c:521: ERROR: space required before the open parenthesis '('
> datagram.c:830: WARNING: braces {} are not necessary for single statement blocks
> datagram.c:849: WARNING: braces {} are not necessary for single statement blocks
>
> Signed-off-by: Eldad Zack <eldad@fogrefinery.com>
Applied.
^ permalink raw reply
* Re: [PATCH 2/8] net/ipv6/addrconf_core.c: Checkpatch cleanup
From: David Miller @ 2012-04-02 3:07 UTC (permalink / raw)
To: eldad; +Cc: kuznet, jmorris, yoshfuji, kaber, netdev, linux-kernel
In-Reply-To: <1333302548-9187-2-git-send-email-eldad@fogrefinery.com>
From: Eldad Zack <eldad@fogrefinery.com>
Date: Sun, 1 Apr 2012 19:49:02 +0200
> addrconf_core.c:13: ERROR: space required before the open parenthesis '('
>
> Signed-off-by: Eldad Zack <eldad@fogrefinery.com>
Applied.
^ permalink raw reply
* Re: [PATCH 1/8] net/ipv6/sit.c: Checkpatch cleanup
From: David Miller @ 2012-04-02 3:07 UTC (permalink / raw)
To: eldad; +Cc: kuznet, jmorris, yoshfuji, kaber, netdev, linux-kernel
In-Reply-To: <1333302548-9187-1-git-send-email-eldad@fogrefinery.com>
From: Eldad Zack <eldad@fogrefinery.com>
Date: Sun, 1 Apr 2012 19:49:01 +0200
> sit.c:118: ERROR: "foo * bar" should be "foo *bar"
> sit.c:694: ERROR: "(foo*)" should be "(foo *)"
> sit.c:724: ERROR: "(foo*)" should be "(foo *)"
>
> Signed-off-by: Eldad Zack <eldad@fogrefinery.com>
Applied.
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox