* Re: [PATCH] ipv6: fix RTPROT_RA markup of RA routes w/nexthops
From: David Miller @ 2012-07-17 5:56 UTC (permalink / raw)
To: infrastation; +Cc: netdev
In-Reply-To: <20120710184550.7a5a8d89802473b4c28d07bf@yandex.ru>
From: Denis Ovsienko <infrastation@yandex.ru>
Date: Tue, 10 Jul 2012 18:45:50 +0400
> From: Denis Ovsienko <infrastation@yandex.ru>
>
> Userspace implementations of network routing protocols sometimes need to
> tell RA-originated IPv6 routes from other kernel routes to make proper
> routing decisions. This makes most sense for RA routes with nexthops,
> namely, default routes and Route Information routes.
>
> The intended mean of preserving RA route origin in a netlink message is
> through indicating RTPROT_RA as protocol code. Function rt6_fill_node()
> tried to do that for default routes, but its test condition was taken
> wrong. This change is modeled after the original mailing list posting
> by Jeff Haran. It fixes the test condition for default route case and
> sets the same behaviour for Route Information case (both types use
> nexthops). Handling of the 3rd RA route type, Prefix Information, is
> left unchanged, as it stands for interface connected routes (without
> nexthops).
>
> Signed-off-by: Denis Ovsienko <infrastation@yandex.ru>
Applied to net-next, thanks.
^ permalink raw reply
* Re: [patch] net/mlx4: off by one in parse_trans_rule()
From: David Miller @ 2012-07-17 5:58 UTC (permalink / raw)
To: dan.carpenter
Cc: hadarh, ogerlitz, eugenia, yevgenyp, netdev, kernel-janitors
In-Reply-To: <20120711063336.GC11812@elgon.mountain>
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Wed, 11 Jul 2012 09:33:36 +0300
> This should be ">=" here instead of ">". MLX4_NET_TRANS_RULE_NUM is 6.
> We use "spec->id" as an array offset into the __rule_hw_sz[] and
> __sw_id_hw[] arrays which have 6 elements.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thanks.
Dan, in the future please indicate clearly that your patches are
targetted at net-next specifically. Thanks.
^ permalink raw reply
* Re: [patch] net/mlx4_en: dereferencing freed memory
From: David Miller @ 2012-07-17 5:58 UTC (permalink / raw)
To: dan.carpenter; +Cc: yevgenyp, amirv, ogerlitz, alexg, netdev, kernel-janitors
In-Reply-To: <20120711063407.GD11812@elgon.mountain>
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Wed, 11 Jul 2012 09:34:07 +0300
> We dereferenced "mclist" after the kfree().
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied.
^ permalink raw reply
* Re: [PATCH] bridge: Fix enforcement of multicast hash_max limit
From: David Miller @ 2012-07-17 5:59 UTC (permalink / raw)
To: tgraf; +Cc: netdev
In-Reply-To: <417e2d4ff99d88014f288e9924c5a45d4650f474.1341995313.git.tgraf@suug.ch>
From: Thomas Graf <tgraf@suug.ch>
Date: Wed, 11 Jul 2012 10:29:19 +0200
> The hash size is doubled when it needs to grow and compared against
> hash_max. The >= comparison will limit the hash table size to half
> of what is expected i.e. the default 512 hash_max will not allow
> the hash table to grow larger than 256.
>
> Also print the hash table limit instead of the desirable size when
> the limit is reached.
>
> Signed-off-by: Thomas Graf <tgraf@suug.ch>
Applied to net-next, thanks Thomas.
^ permalink raw reply
* Re: [PATCH v4] net: cgroup: fix access the unallocated memory in netprio cgroup
From: David Miller @ 2012-07-17 6:01 UTC (permalink / raw)
To: nhorman; +Cc: gaofeng, eric.dumazet, linux-kernel, netdev, edumazet
In-Reply-To: <20120712105611.GA7055@hmsreliant.think-freely.org>
From: Neil Horman <nhorman@tuxdriver.com>
Date: Thu, 12 Jul 2012 06:56:11 -0400
> On Thu, Jul 12, 2012 at 03:50:15PM +0800, Gao feng wrote:
>> there are some out of bound accesses in netprio cgroup.
...
>> Signed-off-by: Gao feng <gaofeng@cn.fujitsu.com>
>
> Acked-by: Neil Horman <nhorman@tuxdriver.com>
>
Applied to 'net', thanks.
^ permalink raw reply
* Re: [PATCH net-next 1/2] be2net: Add description about various RSS hash types
From: David Miller @ 2012-07-17 6:02 UTC (permalink / raw)
To: padmanabh.ratnakar; +Cc: netdev
In-Reply-To: <ecab14f7-24e9-4329-9d62-640086a29b52@exht1.ad.emulex.com>
From: Padmanabh Ratnakar <padmanabh.ratnakar@emulex.com>
Date: Fri, 13 Jul 2012 18:15:51 +0530
> Incorporated review comment from Eric Dumazet. Added description
> about different RSS hash types which adapter is capable of.
> Will add support for ETHTOOL_GRXFH and ETHTOOL_SRXFX as suggested
> by Ben Hutchings in a later patch.
>
> Signed-off-by: Padmanabh Ratnakar <padmanabh.ratnakar@emulex.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next 2/2] be2net: update driver version
From: David Miller @ 2012-07-17 6:02 UTC (permalink / raw)
To: padmanabh.ratnakar; +Cc: netdev
In-Reply-To: <e64dbbac-fcdd-4b7c-a37c-62ac4ab655b6@exht1.ad.emulex.com>
From: Padmanabh Ratnakar <padmanabh.ratnakar@emulex.com>
Date: Fri, 13 Jul 2012 18:16:03 +0530
>
> Signed-off-by: Padmanabh Ratnakar <padmanabh.ratnakar@emulex.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next] be2net: dont pull too much data in skb linear part
From: David Miller @ 2012-07-17 6:03 UTC (permalink / raw)
To: eric.dumazet; +Cc: padmanabh.ratnakar, netdev
In-Reply-To: <1342185581.3265.8355.camel@edumazet-glaptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Fri, 13 Jul 2012 15:19:41 +0200
> From: Eric Dumazet <edumazet@google.com>
>
> skb_fill_rx_data() pulls 64 byte of data in skb->data
>
> Its too much for TCP (with no options) on IPv4, as total size of headers
> is 14 + 40 = 54
>
> This means tcp stack and splice() are suboptimal, since tcp payload
> is in part in tcp->data, and in part in skb frag.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied.
^ permalink raw reply
* Re: [net-next 0/7][pull request] Intel Wired LAN Driver Updates
From: David Miller @ 2012-07-17 6:04 UTC (permalink / raw)
To: jeffrey.t.kirsher; +Cc: netdev, gospo, sassmann
In-Reply-To: <1342307225-28917-1-git-send-email-jeffrey.t.kirsher@intel.com>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Sat, 14 Jul 2012 16:06:58 -0700
> This series contains updates to e1000e and ixgbe.
>
> The following are changes since commit 141e369de698f2e17bf716b83fcc647ddcb2220c:
> xfrm: Initialize the struct xfrm_dst behind the dst_enty field
> and are available in the git repository at:
> git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/net-next master
>
> Alexander Duyck (5):
> ixgbe: Simplify logic for getting traffic class from user priority
> ixgbe: Cleanup unpacking code for DCB
> ixgbe: Populate the prio_tc_map in ixgbe_setup_tc
> ixgbe: Add function for obtaining FCoE TC based on FCoE user priority
> ixgbe: Merge FCoE set_num and cache_ring calls into RSS/DCB config
>
> Matthew Vick (1):
> e1000e: Program the correct register for ITR when using MSI-X.
>
> Tushar Dave (1):
> e1000e: Cleanup code logic in e1000_check_for_serdes_link_82571()
Pulled, thanks Jeff.
^ permalink raw reply
* Re: [PATCH net] caif: Fix access to freed pernet memory
From: David Miller @ 2012-07-17 6:06 UTC (permalink / raw)
To: sjur.brandeland; +Cc: netdev, ebiederm, sjurbren, dmitry.tarnyagin
In-Reply-To: <1342383014-5525-1-git-send-email-sjur.brandeland@stericsson.com>
From: sjur.brandeland@stericsson.com
Date: Sun, 15 Jul 2012 22:10:14 +0200
> Can you please queue up this bugfix as appropriate for -net and -stable?
Done.
^ permalink raw reply
* Re: [PATCH v2] b44: add 64 bit stats
From: David Miller @ 2012-07-17 6:08 UTC (permalink / raw)
To: kgroeneveld; +Cc: netdev
In-Reply-To: <CABF+-6W0B0wB7hAfSRh83aEb_XPqaJuzA1nKZJygdd9xw-rN1g@mail.gmail.com>
From: Kevin Groeneveld <kgroeneveld@gmail.com>
Date: Sun, 15 Jul 2012 14:00:28 -0400
> From: Kevin Groeneveld <kgroeneveld@gmail.com>
>
> Add support for 64 bit stats to Broadcom b44 ethernet driver.
>
> Signed-off-by: Kevin Groeneveld <kgroeneveld@gmail.com>
This patch was corrupted by your email client and is therefore
unusable.
^ permalink raw reply
* Re: [PATCH net-next] netem: refine early skb orphaning
From: David Miller @ 2012-07-17 6:08 UTC (permalink / raw)
To: shemminger; +Cc: eric.dumazet, netdev, hagen, msg, aterzis, ycheng
In-Reply-To: <20120714145333.2c441166@nehalam.linuxnetplumber.net>
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Sat, 14 Jul 2012 14:53:33 -0700
> On Sat, 14 Jul 2012 15:16:27 +0200
> Eric Dumazet <eric.dumazet@gmail.com> wrote:
>
>> From: Eric Dumazet <edumazet@google.com>
>>
>> netem does an early orphaning of skbs. Doing so breaks TCP Small Queue
>> or any mechanism relying on socket sk_wmem_alloc feedback.
>>
>> Ideally, we should perform this orphaning after the rate module and
>> before the delay module, to mimic what happens on a real link :
>>
>> skb orphaning is indeed normally done at TX completion, before the
>> transit on the link.
>>
>> +-------+ +--------+ +---------------+ +-----------------+
>> + Qdisc +---> Device +--> TX completion +--> links / hops +->
>> + + + xmit + + skb orphaning + + propagation +
>> +-------+ +--------+ +---------------+ +-----------------+
>> < rate limiting > < delay, drops, reorders >
>>
>> If netem is used without delay feature (drops, reorders, rate
>> limiting), then we should avoid early skb orphaning, to keep pressure
>> on sockets as long as packets are still in qdisc queue.
>>
>> Ideally, netem should be refactored to implement delay module
>> as the last stage. Current algorithm merges the two phases
>> (rate limiting + delay) so its not correct.
>>
>> Signed-off-by: Eric Dumazet <edumazet@google.com>
...
> Acked-by: Stephen Hemminger <shemminger@vyatta.com>
Applied, thanks.
^ permalink raw reply
* Re: [PATCH 0/4 v3 net-next] tg3: Add hwmon support
From: David Miller @ 2012-07-17 6:11 UTC (permalink / raw)
To: mchan; +Cc: netdev
In-Reply-To: <1342491842-29818-1-git-send-email-mchan@broadcom.com>
From: "Michael Chan" <mchan@broadcom.com>
Date: Mon, 16 Jul 2012 19:23:58 -0700
> David, I've removed the binary sysfs attribute and now use
> hwmon only. Please consider this patchset for net-next.
Applied, thanks Michael.
You might want to add some Kconfig logic so that it's easier
to get the hwmon stuff automatically when tg3 is selected.
^ permalink raw reply
* Re: [PATCH net-next] bnx2: Try to recover from PCI block reset
From: David Miller @ 2012-07-17 6:12 UTC (permalink / raw)
To: mchan; +Cc: netdev, nhorman
In-Reply-To: <1342484756-29615-1-git-send-email-mchan@broadcom.com>
From: "Michael Chan" <mchan@broadcom.com>
Date: Mon, 16 Jul 2012 17:25:56 -0700
> If the PCI block has reset, the memory enable bit will be reset and
> the device will not respond to MMIO access. bnx2_reset_task() currently
> will not recover when this happens. Add code to detect this condition
> and restore the PCI state. This scenario has been reported by some
> users.
>
> Signed-off-by: Michael Chan <mchan@broadcom.com>
Applied, thanks Michael.
^ permalink raw reply
* Re: [PATCH 2/7] net-tcp: Fast Open client - cookie cache
From: David Miller @ 2012-07-17 6:15 UTC (permalink / raw)
To: ycheng; +Cc: hkchu, edumazet, ncardwell, sivasankar, netdev
In-Reply-To: <1342473410-6265-3-git-send-email-ycheng@google.com>
From: Yuchung Cheng <ycheng@google.com>
Date: Mon, 16 Jul 2012 14:16:45 -0700
> The Fast Open cookie cache is used by a TCP Fast Open client to store
> remote servers' Fast Open cookies. It stores one Fast Open cookie
> per IP (v4 or v6) and by default 1024 cookies total. The size is
> tunable via /proc/sys/net/ipv4/tcp_fastopen_cookies. Setting it to 0
> will flush the cache.
>
> The inetpeer cache also caches remote peer's information but the
> in-active cache entries are recycled on the scale of minutes. Therefore
> a separate storage is required but the lookup is done via inetpeer.
> Each inetpeer entry holds a cookie cache entry pointer (if TFO is used
> on that IP). On cache write, the cookie cache entry is allocated and
> stored in a list for LRU replacement. A spinlock protects any R/W
> operation on the cookie cache entry and the list.
>
> Signed-off-by: Yuchung Cheng <ycheng@google.com>
I would store these in the new tcp metrics cache.
Any argument against doing so wrt. expiry is bogus, because you can
implement whatever time limit you want using a jiffies based
expiration value.
^ permalink raw reply
* Re: [PATCH 1/7] net-tcp: Fast Open base
From: David Miller @ 2012-07-17 6:16 UTC (permalink / raw)
To: ycheng; +Cc: hkchu, edumazet, ncardwell, sivasankar, netdev
In-Reply-To: <1342473410-6265-2-git-send-email-ycheng@google.com>
From: Yuchung Cheng <ycheng@google.com>
Date: Mon, 16 Jul 2012 14:16:44 -0700
> +#define TCPOPT_EXP 254 /* Experimental */
> +/* Magic number to be after the option value for sharing TCP
> + * experimental options. See draft-ietf-tcpm-experimental-options-00.txt
> + */
> +#define TCPOPT_FASTOPEN_MAGIC 0xF989
If I apply this, we're stuck supporting this experimental number
forever.
Because somewhere, someone will have a kernel running using this
number, so we have to support this option value as well as whatever
the official one is.
Therefore I think the only logical thing we can do is only deploy
this once an official option number is choosen.
^ permalink raw reply
* Re: [net 0/2][pull request] Intel Wired LAN Driver Updates
From: David Miller @ 2012-07-17 6:20 UTC (permalink / raw)
To: jeffrey.t.kirsher; +Cc: netdev, gospo, sassmann
In-Reply-To: <1342252063-27023-1-git-send-email-jeffrey.t.kirsher@intel.com>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Sat, 14 Jul 2012 00:47:41 -0700
> This series contains fixes to e1000e.
>
> The following are changes since commit 7ac2908e4b2edaec60e9090ddb4d9ceb76c05e7d:
> sch_sfb: Fix missing NULL check
> and are available in the git repository at:
> git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/net master
>
> Bruce Allan (1):
> e1000e: fix test for PHY being accessible on 82577/8/9 and I217
>
> Tushar Dave (1):
> e1000e: Correct link check logic for 82571 serdes
Pulled, thanks Jeff.
^ permalink raw reply
* Re: [PATCH] MAINTAINERS: reflect actual changes in IEEE 802.15.4 maintainership
From: David Miller @ 2012-07-17 6:20 UTC (permalink / raw)
To: dbaryshkov; +Cc: linux-kernel, netdev, alex.bluesman.smirnov
In-Reply-To: <1342246534-22562-1-git-send-email-dbaryshkov@gmail.com>
From: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
Date: Sat, 14 Jul 2012 10:15:34 +0400
> As the life flows, developers priorities shifts a bit. Reflect actual
> changes in the maintainership of IEEE 802.15.4 code: Sergey mostly
> stopped cared about this piece of code. Most of the work recently was
> done by Alexander, so put him to the MAINTAINERS file to reflect his
> status and to ease the life of respective patches.
>
> Also add new net/mac802154/ directory to the list of maintained files.
>
> Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
> Cc: Alexander Smirnov <alex.bluesman.smirnov@gmail.com>
Applied, thanks.
^ permalink raw reply
* Re: [PATCH] ax25: Fix missing break
From: David Miller @ 2012-07-17 6:22 UTC (permalink / raw)
To: alan; +Cc: netdev, ralf
In-Reply-To: <20120713163247.22674.82793.stgit@localhost.localdomain>
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
Date: Fri, 13 Jul 2012 17:33:08 +0100
> From: Alan Cox <alan@linux.intel.com>
>
> At least there seems to be no reason to disallow ROSE sockets when
> NETROM is loaded.
>
> Signed-off-by: Alan Cox <alan@linux.intel.com>
Applied, thanks Alan.
^ permalink raw reply
* Re: [PATCH] sctp: fix sparse warning for sctp_init_cause_fixed
From: David Miller @ 2012-07-17 6:24 UTC (permalink / raw)
To: ioanorghici; +Cc: vyasevich, sri, netdev
In-Reply-To: <1342199797-11305-1-git-send-email-ioanorghici@gmail.com>
From: Ioan Orghici <ioanorghici@gmail.com>
Date: Fri, 13 Jul 2012 20:16:37 +0300
> Fix the following sparse warning:
> * symbol 'sctp_init_cause_fixed' was not declared. Should it be
> static?
>
> Signed-off-by: Ioan Orghici <ioanorghici@gmail.com>
Applied.
^ permalink raw reply
* Re: [PATCH] irda: Fix typo in irda
From: David Miller @ 2012-07-17 6:24 UTC (permalink / raw)
To: standby24x7; +Cc: netdev, samuel, linux-kernel, trivial
In-Reply-To: <1342200167-14934-1-git-send-email-standby24x7@gmail.com>
From: Masanari Iida <standby24x7@gmail.com>
Date: Sat, 14 Jul 2012 02:22:47 +0900
> Correct spelling typo in irda.
>
> Signed-off-by: Masanari Iida <standby24x7@gmail.com>
Applied.
^ permalink raw reply
* Re: [PATCH] drivers: connector: fixed coding style issues
From: David Miller @ 2012-07-17 6:24 UTC (permalink / raw)
To: joe; +Cc: valentin.ilie, zbr, netdev
In-Reply-To: <1342298026.8377.33.camel@joe2Laptop>
I applied v2 of this patch, thanks.
^ permalink raw reply
* Re: [PATCH] gigaset: silence GCC warning for unused 'format_ie'
From: David Miller @ 2012-07-17 6:24 UTC (permalink / raw)
To: pebolle; +Cc: tilman, hjlipp, isdn, gigaset307x-common, netdev, linux-kernel
In-Reply-To: <1342343515.1780.2.camel@x61.thuisdomein>
From: Paul Bolle <pebolle@tiscali.nl>
Date: Sun, 15 Jul 2012 11:11:55 +0200
> Building Gigaset's CAPI support without Gigaset's debugging enabled
> triggers this GCC warning:
> 'format_ie' defined but not used [-Wunused-function]
>
> Silence this warning by wrapping format_ie() in an "#ifdef
> CONFIG_GIGASET_DEBUG" and "#endif" pair.
>
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
Applied.
^ permalink raw reply
* Re: [PATCH v3 0/3] Add a driver for the ASIX AX88172A with phylib support
From: David Miller @ 2012-07-17 6:26 UTC (permalink / raw)
To: christian.riesch
Cc: netdev, oneukum, edumazet, allan, kernel, grundler, bhutchings,
joe, michael
In-Reply-To: <1342193191-18822-1-git-send-email-christian.riesch@omicron.at>
From: Christian Riesch <christian.riesch@omicron.at>
Date: Fri, 13 Jul 2012 17:26:28 +0200
> this is v3 of my patchset that adds a driver for the ASIX AX88172A USB 2.0
> to 10/100M Fast Ethernet Controller.
All applied, thanks.
^ permalink raw reply
* Re: [BUG] tg3: frequent freezes
From: Michael Chan @ 2012-07-17 6:56 UTC (permalink / raw)
To: Eric Dumazet; +Cc: netdev
In-Reply-To: <1342503329.2626.30.camel@edumazet-glaptop>
On Tue, 2012-07-17 at 07:35 +0200, Eric Dumazet wrote:
> [ 266.248330] tg3 0000:09:00.0: eth0: 0x00004800: 0x080303fe,
> 0x00000010, 0x00000000, 0x00000020
RDMAC_STATUS (0x4804) is showing 0x10 which is parity error.
>[ 266.247878] tg3 0000:09:00.0: eth0: 0x00000000: 0x167314e4,
>0x40100506, 0x02000002, 0x00000010
PCI Status (0x06) is also showing SERR (0x4000)
Assuming your chip is not a bad chip, I'll have to look around for a
5755M and see if I can duplicate the problem.
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox