* Re: [PATCH 3/4] net_sched: gred: fix qave reporting via netlink
From: Jamal Hadi Salim @ 2012-09-13 18:01 UTC (permalink / raw)
To: David Ward; +Cc: netdev, Bruce Osler, Cyril Chemparathy
In-Reply-To: <1347549755-19438-3-git-send-email-david.ward@ll.mit.edu>
On 12-09-13 11:22 AM, David Ward wrote:
> q->vars.qavg is a Wlog scaled value, but q->backlog is not. In order
> to pass q->vars.qavg as the backlog value, we need to un-scale it.
> Additionally, the qave value returned via netlink should not be Wlog
> scaled, so we need to un-scale the result of red_calc_qavg().
>
> This caused artificially high values for "Average Queue" to be shown
> by 'tc -s -d qdisc', but did not affect the actual operation of GRED.
>
> Signed-off-by: David Ward <david.ward@ll.mit.edu>
Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>
^ permalink raw reply
* Re: [PATCH 4/4] net_sched: gred: actually perform idling in WRED mode
From: Jamal Hadi Salim @ 2012-09-13 18:08 UTC (permalink / raw)
To: David Ward; +Cc: netdev, Bruce Osler, Cyril Chemparathy
In-Reply-To: <1347549755-19438-4-git-send-email-david.ward@ll.mit.edu>
On 12-09-13 11:22 AM, David Ward wrote:
> gred_dequeue() and gred_drop() do not seem to get called when the
> queue is empty, meaning that we never start idling while in WRED
> mode. And since qidlestart is not stored by gred_store_wred_set(),
> we would never stop idling while in WRED mode if we ever started.
> This messes up the average queue size calculation that influences
> packet marking/dropping behavior.
>
> Now, we start WRED mode idling as we are removing the last packet
> from the queue. Also we now actually stop WRED mode idling when we
> are enqueuing a packet.
>
> Cc: Bruce Osler <brosler@cisco.com>
> Signed-off-by: David Ward <david.ward@ll.mit.edu>
This is one is not so obvious. Iam assuming you vetted it via some tests.
In which case:
Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>
cheers,
jamal
^ permalink raw reply
* Re: [PATCH] Xen backend support for paged out grant targets.
From: Ian Campbell @ 2012-09-13 18:11 UTC (permalink / raw)
To: Andres Lagar-Cavilla
Cc: xen-devel@xen.lists.org, Konrad Rzeszutek Wilk, David Vrabel,
David Miller, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
In-Reply-To: <1347557306-25453-1-git-send-email-andres@lagarcavilla.org>
On Thu, 2012-09-13 at 18:28 +0100, Andres Lagar-Cavilla wrote:
>
> * Add placeholder in array of grant table error descriptions for
> unrelated error code we jump over.
Why not just define it, it's listed here:
http://xenbits.xen.org/docs/unstable/hypercall/include,public,grant_table.h.html#Enum_grant_status
I notice the specific wording of the error msg is different here too.
It'd probably be best to use the same wording as the Xen definition, so
all OSes end up with the same name for the same condition (else bug
reports will be confusing).
Ian.
^ permalink raw reply
* Re: [PATCH v4 0/8] cgroup: Assign subsystem IDs during compile time
From: Tejun Heo @ 2012-09-13 18:13 UTC (permalink / raw)
To: Daniel Wagner
Cc: netdev, cgroups, Daniel Wagner, David S. Miller, Paul E. McKenney,
Andrew Morton, Eric Dumazet, Gao feng, Glauber Costa, Herbert Xu,
Jamal Hadi Salim, John Fastabend, Kamezawa Hiroyuki, Li Zefan,
Neil Horman
In-Reply-To: <1347459128-32236-1-git-send-email-wagi@monom.org>
On Wed, Sep 12, 2012 at 04:12:00PM +0200, Daniel Wagner wrote:
> I've removed the useless test in patch #4 and updated the commit message
> on patch #7.
>
> While rewriting the commit message #7 I realized the pointer check was
> completely wrong. Instead testing the return value of
> task_subsys_state() I tested the pointer return by container_of. For
> more details on this see the commit message.
>
> Because of this I added Herbert and Paul to the Cc list. Please have
> close look at my rambling on the RCU part in patch #7. Thanks a lot!
>
> This series is against
>
> git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git for-3.7
Applied to cgroup/for-3.7.
Thanks!
--
tejun
^ permalink raw reply
* Re: [PATCH 0/4] netfilter updates for 3.6-rc5
From: David Miller @ 2012-09-13 18:25 UTC (permalink / raw)
To: pablo; +Cc: netfilter-devel, netdev
In-Reply-To: <1347533648-3451-1-git-send-email-pablo@netfilter.org>
From: pablo@netfilter.org
Date: Thu, 13 Sep 2012 12:54:04 +0200
> The following patchset contains four updates for your net tree, they are:
>
> * Fix crash on timewait sockets, since the TCP early demux was added,
> in nfnetlink_log, from Eric Dumazet.
>
> * Fix broken syslog log-level for xt_LOG and ebt_log since printk format was
> converted from <.> to a 2 bytes pattern using ASCII SOH, from Joe Perches.
>
> * Two security fixes for the TCP connection tracking targeting off-path attacks,
> from Jozsef Kadlecsik. The problem was discovered by Jan Wrobel and it is
> documented in: http://mixedbit.org/reflection_scan/reflection_scan.pdf.
>
> You can pull these changes from:
>
> git://1984.lsi.us.es/nf master
Pulled, thanks Pablo.
^ permalink raw reply
* Re: [PATCH 0/5] Netfilter updates for net-next
From: David Miller @ 2012-09-13 18:26 UTC (permalink / raw)
To: pablo; +Cc: netfilter-devel, netdev
In-Reply-To: <1347534092-3579-1-git-send-email-pablo@netfilter.org>
From: pablo@netfilter.org
Date: Thu, 13 Sep 2012 13:01:27 +0200
> The following patchset contains four Netfilter updates, mostly targeting
> to fix issues added with IPv6 NAT, and one little IPVS update for net-next:
>
> * Remove unneeded conditional free of skb in nfnetlink_queue, from
> Wei Yongjun.
>
> * One semantic path from coccinelle detected the use of list_del +
> INIT_LIST_HEAD, instead of list_del_init, again from Wei Yongjun.
>
> * Fix out-of-bound memory access in the NAT address selection, from
> Florian Westphal. This was introduced with the IPv6 NAT patches.
>
> * Two fixes for crashes that were introduced in the recently merged
> IPv6 NAT support, from myself.
>
> You can pull these changes from:
>
> git://1984.lsi.us.es/nf-next master
Also pulled, thanks a lot.
^ permalink raw reply
* Re: [PATCH] mISDN: Fix wrong usage of flush_work_sync while holding locks
From: David Miller @ 2012-09-13 18:59 UTC (permalink / raw)
To: keil; +Cc: netdev, stable
In-Reply-To: <1347546980-15923-1-git-send-email-keil@b1-systems.de>
From: Karsten Keil <keil@b1-systems.de>
Date: Thu, 13 Sep 2012 16:36:20 +0200
> It is a bad idea to hold a spinlock and call flush_work_sync.
> Move the workqueue cleanup outside the spinlock and use cancel_work_sync,
> on closing the channel this seems to be the more correct function.
> Remove the never used and constant return value of mISDN_freebchannel.
>
> Signed-off-by: Karsten Keil <keil@b1-systems.de>
> Cc: <stable@kernel.org>
Applied, thanks.
^ permalink raw reply
* Re: [net-next PATCH 0/3] bnx2x: Link flap avoidance added
From: David Miller @ 2012-09-13 19:01 UTC (permalink / raw)
To: yuvalmin; +Cc: netdev, eilong, ariele
In-Reply-To: <1347540981-16198-1-git-send-email-yuvalmin@broadcom.com>
From: "Yuval Mintz" <yuvalmin@broadcom.com>
Date: Thu, 13 Sep 2012 15:56:18 +0300
> In various flows in the bnx2x driver, the link is toggled unnecessarily -
> In such flows, if the link is already up it would be pulled down than
> raised up again, even if no change in the link was requested by the
> user.
>
> This patch series tries to eliminate this problem, or at least to greatly
> reduce the number of cases that would actually cause such a scenario to
> happen.
>
> Please consider applying this patch series to 'net-next'.
All applied, thanks.
^ permalink raw reply
* Re: [PATCH] mISDN: Fix wrong usage of flush_work_sync while holding locks
From: David Miller @ 2012-09-13 19:06 UTC (permalink / raw)
To: keil; +Cc: netdev, stable
In-Reply-To: <20120913.145937.235693485700301637.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Thu, 13 Sep 2012 14:59:37 -0400 (EDT)
> From: Karsten Keil <keil@b1-systems.de>
> Date: Thu, 13 Sep 2012 16:36:20 +0200
>
>> It is a bad idea to hold a spinlock and call flush_work_sync.
>> Move the workqueue cleanup outside the spinlock and use cancel_work_sync,
>> on closing the channel this seems to be the more correct function.
>> Remove the never used and constant return value of mISDN_freebchannel.
>>
>> Signed-off-by: Karsten Keil <keil@b1-systems.de>
>> Cc: <stable@kernel.org>
>
> Applied, thanks.
BTW, about -stable:
1) Even if it were appropriate to submit this directly to -stable,
stable@kernel.org is not the correct email address and you must
have seen the bounce produced by trying to send email there.
Rather, stable@vger.kernel.org is the correct address.
2) I queue up and submit networking bug fixes for -stable myself so
you should not submit them directly but rather make a request that
I add your patch to my networking -stable queue.
Thanks.
^ permalink raw reply
* Re: [PATCH 4/4] net_sched: gred: actually perform idling in WRED mode
From: Ward, David - 0663 - MITLL @ 2012-09-13 19:38 UTC (permalink / raw)
To: Jamal Hadi Salim; +Cc: netdev@vger.kernel.org, Bruce Osler, Cyril Chemparathy
In-Reply-To: <50522106.40404@mojatatu.com>
[-- Attachment #1: Type: text/plain, Size: 1237 bytes --]
On 13/09/12 14:08, Jamal Hadi Salim wrote:
> On 12-09-13 11:22 AM, David Ward wrote:
>> gred_dequeue() and gred_drop() do not seem to get called when the
>> queue is empty, meaning that we never start idling while in WRED
>> mode. And since qidlestart is not stored by gred_store_wred_set(),
>> we would never stop idling while in WRED mode if we ever started.
>> This messes up the average queue size calculation that influences
>> packet marking/dropping behavior.
>>
>> Now, we start WRED mode idling as we are removing the last packet
>> from the queue. Also we now actually stop WRED mode idling when we
>> are enqueuing a packet.
>>
>> Cc: Bruce Osler <brosler@cisco.com>
>> Signed-off-by: David Ward <david.ward@ll.mit.edu>
> This is one is not so obvious. Iam assuming you vetted it via some tests.
> In which case:
> Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>
>
> cheers,
> jamal
>
Before applying this patch, the average queue size (as seen with "tc -s
qdisc") remained constant forever after I stopped sending any packets
through the interface -- it didn't taper off as you would expect. After
the patch, the average queue size will now taper off if packets are not
being sent.
David
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4571 bytes --]
^ permalink raw reply
* Re: [PATCH] Xen backend support for paged out grant targets.
From: Andres Lagar-Cavilla @ 2012-09-13 19:45 UTC (permalink / raw)
To: Ian Campbell
Cc: Andres Lagar-Cavilla, xen-devel@xen.lists.org,
Konrad Rzeszutek Wilk, David Vrabel, David Miller,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
In-Reply-To: <1347559899.25803.64.camel@dagon.hellion.org.uk>
On Sep 13, 2012, at 2:11 PM, Ian Campbell wrote:
> On Thu, 2012-09-13 at 18:28 +0100, Andres Lagar-Cavilla wrote:
>>
>> * Add placeholder in array of grant table error descriptions for
>> unrelated error code we jump over.
>
> Why not just define it, it's listed here:
> http://xenbits.xen.org/docs/unstable/hypercall/include,public,grant_table.h.html#Enum_grant_status
Well, a) we'd be defining something no one will be using (for the moment) b) I would be signing-off on something unrelated.
>
> I notice the specific wording of the error msg is different here too.
That should not be, I'll re-spin the patch.
Thanks
Andres
> It'd probably be best to use the same wording as the Xen definition, so
> all OSes end up with the same name for the same condition (else bug
> reports will be confusing).
>
> Ian.
>
^ permalink raw reply
* Re: [PATCH] mISDN: Fix wrong usage of flush_work_sync while holding locks
From: Karsten Keil @ 2012-09-13 19:50 UTC (permalink / raw)
To: David Miller; +Cc: keil, netdev
In-Reply-To: <20120913.150659.17331564270446673.davem@davemloft.net>
Am 13.09.2012 21:06, schrieb David Miller:
> From: David Miller <davem@davemloft.net>
> Date: Thu, 13 Sep 2012 14:59:37 -0400 (EDT)
>
>> From: Karsten Keil <keil@b1-systems.de>
>> Date: Thu, 13 Sep 2012 16:36:20 +0200
>>
>>> It is a bad idea to hold a spinlock and call flush_work_sync.
>>> Move the workqueue cleanup outside the spinlock and use cancel_work_sync,
>>> on closing the channel this seems to be the more correct function.
>>> Remove the never used and constant return value of mISDN_freebchannel.
>>>
>>> Signed-off-by: Karsten Keil <keil@b1-systems.de>
>>> Cc: <stable@kernel.org>
>>
>> Applied, thanks.
>
> BTW, about -stable:
>
> 1) Even if it were appropriate to submit this directly to -stable,
> stable@kernel.org is not the correct email address and you must
> have seen the bounce produced by trying to send email there.
>
> Rather, stable@vger.kernel.org is the correct address.
>
> 2) I queue up and submit networking bug fixes for -stable myself so
> you should not submit them directly but rather make a request that
> I add your patch to my networking -stable queue.
>
OK, then I will put something like, "Should be considered for stable
too" in the comment and do not add the CC: stable@vger.kernel.org
for the next time.
Thanks.
^ permalink raw reply
* Re: [PATCH 1/4] net_sched: gred: correct comment about qavg calculation in RIO mode
From: David Miller @ 2012-09-13 20:10 UTC (permalink / raw)
To: jhs; +Cc: david.ward, netdev, brosler, cyril
In-Reply-To: <50521EFC.90701@mojatatu.com>
From: Jamal Hadi Salim <jhs@mojatatu.com>
Date: Thu, 13 Sep 2012 13:59:24 -0400
> On 12-09-13 11:22 AM, David Ward wrote:
>> Signed-off-by: David Ward <david.ward@ll.mit.edu>
>
> Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>
Applied.
^ permalink raw reply
* Re: [PATCH 2/4] net_sched: gred: eliminate redundant DP prio comparisons
From: David Miller @ 2012-09-13 20:10 UTC (permalink / raw)
To: jhs; +Cc: david.ward, netdev, brosler, cyril
In-Reply-To: <50521F3E.7010101@mojatatu.com>
From: Jamal Hadi Salim <jhs@mojatatu.com>
Date: Thu, 13 Sep 2012 14:00:30 -0400
> On 12-09-13 11:22 AM, David Ward wrote:
>> Each pair of DPs only needs to be compared once when searching for
>> a non-unique prio value.
>>
>> Signed-off-by: David Ward <david.ward@ll.mit.edu>
>
> Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>
Applied.
^ permalink raw reply
* Re: [PATCH 3/4] net_sched: gred: fix qave reporting via netlink
From: David Miller @ 2012-09-13 20:10 UTC (permalink / raw)
To: jhs; +Cc: david.ward, netdev, brosler, cyril
In-Reply-To: <50521F97.20503@mojatatu.com>
From: Jamal Hadi Salim <jhs@mojatatu.com>
Date: Thu, 13 Sep 2012 14:01:59 -0400
> On 12-09-13 11:22 AM, David Ward wrote:
>> q->vars.qavg is a Wlog scaled value, but q->backlog is not. In order
>> to pass q->vars.qavg as the backlog value, we need to un-scale it.
>> Additionally, the qave value returned via netlink should not be Wlog
>> scaled, so we need to un-scale the result of red_calc_qavg().
>>
>> This caused artificially high values for "Average Queue" to be shown
>> by 'tc -s -d qdisc', but did not affect the actual operation of GRED.
>>
>> Signed-off-by: David Ward <david.ward@ll.mit.edu>
>
> Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>
Applied.
^ permalink raw reply
* Re: [PATCH 4/4] net_sched: gred: actually perform idling in WRED mode
From: David Miller @ 2012-09-13 20:10 UTC (permalink / raw)
To: david.ward; +Cc: jhs, netdev, brosler, cyril
In-Reply-To: <50523632.60703@ll.mit.edu>
From: "Ward, David - 0663 - MITLL" <david.ward@ll.mit.edu>
Date: Thu, 13 Sep 2012 15:38:26 -0400
> On 13/09/12 14:08, Jamal Hadi Salim wrote:
>> On 12-09-13 11:22 AM, David Ward wrote:
>>> gred_dequeue() and gred_drop() do not seem to get called when the
>>> queue is empty, meaning that we never start idling while in WRED
>>> mode. And since qidlestart is not stored by gred_store_wred_set(),
>>> we would never stop idling while in WRED mode if we ever started.
>>> This messes up the average queue size calculation that influences
>>> packet marking/dropping behavior.
>>>
>>> Now, we start WRED mode idling as we are removing the last packet
>>> from the queue. Also we now actually stop WRED mode idling when we
>>> are enqueuing a packet.
>>>
>>> Cc: Bruce Osler <brosler@cisco.com>
>>> Signed-off-by: David Ward <david.ward@ll.mit.edu>
>> This is one is not so obvious. Iam assuming you vetted it via some
>> tests.
>> In which case:
>> Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>
>>
>> cheers,
>> jamal
>>
>
> Before applying this patch, the average queue size (as seen with "tc
> -s qdisc") remained constant forever after I stopped sending any
> packets through the interface -- it didn't taper off as you would
> expect. After the patch, the average queue size will now taper off if
> packets are not being sent.
Applied.
^ permalink raw reply
* Re: [PATCH net v2] net: qmi_wwan: call subdriver with control intf only
From: David Miller @ 2012-09-13 20:12 UTC (permalink / raw)
To: bjorn; +Cc: netdev, linux-usb
In-Reply-To: <1347518675-8427-1-git-send-email-bjorn@mork.no>
From: Bjørn Mork <bjorn@mork.no>
Date: Thu, 13 Sep 2012 08:44:35 +0200
> This fixes a hang on suspend due to calling wdm_suspend on
> the unregistered data interface. The hang should have been
> a NULL pointer reference had it not been for a logic error
> in the cdc_wdm code.
>
> commit 230718bd net: qmi_wwan: bind to both control and data interface
>
> changed qmi_wwan to use cdc_wdm as a subdriver for devices with
> a two-interface QMI/wwan function. The commit failed to update
> qmi_wwan_suspend and qmi_wwan_resume, which were written to handle
> either a single combined interface function, or no subdriver at all.
>
> The result was that we called into the subdriver both when the
> control interface was suspended and when the data interface was
> suspended. Calling the subdriver suspend function with an
> unregistered interface is not supported and will make the
> subdriver bug out.
>
> Signed-off-by: Bjørn Mork <bjorn@mork.no>
Applied, thanks.
^ permalink raw reply
* Re: [net PATCH v2 1/7] bnx2x: Avoid sending multiple statistics queries
From: David Miller @ 2012-09-13 20:17 UTC (permalink / raw)
To: yuvalmin; +Cc: netdev, dmitry, eilong
In-Reply-To: <1347374054-16730-2-git-send-email-yuvalmin@broadcom.com>
From: "Yuval Mintz" <yuvalmin@broadcom.com>
Date: Tue, 11 Sep 2012 17:34:08 +0300
> From: Dmitry Kravkov <dmitry@broadcom.com>
>
> During traffic when DCB is enabled, it is possible for multiple instances
> of statistics queries to be sent to the chip - this may cause the FW to assert.
>
> This patch prevents the sending of an additional instance of statistics query
> while the previous query hasn't completed.
>
> Signed-off-by: Dmitry Kravkov <dmitry@broadcom.com>
> Signed-off-by: Yuval Mintz <yuvalmin@broadcom.com>
> Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
This change results in no change in behavior as far as I can tell.
> - if (bnx2x_storm_stats_update(bp) && (bp->stats_pending++ == 3)) {
> - BNX2X_ERR("storm stats were not updated for 3 times\n");
> - bnx2x_panic();
> + if (bnx2x_storm_stats_update(bp)) {
> + if (bp->stats_pending++ == 3) {
> + BNX2X_ERR("storm stats were not updated for 3 times\n");
> + bnx2x_panic();
> + }
There is no difference between:
if (A && B) {
C;
}
and:
if (A) {
if (B) {
C;
}
}
Yet that's exactly what is happening in this patch.
And such a do-nothing change is certainly not appropriate this late in
the -rc series.
I'm tossing this entire series, please sort this out and submit
the real actual critical bug fixes.
^ permalink raw reply
* Re: [v3 PATCH 1/2] netprio_cgroup: Remove update_netdev_tables() since it is unnecessary
From: David Miller @ 2012-09-13 20:19 UTC (permalink / raw)
To: srivatsa.bhat
Cc: nhorman, David.Laight, john.r.fastabend, gaofeng, eric.dumazet,
mark.d.rustad, lizefan, netdev, linux-kernel
In-Reply-To: <20120913063225.6278.87780.stgit@srivatsabhat.in.ibm.com>
From: "Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>
Date: Thu, 13 Sep 2012 12:02:25 +0530
> The update_netdev_tables() function appears to be unnecessary, since the
> write_update_netdev_table() function will adjust the priomaps as and when
> required anyway. So drop the usage of update_netdev_tables() entirely.
>
> Signed-off-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
Applied to net-next
^ permalink raw reply
* Re: [v3 PATCH 2/2] netprio_cgroup: Use memcpy instead of the for-loop to copy priomap
From: David Miller @ 2012-09-13 20:19 UTC (permalink / raw)
To: srivatsa.bhat
Cc: nhorman, David.Laight, john.r.fastabend, gaofeng, eric.dumazet,
mark.d.rustad, lizefan, netdev, linux-kernel
In-Reply-To: <20120913063233.6278.7615.stgit@srivatsabhat.in.ibm.com>
From: "Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>
Date: Thu, 13 Sep 2012 12:02:34 +0530
> Replace the current (inefficient) for-loop with memcpy, to copy priomap.
>
> Signed-off-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
Applied to net-next
^ permalink raw reply
* Remarks and comments about ipconfig behavior
From: Erwan Velu @ 2012-09-13 20:21 UTC (permalink / raw)
To: netdev
Hey Fellows !
I've been figuring a strange behavior today and I'd like to share with
you both experience and remarks.
On my system that runs a 3.2.29 but that's also applicable with
linux-next and all other releases.
As shown here :
http://git.kernel.org/?p=linux/kernel/git/next/linux-next.git;a=blob;f=net/ipv4/ipconfig.c;h=67e8a6b086ea7a0d2c4cc986ed6ed0e6b4414c6a;hb=HEAD#l262
, if you specify an ip= option on the cmdline, the kernel is expecting
the carrier to be present unless it will make a loop up to 2mn as per
CONF_CARRIER_TIMEOUT value.
That lever for me two points :
- why is this timeout setup for so long ? Even with a spantree
configuration, not having a carrier for 2mn is *waow* ... Does a 30sec
could not be enough ? What is the need of waiting so long time ?
- Until we get the carrier, the kernel just stops and the boot process
is totally locked but there isn't any message shown to the user. The
system really look like frozen/dead for 2 minutes.
I spent a complete day trying to understand why my box was unable to
boot while the network cable was removed.
I just discover this behavior by comparing log files to understand that
was the reason.
So my suggestion would be the following and I can offer patches if you
agree on thoses points :
- reducing the timeout to something smaller like 30sec
- display a message every second to inform the user we are waiting the
carrier to satisfy the ipconfig option
What are you thoughts on that ?
Thanks you,
Erwan Velu
^ permalink raw reply
* Re: [net-next.git 3/8 (V2)] stmmac: add the initial tx coalesce schema
From: David Miller @ 2012-09-13 20:23 UTC (permalink / raw)
To: peppe.cavallaro; +Cc: netdev, bhutchings
In-Reply-To: <1347346514-23411-4-git-send-email-peppe.cavallaro@st.com>
From: Giuseppe CAVALLARO <peppe.cavallaro@st.com>
Date: Tue, 11 Sep 2012 08:55:09 +0200
> + unsigned long flags;
> +
> + spin_lock_irqsave(&priv->tx_lock, flags);
>
> - spin_lock(&priv->tx_lock);
> + priv->xstats.tx_clean++;
You are changing the locking here for the sake of the new timer.
But timers run in software interrupt context, so this change is
completely unnecessary since NAPI runs in software interrupt context
as well, and neither timers nor NAPI run in hardware interrupts
context.
Therefore, disabling hardware interrupts for this lock is unnecessary
and will decrease performance.
^ permalink raw reply
* Re: [PATCH] scsi_netlink: Remove dead and buggy code
From: David Miller @ 2012-09-13 20:24 UTC (permalink / raw)
To: ebiederm; +Cc: James.Bottomley, netdev, James.Smart, linux-scsi
In-Reply-To: <20120911.184846.1973557158791638595.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Tue, 11 Sep 2012 18:48:46 -0400 (EDT)
> From: ebiederm@xmission.com (Eric W. Biederman)
> Date: Tue, 11 Sep 2012 15:40:08 -0700
>
>> So just for curiosity I searched the entire git history for scsi_nl_add_
>> and the only commit that I found was the addition of that code to the
>> tree in August of 2008.
>>
>> Does anyone have any reason to keep scsi_nl_add_transport or
>> scsi_nl_add_driver that have never been used in the 4 years since
>> they have been added?
>
> That's basically the question on the table right now :-)
Time has run out.
Letting legitimate and reasonable patches simply rot for a week is
absolutely never acceptable, so I'm applying Eric's patch to net-next.
^ permalink raw reply
* Re: Remarks and comments about ipconfig behavior
From: David Miller @ 2012-09-13 20:31 UTC (permalink / raw)
To: erwanaliasr1; +Cc: netdev
In-Reply-To: <5052403B.4040408@gmail.com>
From: Erwan Velu <erwanaliasr1@gmail.com>
Date: Thu, 13 Sep 2012 22:21:15 +0200
> That lever for me two points :
> - why is this timeout setup for so long ? Even with a spantree
> - configuration, not having a carrier for 2mn is *waow* ... Does a 30sec
> - could not be enough ? What is the need of waiting so long time ?
I've seen PHY/switch/hub combinations that take longer than 30 seconds
to fully negotiate the link.
There is really no upper limit to the link speed/duplex/etc.
negoatiation process.
Even if the actual negoatiation protocol had an upper limit on
negoatiation time, hardware implementations do things like try
sampling the quality of the cable signal and may choose to
down-rev the advertised features and restart the negoatiation.
^ permalink raw reply
* Re: [PATCH 1/2] ipv6: Add labels for site-local and 6bone testing addresses (RFC6724)
From: David Miller @ 2012-09-13 20:34 UTC (permalink / raw)
To: yoshfuji; +Cc: netdev
In-Reply-To: <201209110508.q8B58GJO015601@94.43.138.210.xn.2iij.net>
From: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Date: Tue, 11 Sep 2012 13:16:49 +0900
> Added labels for site-local addresses (fec0::/10) and 6bone testing
> addresses (3ffe::/16) in order to depreference them.
>
> Note that the RFC introduced new rows for Teredo, ULA and 6to4 addresses
> in the default policy table. Some of them have different labels from ours.
> For backward compatibility, we do not change the "default" labels.
>
> Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Applied to net-next.
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox