* Re: [PATCH] vmxnet3: convert BUG_ON(true) into a simple BUG()
From: David Miller @ 2012-11-09 22:03 UTC (permalink / raw)
To: sbhatewara; +Cc: sasha.levin, pv-drivers, netdev, linux-kernel
In-Reply-To: <967392202.19635700.1352440936686.JavaMail.root@vmware.com>
From: Shreyas Bhatewara <sbhatewara@vmware.com>
Date: Thu, 8 Nov 2012 22:02:16 -0800 (PST)
>
> ----- Original Message -----
>> Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
>> ---
>> drivers/net/vmxnet3/vmxnet3_drv.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Signed-off-by: Shreyas N Bhatewara <sbhatewara@vmware.com>
Applied, thanks.
^ permalink raw reply
* Re: [PATCH net-next] ipip: add GSO support
From: David Miller @ 2012-11-09 22:01 UTC (permalink / raw)
To: eric.dumazet; +Cc: netdev, maze, therbert, willemb
In-Reply-To: <1352404792.19779.88.camel@edumazet-glaptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 08 Nov 2012 11:59:52 -0800
> From: Eric Dumazet <edumazet@google.com>
>
> In commit 6b78f16e4b (gre: add GSO support) we added GSO support to GRE
> tunnels.
>
> This patch does the same for IPIP tunnels.
>
> Performance of single TCP flow over an IPIP tunnel is increased by 40%
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied, thanks.
^ permalink raw reply
* Re: [PATCH] usbnet: ratelimit kevent may have been dropped warnings
From: David Miller @ 2012-11-09 22:00 UTC (permalink / raw)
To: steve.glendinning; +Cc: oneukum, netdev
In-Reply-To: <1352391981-15692-1-git-send-email-steve.glendinning@shawell.net>
From: Steve Glendinning <steve.glendinning@shawell.net>
Date: Thu, 8 Nov 2012 16:26:21 +0000
> when something goes wrong, a flood of these messages can be
> generated by usbnet (thousands per second). This doesn't
> generally *help* the condition so this patch ratelimits the
> rate of their generation.
>
> There's an underlying problem in usbnet's kevent deferral
> mechanism which needs fixing, specifically that events *can*
> get dropped and not handled. This patch doesn't address this,
> but just mitigates fallout caused by the current implemention.
>
> Signed-off-by: Steve Glendinning <steve.glendinning@shawell.net>
Applied, thanks.
^ permalink raw reply
* Re: [PATCH] ipv4: Handle very small SO_SNDTIMEOs
From: David Miller @ 2012-11-09 21:58 UTC (permalink / raw)
To: andi; +Cc: netdev, ak
In-Reply-To: <1352389908-28587-1-git-send-email-andi@firstfloor.org>
From: Andi Kleen <andi@firstfloor.org>
Date: Thu, 8 Nov 2012 07:51:48 -0800
> From: Andi Kleen <ak@linux.intel.com>
>
> When the SO_SNDTIMEO timeout is short enough it may round down to zero
> jiffies. This causes unexpected behaviour because the socket
> essentially becomes always non blocking.
>
> Round up the timeout to at least two jiffies, so that
> we guarantee waiting for at least some time. With one jiffie
> we could potentially still wait zero time because we might
> be just at the edge of the jiffie, and if it flips over
> in the middle of the check it could be still zero.
>
> This has been observed in a real application.
>
> Signed-off-by: Andi Kleen <ak@linux.intel.com>
Please use usecs_to_jiffies() and, if necessary, implement the policy
there.
I'm sure that things like poll() et al. have similar if not identical
issues. Therefore it's better to have some generic spot deal with
this problem generically.
^ permalink raw reply
* Re: [PATCH net-next] doc: packet_mmap: update doc to implementation status
From: David Miller @ 2012-11-09 21:46 UTC (permalink / raw)
To: dxchgb; +Cc: ronny.meeus, uaca, johann.baudy, netdev
In-Reply-To: <20121108123700.GA25799@thinkbox>
From: Daniel Borkmann <dxchgb@gmail.com>
Date: Thu, 8 Nov 2012 13:37:01 +0100
> This improves the packet_mmap.txt document in the following ways:
>
> * Add initial information about different TPACKET versions
> * Add initial information about packet fanout
> * Add pointer to BPF document (since this also could be of interest)
> * 'Fix' minor, rather cosmetic things
>
> Information partially taken from related commit messages.
>
> Reported-by: Ronny Meeus <ronny.meeus@gmail.com>
> Signed-off-by: Daniel Borkmann <daniel.borkmann@tik.ee.ethz.ch>
Thanks for doing this, applied.
^ permalink raw reply
* Re: [PATCH net-next 1/2] PPC: net: bpf_jit_comp: add XOR instruction for BPF JIT
From: David Miller @ 2012-11-09 21:40 UTC (permalink / raw)
To: dxchgb; +Cc: matt, benh, netdev
In-Reply-To: <20121108213939.GA29696@thinkbox>
From: Daniel Borkmann <dxchgb@gmail.com>
Date: Thu, 8 Nov 2012 22:39:41 +0100
> This patch is a follow-up for patch "filter: add XOR instruction for use
> with X/K" that implements BPF PowerPC JIT parts for the BPF XOR operation.
>
> Signed-off-by: Daniel Borkmann <daniel.borkmann@tik.ee.ethz.ch>
Could a powerpc person please review these two patches so that I can
toss them into net-next (where the dependency is)?
Thanks!
^ permalink raw reply
* Re: [PATCH net-next 1/2] ARM: net: bpf_jit_32: add XOR instruction for BPF JIT
From: David Miller @ 2012-11-09 21:39 UTC (permalink / raw)
To: dxchgb; +Cc: mgherzan, arnd, netdev, linux-arm-kernel
In-Reply-To: <20121108012828.GA23143@thinkbox>
From: Daniel Borkmann <dxchgb@gmail.com>
Date: Thu, 8 Nov 2012 02:28:28 +0100
> This patch is a follow-up for patch "filter: add XOR instruction for use
> with X/K" that implements BPF ARM JIT parts for the BPF XOR operation.
>
> Signed-off-by: Daniel Borkmann <daniel.borkmann@tik.ee.ethz.ch>
> Cc: Mircea Gherzan <mgherzan@gmail.com>
> Cc: Arnd Bergmann <arnd@arndb.de>
Could an ARM person please review and ACK these two patches so that
I can toss them into net-next (where the dependency is)?
Thanks!
^ permalink raw reply
* Re: [PATCH net-next] phylib: mdio: Add sysfs attribute for PHY identifiers.
From: David Miller @ 2012-11-09 21:38 UTC (permalink / raw)
To: nbowler; +Cc: netdev
In-Reply-To: <1352305234-22340-1-git-send-email-nbowler@elliptictech.com>
From: Nick Bowler <nbowler@elliptictech.com>
Date: Wed, 7 Nov 2012 11:20:34 -0500
> This adds a phy_id sysfs attribute to MDIO devices, containing the
> 32-bit PHY identifier reported by the device. This attribute can
> be useful when debugging problems related to phy drivers. Other
> enumerable buses already have similar attributes.
>
> Signed-off-by: Nick Bowler <nbowler@elliptictech.com>
Seems reasonable, applied, thanks.
^ permalink raw reply
* Re: [PATCH v3 8/7] pppoatm: fix missing wakeup in pppoatm_send()
From: David Miller @ 2012-11-09 21:30 UTC (permalink / raw)
To: dwmw2; +Cc: krzysiek, netdev, linux-kernel, chas
In-Reply-To: <1352292734.7340.35.camel@shinybook.infradead.org>
From: David Woodhouse <dwmw2@infradead.org>
Date: Wed, 07 Nov 2012 12:52:14 +0000
> Now that we can return zero from pppoatm_send() for reasons *other* than
> the queue being full, that means we can't depend on a subsequent call to
> pppoatm_pop() waking the queue, and we might leave it stalled
> indefinitely.
>
> Fix this by immediately scheduling the wakeup tasklet. As documented
> already elsewhere, the PPP channel's ->downl lock protects against the
> wakeup happening too soon and effectively being missed.
>
> Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
> ----
> Untested.
> With this sorted, Acked-By: David Woodhouse <David.Woodhouse@intel.com<
> to the other seven. Thanks.
I don't know what to do with this patch because I don't have any
context whatsoever.
So I'm tossing it, please resubmit it when it's meant to be
applied, and with some context.
^ permalink raw reply
* Re: [PATCH 4/4] Make the wanxl firmware array const
From: David Miller @ 2012-11-09 21:29 UTC (permalink / raw)
To: dhowells; +Cc: khc, netdev, linux
In-Reply-To: <20121107123731.4147.57657.stgit@warthog.procyon.org.uk>
From: David Howells <dhowells@redhat.com>
Date: Wed, 07 Nov 2012 12:37:31 +0000
> Make the wanxl firmware array const so that it goes in the read-only section.
>
> Signed-off-by: David Howells <dhowells@redhat.com>
Applied to net-next.
^ permalink raw reply
* Re: [PATCH 3/4] Fix the wanxl firmware to include missing constants
From: David Miller @ 2012-11-09 21:29 UTC (permalink / raw)
To: dhowells; +Cc: khc, netdev, linux
In-Reply-To: <20121107123724.4147.98542.stgit@warthog.procyon.org.uk>
From: David Howells <dhowells@redhat.com>
Date: Wed, 07 Nov 2012 12:37:24 +0000
> Fix the wanxl firmware to include missing constants such as PARITY_NONE. It
> should be #including the linux/hdlc/ioctl.h header.
>
> To make this work, we also have to guard parts of ioctl.h with !__ASSEMBLY__.
>
> Signed-off-by: David Howells <dhowells@redhat.com>
Applied to net-next.
^ permalink raw reply
* Re: [PATCH 2/4] UAPI: (Scripted) Disintegrate include/linux/hdlc
From: David Miller @ 2012-11-09 21:29 UTC (permalink / raw)
To: dhowells; +Cc: khc, netdev, linux
In-Reply-To: <20121107123717.4147.15213.stgit@warthog.procyon.org.uk>
From: David Howells <dhowells@redhat.com>
Date: Wed, 07 Nov 2012 12:37:17 +0000
> Signed-off-by: David Howells <dhowells@redhat.com>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
> Acked-by: Thomas Gleixner <tglx@linutronix.de>
> Acked-by: Michael Kerrisk <mtk.manpages@gmail.com>
> Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> Acked-by: Dave Jones <davej@redhat.com>
> Acked-by: Krzysztof Halasa <khc@pm.waw.pl>
Applied to net-next.
^ permalink raw reply
* Re: [PATCH 1/4] UAPI: Fix compilation of the wanxl firmware blob.
From: David Miller @ 2012-11-09 21:29 UTC (permalink / raw)
To: dhowells; +Cc: khc, netdev, linux
In-Reply-To: <20121107123709.4147.98018.stgit@warthog.procyon.org.uk>
From: David Howells <dhowells@redhat.com>
Date: Wed, 07 Nov 2012 12:37:09 +0000
> The wanxl firmware needs access to some bits of UAPI stuff, so the -I flag in
> the Makefile needs adjusting to point at the UAPI headers.
>
> Signed-off-by: David Howells <dhowells@redhat.com>
Applied to net-next.
^ permalink raw reply
* Re: [PATCH] bonding: rlb mode of bond should not alter ARP replies originating via bridge
From: David Miller @ 2012-11-09 21:25 UTC (permalink / raw)
To: zheng.x.li; +Cc: netdev, fubar, andy, linux-kernel, joe.jin
In-Reply-To: <1352258580-8272-1-git-send-email-zheng.x.li@oracle.com>
From: Zheng Li <zheng.x.li@oracle.com>
Date: Wed, 7 Nov 2012 11:23:00 +0800
> ARP traffic passing through a bridge and out via the bond (when the bond is a
> port of the bridge) should not have its source MAC address adjusted by the
> receive load balance code in rlb_arp_xmit.
>
> Signed-off-by: Zheng Li <zheng.x.li@oracle.com>
Please format these change properly, this is not indented
correctly at all:
> + if (ether_addr_equal_64bits(arp->mac_src,
> + tmp_slave->dev->dev_addr)) {
> + memcpy(arp->mac_src,
> + tx_slave->dev->dev_addr,
> + ETH_ALEN);
> + break;
Arguments to functions should line up, always, with the first column
after the openning parenthesis of the function call.
If that makes the far right column of the line go too far past
80 columns, too bad. Make and use a helper function to perform
this test in that case.
Thanks.
^ permalink raw reply
* Re: [PATCH] ipv6: add knob to send unsolicited ND on link-layer address change
From: David Miller @ 2012-11-09 21:22 UTC (permalink / raw)
To: hannes; +Cc: netdev
In-Reply-To: <20121109130141.GA31099@order.stressinduktion.org>
From: Hannes Frederic Sowa <hannes@stressinduktion.org>
Date: Fri, 9 Nov 2012 14:01:41 +0100
> David, if you intend to merge this patch, could you please remove the empty
> line I accidently added in the addrconf_sysctl_table, directly following
> .proc_handler? As usual, I noticed it just after sending the patch.
I intend to eventually apply this to net-next, and I'll take care
of the empty line when I do so, thanks.
^ permalink raw reply
* Re: [PATCH] ipv6: send unsolicited neighbour advertisements to all-nodes
From: David Miller @ 2012-11-09 21:22 UTC (permalink / raw)
To: hannes; +Cc: netdev
In-Reply-To: <20121107021841.GC26398@order.stressinduktion.org>
From: Hannes Frederic Sowa <hannes@stressinduktion.org>
Date: Wed, 7 Nov 2012 03:18:41 +0100
> As documented in RFC4861 (Neighbor Discovery for IP version 6) 7.2.6.,
> unsolicited neighbour advertisements should be sent to the all-nodes
> multicast address.
>
> Signed-off-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
Applied and queued up for -stable, thanks.
^ permalink raw reply
* Re: How to compile tcp fast open client app with kernel tfo client support ?
From: Vincent Li @ 2012-11-09 21:09 UTC (permalink / raw)
To: Vijay Subramanian; +Cc: Eric Dumazet, Yuchung Cheng, netdev
In-Reply-To: <CAGK4HS_SpdECk_KCu98Z1X9W02G9j9u7QE9B6qHEnTXLeZbqgA@mail.gmail.com>
On Fri, Nov 9, 2012 at 12:54 PM, Vijay Subramanian
<subramanian.vijay@gmail.com> wrote:
> On 9 November 2012 12:27, Eric Dumazet <eric.dumazet@gmail.com> wrote:
>> On Fri, 2012-11-09 at 12:17 -0800, Vincent Li wrote:
>>
>>> I have tried to run fresh build net-next, for some reason the build
>>> stops ssh service from starting up, tried 3.7.0-rc4 too, same issue. I
>>> don't know if it is new kernel bug or ubuntu upstart bug, but that is
>>> another issue.
>>>
>>
>> Not sure Ubuntu 10.04 binaries can run a 3.7 kernel.
>>
>> Some bug fixes in kernel need bug fixes in userland.
>>
>> You could try a bisection ?
>>
> I saw the same issue with Ubuntu starting around 3.7.0-rc1 but 3.6
> was fine if I recall. (I did a partial bisection but was not sure it
> was a kernel issue)
> sshd would not start up on boot and I 'fixed' it by adding the
> following in /etc/rc.local since I assumed it was a userspace issue.
>
> if [ ! -d /var/run/sshd ]; then
> mkdir /var/run/sshd
> chmod 0755 /var/run/sshd
> fi
> /usr/sbin/sshd
>
>
> Thanks,
> Vijay
thanks again, you "fixed" my other issue :-)
Vincent
^ permalink raw reply
* Re: [PATCH 2/2] smsc95xx: set MII_BUSY bit to read/write PHY regs
From: David Miller @ 2012-11-09 21:08 UTC (permalink / raw)
To: steve.glendinning; +Cc: netdev
In-Reply-To: <1352196533-2674-1-git-send-email-steve.glendinning@shawell.net>
From: Steve Glendinning <steve.glendinning@shawell.net>
Date: Tue, 6 Nov 2012 10:08:53 +0000
> The device datasheet specifies the BUSY bit must be set when reading
> or writing phy registers. This patch ensures we do that.
>
> Signed-off-by: Steve Glendinning <steve.glendinning@shawell.net>
Steve please let me know why you only submitted patch #2
of an apparent 2 part series.
If I don't get a response soon I'm just going to toss this
patch instead of letting it simply rot in patchwork.
Thanks.
^ permalink raw reply
* Re: [PATCH] cdc_ether: use USB_DEVICE_AND_INTERFACE_INFO for Novatel 551L/E362
From: David Miller @ 2012-11-09 21:07 UTC (permalink / raw)
To: dcbw; +Cc: bjorn, aleksander, netdev
In-Reply-To: <1352398152.22225.14.camel@dcbw.foobar.com>
From: Dan Williams <dcbw@redhat.com>
Date: Thu, 08 Nov 2012 12:09:12 -0600
> Small cleanup.
>
> Signed-off-by: Dan Williams <dcbw@redhat.com>
> Cc: stable@vger.kernel.org
Don't do things like this, _please_.
A cleanup is absolutely not appropriate for -stable. Yet you
tagged this as being destined for there.
What's more this screws up the second patch, which in fact could
be -stable material. But I'm not going to apply it as it is
because it could have dependencies on this patch which as
states is not inappropriate for both 'net' and -stable.
I'm therefore tossing both of these changes, submit things properly
please.
^ permalink raw reply
* Re: How to compile tcp fast open client app with kernel tfo client support ?
From: Vijay Subramanian @ 2012-11-09 20:54 UTC (permalink / raw)
To: Eric Dumazet; +Cc: Vincent Li, Yuchung Cheng, netdev
In-Reply-To: <1352492823.19779.825.camel@edumazet-glaptop>
On 9 November 2012 12:27, Eric Dumazet <eric.dumazet@gmail.com> wrote:
> On Fri, 2012-11-09 at 12:17 -0800, Vincent Li wrote:
>
>> I have tried to run fresh build net-next, for some reason the build
>> stops ssh service from starting up, tried 3.7.0-rc4 too, same issue. I
>> don't know if it is new kernel bug or ubuntu upstart bug, but that is
>> another issue.
>>
>
> Not sure Ubuntu 10.04 binaries can run a 3.7 kernel.
>
> Some bug fixes in kernel need bug fixes in userland.
>
> You could try a bisection ?
>
I saw the same issue with Ubuntu starting around 3.7.0-rc1 but 3.6
was fine if I recall. (I did a partial bisection but was not sure it
was a kernel issue)
sshd would not start up on boot and I 'fixed' it by adding the
following in /etc/rc.local since I assumed it was a userspace issue.
if [ ! -d /var/run/sshd ]; then
mkdir /var/run/sshd
chmod 0755 /var/run/sshd
fi
/usr/sbin/sshd
Thanks,
Vijay
^ permalink raw reply
* Re: essentially offline...
From: Jan Ceuleers @ 2012-11-09 20:49 UTC (permalink / raw)
To: David Miller
Cc: netdev-u79uwXL29TY76Z2rM5mHXA,
netfilter-devel-u79uwXL29TY76Z2rM5mHXA,
linux-wireless-u79uwXL29TY76Z2rM5mHXA
In-Reply-To: <20121108.160149.1435441347312920431.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
On 11/08/2012 10:01 PM, David Miller wrote:
> I used the work jackass just as frequently before I lived part time
> in New York. Try again...
Well then it seems you were born that way. Still doesn't make it acceptable.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* Re: Question about Mellanox FW reporting (incorrect) port types
From: Marcelo Ricardo Leitner @ 2012-11-09 20:37 UTC (permalink / raw)
To: Or Gerlitz
Cc: Yevgeny Petrilin, netdev, Or Gerlitz, Doug Ledford, Yishai Hadas
In-Reply-To: <507F0BD5.7080005@redhat.com>
Em 17-10-2012 16:49, Marcelo Ricardo Leitner escreveu:
> On 10/17/2012 04:22 PM, Or Gerlitz wrote:
>> Marcelo Ricardo Leitner <mleitner@redhat.com> wrote:
>>>
>>> [...] So my questions are: is it possible to the firmware report a
>>> wrong port type like
>>> that? Is it somehow configurable by sysadmin (via fw update, ..), can
>>> we flip that byte
>>> or is it a manufacturing issue?
For completeness,
As it happens the customer had the HP Infinband Enablement Kit
(614841-B21) installed at jumper location 53 (J53) of the motherboard,
which makes the QSFP port of the S390s' NC543i interface an Infiniband
interface rather than a 10gbE interface. Removing this allowed the port
to be brought-up as 10GbE just fine.
Interesting that it worked as 10GbE even with InifiniBand Enablement Kit
on it, so the port was just advertised, but not forced, as InfiniBand.
Or something like that.
Thanks,
Marcelo.
^ permalink raw reply
* Re: How to compile tcp fast open client app with kernel tfo client support ?
From: Eric Dumazet @ 2012-11-09 20:27 UTC (permalink / raw)
To: Vincent Li; +Cc: Yuchung Cheng, Vijay Subramanian, netdev
In-Reply-To: <CAK3+h2xAqjs8CvkcwXiFryyQhDnohsN7-0KfQVjpegZh_AD1eg@mail.gmail.com>
On Fri, 2012-11-09 at 12:17 -0800, Vincent Li wrote:
> I have tried to run fresh build net-next, for some reason the build
> stops ssh service from starting up, tried 3.7.0-rc4 too, same issue. I
> don't know if it is new kernel bug or ubuntu upstart bug, but that is
> another issue.
>
Not sure Ubuntu 10.04 binaries can run a 3.7 kernel.
Some bug fixes in kernel need bug fixes in userland.
You could try a bisection ?
^ permalink raw reply
* Re: How to compile tcp fast open client app with kernel tfo client support ?
From: Vincent Li @ 2012-11-09 20:17 UTC (permalink / raw)
To: Yuchung Cheng; +Cc: Vijay Subramanian, netdev
In-Reply-To: <CAK6E8=fc=hYppk=4+tnNF9UPvQNFhw8YKo-ebG2y6FwXTft_EQ@mail.gmail.com>
> Hi Vincent,
>
> Note that MSG_FASTOPEN flag should be used only once. Subsequent
> sendto(MSG_FASTOPEN) == connect() on connected sockets. You can verify
> if the fast open is successful by checking a bit in TCP_INFO.
> http://patchwork.o zlabs.org/patch/192883/ if you are running a fresh
> netdev build.
>
> I'll submit a patch to update the man page on MSG_FASTOPEN too.
>
> Yuchung
>
I have tried to run fresh build net-next, for some reason the build
stops ssh service from starting up, tried 3.7.0-rc4 too, same issue. I
don't know if it is new kernel bug or ubuntu upstart bug, but that is
another issue.
I will study the tcp fast open more, thanks.
Vincent
^ permalink raw reply
* Re: [PATCH v3 1/9] net: core: use this_cpu_ptr per-cpu helper
From: Eric Dumazet @ 2012-11-09 20:15 UTC (permalink / raw)
To: Christoph Lameter
Cc: Shan Wei, David Miller, timo.teras, steffen.klassert, NetDev,
Kernel-Maillist
In-Reply-To: <0000013ae6c9e81a-eabe295b-72a5-4ebd-85c5-231bec1a70c5-000000@email.amazonses.com>
On Fri, 2012-11-09 at 20:08 +0000, Christoph Lameter wrote:
> On Fri, 9 Nov 2012, Shan Wei wrote:
>
> > diff --git a/net/core/flow.c b/net/core/flow.c
> > index e318c7e..b0901ee 100644
> > --- a/net/core/flow.c
> > +++ b/net/core/flow.c
> > @@ -327,11 +327,9 @@ static void flow_cache_flush_tasklet(unsigned long data)
> > static void flow_cache_flush_per_cpu(void *data)
> > {
> > struct flow_flush_info *info = data;
> > - int cpu;
> > struct tasklet_struct *tasklet;
> >
> > - cpu = smp_processor_id();
> > - tasklet = &per_cpu_ptr(info->cache->percpu, cpu)->flush_tasklet;
> > + tasklet = this_cpu_ptr(&info->cache->percpu->flush_tasklet);
> > tasklet->data = (unsigned long)info;
>
> this_cpu_write(info->cache->percpu->flush_tasklet->data, (unsigned
> long)info);
>
> should also do the trick in less instructions and get rid of all temporary
> variables as well.
Its not the case.
We need the _pointer_ to call :
tasklet_schedule(tasklet);
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox