* Re: [PATCH net-next] core: simplify the getting percpu of flow_cache
From: David Miller @ 2013-03-29 19:15 UTC (permalink / raw)
To: roy.qing.li; +Cc: netdev
In-Reply-To: <1364473451-3640-1-git-send-email-roy.qing.li@gmail.com>
From: roy.qing.li@gmail.com
Date: Thu, 28 Mar 2013 20:24:11 +0800
> From: Li RongQing <roy.qing.li@gmail.com>
>
> replace per_cpu with per_cpu_ptr to save conversion between address and pointer
>
> Signed-off-by: Li RongQing <roy.qing.li@gmail.com>
Applied.
^ permalink raw reply
* Re: [PATCH] smsc75xx: fix jumbo frame support
From: David Miller @ 2013-03-29 19:16 UTC (permalink / raw)
To: steve.glendinning; +Cc: netdev, philip.dawson
In-Reply-To: <1364474081-21918-1-git-send-email-steve.glendinning@shawell.net>
From: Steve Glendinning <steve.glendinning@shawell.net>
Date: Thu, 28 Mar 2013 12:34:41 +0000
> This patch enables RX of jumbo frames for LAN7500.
>
> Previously the driver would transmit jumbo frames succesfully but
> would drop received jumbo frames (incrementing the interface errors
> count).
>
> With this patch applied the device can succesfully receive jumbo
> frames up to MTU 9000 (9014 bytes on the wire including ethernet
> header).
>
> Signed-off-by: Steve Glendinning <steve.glendinning@shawell.net>
Applied and queued up for -stable, thanks Steve.
^ permalink raw reply
* Re: [PATCH] net: core: Remove redundant call to 'nf_reset' in 'dev_forward_skb'
From: Eric Dumazet @ 2013-03-29 19:17 UTC (permalink / raw)
To: David Miller; +Cc: shmulik.ladkani, greearb, netdev, rgohita
In-Reply-To: <20130329.151120.296920819953677221.davem@davemloft.net>
On Fri, 2013-03-29 at 15:11 -0400, David Miller wrote:
> From: Shmulik Ladkani <shmulik.ladkani@gmail.com>
> Date: Thu, 28 Mar 2013 11:13:26 +0200
>
> > 'nf_reset' is called just prior calling 'netif_rx'.
> > No need to call it twice.
> >
> > Reported-by: Igor Michailov <rgohita@gmail.com>
> > Signed-off-by: Shmulik Ladkani <shmulik.ladkani@gmail.com>
>
> I do not see this happening in the:
>
> macvlan_start_xmit()
>
> --> macvlan_queue_xmit()
>
> code path.
>
> I'm not applying this patch. There seems to be no real agreement
> that the caller of dev_forward_skb() takes care of the nf_reset().
>
> And wouldn't it be better to consolidate the nf_reset() calls
> into one place instead of several, increasing the audit burdon.
>
Hmm, I believe you misread this patch :
nf_reset() is called _twice_ in dev_forward_skb()
int dev_forward_skb(struct net_device *dev, struct sk_buff *skb)
{
if (skb_shinfo(skb)->tx_flags & SKBTX_DEV_ZEROCOPY) {
if (skb_copy_ubufs(skb, GFP_ATOMIC)) {
atomic_long_inc(&dev->rx_dropped);
kfree_skb(skb);
return NET_RX_DROP;
}
}
skb_orphan(skb);
<1> nf_reset(skb);
if (unlikely(!is_skb_forwardable(dev, skb))) {
atomic_long_inc(&dev->rx_dropped);
kfree_skb(skb);
return NET_RX_DROP;
}
skb->skb_iif = 0;
skb->dev = dev;
skb_dst_drop(skb);
skb->tstamp.tv64 = 0;
skb->pkt_type = PACKET_HOST;
skb->protocol = eth_type_trans(skb, dev);
skb->mark = 0;
secpath_reset(skb);
<2> nf_reset(skb);
return netif_rx(skb);
}
^ permalink raw reply
* Re: [PATCH v2] net IPv6 : Fix broken IPv6 routing table after loopback down-up
From: David Miller @ 2013-03-29 19:17 UTC (permalink / raw)
To: kumaran.4353
Cc: eric.dumazet, yoshfuji, kaber, kuznet, jmorris,
Balakumaran.Kannan, maruthi.thotad, netdev, jamshed.a,
amit.agarwal, takuzo.ohara, aaditya.kumar
In-Reply-To: <CAHPKR9J=niSHrGmeX7ZM-1fosjnRA_CFrfd+ha3zwNibNGe1bg@mail.gmail.com>
From: Balakumaran Kannan <kumaran.4353@gmail.com>
Date: Thu, 28 Mar 2013 20:44:36 +0530
> static void addrconf_add_linklocal(struct inet6_dev *idev, const
> struct in6_addr *addr)
Your email client corrupted this patch, please resubmit but only after
you have emailed the patch to yourself and successfully applied the
patch you receive in that test email.
Thanks.
^ permalink raw reply
* [net-next PATCH] net: rtnetlink: fdb dflt dump must set idx used for cb->arg[0]
From: John Fastabend @ 2013-03-29 18:18 UTC (permalink / raw)
To: netdev; +Cc: vyasevich
In rtnl_fdb_dump() when the fdb_dump ndo op is not populated
we never set the idx value so that cb->arg[0] is always 0.
Resulting in a endless loop of messages.
Introduced with this commit,
commit 090096bf3db1c281ddd034573260045888a68fea
Author: Vlad Yasevich <vyasevic@redhat.com>
Date: Wed Mar 6 15:39:42 2013 +0000
net: generic fdb support for drivers without ndo_fdb_<op>
CC: Vlad Yasevich <vyasevic@redhat.com>
Signed-off-by: John Fastabend <john.r.fastabend@intel.com>
---
net/core/rtnetlink.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
index 6fdfac8..d2322d7 100644
--- a/net/core/rtnetlink.c
+++ b/net/core/rtnetlink.c
@@ -2262,7 +2262,7 @@ skip:
* @dev: netdevice
*
* Default netdevice operation to dump the existing unicast address list.
- * Returns zero on success.
+ * Returns number of addresses from list put in skb.
*/
int ndo_dflt_fdb_dump(struct sk_buff *skb,
struct netlink_callback *cb,
@@ -2303,7 +2303,7 @@ static int rtnl_fdb_dump(struct sk_buff *skb, struct netlink_callback *cb)
if (dev->netdev_ops->ndo_fdb_dump)
idx = dev->netdev_ops->ndo_fdb_dump(skb, cb, dev, idx);
else
- ndo_dflt_fdb_dump(skb, cb, dev, idx);
+ idx = ndo_dflt_fdb_dump(skb, cb, dev, idx);
}
rcu_read_unlock();
^ permalink raw reply related
* Re: [PATCH] net: add a synchronize_net() in netdev_rx_handler_unregister()
From: Paul E. McKenney @ 2013-03-29 19:20 UTC (permalink / raw)
To: Eric Dumazet
Cc: Jiri Pirko, Steven Rostedt, Andy Gospodarek, David S. Miller,
LKML, netdev, Nicolas de Pesloüan, Thomas Gleixner,
Guy Streeter, stephen
In-Reply-To: <1364562082.5113.16.camel@edumazet-glaptop>
On Fri, Mar 29, 2013 at 06:01:22AM -0700, Eric Dumazet wrote:
> From: Eric Dumazet <edumazet@google.com>
>
> On Fri, 2013-03-29 at 10:48 +0100, Jiri Pirko wrote:
>
> > Hmm. I think that this might be issue introduced by:
> > commit a9b3cd7f323b2e57593e7215362a7b02fc933e3a
> > Author: Stephen Hemminger <shemminger@vyatta.com>
> > Date: Mon Aug 1 16:19:00 2011 +0000
> >
> > rcu: convert uses of rcu_assign_pointer(x, NULL) to RCU_INIT_POINTER
> >
> >
> > Because, if rcu_dereference(dev->rx_handler) is null,
> > rcu_dereference(dev->rx_handler_data) is never done. Therefore I believe
> > we are hitting following scenario:
> >
> >
> > CPU0 CPU1
> > ---- ----
> > dev->rx_handler_data = NULL
> > rcu_read_lock()
> > dev->rx_handler = NULL
> >
> >
> > CPU0 will see rx_handler set and yet, rx_handler_data nulled. Write
> > barrier in rcu_assign_pointer() might prevent this reorder from happening.
> > Therefore I suggest:
> >
> > diff --git a/net/core/dev.c b/net/core/dev.c
> > index 0caa38e..c16b829 100644
> > --- a/net/core/dev.c
> > +++ b/net/core/dev.c
> > @@ -3332,8 +3332,8 @@ void netdev_rx_handler_unregister(struct net_device *dev)
> > {
> >
> > ASSERT_RTNL();
> > - RCU_INIT_POINTER(dev->rx_handler, NULL);
> > - RCU_INIT_POINTER(dev->rx_handler_data, NULL);
> > + rcu_assign_pointer(dev->rx_handler, NULL);
> > + rcu_assign_pointer(dev->rx_handler_data, NULL);
> > }
> > EXPORT_SYMBOL_GPL(netdev_rx_handler_unregister);
> >
> >
>
> Nope this changes nothing at all.
>
> However, we can fix the bug in a different way, if we want to avoid a
> test in fast path.
>
> With following patch, we can make sure that a reader seeing a non NULL
> rx_handler has a guarantee to see a non NULL rx_handler_data
>
> Thanks
>
> [PATCH] net: add a synchronize_net() in netdev_rx_handler_unregister()
>
> commit 35d48903e97819 (bonding: fix rx_handler locking) added a race
> in bonding driver, reported by Steven Rostedt who did a very good
> diagnosis :
>
> <quoting Steven>
>
> I'm currently debugging a crash in an old 3.0-rt kernel that one of our
> customers is seeing. The bug happens with a stress test that loads and
> unloads the bonding module in a loop (I don't know all the details as
> I'm not the one that is directly interacting with the customer). But the
> bug looks to be something that may still be present and possibly present
> in mainline too. It will just be much harder to trigger it in mainline.
>
> In -rt, interrupts are threads, and can schedule in and out just like
> any other thread. Note, mainline now supports interrupt threads so this
> may be easily reproducible in mainline as well. I don't have the ability
> to tell the customer to try mainline or other kernels, so my hands are
> somewhat tied to what I can do.
>
> But according to a core dump, I tracked down that the eth irq thread
> crashed in bond_handle_frame() here:
>
> slave = bond_slave_get_rcu(skb->dev);
> bond = slave->bond; <--- BUG
>
>
> the slave returned was NULL and accessing slave->bond caused a NULL
> pointer dereference.
>
> Looking at the code that unregisters the handler:
>
> void netdev_rx_handler_unregister(struct net_device *dev)
> {
>
> ASSERT_RTNL();
> RCU_INIT_POINTER(dev->rx_handler, NULL);
> RCU_INIT_POINTER(dev->rx_handler_data, NULL);
> }
>
> Which is basically:
> dev->rx_handler = NULL;
> dev->rx_handler_data = NULL;
>
> And looking at __netif_receive_skb() we have:
>
> rx_handler = rcu_dereference(skb->dev->rx_handler);
> if (rx_handler) {
> if (pt_prev) {
> ret = deliver_skb(skb, pt_prev, orig_dev);
> pt_prev = NULL;
> }
> switch (rx_handler(&skb)) {
>
> My question to all of you is, what stops this interrupt from happening
> while the bonding module is unloading? What happens if the interrupt
> triggers and we have this:
>
>
> CPU0 CPU1
> ---- ----
> rx_handler = skb->dev->rx_handler
>
> netdev_rx_handler_unregister() {
> dev->rx_handler = NULL;
> dev->rx_handler_data = NULL;
>
> rx_handler()
> bond_handle_frame() {
> slave = skb->dev->rx_handler;
> bond = slave->bond; <-- NULL pointer dereference!!!
>
>
> What protection am I missing in the bond release handler that would
> prevent the above from happening?
>
> </quoting Steven>
>
> We can fix bug this in two ways. First is adding a test in
> bond_handle_frame() and others to check if rx_handler_data is NULL.
>
> A second way is adding a synchronize_net() in
> netdev_rx_handler_unregister() to make sure that a rcu protected reader
> has the guarantee to see a non NULL rx_handler_data.
>
> The second way is better as it avoids an extra test in fast path.
>
> Reported-by: Steven Rostedt <rostedt@goodmis.org>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: Jiri Pirko <jpirko@redhat.com>
> Cc: Paul E. McKenney <paulmck@us.ibm.com>
Reviewed-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
With kudos to Steven Rostedt for his analogy between RCU and
Schrödinger's cat. ;-)
> ---
> net/core/dev.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/net/core/dev.c b/net/core/dev.c
> index b13e5c7..56932a4 100644
> --- a/net/core/dev.c
> +++ b/net/core/dev.c
> @@ -3314,6 +3314,7 @@ int netdev_rx_handler_register(struct net_device *dev,
> if (dev->rx_handler)
> return -EBUSY;
>
> + /* Note: rx_handler_data must be set before rx_handler */
> rcu_assign_pointer(dev->rx_handler_data, rx_handler_data);
> rcu_assign_pointer(dev->rx_handler, rx_handler);
>
> @@ -3334,6 +3335,11 @@ void netdev_rx_handler_unregister(struct net_device *dev)
>
> ASSERT_RTNL();
> RCU_INIT_POINTER(dev->rx_handler, NULL);
> + /* a reader seeing a non NULL rx_handler in a rcu_read_lock()
> + * section has a guarantee to see a non NULL rx_handler_data
> + * as well.
> + */
> + synchronize_net();
> RCU_INIT_POINTER(dev->rx_handler_data, NULL);
> }
> EXPORT_SYMBOL_GPL(netdev_rx_handler_unregister);
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply
* Re: [PATCH 1/2 v3] usbnet: allow status interrupt URB to always be active
From: David Miller @ 2013-03-29 19:20 UTC (permalink / raw)
To: dcbw-H+wXaHxf7aLQT0dZR+AlfA
Cc: oliver-GvhC2dPhHPQdnm+yROfE0A,
epasheva-ywE8TTl5eJHWpu6QEFMNjNBPR1lH4CV8,
netdev-u79uwXL29TY76Z2rM5mHXA, linux-usb-u79uwXL29TY76Z2rM5mHXA,
rfiler-ywE8TTl5eJHWpu6QEFMNjNBPR1lH4CV8, phil-ydcDiazATMQ
In-Reply-To: <1364488207.1877.20.camel-wKZy7rqYPVb5EHUCmHmTqw@public.gmane.org>
From: Dan Williams <dcbw-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Date: Thu, 28 Mar 2013 11:30:07 -0500
> + if (test_bit (EVENT_DEV_ASLEEP, &dev->flags))
> + return -EINVAL;
> +
> + mutex_lock (&dev->interrupt_mutex);
Please do not put a space between a function name and the openning
parenthesis in the call.
These are not C language primitives (where the space would be
appropriate, f.e. "if (") they are C functions.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* Re: [PATCH 2/2 v3] sierra_net: keep status interrupt URB active
From: David Miller @ 2013-03-29 19:21 UTC (permalink / raw)
To: dcbw-H+wXaHxf7aLQT0dZR+AlfA
Cc: oliver-GvhC2dPhHPQdnm+yROfE0A,
epasheva-ywE8TTl5eJHWpu6QEFMNjNBPR1lH4CV8,
netdev-u79uwXL29TY76Z2rM5mHXA, linux-usb-u79uwXL29TY76Z2rM5mHXA,
rfiler-ywE8TTl5eJHWpu6QEFMNjNBPR1lH4CV8, phil-ydcDiazATMQ
In-Reply-To: <1364488327.1877.22.camel-wKZy7rqYPVb5EHUCmHmTqw@public.gmane.org>
Please respin this along with patch #1 when you fix the coding
style issues I mentioned, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* Re: [net-next PATCH 3/3] net: frag queue per hash bucket locking
From: David Miller @ 2013-03-29 19:22 UTC (permalink / raw)
To: brouer; +Cc: hannes, eric.dumazet, netdev, fw, dborkman
In-Reply-To: <1364583693.3232.257.camel@localhost>
From: Jesper Dangaard Brouer <brouer@redhat.com>
Date: Fri, 29 Mar 2013 20:01:33 +0100
> On Fri, 2013-03-29 at 01:33 +0100, Hannes Frederic Sowa wrote:
>> On Thu, Mar 28, 2013 at 04:39:42PM -0700, Eric Dumazet wrote:
>> > On Fri, 2013-03-29 at 00:30 +0100, Hannes Frederic Sowa wrote:
>> > > On Thu, Mar 28, 2013 at 01:22:44PM -0700, Eric Dumazet wrote:
>> > > > On Thu, 2013-03-28 at 19:57 +0100, Hannes Frederic Sowa wrote:
>> > > >
>> > > > > I assume that it has to do with the usage of this code in
>> > > > > ipv6/netfilter/nf_conntrack_reasm.c, which could be invoked from process
>> > > > > context, if I read it correctly.
>> > > >
>> > > > Then there would be a possible deadlock in current code.
>> > >
>> > > Netfilter currently does a local_bh_disable() before entering inet_fragment
>> > > (and later enables it, again).
>> > >
>> >
>> > Good, so no need for the _bh() as I suspected.
>>
>> Ack.
>>
>> I replaced the _bh spin_locks with plain spinlocks and tested the code
>> with sending fragments and receiving fragments (netfilter and reassmbly
>> logic) with lockdep and didn't get any splats. Looks good so far.
>
> Well, it's great to see, that you are working on solving my patch
> proposal. While I'm on Easter vacation ;-) Much appreciated.
> I'm officially back from vacation Tuesday, and I'll repost then (after
> testing it on my 10G testlab).
Jesper, when you do this, please just put the whole of the excellent
description text you had in the "0/3" posting from this series into
the commit message for the respun patch #3.
Thanks.
^ permalink raw reply
* Re: [PATCH net-next] ip_tunnel: Fix off-by-one error in forming dev name.
From: David Miller @ 2013-03-29 19:24 UTC (permalink / raw)
To: pshelar; +Cc: netdev, bhutchings
In-Reply-To: <1364494906-9818-1-git-send-email-pshelar@nicira.com>
From: Pravin B Shelar <pshelar@nicira.com>
Date: Thu, 28 Mar 2013 11:21:46 -0700
> As Ben pointed out following patch fixes bug in checking device
> name length limits while forming tunnel device name.
>
> CC: Ben Hutchings <bhutchings@solarflare.com>
> Signed-off-by: Pravin B Shelar <pshelar@nicira.com>
Applied, thanks.
^ permalink raw reply
* Re: [PATCH] net: core: Remove redundant call to 'nf_reset' in 'dev_forward_skb'
From: David Miller @ 2013-03-29 19:26 UTC (permalink / raw)
To: eric.dumazet; +Cc: shmulik.ladkani, greearb, netdev, rgohita
In-Reply-To: <1364584656.5113.55.camel@edumazet-glaptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Fri, 29 Mar 2013 12:17:36 -0700
> On Fri, 2013-03-29 at 15:11 -0400, David Miller wrote:
>> From: Shmulik Ladkani <shmulik.ladkani@gmail.com>
>> Date: Thu, 28 Mar 2013 11:13:26 +0200
>>
>> > 'nf_reset' is called just prior calling 'netif_rx'.
>> > No need to call it twice.
>> >
>> > Reported-by: Igor Michailov <rgohita@gmail.com>
>> > Signed-off-by: Shmulik Ladkani <shmulik.ladkani@gmail.com>
>>
>> I do not see this happening in the:
>>
>> macvlan_start_xmit()
>>
>> --> macvlan_queue_xmit()
>>
>> code path.
>>
>> I'm not applying this patch. There seems to be no real agreement
>> that the caller of dev_forward_skb() takes care of the nf_reset().
>>
>> And wouldn't it be better to consolidate the nf_reset() calls
>> into one place instead of several, increasing the audit burdon.
>>
>
> Hmm, I believe you misread this patch :
>
> nf_reset() is called _twice_ in dev_forward_skb()
Aha, that makes more sense, applied.
^ permalink raw reply
* Re: [PATCH] net: add a synchronize_net() in netdev_rx_handler_unregister()
From: Eric Dumazet @ 2013-03-29 19:26 UTC (permalink / raw)
To: paulmck
Cc: Jiri Pirko, Steven Rostedt, Andy Gospodarek, David S. Miller,
LKML, netdev, Nicolas de Pesloüan, Thomas Gleixner,
Guy Streeter, stephen
In-Reply-To: <20130329192011.GO3320@linux.vnet.ibm.com>
On Fri, 2013-03-29 at 12:20 -0700, Paul E. McKenney wrote:
> Reviewed-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
>
> With kudos to Steven Rostedt for his analogy between RCU and
> Schrödinger's cat. ;-)
Thanks Paul !
^ permalink raw reply
* Re: [net-next PATCH] net: rtnetlink: fdb dflt dump must set idx used for cb->arg[0]
From: David Miller @ 2013-03-29 19:27 UTC (permalink / raw)
To: john.fastabend; +Cc: netdev, vyasevich
In-Reply-To: <20130329181831.9902.70451.stgit@nitbit.x32>
From: John Fastabend <john.fastabend@gmail.com>
Date: Fri, 29 Mar 2013 11:18:37 -0700
> In rtnl_fdb_dump() when the fdb_dump ndo op is not populated
> we never set the idx value so that cb->arg[0] is always 0.
> Resulting in a endless loop of messages.
>
> Introduced with this commit,
>
> commit 090096bf3db1c281ddd034573260045888a68fea
> Author: Vlad Yasevich <vyasevic@redhat.com>
> Date: Wed Mar 6 15:39:42 2013 +0000
>
> net: generic fdb support for drivers without ndo_fdb_<op>
>
> CC: Vlad Yasevich <vyasevic@redhat.com>
> Signed-off-by: John Fastabend <john.r.fastabend@intel.com>
Applied, thanks John.
^ permalink raw reply
* Re: [PATCH 1/2] net: calxedaxgmac: fix rx ring handling when OOM
From: David Miller @ 2013-03-29 19:29 UTC (permalink / raw)
To: robherring2; +Cc: linux-kernel, netdev, rob.herring
In-Reply-To: <1364506365-13689-1-git-send-email-robherring2@gmail.com>
From: Rob Herring <robherring2@gmail.com>
Date: Thu, 28 Mar 2013 16:32:44 -0500
> From: Rob Herring <rob.herring@calxeda.com>
>
> If skb allocation for the rx ring fails repeatedly, we can reach a point
> were the ring is empty. In this condition, the driver is out of sync with
> the h/w. While this has always been possible, the removal of the skb
> recycling seems to have made triggering this problem easier.
>
> Signed-off-by: Rob Herring <rob.herring@calxeda.com>
Applied.
^ permalink raw reply
* Re: [PATCH 2/2] net: calxedaxgmac: Wake-on-LAN fixes
From: David Miller @ 2013-03-29 19:30 UTC (permalink / raw)
To: robherring2; +Cc: linux-kernel, netdev, rob.herring
In-Reply-To: <1364506365-13689-2-git-send-email-robherring2@gmail.com>
From: Rob Herring <robherring2@gmail.com>
Date: Thu, 28 Mar 2013 16:32:45 -0500
> From: Rob Herring <rob.herring@calxeda.com>
>
> WOL is broken because the magic packet status bit is getting set rather
> than the enable bit. The PMT interrupt is not getting serviced because
> the PMT interrupt is also enabled on the global interrupt, but not
> cleared by the global interrupt and the global interrupt is higher
> priority. This fixes both of these issues to get WOL working.
>
> There's still a problem with receive after resume, but at least now we
> can wake-up.
>
> Signed-off-by: Rob Herring <rob.herring@calxeda.com>
Applied.
^ permalink raw reply
* Re: [PATCH 1/2] sh_eth: move data from header file to driver
From: David Miller @ 2013-03-29 19:31 UTC (permalink / raw)
To: sergei.shtylyov; +Cc: netdev, nobuhiro.iwamatsu.yj, linux-sh
In-Reply-To: <201303290048.27020.sergei.shtylyov@cogentembedded.com>
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Date: Fri, 29 Mar 2013 00:48:26 +0300
> The driver's header file contains initialized register offset tables which (as
> any data definitions), of course, have no business being there. Move them to
> the driver's body, somewhat beautifying the initializers, while at it...
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Applied.
^ permalink raw reply
* Re: [PATCH 2/2] sh_eth: add R-Car support for real
From: David Miller @ 2013-03-29 19:31 UTC (permalink / raw)
To: sergei.shtylyov; +Cc: netdev, nobuhiro.iwamatsu.yj, linux-sh, phil.edworthy
In-Reply-To: <201303290051.32106.sergei.shtylyov@cogentembedded.com>
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Date: Fri, 29 Mar 2013 00:51:31 +0300
> Commit d0418bb7123f44b23d69ac349eec7daf9103472f (net: sh_eth: Add eth support
> for R8A7779 device) was a failed attempt to add support for one of members of
> the R-Car SoC family. That's for three reasons: it treated R8A7779 the same
> as SH7724 except including quite dirty hack adding ECMR_ELB bit to the mask
> in sh_eth_set_rate() while not removing ECMR_RTM bit (despite it's reserved in
> R-Car Ether), and it didn't add a new register offset array despite the closest
> SH_ETH_REG_FAST_SH4 mapping differs by 0x200 to the offsets all the R-Car Ether
> registers have, and also some of the registers in this old mapping don't exist
> on R-Car Ether (due to this, SH7724's 'sh_eth_my_cpu_data' structure is not
> adequeate for R-Car too). Fix all these shortcomings, restoring the SH7724
> related section to its pristine state...
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Applied.
^ permalink raw reply
* Re: [PATCH net] net: fq_codel: Fix off-by-one error
From: David Miller @ 2013-03-29 19:33 UTC (permalink / raw)
To: eric.dumazet; +Cc: subramanian.vijay, netdev
In-Reply-To: <1364569280.5113.21.camel@edumazet-glaptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Fri, 29 Mar 2013 08:01:20 -0700
> On Thu, 2013-03-28 at 16:52 -0700, Vijay Subramanian wrote:
>> Currently, we hold a max of sch->limit -1 number of packets instead of
>> sch->limit packets. Fix this off-by-one error.
>>
>> Signed-off-by: Vijay Subramanian <subramanian.vijay@gmail.com>
...
> Acked-by: Eric Dumazet <edumazet@google.com>
Applied and queued up for -stable.
^ permalink raw reply
* Re: [PATCH v2] include/linux: printk is needed in filter.h when CONFIG_BPF_JIT is defined
From: David Miller @ 2013-03-29 19:34 UTC (permalink / raw)
To: gang.chen; +Cc: edumazet, dborkman, wad, eparis, netdev
In-Reply-To: <5154ED65.5090607@asianux.com>
From: Chen Gang <gang.chen@asianux.com>
Date: Fri, 29 Mar 2013 09:24:53 +0800
>
> for make V=1 EXTRA_CFLAGS=-W ARCH=arm allmodconfig
> printk is need when CONFIG_BPF_JIT is defined
> or it will report pr_err and print_hex_dump are implicit declaration
>
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
There are no references to pr_err nor print_hex_dump in this
filter.h header file.
I think the issue is more like that the ARM bpf jit code uses
those routines, and therefore the ARM bpf jit code is what needs
to add these includes.
I'm not applying this patch, it isn't correct.
^ permalink raw reply
* Re: [PATCH net] atl1e: drop pci-msi support because of packet corruption
From: David Miller @ 2013-03-29 19:35 UTC (permalink / raw)
To: hannes; +Cc: netdev, rebelyouth.hacklab, xiong, christian.suenkenberg, sven
In-Reply-To: <20130329041050.GA29040@order.stressinduktion.org>
From: Hannes Frederic Sowa <hannes@stressinduktion.org>
Date: Fri, 29 Mar 2013 05:10:50 +0100
> Usage of pci-msi results in corrupted dma packet transfers to the host.
>
> Reported-by: rebelyouth <rebelyouth.hacklab@gmail.com>
> Cc: Huang, Xiong <xiong@qca.qualcomm.com>
> Tested-by: Christian Sünkenberg <christian.suenkenberg@student.kit.edu>
> Signed-off-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
Applied and queued up for -stable, thanks.
^ permalink raw reply
* Re: [PATCH net-next 1/1] MAINTAINERS: Update netxen_nic maintainers list
From: David Miller @ 2013-03-29 19:36 UTC (permalink / raw)
To: manish.chopra; +Cc: netdev, Dept_NX_Linux_NIC_Driver
In-Reply-To: <1364550848-30558-1-git-send-email-manish.chopra@qlogic.com>
From: Manish Chopra <manish.chopra@qlogic.com>
Date: Fri, 29 Mar 2013 05:54:08 -0400
> o Add myself to netxen_nic maintainers list
>
> Signed-off-by: Manish Chopra <manish.chopra@qlogic.com>
I've applied this to 'net', thanks.
^ permalink raw reply
* Re: [PATCH] net: add a synchronize_net() in netdev_rx_handler_unregister()
From: David Miller @ 2013-03-29 19:39 UTC (permalink / raw)
To: paulmck
Cc: eric.dumazet, jpirko, rostedt, andy, linux-kernel, netdev,
nicolas.2p.debian, tglx, streeter, stephen
In-Reply-To: <20130329192011.GO3320@linux.vnet.ibm.com>
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Date: Fri, 29 Mar 2013 12:20:11 -0700
> On Fri, Mar 29, 2013 at 06:01:22AM -0700, Eric Dumazet wrote:
>> [PATCH] net: add a synchronize_net() in netdev_rx_handler_unregister()
>>
>> commit 35d48903e97819 (bonding: fix rx_handler locking) added a race
>> in bonding driver, reported by Steven Rostedt who did a very good
>> diagnosis :
...
>> We can fix bug this in two ways. First is adding a test in
>> bond_handle_frame() and others to check if rx_handler_data is NULL.
>>
>> A second way is adding a synchronize_net() in
>> netdev_rx_handler_unregister() to make sure that a rcu protected reader
>> has the guarantee to see a non NULL rx_handler_data.
>>
>> The second way is better as it avoids an extra test in fast path.
>>
>> Reported-by: Steven Rostedt <rostedt@goodmis.org>
>> Signed-off-by: Eric Dumazet <edumazet@google.com>
>> Cc: Jiri Pirko <jpirko@redhat.com>
>> Cc: Paul E. McKenney <paulmck@us.ibm.com>
>
> Reviewed-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
>
> With kudos to Steven Rostedt for his analogy between RCU and
> Schrödinger's cat. ;-)
Applied and queued up for -stable, thanks Everyone.
^ permalink raw reply
* Re: [PATCH] cirrus: cs89x0: remove two obsolete Kconfig macros
From: David Miller @ 2013-03-29 19:40 UTC (permalink / raw)
To: pebolle; +Cc: netdev, linux-kernel
In-Reply-To: <1364554290.1345.52.camel@x61.thuisdomein>
From: Paul Bolle <pebolle@tiscali.nl>
Date: Fri, 29 Mar 2013 11:51:30 +0100
> The CONFIG_ARCH_IXDP2X01 and CONFIG_MACH_IXDP2351 Kconfig macros are
> unused since the ixp23xx and ixp2000 platforms were removed in v3.5. So
> remove the last code still depending on these macros. And since
> CS89x0_NONISA_IRQ was only set if either of these two macros was defined
> we can also remove that macro and the code depending on it.
>
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
Applied, thanks Paul.
^ permalink raw reply
* Re: Bug in ks8851.c
From: David Miller @ 2013-03-29 19:43 UTC (permalink / raw)
To: Max.Nekludov
Cc: kda, gerg, jiri, linus971, linux-arm-kernel, linux-kernel, mjr,
netdev, sboyd, torvalds
In-Reply-To: <OF95B2AB6A.BE754AB4-ON44257B3D.00544464-44257B3D.0054ECCB@gb.elster.com>
From: Max.Nekludov@us.elster.com
Date: Fri, 29 Mar 2013 19:27:36 +0400
> Denis,
> here is patch with commit message:
>
> Subject: [PATCH] Fix bug in ks8851 driver
>
> According to the Datasheet (page 52):
> 15-12 Reserved
> 11-0 RXBC Receive Byte Count
> This field indicates the present received frame byte size.
>
> The code has a bug:
> rxh = ks8851_rdreg32(ks, KS_RXFHSR);
> rxstat = rxh & 0xffff;
> rxlen = rxh >> 16; // BUG!!! 0xFFF mask should be applied
>
> Signed-off-by: Max Nekludov <Max.Nekludov@us.elster.com>
Applied and queued up for -stable, thanks.
^ permalink raw reply
* Re: [PATCH net-next 0/7] SR-IOV support for QLogic 83xx series
From: David Miller @ 2013-03-29 19:51 UTC (permalink / raw)
To: rajesh.borundia; +Cc: netdev, Dept_NX_Linux_NIC_Driver
In-Reply-To: <1364571999-31593-1-git-send-email-rajesh.borundia@qlogic.com>
From: Rajesh Borundia <rajesh.borundia@qlogic.com>
Date: Fri, 29 Mar 2013 11:46:32 -0400
> Patch series to add SR-IOV support in qlcnic driver for 83xx series adapters.
> Please apply it to net-next.
Series applied, thanks.
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox