* [PATCH net-next V2 1/5] net/mlx4_en: Coding style cleanup in mlx4_en_dcbnl_ieee_setpfc()
From: Amir Vadai @ 2013-08-21 7:08 UTC (permalink / raw)
To: David S. Miller; +Cc: netdev, Amir Vadai
In-Reply-To: <1377068939-17561-1-git-send-email-amirv@mellanox.com>
Fix some coding style issues in this function.
Signed-off-by: Amir Vadai <amirv@mellanox.com>
---
drivers/net/ethernet/mellanox/mlx4/en_dcb_nl.c | 15 +++++++++------
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/drivers/net/ethernet/mellanox/mlx4/en_dcb_nl.c b/drivers/net/ethernet/mellanox/mlx4/en_dcb_nl.c
index 9d4a1ea..f71fba9 100644
--- a/drivers/net/ethernet/mellanox/mlx4/en_dcb_nl.c
+++ b/drivers/net/ethernet/mellanox/mlx4/en_dcb_nl.c
@@ -160,6 +160,7 @@ static int mlx4_en_dcbnl_ieee_setpfc(struct net_device *dev,
struct ieee_pfc *pfc)
{
struct mlx4_en_priv *priv = netdev_priv(dev);
+ struct mlx4_en_port_profile *prof = priv->prof;
struct mlx4_en_dev *mdev = priv->mdev;
int err;
@@ -169,15 +170,17 @@ static int mlx4_en_dcbnl_ieee_setpfc(struct net_device *dev,
pfc->mbc,
pfc->delay);
- priv->prof->rx_pause = priv->prof->tx_pause = !!pfc->pfc_en;
- priv->prof->rx_ppp = priv->prof->tx_ppp = pfc->pfc_en;
+ prof->rx_pause = !!pfc->pfc_en;
+ prof->tx_pause = !!pfc->pfc_en;
+ prof->rx_ppp = pfc->pfc_en;
+ prof->tx_ppp = pfc->pfc_en;
err = mlx4_SET_PORT_general(mdev->dev, priv->port,
priv->rx_skb_size + ETH_FCS_LEN,
- priv->prof->tx_pause,
- priv->prof->tx_ppp,
- priv->prof->rx_pause,
- priv->prof->rx_ppp);
+ prof->tx_pause,
+ prof->tx_ppp,
+ prof->rx_pause,
+ prof->rx_ppp);
if (err)
en_err(priv, "Failed setting pause params\n");
--
1.8.3.4
^ permalink raw reply related
* [PATCH net-next V2 0/5] Mellanox driver updates 2013-08-19
From: Amir Vadai @ 2013-08-21 7:08 UTC (permalink / raw)
To: David S. Miller; +Cc: netdev, Amir Vadai
Hi Dave,
This small patchset contains 2 fixes to bad handling of error flows in TX
datapath, and a fix to a bug in mlx4_en_dcbnl_ieee_setpfc() where global pause
frames were enabled whenever PFC was configured.
Also added a patch to reduce the scope of some local variables in the moved
block of code and it's surrounding.
Thanks,
Amir
---
Changes from V1:
- Split coding style fix from logical fix
Changes from V0:
- Missing new lines + typo's
- Fixed frags dma leak
- Use local for ddev
- New patch (4/4), to reduce scope of some locals
Amir Vadai (4):
net/mlx4_en: Coding style cleanup in mlx4_en_dcbnl_ieee_setpfc()
net/mlx4_en: Notify user when TX ring in error state
net/mlx4_en: Fix handling of dma_map failure
net/mlx4_en: Reduce scope of local variables in mlx4_en_xmit
Eugenia Emantayev (1):
net/mlx4_en: Disable global flow control when PFC enabled
drivers/net/ethernet/mellanox/mlx4/en_dcb_nl.c | 15 ++--
drivers/net/ethernet/mellanox/mlx4/en_tx.c | 116 +++++++++++++++++--------
2 files changed, 87 insertions(+), 44 deletions(-)
--
1.8.3.4
^ permalink raw reply
* Re: [PATCH] netns: unix: only allow to find out unix socket in same net namespace
From: Eric W. Biederman @ 2013-08-21 7:06 UTC (permalink / raw)
To: Gao feng
Cc: systemd-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
libvir-list-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA, Linux Containers,
lxc-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f,
davem-fT/PcQaiUtIeIZ0/mPfg9Q
In-Reply-To: <5214641C.9030902-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
Gao feng <gaofeng-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org> writes:
> cc libvirt-list
>
> On 08/21/2013 01:30 PM, Eric W. Biederman wrote:
>> Gao feng <gaofeng-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org> writes:
>>
>>> Unix sockets are private resources of net namespace,
>>> allowing one net namespace to access to other netns's unix
>>> sockets is meaningless.
>>
>> Allowing one net namespace to access another netns's unix socket is
>> deliberate behavior. This is a desired and useful feature, and
>> only a misconfiguration of visible files would allow this to be a
>> problem.
>>
>>> I'm researching a problem about shutdown from container,
>>> if the cotainer shares the same file /run/systemd/private
>>> with host, when we run shutdown -h xxx in container, the
>>> shutdown message will be send to the systemd-shutdownd
>>> through unix socket /run/systemd/private, and because
>>> systemd-shutdownd is running in host, so finally, the host
>>> will become shutdown.
>>
>> The simple answer is don't do that then. I can see no reason
>> to share /run outside of the container unless you want this kind of
>> behavior.
>>
>> Quite frankly I want this behavior if I am using network namespaces
>> to support multiple routing contexts. That is if I am using scripts
>> like:
>>
>> ip netns add other
>> ip netns exec other script
>>
>> I don't want to have to remember to say
>> ip netns orig exec shutdown -h now
>>
>> There are more compelling uses and there is no cost in supporting this
>> in the kernel.
>>
>> What kind of misconfiguration caused someone to complain about this?
>>
>
> libvirt lxc allows user to set up a container which shares the same root
> directory with host.
>
> seems like the unix sockets whose sun_path is an abstract socket address
> are net namespace aware.
>
> Should we use "abstract" type of address instead of a file system pathname
> for systemd in this case?
I suspect libvirt should simply not share /run or any other normally
writable directory with the host. Sharing /run /var/run or even /tmp
seems extremely dubious if you want some kind of containment, and
without strange things spilling through.
Eric
^ permalink raw reply
* Re: [PATCH (net.git) 2/2] stmmac: remove useless csum flag
From: David Miller @ 2013-08-21 7:06 UTC (permalink / raw)
To: peppe.cavallaro; +Cc: netdev, sonic.zhang
In-Reply-To: <1377062908-16543-2-git-send-email-peppe.cavallaro@st.com>
From: Giuseppe CAVALLARO <peppe.cavallaro@st.com>
Date: Wed, 21 Aug 2013 07:28:28 +0200
> This patch removes the no_csum_insertion private parameter that is not used anymore
> and, also, the "likely" annotation from the condition that is not in a critical path.
>
> Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@st.com>
This is absolutely just a cleanup and therefore not suitable for 'net',
resubmit your changes targetted to the correct tree, 'net-next'.
Thank you.
^ permalink raw reply
* Re: [PATCH v2 2/2] net: netem: always adjust now/delay when not reordering
From: Ferry Huberts @ 2013-08-21 7:04 UTC (permalink / raw)
To: Eric Dumazet; +Cc: netdev
In-Reply-To: <1377065647.4226.96.camel@edumazet-glaptop>
On 21/08/13 08:14, Eric Dumazet wrote:
> On Wed, 2013-08-21 at 07:59 +0200, Ferry Huberts wrote:
>> From: Ferry Huberts <ferry.huberts@pelagic.nl>
>>
>> Not doing this (current behaviour) introduces reordering.
>>
>> The packet_len_2_sched_time call is the only thing that logically
>> depends on q->rate, so move the now/delay adjustment out of the if.
>>
>> How to test:
>> -----------
>
> I ask again :
>
> Did you test a config with both rate limiting and delay.
(sorry for missing that question)
Just did so and with rate limiting I get no reordering, which is logical
looking at the code.
The thing is, the evaluation q->rate is within the 'no-reordering' block
and in the current situation you can get reordering (with that 'strange'
command). My patch makes sure that no reordering will occur, and
effectively 'clamps' the realised delay, which currently isn't done.
>
> Netem primary use is to emulate say a 1Mbits link with a rtt of 50ms
>
> netem rate 1Mbit delay 50ms
>
>
> Because the "delay 10ms 500ms" is very strange : effective delay is in
> the following range : -490 ms ... 510 ms
>
> Its probably clamped to 0ms ... 510ms
Currently it isn't. With my patch it's 'clamped' in the sense that if
the calculated delay would make the packet be scheduled before the
previous one, that the delay of the current packet is adjusted so that
it's scheduled right after the previous one.
>
> I really doubt this is what you wanted.
It's the command Teco showed me to test/reproduce it.
--
Ferry Huberts
^ permalink raw reply
* Re: [PATCH v6] net/phy: micrel: Add OF configuration support for ksz9021
From: David Miller @ 2013-08-21 7:04 UTC (permalink / raw)
To: xobs; +Cc: s.hauer, B38611, netdev, devicetree, stephen, rostedt
In-Reply-To: <1377049572-30752-2-git-send-email-xobs@kosagi.com>
From: Sean Cross <xobs@kosagi.com>
Date: Wed, 21 Aug 2013 01:46:12 +0000
> Some boards require custom PHY configuration, for example due to trace
> length differences. Add the ability to configure these registers in
> order to get the PHY to function on boards that need it.
>
> Because PHYs are auto-detected based on MDIO device IDs, allow PHY
> configuration to be specified in the parent Ethernet device node if no
> PHY device node is present.
>
> Signed-off-by: Sean Cross <xobs@kosagi.com>
Applied to net-next, thanks.
^ permalink raw reply
* Re: [PATCH] VMXNET3: Add support for virtual IOMMU
From: David Miller @ 2013-08-21 7:02 UTC (permalink / raw)
To: acking; +Cc: pv-drivers, netdev, linux-kernel, virtualization
In-Reply-To: <1377020012-1839-1-git-send-email-acking@vmware.com>
From: Andy King <acking@vmware.com>
Date: Tue, 20 Aug 2013 10:33:32 -0700
> We can't just do virt_to_phys() on memory that we pass to the device and
> expect it to work in presence of a virtual IOMMU. We need to add IOMMU
> mappings for such DMAs to work correctly. Fix that with
> pci_alloc_consistent() where possible, or pci_map_single() where the
> mapping is short-lived or we don't control the allocation (netdev).
>
> Also fix two small bugs:
> 1) use after free of rq->buf_info in vmxnet3_rq_destroy()
> 2) a cpu_to_le32() that should have been a cpu_to_le64()
>
> Acked-by: George Zhang <georgezhang@vmware.com>
> Acked-by: Aditya Sarwade <asarwade@vmware.com>
> Signed-off-by: Andy King <acking@vmware.com>
Please use dma_alloc_coherent() (or in fact dma_zalloc_coherent()),
dma_map_single() et al., because they are preferred and in particular
allow specification of GFP_* flags.
^ permalink raw reply
* [PATCH 8/8] net: emac: remove unnecessary dev_set_drvdata()
From: Libo Chen @ 2013-08-21 7:02 UTC (permalink / raw)
To: davem; +Cc: gregkh, wfp5p, jiri, netdev, linux-kernel, lizefan, libo.chen
Unnecessary dev_set_drvdata() is removed, because the driver core
clears the driver data to NULL after device_release or on probe failure.
Signed-off-by: Libo Chen <libo.chen@huawei.com>
---
drivers/net/ethernet/ibm/emac/core.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/ibm/emac/core.c b/drivers/net/ethernet/ibm/emac/core.c
index d300a0c..2d3b064 100644
--- a/drivers/net/ethernet/ibm/emac/core.c
+++ b/drivers/net/ethernet/ibm/emac/core.c
@@ -2955,8 +2955,6 @@ static int emac_remove(struct platform_device *ofdev)
DBG(dev, "remove" NL);
- dev_set_drvdata(&ofdev->dev, NULL);
-
unregister_netdev(dev->ndev);
cancel_work_sync(&dev->reset_work);
--
1.7.1
^ permalink raw reply related
* [PATCH 7/8] net: davinci_mdio: remove unnecessary dev_set_drvdata()
From: Libo Chen @ 2013-08-21 7:02 UTC (permalink / raw)
To: davem
Cc: mugunthanvnm, bigeasy, prabhakar.csengg, netdev, linux-kernel,
lizefan, libo.chen
Unnecessary dev_set_drvdata() is removed, because the driver core
clears the driver data to NULL after device_release or on probe failure.
Signed-off-by: Libo Chen <libo.chen@huawei.com>
---
drivers/net/ethernet/ti/davinci_mdio.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/ti/davinci_mdio.c b/drivers/net/ethernet/ti/davinci_mdio.c
index 01b0cc5..7f85143 100644
--- a/drivers/net/ethernet/ti/davinci_mdio.c
+++ b/drivers/net/ethernet/ti/davinci_mdio.c
@@ -433,8 +433,6 @@ static int davinci_mdio_remove(struct platform_device *pdev)
pm_runtime_put_sync(&pdev->dev);
pm_runtime_disable(&pdev->dev);
- dev_set_drvdata(dev, NULL);
-
kfree(data);
return 0;
--
1.7.1
^ permalink raw reply related
* [PATCH 6/8] net: xilinx_emaclite: remove unnecessary dev_set_drvdata()
From: Libo Chen @ 2013-08-21 7:02 UTC (permalink / raw)
To: davem
Cc: michal.simek, renner, gregkh, netdev, linux-kernel, lizefan,
libo.chen
Unnecessary dev_set_drvdata() is removed, because the driver core
clears the driver data to NULL after device_release or on probe failure.
Signed-off-by: Libo Chen <libo.chen@huawei.com>
---
drivers/net/ethernet/xilinx/xilinx_emaclite.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ethernet/xilinx/xilinx_emaclite.c b/drivers/net/ethernet/xilinx/xilinx_emaclite.c
index 7c1ccbc..4c619ea 100644
--- a/drivers/net/ethernet/xilinx/xilinx_emaclite.c
+++ b/drivers/net/ethernet/xilinx/xilinx_emaclite.c
@@ -1249,7 +1249,6 @@ static int xemaclite_of_remove(struct platform_device *of_dev)
lp->phy_node = NULL;
xemaclite_remove_ndev(ndev, of_dev);
- dev_set_drvdata(dev, NULL);
return 0;
}
--
1.7.1
^ permalink raw reply related
* [PATCH 5/8] net: sunhme: remove unnecessary dev_set_drvdata()
From: Libo Chen @ 2013-08-21 7:02 UTC (permalink / raw)
To: davem; +Cc: gregkh, jg1.han, wfp5p, netdev, linux-kernel, lizefan, libo.chen
Unnecessary dev_set_drvdata() is removed, because the driver core
clears the driver data to NULL after device_release or on probe failure.
Signed-off-by: Libo Chen <libo.chen@huawei.com>
---
drivers/net/ethernet/sun/sunhme.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/sun/sunhme.c b/drivers/net/ethernet/sun/sunhme.c
index b90d311..c67e683 100644
--- a/drivers/net/ethernet/sun/sunhme.c
+++ b/drivers/net/ethernet/sun/sunhme.c
@@ -3250,8 +3250,6 @@ static int hme_sbus_remove(struct platform_device *op)
free_netdev(net_dev);
- dev_set_drvdata(&op->dev, NULL);
-
return 0;
}
--
1.7.1
^ permalink raw reply related
* [PATCH 4/8] net: sunbmac: remove unnecessary dev_set_drvdata()
From: Libo Chen @ 2013-08-21 7:02 UTC (permalink / raw)
To: davem; +Cc: emilio, gregkh, wfp5p, netdev, linux-kernel, lizefan, libo.chen
Unnecessary dev_set_drvdata() is removed, because the driver core
clears the driver data to NULL after device_release or on probe failure.
Signed-off-by: Libo Chen <libo.chen@huawei.com>
---
drivers/net/ethernet/sun/sunbmac.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/sun/sunbmac.c b/drivers/net/ethernet/sun/sunbmac.c
index 0a32ca5..7217ee5 100644
--- a/drivers/net/ethernet/sun/sunbmac.c
+++ b/drivers/net/ethernet/sun/sunbmac.c
@@ -1259,8 +1259,6 @@ static int bigmac_sbus_remove(struct platform_device *op)
free_netdev(net_dev);
- dev_set_drvdata(&op->dev, NULL);
-
return 0;
}
--
1.7.1
^ permalink raw reply related
* [PATCH 3/8] net: fec_mpc52xx_phy: remove unnecessary dev_set_drvdata()
From: Libo Chen @ 2013-08-21 7:02 UTC (permalink / raw)
To: davem; +Cc: netdev, linux-kernel, lizefan, libo.chen
Unnecessary dev_set_drvdata() is removed, because the driver core
clears the driver data to NULL after device_release or on probe failure.
Signed-off-by: Libo Chen <libo.chen@huawei.com>
---
drivers/net/ethernet/freescale/fec_mpc52xx_phy.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fec_mpc52xx_phy.c b/drivers/net/ethernet/freescale/fec_mpc52xx_phy.c
index eb44797..e052890 100644
--- a/drivers/net/ethernet/freescale/fec_mpc52xx_phy.c
+++ b/drivers/net/ethernet/freescale/fec_mpc52xx_phy.c
@@ -127,7 +127,6 @@ static int mpc52xx_fec_mdio_remove(struct platform_device *of)
struct mpc52xx_fec_mdio_priv *priv = bus->priv;
mdiobus_unregister(bus);
- dev_set_drvdata(dev, NULL);
iounmap(priv->regs);
kfree(priv);
mdiobus_free(bus);
--
1.7.1
^ permalink raw reply related
* [PATCH 2/8] net: ucc_geth: remove unnecessary dev_set_drvdata()
From: Libo Chen @ 2013-08-21 7:02 UTC (permalink / raw)
To: davem; +Cc: leoli, netdev, linuxppc-dev, linux-kernel, lizefan, libo.chen
Unnecessary dev_set_drvdata() is removed, because the driver core
clears the driver data to NULL after device_release or on probe failure.
Signed-off-by: Libo Chen <libo.chen@huawei.com>
---
drivers/net/ethernet/freescale/ucc_geth.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ethernet/freescale/ucc_geth.c b/drivers/net/ethernet/freescale/ucc_geth.c
index 533885c..5930c39 100644
--- a/drivers/net/ethernet/freescale/ucc_geth.c
+++ b/drivers/net/ethernet/freescale/ucc_geth.c
@@ -3917,7 +3917,6 @@ static int ucc_geth_remove(struct platform_device* ofdev)
unregister_netdev(dev);
free_netdev(dev);
ucc_geth_memclean(ugeth);
- dev_set_drvdata(device, NULL);
return 0;
}
--
1.7.1
^ permalink raw reply related
* [PATCH 1/8] net: fsl_pq_mdio: remove unnecessary dev_set_drvdata()
From: Libo Chen @ 2013-08-21 7:02 UTC (permalink / raw)
To: davem; +Cc: timur, netdev, linux-kernel, lizefan, libo.chen
Unnecessary dev_set_drvdata() is removed, because the driver core
clears the driver data to NULL after device_release or on probe failure.
Signed-off-by: Libo Chen <libo.chen@huawei.com>
---
drivers/net/ethernet/freescale/fsl_pq_mdio.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fsl_pq_mdio.c b/drivers/net/ethernet/freescale/fsl_pq_mdio.c
index b7dcd41..c4f6506 100644
--- a/drivers/net/ethernet/freescale/fsl_pq_mdio.c
+++ b/drivers/net/ethernet/freescale/fsl_pq_mdio.c
@@ -468,8 +468,6 @@ static int fsl_pq_mdio_remove(struct platform_device *pdev)
mdiobus_unregister(bus);
- dev_set_drvdata(device, NULL);
-
iounmap(priv->map);
mdiobus_free(bus);
--
1.7.1
^ permalink raw reply related
* Re: [PATCH] netns: unix: only allow to find out unix socket in same net namespace
From: Gao feng @ 2013-08-21 6:54 UTC (permalink / raw)
To: Eric W. Biederman
Cc: systemd-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
libvir-list-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA, Linux Containers,
lxc-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f,
davem-fT/PcQaiUtIeIZ0/mPfg9Q
In-Reply-To: <87d2p7vcdx.fsf-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
cc libvirt-list
On 08/21/2013 01:30 PM, Eric W. Biederman wrote:
> Gao feng <gaofeng-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org> writes:
>
>> Unix sockets are private resources of net namespace,
>> allowing one net namespace to access to other netns's unix
>> sockets is meaningless.
>
> Allowing one net namespace to access another netns's unix socket is
> deliberate behavior. This is a desired and useful feature, and
> only a misconfiguration of visible files would allow this to be a
> problem.
>
>> I'm researching a problem about shutdown from container,
>> if the cotainer shares the same file /run/systemd/private
>> with host, when we run shutdown -h xxx in container, the
>> shutdown message will be send to the systemd-shutdownd
>> through unix socket /run/systemd/private, and because
>> systemd-shutdownd is running in host, so finally, the host
>> will become shutdown.
>
> The simple answer is don't do that then. I can see no reason
> to share /run outside of the container unless you want this kind of
> behavior.
>
> Quite frankly I want this behavior if I am using network namespaces
> to support multiple routing contexts. That is if I am using scripts
> like:
>
> ip netns add other
> ip netns exec other script
>
> I don't want to have to remember to say
> ip netns orig exec shutdown -h now
>
> There are more compelling uses and there is no cost in supporting this
> in the kernel.
>
> What kind of misconfiguration caused someone to complain about this?
>
libvirt lxc allows user to set up a container which shares the same root
directory with host.
seems like the unix sockets whose sun_path is an abstract socket address
are net namespace aware.
Should we use "abstract" type of address instead of a file system pathname
for systemd in this case?
^ permalink raw reply
* Re: [PATCH net-next 0/3] Minor ipv6 mcast cleanups
From: David Miller @ 2013-08-21 6:53 UTC (permalink / raw)
To: dborkman; +Cc: netdev, hannes
In-Reply-To: <1376994122-3022-1-git-send-email-dborkman@redhat.com>
From: Daniel Borkmann <dborkman@redhat.com>
Date: Tue, 20 Aug 2013 12:21:59 +0200
> Daniel Borkmann (3):
> net: ipv6: igmp6_event_query: use msecs_to_jiffies
> net: ipv6: minor: *_start_timer: rather use unsigned long
> net: ipv6: mcast: minor: use defines for rfc3810/8.1 lengths
All applied, thanks Daniel.
^ permalink raw reply
* Re: [PATCH net-next v4] net: cpsw: Add support for wake-on-lan for cpsw
From: David Miller @ 2013-08-21 6:50 UTC (permalink / raw)
To: ujhelyi.m; +Cc: mugunthanvnm, netdev, linux-kernel
In-Reply-To: <1376978378-26096-1-git-send-email-ujhelyi.m@gmail.com>
From: ujhelyi.m@gmail.com
Date: Tue, 20 Aug 2013 07:59:38 +0200
> From: Matus Ujhelyi <ujhelyi.m@gmail.com>
>
> Some phy's can be configured to enable wake on lan (e.g. at803x or marvell 88E1318S).
> There is no way how to enable wol on CPSW with such connected phys. This patch
> adds this support. It is provided by calling the phy's related code.
>
> Tested on board with at8030x connected phy. Wol interrupt line is
> connected to GPIO0 on am335x.
>
> Signed-off-by: Matus Ujhelyi <ujhelyi.m@gmail.com>
Applied.
^ permalink raw reply
* Re: [net-next PATCH 1/1] drivers: net: cpsw: remove platform data header file of cpsw
From: David Miller @ 2013-08-21 6:50 UTC (permalink / raw)
To: mugunthanvnm; +Cc: netdev
In-Reply-To: <1376914660-20431-1-git-send-email-mugunthanvnm@ti.com>
From: Mugunthan V N <mugunthanvnm@ti.com>
Date: Mon, 19 Aug 2013 17:47:40 +0530
> CPSW driver no longer supports platform register as all the SoCs which has CPSW
> are supporting DT only booting, so moving cpsw.h header file from platform
> include to drivers/net/ethernet/ti
>
> Signed-off-by: Mugunthan V N <mugunthanvnm@ti.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next] ip6_tunnel: ensure to always have a link local address
From: David Miller @ 2013-08-21 6:48 UTC (permalink / raw)
To: nicolas.dichtel; +Cc: netdev, yoshfuji
In-Reply-To: <1376993766-5723-1-git-send-email-nicolas.dichtel@6wind.com>
From: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Date: Tue, 20 Aug 2013 12:16:06 +0200
> When an Xin6 tunnel is set up, we check other netdevices to inherit the link-
> local address. If none is available, the interface will not have any link-local
> address. RFC4862 expects that each interface has a link local address.
>
> Now than this kind of tunnels supports x-netns, it's easy to fall in this case
> (by creating the tunnel in a netns where ethernet interfaces stand and then
> moving it to a other netns where no ethernet interface is available).
>
> RFC4291, Appendix A suggests two methods: the first is the one currently
> implemented, the second is to generate a unique identifier, so that we can
> always generate the link-local address. Let's use eth_random_addr() to generate
> this interface indentifier.
>
> I remove completly the previous method, hence for the whole life of the
> interface, the link-local address remains the same (previously, it depends on
> which ethernet interfaces were up when the tunnel interface was set up).
>
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Applied, but this brings up an issue I keep noticing.
We talk about eth_random_addr() and "uniqueness" together all the
time, but the former never implies the latter.
And we're going to run into situations where any conflicts generated
by this random address generater will cause reall failures.
Therefore we'll have to create a system to prevent them. Probably
using some simple table that keeps track of the addresses we've
generated.
^ permalink raw reply
* No more checkpatch "fixes" from newer developers.
From: David Miller @ 2013-08-21 6:44 UTC (permalink / raw)
To: dingtianhong; +Cc: netdev
I've really had it with "checkpatch" fixes that break things.
Case in point, the recent ipv6 checkpatch fixes did this:
/* first try to inherit the link-local address from the link device */
- if (idev->dev->iflink &&
- (link_dev = __dev_get_by_index(net, idev->dev->iflink))) {
- if (!ipv6_inherit_linklocal(idev, link_dev))
+ if (idev->dev->iflink)
+ link_dev = __dev_get_by_index(net, idev->dev->iflink);
+ if (link_dev && !ipv6_inherit_linklocal(idev, link_dev))
return;
- }
+
Are you kidding me? The openning and closing curly braces that create
the basic block were erroneously removed. Now the value of link_dev
is not defined.
I'm reverting this, and don't bother submitting these kinds of changes
any more, I'm going to ignore them.
^ permalink raw reply
* Re: [net PATCH] bridge: Use the correct bit length for bitmap functions in the VLAN code
From: David Miller @ 2013-08-21 6:36 UTC (permalink / raw)
To: makita.toshiaki; +Cc: vyasevic, netdev
In-Reply-To: <1376986218.5740.9.camel@ubuntu-vm-makita>
From: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>
Date: Tue, 20 Aug 2013 17:10:18 +0900
> The VLAN code needs to know the length of the per-port VLAN bitmap to
> perform its most basic operations (retrieving VLAN informations, removing
> VLANs, forwarding database manipulation, etc). Unfortunately, in the
> current implementation we are using a macro that indicates the bitmap
> size in longs in places where the size in bits is expected, which in
> some cases can cause what appear to be random failures.
> Use the correct macro.
>
> Signed-off-by: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>
Applied and queued up for -stable, thank you.
^ permalink raw reply
* Re: [PATCH] drivers:net:ifb: Fixed coding style error:assignment in if statement
From: David Miller @ 2013-08-21 6:34 UTC (permalink / raw)
To: skd.linux; +Cc: netdev, linux-kernel
In-Reply-To: <1376955577-26518-1-git-send-email-skd.linux@gmail.com>
From: Sanil Kumar D <skd.linux@gmail.com>
Date: Tue, 20 Aug 2013 05:09:37 +0530
> + if (skb == NULL) {
"!skb" is preferred.
> + if (skb == NULL) {
Likewise.
^ permalink raw reply
* Re: [patch -next v2] ipip: dereferencing an ERR_PTR in ip_tunnel_init_net()
From: David Miller @ 2013-08-21 6:33 UTC (permalink / raw)
To: dan.carpenter
Cc: nicolas.dichtel, kuznet, eric.dumazet, jmorris, yoshfuji, kaber,
netdev, kernel-janitors
In-Reply-To: <20130819222307.GA3622@elgon.mountain>
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Tue, 20 Aug 2013 01:23:07 +0300
> The __ip_tunnel_create() function returns an ERR_PTR on error so we need
> to check for that before dereferencing. This bug was added in commit
> 6c742e714d8c2 ("ipip: add x-netns support").
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> v2: Eric Dumazet said v1 patch looked racy and suggested the v2 fix.
>
This doesn't apply cleanly, you'll need to respin it.
^ permalink raw reply
* Re: [PATCH] Fix stack corruption on some architectures
From: David Miller @ 2013-08-21 6:29 UTC (permalink / raw)
To: daniel-R/FLGEdV95bo9U+Z1CfBt0SU0eOFXohjCypLqA8HKkk
Cc: j.dumon-x9gZzRpC1QbQT0dZR+AlfA,
gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r,
linux-usb-u79uwXL29TY76Z2rM5mHXA, netdev-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
In-Reply-To: <1376944647.5082.12.camel@chimera>
Please submit this with a more appropriate subject line.
After '[PATCH] ' there should be a subsystem or driver name
prefix, followed up a semicolon. Here it could be "hso: ",
so something like:
[PATCH] hso: Fix stack corruption on some architectures.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox