* Re: [PATCH 1/1] net: macb: Remove obsolete comment from Kconfig
From: David Miller @ 2014-12-09 20:39 UTC (permalink / raw)
To: james.byrne; +Cc: nicolas.ferre, netdev
In-Reply-To: <1417784633-13360-1-git-send-email-james.byrne@origamienergy.com>
From: James Byrne <james.byrne@origamienergy.com>
Date: Fri, 5 Dec 2014 13:03:53 +0000
> The Kconfig file says that Gigabit mode is not supported, but it has been
> supported since commit 140b7552fdff04bbceeb842f0e04f0b4015fe97b ("net/macb:
> Add support for Gigabit Ethernet mode").
>
> Signed-off-by: James Byrne <james.byrne@origamienergy.com>
Applied to net-next, thanks.
^ permalink raw reply
* Re: [patch net-next 1/2] net: sched: cls_basic: fix error path in basic_change()
From: David Miller @ 2014-12-09 20:42 UTC (permalink / raw)
To: jiri; +Cc: netdev, jhs
In-Reply-To: <1417791023-28124-1-git-send-email-jiri@resnulli.us>
From: Jiri Pirko <jiri@resnulli.us>
Date: Fri, 5 Dec 2014 15:50:22 +0100
> Signed-off-by: Jiri Pirko <jiri@resnulli.us>
Applied.
^ permalink raw reply
* Re: [patch net-next 2/2] net: sched: cls: use nla_nest_cancel instead of nlmsg_trim
From: David Miller @ 2014-12-09 20:42 UTC (permalink / raw)
To: jiri; +Cc: netdev, jhs
In-Reply-To: <1417791023-28124-2-git-send-email-jiri@resnulli.us>
From: Jiri Pirko <jiri@resnulli.us>
Date: Fri, 5 Dec 2014 15:50:23 +0100
> To cancel nesting, this function is more convenient.
>
> Signed-off-by: Jiri Pirko <jiri@resnulli.us>
Applied.
^ permalink raw reply
* Re: [patch net-next 2/2] net: sched: cls: use nla_nest_cancel instead of nlmsg_trim
From: David Miller @ 2014-12-09 20:48 UTC (permalink / raw)
To: jiri; +Cc: netdev, jhs
In-Reply-To: <20141209.154218.95904353076153825.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Tue, 09 Dec 2014 15:42:18 -0500 (EST)
> From: Jiri Pirko <jiri@resnulli.us>
> Date: Fri, 5 Dec 2014 15:50:23 +0100
>
>> To cancel nesting, this function is more convenient.
>>
>> Signed-off-by: Jiri Pirko <jiri@resnulli.us>
>
> Applied.
This doesn't even compile, when you took away the local 'b' variable
it is still referenced by pr_debug() calls.
^ permalink raw reply
* [PATCH net-next] amd-xgbe: Use disable_irq_nosync when in IRQ context
From: Tom Lendacky @ 2014-12-09 20:54 UTC (permalink / raw)
To: netdev; +Cc: David Miller
The disable_irq_nosync function, not the disable_irq function, must be
used to disable the DMA channel interrupt from within the interrupt
service routine. Change the disable_irq call to disable_irq_nosync.
Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
---
drivers/net/ethernet/amd/xgbe/xgbe-drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-drv.c b/drivers/net/ethernet/amd/xgbe/xgbe-drv.c
index bedfdb1..bf6bf11 100644
--- a/drivers/net/ethernet/amd/xgbe/xgbe-drv.c
+++ b/drivers/net/ethernet/amd/xgbe/xgbe-drv.c
@@ -396,7 +396,7 @@ static irqreturn_t xgbe_dma_isr(int irq, void *data)
*/
if (napi_schedule_prep(&channel->napi)) {
/* Disable Tx and Rx interrupts */
- disable_irq(channel->dma_irq);
+ disable_irq_nosync(channel->dma_irq);
/* Turn on polling */
__napi_schedule(&channel->napi);
^ permalink raw reply related
* Re: [PATCH net-next v2 0/4] net: allow setting congctl via routing table
From: David Miller @ 2014-12-09 20:58 UTC (permalink / raw)
To: dborkman; +Cc: hannes, fw, netdev
In-Reply-To: <1417909163-19135-1-git-send-email-dborkman@redhat.com>
From: Daniel Borkmann <dborkman@redhat.com>
Date: Sun, 7 Dec 2014 00:39:19 +0100
> This is the second part of our work and allows for setting the congestion
> control algorithm via routing table. For details, please see individual
> patches.
>
> Joint work with Florian Westphal, suggested by Hannes Frederic Sowa.
>
> Patch for iproute2: http://patchwork.ozlabs.org/patch/418149/
>
> Thanks!
>
> v1->v2:
> - Very sorry, I noticed I had decnet disabled during testing.
> Added missing header include in decnet, rest as is.
I don't like how you have to explicitly load the congestion control
module before asking for it to be used in the route entry metric.
It should request the module automatically just like the stack already
does for other cases.
You have run into this problem as a result of your design decision to
use that 32-bit key. Therefore, I think you seriously need to
reconsider that aspect of your change.
^ permalink raw reply
* Re: [PATCH net-next] macvlan: allow setting LRO independently of lower device
From: David Miller @ 2014-12-09 21:00 UTC (permalink / raw)
To: mkubecek; +Cc: kaber, netdev, linux-kernel
In-Reply-To: <20141205190937.99BD6A0BB0@unicorn.suse.cz>
From: Michal Kubecek <mkubecek@suse.cz>
Date: Fri, 5 Dec 2014 17:05:49 +0100
> Since commit fbe168ba91f7 ("net: generic dev_disable_lro() stacked
> device handling"), dev_disable_lro() zeroes NETIF_F_LRO feature flag
> first for a macvlan device and then for its lower device. As an attempt
> to set NETIF_F_LRO to zero is ignored, dev_disable_lro() issues a
> warning and taints kernel.
>
> Allowing NETIF_F_LRO to be set independently of the lower device
> consists of three parts:
>
> - add the flag to hw_features to allow toggling it
> - allow setting it to 0 even if lower device has the flag set
> - add the flag to MACVLAN_FEATURES to restore copying from lower
> device on macvlan creation
>
> Signed-off-by: Michal Kubecek <mkubecek@suse.cz>
Applied, thanks.
^ permalink raw reply
* Re: [PATCH net-next] openvswitch: set correct protocol on route lookup
From: David Miller @ 2014-12-09 21:01 UTC (permalink / raw)
To: jbenc; +Cc: netdev, dev, pshelar, wenyuz
In-Reply-To: <0ead411e38bc57a8971ffd9826f7bf9bfdc6ccf1.1417796557.git.jbenc@redhat.com>
From: Jiri Benc <jbenc@redhat.com>
Date: Fri, 5 Dec 2014 17:24:28 +0100
> Respect what the caller passed to ovs_tunnel_get_egress_info.
>
> Fixes: 8f0aad6f35f7e ("openvswitch: Extend packet attribute for egress tunnel info")
> Signed-off-by: Jiri Benc <jbenc@redhat.com>
Applied, thanks.
^ permalink raw reply
* Re: [PATCH net-next ] Documentation (ixgbe.txt): use a decimal address.
From: David Miller @ 2014-12-09 21:02 UTC (permalink / raw)
To: ramirose; +Cc: netdev, jeffrey.t.kirsher
In-Reply-To: <1417800943-4429-1-git-send-email-ramirose@gmail.com>
From: Rami Rosen <ramirose@gmail.com>
Date: Fri, 5 Dec 2014 19:35:43 +0200
> This patch fixes the erronous usage of an hexadecimal address in the
> example, by replacing it with a decimal address.
>
> Signed-off-by: Rami Rosen <ramirose@gmail.com>
Applied.
^ permalink raw reply
* Re: [PATCH] tipc: fix broadcast link wakeup after congestion
From: David Miller @ 2014-12-09 21:03 UTC (permalink / raw)
To: richard.alpe; +Cc: netdev, tipc-discussion, erik.hugne
In-Reply-To: <1417802360-5383-1-git-send-email-richard.alpe@ericsson.com>
From: <richard.alpe@ericsson.com>
Date: Fri, 5 Dec 2014 18:59:20 +0100
> From: Richard Alpe <richard.alpe@ericsson.com>
>
> commit 908344cdda80 ("tipc: fix bug in multicast congestion
> handling") introduced two bugs in the bclink wakeup function.
>
> This patch fixes the missing spinlock init for the broadcast link
> waiting_sks list and eliminates a broadcast link wakeup race caused
> by operation on the wakeup list without proper locking.
>
> Signed-off-by: Richard Alpe <richard.alpe@ericsson.com>
> Signed-off-by: Erik Hugne <erik.hugne@ericsson.com>
> Acked-by: Tero Aho <Tero.Aho@coriant.com>
This patch does not apply to the current 'net' tree.
^ permalink raw reply
* Re: the next chunk of iov_iter-net stuff for review
From: Al Viro @ 2014-12-09 21:04 UTC (permalink / raw)
To: David Miller; +Cc: netdev, linux-kernel
In-Reply-To: <20141209.150732.158834258918114526.davem@davemloft.net>
On Tue, Dec 09, 2014 at 03:07:32PM -0500, David Miller wrote:
> From: Al Viro <viro@ZenIV.linux.org.uk>
> Date: Fri, 5 Dec 2014 05:56:23 +0000
>
> > OK, here's the tentative next batch (covers most of the ->recvmsg()
> > side of conversion). That's on top of merge of net-next#master with
> > vfs#iov_iter (the latter had been posted earlier today, Cc'd to netdev among
> > other places). This series corresponds to vfs#for-davem. Review and comments
> > would be very welcome...
>
> Al, what's the state of this? The iov_iter rewrite had some changes
> recently.
Well, I've got no comments whatsoever on the networking side of things;
might mean that everything's fine, might mean that everyone had been too
polite to say it's shite, might be something in between... FWIW, changes
in iov_iter do not affect any of those patches, so the stuff posted
for review is unchanged by those.
> Also, never assume I just know what GIT url to pull from, always
> explicitly state where you want me to pull changes from.
Sure, but that was just a call for review. _If_ you think that those patches
are OK, the URL is
git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git for-davem
(and it pulls the fixed variant of iov_iter, otherwise it's exactly the same
as when I posted those).
FWIW, this stuff seems to work here, but I'd really like to hear at least
something before asking to pull. As it is, your mail is the first reply of
any kind...
^ permalink raw reply
* Re: [PATCH net] bnx2x: Implement ndo_gso_check()
From: David Miller @ 2014-12-09 21:05 UTC (permalink / raw)
To: joestringer; +Cc: netdev, ariel.elior, jesse, therbert, linux-kernel
In-Reply-To: <1417808146-3436-1-git-send-email-joestringer@nicira.com>
From: Joe Stringer <joestringer@nicira.com>
Date: Fri, 5 Dec 2014 11:35:46 -0800
> Use vxlan_gso_check() to advertise offload support for this NIC.
>
> Signed-off-by: Joe Stringer <joestringer@nicira.com>
Applied, thanks.
^ permalink raw reply
* Re: [PATCH] dummy: add support for ethtool get_drvinfo
From: David Miller @ 2014-12-09 21:07 UTC (permalink / raw)
To: fbl; +Cc: netdev
In-Reply-To: <1417824804-20634-1-git-send-email-fbl@redhat.com>
From: Flavio Leitner <fbl@redhat.com>
Date: Fri, 5 Dec 2014 22:13:24 -0200
> The command 'ethtool -i' is useful to find details
> about the interface like the device driver being used.
> This was missing for dummy driver.
>
> Signed-off-by: Flavio Leitner <fbl@redhat.com>
Applied, thank you.
Consider adding a MODULE_VERSION instance since you've added an
explicit version.
Thanks.
^ permalink raw reply
* Re: [PATCH net-next] dst: no need to take reference on DST_NOCACHE dsts
From: David Miller @ 2014-12-09 21:08 UTC (permalink / raw)
To: hannes; +Cc: netdev, edumazet, ja
In-Reply-To: <51b54bc66109594459e1a08c9022c5c48f20d910.1417889528.git.hannes@stressinduktion.org>
From: Hannes Frederic Sowa <hannes@stressinduktion.org>
Date: Sat, 6 Dec 2014 19:19:42 +0100
> Since commit f8864972126899 ("ipv4: fix dst race in sk_dst_get()")
> DST_NOCACHE dst_entries get freed by RCU. So there is no need to get a
> reference on them when we are in rcu protected sections.
>
> Cc: Eric Dumazet <edumazet@google.com>
> Cc: Julian Anastasov <ja@ssi.bg>
> Signed-off-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
Applied, thanks.
^ permalink raw reply
* Re: [PATCH net-next 1/4] netdevice: Add a function to check macvlan port
From: David Miller @ 2014-12-09 21:10 UTC (permalink / raw)
To: maheshb; +Cc: netdev, edumazet
In-Reply-To: <1417909984-13133-1-git-send-email-maheshb@google.com>
From: Mahesh Bandewar <maheshb@google.com>
Date: Sat, 6 Dec 2014 15:53:04 -0800
> Similar to a check for macvlan device, netif_is_macvlan(), add
> another function to check if a device is used as macvlan port.
>
> Signed-off-by: Mahesh Bandewar <maheshb@google.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next 2/4] ipvlan: play well with macvlan device
From: David Miller @ 2014-12-09 21:10 UTC (permalink / raw)
To: maheshb; +Cc: netdev, edumazet
In-Reply-To: <1417909999-13234-1-git-send-email-maheshb@google.com>
From: Mahesh Bandewar <maheshb@google.com>
Date: Sat, 6 Dec 2014 15:53:19 -0800
> If a device is already a macvlan port then refuse to use it as
> an ipvlan port in the early stage of port creation.
>
> thost1:~# ip link add link eth0 mvl0 type macvlan
> thost1:~# echo $?
> 0
> thost1:~# ip link add link eth0 ipvl0 type ipvlan
> RTNETLINK answers: Device or resource busy
> thost1:~# echo $?
> 2
> thost1:~#
>
> Signed-off-by: Mahesh Bandewar <maheshb@google.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next 3/4] ipvlan: move the device check function into netdevice.h
From: David Miller @ 2014-12-09 21:10 UTC (permalink / raw)
To: maheshb; +Cc: netdev, edumazet
In-Reply-To: <1417910013-13274-1-git-send-email-maheshb@google.com>
From: Mahesh Bandewar <maheshb@google.com>
Date: Sat, 6 Dec 2014 15:53:33 -0800
> Move the port check [ipvlan_dev_master()] and device check
> [ipvlan_dev_slave()] functions to netdevice.h and rename them
> netif_is_ipvlan_port() and netif_is_ipvlan() resp. to be
> consistent with macvlan api naming.
>
> Signed-off-by: Mahesh Bandewar <maheshb@google.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next 4/4] macvlan: play well with ipvlan device
From: David Miller @ 2014-12-09 21:10 UTC (permalink / raw)
To: maheshb; +Cc: netdev, edumazet
In-Reply-To: <1417910026-13371-1-git-send-email-maheshb@google.com>
From: Mahesh Bandewar <maheshb@google.com>
Date: Sat, 6 Dec 2014 15:53:46 -0800
> If device is already used as an ipvlan port then refuse to
> use it as a macvlan port at early stage of port creation.
>
> thost1:~# ip link add link eth0 ipvl0 type ipvlan
> thost1:~# echo $?
> 0
> thost1:~# ip link add link eth0 mvl0 type macvlan
> RTNETLINK answers: Device or resource busy
> thost1:~# echo $?
> 2
> thost1:~#
>
> Signed-off-by: Mahesh Bandewar <maheshb@google.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next] enic: add support for set/get rss hash key
From: David Miller @ 2014-12-09 21:12 UTC (permalink / raw)
To: _govind; +Cc: netdev, ssujith, benve
In-Reply-To: <1417972273-22661-1-git-send-email-_govind@gmx.com>
From: Govindarajulu Varadarajan <_govind@gmx.com>
Date: Sun, 7 Dec 2014 22:41:13 +0530
> This patch adds support for setting/getting rss hash key using ethtool.
>
> Signed-off-by: Govindarajulu Varadarajan <_govind@gmx.com>
Applied, thanks.
^ permalink raw reply
* Re: [PATCH 12/20] hp100: fix misspelling of current function in string
From: David Miller @ 2014-12-09 21:13 UTC (permalink / raw)
To: Julia.Lawall; +Cc: perex, kernel-janitors, linux, joe, netdev, linux-kernel
In-Reply-To: <1417980062-25151-13-git-send-email-Julia.Lawall@lip6.fr>
From: Julia Lawall <Julia.Lawall@lip6.fr>
Date: Sun, 7 Dec 2014 20:20:54 +0100
> Replace a misspelled function name by %s and then __func__.
>
> This was done using Coccinelle, including the use of Levenshtein distance,
> as proposed by Rasmus Villemoes.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Applied.
^ permalink raw reply
* Re: [PATCH 14/20] chelsio: fix misspelling of current function in string
From: David Miller @ 2014-12-09 21:13 UTC (permalink / raw)
To: Julia.Lawall; +Cc: netdev, kernel-janitors, linux, joe, linux-kernel
In-Reply-To: <1417980062-25151-15-git-send-email-Julia.Lawall@lip6.fr>
From: Julia Lawall <Julia.Lawall@lip6.fr>
Date: Sun, 7 Dec 2014 20:20:56 +0100
> Replace a misspelled function name by %s and then __func__.
>
> This was done using Coccinelle, including the use of Levenshtein distance,
> as proposed by Rasmus Villemoes.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Applied.
^ permalink raw reply
* Re: [PATCH 12/20] hp100: fix misspelling of current function in string
From: David Miller @ 2014-12-09 21:14 UTC (permalink / raw)
To: Julia.Lawall; +Cc: perex, kernel-janitors, linux, joe, netdev, linux-kernel
In-Reply-To: <1417980062-25151-13-git-send-email-Julia.Lawall@lip6.fr>
From: Julia Lawall <Julia.Lawall@lip6.fr>
Date: Sun, 7 Dec 2014 20:20:54 +0100
> Replace a misspelled function name by %s and then __func__.
>
> This was done using Coccinelle, including the use of Levenshtein distance,
> as proposed by Rasmus Villemoes.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Applied.
^ permalink raw reply
* Re: [PATCH 14/20] chelsio: fix misspelling of current function in string
From: David Miller @ 2014-12-09 21:14 UTC (permalink / raw)
To: Julia.Lawall; +Cc: netdev, kernel-janitors, linux, joe, linux-kernel
In-Reply-To: <1417980062-25151-15-git-send-email-Julia.Lawall@lip6.fr>
From: Julia Lawall <Julia.Lawall@lip6.fr>
Date: Sun, 7 Dec 2014 20:20:56 +0100
> Replace a misspelled function name by %s and then __func__.
>
> This was done using Coccinelle, including the use of Levenshtein distance,
> as proposed by Rasmus Villemoes.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Applied.
^ permalink raw reply
* Re: [PATCH 10/20] uli526x: fix misspelling of current function in string
From: David Miller @ 2014-12-09 21:14 UTC (permalink / raw)
To: Julia.Lawall; +Cc: grundler, kernel-janitors, linux, joe, netdev, linux-kernel
In-Reply-To: <1417980062-25151-11-git-send-email-Julia.Lawall@lip6.fr>
From: Julia Lawall <Julia.Lawall@lip6.fr>
Date: Sun, 7 Dec 2014 20:20:52 +0100
> Replace a misspelled function name by %s and then __func__.
>
> This was done using Coccinelle, including the use of Levenshtein distance,
> as proposed by Rasmus Villemoes.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Applied.
^ permalink raw reply
* Re: [PATCH 4/20] dmfe: fix misspelling of current function in string
From: David Miller @ 2014-12-09 21:14 UTC (permalink / raw)
To: Julia.Lawall; +Cc: grundler, kernel-janitors, linux, joe, netdev, linux-kernel
In-Reply-To: <1417980062-25151-5-git-send-email-Julia.Lawall@lip6.fr>
From: Julia Lawall <Julia.Lawall@lip6.fr>
Date: Sun, 7 Dec 2014 20:20:46 +0100
> The function name contains cleanup, not clean.
>
> This was done using Coccinelle, including the use of Levenshtein distance,
> as proposed by Rasmus Villemoes.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Applied.
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox