* Re: [PATCH net-next] firewire: net: really fix maximum possible MTU
From: David Miller @ 2016-10-30 3:01 UTC (permalink / raw)
To: stefanr; +Cc: netdev, linux1394-devel, jarod, linux-kernel
In-Reply-To: <20161029221658.03942ff6@kant>
From: Stefan Richter <stefanr@s5r6.in-berlin.de>
Date: Sat, 29 Oct 2016 22:16:58 +0200
> The maximum unicast datagram size /without/ link fragmentation is
> 4096 - 4 = 4092 (max IEEE 1394 async payload size at >= S800 bus speed,
> minus unfragmented encapssulation header). Max broadcast datagram size
> without fragmentation is 8 bytes less than that (due to GASP header).
>
> The maximum datagram size /with/ link fragmentation is 0xfff = 4095
> for unicast and broadcast. This is because the RFC 2734 fragment
> encapsulation header field for datagram size is only 12 bits wide.
>
> Fixes: 5d48f00d836a('firewire: net: fix maximum possible MTU')
> Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
Applied, thanks.
^ permalink raw reply
* Fw: [GIT] Networking
From: David Miller @ 2016-10-30 2:43 UTC (permalink / raw)
To: netdev; +Cc: linux-kernel
[-- Attachment #1: Type: Text/Plain, Size: 50 bytes --]
Sorry, forgot to CC: the lists on this one, doh!
[-- Attachment #2: Type: Message/Rfc822, Size: 46820 bytes --]
From: David Miller <davem@davemloft.net>
To: torvalds@linux-foundation.org
Cc: akpm@linux-foundation.org
Subject: [GIT] Networking
Date: Sat, 29 Oct 2016 21:12:33 -0400 (EDT)
Message-ID: <20161029.211233.2078146849785088999.davem@davemloft.net>
Lots of fixes, mostly drivers as is usually the case.
1) Don't treat zero DMA address as invalid in vmxnet3, from Alexey
Khoroshilov.
2) Fix element timeouts in netfilter's nft_dynset, from Anders
K. Pedersen.
3) Don't put aead_req crypto struct on the stack in mac80211, from Ard
Biesheuvel.
4) Several uninitialized variable warning fixes from Arnd Bergmann.
5) Fix memory leak in cxgb4, from Colin Ian King.
6) Fix bpf handling of VLAN header push/pop, from Daniel Borkmann.
7) Several VRF semantic fixes from David Ahern.
8) Set skb->protocol properly in ip6_tnl_xmit(), from Eli Cooper.
9) Socket needs to be locked in udp_disconnect(), from Eric Dumazet.
10) Div-by-zero on 32-bit fix in mlx4 driver, from Eugenia Emantayev.
11) Fix stale link state during failover in NCSCI driver, from Gavin
Shan.
12) Fix netdev lower adjacency list traversal, from Ido Schimmel.
13) Propvide proper handle when emitting notifications of filter
deletes, from Jamal Hadi Salim.
14) Memory leaks and big-endian issues in rtl8xxxu, from Jes Sorensen.
15) Fix DESYNC_FACTOR handling in ipv6, from Jiri Bohac.
16) Several routing offload fixes in mlxsw driver, from Jiri Pirko.
17) Fix broadcast sync problem in TIPC, from Jon Paul Maloy.
18) Validate chunk len before using it in SCTP, from Marcelo Ricardo
Leitner.
19) Revert a netns locking change that causes regressions, from Paul
Moore.
20) Add recursion limit to GRO handling, from Sabrina Dubroca.
21) GFP_KERNEL in irq context fix in ibmvnic, from Thomas Falcon.
22) Avoid accessing stale vxlan/geneve socket in data path, from
Pravin Shelar.
The following changes since commit 29fbff8698fc0ac1a1d74584b258e0bf18b469f9:
Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net (2016-10-13 21:40:23 -0700)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git
for you to fetch changes up to fceb9c3e38252992bbf1a3028cc2f7b871211533:
geneve: avoid using stale geneve socket. (2016-10-29 20:56:31 -0400)
----------------------------------------------------------------
Adam Williamson (1):
ath6kl: add Dell OEM SDIO I/O for the Venue 8 Pro
Alexander Alemayhu (1):
Documentation/networking: update git urls to use https over http
Alexey Khoroshilov (1):
vmxnet3: avoid assumption about invalid dma_pa in vmxnet3_set_mc()
Anders K. Pedersen (1):
netfilter: nft_dynset: fix element timeout for HZ != 1000
Ard Biesheuvel (2):
r8169: set coherent DMA mask as well as streaming DMA mask
mac80211: move struct aead_req off the stack
Arnd Bergmann (7):
netfilter: nf_tables: avoid uninitialized variable warning
net: bcm63xx: avoid referencing uninitialized variable
net/hyperv: avoid uninitialized variable
rocker: fix maybe-uninitialized warning
kalmia: avoid potential uninitialized variable use
flow_dissector: fix vlan tag handling
IB/mlx4: avoid a -Wmaybe-uninitialize warning
Brenden Blanco (1):
net/mlx4_en: fixup xdp tx irq to match rx
Colin Ian King (2):
cxgb4: fix memory leak of qe on error exit path
net: bgmac: fix spelling mistake: "connecton" -> "connection"
Craig Gallek (1):
inet: Fix missing return value in inet6_hash
Dan Carpenter (4):
afs: unmapping the wrong buffer
stmmac: fix an error code in stmmac_ptp_register()
netfilter: nf_tables: underflow in nft_parse_u32_check()
netfilter: nft_exthdr: fix error handling in nft_exthdr_init()
Daniel Borkmann (2):
bpf, test: fix ld_abs + vlan push/pop stress test
bpf: fix samples to add fake KBUILD_MODNAME
Daniel Jurgens (2):
{net, ib}/mlx5: Make cache line size determination at runtime.
net/mlx5: Always Query HCA caps after setting them
David Ahern (3):
net: Require exact match for TCP socket lookups if dif is l3mdev
net: ipv6: Fix processing of RAs in presence of VRF
net: ipv6: Do not consider link state for nexthop validation
David Ertman (1):
i40e: Fix configure TCs after initial DCB disable
David Howells (3):
rxrpc: Fix checker warning by not passing always-zero value to ERR_PTR()
rxrpc: Fix checking of error from ip6_route_output()
afs: call->operation_ID sometimes used as __be32 sometimes as u32
David S. Miller (17):
Merge tag 'rxrpc-rewrite-20161013' of git://git.kernel.org/.../dhowells/linux-fs
Merge branch 'qed-fixes'
Merge tag 'wireless-drivers-for-davem-2016-10-14' of git://git.kernel.org/.../kvalo/wireless-drivers
Merge branch 'net-driver-autoload'
Merge tag 'mac80211-for-davem-2016-10-18' of git://git.kernel.org/.../jberg/mac80211
Merge branch 'ncsi-fixes'
Merge git://git.kernel.org/.../pablo/nf
Merge branch 'dsa-bcm_sf2-do-not-rely-on-kexec_in_progress'
Merge branch 'qed-fixes'
Merge branch 'for-upstream' of git://git.kernel.org/.../bluetooth/bluetooth
Merge branch 'mlxsw-fixes'
Merge branch 'mlx5-fixes'
Merge tag 'batadv-net-for-davem-20161026' of git://git.open-mesh.org/linux-merge
Merge tag 'mac80211-for-davem-2016-10-27' of git://git.kernel.org/.../jberg/mac80211
Merge branch 'mlx4-fixes'
Merge branch '40GbE' of git://git.kernel.org/.../jkirsher/net-queue
Revert "ibmvnic: Fix releasing of sub-CRQ IRQs in interrupt context"
Elad Raz (1):
mlxsw: switchx2: Fix ethernet port initialization
Eli Cooper (1):
ip6_tunnel: Update skb->protocol to ETH_P_IPV6 in ip6_tnl_xmit()
Emil Tantilov (1):
ixgbe: fix panic when using macvlan with l2-fwd-offload enabled
Erez Shitrit (1):
net/mlx4_en: Process all completions in RX rings after port goes up
Eric Dumazet (6):
net: pktgen: remove rcu locking in pktgen_change_name()
soreuseport: do not export reuseport_add_sock()
tcp: do not export sysctl_tcp_low_latency
udp: must lock the socket in udp_disconnect()
ipv4: disable BH in set_ping_group_range()
udp: fix IP_CHECKSUM handling
Eric Garver (1):
flow_dissector: Check skb for VLAN only if skb specified.
Eugenia Emantayev (3):
net/mlx4_en: Resolve dividing by zero in 32-bit system
net/mlx4_en: Fix panic during reboot
net/mlx4: Fix firmware command timeout during interrupt test
Fabio Estevam (1):
net: fec: Call swap_buffer() prior to IP header alignment
Felix Fietkau (1):
Revert "ath9k_hw: implement temperature compensation support for AR9003+"
Florian Fainelli (4):
net: dsa: bcm_sf2: Prevent GPHY shutdown for kexec'd kernels
kexec: Export kexec_in_progress to modules
Revert "kexec: Export kexec_in_progress to modules"
net: dsa: bcm_sf2: Do not rely on kexec_in_progress
Florian Westphal (1):
netfilter: x_tables: suppress kmemcheck warning
Ganesh Goudar (2):
cxgb4: Fix number of queue sets corssing the limit
cxgb4: Fix error handling in alloc_uld_rxqs().
Gavin Shan (4):
net/ncsi: Avoid if statements in ncsi_suspend_channel()
net/ncsi: Fix stale link state of inactive channels on failover
net/ncsi: Choose hot channel as active one if necessary
net/ncsi: Improve HNCDSC AEN handler
Geert Uytterhoeven (1):
netfilter: xt_hashlimit: Add missing ULL suffixes for 64-bit constants
Giuseppe CAVALLARO (2):
stmmac: fix and review the ptp registration.
stmmac: display the descriptors if DES0 = 0
Govindarajulu Varadarajan (1):
enic: fix rq disable
Guenter Roeck (1):
net: asix: Avoid looping when the device does not respond
Guilherme G Piccoli (1):
i40e: disable MSI-X interrupts if we cannot reserve enough vectors
Huaibin Wang (1):
i40e: fix call of ndo_dflt_bridge_getlink()
Ido Schimmel (2):
net: core: Correctly iterate over lower adjacency list
switchdev: Execute bridge ndos only for bridge ports
Ivan Vecera (2):
bnx2: fix locking when netconsole is used
arch/powerpc: Update parameters for csum_tcpudp_magic & csum_tcpudp_nofold
Jack Morgenstein (3):
net/mlx4_core: Fix the resource-type enum in res tracker to conform to FW spec
net/mlx4_core: Do not access comm channel if it has not yet been initialized
net/mlx4_en: Fix potential deadlock in port statistics flow
Jacob Siverskog (1):
Bluetooth: btwilink: Fix probe return value
Jamal Hadi Salim (1):
net sched filters: fix notification of filter delete with proper handle
Jani Nikula (1):
mac80211: fix some sphinx warnings
Jason A. Donenfeld (1):
ipv6: do not increment mac header when it's unset
Jason Gunthorpe (1):
net: mv643xx_eth: Fetch the phy connection type from DT
Javier Martinez Canillas (10):
net: wan: slic_ds26522: add SPI device ID table to fix module autoload
net: wan: slic_ds26522: Export OF module alias information
net: wan: slic_ds26522: Allow driver to built if COMPILE_TEST is enabled
net: nps_enet: Fix module autoload
net: ethernet: nb8800: Fix module autoload
net: hns: Fix hns_dsaf module autoload for OF registration
net: qcom/emac: Fix module autoload for OF registration
net: hisilicon: Fix hns_mdio module autoload for OF registration
net: dsa: b53: Fix module autoload
net: dsa: bcm_sf2: Fix module autoload for OF registration
Jes Sorensen (4):
rtl8xxxu: Fix memory leak in handling rxdesc16 packets
rtl8xxxu: Fix big-endian problem reporting mactime
rtl8xxxu: Fix rtl8723bu driver reload issue
rtl8xxxu: Fix rtl8192eu driver reload issue
Jesse Brandeburg (1):
ethtool: silence warning on bit loss
Jiri Bohac (3):
IPv6: Drop the temporary address regen_timer
IPv6: fix DESYNC_FACTOR
ipv6: properly prevent temp_prefered_lft sysctl race
Jiri Pirko (6):
rtnetlink: Add rtnexthop offload flag to compare mask
mlxsw: spectrum_router: Use correct tree index for binding
mlxsw: spectrum_router: Make mlxsw_sp_router_fib4_del return void and remove warn
mlxsw: pci: Fix reset wait for SwitchX2
mlxsw: spectrum_router: Save requested prefix bitlist when creating tree
mlxsw: spectrum_router: Compare only trees which are in use during tree get
Jiri Slaby (1):
net: sctp, forbid negative length
Johannes Berg (6):
mac80211: discard multicast and 4-addr A-MSDUs
cfg80211: let ieee80211_amsdu_to_8023s() take only header-less SKB
cfg80211: add ability to check DA/SA in A-MSDU decapsulation
mac80211: validate DA/SA during A-MSDU decapsulation
cfg80211: process events caused by suspend before suspending
net_sched actions: use nla_parse_nested()
Jon Paul Maloy (1):
tipc: fix broadcast link synchronization problem
Jérôme de Bretagne (1):
Bluetooth: hci_bcm: Fix autosuspend PM for Lenovo ThinkPad 8
Larry Finger (1):
rtlwifi: Fix regression caused by commit d86e64768859
Linus Lüssing (1):
batman-adv: fix splat on disabling an interface
Liping Zhang (3):
netfilter: xt_NFLOG: fix unexpected truncated packet
netfilter: xt_ipcomp: add "ip[6]t_ipcomp" module alias name
netfilter: nft_hash: add missing NFTA_HASH_OFFSET's nla_policy
Manish Chopra (1):
qede: Fix incorrrect usage of APIs for un-mapping DMA memory
Maor Gottlieb (1):
net/mlx4_core: Avoid setting ports to auto when only one port type is supported
Marcelo Ricardo Leitner (1):
sctp: validate chunk len before actually using it
Marty Faltesek (1):
ath10k: cache calibration data when the core is stopped
Michael Braun (1):
mac80211: fix CMD_FRAME for AP_VLAN
Michał Narajowski (1):
Bluetooth: Fix append max 11 bytes of name to scan rsp data
Mintz, Yuval (2):
MAINTAINERS: Update qlogic networking drivers
qede: Fix out-of-bound fastpath memory access
Mohamad Haj Yahia (5):
net/mlx5e: Unregister netdev before detaching it
net/mlx5: Change the acl enable prototype to return status
net/mlx5: Clear health sick bit when starting health poll
net/mlx5: Fix race between PCI error handlers and health work
net/mlx5: PCI error recovery health care simulation
Moshe Lazer (1):
net/mlx4_core: Change the default value of enable_qos
Nicolas Dichtel (3):
ipv6: correctly add local routes when lo goes up
netfilter: conntrack: remove obsolete sysctl (nf_conntrack_events_retry_timeout)
netfilter: conntrack: restart gc immediately if GC_MAX_EVICTS is reached
Niklas Cassel (2):
dwc_eth_qos: do not clear pause flags from phy_device->supported
dwc_eth_qos: enable flow control by default
Nikolay Aleksandrov (1):
bridge: multicast: restore perm router ports on multicast enable
Noa Osherovich (1):
net/mlx5: Avoid passing dma address 0 to firmware
Pablo Neira Ayuso (2):
netfilter: nft_range: validate operation netlink attribute
netfilter: fix nf_queue handling
Paolo Abeni (1):
IB/ipoib: move back IB LL address into the hard header
Paul Blakey (4):
net/sched: act_mirred: Use passed lastuse argument
net/mlx5: Keep autogroups list ordered
net/mlx5: Fix autogroups groups num not decreasing
net/mlx5: Correctly initialize last use of flow counters
Paul Moore (1):
netns: revert "netns: avoid disabling irq for netns id"
Roger Quadros (1):
net: phy: dp83848: add dp83822 PHY support
Sabrina Dubroca (1):
net: add recursion limit to GRO
Saeed Mahameed (1):
net/mlx5e: Choose best nearest LRO timeout
Stephen Hemminger (3):
doc: update docbook annotations for socket and skb
netvsc: fix incorrect receive checksum offloading
Revert "hv_netvsc: report vmbus name in ethtool"
Sudarsana Reddy Kalluru (7):
qede: get_channels() need to populate max tx/rx coalesce values
qede: Do not allow RSS config for 100G devices
qede: Loopback implementation should ignore the normal traffic
qed*: Reduce the memory footprint for Rx path
qede: Reconfigure rss indirection direction table when rss count is updated
qed: Zero-out the buffer paased to dcbx_query() API
bnx2x: Use the correct divisor value for PHC clock readings.
Sven Eckelmann (2):
batman-adv: Modify neigh_list only with rcu-list functions
batman-adv: Add BATADV_DBG_TP_METER to BATADV_DBG_ALL
Tariq Toukan (1):
net/mlx4_en: Save slave ethtool stats command
Thomas Falcon (6):
ibmvnic: Driver Version 1.0.1
ibmvnic: Fix GFP_KERNEL allocation in interrupt context
ibmvnic: Update MTU after device initialization
ibmvnic: Fix releasing of sub-CRQ IRQs in interrupt context
ibmvnic: Fix releasing of sub-CRQ IRQs in interrupt context
ibmvnic: Fix missing brackets in init_sub_crq_irqs
Timur Tabi (1):
net: qcom/emac: disable interrupts before calling phy_disconnect
Tobias Brunner (1):
macsec: Fix header length if SCI is added if explicitly disabled
Tobias Klauser (3):
net/hsr: Remove unused but set variable
ipv4: Remove unused but set variable
tcp: Remove unused but set variable
Vadim Fedorenko (1):
ip6_tunnel: fix ip6_tnl_lookup
WANG Cong (2):
ipv6: fix a potential deadlock in do_ipv6_setsockopt()
ipv4: use the right lock for ping_group_range
Wei Yongjun (3):
wlcore: sdio: drop kfree for memory allocated with devm_kzalloc
qed: Use list_move_tail instead of list_del/list_add_tail
rocker: fix error return code in rocker_world_check_init()
Willem de Bruijn (1):
packet: on direct_xmit, limit tso and csum to supported devices
Xin Long (1):
sctp: fix the panic caused by route update
Yuval Mintz (3):
qed: Fix static checker warning.
qed*: Fix Kconfig dependencies with INFINIBAND_QEDR
qed: Additional work toward cleaning C=1
Zefir Kurtisi (2):
Revert "at803x: fix suspend/resume for SGMII link"
at803x: double check SGMII side autoneg
pravin shelar (2):
vxlan: avoid using stale vxlan socket.
geneve: avoid using stale geneve socket.
shamir rabinovitch (1):
rds: debug messages are enabled by default
Documentation/devicetree/bindings/net/marvell-orion-net.txt | 1 +
Documentation/networking/netdev-FAQ.txt | 8 +--
Documentation/networking/nf_conntrack-sysctl.txt | 18 ------
MAINTAINERS | 41 ++++++------
arch/powerpc/include/asm/checksum.h | 12 ++--
drivers/bluetooth/btwilink.c | 2 +-
drivers/bluetooth/hci_bcm.c | 8 +++
drivers/infiniband/hw/mlx5/main.c | 2 +-
drivers/infiniband/hw/mlx5/qp.c | 1 -
drivers/infiniband/ulp/ipoib/ipoib.h | 20 ++++--
drivers/infiniband/ulp/ipoib/ipoib_cm.c | 15 ++---
drivers/infiniband/ulp/ipoib/ipoib_ib.c | 12 ++--
drivers/infiniband/ulp/ipoib/ipoib_main.c | 54 +++++++++-------
drivers/infiniband/ulp/ipoib/ipoib_multicast.c | 6 +-
drivers/net/dsa/b53/b53_mmap.c | 1 +
drivers/net/dsa/bcm_sf2.c | 16 +++++
drivers/net/ethernet/aurora/nb8800.c | 1 +
drivers/net/ethernet/broadcom/bcm63xx_enet.c | 3 +-
drivers/net/ethernet/broadcom/bgmac.c | 2 +-
drivers/net/ethernet/broadcom/bnx2.c | 17 +++--
drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 2 +-
drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 2 +-
drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.c | 40 ++++++------
drivers/net/ethernet/chelsio/cxgb4/sched.c | 4 +-
drivers/net/ethernet/cisco/enic/vnic_rq.c | 32 +++++++---
drivers/net/ethernet/ezchip/nps_enet.c | 1 +
drivers/net/ethernet/freescale/fec_main.c | 6 +-
drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c | 1 +
drivers/net/ethernet/hisilicon/hns_mdio.c | 1 +
drivers/net/ethernet/ibm/ibmvnic.c | 45 +++++++++-----
drivers/net/ethernet/ibm/ibmvnic.h | 3 +-
drivers/net/ethernet/intel/i40e/i40e.h | 1 +
drivers/net/ethernet/intel/i40e/i40e_main.c | 34 ++--------
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 12 ++--
drivers/net/ethernet/marvell/mv643xx_eth.c | 23 +++++--
drivers/net/ethernet/mellanox/mlx4/cmd.c | 9 +++
drivers/net/ethernet/mellanox/mlx4/en_clock.c | 5 +-
drivers/net/ethernet/mellanox/mlx4/en_cq.c | 10 ++-
drivers/net/ethernet/mellanox/mlx4/en_netdev.c | 13 +++-
drivers/net/ethernet/mellanox/mlx4/en_port.c | 4 +-
drivers/net/ethernet/mellanox/mlx4/en_selftest.c | 26 +++++++-
drivers/net/ethernet/mellanox/mlx4/eq.c | 62 +++++++++----------
drivers/net/ethernet/mellanox/mlx4/fw.c | 4 +-
drivers/net/ethernet/mellanox/mlx4/main.c | 10 ++-
drivers/net/ethernet/mellanox/mlx4/mlx4.h | 5 +-
drivers/net/ethernet/mellanox/mlx4/port.c | 13 +---
drivers/net/ethernet/mellanox/mlx4/resource_tracker.c | 5 +-
drivers/net/ethernet/mellanox/mlx5/core/alloc.c | 31 ++++++++--
drivers/net/ethernet/mellanox/mlx5/core/en.h | 5 ++
drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 21 +++++--
drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 1 +
drivers/net/ethernet/mellanox/mlx5/core/eswitch.c | 50 ++++++++++-----
drivers/net/ethernet/mellanox/mlx5/core/fs_core.c | 9 ++-
drivers/net/ethernet/mellanox/mlx5/core/fs_counters.c | 1 +
drivers/net/ethernet/mellanox/mlx5/core/health.c | 76 ++++++++++++++++++++---
drivers/net/ethernet/mellanox/mlx5/core/main.c | 39 ++++++++----
drivers/net/ethernet/mellanox/mlx5/core/mlx5_core.h | 1 +
drivers/net/ethernet/mellanox/mlx5/core/pagealloc.c | 26 +++++---
drivers/net/ethernet/mellanox/mlxsw/pci.c | 10 ++-
drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c | 21 ++++---
drivers/net/ethernet/mellanox/mlxsw/switchx2.c | 1 +
drivers/net/ethernet/qlogic/Kconfig | 4 ++
drivers/net/ethernet/qlogic/qed/Makefile | 2 +-
drivers/net/ethernet/qlogic/qed/qed_cxt.c | 15 ++---
drivers/net/ethernet/qlogic/qed/qed_dcbx.c | 2 +
drivers/net/ethernet/qlogic/qed/qed_debug.c | 53 ++++++++--------
drivers/net/ethernet/qlogic/qed/qed_dev.c | 19 +++---
drivers/net/ethernet/qlogic/qed/qed_ll2.c | 27 ++++----
drivers/net/ethernet/qlogic/qed/qed_ll2.h | 20 ------
drivers/net/ethernet/qlogic/qed/qed_main.c | 31 +++++-----
drivers/net/ethernet/qlogic/qed/qed_roce.c | 216 ++++++++++++++++++----------------------------------------------
drivers/net/ethernet/qlogic/qed/qed_roce.h | 95 ++++++++++++++--------------
drivers/net/ethernet/qlogic/qed/qed_sp.h | 1 -
drivers/net/ethernet/qlogic/qed/qed_spq.c | 4 --
drivers/net/ethernet/qlogic/qede/Makefile | 2 +-
drivers/net/ethernet/qlogic/qede/qede.h | 3 +-
drivers/net/ethernet/qlogic/qede/qede_ethtool.c | 99 ++++++++++++++++++-----------
drivers/net/ethernet/qlogic/qede/qede_main.c | 15 +++--
drivers/net/ethernet/qualcomm/emac/emac-mac.c | 8 ++-
drivers/net/ethernet/qualcomm/emac/emac.c | 1 +
drivers/net/ethernet/realtek/r8169.c | 3 +-
drivers/net/ethernet/rocker/rocker_main.c | 2 +-
drivers/net/ethernet/rocker/rocker_ofdpa.c | 4 +-
drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c | 7 +--
drivers/net/ethernet/stmicro/stmmac/stmmac.h | 2 +-
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 6 +-
drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c | 13 ++--
drivers/net/ethernet/synopsys/dwc_eth_qos.c | 4 +-
drivers/net/geneve.c | 47 ++++++++++----
drivers/net/hyperv/netvsc_drv.c | 25 ++++----
drivers/net/macsec.c | 26 +++++---
drivers/net/phy/at803x.c | 65 +++++++++++--------
drivers/net/phy/dp83848.c | 3 +
drivers/net/usb/asix_common.c | 8 +--
drivers/net/usb/kalmia.c | 2 +-
drivers/net/vmxnet3/vmxnet3_drv.c | 17 ++---
drivers/net/vrf.c | 2 +
drivers/net/vxlan.c | 82 ++++++++++++++----------
drivers/net/wan/Kconfig | 2 +-
drivers/net/wan/slic_ds26522.c | 8 +++
drivers/net/wireless/ath/ath10k/core.h | 1 +
drivers/net/wireless/ath/ath10k/debug.c | 75 +++++++++++-----------
drivers/net/wireless/ath/ath6kl/sdio.c | 1 +
drivers/net/wireless/ath/ath9k/ar9003_calib.c | 25 +-------
drivers/net/wireless/ath/ath9k/hw.h | 1 -
drivers/net/wireless/marvell/mwifiex/11n_rxreorder.c | 2 +-
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.h | 4 +-
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192e.c | 8 ++-
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8723b.c | 4 ++
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 11 +++-
drivers/net/wireless/realtek/rtlwifi/core.c | 2 +-
drivers/net/wireless/realtek/rtlwifi/rtl8188ee/sw.c | 8 +--
drivers/net/wireless/realtek/rtlwifi/rtl8192ce/sw.c | 13 ++--
drivers/net/wireless/realtek/rtlwifi/rtl8192cu/sw.c | 12 ++--
drivers/net/wireless/realtek/rtlwifi/rtl8192de/sw.c | 6 +-
drivers/net/wireless/realtek/rtlwifi/rtl8192ee/sw.c | 8 +--
drivers/net/wireless/realtek/rtlwifi/rtl8192se/sw.c | 9 +--
drivers/net/wireless/realtek/rtlwifi/rtl8723ae/sw.c | 12 ++--
drivers/net/wireless/realtek/rtlwifi/rtl8723be/sw.c | 6 +-
drivers/net/wireless/realtek/rtlwifi/rtl8821ae/sw.c | 18 +++---
drivers/net/wireless/realtek/rtlwifi/wifi.h | 2 -
drivers/net/wireless/ti/wlcore/sdio.c | 1 -
fs/afs/cmservice.c | 6 +-
fs/afs/fsclient.c | 4 +-
fs/afs/internal.h | 2 +-
fs/afs/rxrpc.c | 3 +-
include/linux/hyperv.h | 7 ---
include/linux/ipv6.h | 17 ++++-
include/linux/mlx4/device.h | 3 +-
include/linux/mlx5/driver.h | 16 ++---
include/linux/netdevice.h | 41 +++++++++++-
include/linux/qed/qed_if.h | 1 +
include/linux/qed/qede_roce.h | 2 +-
include/linux/skbuff.h | 1 +
include/net/addrconf.h | 1 +
include/net/cfg80211.h | 32 +++++++---
include/net/if_inet6.h | 2 +-
include/net/ip.h | 12 +++-
include/net/ip6_fib.h | 2 +
include/net/ip6_route.h | 1 +
include/net/mac80211.h | 21 ++++---
include/net/sock.h | 4 +-
include/net/tcp.h | 13 +++-
include/net/udp.h | 1 +
include/net/vxlan.h | 4 +-
include/uapi/linux/ethtool.h | 3 +-
include/uapi/linux/rtnetlink.h | 2 +-
lib/test_bpf.c | 2 +-
net/8021q/vlan.c | 2 +-
net/batman-adv/hard-interface.c | 1 -
net/batman-adv/log.h | 2 +-
net/batman-adv/originator.c | 2 +-
net/bluetooth/hci_request.c | 49 +++++++--------
net/bluetooth/hci_request.h | 2 +
net/bluetooth/mgmt.c | 26 +++++---
net/bridge/br_multicast.c | 23 ++++---
net/core/dev.c | 12 +++-
net/core/flow_dissector.c | 12 ++--
net/core/net_namespace.c | 35 ++++++-----
net/core/pktgen.c | 17 ++---
net/core/sock_reuseport.c | 1 -
net/ethernet/eth.c | 2 +-
net/hsr/hsr_forward.c | 4 --
net/ipv4/af_inet.c | 2 +-
net/ipv4/fou.c | 4 +-
net/ipv4/gre_offload.c | 2 +-
net/ipv4/inet_hashtables.c | 8 ++-
net/ipv4/ip_output.c | 3 -
net/ipv4/ip_sockglue.c | 11 ++--
net/ipv4/ping.c | 2 +-
net/ipv4/raw.c | 2 +-
net/ipv4/sysctl_net_ipv4.c | 8 +--
net/ipv4/tcp_ipv4.c | 3 -
net/ipv4/udp.c | 15 ++++-
net/ipv4/udp_offload.c | 2 +-
net/ipv6/addrconf.c | 101 ++++++++++++------------------
net/ipv6/inet6_hashtables.c | 13 ++--
net/ipv6/ip6_offload.c | 2 +-
net/ipv6/ip6_tunnel.c | 3 +
net/ipv6/ipv6_sockglue.c | 3 +-
net/ipv6/mcast.c | 17 +++--
net/ipv6/ping.c | 2 +-
net/ipv6/raw.c | 2 +-
net/ipv6/reassembly.c | 3 +-
net/ipv6/route.c | 74 +++++++++++++++-------
net/ipv6/udp.c | 3 +-
net/l2tp/l2tp_ip.c | 2 +-
net/l2tp/l2tp_ip6.c | 2 +-
net/mac80211/aes_ccm.c | 46 +++++++++-----
net/mac80211/aes_ccm.h | 8 ++-
net/mac80211/aes_gcm.c | 43 ++++++++-----
net/mac80211/aes_gcm.h | 6 +-
net/mac80211/aes_gmac.c | 26 ++++----
net/mac80211/aes_gmac.h | 4 ++
net/mac80211/offchannel.c | 2 +-
net/mac80211/rx.c | 51 ++++++++++++---
net/mac80211/wpa.c | 22 +++----
net/ncsi/internal.h | 2 +
net/ncsi/ncsi-aen.c | 18 +++++-
net/ncsi/ncsi-manage.c | 126 +++++++++++++++++++++++++++----------
net/netfilter/core.c | 13 +---
net/netfilter/nf_conntrack_core.c | 2 +-
net/netfilter/nf_internals.h | 2 +-
net/netfilter/nf_queue.c | 48 ++++++++++-----
net/netfilter/nf_tables_api.c | 2 +-
net/netfilter/nft_dynset.c | 6 +-
net/netfilter/nft_exthdr.c | 3 +-
net/netfilter/nft_hash.c | 1 +
net/netfilter/nft_range.c | 26 +++++---
net/netfilter/x_tables.c | 2 +-
net/netfilter/xt_NFLOG.c | 1 +
net/netfilter/xt_hashlimit.c | 4 +-
net/netfilter/xt_ipcomp.c | 2 +
net/packet/af_packet.c | 9 ++-
net/rds/Makefile | 2 +-
net/rds/rds.h | 2 +-
net/rxrpc/call_object.c | 2 +-
net/rxrpc/peer_object.c | 4 +-
net/sched/act_api.c | 3 +-
net/sched/act_mirred.c | 5 +-
net/sched/cls_api.c | 3 +-
net/sctp/output.c | 8 ++-
net/sctp/sm_statefuns.c | 12 ++--
net/sctp/socket.c | 5 +-
net/switchdev/switchdev.c | 9 +++
net/tipc/bcast.c | 14 +++--
net/tipc/bcast.h | 3 +-
net/tipc/link.c | 2 +
net/tipc/msg.h | 17 +++++
net/tipc/name_distr.c | 1 +
net/tipc/node.c | 2 +-
net/wireless/sysfs.c | 5 +-
net/wireless/util.c | 34 +++++-----
samples/bpf/parse_ldabs.c | 1 +
samples/bpf/parse_simple.c | 1 +
samples/bpf/parse_varlen.c | 1 +
samples/bpf/tcbpf1_kern.c | 1 +
samples/bpf/tcbpf2_kern.c | 1 +
samples/bpf/test_cgrp2_tc_kern.c | 1 +
239 files changed, 1988 insertions(+), 1387 deletions(-)
^ permalink raw reply
* [net:master 113/114] drivers/net/vxlan.c:947:21: warning: unused variable 'sock6'
From: kbuild test robot @ 2016-10-30 1:16 UTC (permalink / raw)
To: pravin shelar; +Cc: kbuild-all, netdev
[-- Attachment #1: Type: text/plain, Size: 1802 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git master
head: fceb9c3e38252992bbf1a3028cc2f7b871211533
commit: c6fcc4fc5f8b592600c7409e769ab68da0fb1eca [113/114] vxlan: avoid using stale vxlan socket.
config: i386-randconfig-x012-201644 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
git checkout c6fcc4fc5f8b592600c7409e769ab68da0fb1eca
# save the attached .config to linux build tree
make ARCH=i386
All warnings (new ones prefixed by >>):
drivers/net/vxlan.c: In function 'vxlan_group_used':
>> drivers/net/vxlan.c:947:21: warning: unused variable 'sock6' [-Wunused-variable]
struct vxlan_sock *sock6 = NULL;
^~~~~
vim +/sock6 +947 drivers/net/vxlan.c
931 NUD_REACHABLE,
932 NLM_F_EXCL|NLM_F_CREATE,
933 vxlan->cfg.dst_port,
934 vxlan->default_dst.remote_vni,
935 0, NTF_SELF);
936 spin_unlock(&vxlan->hash_lock);
937 }
938
939 return false;
940 }
941
942 /* See if multicast group is already in use by other ID */
943 static bool vxlan_group_used(struct vxlan_net *vn, struct vxlan_dev *dev)
944 {
945 struct vxlan_dev *vxlan;
946 struct vxlan_sock *sock4;
> 947 struct vxlan_sock *sock6 = NULL;
948 unsigned short family = dev->default_dst.remote_ip.sa.sa_family;
949
950 sock4 = rtnl_dereference(dev->vn4_sock);
951
952 /* The vxlan_sock is only used by dev, leaving group has
953 * no effect on other vxlan devices.
954 */
955 if (family == AF_INET && sock4 && atomic_read(&sock4->refcnt) == 1)
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 28871 bytes --]
^ permalink raw reply
* Re: [PATCH net-next] genetlink: Fix generic netlink family unregister
From: David Miller @ 2016-10-30 0:58 UTC (permalink / raw)
To: pshelar; +Cc: netdev, johannes
In-Reply-To: <1477695701-1147-1-git-send-email-pshelar@ovn.org>
From: Pravin B Shelar <pshelar@ovn.org>
Date: Fri, 28 Oct 2016 16:01:41 -0700
> This patch fixes a typo in unregister operation.
>
> Following crash is fixed by this patch. It can be easily reproduced
> by repeating modprobe and rmmod module that uses genetlink.
...
> Fixes: 2ae0f17df1c ("genetlink: use idr to track families").
>
> Reported-by: Jarno Rajahalme <jarno@ovn.org>
> CC: Johannes Berg <johannes@sipsolutions.net>
> Signed-off-by: Pravin B Shelar <pshelar@ovn.org>
Applied, thank you.
^ permalink raw reply
* Re: [PATCH v2 net 2/2] geneve: avoid using stale geneve socket.
From: David Miller @ 2016-10-30 0:56 UTC (permalink / raw)
To: pshelar; +Cc: netdev
In-Reply-To: <1477673956-127319-2-git-send-email-pshelar@ovn.org>
From: Pravin B Shelar <pshelar@ovn.org>
Date: Fri, 28 Oct 2016 09:59:16 -0700
> This patch is similar to earlier vxlan patch.
> Geneve device close operation frees geneve socket. This
> operation can race with geneve-xmit function which
> dereferences geneve socket. Following patch uses RCU
> mechanism to avoid this situation.
>
> Signed-off-by: Pravin B Shelar <pshelar@ovn.org>
> Acked-by: John W. Linville <linville@tuxdriver.com>
Applied.
^ permalink raw reply
* Re: [PATCH v2 net 1/2] vxlan: avoid using stale vxlan socket.
From: David Miller @ 2016-10-30 0:56 UTC (permalink / raw)
To: pshelar; +Cc: netdev
In-Reply-To: <1477673956-127319-1-git-send-email-pshelar@ovn.org>
From: Pravin B Shelar <pshelar@ovn.org>
Date: Fri, 28 Oct 2016 09:59:15 -0700
> When vxlan device is closed vxlan socket is freed. This
> operation can race with vxlan-xmit function which
> dereferences vxlan socket. Following patch uses RCU
> mechanism to avoid this situation.
>
> Signed-off-by: Pravin B Shelar <pshelar@ovn.org>
Applied.
^ permalink raw reply
* Re: [PATCH net] qede: Fix out-of-bound fastpath memory access
From: David Miller @ 2016-10-30 0:52 UTC (permalink / raw)
To: Yuval.Mintz; +Cc: netdev
In-Reply-To: <1477749875-30529-1-git-send-email-Yuval.Mintz@cavium.com>
From: Yuval Mintz <Yuval.Mintz@cavium.com>
Date: Sat, 29 Oct 2016 17:04:35 +0300
> Driver allocates a shadow array for transmitted SKBs with X entries;
> That means valid indices are {0,...,X - 1}. [X == 8191]
> Problem is the driver also uses X as a mask for a
> producer/consumer in order to choose the right entry in the
> array which allows access to entry X which is out of bounds.
>
> To fix this, simply allocate X + 1 entries in the shadow array.
>
> Signed-off-by: Yuval Mintz <Yuval.Mintz@cavium.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next] ibmveth: v1 calculate correct gso_size and set gso_type
From: Jonathan Maxwell @ 2016-10-30 0:21 UTC (permalink / raw)
To: Eric Dumazet
Cc: Thomas Falcon, Jon Maxwell, hofrat, linux-kernel, jarod, netdev,
paulus, Tom Herbert, Marcelo Ricardo Leitner, linuxppc-dev,
David Miller
In-Reply-To: <1477591717.7065.237.camel@edumazet-glaptop3.roam.corp.google.com>
On Fri, Oct 28, 2016 at 5:08 AM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
> On Thu, 2016-10-27 at 12:54 -0500, Thomas Falcon wrote:
>> On 10/27/2016 10:26 AM, Eric Dumazet wrote:
>> > On Wed, 2016-10-26 at 11:09 +1100, Jon Maxwell wrote:
>> >> We recently encountered a bug where a few customers using ibmveth on the
>> >> same LPAR hit an issue where a TCP session hung when large receive was
>> >> enabled. Closer analysis revealed that the session was stuck because the
>> >> one side was advertising a zero window repeatedly.
>> >>
>> >> We narrowed this down to the fact the ibmveth driver did not set gso_size
>> >> which is translated by TCP into the MSS later up the stack. The MSS is
>> >> used to calculate the TCP window size and as that was abnormally large,
>> >> it was calculating a zero window, even although the sockets receive buffer
>> >> was completely empty.
>> >>
>> >> We were able to reproduce this and worked with IBM to fix this. Thanks Tom
>> >> and Marcelo for all your help and review on this.
>> >>
>> >> The patch fixes both our internal reproduction tests and our customers tests.
>> >>
>> >> Signed-off-by: Jon Maxwell <jmaxwell37@gmail.com>
>> >> ---
>> >> drivers/net/ethernet/ibm/ibmveth.c | 20 ++++++++++++++++++++
>> >> 1 file changed, 20 insertions(+)
>> >>
>> >> diff --git a/drivers/net/ethernet/ibm/ibmveth.c b/drivers/net/ethernet/ibm/ibmveth.c
>> >> index 29c05d0..c51717e 100644
>> >> --- a/drivers/net/ethernet/ibm/ibmveth.c
>> >> +++ b/drivers/net/ethernet/ibm/ibmveth.c
>> >> @@ -1182,6 +1182,8 @@ static int ibmveth_poll(struct napi_struct *napi, int budget)
>> >> int frames_processed = 0;
>> >> unsigned long lpar_rc;
>> >> struct iphdr *iph;
>> >> + bool large_packet = 0;
>> >> + u16 hdr_len = ETH_HLEN + sizeof(struct tcphdr);
>> >>
>> >> restart_poll:
>> >> while (frames_processed < budget) {
>> >> @@ -1236,10 +1238,28 @@ static int ibmveth_poll(struct napi_struct *napi, int budget)
>> >> iph->check = 0;
>> >> iph->check = ip_fast_csum((unsigned char *)iph, iph->ihl);
>> >> adapter->rx_large_packets++;
>> >> + large_packet = 1;
>> >> }
>> >> }
>> >> }
>> >>
>> >> + if (skb->len > netdev->mtu) {
>> >> + iph = (struct iphdr *)skb->data;
>> >> + if (be16_to_cpu(skb->protocol) == ETH_P_IP &&
>> >> + iph->protocol == IPPROTO_TCP) {
>> >> + hdr_len += sizeof(struct iphdr);
>> >> + skb_shinfo(skb)->gso_type = SKB_GSO_TCPV4;
>> >> + skb_shinfo(skb)->gso_size = netdev->mtu - hdr_len;
>> >> + } else if (be16_to_cpu(skb->protocol) == ETH_P_IPV6 &&
>> >> + iph->protocol == IPPROTO_TCP) {
>> >> + hdr_len += sizeof(struct ipv6hdr);
>> >> + skb_shinfo(skb)->gso_type = SKB_GSO_TCPV6;
>> >> + skb_shinfo(skb)->gso_size = netdev->mtu - hdr_len;
>> >> + }
>> >> + if (!large_packet)
>> >> + adapter->rx_large_packets++;
>> >> + }
>> >> +
>> >>
>> > This might break forwarding and PMTU discovery.
>> >
>> > You force gso_size to device mtu, regardless of real MSS used by the TCP
>> > sender.
>> >
>> > Don't you have the MSS provided in RX descriptor, instead of guessing
>> > the value ?
>> >
>> >
>> >
>> The MSS is not always available unfortunately, so this is the best solution there is at the moment.
>
> Hmm... then what about skb_shinfo(skb)->gso_segs ?
>
> ip_rcv() for example has :
>
> __IP_ADD_STATS(net,
> IPSTATS_MIB_NOECTPKTS + (iph->tos & INET_ECN_MASK),
> max_t(unsigned short, 1, skb_shinfo(skb)->gso_segs));
>
>
Okay thanks Eric. As the MSS is the main concern, let me work with the
team here and see if we find can a better way to do this. Will take care of
the other points you raised at the same time.
>
> Also prefer : (skb->protocol == htons(ETH_P_IP)) tests
>
> And the ipv6 test is wrong :
>
> } else if (be16_to_cpu(skb->protocol) == ETH_P_IPV6 &&
> iph->protocol == IPPROTO_TCP) {
>
>
> Since iph is a pointer to ipv4 iphdr .
>
>
>
^ permalink raw reply
* Re: [PATCH net-next 2/2] net/mlx4_en: Refactor the XDP forwarding rings scheme
From: Brenden Blanco @ 2016-10-29 23:18 UTC (permalink / raw)
To: Alexei Starovoitov; +Cc: Tariq Toukan, David S. Miller, netdev, Eran Ben Elisha
In-Reply-To: <20161028010701.GB49550@ast-mbp.thefacebook.com>
On Thu, Oct 27, 2016 at 06:07:02PM -0700, Alexei Starovoitov wrote:
> On Thu, Oct 27, 2016 at 05:52:04PM +0300, Tariq Toukan wrote:
> > Separately manage the two types of TX rings: regular ones, and XDP.
> > Upon an XDP set, do not borrow regular TX rings and convert them
> > into XDP ones, but allocate new ones, unless we hit the max number
> > of rings.
> > Which means that in systems with smaller #cores we will not consume
> > the current TX rings for XDP, while we are still in the num TX limit.
>
> The commit log is too scarce for details...
> So questions:
> - Did you test with changing the number of channels after xdp prog is loaded?
> That was the recent bug that Brenden fixed.
> - does it still have 256 tx queue limit or xdp tx rings can go over?
> - Any performance implications ?
>
> Brenden, could you please review this patch?
Sure, sorry for the delay...was traveling.
>
^ permalink raw reply
* Re: [PATCH net-next 1/1] net: phy: Add support for Microsemi VSC 8530/40 Fast Ethernet PHY
From: David Miller @ 2016-10-29 21:31 UTC (permalink / raw)
To: allan.nielsen; +Cc: netdev, andrew, raju.lakkaraju
In-Reply-To: <1477649411-31036-2-git-send-email-allan.nielsen@microsemi.com>
From: "Allan W. Nielsen" <allan.nielsen@microsemi.com>
Date: Fri, 28 Oct 2016 12:10:11 +0200
> From: Raju Lakkaraju <Raju.Lakkaraju@microsemi.com>
>
> Signed-off-by: Raju Lakkaraju <Raju.Lakkaraju@microsemi.com>
> Signed-off-by: Allan W. Nielsen <allan.nielsen@microsemi.com>
Applied.
^ permalink raw reply
* Re: pull-request: mac80211-next 2016-10-28
From: David Miller @ 2016-10-29 21:27 UTC (permalink / raw)
To: johannes-cdvu00un1VgdHxzADdlk8Q
Cc: netdev-u79uwXL29TY76Z2rM5mHXA,
linux-wireless-u79uwXL29TY76Z2rM5mHXA
In-Reply-To: <20161028070614.17583-1-johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
From: Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
Date: Fri, 28 Oct 2016 09:06:13 +0200
> First update for 4.10 - nothing major, new features as usual (FILS), and
> sometimes we deprecate old stuff (WDS).
>
> I don't have the fixes for the on-stack crypto/SG handling in this tree
> (you already have them via mac80211.git), but we did make sure that the
> fils_aead code doesn't re-introduce such an issue.
>
> Please pull and let me know if there's any problem.
Pulled, thanks Johannes.
^ permalink raw reply
* Re: [PATCH] net: phy: dp83848: add dp83822 PHY support
From: David Miller @ 2016-10-29 21:26 UTC (permalink / raw)
To: rogerq; +Cc: f.fainelli, afd, dmurphy, netdev, linux-kernel
In-Reply-To: <1477647620-7315-1-git-send-email-rogerq@ti.com>
From: Roger Quadros <rogerq@ti.com>
Date: Fri, 28 Oct 2016 12:40:20 +0300
> This PHY has a compatible register set with DP83848x so
> add support for it.
>
> Acked-by: Andrew F. Davis <afd@ti.com>
> Signed-off-by: Roger Quadros <rogerq@ti.com>
Applied.
^ permalink raw reply
* Re: [PATCH net] enic: fix rq disable
From: David Miller @ 2016-10-29 21:25 UTC (permalink / raw)
To: gvaradar; +Cc: netdev, benve, _govind
In-Reply-To: <20161027230103.35242-1-gvaradar@cisco.com>
From: Govindarajulu Varadarajan <gvaradar@cisco.com>
Date: Thu, 27 Oct 2016 16:01:03 -0700
> When MTU is changed from 9000 to 1500 while there is burst of inbound 9000
> bytes packets, adaptor sometimes delivers 9000 bytes packets to 1500 bytes
> buffers. This causes memory corruption and sometimes crash.
>
> This is because of a race condition in adaptor between "RQ disable"
> clearing descriptor mini-cache and mini-cache valid bit being set by
> completion of descriptor fetch. This can result in stale RQ desc being
> cached and used when packets arrive. In this case, the stale descriptor
> have old MTU value.
>
> Solution is to write RQ->disable twice. The first write will stop any
> further desc fetches, allowing the second disable to clear the mini-cache
> valid bit without danger of a race.
>
> Also, the check for rq->running becoming 0 after writing rq->enable to 0
> is not done properly. When incoming packets are flooding the interface,
> rq->running will pulse high for each dropped packet. Since the driver was
> waiting for 10us between each poll, it is possible to see rq->running = 1
> 1000 times in a row, even though it is not actually stuck running.
> This results in false failure of vnic_rq_disable(). Fix is to try more
> than 1000 time without delay between polls to ensure we do not miss when
> running goes low.
>
> In old adaptors rq->enable needs to be re-written to 0 when posted_index
> is reset in vnic_rq_clean() in order to keep rq->prefetch_index in sync.
>
> Signed-off-by: Govindarajulu Varadarajan <_govind@gmx.com>
Applied.
^ permalink raw reply
* Re: [PATCH net 1/1] tipc: fix broadcast link synchronization problem
From: David Miller @ 2016-10-29 21:21 UTC (permalink / raw)
To: jon.maloy
Cc: netdev, paul.gortmaker, parthasarathy.bhuvaragan, ying.xue, maloy,
tipc-discussion
In-Reply-To: <1477608715-28003-1-git-send-email-jon.maloy@ericsson.com>
From: Jon Maloy <jon.maloy@ericsson.com>
Date: Thu, 27 Oct 2016 18:51:55 -0400
> In commit 2d18ac4ba745 ("tipc: extend broadcast link initialization
> criteria") we tried to fix a problem with the initial synchronization
> of broadcast link acknowledge values. Unfortunately that solution is
> not sufficient to solve the issue.
>
> We have seen it happen that LINK_PROTOCOL/STATE packets with a valid
> non-zero unicast acknowledge number may bypass BCAST_PROTOCOL
> initialization, NAME_DISTRIBUTOR and other STATE packets with invalid
> broadcast acknowledge numbers, leading to premature opening of the
> broadcast link. When the bypassed packets finally arrive, they are
> inadvertently accepted, and the already correctly initialized
> acknowledge number in the broadcast receive link is overwritten by
> the invalid (zero) value of the said packets. After this the broadcast
> link goes stale.
>
> We now fix this by marking the packets where we know the acknowledge
> value is or may be invalid, and then ignoring the acks from those.
>
> To this purpose, we claim an unused bit in the header to indicate that
> the value is invalid. We set the bit to 1 in the initial BCAST_PROTOCOL
> synchronization packet and all initial ("bulk") NAME_DISTRIBUTOR
> packets, plus those LINK_PROTOCOL packets sent out before the broadcast
> links are fully synchronized.
>
> This minor protocol update is fully backwards compatible.
>
> Reported-by: John Thompson <thompa.atl@gmail.com>
> Tested-by: John Thompson <thompa.atl@gmail.com>
> Signed-off-by: Jon Maloy <jon.maloy@ericsson.com>
Applied, thanks Jon.
^ permalink raw reply
* Re: [PATCH net v1 2/2] ibmvnic: Fix missing brackets in init_sub_crq_irqs
From: David Miller @ 2016-10-29 21:19 UTC (permalink / raw)
To: tlfalcon; +Cc: netdev
In-Reply-To: <1477589332-513-2-git-send-email-tlfalcon@linux.vnet.ibm.com>
From: Thomas Falcon <tlfalcon@linux.vnet.ibm.com>
Date: Thu, 27 Oct 2016 12:28:52 -0500
> Signed-off-by: Thomas Falcon <tlfalcon@linux.vnet.ibm.com>
> ---
> v1: caught by kbuild bot with -Wmisleading-indentation after
> after submitting previous patch
Applied.
^ permalink raw reply
* Re: [PATCH net v2 1/2] ibmvnic: Fix releasing of sub-CRQ IRQs in interrupt context
From: David Miller @ 2016-10-29 21:19 UTC (permalink / raw)
To: tlfalcon; +Cc: netdev
In-Reply-To: <1477589332-513-1-git-send-email-tlfalcon@linux.vnet.ibm.com>
From: Thomas Falcon <tlfalcon@linux.vnet.ibm.com>
Date: Thu, 27 Oct 2016 12:28:51 -0500
> Schedule these XPORT event tasks in the shared workqueue
> so that IRQs are not freed in an interrupt context when
> sub-CRQs are released.
>
> Signed-off-by: Thomas Falcon <tlfalcon@linux.vnet.ibm.com>
> ---
> v2: correct warnings by kbuild bot
Applied.
^ permalink raw reply
* Re: [patch net-next v2] rocker: set physical device for port netdevice
From: David Miller @ 2016-10-29 21:16 UTC (permalink / raw)
To: jiri; +Cc: netdev
In-Reply-To: <1477600342-2752-1-git-send-email-jiri@resnulli.us>
From: Jiri Pirko <jiri@resnulli.us>
Date: Thu, 27 Oct 2016 22:32:22 +0200
> From: Jiri Pirko <jiri@mellanox.com>
>
> Do this so the sysfs has "device" link correctly set.
>
> Signed-off-by: Jiri Pirko <jiri@mellanox.com>
> ---
> v1->v2:
> - make pdev non-const as pointerd out by kbuild test robot
Applied, thanks Jiri.
^ permalink raw reply
* Re: [net 0/4][pull request] Intel Wired LAN Driver Updates 2016-10-27
From: David Miller @ 2016-10-29 21:14 UTC (permalink / raw)
To: jeffrey.t.kirsher; +Cc: netdev, nhorman, sassmann, jogreene, guru.anbalagane
In-Reply-To: <1477603677-39957-1-git-send-email-jeffrey.t.kirsher@intel.com>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Thu, 27 Oct 2016 14:27:53 -0700
> This series contains fixes to ixgbe and i40e.
Pulled, thanks Jeff.
^ permalink raw reply
* Re: [PATCH net-next] tcp_bbr: add a state transition diagram and accompanying comment
From: David Miller @ 2016-10-29 21:13 UTC (permalink / raw)
To: ncardwell; +Cc: netdev, ycheng, edumazet, soheil
In-Reply-To: <1477589197-18123-1-git-send-email-ncardwell@google.com>
From: Neal Cardwell <ncardwell@google.com>
Date: Thu, 27 Oct 2016 13:26:37 -0400
> Document the possible state transitions for a BBR flow, and also add a
> prose summary of the state machine, covering the life of a typical BBR
> flow.
>
> Signed-off-by: Neal Cardwell <ncardwell@google.com>
> Signed-off-by: Yuchung Cheng <ycheng@google.com>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Signed-off-by: Soheil Hassas Yeganeh <soheil@google.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next v1 04/16] tipc: rename struct tipc_skb_cb member handle to bytes_read
From: David Miller @ 2016-10-29 21:01 UTC (permalink / raw)
To: parthasarathy.bhuvaragan; +Cc: jon.maloy, netdev, tipc-discussion
In-Reply-To: <1477578157-13256-5-git-send-email-parthasarathy.bhuvaragan@ericsson.com>
From: Parthasarathy Bhuvaragan <parthasarathy.bhuvaragan@ericsson.com>
Date: Thu, 27 Oct 2016 16:22:25 +0200
> @@ -95,7 +95,7 @@ struct plist;
> #define TIPC_MEDIA_INFO_OFFSET 5
>
> struct tipc_skb_cb {
> - void *handle;
> + u32 bytes_read;
> struct sk_buff *tail;
> bool validated;
> bool wakeup_pending;
If this is now a u32, then:
> - u32 offset = (u32)(unsigned long)(TIPC_SKB_CB(buf)->handle);
> + u32 offset = (u32)(TIPC_SKB_CB(buf)->bytes_read);
This cast is unnecessary as are the parenthesis.
------------------------------------------------------------------------------
The Command Line: Reinvented for Modern Developers
Did the resurgence of CLI tooling catch you by surprise?
Reconnect with the command line and become more productive.
Learn the new .NET and ASP.NET CLI. Get your free copy!
http://sdm.link/telerik
^ permalink raw reply
* Re: [PATCH v7 0/6] Add eBPF hooks for cgroups
From: Daniel Borkmann @ 2016-10-29 20:29 UTC (permalink / raw)
To: Lorenzo Colitti, Alexei Starovoitov
Cc: Daniel Mack, Pablo Neira Ayuso, htejun, ast, David Miller, kafai,
Florian Westphal, harald, netdev@vger.kernel.org, Sargun Dhillon,
cgroups
In-Reply-To: <CAKD1Yr3QfL-biSjQfFgzjMFNoLV7FP9DSB=KNbp+_KyxyQmVMg@mail.gmail.com>
On 10/29/2016 05:34 PM, Lorenzo Colitti wrote:
> On Sat, Oct 29, 2016 at 3:24 PM, Alexei Starovoitov
> <alexei.starovoitov@gmail.com> wrote:
>> it could be solved by swapping the order of cgroup_bpf_run_filter()
>> and NF_INET_POST_ROUTING in patch 5. It was proposed some time back, but
>> the current patch, I think, is more symmetrical.
>> cgroup+bpf runs after nf hook on rx and runs before it on tx.
>> imo it's more consistent.
>
> I guess what I was trying to say was: what does doing this filtering
> in ip_output give you over running this from the netfilter hooks?
> Doing this filtering in netfilter is much more general because there
> can be complex rules both before and after the filtering is applied. I
> hadn't thought of the scalability issue you note below though.
>
> For accounting you probably want to run after the hooks, both for
> ingress and for egress, because the hooks can do all sorts of stuff
> like drop packets, change packet sizes, reroute them to different
> interfaces, etc. Do you see use cases where you want to run before the
> hooks?
Fwiw, not sure if swapping brings much, even after netfilter there could
be complex processing that would potentially drop, mangle, redirect, etc
from tc layer (egress or from qdisc itself). But also at even lower layers
(although rather unlikely, but not impossible), for example in drivers or
shortly before passing skb to them during segmentation (GSO), etc.
Eventually, for that you'd need to monitor various things, and the cgroup
one is just at higher layers with different semantics.
>> Regardless of this choice... are you going to backport cgroupv2 to
>> android? Because this set is v2 only.
>
> Certainly anything that can't easily be backported to, say,
> android-4.4 is not really feasible in the short term. I don't think we
> use network cgroups at all, so if v2 network cgroups can coexist with
> v1 cgroups of other types (which what little I've read seems to
> indicate) then that should be possible.
>
>> yes. that's certainly doable, but sooner or later such approach will hit
>> scalability issue when number of cgroups is large. Same issue we saw
>> with cls_bpf and bpf_skb_under_cgroup(). Hence this patch set was needed
>> that is centered around cgroups instead of hooks. Note, unlike, tc and nf
>> there is no way to attach to a hook. The bpf program is attached to a cgroup.
>> It's an important distinction vs everything that currently exists in the stack.
>
> Ah, I see. Out of curiosity, what was the first scaling limitation you
> hit? eBPF program length? eBPF map size?
The scalability issue is not really program length or map size from eBPF
side in this context. While for v1, you have the bpf_get_cgroup_classid()
helper available on egress (not ingress though) that can scale with larger
number of cgroups since it works on the user-defined net_cls tagging, but
for v2, bpf_skb_under_cgroup() was initially introduced, which can only test
whether the sk's v2 cgroup related to the skb is in the sub-hierarchy of
a specific cgroup that is provided via maps. Effectively, when you have a
larger number of v2 cgroups that boolean test will not scale and you need
to linearly test through various cgroups. It's good enough when need to
special case only few cgroups in the v2 hierarchy on egress. Idea was that
attaching to cgroup itself would resolve this from a different angle for
egress and also ingress in a complementary way, but also seems to open up
for various other use-cases at the same time as seen from various patches
on the list.
Cheers,
Daniel
^ permalink raw reply
* Re: [PATCH 00/17] pull request for net-next: batman-adv 2016-10-27
From: David Miller @ 2016-10-29 20:28 UTC (permalink / raw)
To: sw-2YrNx6rUIHYiY0qSoAWiAoQuADTiUCJX
Cc: netdev-u79uwXL29TY76Z2rM5mHXA,
b.a.t.m.a.n-ZwoEplunGu2X36UT3dwllkB+6BGkLq7r
In-Reply-To: <20161027190150.7880-1-sw-2YrNx6rUIHYiY0qSoAWiAoQuADTiUCJX@public.gmane.org>
From: Simon Wunderlich <sw-2YrNx6rUIHYiY0qSoAWiAoQuADTiUCJX@public.gmane.org>
Date: Thu, 27 Oct 2016 21:01:33 +0200
> this is our first feature pull request for batman-adv (mostly
> containing code cleanup stuff), there are at least two more to come.
>
> Please pull or let me know of any problem!
Pulled, thanks Simon.
^ permalink raw reply
* Re: [PATCH net 00/10] mlx4 misc fixes for 4.9
From: David Miller @ 2016-10-29 20:24 UTC (permalink / raw)
To: tariqt; +Cc: netdev, eranbe
In-Reply-To: <1477574842-29688-1-git-send-email-tariqt@mellanox.com>
From: Tariq Toukan <tariqt@mellanox.com>
Date: Thu, 27 Oct 2016 16:27:12 +0300
> This patchset contains several bug fixes from the team to the
> mlx4 Eth and Core drivers.
>
> Series generated against net commit:
> ecc515d7238f 'sctp: fix the panic caused by route update'
Series applied, thanks Tariq.
^ permalink raw reply
* Re: [net-next 00/17][pull request] 40GbE Intel Wired LAN Driver Updates 2016-10-28
From: David Miller @ 2016-10-29 20:21 UTC (permalink / raw)
To: jeffrey.t.kirsher; +Cc: netdev, nhorman, sassmann, jogreene, guru.anbalagane
In-Reply-To: <1477726258-111563-1-git-send-email-jeffrey.t.kirsher@intel.com>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Sat, 29 Oct 2016 00:30:41 -0700
> This series contains updates to i40e and i40evf only.
Pulled, thanks Jeff.
^ permalink raw reply
* [PATCH net-next] firewire: net: really fix maximum possible MTU
From: Stefan Richter @ 2016-10-29 20:16 UTC (permalink / raw)
To: David S. Miller; +Cc: netdev, linux1394-devel, Jarod Wilson, linux-kernel
In-Reply-To: <20161023163056.6bc38610@kant>
The maximum unicast datagram size /without/ link fragmentation is
4096 - 4 = 4092 (max IEEE 1394 async payload size at >= S800 bus speed,
minus unfragmented encapssulation header). Max broadcast datagram size
without fragmentation is 8 bytes less than that (due to GASP header).
The maximum datagram size /with/ link fragmentation is 0xfff = 4095
for unicast and broadcast. This is because the RFC 2734 fragment
encapsulation header field for datagram size is only 12 bits wide.
Fixes: 5d48f00d836a('firewire: net: fix maximum possible MTU')
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
---
drivers/firewire/net.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/firewire/net.c b/drivers/firewire/net.c
index 03715e7d9d92..363fc5ec1a4e 100644
--- a/drivers/firewire/net.c
+++ b/drivers/firewire/net.c
@@ -1465,7 +1465,7 @@ static int fwnet_probe(struct fw_unit *unit,
net->mtu = 1500U;
net->min_mtu = ETH_MIN_MTU;
- net->max_mtu = ETH_MAX_MTU;
+ net->max_mtu = 0xfff;
/* Set our hardware address while we're at it */
ha = (union fwnet_hwaddr *)net->dev_addr;
--
Stefan Richter
-======----- =-=- ===-=
http://arcgraph.de/sr/
^ permalink raw reply related
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox