* Re: wl1251 & mac address & calibration data
From: Arend Van Spriel @ 2016-12-18 11:54 UTC (permalink / raw)
To: Pali Rohár
Cc: Daniel Wagner, Luis R. Rodriguez, Tom Gundersen, Johannes Berg,
Ming Lei, Mimi Zohar, Bjorn Andersson, Rafał Miłecki,
Kalle Valo, Sebastian Reichel, Pavel Machek, Michal Kazior,
Ivaylo Dimitrov, Aaro Koskinen, Tony Lindgren, linux-wireless,
Network Development, linux-kernel@vger.kernel.org
In-Reply-To: <201612181204.52928@pali>
On 18-12-2016 12:04, Pali Rohár wrote:
> On Sunday 18 December 2016 11:49:53 Arend Van Spriel wrote:
>> On 16-12-2016 11:40, Pali Rohár wrote:
>>> On Friday 16 December 2016 08:25:44 Daniel Wagner wrote:
>>>> On 12/16/2016 03:03 AM, Luis R. Rodriguez wrote:
>>>>> For the new API a solution for "fallback mechanisms" should be
>>>>> clean though and I am looking to stay as far as possible from the
>>>>> existing mess. A solution to help both the old API and new API is
>>>>> possible for the "fallback mechanism" though -- but for that I
>>>>> can only refer you at this point to some of Daniel Wagner and
>>>>> Tom Gunderson's firmwared deamon prospect. It should help pave
>>>>> the way for a clean solution and help address other stupid
>>>>> issues.
>>>>
>>>> The firmwared project is hosted here
>>>>
>>>> https://github.com/teg/firmwared
>>>>
>>>> As Luis pointed out, firmwared relies on
>>>> FW_LOADER_USER_HELPER_FALLBACK, which is not enabled by default.
>>>
>>> I know. But it does not mean that I cannot enable this option at
>>> kernel compile time.
>>>
>>> Bigger problem is that currently request_firmware() first try to
>>> load firmware directly from VFS and after that (if fails) fallback
>>> to user helper.
>>>
>>> So I would need to extend kernel firmware code with new function
>>> (or flag) to not use VFS and try only user mode helper.
>>
>> Why do you need the user-mode helper anyway. This is all static data,
>> right?
>
> Those are static data, but device specific!
So what?
>> So why not cook up a firmware file in user-space once and put
>> it in /lib/firmware for the driver to request directly.
>
> 1. Violates FHS
How?
> 2. Does not work for readonly /, readonly /lib, readonly /lib/firmware
Que?
> 3. Backup & restore of rootfs between same devices does not work (as
> rootfs now contains device specific data).
True.
> 4. Sharing one rootfs (either via nfs or other technology) does not work
> for more devices (even in state when rootfs is used only by one device
> at one time).
Indeed.
> And it is common that N900 developers have rootfs in laptop and via usb
> (cdc_ether) exports it over nfs to N900 device and boot system. It
> basically break booting from one nfs-exported rootfs, as that export
> become model specific...
These are all you choices and more a logistic issue. If your take is
that udev is the way to solve those, fine by me.
>> Seems a bit
>> overkill to have a {e,}udev or whatever daemon running if the result
>> is always the same. Just my 2 cents.
>
> No it is not. It will break couple of other things in Linux and device
Now I am curious. What "couple of other things" will be broken.
> and model specific calibration data should not be in /lib/firmware! That
> directory is used for firmware files, not calibration.
What is "firmware"? Really. These are binary blobs required to make the
device work. And guess what, your device needs calibration data. Why
make the distinction.
Regards,
Arend
^ permalink raw reply
* Re: wl1251 & mac address & calibration data
From: Pali Rohár @ 2016-12-18 11:04 UTC (permalink / raw)
To: Arend Van Spriel
Cc: Daniel Wagner, Luis R. Rodriguez, Tom Gundersen, Johannes Berg,
Ming Lei, Mimi Zohar, Bjorn Andersson, Rafał Miłecki,
Kalle Valo, Sebastian Reichel, Pavel Machek, Michal Kazior,
Ivaylo Dimitrov, Aaro Koskinen, Tony Lindgren, linux-wireless,
Network Development, linux-kernel@vger.kernel.org
In-Reply-To: <68166247-bcd3-f598-7f9e-2139e732233e@broadcom.com>
[-- Attachment #1: Type: Text/Plain, Size: 2610 bytes --]
On Sunday 18 December 2016 11:49:53 Arend Van Spriel wrote:
> On 16-12-2016 11:40, Pali Rohár wrote:
> > On Friday 16 December 2016 08:25:44 Daniel Wagner wrote:
> >> On 12/16/2016 03:03 AM, Luis R. Rodriguez wrote:
> >>> For the new API a solution for "fallback mechanisms" should be
> >>> clean though and I am looking to stay as far as possible from the
> >>> existing mess. A solution to help both the old API and new API is
> >>> possible for the "fallback mechanism" though -- but for that I
> >>> can only refer you at this point to some of Daniel Wagner and
> >>> Tom Gunderson's firmwared deamon prospect. It should help pave
> >>> the way for a clean solution and help address other stupid
> >>> issues.
> >>
> >> The firmwared project is hosted here
> >>
> >> https://github.com/teg/firmwared
> >>
> >> As Luis pointed out, firmwared relies on
> >> FW_LOADER_USER_HELPER_FALLBACK, which is not enabled by default.
> >
> > I know. But it does not mean that I cannot enable this option at
> > kernel compile time.
> >
> > Bigger problem is that currently request_firmware() first try to
> > load firmware directly from VFS and after that (if fails) fallback
> > to user helper.
> >
> > So I would need to extend kernel firmware code with new function
> > (or flag) to not use VFS and try only user mode helper.
>
> Why do you need the user-mode helper anyway. This is all static data,
> right?
Those are static data, but device specific!
> So why not cook up a firmware file in user-space once and put
> it in /lib/firmware for the driver to request directly.
1. Violates FHS
2. Does not work for readonly /, readonly /lib, readonly /lib/firmware
3. Backup & restore of rootfs between same devices does not work (as
rootfs now contains device specific data).
4. Sharing one rootfs (either via nfs or other technology) does not work
for more devices (even in state when rootfs is used only by one device
at one time).
And it is common that N900 developers have rootfs in laptop and via usb
(cdc_ether) exports it over nfs to N900 device and boot system. It
basically break booting from one nfs-exported rootfs, as that export
become model specific...
> Seems a bit
> overkill to have a {e,}udev or whatever daemon running if the result
> is always the same. Just my 2 cents.
No it is not. It will break couple of other things in Linux and device
and model specific calibration data should not be in /lib/firmware! That
directory is used for firmware files, not calibration.
--
Pali Rohár
pali.rohar@gmail.com
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply
* Re: wl1251 & mac address & calibration data
From: Arend Van Spriel @ 2016-12-18 10:49 UTC (permalink / raw)
To: Pali Rohár, Daniel Wagner
Cc: Luis R. Rodriguez, Tom Gundersen, Johannes Berg, Ming Lei,
Mimi Zohar, Bjorn Andersson, Rafał Miłecki, Kalle Valo,
Sebastian Reichel, Pavel Machek, Michal Kazior, Ivaylo Dimitrov,
Aaro Koskinen, Tony Lindgren, linux-wireless, Network Development,
linux-kernel@vger.kernel.org, David Woodhouse
In-Reply-To: <201612161140.27241@pali>
On 16-12-2016 11:40, Pali Rohár wrote:
> On Friday 16 December 2016 08:25:44 Daniel Wagner wrote:
>> On 12/16/2016 03:03 AM, Luis R. Rodriguez wrote:
>>> For the new API a solution for "fallback mechanisms" should be
>>> clean though and I am looking to stay as far as possible from the
>>> existing mess. A solution to help both the old API and new API is
>>> possible for the "fallback mechanism" though -- but for that I can
>>> only refer you at this point to some of Daniel Wagner and Tom
>>> Gunderson's firmwared deamon prospect. It should help pave the way
>>> for a clean solution and help address other stupid issues.
>>
>> The firmwared project is hosted here
>>
>> https://github.com/teg/firmwared
>>
>> As Luis pointed out, firmwared relies on
>> FW_LOADER_USER_HELPER_FALLBACK, which is not enabled by default.
>
> I know. But it does not mean that I cannot enable this option at kernel
> compile time.
>
> Bigger problem is that currently request_firmware() first try to load
> firmware directly from VFS and after that (if fails) fallback to user
> helper.
>
> So I would need to extend kernel firmware code with new function (or
> flag) to not use VFS and try only user mode helper.
Why do you need the user-mode helper anyway. This is all static data,
right? So why not cook up a firmware file in user-space once and put it
in /lib/firmware for the driver to request directly. Seems a bit
overkill to have a {e,}udev or whatever daemon running if the result is
always the same. Just my 2 cents.
Regards,
Arend
^ permalink raw reply
* Re: mlx4: Bug in XDP_TX + 16 rx-queues
From: Tariq Toukan @ 2016-12-18 10:31 UTC (permalink / raw)
To: Martin KaFai Lau, Saeed Mahameed, Tariq Toukan
Cc: netdev@vger.kernel.org, Alexei Starovoitov
In-Reply-To: <20161217101803.GB8732@kafai-mba.local>
Hi Martin,
On 17/12/2016 12:18 PM, Martin KaFai Lau wrote:
> Hi All,
>
> I have been debugging with XDP_TX and 16 rx-queues.
>
> 1) When 16 rx-queues is used and an XDP prog is doing XDP_TX,
> it seems that the packet cannot be XDP_TX out if the pkt
> is received from some particular CPUs (/rx-queues).
Does the rx_xdp_tx_full counter increase?
Does the problem repro if you turn off PFC?
ethtool -A <intf> rx off tx off
>
> 2) If 8 rx-queues is used, it does not have problem.
>
> 3) The 16 rx-queues problem also went away after reverting these
> two patches:
> 15fca2c8eb41 net/mlx4_en: Add ethtool statistics for XDP cases
> 67f8b1dcb9ee net/mlx4_en: Refactor the XDP forwarding rings scheme
>
> 4) I can reproduce the problem by running samples/bof/xdp_ip_tunnel at
> the receiver side. The sender side sends out TCP packets with
> source port ranging from 1 to 1024. At the sender side also, do
> a tcpdump to capture the ip-tunnel packet reflected by xdp_ip_tunnel.
> With 8 rx-queues, I can get all 1024 packets back. With 16 rx-queues,
> I can only get 512 packets back. It is a 40 CPUs machine.
> I also checked the rx*_xdp_tx counters (from ethtool -S eth0) to ensure
> the xdp prog has XDP_TX-ed it out.
So all packets were transmitted (according to rx*_xdp_tx), and only half
the of them received on the other side?
>
> Not saying that 67f8b1dcb9ee is 100% the cause because there are other
> changes since then. It is merely a brain dump on what I have already
> tried.
>
> Tariq/Saeed, any thoughts? I can easily test some patches in
> my setup.
>
> Thanks,
> --Martin
Thanks,
Tariq
^ permalink raw reply
* RE: [PATCH] qed: fix memory leak of a qed_spq_entry on error failure paths
From: Mintz, Yuval @ 2016-12-18 6:33 UTC (permalink / raw)
To: Colin King, netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Elior, Ariel, Tayar, Tomer
In-Reply-To: <20161216125039.20969-1-colin.king@canonical.com>
> From: Colin Ian King <colin.king@canonical.com>
>
> A qed_spq_entry entry is allocated by qed_sp_init_request but is not kfree'd
> if an error occurs, causing a memory leak. Fix this by kfree'ing it and also
> setting *pp_ent to NULL to be safe.
>
> Found with static analysis by CoverityScan, CIDs 1389468-1389470
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
...
> +err:
> + kfree(*pp_ent);
> + *pp_ent = NULL;
> +
> + return rc;
> }
Hi Colin - thanks for this.
It would have been preferable to return the previously allocated spq entry.
I.e., do:
+err:
+ qed_spq_return_entry(p_hwfn, *pp_ent);
+ *pp_ent = NULL;
+ return rc;
Thanks,
Yuval
^ permalink raw reply
* Re: [PATCH net] ipvlan: fix crash
From: David Miller @ 2016-12-18 4:54 UTC (permalink / raw)
To: mahesh; +Cc: netdev, edumazet, maheshb
In-Reply-To: <1482027379-30785-1-git-send-email-mahesh@bandewar.net>
From: Mahesh Bandewar <mahesh@bandewar.net>
Date: Sat, 17 Dec 2016 18:16:19 -0800
> diff --git a/drivers/net/ipvlan/ipvlan_core.c b/drivers/net/ipvlan/ipvlan_core.c
> index b4e990743e1d..4294fc1f5564 100644
> --- a/drivers/net/ipvlan/ipvlan_core.c
> +++ b/drivers/net/ipvlan/ipvlan_core.c
> @@ -660,6 +660,9 @@ rx_handler_result_t ipvlan_handle_frame(struct sk_buff **pskb)
> if (!port)
> return RX_HANDLER_PASS;
>
> + if (unlikely(!pskb_may_pull(skb, sizeof(struct ethhdr))))
> + goto out;
> +
> switch (port->mode) {
ipvlan only allows non-loopback ethernet devices to register
this RX handler.
Such situations being tested here should therefore be completely
impossible.
Every such device must send the SKB through eth_type_trans(), which
unconditionally accesses the ethernet header, therefore it must
be pulled into the linear SKB area already, long before this RX
handler is invoked.
If this really can legitimately happen, you must explain how so.
Just showing the crash that later happens in some (completely
unrelated BTW) ipvlan multicast workqueue handling function, is
really an insufficient commit log message for a bug like this.
^ permalink raw reply
* (unknown),
From: netdev @ 2016-12-18 4:04 UTC (permalink / raw)
To: netdev; +Cc: iqhm, 651366975, uqhzj, 139563427260, cvhv, pinz, 96948314
[-- Attachment #1: ONLINE-311698597317131.zip --]
[-- Type: application/zip, Size: 16286 bytes --]
^ permalink raw reply
* (unknown),
From: netdev @ 2016-12-18 2:58 UTC (permalink / raw)
To: netdev; +Cc: xhgn, 561383013161808, sjuud, 1197, skqi, vqjs, 2752446077
[-- Attachment #1: EMAIL-6394134655.zip --]
[-- Type: application/zip, Size: 16284 bytes --]
^ permalink raw reply
* [GIT] Networking
From: David Miller @ 2016-12-18 2:55 UTC (permalink / raw)
To: torvalds; +Cc: akpm, netdev, linux-kernel
1) Revert bogus nla_ok() change, from Alexey Dobriyan.
2) Various bpf validator fixes from Daniel Borkmann.
3) Add some necessary SET_NETDEV_DEV() calls to hsis_femac and hip04
drivers, from Dongpo Li.
4) Several ethtool ksettings conversions from Philippe Reynes.
5) Fix bugs in inet port management wrt. soreuseport, from Tom
Herbert.
6) XDP support for virtio_net, from John Fastabend.
7) Fix NAT handling within a vrf, from David Ahern.
8) Endianness fixes in dpaa_eth driver, from Claudiu Manoil.
Please pull, thanks a lot!
The following changes since commit 8fa3b6f9392bf6d90cb7b908e07bd90166639f0a:
Merge tag 'cris-for-4.10' of git://git.kernel.org/pub/scm/linux/kernel/git/jesper/cris (2016-12-12 09:06:38 -0800)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git
for you to fetch changes up to 3e3397e7b11ce1b9526975ddfbe8dd569fc1f316:
net: mv643xx_eth: fix build failure (2016-12-17 21:47:26 -0500)
----------------------------------------------------------------
Alexey Dobriyan (1):
netlink: revert broken, broken "2-clause nla_ok()"
Andrew Lunn (1):
net: dsa: mv88e6xxx: Fix opps when adding vlan bridge
Andy Lutomirski (1):
cgroup: Fix CGROUP_BPF config
Arnd Bergmann (1):
qed: fix old-style function definition
Bartosz Folta (1):
net: macb: Added PCI wrapper for Platform Driver.
Ben Greear (1):
mac80211: fix legacy and invalid rx-rate report
Cedric Izoard (1):
mac80211: Ensure enough headroom when forwarding mesh pkt
Claudiu Manoil (1):
dpaa_eth: use big endian accessors
Dan Carpenter (1):
irda: w83977af_ir: cleanup an indent issue
Daniel Borkmann (5):
bpf: fix regression on verifier pruning wrt map lookups
bpf, test_verifier: fix a test case error result on unprivileged
bpf: dynamically allocate digest scratch buffer
bpf: fix overflow in prog accounting
bpf: fix mark_reg_unknown_value for spilled regs on map value marking
Daniel Mack (1):
bpf: cgroup: annotate pointers in struct cgroup_bpf with __rcu
David Ahern (2):
net: vrf: Fix NAT within a VRF
net: vrf: Drop conntrack data after pass through VRF device on Tx
David S. Miller (8):
Merge branch 'hisilicon-netdev-dev'
Merge branch 'cls_flower-mask'
Merge branch 'inet_csk_get_port-and-soreusport-fixes'
Merge branch 'dpaa_eth-fixes'
Merge branch 'virtio_net-XDP'
Merge branch 'gtp-fixes'
Merge branch 'bpf-fixes'
Merge tag 'mac80211-for-davem-2016-12-16' of git://git.kernel.org/.../jberg/mac80211
Dongpo Li (2):
net: ethernet: hisi_femac: Call SET_NETDEV_DEV()
net: ethernet: hip04: Call SET_NETDEV_DEV()
Emese Revfy (1):
isdn: Constify some function parameters
Harald Welte (1):
gtp: Fix initialization of Flags octet in GTPv1 header
Ido Schimmel (1):
mlxsw: spectrum: Mark split ports as such
Jason Wang (1):
virtio-net: correctly enable multiqueue
Jeroen De Wachter (2):
encx24j600: bugfix - always move ERXTAIL to next packet in encx24j600_rx_packets
encx24j600: Fix some checkstyle warnings
Johannes Berg (1):
mac80211: don't call drv_set_default_unicast_key() for VLANs
John Fastabend (5):
net: xdp: add invalid buffer warning
virtio_net: Add XDP support
virtio_net: add dedicated XDP transmit queues
virtio_net: add XDP_TX support
virtio_net: xdp, add slowpath case for non contiguous buffers
Kees Cook (7):
isdn/gigaset: use designated initializers
ATM: use designated initializers
net: use designated initializers
WAN: use designated initializers
bna: use designated initializers
isdn: use designated initializers
net/x25: use designated initializers
LABBE Corentin (5):
irda: irproc.c: Remove unneeded linux/miscdevice.h include
irda: irnet: Move linux/miscdevice.h include
irnet: ppp: move IRNET_MINOR to include/linux/miscdevice.h
irda: irnet: Remove unused IRNET_MAJOR define
irda: irnet: add member name to the miscdevice declaration
Lionel Gauthier (1):
gtp: gtp_check_src_ms_ipv4() always return success
Madalin Bucur (2):
dpaa_eth: remove redundant dependency on FSL_SOC
MAINTAINERS: net: add entry for Freescale QorIQ DPAA Ethernet driver
Mantas M (1):
net: ipv6: check route protocol when deleting routes
Manuel Bessler (1):
r6040: move spinlock in r6040_close as SOFTIRQ-unsafe lock order detected
Paul Blakey (2):
net/sched: cls_flower: Use mask for addr_type
net/sched: cls_flower: Use masked key when calling HW offloads
Philippe Reynes (5):
net: chelsio: cxgb2: use new api ethtool_{get|set}_link_ksettings
net: chelsio: cxgb3: use new api ethtool_{get|set}_link_ksettings
net: cirrus: ep93xx: use new api ethtool_{get|set}_link_ksettings
net: davicom: dm9000: use new api ethtool_{get|set}_link_ksettings
net: sfc: use new api ethtool_{get|set}_link_ksettings
Sudip Mukherjee (1):
net: mv643xx_eth: fix build failure
Thomas Falcon (1):
ibmveth: calculate gso_segs for large packets
Thomas Gleixner (1):
net/3com/3c515: Fix timer handling, prevent leaks and crashes
Timur Tabi (1):
net: qcom/emac: don't try to claim clocks on ACPI systems
Tom Herbert (2):
inet: Don't go into port scan when looking for specific bind port
inet: Fix get port to handle zero port number with soreuseport set
Xin Long (2):
sctp: sctp_epaddr_lookup_transport should be protected by rcu_read_lock
sctp: sctp_transport_lookup_process should rcu_read_unlock when transport is null
MAINTAINERS | 6 ++
drivers/isdn/gigaset/bas-gigaset.c | 32 +++---
drivers/isdn/gigaset/ser-gigaset.c | 32 +++---
drivers/isdn/gigaset/usb-gigaset.c | 32 +++---
drivers/isdn/hisax/config.c | 16 +--
drivers/isdn/hisax/hisax.h | 4 +-
drivers/isdn/i4l/isdn_concap.c | 6 +-
drivers/isdn/i4l/isdn_x25iface.c | 16 +--
drivers/net/dsa/mv88e6xxx/chip.c | 6 ++
drivers/net/ethernet/3com/3c515.c | 15 +--
drivers/net/ethernet/brocade/bna/bna_enet.c | 8 +-
drivers/net/ethernet/cadence/Kconfig | 9 ++
drivers/net/ethernet/cadence/Makefile | 1 +
drivers/net/ethernet/cadence/macb.c | 31 +++++-
drivers/net/ethernet/cadence/macb_pci.c | 153 ++++++++++++++++++++++++++++
drivers/net/ethernet/chelsio/cxgb/cxgb2.c | 64 +++++++-----
drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c | 65 ++++++------
drivers/net/ethernet/cirrus/ep93xx_eth.c | 14 +--
drivers/net/ethernet/davicom/dm9000.c | 14 +--
drivers/net/ethernet/freescale/dpaa/Kconfig | 2 +-
drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 71 ++++++-------
drivers/net/ethernet/hisilicon/hip04_eth.c | 2 +-
drivers/net/ethernet/hisilicon/hisi_femac.c | 2 +-
drivers/net/ethernet/ibm/ibmveth.c | 12 ++-
drivers/net/ethernet/marvell/mv643xx_eth.c | 2 +-
drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 2 +-
drivers/net/ethernet/microchip/encx24j600-regmap.c | 17 ++--
drivers/net/ethernet/microchip/encx24j600.c | 19 +++-
drivers/net/ethernet/qlogic/qed/qed_iscsi.c | 2 +-
drivers/net/ethernet/qualcomm/emac/emac.c | 9 ++
drivers/net/ethernet/rdc/r6040.c | 10 +-
drivers/net/ethernet/sfc/ethtool.c | 35 ++++---
drivers/net/ethernet/sfc/mcdi_port.c | 60 ++++++-----
drivers/net/ethernet/sfc/net_driver.h | 12 +--
drivers/net/gtp.c | 8 +-
drivers/net/irda/w83977af_ir.c | 6 +-
drivers/net/virtio_net.c | 369 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--
drivers/net/vrf.c | 6 +-
drivers/net/wan/lmc/lmc_media.c | 97 +++++++++---------
include/linux/bpf-cgroup.h | 2 +-
include/linux/bpf.h | 13 ++-
include/linux/filter.h | 15 ++-
include/linux/miscdevice.h | 1 +
include/linux/platform_data/macb.h | 6 ++
include/net/inet6_connection_sock.h | 3 +-
include/net/inet_connection_sock.h | 6 +-
include/net/netlink.h | 3 +-
init/Kconfig | 3 +-
kernel/bpf/core.c | 43 +++++---
kernel/bpf/syscall.c | 38 +++++--
kernel/bpf/verifier.c | 28 ++++--
net/atm/lec.c | 6 +-
net/atm/mpoa_caches.c | 43 ++++----
net/core/filter.c | 6 ++
net/decnet/dn_dev.c | 2 +-
net/ipv4/inet_connection_sock.c | 16 +--
net/ipv6/inet6_connection_sock.c | 7 +-
net/ipv6/route.c | 2 +
net/irda/irnet/irnet.h | 1 -
net/irda/irnet/irnet_ppp.h | 11 +-
net/irda/irproc.c | 1 -
net/mac80211/key.c | 3 +-
net/mac80211/rx.c | 2 +-
net/mac80211/sta_info.c | 14 +--
net/sched/cls_flower.c | 6 +-
net/sctp/endpointola.c | 5 +-
net/sctp/socket.c | 7 +-
net/vmw_vsock/vmci_transport_notify.c | 30 +++---
net/vmw_vsock/vmci_transport_notify_qstate.c | 30 +++---
net/x25/sysctl_net_x25.c | 2 +-
tools/testing/selftests/bpf/test_verifier.c | 30 +++++-
71 files changed, 1206 insertions(+), 446 deletions(-)
create mode 100644 drivers/net/ethernet/cadence/macb_pci.c
^ permalink raw reply
* Re: [PATCH] net: mv643xx_eth: fix build failure
From: David Miller @ 2016-12-18 2:47 UTC (permalink / raw)
To: sudipm.mukherjee; +Cc: sebastian.hesselbarth, linux-kernel, netdev
In-Reply-To: <1481935505-24475-1-git-send-email-sudipm.mukherjee@gmail.com>
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Date: Sat, 17 Dec 2016 00:45:05 +0000
> The build of sparc allmodconfig fails with the error:
> "of_irq_to_resource" [drivers/net/ethernet/marvell/mv643xx_eth.ko]
> undefined!
>
> of_irq_to_resource() is defined when CONFIG_OF_IRQ is defined. And also
> CONFIG_OF_IRQ can only be defined if CONFIG_IRQ is defined. So we can
> safely use #if defined(CONFIG_OF_IRQ) in the code.
>
> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
Applied, thanks.
^ permalink raw reply
* Re: [PATCH] isdn: Constify some function parameters
From: David Miller @ 2016-12-18 2:46 UTC (permalink / raw)
To: keescook; +Cc: isdn, linux-kernel, re.emese, netdev
In-Reply-To: <20161216214047.GA90306@beast>
From: Kees Cook <keescook@chromium.org>
Date: Fri, 16 Dec 2016 13:40:47 -0800
> From: Emese Revfy <re.emese@gmail.com>
>
> The coming initify gcc plugin expects const pointer types, and caught
> some __printf arguments that weren't const yet. This fixes those.
>
> Signed-off-by: Emese Revfy <re.emese@gmail.com>
> [kees: expanded commit message]
> Signed-off-by: Kees Cook <keescook@chromium.org>
Applied.
^ permalink raw reply
* Re: [patch net] mlxsw: spectrum: Mark split ports as such
From: David Miller @ 2016-12-18 2:45 UTC (permalink / raw)
To: jiri; +Cc: netdev, idosch, eladr, yotamg, nogahf, arkadis, tamirw
In-Reply-To: <1481912943-2864-1-git-send-email-jiri@resnulli.us>
From: Jiri Pirko <jiri@resnulli.us>
Date: Fri, 16 Dec 2016 19:29:03 +0100
> From: Ido Schimmel <idosch@mellanox.com>
>
> When a port is split we should mark it as such, as otherwise the split
> ports aren't renamed correctly (e.g. sw1p3 -> sw1p3s1) and the unsplit
> operation fails:
>
> $ devlink port split sw1p3 count 4
> $ devlink port unsplit eth0
> devlink answers: Invalid argument
> [ 598.565307] mlxsw_spectrum 0000:03:00.0 eth0: Port wasn't split
>
> Fixes: 67963a33b4fd ("mlxsw: Make devlink port instances independent of spectrum/switchx2 port instances")
> Signed-off-by: Ido Schimmel <idosch@mellanox.com>
> Reported-by: Tamir Winetroub <tamirw@mellanox.com>
> Reviewed-by: Elad Raz <eladr@mellanox.com>
> Tested-by: Tamir Winetroub <tamirw@mellanox.com>
> Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Applied, thanks Jiri.
^ permalink raw reply
* Re: [PATCH] cgroup: Fix CGROUP_BPF config
From: David Miller @ 2016-12-18 2:43 UTC (permalink / raw)
To: luto; +Cc: alexei.starovoitov, daniel, netdev
In-Reply-To: <8d48c3940f8d0275da6398ea5bcef14e20233db5.1481905995.git.luto@kernel.org>
From: Andy Lutomirski <luto@kernel.org>
Date: Fri, 16 Dec 2016 08:33:45 -0800
> CGROUP_BPF depended on SOCK_CGROUP_DATA which can't be manually
> enabled, making it rather challenging to turn CGROUP_BPF on.
>
> Signed-off-by: Andy Lutomirski <luto@kernel.org>
Applied, thanks.
^ permalink raw reply
* Re: pull-request: mac80211 2016-12-16
From: David Miller @ 2016-12-18 2:42 UTC (permalink / raw)
To: johannes; +Cc: netdev, linux-wireless
In-Reply-To: <20161216123957.16744-1-johannes@sipsolutions.net>
From: Johannes Berg <johannes@sipsolutions.net>
Date: Fri, 16 Dec 2016 13:39:56 +0100
> Since you seem to be updating net, I thought I'd send you a few fixes.
> These aren't really all that important though, so if you want to let
> them wait for a bit I can live with that.
>
> Please pull and let me know if there's any problem.
Pulled, thanks.
^ permalink raw reply
* Re: [PATCH net] qed: fix old-style function definition
From: David Miller @ 2016-12-18 2:39 UTC (permalink / raw)
To: arnd
Cc: Yuval.Mintz, Ariel.Elior, everest-linux-l2, arun.easi, hare,
jthumshirn, netdev, linux-kernel
In-Reply-To: <20161216084808.1815139-1-arnd@arndb.de>
From: Arnd Bergmann <arnd@arndb.de>
Date: Fri, 16 Dec 2016 09:47:41 +0100
> The newly added file causes a harmless warning, with "make W=1":
>
> drivers/net/ethernet/qlogic/qed/qed_iscsi.c: In function 'qed_get_iscsi_ops':
> drivers/net/ethernet/qlogic/qed/qed_iscsi.c:1268:29: warning: old-style function definition [-Wold-style-definition]
>
> This makes it a proper prototype.
>
> Fixes: fc831825f99e ("qed: Add support for hardware offloaded iSCSI.")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
APplied.
^ permalink raw reply
* Re: [PATCH] net: ipv6: check route protocol when deleting routes
From: David Miller @ 2016-12-18 2:37 UTC (permalink / raw)
To: grawity; +Cc: netdev, linux-kernel
In-Reply-To: <20161216083059.251368-1-grawity@gmail.com>
From: Mantas Mikulėnas <grawity@gmail.com>
Date: Fri, 16 Dec 2016 10:30:59 +0200
> The protocol field is checked when deleting IPv4 routes, but ignored for
> IPv6, which causes problems with routing daemons accidentally deleting
> externally set routes (observed by multiple bird6 users).
>
> This can be verified using `ip -6 route del <prefix> proto something`.
>
> Signed-off-by: Mantas Mikulėnas <grawity@gmail.com>
Applied, thanks.
^ permalink raw reply
* Re: [PATCH v3 net] r6040: move spinlock in r6040_close as SOFTIRQ-unsafe lock order detected
From: David Miller @ 2016-12-18 2:36 UTC (permalink / raw)
To: manuel.bessler; +Cc: netdev, f.fainelli
In-Reply-To: <1481860500-25117-1-git-send-email-manuel.bessler@sensus.com>
From: Manuel Bessler <manuel.bessler@sensus.com>
Date: Thu, 15 Dec 2016 22:55:00 -0500
> 'ifconfig eth0 down' makes r6040_close() trigger:
> INFO: HARDIRQ-safe -> HARDIRQ-unsafe lock order detected
>
> Fixed by moving calls to phy_stop(), napi_disable(), netif_stop_queue()
> to outside of the module's private spin_lock_irq block.
>
> Found on a Versalogic Tomcat SBC with a Vortex86 SoC
...
> Signed-off-by: Manuel Bessler <manuel.bessler@sensus.com>
Applied, thanks.
^ permalink raw reply
* Re: [patch net-next] irda: w83977af_ir: cleanup an indent issue
From: David Miller @ 2016-12-18 2:33 UTC (permalink / raw)
To: dan.carpenter; +Cc: samuel, joe, netdev, kernel-janitors
In-Reply-To: <20161212112134.GA10035@elgon.mountain>
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Mon, 12 Dec 2016 14:21:34 +0300
> In commit 99d8d2159d7c ("irda: w83977af_ir: Neaten logging"), we
> accidentally added an extra tab to these lines.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied.
^ permalink raw reply
* Re: [PATCH] net: sfc: use new api ethtool_{get|set}_link_ksettings
From: David Miller @ 2016-12-18 2:32 UTC (permalink / raw)
To: tremyfr; +Cc: linux-net-drivers, ecree, bkenward, netdev, linux-kernel
In-Reply-To: <1481757173-16000-1-git-send-email-tremyfr@gmail.com>
From: Philippe Reynes <tremyfr@gmail.com>
Date: Thu, 15 Dec 2016 00:12:53 +0100
> The ethtool api {get|set}_settings is deprecated.
> We move this driver to new api {get|set}_link_ksettings.
>
> Signed-off-by: Philippe Reynes <tremyfr@gmail.com>
Applied.
^ permalink raw reply
* Re: [PATCH] net: davicom: dm9000: use new api ethtool_{get|set}_link_ksettings
From: David Miller @ 2016-12-18 2:32 UTC (permalink / raw)
To: tremyfr
Cc: robert.jarzmik, mugunthanvnm, marcel, jarod, s.nawrocki, fw,
harvey.hunt, netdev
In-Reply-To: <1481706118-13076-1-git-send-email-tremyfr@gmail.com>
From: Philippe Reynes <tremyfr@gmail.com>
Date: Wed, 14 Dec 2016 10:01:58 +0100
> The ethtool api {get|set}_settings is deprecated.
> We move this driver to new api {get|set}_link_ksettings.
>
> Signed-off-by: Philippe Reynes <tremyfr@gmail.com>
Applied.
^ permalink raw reply
* Re: [PATCH] net: cirrus: ep93xx: use new api ethtool_{get|set}_link_ksettings
From: David Miller @ 2016-12-18 2:32 UTC (permalink / raw)
To: tremyfr; +Cc: hsweeten, netdev, linux-kernel
In-Reply-To: <1481581713-6590-1-git-send-email-tremyfr@gmail.com>
From: Philippe Reynes <tremyfr@gmail.com>
Date: Mon, 12 Dec 2016 23:28:33 +0100
> The ethtool api {get|set}_settings is deprecated.
> We move this driver to new api {get|set}_link_ksettings.
>
> Signed-off-by: Philippe Reynes <tremyfr@gmail.com>
Applied.
^ permalink raw reply
* Re: [PATCH] net: chelsio: cxgb3: use new api ethtool_{get|set}_link_ksettings
From: David Miller @ 2016-12-18 2:31 UTC (permalink / raw)
To: tremyfr; +Cc: santosh, netdev, linux-kernel
In-Reply-To: <1481498870-16946-1-git-send-email-tremyfr@gmail.com>
From: Philippe Reynes <tremyfr@gmail.com>
Date: Mon, 12 Dec 2016 00:27:49 +0100
> The ethtool api {get|set}_settings is deprecated.
> We move this driver to new api {get|set}_link_ksettings.
>
> Signed-off-by: Philippe Reynes <tremyfr@gmail.com>
Applied.
^ permalink raw reply
* Re: [PATCH] net: chelsio: cxgb2: use new api ethtool_{get|set}_link_ksettings
From: David Miller @ 2016-12-18 2:31 UTC (permalink / raw)
To: tremyfr; +Cc: jarod, netdev, linux-kernel
In-Reply-To: <1481492870-12222-1-git-send-email-tremyfr@gmail.com>
From: Philippe Reynes <tremyfr@gmail.com>
Date: Sun, 11 Dec 2016 22:47:50 +0100
> The ethtool api {get|set}_settings is deprecated.
> We move this driver to new api {get|set}_link_ksettings.
>
> Signed-off-by: Philippe Reynes <tremyfr@gmail.com>
Applied.
^ permalink raw reply
* Re: [PATCH net v2 0/3] Couple of BPF fixes
From: David Miller @ 2016-12-18 2:28 UTC (permalink / raw)
To: daniel; +Cc: ast, kafai, netdev
In-Reply-To: <cover.1482019225.git.daniel@iogearbox.net>
From: Daniel Borkmann <daniel@iogearbox.net>
Date: Sun, 18 Dec 2016 01:52:56 +0100
> This set contains three BPF fixes for net, one that addresses the
> complaint from Geert wrt static allocations, and the other is a fix
> wrt mem accounting that I found recently during testing and there's
> still one more fix on the map value marking.
>
> Thanks!
>
> v1 -> v2:
> - Patch 1 as is.
> - Fixed kbuild bot issue by letting charging helpers stay in the
> syscall.c, since there locked_vm is valid and only export the
> ones needed by bpf_prog_realloc(). Add empty stubs in case the
> bpf syscall is not enabled.
> - Added patch 3 that addresses one more issue in map val marking.
Series applied, thanks Daniel.
^ permalink raw reply
* [PATCH net] ipvlan: fix crash
From: Mahesh Bandewar @ 2016-12-18 2:16 UTC (permalink / raw)
To: netdev, Eric Dumazet, David Miller; +Cc: Mahesh Bandewar
From: Mahesh Bandewar <maheshb@google.com>
------------[ cut here ]------------
kernel BUG at include/linux/skbuff.h:1737!
Call Trace:
[<ffffffff921fbbc2>] dev_forward_skb+0x92/0xd0
[<ffffffffc031ac65>] ipvlan_process_multicast+0x395/0x4c0 [ipvlan]
[<ffffffffc031a9a7>] ? ipvlan_process_multicast+0xd7/0x4c0 [ipvlan]
[<ffffffff91cdfea7>] ? process_one_work+0x147/0x660
[<ffffffff91cdff09>] process_one_work+0x1a9/0x660
[<ffffffff91cdfea7>] ? process_one_work+0x147/0x660
[<ffffffff91ce086d>] worker_thread+0x11d/0x360
[<ffffffff91ce0750>] ? rescuer_thread+0x350/0x350
[<ffffffff91ce960b>] kthread+0xdb/0xe0
[<ffffffff91c05c70>] ? _raw_spin_unlock_irq+0x30/0x50
[<ffffffff91ce9530>] ? flush_kthread_worker+0xc0/0xc0
[<ffffffff92348b7a>] ret_from_fork+0x9a/0xd0
[<ffffffff91ce9530>] ? flush_kthread_worker+0xc0/0xc0
Signed-off-by: Mahesh Bandewar <maheshb@google.com>
---
drivers/net/ipvlan/ipvlan_core.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/net/ipvlan/ipvlan_core.c b/drivers/net/ipvlan/ipvlan_core.c
index b4e990743e1d..4294fc1f5564 100644
--- a/drivers/net/ipvlan/ipvlan_core.c
+++ b/drivers/net/ipvlan/ipvlan_core.c
@@ -660,6 +660,9 @@ rx_handler_result_t ipvlan_handle_frame(struct sk_buff **pskb)
if (!port)
return RX_HANDLER_PASS;
+ if (unlikely(!pskb_may_pull(skb, sizeof(struct ethhdr))))
+ goto out;
+
switch (port->mode) {
case IPVLAN_MODE_L2:
return ipvlan_handle_mode_l2(pskb, port);
@@ -672,6 +675,8 @@ rx_handler_result_t ipvlan_handle_frame(struct sk_buff **pskb)
/* Should not reach here */
WARN_ONCE(true, "ipvlan_handle_frame() called for mode = [%hx]\n",
port->mode);
+
+out:
kfree_skb(skb);
return RX_HANDLER_CONSUMED;
}
--
2.8.0.rc3.226.g39d4020
^ permalink raw reply related
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox