* Re: [PATCH] net: smc_close: mark expected switch fall-throughs
From: David Miller @ 2017-10-22 1:08 UTC (permalink / raw)
To: garsilva; +Cc: ubraun, linux-s390, netdev, linux-kernel
In-Reply-To: <20171019220244.GA22041@embeddedor.com>
From: "Gustavo A. R. Silva" <garsilva@embeddedor.com>
Date: Thu, 19 Oct 2017 17:02:44 -0500
> @@ -360,7 +360,8 @@ static void smc_close_passive_work(struct work_struct *work)
> case SMC_PEERCLOSEWAIT1:
> if (rxflags->peer_done_writing)
> sk->sk_state = SMC_PEERCLOSEWAIT2;
> - /* fall through to check for closing */
> + /* to check for closing */
> + /* fall through */
Gustavo please look at what you are doing to the code.
This was a nice easy to read sentence in the comment, and now
you've chopped it up into two pieces and made it awkward and
more difficult to read.
^ permalink raw reply
* Re: [PATCH net-next 0/8] tools: bpftool: add a "version" command, and fix several items
From: David Miller @ 2017-10-22 1:11 UTC (permalink / raw)
To: jakub.kicinski; +Cc: netdev, oss-drivers
In-Reply-To: <20171019224626.31608-1-jakub.kicinski@netronome.com>
From: Jakub Kicinski <jakub.kicinski@netronome.com>
Date: Thu, 19 Oct 2017 15:46:18 -0700
> Quentin says:
>
> The first seven patches of this series bring several minor fixes to
> bpftool. Please see individual commit logs for details.
>
> Last patch adds a "version" commands to bpftool, which is in fact the
> version of the kernel from which it was compiled.
Series applied, thank you.
^ permalink raw reply
* [jkirsher/net-queue PATCH] i40e: Add programming descriptors to cleaned_count
From: Alexander Duyck @ 2017-10-22 1:12 UTC (permalink / raw)
To: netdev, intel-wired-lan, akp, pstaszewski
From: Alexander Duyck <alexander.h.duyck@intel.com>
This patch updates the i40e driver to include programming descriptors in
the cleaned_count. Without this change it becomes possible for us to leak
memory as we don't trigger a large enough allocation when the time comes to
allocate new buffers and we end up overwriting a number of rx_buffers equal
to the number of programming descriptors we encountered.
Fixes: 0e626ff7ccbf ("i40e: Fix support for flow director programming status")
Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
---
drivers/net/ethernet/intel/i40e/i40e_txrx.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/intel/i40e/i40e_txrx.c b/drivers/net/ethernet/intel/i40e/i40e_txrx.c
index 368722defacb..d6d352a6e6ea 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_txrx.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_txrx.c
@@ -2102,6 +2102,7 @@ static int i40e_clean_rx_irq(struct i40e_ring *rx_ring, int budget)
if (unlikely(i40e_rx_is_programming_status(qword))) {
i40e_clean_programming_status(rx_ring, rx_desc, qword);
+ cleaned_count++;
continue;
}
size = (qword & I40E_RXD_QW1_LENGTH_PBUF_MASK) >>
^ permalink raw reply related
* Re: [PATCH] net: ethtool: remove error check for legacy setting transceiver type
From: David Miller @ 2017-10-22 1:15 UTC (permalink / raw)
To: niklas.soderlund+renesas
Cc: f.fainelli, netdev, linux-renesas-soc, geert, renjith.rv
In-Reply-To: <20171019233208.15444-1-niklas.soderlund+renesas@ragnatech.se>
From: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Date: Fri, 20 Oct 2017 01:32:08 +0200
> Commit 9cab88726929605 ("net: ethtool: Add back transceiver type")
> restores the transceiver type to struct ethtool_link_settings and
> convert_link_ksettings_to_legacy_settings() but forgets to remove the
> error check for the same in convert_legacy_settings_to_link_ksettings().
> This prevents older versions of ethtool to change link settings.
>
> # ethtool --version
> ethtool version 3.16
>
> # ethtool -s eth0 autoneg on speed 100 duplex full
> Cannot set new settings: Invalid argument
> not setting speed
> not setting duplex
> not setting autoneg
>
> While newer versions of ethtool works.
>
> # ethtool --version
> ethtool version 4.10
>
> # ethtool -s eth0 autoneg on speed 100 duplex full
> [ 57.703268] sh-eth ee700000.ethernet eth0: Link is Down
> [ 59.618227] sh-eth ee700000.ethernet eth0: Link is Up - 100Mbps/Full - flow control rx/tx
>
> Fixes: 19cab88726929605 ("net: ethtool: Add back transceiver type")
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Applied.
^ permalink raw reply
* Re: [PATCH net-next 0/2] Add mac loopback selftest support in hns3 driver
From: David Miller @ 2017-10-22 1:17 UTC (permalink / raw)
To: linyunsheng
Cc: huangdaode, xuwei5, liguozhu, Yisen.Zhuang, gabriele.paoloni,
john.garry, linuxarm, salil.mehta, lipeng321, netdev,
linux-kernel
In-Reply-To: <1508465962-60176-1-git-send-email-linyunsheng@huawei.com>
From: Yunsheng Lin <linyunsheng@huawei.com>
Date: Fri, 20 Oct 2017 10:19:20 +0800
> This patchset refactors the skb receiving and transmitting function
> before adding mac loopback selftest support in hns3 driver.
Series applied.
^ permalink raw reply
* Re: [patch net 0/2] mlxsw: spectrum: Configure TTL of "inherit" for offloaded tunnels
From: David Miller @ 2017-10-22 1:19 UTC (permalink / raw)
To: jiri; +Cc: netdev, petrm, idosch, mlxsw
In-Reply-To: <20171020071616.1498-1-jiri@resnulli.us>
From: Jiri Pirko <jiri@resnulli.us>
Date: Fri, 20 Oct 2017 09:16:14 +0200
> From: Jiri Pirko <jiri@mellanox.com>
>
> Petr says:
>
> Currently mlxsw only offloads tunnels that are configured with TTL of "inherit"
> (which is the default). However, Spectrum defaults to 255 and the driver
> neglects to change the configuration. Thus the tunnel packets from offloaded
> tunnels always have TTL of 255, even though tunnels with explicit TTL of 255 are
> never actually offloaded.
>
> To fix this, introduce support for TIGCR, the register that keeps the related
> bits of global tunnel configuration, and use it on first offload to properly
> configure inheritance of TTL of tunnel packets from overlay packets.
Series applied.
^ permalink raw reply
* Re: [PATCH] net: smc_close: mark expected switch fall-throughs
From: Gustavo A. R. Silva @ 2017-10-22 1:21 UTC (permalink / raw)
To: David Miller; +Cc: ubraun, linux-s390, netdev, linux-kernel
In-Reply-To: <20171022.020835.2065879880300400886.davem@davemloft.net>
Quoting David Miller <davem@davemloft.net>:
> From: "Gustavo A. R. Silva" <garsilva@embeddedor.com>
> Date: Thu, 19 Oct 2017 17:02:44 -0500
>
>> @@ -360,7 +360,8 @@ static void smc_close_passive_work(struct
>> work_struct *work)
>> case SMC_PEERCLOSEWAIT1:
>> if (rxflags->peer_done_writing)
>> sk->sk_state = SMC_PEERCLOSEWAIT2;
>> - /* fall through to check for closing */
>> + /* to check for closing */
>> + /* fall through */
>
> Gustavo please look at what you are doing to the code.
>
> This was a nice easy to read sentence in the comment, and now
> you've chopped it up into two pieces and made it awkward and
> more difficult to read.
You're right.
What about this instead:
/* fall through */
/* to check for closing */
^ permalink raw reply
* Re: [PATCH 00/15] networking drivers refcount_t conversions
From: David Miller @ 2017-10-22 1:31 UTC (permalink / raw)
To: elena.reshetova
Cc: netdev, linux-kernel, linux-arm-kernel, linux-mediatek,
linux-rdma, linux-hams, linux-ppp, ganeshgr, nbd, john, sean.wang,
matthias.bgg, yishaih, saeedm, matanb, tariqt, leonro, ajk,
paulus, zbr, peterz, keescook
In-Reply-To: <1508484229-19706-1-git-send-email-elena.reshetova@intel.com>
From: Elena Reshetova <elena.reshetova@intel.com>
Date: Fri, 20 Oct 2017 10:23:34 +0300
> Note: these are the last patches related to networking that perform
> conversion of refcounters from atomic_t to refcount_t.
> In contrast to the core network refcounter conversions that
> were merged earlier, these are much more straightforward ones.
>
> This series, for various networking drivers, replaces atomic_t reference
> counters with the new refcount_t type and API (see include/linux/refcount.h).
> By doing this we prevent intentional or accidental
> underflows or overflows that can led to use-after-free vulnerabilities.
>
> The patches are fully independent and can be cherry-picked separately.
> Patches are based on top of net-next.
> If there are no objections to the patches, please merge them via respective trees
I've applied this entire series to net-next. If there are any fixups or
follow-ups please send them as relative patches.
Thank you.
^ permalink raw reply
* [PATCH v2] net: smc_close: mark expected switch fall-through
From: Gustavo A. R. Silva @ 2017-10-22 1:35 UTC (permalink / raw)
To: Ursula Braun, David S. Miller
Cc: linux-s390, netdev, linux-kernel, Gustavo A. R. Silva
In-Reply-To: <20171021202100.Horde.z-7P99HVhWm0m3hXj5cOjur@gator4166.hostgator.com>
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Notice that in this particular case I placed the "fall through" comment
on its own line, which is what GCC is expecting to find.
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
Changes in v2:
Move the "fall through" comment on its own line
above the rest of the sentence.
net/smc/smc_close.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/smc/smc_close.c b/net/smc/smc_close.c
index f0d16fb..a6c6559 100644
--- a/net/smc/smc_close.c
+++ b/net/smc/smc_close.c
@@ -360,7 +360,8 @@ static void smc_close_passive_work(struct work_struct *work)
case SMC_PEERCLOSEWAIT1:
if (rxflags->peer_done_writing)
sk->sk_state = SMC_PEERCLOSEWAIT2;
- /* fall through to check for closing */
+ /* fall through */
+ /* to check for closing */
case SMC_PEERCLOSEWAIT2:
case SMC_PEERFINCLOSEWAIT:
if (!smc_cdc_rxed_any_close(&smc->conn))
--
2.7.4
^ permalink raw reply related
* Re: [PATCH v2] of_mdio: Fix broken PHY IRQ in case of probe deferral
From: David Miller @ 2017-10-22 1:37 UTC (permalink / raw)
To: geert+renesas
Cc: andrew, f.fainelli, robh+dt, frowand.list, netdev, devicetree,
linux-renesas-soc, linux-kernel
In-Reply-To: <1508327643-3579-1-git-send-email-geert+renesas@glider.be>
Second ping, this patch needs a review ASAP.
Geert's hard-resetting PHY changes depend upon this change.
Thank you.
^ permalink raw reply
* Re: [net-next 1/1] tipc: refactor tipc_sk_timeout() function
From: David Miller @ 2017-10-22 1:38 UTC (permalink / raw)
To: jon.maloy; +Cc: netdev, parthasarathy.bhuvaragan, ying.xue, tipc-discussion
In-Reply-To: <1508491292-5333-1-git-send-email-jon.maloy@ericsson.com>
From: Jon Maloy <jon.maloy@ericsson.com>
Date: Fri, 20 Oct 2017 11:21:32 +0200
> The function tipc_sk_timeout() is more complex than necessary, and
> even seems to contain an undetected bug. At one of the occurences
> where we renew the timer we just order it with (HZ / 20), instead
> of (jiffies + HZ / 20);
>
> In this commit we clean up the function.
>
> Acked-by: Ying Xue <ying.xue@windriver.com>
> Signed-off-by: Jon Maloy <jon.maloy@ericsson.com>
Applied, thanks Jon.
^ permalink raw reply
* Re: [PATCH v3 net-next 0/2] net: dsa: lan9303: Add fdb/mdb methods
From: David Miller @ 2017-10-22 1:41 UTC (permalink / raw)
To: privat; +Cc: andrew, vivien.didelot, f.fainelli, netdev, linux-kernel
In-Reply-To: <20171020101910.2245-1-privat@egil-hjelmeland.no>
From: Egil Hjelmeland <privat@egil-hjelmeland.no>
Date: Fri, 20 Oct 2017 12:19:08 +0200
> This series add support for accessing and managing the lan9303 ALR
> (Address Logic Resolution).
>
> The first patch add low level functions for accessing the ALR, along
> with port_fast_age and port_fdb_dump methods.
>
> The second patch add functions for managing ALR entires, along with
> remaining fdb/mdb methods.
>
> Note that to complete STP support, a special ALR entry with the STP eth
> address must be added too. This must be addressed later.
Series applied, thank you.
^ permalink raw reply
* Re: [PATCH net-next v2] geneve: Get rid of is_all_zero(), streamline is_tnl_info_zero()
From: David Miller @ 2017-10-22 1:43 UTC (permalink / raw)
To: sbrivio; +Cc: netdev, pshelar
In-Reply-To: <2f3e906b339869a22c9b7c438c8b854c4bfb885b.1508485663.git.sbrivio@redhat.com>
From: Stefano Brivio <sbrivio@redhat.com>
Date: Fri, 20 Oct 2017 13:31:36 +0200
> No need to re-invent memchr_inv() with !is_all_zero(). While at
> it, replace conditional and return clauses with a single return
> clause in is_tnl_info_zero().
>
> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
Applied.
^ permalink raw reply
* Re: v4.14-rc3/arm64 DABT exception in atomic_inc() / __skb_clone()
From: Wei Wei @ 2017-10-22 1:56 UTC (permalink / raw)
To: Willem de Bruijn
Cc: Dmitry Vyukov, Mark Rutland, linux-arm-kernel, LKML, netdev,
Eric Dumazet, David Miller, Willem de Bruijn, syzkaller
In-Reply-To: <CAF=yD-K76TMjHiYRTRAnxM-x4LBcUDY+27WX477HW6kG=L_aZw@mail.gmail.com>
I have uploaded the VM core dump [1]. And I don’t know if these logs are helpful in the case of
failing to get the C reproducer currently.
[1] https://github.com/dotweiba/skb_clone_atomic_inc_bug/blob/master/vmcore.gz
2017/10/21 20:24:32 reproducing crash 'unable to handle kernel paging request in __skb_clone': testing program (duration=24s, {Threaded:true Collide:true Repeat:true Procs:8 Sandb
ox:setuid Fault:false FaultCall:-1 FaultNth:0 EnableTun:true UseTmpDir:true HandleSegv:true WaitRepeat:true Debug:false Repro:true}): mmap-socket$inet_tcp-bind$inet-sendto$inet-se
ndto$inet-syz_emit_ethernet
2017/10/21 20:24:49 reproducing crash 'unable to handle kernel paging request in __skb_clone': program crashed: unable to handle kernel paging request in __skb_clone
2017/10/21 20:24:49 reproducing crash 'unable to handle kernel paging request in __skb_clone': extracting C reproducer
2017/10/21 20:24:49 reproducing crash 'unable to handle kernel paging request in __skb_clone': reproducing took 1h47m5.070207729s
2017/10/21 20:24:49 reproduction failed: no target compiler
Thanks,
Wei
> On 20 Oct 2017, at 11:39 AM, Willem de Bruijn <willemdebruijn.kernel@gmail.com> wrote:
>
> On Fri, Oct 20, 2017 at 11:14 AM, Dmitry Vyukov <dvyukov@google.com> wrote:
>> On Fri, Oct 20, 2017 at 4:40 PM, Wei Wei <dotweiba@gmail.com> wrote:
>>> Sadly, the syzkaller characterized it as a non-reproducible bug and there were empty
>>> repro files. But if manually executing in VM like this “./syz-execprog -executor=
>>> ./syz-executor -repeat=0 -procs=16 -cover=0 crash-log”, it crashed when executing exactly
>>> program 1056 using log0 provided.
>>>
>>> I failed to generate the C reproducer with syz-repro as it said “no target compiler”
>>> in the final step. I would appreciate if you could give some hints.
>>
>> syzkaller tries to use aarch64-linux-gnu-gcc when cross-compiling to arm64:
>> https://github.com/google/syzkaller/blob/master/sys/targets/targets.go#L62
>> Try to install g++-aarch64-linux-gnu.
>> Or how should it be done on your system?
>
> A core dump would also be helpful to root around in and inspect
> what those registers point to. Thanks for posting the various reports
> on github, btw.
^ permalink raw reply
* Re: [PATCH v2] of_mdio: Fix broken PHY IRQ in case of probe deferral
From: Florian Fainelli @ 2017-10-22 2:01 UTC (permalink / raw)
To: Geert Uytterhoeven, Andrew Lunn, Rob Herring, Frank Rowand
Cc: netdev-u79uwXL29TY76Z2rM5mHXA, devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
In-Reply-To: <1508327643-3579-1-git-send-email-geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>
On October 18, 2017 4:54:03 AM PDT, Geert Uytterhoeven <geert+renesas@glider.be> wrote:
>If an Ethernet PHY is initialized before the interrupt controller it is
>connected to, a message like the following is printed:
>
> irq: no irq domain found for /interrupt-controller@e61c0000 !
>
>However, the actual error is ignored, leading to a non-functional
>(POLL)
>PHY interrupt later:
>
>Micrel KSZ8041RNLI ee700000.ethernet-ffffffff:01: attached PHY driver
>[Micrel KSZ8041RNLI] (mii_bus:phy_addr=ee700000.ethernet-ffffffff:01,
>irq=POLL)
>
>Depending on whether the PHY driver will fall back to polling, Ethernet
>may or may not work.
>
>To fix this:
> 1. Switch of_mdiobus_register_phy() from irq_of_parse_and_map() to
> of_irq_get().
> Unlike the former, the latter returns -EPROBE_DEFER if the
> interrupt controller is not yet available, so this condition can be
> detected.
> Other errors are handled the same as before, i.e. use the passed
> mdio->irq[addr] as interrupt.
> 2. Propagate and handle errors from of_mdiobus_register_phy() and
> of_mdiobus_register_device().
>
>Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by : Florian Fainelli <f.fainelli@gmail.com>
I still can't make sure this is not a problem for multiple PHYs hanging off the same bus, but like anything else, we'll deal with problems later if they arise.
>---
>Seen on e.g. r8a7791/koelsch when using the new CPG/MSSR clock driver,
>which will hit upstream in v4.15. I assume it always happened on RZ/G1
>in mainline.
>
>The actual patch is unchanged since v1, sent on May 18. Obviously I
>still cannot test it on a system with multiple PHYs, just like v1.
>
>How can we proceed?
>
>Note that if you are worried about the MDIO subsystem not handling
>(partial) teardown and reprobe correctly in the presence of multiple
>PHYs, that can already be triggered since commit a5597008dbc23087
>("phy:
>fixed_phy: Add gpio to determine link up/down."), which handles
>EPROBE_DEFER for GPIOs.
>
>Thanks!
>
>v2:
> - Update for non-functional interrupts being printed as "POLL" instead
> of "-1" since commit 5e369aefdce4818c ("net: stmmac: Delete dead
> code for MDIO registration").
>---
> drivers/of/of_mdio.c | 39 +++++++++++++++++++++++++++------------
> 1 file changed, 27 insertions(+), 12 deletions(-)
>
>diff --git a/drivers/of/of_mdio.c b/drivers/of/of_mdio.c
>index d94dd8b77abd5140..98258583abb0b405 100644
>--- a/drivers/of/of_mdio.c
>+++ b/drivers/of/of_mdio.c
>@@ -44,7 +44,7 @@ static int of_get_phy_id(struct device_node *device,
>u32 *phy_id)
> return -EINVAL;
> }
>
>-static void of_mdiobus_register_phy(struct mii_bus *mdio,
>+static int of_mdiobus_register_phy(struct mii_bus *mdio,
> struct device_node *child, u32 addr)
> {
> struct phy_device *phy;
>@@ -60,9 +60,13 @@ static void of_mdiobus_register_phy(struct mii_bus
>*mdio,
> else
> phy = get_phy_device(mdio, addr, is_c45);
> if (IS_ERR(phy))
>- return;
>+ return PTR_ERR(phy);
>
>- rc = irq_of_parse_and_map(child, 0);
>+ rc = of_irq_get(child, 0);
>+ if (rc == -EPROBE_DEFER) {
>+ phy_device_free(phy);
>+ return rc;
>+ }
> if (rc > 0) {
> phy->irq = rc;
> mdio->irq[addr] = rc;
>@@ -84,22 +88,23 @@ static void of_mdiobus_register_phy(struct mii_bus
>*mdio,
> if (rc) {
> phy_device_free(phy);
> of_node_put(child);
>- return;
>+ return rc;
> }
>
> dev_dbg(&mdio->dev, "registered phy %s at address %i\n",
> child->name, addr);
>+ return 0;
> }
>
>-static void of_mdiobus_register_device(struct mii_bus *mdio,
>- struct device_node *child, u32 addr)
>+static int of_mdiobus_register_device(struct mii_bus *mdio,
>+ struct device_node *child, u32 addr)
> {
> struct mdio_device *mdiodev;
> int rc;
>
> mdiodev = mdio_device_create(mdio, addr);
> if (IS_ERR(mdiodev))
>- return;
>+ return PTR_ERR(mdiodev);
>
> /* Associate the OF node with the device structure so it
> * can be looked up later.
>@@ -112,11 +117,12 @@ static void of_mdiobus_register_device(struct
>mii_bus *mdio,
> if (rc) {
> mdio_device_free(mdiodev);
> of_node_put(child);
>- return;
>+ return rc;
> }
>
> dev_dbg(&mdio->dev, "registered mdio device %s at address %i\n",
> child->name, addr);
>+ return 0;
> }
>
> /* The following is a list of PHY compatible strings which appear in
>@@ -219,9 +225,11 @@ int of_mdiobus_register(struct mii_bus *mdio,
>struct device_node *np)
> }
>
> if (of_mdiobus_child_is_phy(child))
>- of_mdiobus_register_phy(mdio, child, addr);
>+ rc = of_mdiobus_register_phy(mdio, child, addr);
> else
>- of_mdiobus_register_device(mdio, child, addr);
>+ rc = of_mdiobus_register_device(mdio, child, addr);
>+ if (rc)
>+ goto unregister;
> }
>
> if (!scanphys)
>@@ -242,12 +250,19 @@ int of_mdiobus_register(struct mii_bus *mdio,
>struct device_node *np)
> dev_info(&mdio->dev, "scan phy %s at address %i\n",
> child->name, addr);
>
>- if (of_mdiobus_child_is_phy(child))
>- of_mdiobus_register_phy(mdio, child, addr);
>+ if (of_mdiobus_child_is_phy(child)) {
>+ rc = of_mdiobus_register_phy(mdio, child, addr);
>+ if (rc)
>+ goto unregister;
>+ }
> }
> }
>
> return 0;
>+
>+unregister:
>+ mdiobus_unregister(mdio);
>+ return rc;
> }
> EXPORT_SYMBOL(of_mdiobus_register);
>
--
Florian
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* Re: [PATCH net-next 0/3] net: stmmac: Fix HW timestamping
From: David Miller @ 2017-10-22 2:06 UTC (permalink / raw)
To: Jose.Abreu
Cc: netdev, linux-kernel, Joao.Pinto, peppe.cavallaro,
alexandre.torgue
In-Reply-To: <cover.1508506265.git.joabreu@synopsys.com>
From: Jose Abreu <Jose.Abreu@synopsys.com>
Date: Fri, 20 Oct 2017 14:37:33 +0100
> Three fixes for HW timestamping feature, all of them for RX side.
Series applied to 'net', thanks.
^ permalink raw reply
* Re: [PATCH net] rxrpc: Don't release call mutex on error pointer
From: David Miller @ 2017-10-22 2:06 UTC (permalink / raw)
To: dhowells; +Cc: netdev, linux-afs, linux-kernel
In-Reply-To: <150851528227.19340.4842940319829659889.stgit@warthog.procyon.org.uk>
From: David Howells <dhowells@redhat.com>
Date: Fri, 20 Oct 2017 17:01:22 +0100
> Don't release call mutex at the end of rxrpc_kernel_begin_call() if the
> call pointer actually holds an error value.
>
> Fixes: 540b1c48c37a ("rxrpc: Fix deadlock between call creation and sendmsg/recvmsg")
> Reported-by: Marc Dionne <marc.dionne@auristor.com>
> Signed-off-by: David Howells <dhowells@redhat.com>
Applied, thanks David.
^ permalink raw reply
* Re: [PATCH v2] of_mdio: Fix broken PHY IRQ in case of probe deferral
From: Florian Fainelli @ 2017-10-22 2:06 UTC (permalink / raw)
To: David Miller, geert+renesas
Cc: andrew, robh+dt, frowand.list, netdev, devicetree,
linux-renesas-soc, linux-kernel
In-Reply-To: <20171022.023738.2186250991838185660.davem@davemloft.net>
On October 21, 2017 6:37:38 PM PDT, David Miller <davem@davemloft.net> wrote:
>
>Second ping, this patch needs a review ASAP.
>
>Geert's hard-resetting PHY changes depend upon this change.
Done, same concerns as before and we could all improve on trying to get this tested on a pure SW model (e.g QEMU) but there is only so little time... Regarding the other patch series it needs more love before it gets merged, so that hopefully lowers the criticality.
--
Florian
^ permalink raw reply
* Re: [PATCH] net: tipc: mark expected switch fall-throughs
From: David Miller @ 2017-10-22 2:07 UTC (permalink / raw)
To: garsilva; +Cc: jon.maloy, ying.xue, netdev, tipc-discussion, linux-kernel
In-Reply-To: <20171020170126.GA16177@embeddedor.com>
From: "Gustavo A. R. Silva" <garsilva@embeddedor.com>
Date: Fri, 20 Oct 2017 12:01:26 -0500
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
This doesn't apply to net-next.
^ permalink raw reply
* Re: [PATCH] net: af_unix: mark expected switch fall-through
From: David Miller @ 2017-10-22 2:10 UTC (permalink / raw)
To: garsilva; +Cc: netdev, linux-kernel
In-Reply-To: <20171020170530.GA19922@embeddedor.com>
From: "Gustavo A. R. Silva" <garsilva@embeddedor.com>
Date: Fri, 20 Oct 2017 12:05:30 -0500
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Applied.
^ permalink raw reply
* Re: [PATCH] net: x25: mark expected switch fall-throughs
From: David Miller @ 2017-10-22 2:10 UTC (permalink / raw)
To: garsilva; +Cc: andrew.hendry, linux-x25, netdev, linux-kernel
In-Reply-To: <20171020173752.GA10123@embeddedor.com>
From: "Gustavo A. R. Silva" <garsilva@embeddedor.com>
Date: Fri, 20 Oct 2017 12:37:52 -0500
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next] nfp: use struct fields for 8 bit-wide access
From: David Miller @ 2017-10-22 2:10 UTC (permalink / raw)
To: simon.horman; +Cc: jakub.kicinski, netdev, oss-drivers, pieter.jansenvanvuuren
In-Reply-To: <20171020174952.23572-1-simon.horman@netronome.com>
From: Simon Horman <simon.horman@netronome.com>
Date: Fri, 20 Oct 2017 19:49:52 +0200
> From: Pieter Jansen van Vuuren <pieter.jansenvanvuuren@netronome.com>
>
> Use direct access struct fields rather than PREP_FIELD()
> macros to manipulate the jump ID and length, both of which
> are exactly 8-bits wide. This simplifies the code somewhat.
>
> Signed-off-by: Simon Horman <simon.horman@netronome.com>
> Signed-off-by: Pieter Jansen van Vuuren <pieter.jansenvanvuuren@netronome.com>
> Acked-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Applied.
^ permalink raw reply
* Re: [PATCH net-next 0/5] bpf: add support for BASE_RTT
From: David Miller @ 2017-10-22 2:12 UTC (permalink / raw)
To: brakmo; +Cc: netdev, kernel-team, ast, daniel, bmatheny
In-Reply-To: <20171020180543.4156833-1-brakmo@fb.com>
From: Lawrence Brakmo <brakmo@fb.com>
Date: Fri, 20 Oct 2017 11:05:38 -0700
> This patch set adds the following functionality to socket_ops BPF
> programs.
> 1) Add bpf helper function bpf_getsocketops. Currently only supports
> TCP_CONGESTION
> 2) Add BPF_SOCKET_OPS_BASE_RTT op to get the base RTT of the
> connection. In general, the base RTT indicates the threshold such
> that RTTs above it indicate congestion. More details in the
> relevant patches.
Series applied, thank you.
^ permalink raw reply
* Re: [PATCH net-next 0/3] tun: timer cleanups
From: David Miller @ 2017-10-22 2:15 UTC (permalink / raw)
To: edumazet; +Cc: netdev, eric.dumazet, jasowang
In-Reply-To: <20171020182957.32729-1-edumazet@google.com>
From: Eric Dumazet <edumazet@google.com>
Date: Fri, 20 Oct 2017 11:29:54 -0700
> While working on a syzkaller issue that might have been
> fixed already by Cong Wang in commit 0ad646c81b21
> ("tun: call dev_get_valid_name() before register_netdevice()")
> I made three small changes related to flow_gc_timer.
Series applied, thanks Eric.
^ permalink raw reply
* Re: [PATCH] textsearch: fix typos in library helpers
From: David Miller @ 2017-10-22 2:15 UTC (permalink / raw)
To: rdunlap; +Cc: netdev
In-Reply-To: <8d229510-1022-b6fd-f95a-085dbc545c0a@infradead.org>
From: Randy Dunlap <rdunlap@infradead.org>
Date: Fri, 20 Oct 2017 12:15:52 -0700
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix spellos (typos) in textsearch library helpers.
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Applied.
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox