Netdev List
 help / color / mirror / Atom feed
* [RESEND] [PATCH] Fix tc stats when using -batch mode
@ 2013-10-30 18:44 Nigel Kukard
  0 siblings, 0 replies; only message in thread
From: Nigel Kukard @ 2013-10-30 18:44 UTC (permalink / raw)
  To: netdev

There are two global variables in tc/tc_class.c:
__u32 filter_qdisc;
__u32 filter_classid;

These are not re-initialized for each line received in -batch mode:
class show dev eth0 parent 1: classid 1:1
class show dev eth0 parent 1: classid 1:1
Error: duplicate "classid": "1:1" is the second value.

This patch fixes the issue by initializing the two globals when we
enter print_class().

Signed-off-by: Nigel Kukard <nkukard@lbsd.net>
---
 tc/tc_class.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/tc/tc_class.c b/tc/tc_class.c
index 9d4eea5..8043448 100644
--- a/tc/tc_class.c
+++ b/tc/tc_class.c
@@ -241,6 +241,9 @@ int tc_class_list(int argc, char **argv)
 	t.tcm_family = AF_UNSPEC;
 	memset(d, 0, sizeof(d));
 
+	filter_qdisc = 0;
+	filter_classid = 0;
+
 	while (argc > 0) {
 		if (strcmp(*argv, "dev") == 0) {
 			NEXT_ARG();
-- 
1.8.4.rc3

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2013-10-30 18:53 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-30 18:44 [RESEND] [PATCH] Fix tc stats when using -batch mode Nigel Kukard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox