* (no subject)
@ 2026-09-28 16:36 Willem de Bruijn
0 siblings, 0 replies; only message in thread
From: Willem de Bruijn @ 2026-09-28 16:36 UTC (permalink / raw)
To: Eric Dumazet, Michael S . Tsirkin
Cc: Simon Horman, Willem de Bruijn, netdev, edumazet,
David S . Miller, Jakub Kicinski, Paolo Abeni
In-Reply-To: <20260928144254.3361044-3-edumazet@kernel.org>
References: <20260928144254.3361044-1-edumazet@kernel.org> <20260928144254.3361044-3-edumazet@kernel.org>
Subject: Re: [PATCH v2 net 2/2] selftests: net: tun: add test for VLAN-tagged GSO without NEEDS_CSUM
Eric Dumazet wrote:
> Add a selftest in tun.c verifying that a VLAN-tagged (802.1Q) TCPv4 GSO
> packet without VIRTIO_NET_HDR_F_NEEDS_CSUM (both flags = 0 and
> flags = VIRTIO_NET_HDR_F_DATA_VALID) is accepted when written to a TAP
> device (/dev/net/tun with IFF_TAP | IFF_NO_PI | IFF_VNET_HDR).
Thanks. We must not regress users.
Even those that do dubious things..
What is the use case for TSO without checksum offload? Do we know of real
users?
It would not work whenever segmentation is actually needed. So maybe for
on-host VM-to-VM communication? But that won't segment with properly
configured checksum offload either.
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2026-09-28 16:36 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-28 16:36 Willem de Bruijn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox