Linux Netfilter development
 help / color / mirror / Atom feed
From: Christoph Paasch <christoph.paasch@gmail.com>
To: Jan Engelhardt <jengelh@medozas.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] netfilter: Allow dropping packet after call to l4proto->packet
Date: Thu, 12 Mar 2009 16:49:03 +0100	[thread overview]
Message-ID: <200903121649.07014.christoph.paasch@gmail.com> (raw)
In-Reply-To: <alpine.LSU.2.00.0903121634070.12067@fbirervta.pbzchgretzou.qr>

[-- Attachment #1: Type: text/plain, Size: 496 bytes --]


On Thu March 12 2009 wrote Jan Engelhardt:
> On Thursday 2009-03-12 16:13, Christoph Paasch wrote:
> >As NF_DROP = 0, no packets would ever have been dropped.
>
> Mh would not it be safer to actually give NF_DROP a real value so that
> -NF_DROP also makes sense?
Yes, why not...

> (Might need checking places where NF_DROP is used.)
NF_DROP is used only in tcp_packet (as far as I can see, no other l4 proto 
uses it in *_packet)


--
Christoph Paasch

www.rollerbulls.be
--

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

  reply	other threads:[~2009-03-12 15:49 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-12 13:44 l4_packet returning NF_DROP Christoph Paasch
2009-03-12 15:02 ` Christoph Paasch
2009-03-12 15:13   ` [PATCH] netfilter: Allow dropping packet after call to l4proto->packet Christoph Paasch
2009-03-12 15:34     ` Jan Engelhardt
2009-03-12 15:49       ` Christoph Paasch [this message]
2009-03-12 16:07         ` Jan Engelhardt
2009-03-12 17:27       ` Pablo Neira Ayuso
2009-03-12 17:26     ` Pablo Neira Ayuso
2009-03-13  8:27       ` Christoph Paasch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200903121649.07014.christoph.paasch@gmail.com \
    --to=christoph.paasch@gmail.com \
    --cc=jengelh@medozas.de \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox