* Fwd: Bug 883 - Uninitialized values in libnetfilter_log.c [not found] <CA+J3vcL=6i2DfpGcGpPw6WSrw7tdWn=5Y8e8q6KObDe8t_kAOA@mail.gmail.com> @ 2014-01-12 9:14 ` Ivan Homoliak 2014-01-13 16:02 ` Phil Oester 0 siblings, 1 reply; 2+ messages in thread From: Ivan Homoliak @ 2014-01-12 9:14 UTC (permalink / raw) To: netfilter-devel [-- Attachment #1: Type: text/plain, Size: 302 bytes --] I think I found few bugs in libnetfilter_log by valgrind and ulogd. See the patch in attachment. Version: libnetfilter_log-1.0.1 File: libnetfilter_log.c GCC: 4.8.2 20131212 (Red Hat 4.8.2-7) OS: Fedora release 19 (Schrödinger’s Cat) Kernel: 3.12.5-200.fc19.x86_64 Regards, Ivan Homoliak. [-- Attachment #2: libnetfilter_log-1.0.1.patch --] [-- Type: application/octet-stream, Size: 458 bytes --] 135a136,137 > > memset(&u, 0, sizeof(u)); 472c474,475 < --- > memset(&u, 0, sizeof(u)); > 477a481 > params._pad = (u_int8_t) 0; 502a507,508 > memset(&u, 0, sizeof(u)); > 527a534,535 > memset(&u, 0, sizeof(u)); > 556c564 < int status; --- > int status = 0; //ihomoliak 557a566,567 > memset(&u, 0, sizeof(u)); > 590a601,602 > memset(&u, 0, sizeof(u)); > ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Fwd: Bug 883 - Uninitialized values in libnetfilter_log.c 2014-01-12 9:14 ` Fwd: Bug 883 - Uninitialized values in libnetfilter_log.c Ivan Homoliak @ 2014-01-13 16:02 ` Phil Oester 0 siblings, 0 replies; 2+ messages in thread From: Phil Oester @ 2014-01-13 16:02 UTC (permalink / raw) To: Ivan Homoliak; +Cc: netfilter-devel On Sun, Jan 12, 2014 at 10:14:38AM +0100, Ivan Homoliak wrote: > I think I found few bugs in libnetfilter_log by valgrind and ulogd. > See the patch in attachment. Hi Ivan, thanks for the patch, but please send the diff in unified format, and include your signed-off-by. See Documentation/SubmittingPatches for further information. Phil ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-01-13 16:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CA+J3vcL=6i2DfpGcGpPw6WSrw7tdWn=5Y8e8q6KObDe8t_kAOA@mail.gmail.com>
2014-01-12 9:14 ` Fwd: Bug 883 - Uninitialized values in libnetfilter_log.c Ivan Homoliak
2014-01-13 16:02 ` Phil Oester
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox