From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Phil Sutter <phil@nwl.cc>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [iptables PATCH] xtables-monitor: Fix ip6tables rule printing
Date: Thu, 13 Aug 2020 04:03:12 +0200 [thread overview]
Message-ID: <20200813020312.GC3104@salvia> (raw)
In-Reply-To: <20200807145100.21340-1-phil@nwl.cc>
On Fri, Aug 07, 2020 at 04:51:00PM +0200, Phil Sutter wrote:
> When printing an ip6tables rule event, false family ops are used as they
> are initially looked up for AF_INET and reused no matter the current
> rule's family. In practice, this means that nft_rule_print_save() calls
> the wrong rule_to_cs, save_rule and clear_cs callbacks. Therefore, if a
> rule specifies a source or destination address, the address is not
> printed.
>
> Fix this by performing a family lookup each time rule_cb is called.
>
> Signed-off-by: Phil Sutter <phil@nwl.cc>
Acked-by: Pablo Neira Ayuso <pablo@netfilter.org>
prev parent reply other threads:[~2020-08-13 2:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-07 14:51 [iptables PATCH] xtables-monitor: Fix ip6tables rule printing Phil Sutter
2020-08-13 2:03 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200813020312.GC3104@salvia \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox