From: Boris Sukholitko <boris.sukholitko@broadcom.com>
To: netfilter-devel@vger.kernel.org
Cc: Ilya Lifshits <ilya.lifshits@broadcom.com>,
Boris Sukholitko <boris.sukholitko@broadcom.com>
Subject: [PATCH nf-next v2 1/4] selftest: netfilter: use /proc for pid checking
Date: Thu, 4 May 2023 11:48:11 +0300 [thread overview]
Message-ID: <20230504084814.41487-2-boris.sukholitko@broadcom.com> (raw)
In-Reply-To: <20230504084814.41487-1-boris.sukholitko@broadcom.com>
[-- Attachment #1: Type: text/plain, Size: 796 bytes --]
Some ps commands (e.g. busybox derived) have no -p option. Use /proc for
pid existence check.
Signed-off-by: Boris Sukholitko <boris.sukholitko@broadcom.com>
---
tools/testing/selftests/netfilter/nft_flowtable.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/netfilter/nft_flowtable.sh b/tools/testing/selftests/netfilter/nft_flowtable.sh
index 7060bae04ec8..4d8bc51b7a7b 100755
--- a/tools/testing/selftests/netfilter/nft_flowtable.sh
+++ b/tools/testing/selftests/netfilter/nft_flowtable.sh
@@ -288,11 +288,11 @@ test_tcp_forwarding_ip()
sleep 3
- if ps -p $lpid > /dev/null;then
+ if test -d /proc/"$lpid"/; then
kill $lpid
fi
- if ps -p $cpid > /dev/null;then
+ if test -d /proc/"$cpid"/; then
kill $cpid
fi
--
2.32.0
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4221 bytes --]
next prev parent reply other threads:[~2023-05-04 8:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-04 8:48 [PATCH nf-next v2 0/4] selftest: netfilter: small test tweaks Boris Sukholitko
2023-05-04 8:48 ` Boris Sukholitko [this message]
2023-05-04 8:48 ` [PATCH nf-next v2 2/4] selftest: netfilter: no need for ps -x option Boris Sukholitko
2023-05-04 8:48 ` [PATCH nf-next v2 3/4] selftest: netfilter: wait for specific nc pids Boris Sukholitko
2023-05-04 8:48 ` [PATCH nf-next v2 4/4] selftest: netfilter: monitor result file sizes Boris Sukholitko
2023-05-10 7:09 ` [PATCH nf-next v2 0/4] selftest: netfilter: small test tweaks Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230504084814.41487-2-boris.sukholitko@broadcom.com \
--to=boris.sukholitko@broadcom.com \
--cc=ilya.lifshits@broadcom.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox