Linux Netfilter development
 help / color / mirror / Atom feed
From: Boris Sukholitko <boris.sukholitko@broadcom.com>
To: netfilter-devel@vger.kernel.org
Cc: Ilya Lifshits <ilya.lifshits@broadcom.com>,
	Boris Sukholitko <boris.sukholitko@broadcom.com>,
	Florian Westphal <fw@strlen.de>
Subject: [PATCH nf-next v2 4/4] selftest: netfilter: monitor result file sizes
Date: Thu,  4 May 2023 11:48:14 +0300	[thread overview]
Message-ID: <20230504084814.41487-5-boris.sukholitko@broadcom.com> (raw)
In-Reply-To: <20230504084814.41487-1-boris.sukholitko@broadcom.com>

[-- Attachment #1: Type: text/plain, Size: 1257 bytes --]

When running nft_flowtable.sh in VM on a busy server we've found that
the time of the netcat file transfers vary wildly.

Therefore replace hardcoded 3 second sleep with the loop checking for
a change in the file sizes. Once no change in detected we test the results.

Nice side effect is that we shave 1 second sleep in the fast case
(hard-coded 3 second sleep vs two 1 second sleeps).

Acked-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Boris Sukholitko <boris.sukholitko@broadcom.com>
---
 tools/testing/selftests/netfilter/nft_flowtable.sh | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/tools/testing/selftests/netfilter/nft_flowtable.sh b/tools/testing/selftests/netfilter/nft_flowtable.sh
index 92bc308bf168..51f986f19fee 100755
--- a/tools/testing/selftests/netfilter/nft_flowtable.sh
+++ b/tools/testing/selftests/netfilter/nft_flowtable.sh
@@ -286,7 +286,15 @@ test_tcp_forwarding_ip()
 	ip netns exec $nsa nc -w 4 "$dstip" "$dstport" < "$nsin" > "$ns1out" &
 	cpid=$!
 
-	sleep 3
+	sleep 1
+
+	prev="$(ls -l $ns1out $ns2out)"
+	sleep 1
+
+	while [[ "$prev" != "$(ls -l $ns1out $ns2out)" ]]; do
+		sleep 1;
+		prev="$(ls -l $ns1out $ns2out)"
+	done
 
 	if test -d /proc/"$lpid"/; then
 		kill $lpid
-- 
2.32.0


[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4221 bytes --]

  parent reply	other threads:[~2023-05-04  8:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-04  8:48 [PATCH nf-next v2 0/4] selftest: netfilter: small test tweaks Boris Sukholitko
2023-05-04  8:48 ` [PATCH nf-next v2 1/4] selftest: netfilter: use /proc for pid checking Boris Sukholitko
2023-05-04  8:48 ` [PATCH nf-next v2 2/4] selftest: netfilter: no need for ps -x option Boris Sukholitko
2023-05-04  8:48 ` [PATCH nf-next v2 3/4] selftest: netfilter: wait for specific nc pids Boris Sukholitko
2023-05-04  8:48 ` Boris Sukholitko [this message]
2023-05-10  7:09 ` [PATCH nf-next v2 0/4] selftest: netfilter: small test tweaks Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230504084814.41487-5-boris.sukholitko@broadcom.com \
    --to=boris.sukholitko@broadcom.com \
    --cc=fw@strlen.de \
    --cc=ilya.lifshits@broadcom.com \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox