Linux Netfilter development
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: <netfilter-devel@vger.kernel.org>
Cc: Florian Westphal <fw@strlen.de>
Subject: [RFC nf-next 0/4] nf_tables: remove explicit register zeroing
Date: Thu, 27 Jun 2024 15:53:20 +0200	[thread overview]
Message-ID: <20240627135330.17039-1-fw@strlen.de> (raw)

Hi,

I'd like to propose this again.

First patch is preparation work.
Second patch is the actual change I'd like to get into nf-next.

The third patch partially un-does the second:
Instead of rejecting a rule that triggers uninitialised register
access detection, do explicit zeroing from blob generator.

Please see patch 3 for a rationale why I think that we should
just go with patch 1+2.

Patch 4 reverts the explicit zeroing.

Florian Westphal (4):
  netfilter: nf_tables: pass context structure to
    nft_parse_register_load
  netfilter: nf_tables: allow loads only when register is initialized
  netfilter: nf_tables: insert register zeroing instructions for dodgy
    chains
  netfilter: nf_tables: don't initialize registers in nft_do_chain()

 include/net/netfilter/nf_tables.h      |  14 ++-
 net/bridge/netfilter/nft_meta_bridge.c |   2 +-
 net/ipv4/netfilter/nft_dup_ipv4.c      |   4 +-
 net/ipv6/netfilter/nft_dup_ipv6.c      |   4 +-
 net/netfilter/nf_tables_api.c          | 119 +++++++++++++++++++++++--
 net/netfilter/nf_tables_core.c         |   2 +-
 net/netfilter/nft_bitwise.c            |   4 +-
 net/netfilter/nft_byteorder.c          |   2 +-
 net/netfilter/nft_cmp.c                |   6 +-
 net/netfilter/nft_ct.c                 |   2 +-
 net/netfilter/nft_dup_netdev.c         |   2 +-
 net/netfilter/nft_dynset.c             |   4 +-
 net/netfilter/nft_exthdr.c             |   2 +-
 net/netfilter/nft_fwd_netdev.c         |   6 +-
 net/netfilter/nft_hash.c               |   2 +-
 net/netfilter/nft_lookup.c             |   2 +-
 net/netfilter/nft_masq.c               |   4 +-
 net/netfilter/nft_meta.c               |   2 +-
 net/netfilter/nft_nat.c                |   8 +-
 net/netfilter/nft_objref.c             |   2 +-
 net/netfilter/nft_payload.c            |   2 +-
 net/netfilter/nft_queue.c              |   2 +-
 net/netfilter/nft_range.c              |   2 +-
 net/netfilter/nft_redir.c              |   4 +-
 net/netfilter/nft_tproxy.c             |   4 +-
 25 files changed, 159 insertions(+), 48 deletions(-)

-- 
2.44.2


             reply	other threads:[~2024-06-27 13:58 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-27 13:53 Florian Westphal [this message]
2024-06-27 13:53 ` [RFC nf-next 1/4] netfilter: nf_tables: pass context structure to nft_parse_register_load Florian Westphal
2024-06-27 13:53 ` [RFC nf-next 2/4] netfilter: nf_tables: allow loads only when register is initialized Florian Westphal
2024-07-01 20:31   ` Pablo Neira Ayuso
2024-07-01 22:16     ` Florian Westphal
2024-06-27 13:53 ` [RFC nf-next 3/4] netfilter: nf_tables: insert register zeroing instructions for dodgy chains Florian Westphal
2024-07-01 20:30   ` Pablo Neira Ayuso
2024-07-01 22:18     ` Florian Westphal
2024-07-01 22:32       ` Pablo Neira Ayuso
2024-06-27 13:53 ` [RFC nf-next 4/4] netfilter: nf_tables: don't initialize registers in nft_do_chain() Florian Westphal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240627135330.17039-1-fw@strlen.de \
    --to=fw@strlen.de \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox