Linux Netfilter development
 help / color / mirror / Atom feed
* Re: [RESEND][NETFILTER][PATCH] nfqnl_mangle() not requesting enough space for bigger reinjected packet.
       [not found]   ` <87zlrdtw6q.fsf@natisbad.org>
@ 2008-05-06 10:18     ` Patrick McHardy
  0 siblings, 0 replies; only message in thread
From: Patrick McHardy @ 2008-05-06 10:18 UTC (permalink / raw)
  To: Arnaud Ebalard
  Cc: Linux Netdev List, David Miller, Netfilter Developer Mailing List

Arnaud Ebalard wrote:
> BTW, while looking at the code, I noticed the call to skb_copy_expand()
> leads to a complete copy of current sk_buff data to the new sk_buff.
> Those data are then completely rewritten a few lines later. Too bad
> there is no simple way (considering skbuff.h) to prevent the useless
> copy.


Yeah, thats a bit unfortunate. I don't see how we could avoid
this besides allocating a fresh skb and setting up all the meta
data manually though.


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2008-05-06 10:19 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <87abjdvpiq.fsf@natisbad.org>
     [not found] ` <481647F2.20507@trash.net>
     [not found]   ` <87zlrdtw6q.fsf@natisbad.org>
2008-05-06 10:18     ` [RESEND][NETFILTER][PATCH] nfqnl_mangle() not requesting enough space for bigger reinjected packet Patrick McHardy

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox