Re: [RFC] masquerading/conntrack

[Pablo Neira Ayuso <pablo@netfilter.org>]

NICOLAS BOULIANE wrote:
> Pablo,
> 
> It fixed the strdup(). But now:
> 
> cc1: warnings being treated as errors
> read_config_lex.c: In function 'yylex':
> read_config_lex.c:3846: warning: label 'find_rule' defined but not used
> make[1]: *** [read_config_lex.o] Error 1
> 
> 
> if I strip this label (find_rule), then I get:
> 
> read_config_lex.c:3593: warning: 'yy_full_match' defined but not used
> make[1]: *** [read_config_lex.o] Error 1
> make[1]: Leaving directory `/usr/local/src/conntrack-tools/src'
> make: *** [all-recursive] Error 1
> 
> 
> If I remove this function (yy_full_match), then I get:
> 
> cc1: warnings being treated as errors
> read_config_lex.c: In function 'yylex':
> read_config_lex.c:3782: warning: 'yy_act' may be used uninitialized in
> this function
> make[1]: *** [read_config_lex.o] Error 1
> 
> If I initialize this var (register int yy_act = 0;), then I get:
> 
> everything compile now.

This report is really strange, your flex implementation is generating
useless code. What version are you using? Here I'm using flex 2.5.33.

> I'm using a version I compiled without the -Werror flag, it was more clean.

The -Werror is there to catch this sort of problems and force users to
report them ;), I plan to keep it there until conntrack-tools hits 1.0
at least.

Probably we have to check for a specific version of flex.

-- 
"Los honestos son inadaptados sociales" -- Les Luthiers