Linux Netfilter development
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: NICOLAS BOULIANE <nicboul@gmail.com>
Cc: Netfilter Developer Mailing List <netfilter-devel@vger.kernel.org>
Subject: Re: [RFC] masquerading/conntrack
Date: Thu, 22 May 2008 15:00:11 +0200	[thread overview]
Message-ID: <48356E5B.6030402@netfilter.org> (raw)
In-Reply-To: <dd45289d0805210913j766083e2m3ae50d846320f09c@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 774 bytes --]

NICOLAS BOULIANE wrote:
>> This report is really strange, your flex implementation is generating
>> useless code. What version are you using? Here I'm using flex 2.5.33.
>>
> 
> [nib@bwm ~]$ flex --version
> flex version 2.5.4
> [nib@bwm ~]$
> 
> [nib@bwm ~]$ yum info flex
> Loading "installonlyn" plugin
> Setting up repositories
> Reading repository metadata in from local files
> Installed Packages
> Name   : flex
> Arch   : i386
> Version: 2.5.4a
> Release: 41.fc6
> Size   : 239 k
> Repo   : installed
> ...
> 
> Centos is running on this machine.

Centos seems to be using a caveman flex version! From 1997, 11 years ago!

I have committed the following patch to warn people about using old flex
version.

-- 
"Los honestos son inadaptados sociales" -- Les Luthiers

[-- Attachment #2: x --]
[-- Type: text/plain, Size: 865 bytes --]

diff --git a/configure.in b/configure.in
index f3b8785..0a6b8fe 100644
--- a/configure.in
+++ b/configure.in
@@ -49,6 +49,21 @@ then
 	exit 1
 fi
 
+AC_MSG_CHECKING(flex version)
+flex_version=`$LEX --version | sed 's/version//g' | awk '/flex/ {print $2}'`
+flex_major=`echo $flex_version| cut -d . -f 1`
+flex_minor=`echo $flex_version| cut -d . -f 2`
+flex_rev=`echo $flex_version| cut -d . -f 3`
+ 
+if test "$flex_major" -eq "2" && test "$flex_minor" -eq "5" && test "$flex_rev" -ge "33"; then
+	AC_MSG_RESULT([$flex_version. OK])
+else
+	AC_MSG_WARN([flex version $flex_version found.
+	Version 2.5.33 or greater is required. You may experience problems
+	while compilating the conntrack-tools. Please, consider to upgrade 
+	flex.])
+fi
+
 AC_CHECK_HEADERS([linux/capability.h],, [AC_MSG_ERROR([Cannot find linux/capabibility.h])])
 
 # Checks for libraries.

      reply	other threads:[~2008-05-22 13:00 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-21  8:33 [RFC] masquerading/conntrack NICOLAS BOULIANE
2008-05-21  8:48 ` Henrik Nordstrom
2008-05-21  9:53 ` Pablo Neira Ayuso
2008-05-21 13:23   ` NICOLAS BOULIANE
2008-05-21 14:04     ` Pablo Neira Ayuso
2008-05-21 14:25       ` NICOLAS BOULIANE
2008-05-21 15:10         ` Pablo Neira Ayuso
2008-05-21 16:13           ` NICOLAS BOULIANE
2008-05-22 13:00             ` Pablo Neira Ayuso [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48356E5B.6030402@netfilter.org \
    --to=pablo@netfilter.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=nicboul@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox