From: Patrick McHardy <kaber@trash.net>
To: Jan Engelhardt <jengelh@medozas.de>
Cc: Krzysztof Oledzki <ole@ans.pl>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 2/2] Netfilter: Accounting rework: ct_extend + 64bit counters (v3)
Date: Mon, 30 Jun 2008 17:59:34 +0200 [thread overview]
Message-ID: <486902E6.2020701@trash.net> (raw)
In-Reply-To: <alpine.LNX.1.10.0806281109160.12725@fbirervta.pbzchgretzou.qr>
Jan Engelhardt wrote:
> On Tuesday 2008-06-24 19:13, Krzysztof Oledzki wrote:
>>> On Tuesday 2008-06-24 18:45, Patrick McHardy wrote:
>>>> sysctls using the sysctl() syscall are deprecated if I'm
>>>> not mistaken. sysfs also allows to change module parameters
>>>> at runtime, but sure, keep it, it will be gone soon enough.
>>> The entire sysctl(2) mechanism is deprecated.
>> That's why I used CTL_UNNUMBERED here.
>>
>> http://www.kernel.org/doc/Documentation/sysctl/ctl_unnumbered.txt
>
> But still, if a module_param suffices, I do not see a need for
> providing an additional user-visible api via sysctl.
Well, its a bit easier/more flexible to use, especially when not
using modules, and its more in line with the remaining netfilter
controls. So I'm OK with the sysctl.
next prev parent reply other threads:[~2008-06-30 15:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-19 11:00 [PATCH 2/2] Netfilter: Accounting rework: ct_extend + 64bit counters (v3) Krzysztof Piotr Oledzki
2008-06-24 15:38 ` Patrick McHardy
2008-06-24 16:37 ` Krzysztof Oledzki
2008-06-24 16:45 ` Patrick McHardy
2008-06-24 16:50 ` Jan Engelhardt
2008-06-24 17:13 ` Krzysztof Oledzki
2008-06-28 9:09 ` Jan Engelhardt
2008-06-30 15:59 ` Patrick McHardy [this message]
2008-07-02 13:03 ` Krzysztof Oledzki
2008-07-02 13:07 ` Patrick McHardy
2008-07-02 13:20 ` Krzysztof Oledzki
2008-07-02 13:21 ` Patrick McHardy
2008-07-02 13:36 ` Krzysztof Oledzki
2008-07-02 13:40 ` Patrick McHardy
2008-07-02 13:46 ` Krzysztof Oledzki
2008-07-02 13:51 ` Patrick McHardy
2008-07-02 13:57 ` Jan Engelhardt
2008-07-02 14:02 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=486902E6.2020701@trash.net \
--to=kaber@trash.net \
--cc=jengelh@medozas.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=ole@ans.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox