From: Patrick McHardy <kaber@trash.net>
To: Krzysztof Oledzki <ole@ans.pl>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 2/2] Netfilter: Accounting rework: ct_extend + 64bit counters (v3)
Date: Wed, 02 Jul 2008 15:07:40 +0200 [thread overview]
Message-ID: <486B7D9C.4070501@trash.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0807021358370.4958@bizon.gios.gov.pl>
Krzysztof Oledzki wrote:
>
>
> On Tue, 24 Jun 2008, Krzysztof Oledzki wrote:
>
> <CUT>
>
>>>> +static unsigned int nf_ct_acct __read_mostly = NF_CT_ACCT_DEFAULT;
>>>
>>> Perhaps this should be bool instead?
>>
>> Yep.
>
> It seems that it has to stay as unsigned int - if I change it to bool I
> get:
> net/netfilter/nf_conntrack_acct.c: In function '__check_acct':
> net/netfilter/nf_conntrack_acct.c:27: warning: return from incompatible
> pointer type
You also need to use the proper module_param type.
next prev parent reply other threads:[~2008-07-02 13:07 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-19 11:00 [PATCH 2/2] Netfilter: Accounting rework: ct_extend + 64bit counters (v3) Krzysztof Piotr Oledzki
2008-06-24 15:38 ` Patrick McHardy
2008-06-24 16:37 ` Krzysztof Oledzki
2008-06-24 16:45 ` Patrick McHardy
2008-06-24 16:50 ` Jan Engelhardt
2008-06-24 17:13 ` Krzysztof Oledzki
2008-06-28 9:09 ` Jan Engelhardt
2008-06-30 15:59 ` Patrick McHardy
2008-07-02 13:03 ` Krzysztof Oledzki
2008-07-02 13:07 ` Patrick McHardy [this message]
2008-07-02 13:20 ` Krzysztof Oledzki
2008-07-02 13:21 ` Patrick McHardy
2008-07-02 13:36 ` Krzysztof Oledzki
2008-07-02 13:40 ` Patrick McHardy
2008-07-02 13:46 ` Krzysztof Oledzki
2008-07-02 13:51 ` Patrick McHardy
2008-07-02 13:57 ` Jan Engelhardt
2008-07-02 14:02 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=486B7D9C.4070501@trash.net \
--to=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
--cc=ole@ans.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox