Linux Netfilter development
 help / color / mirror / Atom feed
From: Fabian Hugelshofer <hugelshofer2006@gmx.ch>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Patrick McHardy <kaber@trash.net>,
	Netfilter Development Mailinglist
	<netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH 7/7] dynamic calculation of event message size for ctnetlin
Date: Thu, 31 Jul 2008 17:26:41 +0100	[thread overview]
Message-ID: <4891E7C1.2060203@gmx.ch> (raw)
In-Reply-To: <48904B37.7090108@netfilter.org>

Pablo Neira Ayuso wrote:
> [PATCH] dynamic calculation of event message size for ctnetlink
> 
> This patch adds dynamic message size calculation for ctnetlink. This
> reduces CPU consumption since the overhead in the message trimming
> is removed.

Thanks for the patch.

Just did some performance tests. On average it saves 5% CPU usage at 
~1600pps (UDP packets, 1000B payload, random source ports) on my router 
(IXP4XX, 266Mhz).

With the unclean patch the performance gain was slightly higher. I have 
posted it was 10%, but as far as I remember it was actually a bit less 
then that. The remaining difference can be explained by the length 
calculation overhead and measuring inaccuracy.

  reply	other threads:[~2008-07-31 16:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-30 11:06 [PATCH 7/7] dynamic calculation of event message size for ctnetlin Pablo Neira Ayuso
2008-07-31 16:26 ` Fabian Hugelshofer [this message]
2008-07-31 16:42   ` Pablo Neira Ayuso
2008-07-31 16:54     ` Fabian Hugelshofer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4891E7C1.2060203@gmx.ch \
    --to=hugelshofer2006@gmx.ch \
    --cc=kaber@trash.net \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox