Linux Netfilter development
 help / color / mirror / Atom feed
* physdev: remove extra space in output
@ 2008-08-06 21:32 Jan Engelhardt
  2008-08-13 12:40 ` Patrick McHardy
  0 siblings, 1 reply; 2+ messages in thread
From: Jan Engelhardt @ 2008-08-06 21:32 UTC (permalink / raw)
  To: kaber; +Cc: Netfilter Developer Mailing List

commit 99f9a7790de1f94d0d8a46c5699f2beb32ac193e
Author: Jan Engelhardt <jengelh@medozas.de>
Date:   Wed Aug 6 17:31:08 2008 -0400

physdev: remove extra space in output

Just a cosmetic fix for `iptables -S` and `iptables-save` printing
two spaces between arguments in the physdev match.

Signed-off-by: Jan Engelhardt <jengelh@medozas.de>
---
 extensions/libxt_physdev.c |   23 ++++++++++++-----------
 1 files changed, 12 insertions(+), 11 deletions(-)

diff --git a/extensions/libxt_physdev.c b/extensions/libxt_physdev.c
index 34547c8..0a937ea 100644
--- a/extensions/libxt_physdev.c
+++ b/extensions/libxt_physdev.c
@@ -143,22 +143,23 @@ static void physdev_save(const void *ip, const struct xt_entry_match *match)
 		(struct xt_physdev_info*)match->data;
 
 	if (info->bitmask & XT_PHYSDEV_OP_ISIN)
-		printf("%s --physdev-is-in",
-		       info->invert & XT_PHYSDEV_OP_ISIN ? " !":"");
+		printf("%s--physdev-is-in ",
+		       (info->invert & XT_PHYSDEV_OP_ISIN) ? "! " : "");
 	if (info->bitmask & XT_PHYSDEV_OP_IN)
-		printf("%s --physdev-in %s",
-		(info->invert & XT_PHYSDEV_OP_IN) ? " !":"", info->physindev);
+		printf("%s--physdev-in %s ",
+		       (info->invert & XT_PHYSDEV_OP_IN) ? "! " : "",
+		       info->physindev);
 
 	if (info->bitmask & XT_PHYSDEV_OP_ISOUT)
-		printf("%s --physdev-is-out",
-		       info->invert & XT_PHYSDEV_OP_ISOUT ? " !":"");
+		printf("%s--physdev-is-out ",
+		       (info->invert & XT_PHYSDEV_OP_ISOUT) ? "! " : "");
 	if (info->bitmask & XT_PHYSDEV_OP_OUT)
-		printf("%s --physdev-out %s",
-		(info->invert & XT_PHYSDEV_OP_OUT) ? " !":"", info->physoutdev);
+		printf("%s--physdev-out %s ",
+		       (info->invert & XT_PHYSDEV_OP_OUT) ? "! " : "",
+		       info->physoutdev);
 	if (info->bitmask & XT_PHYSDEV_OP_BRIDGED)
-		printf("%s --physdev-is-bridged",
-		       info->invert & XT_PHYSDEV_OP_BRIDGED ? " !":"");
-	printf(" ");
+		printf("%s--physdev-is-bridged ",
+		       (info->invert & XT_PHYSDEV_OP_BRIDGED) ? "! " : "");
 }
 
 static struct xtables_match physdev_match = {


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: physdev: remove extra space in output
  2008-08-06 21:32 physdev: remove extra space in output Jan Engelhardt
@ 2008-08-13 12:40 ` Patrick McHardy
  0 siblings, 0 replies; 2+ messages in thread
From: Patrick McHardy @ 2008-08-13 12:40 UTC (permalink / raw)
  To: Jan Engelhardt; +Cc: Netfilter Developer Mailing List

Jan Engelhardt wrote:
> physdev: remove extra space in output
> 
> Just a cosmetic fix for `iptables -S` and `iptables-save` printing
> two spaces between arguments in the physdev match.

Applied, thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-08-13 12:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-08-06 21:32 physdev: remove extra space in output Jan Engelhardt
2008-08-13 12:40 ` Patrick McHardy

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox