Linux Netfilter development
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Jan Engelhardt <jengelh@medozas.de>
Cc: Netfilter Developer Mailing List <netfilter-devel@vger.kernel.org>
Subject: Re: 7/7 [NETFILTER]: Implement NFPROTO_UNSPEC as a wildcard for extensions
Date: Thu, 04 Sep 2008 17:10:49 +0200	[thread overview]
Message-ID: <48BFFA79.701@trash.net> (raw)
In-Reply-To: <alpine.LNX.1.10.0808131943180.13154@fbirervta.pbzchgretzou.qr>

[-- Attachment #1: Type: text/plain, Size: 600 bytes --]

Jan Engelhardt wrote:
> [NETFILTER]: Implement NFPROTO_UNSPEC as a wildcard for extensions
> 
> When a match or target is looked up using xt_find_{match,target},
> Xtables will also search the NFPROTO_UNSPEC module list. This allows
> for protocol-independent extensions (like xt_time) to be reused from
> other components (e.g. arptables, ebtables).
> 
> Extensions that take different codepaths depending on match->family
> or target->family of course cannot use NFPROTO_UNSPEC within the
> registration structure (e.g. xt_pkttype).

Nice work. You should have compile tested it though.

Applied.


[-- Attachment #2: x --]
[-- Type: text/plain, Size: 484 bytes --]

diff --git a/net/netfilter/xt_string.c b/net/netfilter/xt_string.c
index 9365a49..18d8884 100644
--- a/net/netfilter/xt_string.c
+++ b/net/netfilter/xt_string.c
@@ -81,7 +81,7 @@ static void string_mt_destroy(const struct xt_match *match, void *matchinfo)
 	textsearch_destroy(STRING_TEXT_PRIV(matchinfo)->config);
 }
 
-static struct xt_match string_mt_reg[] __read_mostly = {
+static struct xt_match xt_string_mt_reg[] __read_mostly = {
 	{
 		.name 		= "string",
 		.revision	= 0,

  reply	other threads:[~2008-09-04 15:10 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-13 23:25 1/7 [NETFILTER]: Use unsigned types for hooknum and pf vars Jan Engelhardt
2008-08-13 23:27 ` 2/7 [NETFILTER]: Rename ipt_recent to xt_recent Jan Engelhardt
2008-09-04 14:45   ` Patrick McHardy
2008-08-13 23:27 ` 3/7 [NETFILTER]: xt_recent: IPv6 support Jan Engelhardt
2008-09-04 14:48   ` Patrick McHardy
2008-08-13 23:27 ` 4/7 [NETFILTER]: xt_length match, revision 1 Jan Engelhardt
2008-09-04 14:56   ` Patrick McHardy
2008-09-04 15:56     ` Jan Engelhardt
2008-09-04 15:58       ` Patrick McHardy
2008-08-13 23:42 ` 5/7 [NETFILTER]: Introduce NFPROTO_* constants Jan Engelhardt
2008-09-04 14:59   ` Patrick McHardy
2008-08-13 23:43 ` 6/7 [NETFILTER]: Use NFPROTO_* in extensions Jan Engelhardt
2008-09-04 15:05   ` Patrick McHardy
2008-09-04 16:01     ` Patrick McHardy
2008-08-13 23:44 ` 7/7 [NETFILTER]: Implement NFPROTO_UNSPEC as a wildcard for extensions Jan Engelhardt
2008-09-04 15:10   ` Patrick McHardy [this message]
2008-09-04 15:41     ` Jan Engelhardt
2008-09-04 14:34 ` 1/7 [NETFILTER]: Use unsigned types for hooknum and pf vars Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48BFFA79.701@trash.net \
    --to=kaber@trash.net \
    --cc=jengelh@medozas.de \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox