Re: [bug, -git] ERROR: "ebt_unregister_table" [net/bridge/netfilter/ebtable_nat.ko] undefined

Re: [bug, -git] ERROR: "ebt_unregister_table" [net/bridge/netfilter/ebtable_nat.ko] undefined

[Patrick McHardy]

[-- Attachment #1: Type: text/plain, Size: 1502 bytes --]

Ingo Molnar wrote:
> i think you misunderstood my report. This is about latest upstream -git 
> being broken:
> 
> ERROR: "ebt_register_table" [net/bridge/netfilter/ebtable_filter.ko] undefined!
> ERROR: "ebt_do_table" [net/bridge/netfilter/ebtable_filter.ko] undefined!
> ERROR: "ebt_unregister_table" [net/bridge/netfilter/ebtable_filter.ko] undefined!
> ERROR: "ebt_register_table" [net/bridge/netfilter/ebtable_broute.ko] undefined!
> ERROR: "ebt_do_table" [net/bridge/netfilter/ebtable_broute.ko] undefined!
> ERROR: "ebt_unregister_table" [net/bridge/netfilter/ebtable_broute.ko] undefined!
> make[1]: *** [__modpost] Error 1
> make: *** [modules] Error 2
> 
> i posted to this thread because i wanted to find a relevant context. 
> (but probably is not)
> 
> Anyway, i started a new thread for this.
> 
> the dependencies there look pretty complex so i did not find a quick fix 
> - but i can test patches.

This appears to be caused by Jan's Kconfig changes to use menuconfig,
which lost a dependency on BRIDGE:

-menu "Bridge: Netfilter Configuration"
-       depends on BRIDGE && BRIDGE_NETFILTER
-
-config BRIDGE_NF_EBTABLES
+menuconfig BRIDGE_NF_EBTABLES
         tristate "Ethernet Bridge tables (ebtables) support"
         select NETFILTER_XTABLES
         help
           ebtables is a general, extensible frame/packet identification
           framework. Say 'Y' or 'M' here if you want to do Ethernet
           filtering/NAT/brouting on the Ethernet bridge.

Does this patch fix it?

[-- Attachment #2: x --]
[-- Type: text/plain, Size: 417 bytes --]

diff --git a/net/bridge/netfilter/Kconfig b/net/bridge/netfilter/Kconfig
index 366d3e9..ba6f73e 100644
--- a/net/bridge/netfilter/Kconfig
+++ b/net/bridge/netfilter/Kconfig
@@ -4,6 +4,7 @@
 
 menuconfig BRIDGE_NF_EBTABLES
 	tristate "Ethernet Bridge tables (ebtables) support"
+	depends on BRIDGE && BRIDGE_NETFILTER
 	select NETFILTER_XTABLES
 	help
 	  ebtables is a general, extensible frame/packet identification

Re: [bug, -git] ERROR: "ebt_unregister_table" [net/bridge/netfilter/ebtable_nat.ko] undefined

[Ingo Molnar]

* Patrick McHardy <kaber@trash.net> wrote:

> Ingo Molnar wrote:
>> i think you misunderstood my report. This is about latest upstream -git 
>> being broken:
>>
>> ERROR: "ebt_register_table" [net/bridge/netfilter/ebtable_filter.ko] undefined!
>> ERROR: "ebt_do_table" [net/bridge/netfilter/ebtable_filter.ko] undefined!
>> ERROR: "ebt_unregister_table" [net/bridge/netfilter/ebtable_filter.ko] undefined!
>> ERROR: "ebt_register_table" [net/bridge/netfilter/ebtable_broute.ko] undefined!
>> ERROR: "ebt_do_table" [net/bridge/netfilter/ebtable_broute.ko] undefined!
>> ERROR: "ebt_unregister_table" [net/bridge/netfilter/ebtable_broute.ko] undefined!
>> make[1]: *** [__modpost] Error 1
>> make: *** [modules] Error 2
>>
>> i posted to this thread because i wanted to find a relevant context.  
>> (but probably is not)
>>
>> Anyway, i started a new thread for this.
>>
>> the dependencies there look pretty complex so i did not find a quick 
>> fix - but i can test patches.
>
> This appears to be caused by Jan's Kconfig changes to use menuconfig,
> which lost a dependency on BRIDGE:
>
> -menu "Bridge: Netfilter Configuration"
> -       depends on BRIDGE && BRIDGE_NETFILTER
> -
> -config BRIDGE_NF_EBTABLES
> +menuconfig BRIDGE_NF_EBTABLES
>         tristate "Ethernet Bridge tables (ebtables) support"
>         select NETFILTER_XTABLES
>         help
>           ebtables is a general, extensible frame/packet identification
>           framework. Say 'Y' or 'M' here if you want to do Ethernet
>           filtering/NAT/brouting on the Ethernet bridge.
>
> Does this patch fix it?

yeah, the module build now succeeds fine with that config, thanks 
Patrick!

Tested-by: Ingo Molnar <mingo@elte.hu>

	Ingo

Re: [bug, -git] ERROR: "ebt_unregister_table" [net/bridge/netfilter/ebtable_nat.ko] undefined

[Patrick McHardy]

Ingo Molnar wrote:
> * Patrick McHardy <kaber@trash.net> wrote:
> 
>> Ingo Molnar wrote:
>>> i think you misunderstood my report. This is about latest upstream -git 
>>> being broken:
>>>
>>> ERROR: "ebt_register_table" [net/bridge/netfilter/ebtable_filter.ko] undefined!
>>> ERROR: "ebt_do_table" [net/bridge/netfilter/ebtable_filter.ko] undefined!
>>> ERROR: "ebt_unregister_table" [net/bridge/netfilter/ebtable_filter.ko] undefined!
>>> ERROR: "ebt_register_table" [net/bridge/netfilter/ebtable_broute.ko] undefined!
>>> ERROR: "ebt_do_table" [net/bridge/netfilter/ebtable_broute.ko] undefined!
>>> ERROR: "ebt_unregister_table" [net/bridge/netfilter/ebtable_broute.ko] undefined!
>>> make[1]: *** [__modpost] Error 1
>>> make: *** [modules] Error 2
>>>
>> Does this patch fix it?
> 
> yeah, the module build now succeeds fine with that config, thanks 
> Patrick!
> 
> Tested-by: Ingo Molnar <mingo@elte.hu>

Thanks Ingo, I'll send it upstream tonight.