From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Phil Sutter <phil@nwl.cc>, netfilter-devel@vger.kernel.org, fw@strlen.de
Subject: Re: [PATCH iptables] tests: iptables-test: extend coverage for ip6tables
Date: Tue, 22 Oct 2024 17:07:25 +0200 [thread overview]
Message-ID: <Zxe_rez8MZN-ieN8@calendula> (raw)
In-Reply-To: <Zxe85R9YnoOL-pzg@orbyte.nwl.cc>
On Tue, Oct 22, 2024 at 04:55:33PM +0200, Phil Sutter wrote:
> On Tue, Oct 22, 2024 at 03:48:12PM +0200, Pablo Neira Ayuso wrote:
> > On Tue, Oct 22, 2024 at 03:08:01PM +0200, Phil Sutter wrote:
> > > On Tue, Oct 22, 2024 at 02:30:58PM +0200, Phil Sutter wrote:
> > > [...]
> > > > - With your patch applied, 20 rules fail (in both variants). Is this
> > > > expected or a bug on my side?
> > >
> > > OK, so most failures are caused by my test kernel not having
> > > CONFIG_IP_VS_IPV6 enabled.
> > >
> > > Apart from that, there is a minor bug in introduced libip6t_recent.t in
> > > that it undoes commit d859b91e6f3ed ("extensions: recent: New kernels
> > > support 999 hits") by accident. More interesting though, it's reported
> > > twice, once for fast mode and once for normal mode. I'll see how I can
> > > turn off error reporting in fast mode, failing tests are repeated
> > > anyway.
> >
> > Would you point me to the relevant line in the libip6t_recent.t?
>
> It is in line 7, I had changed the supposed-to-fail --hitcount value of
> 999 to 65536.
This was already fixed in v2, correct?
https://patchwork.ozlabs.org/project/netfilter-devel/patch/20241021101442.182533-1-pablo@netfilter.org/
I am using 65536 there.
Thanks.
next prev parent reply other threads:[~2024-10-22 15:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-20 22:47 [PATCH iptables] tests: iptables-test: extend coverage for ip6tables Pablo Neira Ayuso
2024-10-22 12:30 ` Phil Sutter
2024-10-22 13:05 ` Pablo Neira Ayuso
2024-10-22 13:08 ` Phil Sutter
2024-10-22 13:48 ` Pablo Neira Ayuso
2024-10-22 14:55 ` Phil Sutter
2024-10-22 15:07 ` Pablo Neira Ayuso [this message]
2024-10-23 11:03 ` Phil Sutter
2024-11-05 23:01 ` Phil Sutter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zxe_rez8MZN-ieN8@calendula \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox