Linux Netfilter development
 help / color / mirror / Atom feed
From: Phil Sutter <phil@nwl.cc>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org, fw@strlen.de
Subject: Re: [PATCH iptables] tests: iptables-test: extend coverage for ip6tables
Date: Tue, 22 Oct 2024 14:30:57 +0200	[thread overview]
Message-ID: <ZxebAVfZ_aDSNeb4@orbyte.nwl.cc> (raw)
In-Reply-To: <20241020224707.69249-1-pablo@netfilter.org>

Hi Pablo,

On Mon, Oct 21, 2024 at 12:47:07AM +0200, Pablo Neira Ayuso wrote:
> Update iptables-test.py to run libxt_*.t both for iptables and
> ip6tables. This update requires changes in the existing tests.

Thanks for working on this! I see a few things we could still improve:

- Output prints libxt tests twice. Maybe append the command name?
- The copying of libxt into libipt and libip6t creates some redundancy
  depending on test content. Maybe keep the non-specific ones in a libxt
  test file?
- I noticed there are some remains of supporting '-4' and '-6' flags in
  iptables-test.py but it is unused and seems broken. One could revive
  it to keep everything in libxt files, prefixing the specific tests
  accordingly. I'll give this a try to see how much work it is to
  implement support for.
- With your patch applied, 20 rules fail (in both variants). Is this
  expected or a bug on my side?

Cheers, Phil

  reply	other threads:[~2024-10-22 12:30 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-20 22:47 [PATCH iptables] tests: iptables-test: extend coverage for ip6tables Pablo Neira Ayuso
2024-10-22 12:30 ` Phil Sutter [this message]
2024-10-22 13:05   ` Pablo Neira Ayuso
2024-10-22 13:08   ` Phil Sutter
2024-10-22 13:48     ` Pablo Neira Ayuso
2024-10-22 14:55       ` Phil Sutter
2024-10-22 15:07         ` Pablo Neira Ayuso
2024-10-23 11:03           ` Phil Sutter
2024-11-05 23:01             ` Phil Sutter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZxebAVfZ_aDSNeb4@orbyte.nwl.cc \
    --to=phil@nwl.cc \
    --cc=fw@strlen.de \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox