From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH conntrack-tools] conntrack: --id argument is mandatory
Date: Wed, 8 Oct 2025 17:23:12 +0200 [thread overview]
Message-ID: <aOaB4Gwca99LKqmU@calendula> (raw)
In-Reply-To: <20251008121820.28391-1-fw@strlen.de>
Hi Florian,
On Wed, Oct 08, 2025 at 02:18:15PM +0200, Florian Westphal wrote:
> conntrack -i
> conntrack v1.4.8 (conntrack-tools): option `-i' requires an argument
> conntrack --id
> Segmentation fault (core dumped)
>
> Signed-off-by: Florian Westphal <fw@strlen.de>
Reviewed-by: Pablo Neira Ayuso <pablo@netfilter.org>
Please, run tests with this applied, I think this is fine.
> ---
> src/conntrack.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/conntrack.c b/src/conntrack.c
> index b7d260f8e55d..940469ddcf74 100644
> --- a/src/conntrack.c
> +++ b/src/conntrack.c
> @@ -331,7 +331,7 @@ static struct option original_opts[] = {
> {"nat-range", 1, 0, 'a'}, /* deprecated */
> {"mark", 1, 0, 'm'},
> {"secmark", 1, 0, 'c'},
> - {"id", 2, 0, 'i'}, /* deprecated */
> + {"id", 1, 0, 'i'}, /* deprecated */
> {"family", 1, 0, 'f'},
> {"src-nat", 2, 0, 'n'},
> {"dst-nat", 2, 0, 'g'},
> --
> 2.49.1
>
>
prev parent reply other threads:[~2025-10-08 15:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-08 12:18 [PATCH conntrack-tools] conntrack: --id argument is mandatory Florian Westphal
2025-10-08 15:23 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aOaB4Gwca99LKqmU@calendula \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox