* [PATCH conntrack-tools] conntrack: --id argument is mandatory
@ 2025-10-08 12:18 Florian Westphal
2025-10-08 15:23 ` Pablo Neira Ayuso
0 siblings, 1 reply; 2+ messages in thread
From: Florian Westphal @ 2025-10-08 12:18 UTC (permalink / raw)
To: netfilter-devel; +Cc: Florian Westphal
conntrack -i
conntrack v1.4.8 (conntrack-tools): option `-i' requires an argument
conntrack --id
Segmentation fault (core dumped)
Signed-off-by: Florian Westphal <fw@strlen.de>
---
src/conntrack.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/conntrack.c b/src/conntrack.c
index b7d260f8e55d..940469ddcf74 100644
--- a/src/conntrack.c
+++ b/src/conntrack.c
@@ -331,7 +331,7 @@ static struct option original_opts[] = {
{"nat-range", 1, 0, 'a'}, /* deprecated */
{"mark", 1, 0, 'm'},
{"secmark", 1, 0, 'c'},
- {"id", 2, 0, 'i'}, /* deprecated */
+ {"id", 1, 0, 'i'}, /* deprecated */
{"family", 1, 0, 'f'},
{"src-nat", 2, 0, 'n'},
{"dst-nat", 2, 0, 'g'},
--
2.49.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH conntrack-tools] conntrack: --id argument is mandatory
2025-10-08 12:18 [PATCH conntrack-tools] conntrack: --id argument is mandatory Florian Westphal
@ 2025-10-08 15:23 ` Pablo Neira Ayuso
0 siblings, 0 replies; 2+ messages in thread
From: Pablo Neira Ayuso @ 2025-10-08 15:23 UTC (permalink / raw)
To: Florian Westphal; +Cc: netfilter-devel
Hi Florian,
On Wed, Oct 08, 2025 at 02:18:15PM +0200, Florian Westphal wrote:
> conntrack -i
> conntrack v1.4.8 (conntrack-tools): option `-i' requires an argument
> conntrack --id
> Segmentation fault (core dumped)
>
> Signed-off-by: Florian Westphal <fw@strlen.de>
Reviewed-by: Pablo Neira Ayuso <pablo@netfilter.org>
Please, run tests with this applied, I think this is fine.
> ---
> src/conntrack.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/conntrack.c b/src/conntrack.c
> index b7d260f8e55d..940469ddcf74 100644
> --- a/src/conntrack.c
> +++ b/src/conntrack.c
> @@ -331,7 +331,7 @@ static struct option original_opts[] = {
> {"nat-range", 1, 0, 'a'}, /* deprecated */
> {"mark", 1, 0, 'm'},
> {"secmark", 1, 0, 'c'},
> - {"id", 2, 0, 'i'}, /* deprecated */
> + {"id", 1, 0, 'i'}, /* deprecated */
> {"family", 1, 0, 'f'},
> {"src-nat", 2, 0, 'n'},
> {"dst-nat", 2, 0, 'g'},
> --
> 2.49.1
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-10-08 15:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-08 12:18 [PATCH conntrack-tools] conntrack: --id argument is mandatory Florian Westphal
2025-10-08 15:23 ` Pablo Neira Ayuso
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox