Linux Netfilter development
 help / color / mirror / Atom feed
* [iptables PATCH] libxtables: Store all requested target types
@ 2026-01-23 11:58 Phil Sutter
  2026-01-27 19:50 ` Phil Sutter
  0 siblings, 1 reply; 2+ messages in thread
From: Phil Sutter @ 2026-01-23 11:58 UTC (permalink / raw)
  To: netfilter-devel

Repeat the change in commit 1a696c99d278c ("libxtables: store all
requested match types") for target registration. An obvious use-case
affected as described in that commit is an 'nft list ruleset' process
translating different families' extensions in one go. If the same
extension is used in multiple families, only the first one is being
found.

Signed-off-by: Phil Sutter <phil@nwl.cc>
---
 libxtables/xtables.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/libxtables/xtables.c b/libxtables/xtables.c
index 5fc50a63f380b..af56a75fcb117 100644
--- a/libxtables/xtables.c
+++ b/libxtables/xtables.c
@@ -1345,10 +1345,6 @@ void xtables_register_target(struct xtables_target *me)
 	if (me->extra_opts != NULL)
 		xtables_check_options(me->name, me->extra_opts);
 
-	/* ignore not interested target */
-	if (me->family != afinfo->family && me->family != AF_UNSPEC)
-		return;
-
 	/* order into linked list of targets pending full registration */
 	for (pos = &xtables_pending_targets; *pos; pos = &(*pos)->next) {
 		/* group by name */
-- 
2.51.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [iptables PATCH] libxtables: Store all requested target types
  2026-01-23 11:58 [iptables PATCH] libxtables: Store all requested target types Phil Sutter
@ 2026-01-27 19:50 ` Phil Sutter
  0 siblings, 0 replies; 2+ messages in thread
From: Phil Sutter @ 2026-01-27 19:50 UTC (permalink / raw)
  To: netfilter-devel

On Fri, Jan 23, 2026 at 12:58:37PM +0100, Phil Sutter wrote:
> Repeat the change in commit 1a696c99d278c ("libxtables: store all
> requested match types") for target registration. An obvious use-case
> affected as described in that commit is an 'nft list ruleset' process
> translating different families' extensions in one go. If the same
> extension is used in multiple families, only the first one is being
> found.
> 
> Signed-off-by: Phil Sutter <phil@nwl.cc>

Patch applied.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-01-27 19:50 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-23 11:58 [iptables PATCH] libxtables: Store all requested target types Phil Sutter
2026-01-27 19:50 ` Phil Sutter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox