From: Florian Westphal <fw@strlen.de>
To: Phil Sutter <phil@nwl.cc>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [nft PATCH] doc: nft.8: Describe iface_type data type
Date: Tue, 27 Jan 2026 23:47:16 +0100 [thread overview]
Message-ID: <aXlAdFAKM5SVfFfE@strlen.de> (raw)
In-Reply-To: <aXk-ZPRpYwj_KZ5e@orbyte.nwl.cc>
Phil Sutter <phil@nwl.cc> wrote:
> On Tue, Jan 27, 2026 at 11:17:59PM +0100, Florian Westphal wrote:
> > Phil Sutter <phil@nwl.cc> wrote:
> > > +INTERFACE TYPE TYPE
> > > +~~~~~~~~~~~~~~~~~~~
> >
> > TYPE TYPE?
>
> Yes, sadly. ;)
Ugh.
> We also have "ICMP TYPE TYPE" and "ICMPV6 TYPE TYPE" - the types
> themselves are called "icmp_type", "icmpv6_type" and "iface_type". So
> section titles formed like "<type> type" end up this way. It seems
> wrong, but "INTERFACE TYPE" is misleading as the type is not called
> "interface" but "interface type".
Whats wrong with INTERFACE TYPE?
Its called interface type.
I'd remove the extra TYPE everywhere, its not many occurences:
data-types.txt:ICMP TYPE TYPE
data-types.txt:The ICMP Type type is used to conveniently specify the ICMP header's type field.
data-types.txt:ICMPV6 TYPE TYPE
data-types.txt:The ICMPv6 Type type is used to conveniently specify the ICMPv6 header's type field.
next prev parent reply other threads:[~2026-01-27 22:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-27 22:12 [nft PATCH] doc: nft.8: Describe iface_type data type Phil Sutter
2026-01-27 22:17 ` Florian Westphal
2026-01-27 22:38 ` Phil Sutter
2026-01-27 22:47 ` Florian Westphal [this message]
2026-01-27 22:59 ` Phil Sutter
2026-01-27 23:18 ` Florian Westphal
2026-01-27 23:30 ` Phil Sutter
2026-02-05 15:21 ` Phil Sutter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXlAdFAKM5SVfFfE@strlen.de \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox