From: Florian Westphal <fw@strlen.de>
To: Phil Sutter <phil@nwl.cc>, netfilter-devel@vger.kernel.org
Subject: Re: [nft PATCH] doc: nft.8: Describe iface_type data type
Date: Wed, 28 Jan 2026 00:18:51 +0100 [thread overview]
Message-ID: <aXlH2xBJdgX9gFgj@strlen.de> (raw)
In-Reply-To: <aXlDPwtasLIQ9NMg@orbyte.nwl.cc>
Phil Sutter <phil@nwl.cc> wrote:
> As said, these headers are all structured as "<typename> TYPE":
>
> - INTEGER TYPE
> - BITMASK TYPE
> - STRING TYPE
> - INTERFACE TYPE TYPE
- INTERFACE TYPE
> - LINK LAYER ADDRESS TYPE
> - IPV4 ADDRESS TYPE
> ...
> - ICMP TYPE TYPE
ICMP TYPE
> - ICMP CODE TYPE
> - ICMPV6 TYPE TYPE
> - ICMPV6 TYPE
> IMO we could drop the " TYPE" suffix from them all, but only merging the
> "TYPE TYPE" cases is inconsistent.
Why?!
INTEGER TYPE
INTERFACE TYPE TYPE
Thats absolutely sounds inconsistent.
Sure:
payload expression, datatype integer (integer), 4 bits
meta expression, datatype iface_type (network interface type) (basetype integer), 16 bits
So what?
I don't see any implication that you can take 'FOO TYPE' to mean
that the type is called 'foo' internally.
> I get your point, it looks wrong and sounds odd when reading out loud
> but it is formally correct.
Ok, I give up.
next prev parent reply other threads:[~2026-01-27 23:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-27 22:12 [nft PATCH] doc: nft.8: Describe iface_type data type Phil Sutter
2026-01-27 22:17 ` Florian Westphal
2026-01-27 22:38 ` Phil Sutter
2026-01-27 22:47 ` Florian Westphal
2026-01-27 22:59 ` Phil Sutter
2026-01-27 23:18 ` Florian Westphal [this message]
2026-01-27 23:30 ` Phil Sutter
2026-02-05 15:21 ` Phil Sutter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXlH2xBJdgX9gFgj@strlen.de \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox