[ANNOUNCEMENT] ipset-2.3.1 released

[ANNOUNCEMENT] ipset-2.3.1 released

[Jozsef Kadlecsik]

Hello,

I'm happy to release a new version of ipset. This is a bugfix release, no 
new features added. The list of the fixes:

- kernel part: a nasty typo which can lead to kernel crash when 
  creating a set is fixed in the macipmap type
- userspace tool:
  - segfault on --unbind :all: :all: fixed (reported by cheetah and Tom 
    Eastep)
  - User input parameters are sanitized everywhere
  - Initial testsuite added: few bugs discovered and fixed
    - typo in macipmap type prevented to use max size set of this type
    - *map types are made sure to allow and use max size of sets

You can download the ipset-1.3.1 source tree and the patch-o-matic-ng 
snapshot from http://ipset.netfilter.org/.

The sources can be downloaded directly from the git and svn repositories
as well:

- patch-o-matic-ng from git: git://git.netfilter.org/patch-o-matic-ng.git
- ipset from svn: https://svn.netfilter.org/netfilter/trunk/ipset

Best regards,
Jozsef
-
E-mail  : kadlec@blackhole.kfki.hu, kadlec@mail.kfki.hu
PGP key : http://www.kfki.hu/~kadlec/pgp_public_key.txt
Address : KFKI Research Institute for Particle and Nuclear Physics
          H-1525 Budapest 114, POB. 49, Hungary

Re: [ANNOUNCEMENT] ipset-2.3.1 released

[pud]

On Thu, 12 Jun 2008, Jozsef Kadlecsik wrote:

> Hello,
> 
> I'm happy to release a new version of ipset. This is a bugfix release, no 
> new features added. The list of the fixes:

thanks for that, but maybe it still needs a fix for building with glibc-2.8:

cc -O2 -Wall -Wunused -I/usr/src/linux/include -I.  -fPIC -o ipset_iphash.o -c ipset_iphash.c
ipset_iphash.c: In function 'create_parse':
ipset_iphash.c:71: error: 'UINT_MAX' undeclared (first use in this function)
ipset_iphash.c:71: error: (Each undeclared identifier is reported only once
ipset_iphash.c:71: error: for each function it appears in.)
make: *** [ipset_iphash.o] Error 1


including limits.h fixes it of cause, but i'm not sure if that is a proper fix



-- 
gpg-key #C3B04767

Re: [ANNOUNCEMENT] ipset-2.3.1 released

[Jozsef Kadlecsik]

On Sat, 14 Jun 2008, pud wrote:

> thanks for that, but maybe it still needs a fix for building with glibc-2.8:
> 
> cc -O2 -Wall -Wunused -I/usr/src/linux/include -I.  -fPIC -o ipset_iphash.o -c ipset_iphash.c
> ipset_iphash.c: In function 'create_parse':
> ipset_iphash.c:71: error: 'UINT_MAX' undeclared (first use in this function)
> ipset_iphash.c:71: error: (Each undeclared identifier is reported only once
> ipset_iphash.c:71: error: for each function it appears in.)
> make: *** [ipset_iphash.o] Error 1
> 
> including limits.h fixes it of cause, but i'm not sure if that is a proper fix

I added the limits.h to the files which uses UINT_MAX. svn holds the fixed 
version, thank you the report.

Best regards,
Jozsef
-
E-mail  : kadlec@blackhole.kfki.hu, kadlec@mail.kfki.hu
PGP key : http://www.kfki.hu/~kadlec/pgp_public_key.txt
Address : KFKI Research Institute for Particle and Nuclear Physics
          H-1525 Budapest 114, POB. 49, Hungary

Re: [ANNOUNCEMENT] ipset-2.3.1 released

[ArcosCom Linux User]

Be carefull about 32/64 bits architectures, this macro value, perhaps, is
diferent depending on it.

Regards

El Mar, 17 de Junio de 2008, 10:07, Jozsef Kadlecsik escribió:
> On Sat, 14 Jun 2008, pud wrote:
>
>> thanks for that, but maybe it still needs a fix for building with
>> glibc-2.8:
>>
>> cc -O2 -Wall -Wunused -I/usr/src/linux/include -I.  -fPIC -o
>> ipset_iphash.o -c ipset_iphash.c
>> ipset_iphash.c: In function 'create_parse':
>> ipset_iphash.c:71: error: 'UINT_MAX' undeclared (first use in this
>> function)
>> ipset_iphash.c:71: error: (Each undeclared identifier is reported only
>> once
>> ipset_iphash.c:71: error: for each function it appears in.)
>> make: *** [ipset_iphash.o] Error 1
>>
>> including limits.h fixes it of cause, but i'm not sure if that is a
>> proper fix
>
> I added the limits.h to the files which uses UINT_MAX. svn holds the fixed
> version, thank you the report.
>
> Best regards,
> Jozsef
> -
> E-mail  : kadlec@blackhole.kfki.hu, kadlec@mail.kfki.hu
> PGP key : http://www.kfki.hu/~kadlec/pgp_public_key.txt
> Address : KFKI Research Institute for Particle and Nuclear Physics
>           H-1525 Budapest 114, POB. 49, Hungary
> --
> To unsubscribe from this list: send the line "unsubscribe netfilter" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

Re: [ANNOUNCEMENT] ipset-2.3.1 released

[Jozsef Kadlecsik]

On Tue, 17 Jun 2008, ArcosCom Linux User wrote:

> >> cc -O2 -Wall -Wunused -I/usr/src/linux/include -I.  -fPIC -o
> >> ipset_iphash.o -c ipset_iphash.c
> >> ipset_iphash.c: In function 'create_parse':
> >> ipset_iphash.c:71: error: 'UINT_MAX' undeclared (first use in this
> >> function)
> >> ipset_iphash.c:71: error: (Each undeclared identifier is reported only
> >> once
> >> ipset_iphash.c:71: error: for each function it appears in.)
> >> make: *** [ipset_iphash.o] Error 1

> Be carefull about 32/64 bits architectures, this macro value, perhaps, is
> diferent depending on it.

No, it holds the same value. ULONG_MAX (LONG_MIN/LONG_MAX) is different on 
32 and 64 bit modes.

Best regards,
Jozsef
-
E-mail  : kadlec@blackhole.kfki.hu, kadlec@mail.kfki.hu
PGP key : http://www.kfki.hu/~kadlec/pgp_public_key.txt
Address : KFKI Research Institute for Particle and Nuclear Physics
          H-1525 Budapest 114, POB. 49, Hungary

Re: [ANNOUNCEMENT] ipset-2.3.1 released

[Jan Engelhardt]

On Tuesday 2008-06-17 15:55, Jozsef Kadlecsik wrote:

>On Tue, 17 Jun 2008, ArcosCom Linux User wrote:
>
>> >> cc -O2 -Wall -Wunused -I/usr/src/linux/include -I.  -fPIC -o
>> >> ipset_iphash.o -c ipset_iphash.c
>> >> ipset_iphash.c: In function 'create_parse':
>> >> ipset_iphash.c:71: error: 'UINT_MAX' undeclared (first use in this
>> >> function)
>> >> ipset_iphash.c:71: error: (Each undeclared identifier is reported only
>> >> once
>> >> ipset_iphash.c:71: error: for each function it appears in.)
>> >> make: *** [ipset_iphash.o] Error 1
>
>> Be carefull about 32/64 bits architectures, this macro value, perhaps, is
>> diferent depending on it.
>
>No, it holds the same value.

The same value... currently, and on selected systems ;-)
(UINT_MAX is implementation dependent.)

Also, -I/usr/src/linux looks *very* wrong to me, there is reason
we have /usr/include/linux...

Re: [ANNOUNCEMENT] ipset-2.3.1 released

[Jozsef Kadlecsik]

On Tue, 17 Jun 2008, Jan Engelhardt wrote:

> >> Be carefull about 32/64 bits architectures, this macro value, perhaps, is
> >> diferent depending on it.
> >
> >No, it holds the same value.
> 
> The same value... currently, and on selected systems ;-)
> (UINT_MAX is implementation dependent.)

I'm not going to port ipset to other systems. Or do you imply UINT_MAX is 
implementation dependent on Linux? (Anyway, the successor of ipset is on 
the way... ;-)
 
> Also, -I/usr/src/linux looks *very* wrong to me, there is reason
> we have /usr/include/linux...

From the purists point of you, you are quite right. But ipset (userspace 
part + kernelspace part) - as it's "based" on patch-o-matic-ng - cannot be 
compiled without the kernel source. So -I/usr/src/linux is there as a 
fallback if the kernel source path is not defined explicitely.

Best regards,
Jozsef
-
E-mail  : kadlec@blackhole.kfki.hu, kadlec@mail.kfki.hu
PGP key : http://www.kfki.hu/~kadlec/pgp_public_key.txt
Address : KFKI Research Institute for Particle and Nuclear Physics
          H-1525 Budapest 114, POB. 49, Hungary