* [PATCH] net/netfilter/nf_conntrack_h323_main.c: logical-bitwise & confusion in process_setup()
@ 2008-03-11 8:48 Roel Kluin
0 siblings, 0 replies; 3+ messages in thread
From: Roel Kluin @ 2008-03-11 8:48 UTC (permalink / raw)
To: kaber; +Cc: netfilter-devel, netfilter, coreteam
logical-bitwise & confusion
Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
---
diff --git a/net/netfilter/nf_conntrack_h323_main.c b/net/netfilter/nf_conntrack_h323_main.c
index 6213787..898f192 100644
--- a/net/netfilter/nf_conntrack_h323_main.c
+++ b/net/netfilter/nf_conntrack_h323_main.c
@@ -842,7 +842,7 @@ static int process_setup(struct sk_buff *skb, struct nf_conn *ct,
set_h225_addr = rcu_dereference(set_h225_addr_hook);
if ((setup->options & eSetup_UUIE_destCallSignalAddress) &&
- (set_h225_addr) && ct->status && IPS_NAT_MASK &&
+ (set_h225_addr) && ct->status & IPS_NAT_MASK &&
get_h225_addr(ct, *data, &setup->destCallSignalAddress,
&addr, &port) &&
memcmp(&addr, &ct->tuplehash[!dir].tuple.src.u3, sizeof(addr))) {
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH] net/netfilter/nf_conntrack_h323_main.c: logical-bitwise & confusion in process_setup()
@ 2008-03-11 8:50 Roel Kluin
2008-03-11 13:59 ` Patrick McHardy
0 siblings, 1 reply; 3+ messages in thread
From: Roel Kluin @ 2008-03-11 8:50 UTC (permalink / raw)
To: kaber; +Cc: netfilter-devel, netfilter, coreteam
logical-bitwise & confusion
Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
---
diff --git a/net/netfilter/nf_conntrack_h323_main.c b/net/netfilter/nf_conntrack_h323_main.c
index 6213787..898f192 100644
--- a/net/netfilter/nf_conntrack_h323_main.c
+++ b/net/netfilter/nf_conntrack_h323_main.c
@@ -842,7 +842,7 @@ static int process_setup(struct sk_buff *skb, struct nf_conn *ct,
set_h225_addr = rcu_dereference(set_h225_addr_hook);
if ((setup->options & eSetup_UUIE_destCallSignalAddress) &&
- (set_h225_addr) && ct->status && IPS_NAT_MASK &&
+ (set_h225_addr) && ct->status & IPS_NAT_MASK &&
get_h225_addr(ct, *data, &setup->destCallSignalAddress,
&addr, &port) &&
memcmp(&addr, &ct->tuplehash[!dir].tuple.src.u3, sizeof(addr))) {
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-03-11 13:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-03-11 8:48 [PATCH] net/netfilter/nf_conntrack_h323_main.c: logical-bitwise & confusion in process_setup() Roel Kluin
-- strict thread matches above, loose matches on Subject: below --
2008-03-11 8:50 Roel Kluin
2008-03-11 13:59 ` Patrick McHardy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox