* [PATCH 5/6] NETFILTER: signed tcphoff for ipv6_skip_exthdr() retval
[not found] <480558CA.7090800@tiscali.nl>
@ 2008-04-16 16:00 ` Roel Kluin
2008-04-21 12:24 ` [netfilter-core] " Patrick McHardy
0 siblings, 1 reply; 2+ messages in thread
From: Roel Kluin @ 2008-04-16 16:00 UTC (permalink / raw)
To: Jan Engelhardt; +Cc: kaber, netfilter-devel, netfilter, coreteam, lkml
if tcphoff remains unsigned, a negative ipv6_skip_exthdr() return value will
go unnoticed,
Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
---
diff --git a/net/netfilter/xt_TCPOPTSTRIP.c b/net/netfilter/xt_TCPOPTSTRIP.c
index 3b2aa56..9685b6f 100644
--- a/net/netfilter/xt_TCPOPTSTRIP.c
+++ b/net/netfilter/xt_TCPOPTSTRIP.c
@@ -90,7 +90,7 @@ tcpoptstrip_tg6(struct sk_buff *skb, const struct net_device *in,
const struct xt_target *target, const void *targinfo)
{
struct ipv6hdr *ipv6h = ipv6_hdr(skb);
- unsigned int tcphoff;
+ int tcphoff;
u_int8_t nexthdr;
nexthdr = ipv6h->nexthdr;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [netfilter-core] [PATCH 5/6] NETFILTER: signed tcphoff for ipv6_skip_exthdr() retval
2008-04-16 16:00 ` [PATCH 5/6] NETFILTER: signed tcphoff for ipv6_skip_exthdr() retval Roel Kluin
@ 2008-04-21 12:24 ` Patrick McHardy
0 siblings, 0 replies; 2+ messages in thread
From: Patrick McHardy @ 2008-04-21 12:24 UTC (permalink / raw)
To: Roel Kluin; +Cc: Jan Engelhardt, coreteam, netfilter, netfilter-devel, lkml
Roel Kluin wrote:
> if tcphoff remains unsigned, a negative ipv6_skip_exthdr() return value will
> go unnoticed,
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-04-21 12:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <480558CA.7090800@tiscali.nl>
2008-04-16 16:00 ` [PATCH 5/6] NETFILTER: signed tcphoff for ipv6_skip_exthdr() retval Roel Kluin
2008-04-21 12:24 ` [netfilter-core] " Patrick McHardy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox