Linux Netfilter discussions
 help / color / mirror / Atom feed
From: "Gilad Benjamini" <gilad.benjamini@gmail.com>
To: 'Christoph Paasch' <christoph.paasch@gmail.com>,
	'Gilad Benjamini' <gilad.benjamini@gmail.com>
Cc: netfilter@vger.kernel.org
Subject: RE: INVALID state
Date: Thu, 13 Nov 2008 14:34:30 -0800	[thread overview]
Message-ID: <491cab7d.27b38c0a.772a.42ee@mx.google.com> (raw)
In-Reply-To: <200811132331.08821.christoph.paasch@gmail.com>

Back to my original question then: what is the rule of thumb ?
In other words, for a non-programmer reading proper documentation, how would
the documentation describe INVALID ?

> -----Original Message-----
> From: netfilter-owner@vger.kernel.org [mailto:netfilter-
> owner@vger.kernel.org] On Behalf Of Christoph Paasch
> Sent: Thursday, November 13, 2008 2:31 PM
> To: Gilad Benjamini
> Cc: netfilter@vger.kernel.org
> Subject: Re: INVALID state
> 
> Hi,
> 
> On Thu November 13 2008, Gilad Benjamini wrote:
> > - init_conntrack calls l4proto->new. If a zero value is returned,
> > nf_conntrack_free is called and the packet's connection is considered
> > INVALID
> In fact, the packet isn't marked "INVALID", there is just xt_state.c,
> who
> detects an invalid packet, if nf_ct_get(...) returns 0 or null. Which
> means,
> that skb->nfct == NULL. Which in turn means, that nf_conntrack_in
> doesn't
> assigned a connection to the packet.
> 
> And that will be the case, if any of these calls return a negative
> value (take
> a look at nf_conntrack_in and the functions it's calling):
> l3proto->get_l4proto
> l3proto->pkt_to_tuple
> l3proto->invert_tuple
> l4proto->error
> l4proto->pkt_to_tuple
> l4proto->invert_tuple
> l4proto->new
> l4proto->packet
> nf_conntrack_alloc
> 
> So, there can be A LOT of cases, where conntrack detects an invalid
> packet...
> 
> --
> Christoph Paasch
> 
> www.rollerbulls.be
> --
> --
> To unsubscribe from this list: send the line "unsubscribe netfilter" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


  reply	other threads:[~2008-11-13 22:34 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-13 18:16 INVALID state Gilad Benjamini
2008-11-13 22:31 ` Christoph Paasch
2008-11-13 22:34   ` Gilad Benjamini [this message]
2008-11-13 23:01     ` Christoph Paasch
  -- strict thread matches above, loose matches on Subject: below --
2010-02-28  9:24 Nemeth Denes
2010-02-28 10:10 ` Mart Frauenlob
2010-02-28 10:52   ` Nemeth Denes
2010-02-28 11:15     ` Mart Frauenlob
2008-11-12 22:08 Gilad Benjamini
2008-11-13 11:13 ` Thomas Jacob
2008-11-13 12:16   ` Christoph Paasch
2008-11-13 12:48     ` Thomas Jacob
2008-11-13 13:08       ` Christoph Paasch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=491cab7d.27b38c0a.772a.42ee@mx.google.com \
    --to=gilad.benjamini@gmail.com \
    --cc=christoph.paasch@gmail.com \
    --cc=netfilter@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox