From: Al Viro <viro@zeniv.linux.org.uk>
To: Gao Xiang <hsiangkao@linux.alibaba.com>
Cc: Christian Brauner <brauner@kernel.org>,
David Howells <dhowells@redhat.com>,
Baokun Li <libaokun1@huawei.com>,
Jeffle Xu <jefflexu@linux.alibaba.com>,
netfs@lists.linux.dev, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] get rid of close_fd() misuse in cachefiles
Date: Mon, 3 Jun 2024 04:40:55 +0100 [thread overview]
Message-ID: <20240603034055.GI1629371@ZenIV> (raw)
In-Reply-To: <49210e35-1cca-4d5a-a099-5a2d7b0390d0@linux.alibaba.com>
On Mon, Jun 03, 2024 at 10:33:38AM +0800, Gao Xiang wrote:
> > Anyway, your variant seems to be correct; feel free to slap my
> > ACKed-by on it.
>
> Hi Christian, would you mind take Al's ack for this, and
> hopefully upstream these patches? Many thanks!
FWIW, another thing that would be nice to have there is
removal of now-pointless include on linux/fdtable.h
next prev parent reply other threads:[~2024-06-03 3:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-03 0:11 [PATCH] get rid of close_fd() misuse in cachefiles Al Viro
2024-06-03 1:53 ` Gao Xiang
2024-06-03 2:21 ` Al Viro
2024-06-03 2:33 ` Gao Xiang
2024-06-03 3:40 ` Al Viro [this message]
2024-06-03 6:23 ` [PATCH] cachefiles: remove unneeded include of <linux/fdtable.h> Gao Xiang
2024-06-03 13:39 ` (subset) " Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240603034055.GI1629371@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=brauner@kernel.org \
--cc=dhowells@redhat.com \
--cc=hsiangkao@linux.alibaba.com \
--cc=jefflexu@linux.alibaba.com \
--cc=libaokun1@huawei.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=netfs@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox