From: Gao Xiang <hsiangkao@linux.alibaba.com>
To: Al Viro <viro@zeniv.linux.org.uk>,
David Howells <dhowells@redhat.com>,
Baokun Li <libaokun1@huawei.com>
Cc: Jeffle Xu <jefflexu@linux.alibaba.com>,
netfs@lists.linux.dev, linux-fsdevel@vger.kernel.org,
Christian Brauner <brauner@kernel.org>
Subject: Re: [PATCH] get rid of close_fd() misuse in cachefiles
Date: Mon, 3 Jun 2024 09:53:26 +0800 [thread overview]
Message-ID: <80e3f7fd-6a1c-4d88-84de-7c34984a5836@linux.alibaba.com> (raw)
In-Reply-To: <20240603001128.GG1629371@ZenIV>
Hi Al,
On 2024/6/3 08:11, Al Viro wrote:
> fd_install() can't be undone by close_fd(). Just delay it
> until the last failure exit - have cachefiles_ondemand_get_fd()
> return the file on success (and ERR_PTR() on error) and let the
> caller do fd_install() after successful copy_to_user()
>
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
It's a straight-forward fix to me, yet it will have a conflict with
https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git/commit/fs/cachefiles?h=vfs.fixes&id=4b4391e77a6bf24cba2ef1590e113d9b73b11039
https://lore.kernel.org/all/20240522114308.2402121-10-libaokun@huaweicloud.com/
It also moves fd_install() to the end of the daemon_read() and tends
to fix it for months, does it look good to you?
Thanks,
Ga Xiang
next prev parent reply other threads:[~2024-06-03 1:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-03 0:11 [PATCH] get rid of close_fd() misuse in cachefiles Al Viro
2024-06-03 1:53 ` Gao Xiang [this message]
2024-06-03 2:21 ` Al Viro
2024-06-03 2:33 ` Gao Xiang
2024-06-03 3:40 ` Al Viro
2024-06-03 6:23 ` [PATCH] cachefiles: remove unneeded include of <linux/fdtable.h> Gao Xiang
2024-06-03 13:39 ` (subset) " Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80e3f7fd-6a1c-4d88-84de-7c34984a5836@linux.alibaba.com \
--to=hsiangkao@linux.alibaba.com \
--cc=brauner@kernel.org \
--cc=dhowells@redhat.com \
--cc=jefflexu@linux.alibaba.com \
--cc=libaokun1@huawei.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=netfs@lists.linux.dev \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox